- 04 Mar, 2020 20 commits
-
-
Alex Newcomer authored
This was broken a while ago but went unnoticed. We should show the back button, pointing downwards, so users can get out of the ime VK. Also we should show the in-app shelf to hide the apps. Bug: 1058149 Change-Id: I170f1c24fc405d7ff322ada5a9816cde4e198078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083758Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#746610}
-
Anand K. Mistry authored
ChromeAsyncExtensionFunction is deprecated and its behaviour is not well documented. Migrating to ExtensionFunction allows the function's result behaviour to be more explicitly defined. Bug: 634140 Change-Id: I1be112d7c1188c698650e9ecbf2ac5e88c45f3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066502 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#746609}
-
Darren Shen authored
Change-Id: I1ed54d34f2cc2b81078144facb47941405702d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082653Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#746608}
-
Yulun Wu authored
Bug: 991767 Change-Id: I26ba9da8a01a20efed9634cf9a8c462b14b999d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084719 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746607}
-
Jinsong Fan authored
According to http://crrev/c/1742171, Java AwQuotaManagerBridge is not a singleton and owned by Java AwBrowserContext. The JNI GetDefaultNativeAwQuotaManagerBridge is no longer used. Bug: None Change-Id: I4714c9a703ccbddf62b9667dde3e4a2cde5bda74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082870Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#746606}
-
Bettina authored
SBER and Standard protection are offered by Enhanced Protection. To prevent multiple places checking enhanced protection, one check is added into the pref service and all other code calls the code. Bug: 1057191 Change-Id: Ic79b9acb17578eaa32dac47178cb48903864ae7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083863 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#746605}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ccefde95b3bb..40d8cb5fc0ae git log ccefde95b3bb..40d8cb5fc0ae --date=short --first-parent --format='%ad %ae %s' 2020-03-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 20a0a16e..0380a339 (746350:746487) Created with: gclient setdep -r src/third_party/webrtc@40d8cb5fc0ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6c8d6f9786e06ccad77c785b35170e4f4fa68524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085194Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746604}
-
Hiroki Sato authored
This CL cleans up the a11y bounds computations in ARC++; - Aggregate the bounds computation logic inside AccessibilityInfoDataWrapper. - Explicitly use |offset_container_id| of AXRelativeBounds. _ Keep the device scale factor in AXTreeSourceArc. Set and update it from ArcAccessibilityHelperBridge. This CL also fixes the bounds computation of notification window and input method window, which were currently not adjusted by device scaling. Bug: b:147707554 Test: manual. Open PlayStore, change device scale factor by Ctrl +/-, bounds are correct. Test: manual. Open TalkBack-test app, create notification windows, bounds are correct. Change-Id: Ie5f6904fcf8c18fd86d9fc1e99a1db7970a14be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066411 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#746603}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e3e152bd3a29..970291c5e024 git log e3e152bd3a29..970291c5e024 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 jarhar@chromium.org Improved cookie blocked reason ui strings 2020-03-03 sigurds@chromium.org [COEP] Report detailed blocked reason for requests blocked by COEP Created with: gclient setdep -r src/third_party/devtools-frontend/src@970291c5e024 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051466 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I90102f67410ada7ef85ddf0f97ba6a82f56718e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085179Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746602}
-
Matt Menke authored
Previously, when idle sockets were closed by the socket pool, there was no information as to why (Closed by remote side, received data unexpectedly, low memory notification, flushing socket pools with an error, etc). This CL adds an event that logs a text string when the socket pool closes a socket, which should help debug sockets cases where sockets are unexpectedly closed. Bug: 1054186 Change-Id: Id4db0394b006ab434b3548a521bf6d7b324e145f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067684 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#746601}
-
Noel Gordon authored
Make the Files app window frame white in files-ng. The frame color of Video Player, Gallery, and Audio Player are not changed. Minor: Fix var/let/const pre-submit nits. Add eslint var exception to the var loader = {} ... line, since per the patchset #1 try jobs, the KeyboardOperations/FilesAppBrowserTest*/keyboardOpenNewWindow* tests fail if const (or let) is used instead of var. Bug: 1057918 Change-Id: Ic7beb58e34b9d152bff90de1c775d7dd16442a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084335Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#746600}
-
Xing Liu authored
UserLevelMemoryPressureSignalGeneratorTest.GenerationPauses is failing on some Android builders. This CL disables it. TBR=slangley@chromium.org Bug: 1058178 Change-Id: I5bbee637ee9a23589bfe7d5c0be93406bf372c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086311Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746599}
-
Nektarios Paisios authored
R=aleventhal@chromium.org, dmazzoni@chromium.org Change-Id: I2b26abd652e0797e70ad3c869ff2f1ad922b3152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085115 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#746598}
-
Michael Sun authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/a4d130010ec6..2302d21944c8 $ git log a4d130010..2302d2194 --date=short --no-merges --format='%ad %ae %s' 2020-02-20 kevinptt runtime_probe: Modify probing type of wireless 2020-02-29 michaelfsun system_api: Add CRAS media player D-Bus constants 2020-02-26 juwa vm_tools: add extensions to Application message Created with: roll-dep src/third_party/cros_system_api Bug: b:147365563 Change-Id: Ieee9f156c4a834b8f71ce2bd34cd8713c1a670cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081187Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Michael Sun <michaelfsun@google.com> Cr-Commit-Position: refs/heads/master@{#746597}
-
Eric Willigers authored
CreateAppIdLaunchParamsWithEventFlags is used by system web apps. We move the function from extensions to app service, eliminating a dependence of web apps on extensions/ code. Change-Id: Ie406bdd4aa0e69752d5ad671925310a11da29e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082669Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#746596}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f096a8f4. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I5302bf94f97bafb0111ec63d2647f041b25f86ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084833Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746595}
-
Robert Sesek authored
It has launched and landed, so the sandbox should be unconditionally enabled. Bug: 915910 Change-Id: I89d2dcd3788e0570bce7c632349706ad6c73810f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085112Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#746594}
-
zhaoyangli authored
A recent change made |get_launch_command| return an empty dict, which caused a none-empty check failure later. This change set some default fields in the dict as what was happening before. Bug: 1054989 Change-Id: Ib2cfeac297705eb4e20c40b923c30d20976b6852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083761 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746593}
-
John Abd-El-Malek authored
Fix Android crash in ChromeContentBrowserClient::CreateURLLoaderThrottles when a RenderFrameHost is shutting down. At that point It won't have a WebContents. Bug: 1056801 Change-Id: I1453f7484123157d8086b8b9964eb66f4d4ec1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085846Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#746592}
-
dalyk authored
Most tests involving the dropdown or custom input field have been moved to the new secure_dns_interactive_test.js as they involve testing for focus. This cl also re-enables CrSettingsSecureDnsTest.All, which was disabled when the flakiness was observed. Bug: 1040145,1057504 Change-Id: I7813849295ddf6a3ddc283a9cdd9416db64b8f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083760Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#746591}
-
- 03 Mar, 2020 20 commits
-
-
Frank Tang authored
Track misc features launched in 2019 to understand the impact. Also measure the v8BreakIterator usage of 'word' and 'line' to lobby the need for 'line' in the replacement standard Intl.Segmenter. Depending on https://chromium-review.googlesource.com/c/v8/v8/+/2067512 Bug: v8:10251 Change-Id: Ied744dc947986b4cdbec3f70c3eb6299cd58599c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078903Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#746590}
-
Ovidio Henriquez authored
This change adds an entry for Web Bluetooth permissions to Site Settings if the WebBluetoothNewPermissionsBackend flag is enabled. Bug: 601523, 563724 Change-Id: I0860e56132242c3ca59f0ee79e0b11337fd6d041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082322Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#746589}
-
Yulun Wu authored
Adds a switch to override minimal interval between showing user contextual nudges. Bug: 1055918 Change-Id: I71ae9c6ab5662336d6828f9af64cc98aad14c099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079537Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746588}
-
Nektarios Paisios authored
The use of ComPtr::GetAddressOf is banned see http://crbug.com/914910 Either the "&" operator or the ReleaseAndGetAddressOf method should be used. Also, the "CopyTo" method could be replaced with the "As" method which is easier to type and call. Bug: 914910 R=dmazzoni@chromium.org, kbabbitt@microsoft.com Change-Id: Ida82e35ecc16953b99e576fc62834b6c894e87ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083664 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#746587}
-
wutao authored
Remove unused code related to kEnableTextQueriesWithClientDiscourseContext. Bug: b/145218971 Test: manual Change-Id: Iceb7a5be8f0d95939542637fd17ebf2ac1648569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080819Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#746586}
-
Stephen Lin authored
R=pkasting@chromium.org Bug: 1058139 Change-Id: I5c57ce99769e9ae77022199c25ea1c7b47250bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085838 Auto-Submit: Stephen Lin <stephenlin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#746585}
-
Wenbin Zhang authored
Updating the owners of tracing_perftests. After synced with primiano@, setting the owners to eseckler@chromium.org and oysteine@chromium.org. Bug: chromium:1049256 Change-Id: I6c2269369e7ec5d9114e15fc915bd1b439841da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085832 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#746584}
-
Yusuf Sengul authored
Bug: 1038368 Change-Id: Ibc07bae9b5a3763ea88a6d070c5e159178a03a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086012 Auto-Submit: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#746583}
-
Gang Wu authored
Update recursivelyDeleteFile and batchDeleteFiles in FileUtils, so both of functions can take a filter function to check if the file can be deleted. Change-Id: I7f2cdc1182a8ad4111297d0529b1fdc8b31b462b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062914Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746582}
-
Ehimare Okoyomon authored
Add support and UI to disable incognito ntp toggle if that setting is managed. EnforcedByPolicy: https://screenshot.googleplex.com/BoEVngjYMsn.png EnforcedBySettings: https://screenshot.googleplex.com/21UPKQSmc31.png Bug: 1040091 Change-Id: Ie1f269af20a82025d4ec3d6f92e9c5e8b061f3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062445 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#746581}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/67cabcd71f8a..e1318818e6ab git log 67cabcd71f8a..e1318818e6ab --date=short --first-parent --format='%ad %ae %s' 2020-03-03 ehmaldonado@google.com gclient: Don't warn on Python 3 when GCLIENT_PY3=1 is set. Created with: gclient setdep -r src/third_party/depot_tools@e1318818e6ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ie8fe5aaa04b085461b16cb46065cc9b70eaf8908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746580}
-
John Palmer authored
Change-Id: I6419cab6c355a4021f9accb537e34d221f24abcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082735Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Auto-Submit: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#746579}
-
Hazem Ashmawy authored
Flags set via flags UI are not applied to ":webview_apk" processes. That's why simply checking CommandLine for flags only isn't sufficient in the devUi at the moment. Until this is fixed, we will connect to DeveloperMode ContentProvider to retrieve the overridden value of the crash uploads flag to show/hide crash consent error accordingly. Bug: 1051019 Test: Enable/Disable crash upload flag via commandline and the UI and check the error Test: Enable/Disable usage & diagnostics settings and check the error Change-Id: I3a0d31c0b17dc7fe302965132055deb90ae8ca74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080381 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#746578}
-
Daniel Rubery authored
The CSD model shows a warning without |callback| or |callback_thread| set, so when committed interstitials are enabled, we crash here in BaseUIManager::DisplayBlockingPage. This CL fixes that crash. Bug: 1058094 Change-Id: Id1dccced4fd4469ecf7f6f6bbc95d283550c98c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082323 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#746577}
-
Anand K. Mistry authored
Bug: 634140 Change-Id: I38b8ad3ec7c01c2dedbb65281d7d4541bd553688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078371 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#746576}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for fingerprint subpage and setup pin subpage from settings_strings.grdp to os_settings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I89540f7f26bdcf79503a26346a28842ed45befe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057115 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#746575}
-
Josh Simmons authored
Bug: 1040661 Change-Id: Ib9406209e2a8c5c3b753e4cd29b3faf20573f870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082320Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#746574}
-
Darwin Huang authored
Mechanical find/replace from "Trace(blink::Visitor* to Trace(Visitor*" Refactoring change only. No functional changes intended. Bug: 1051193 Change-Id: I60c4e11fb0d50be25c5dcc8a0d5ab854c0ff34c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084723 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746573}
-
Nina Satragno authored
This is a reland of 60d219b6 Temporarily bring back `adjusted_timeout` to make compiling internal android source happy. This will be followed up by a patch updating internal code and later the final removal of `adjusted_timeout`. Original change's description: > [webauthn] Don't adjust timeout when testing > > Move the timeout adjustment from blink to the browser and avoid > adjusting it if we detect a discovery factory override is in place. > > This change makes authenticator browser tests and WPTs 3X faster. > > Fixed: 976428 > Change-Id: Iaea88f356a6d090c14474151b29c04e912c471b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079043 > Commit-Queue: Nina Satragno <nsatragno@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Jared Saul <jsaul@google.com> > Cr-Commit-Position: refs/heads/master@{#746432} Change-Id: If79cd8e5e7add21bd20bc375628cee5f4c3b6e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084725Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#746572}
-
Markus Handell authored
https://chromium-review.googlesource.com/c/chromium/src/+/2033253 unfortunately did away with pause time compensation. This CL adds it back. Bug: 1057810 Change-Id: Iee553ca2e671739fa4ba794878ed09e5bf6954fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085251Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#746571}
-