- 03 Feb, 2020 40 commits
-
-
Marc Treib authored
TBR=chenwilliam@chromium.org Bug: 1044505 Change-Id: I18af5ad3da693eec837cbce5c21968f4b106a322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033073Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#737731}
-
anina koehler authored
When running tests from device_cloud_policy_manager_chromeos_unittest.cc, GMOCK warnings about uninteresting mock function calls are appearing. Similar to ConnectManager(), a helper method ShutdownManager() was created and expect calls for MockCloudExternalDataManagers Connect() and Disconnect() methods were added in the helper methods. Bug: 1046259 Change-Id: Ibb371bcf8bdaaf04974737f616e4081f8a994b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012281 Commit-Queue: Anina Koehler <aninak@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#737730}
-
Marc Treib authored
TBR=kylechar@chromium.org,agawronska@chromium.org Bug: 1048073 Change-Id: Ie3822f2e9be287f31222fc24b0010d97ae799b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033516Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0d9543d525ec..1863ec3f932b Created with: gclient setdep -r src-internal@1863ec3f932b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If9cec59d0492743f4586d6f698f6929863bff53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035363Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737728}
-
Jihwan Marc Kim authored
Existing PasswordManager::BuildSuggestions helper is quite convoluted, reorder the parameters. Bug: 1046756 Change-Id: I82e50d08954bae9f94268759800051c6eb20465f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032627Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#737727}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3610dd0daf0f..e27cd5339842 git log 3610dd0daf0f..e27cd5339842 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 aerotwist@chromium.org [e2e] Have Mocha resolve on end instead of suite end 2020-02-03 szuend@chromium.org [cleanup] Minor code cleanups in BreakpointManager Created with: gclient setdep -r src/third_party/devtools-frontend/src@e27cd5339842 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1047672 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifbbb6d36c189b8d6558c9f4925b7693ee18b2ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035367Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737726}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7b430041e7fc..784967be4d56 git log 7b430041e7fc..784967be4d56 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 ddrone@google.com Add a message for LatencyInfo.Flow Created with: gclient setdep -r src/third_party/perfetto@784967be4d56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: If697bb558f577e2368ef9ab3e75c46b71842e748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035366Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I7c8391cfd5f26de9a4aee4f2b223e913650f42fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033053 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#737724}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-4025.0-1580122052-benchmark-81.0.4019.0-r1 to 81-4025.0-1580122052-benchmark-81.0.4044.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0afd37e7c83ab1bb925e57c8b7365624df484aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035368Reviewed-by:
-
Saurabh Nijhara authored
This CL updates the update_required_dialog to handle cases for no network present, metered network, eol reached and update required. Bug: 944838 Change-Id: I5bf028251cbf88b5048697fcbc903faf2f665b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007642 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737722}
-
Rune Lillesveen authored
The html spec talks about script blocking stylesheets[1], but we do script blocking in body by pausing the html parser. The APIs for doing that for the XML parser had empty implementations which meant that querying style from a script after an external stylesheet resource would not wait for the stylesheet to load. [1] https://html.spec.whatwg.org/multipage/semantics.html#interactions-of-styling-and-scripting Bug: 1043944, 917116 Change-Id: I08422fa0608db8972154a8b19854906e154dfdd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012021 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#737721}
-
Oriol Brufau authored
Since r731964, if you clicked a ::marker originated by a ::before or ::after, and you read the 'path' property of the event, the first node in the array might be the ::before or ::after pseudo-element. Actually it was fine if you clicked the contents (text or image) of the ::marker. But it's possible to make the ::marker taller than its contents by setting a big 'line-height'. Then you could click inside the ::marker but outside its contents, and reproduce the problem. That was wrong, as described in pseudo_element.h, > Pseudo element are not allowed to be the inner node for hit testing. This patch fixes it by making PseudoElement::InnerNodeForHitTesting iterate ancestors until it finds one which is not a pseudo-element. Bug: 1048000, 457718 TEST=external/wpt/css/css-pseudo/marker-hit-testing.html Some checks fail in legacy because the marker ignores 'line-height'. Change-Id: I7bed7d0824638b0c7f4b63a744a3ca4978285445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030973Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#737720}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2dd9ed07760d..43a0a815b814 git log 2dd9ed07760d..43a0a815b814 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 cwallez@chromium.org Fix examples running with the wire. Created with: gclient setdep -r src/third_party/dawn@43a0a815b814 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I6ca96eb1c5fc6bfdda150e4b3be6f60629171f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035360Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds a base::Feature for the Password Check feature by renaming the existing Leak History feature that so far hasn't been used. It also adds logic to expose the feature to the Desktop settings. Bug: 1047726 Change-Id: Ieb5b29d1a3cee6cd866502864251d40cbf93ab8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033446 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Marc Treib authored
This reverts commit db4b7168. Reason for revert: New WebTime* tests are failing on MSan, crbug.com/1048043a Original change's description: > Adds WebTimeActivityProvider. > > This CL adds WebTimeActivityProvider which is > BrowserListObserver, a TabStripModelObserver, > AppServiceWrapper::EventListener, and > WebTimeNavigationObserver::EventListener. It is hosted > in AppTimeController. > > The instance of this class observes > the TabStripModel of each Browser in BrowserList. It also > observes the WebTimeNavigationObserver instances of each WebContent > hosted in each Browser window. The instance also observes > AppServiceWrapper to learn about the activation/deactivation of > chrome application windows. > > WebTimeActivityProvider informs its observers when Chrome becomes > Active, Active with whitelisted content or inactive. > > Bug: 1034551 > Change-Id: I7d7dd3624ea4fb764c13e35f0ef542759cee8933 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020522 > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737492} TBR=agawronska@chromium.org,yilkal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1034551, 1048043a Change-Id: Id065ff05c0b67ed514a034455c40a8ab71f7280e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033515Reviewed-by:
-
Nazerke authored
This CL only removes DCHECK of browserstate which is not used. Instead of that DHECK for browser is added as the coordinator is already using the initializer with a browser instance. Change-Id: I7094d68f7e6d3f235b34f49b9eec8bb126d76fb6 Bug: 1029346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033352Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#737716}
-
Kenichi Ishibashi authored
The reference was tentatively added to move some code from ServiceWorkerStorage to ServiceWorkerRegistry but it isn't needed any more. Bug: 1039200 Change-Id: I59ac327e120bfd82d87c3c81b95d6da3d629dd5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035230 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#737715}
-
Simon Zünd authored
This CL re-writes a breakpoint web test using a new SourcesTestRunner helper introduced in https://crrev.com/c/2027427. This should not only prepare the test for the upcoming source map asyncification but also reduce the overall flakiness of breakpoint web tests. This CL superseeds the current in-flight CL https://crrev.com/c/2022642 which will be abandoned. R=sigurds@chromium.org Bug: chromium:1032016 Change-Id: Id5bcd9d3913a2f83c029f52da33e484c61f0c9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030464Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#737714}
-
Nazerke authored
This CL modernizes the BadgePopupMenuCoordinator to use the superclass -initWithBaseViewController:browser: initializer. Also this CL updates showcase coordinator for Badge Popup Menu Coordinator. Bug: 1029346 Change-Id: Ib683cdb45452b90412e953a4c9a25495ef2389f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033161Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fed0dda178e6..326c900efd28 git log fed0dda178e6..326c900efd28 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src bd4b3a888fca..e85fe4c3cc9f (3 commits) 2020-02-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 79b36b640692..41a7302e9c62 (3 commits) Created with: gclient setdep -r src/third_party/angle@326c900efd28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: Iac9e6d7bbcf7ddc98031b792ff80a948552ad8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035166Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7e6ae2798c52..3610dd0daf0f git log 7e6ae2798c52..3610dd0daf0f --date=short --first-parent --format='%ad %ae %s' 2020-02-03 bmeurer@chromium.org [karma-tests] Add unit tests for StringOutputStream. Created with: gclient setdep -r src/third_party/devtools-frontend/src@3610dd0daf0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ida574cd6f54b514bc0efc91aca1536f6bdc2f126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035354Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5bec61a84538f758f48027e76ab428f48f2be953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035357Reviewed-by:
-
Owen Min authored
In chrome.enterprise.reportingPrivate.getDeviceInfo API, screen lock secured flag now check if user has password on Windows. The code behavior matches SecureConnect native host: 291830502 Bug: 1047785 Change-Id: Iffc94d9cf179f85f353b8d245b90f5dd759c4bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031703 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#737709}
-
Marc Treib authored
TBR=yaoxia@chromium.org Bug: 1047921 Change-Id: I5883ab91335fb7faa0a7ee45d93b5535b2cca794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033513Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ibead71c45e5608fa4692174a01a84c117834fca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033050 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
NewResourceId() is going to be asyc and it wouldn't be trivial to use a test util, CreateServiceWorkerRegistrationAndVersion, which runs synchronously. Since users of this util function don't require actual ID assignments, we can make call sites to pass pseudo resource IDs. This CL changes CreateServiceWorkerRegistrationAndVersion() to take a ID instead of using NewResourceId(). Bug: 1046335 Change-Id: I78ed239b652b0ba6ac09ab808566a0d199e8110a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032449 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737706}
-
sandromaggi authored
Our test card expired after January 2020. Bug: 1048074 Change-Id: I65a604154c2eb05c036c85440f51f533f48f1ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033768 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#737705}
-
Rune Lillesveen authored
Whether we mark a node for kLocalStyleChange or kSubtreeStyleChange is essential information. Change-Id: I08241b3b319d11d0244bc10f458fb2a47ebf2359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033245 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#737704}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/64e691680849..0d9543d525ec Created with: gclient setdep -r src-internal@0d9543d525ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie2bcc97cfcd06c2c0d61fda99004e0f509eb1e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035167Reviewed-by:
-
Guido Urdaneta authored
This reverts commit 80d89eb4. Reason for revert: The TSAN failure is a more general failure affected lots of test. It's not specific to this test. Once the general problem is fixed, this test should stop flaking. Original change's description: > Disable flaky WebRtcMediaRecorderTest.StartAndDataAvailable on TSAN > > Bug: 1043828 > Change-Id: I41db446ceec894c06b15c40a673f290f8ba2e533 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030886 > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Armando Miraglia <armax@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736876} TBR=guidou@chromium.org,armax@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1043828 Change-Id: Ib06dd710488a087ab24c409691107c7c1360dfad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033767Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#737702}
-
Yuki Shiino authored
As a preparation of https://crrev.com/c/1996111 , relaxes the return type of ScriptWrappable::Wrap from v8::Local<v8::Object> to v8::Local<v8::Value> so that it can return v8::Null in addition to v8::Object. Change-Id: I453c405d62f4deef8bcf3bddcc59aa80a56c46d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032552Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#737701}
-
Luciano Pacheco authored
Bug: 992821 Change-Id: I7a4be8b64b4ba410b24e73a00add654d8e91f418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029473 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737700}
-
Guido Urdaneta authored
This reverts commit 3a45f157. Reason for revert: This ASAN/TSAN failure is a more general failure not specific to this test. Re-enabling, since the issue should be fixed when the more general problem is fixed. Original change's description: > Disable flaky WebRtcMediaRecorderTest.ResumeAndDataAvailable on TSAN/ASAN > > Bug: 1045381 > Change-Id: I285a44d32d47522786b1676b708b0723f336295b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031144 > Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736883} TBR=guidou@chromium.org,marinaciocea@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1045381 Change-Id: I02b5189bfbd2bcceb9ad8f01cda5c70b86146ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035370Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#737699}
-
Matt Falkenhagen authored
It is failing on the builders. Bug: 1048074 Change-Id: I7c88b0cc43ff5be0229d3d06a7e8e488c75b879a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032633Reviewed-by:
-
Kenichi Ishibashi authored
There were three ScheduleDeleteAndStartOver() calls in ServiceWorkerStorage which we couldn't simply move to ServiceWorkerRegistry as these are callbacks of internal operations. This CL replaces these ScheduleDeleteAndStartOver() with Disable() and makes ServiceWorkerRegistry schedule a recovery process when the next public operation is performed (the next operation will fail because the storage is disabled, then the registry tries to recover). This slightly changes the existing behavior but I don't think this change has a real world impact given that the low error rates of storage. Bug: 1039200 Change-Id: Iec112cf6690de4d68c3498282736a5f564924d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034385 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#737697}
-
Kenichi Ishibashi authored
This method puts resource id assignment and response writer creation together so that call sites don't have to assign a resource id explicitly for new resources. See the linked bug for the context of this change. Bug: 1046335 Change-Id: Id8e282ad57af99ce3833cc2285d6b3057ac2da43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032631 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Change-Id: Iffccaa069401f150ed6772a94eec0a52693db416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032761Reviewed-by:
-
Yuki Shiino authored
- Turn ArrayBufferView into a built-in type (was a union of all typed arrays) - Remove flattened_member_types_in_original_order (turned out that there was no need to flatten unions) Bug: 839389 Change-Id: I1a6eecf217b1d8021b6e7b5b520500f43c57fb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032695Reviewed-by:
-
Luciano Pacheco authored
Resize the icons in the file list from 16x16 to 20x20 and overwrite all icons for new style. Check mark and folder icons use mask-image to follow the font color: Folder has to be the same grey, instead of its black color and check mark has to switch from blue to grey when it doesn't have the focus. When the file list is in the multi-select mode (body.check-select) background and image mask are reset so they aren't visible behind the check mark icon. Bug: 992821 Change-Id: I9314e4b0f93778e046c0fa746a55bfcb8e516340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029558 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0b016536ab1f..6ce875a55578 git log 0b016536ab1f..6ce875a55578 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 dberris@google.com Remove old change-detection algorithm Created with: gclient setdep -r src/third_party/catapult@6ce875a55578 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:922256 Tbr: crouleau@chromium.org Change-Id: Ieaf9fdea60769516f3076dfc9c50ad4c068d7631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035157Reviewed-by:
-
