- 23 Jun, 2020 40 commits
-
-
Etienne Pierre-doray authored
Possible race when Join(): - thread A: Join: worker_released_condition_->Wait() - thread C: WillRunTask: GetMaxConcurrency() returns > 0 - thread B: already running, finishes all the work GetMaxConcurrency() goes 0 - thread B: DidProcessTask: worker_released_condition_->Signal(), - thread A: Join returns (GetMaxConcurrency() is 0) - thread C: TryIncrementWorkerCountFromWorkerRelease worker count goes 1 - thread C: runs worker_task after Join To fix race when Joining, all writes to |state_| are protected by |worker_lock|. Memory ordering is no longer necessary. Alternative: cancel before Join returns with a compare and swap and loop again if new workers. Change-Id: I4e478ffae2bdaec56386739f78de089d0e74e42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248159 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#781453}
-
zhaoyangli authored
Set form factors and iOS versions exactly the same as the union of ios-simulator and ios-simulator-full-configs CQ builders. This is because a unit test in iOS 12 is failing and we need to gather more accurate data before running coverage in CQ. Bug: 1090188 Change-Id: I0875469c874e8745da3f3c1a23d25dbe6297a63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258899Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#781452}
-
Hidehiko Abe authored
This CL sets up an empty LacrosChromeService in lacros-chrome, and connects to it from ash-chrome. BUG=chromium:1094106 TEST=Ran locally. Change-Id: Ie5ae843319d05c249ce33bbe8505fcee43899499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246121 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#781451}
-
Daniel Rubery authored
This test became flaky due to an uninitialized variable introduced by https://chromium-review.googlesource.com/c/chromium/src/+/2249162 This was fixed by https://chromium-review.googlesource.com/c/chromium/src/+/2253759 Fixed: 1096975 Change-Id: I659848f1bb82b30f3debd4370a1b6640b72c12a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254349 Auto-Submit: Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#781450}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d15ec1eec289..089f7a6b11cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC chanli@google.com,csharp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1096382 Tbr: chanli@google.com,csharp@google.com Change-Id: Ib120d756bf02c3d15381d693576a28321b937430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260917Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781449}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ead457578785..8dbca52cb29a 2020-06-23 joselea@microsoft.com Re enable memory test 2020-06-23 joselea@microsoft.com Logic to log event for panel closed. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1074732,chromium:1086641 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8edac18f7a1e7053d1aa01c8cfb96386a1112491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260922Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781448}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fc6f3bb6. With Chromium commits locally applied on WPT: ee0c101e "[COOP] access reporting toward the opener." c98dba7e "[COOP] access reporting. Improves tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I7c90ebcfa58061b3b14385ba7ab8ba199e195583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260396Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781447}
-
Jeremy Leconte authored
Bug: 1093406 Change-Id: If12b3273af093a5ae43bc5d001bfd661de55a12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260657 Commit-Queue: Jeremy Leconte <jleconte@google.com> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#781446}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 70 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-12-20. TBR=chromium-metrics-reviews@google.com Change-Id: I1898b00b3258df5a378cfa4faf00586edc04a0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261054Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#781445}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d8ac1d219713..b47cc50aadb6 2020-06-23 amaiorano@google.com Enable validation layer custom extensions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Ie09a5c4be3573f1f17d3ed518d1065e5929da402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260914Reviewed-by:
-
Mike Wittman authored
Disabling until we can make the profiler work on this version to avoid crashes. Bug: 1098119 Change-Id: I88194799e3e8d6635a055ca3ac4b38b8103b14b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261133Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#781443}
-
Thomas Tellier authored
On login/lock screen, enterprise management disclosure is shown for child accounts due to a confusion in the code between management and enterprise management. Bug: 1093934 Change-Id: I8cb12dc9342290937da2939a8cd14f7eefbf4895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254278Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#781442}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2eb3c17ba30a..43a6e176a60f 2020-06-23 jvanverth@google.com Reland "Reland "Fill in GrD3DGpu::onUpdateBackendTexture"" 2020-06-23 fmalita@chromium.org Fix public.bzl formatting 2020-06-23 johnstiles@google.com Reduce calls to `addColorFragmentProcessor` in GrPaint creation. 2020-06-23 egdaniel@google.com Add api to GrVkMemoryAllocator to return VkResult from allocate calls. 2020-06-23 fmalita@chromium.org Add SkottieUtils src/hdr defines to public.bzl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I0f5faea44f009e3a8dcad1080e45990e6989bc3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260919Reviewed-by:
-
Andres Calderon Jaramillo authored
CL:2246846 modified the VaapiVideoDecodeAccelerator to use BufferAllocationMode::kNone for H.264 on Gemini Lake or later. However, for older devices, it started using kSuperReduced mode which caused widespread failures on resolution change tests. This CL brings back the original fallback to kReduced for H.264 which shouldn't have been removed in the previous CL anyway. Bug: b:159661743, b:159659506, 910986, 1054097 Test: video.DecodeAccel.h264_resolution_switch on pyro & caroline. Test: video.Seek.switch_h264_alt on pyro & caroline. Change-Id: I3eb883b8d68c60469751db4a12049ab56e60a0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260937 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#781440}
-
Natalie Chouinard authored
This layout is already set by the PreferenceTheme, and re-setting it here was unintentionally overriding a custom layout used by Account Management. This fixes a ~1dp UI regression introduced by crrev.com/c/1668628. See bug for screenshots and additional detail. Bug: 1097375 Change-Id: If2b2d2fa9ba74e8ce5e5ced1344dbaadecd63bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255221Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#781439}
-
Robert Ogden authored
Domain Reliability Uploads, Web Reports, Certificate Reporting, etc all pose a risk of being a privacy leak in the context of an isolated prerender. They are all explicitly disabled. Note: All of these are disabled by default so this CL doesn't change any behavior, but it does make the impl much more future-proof. Bug: 1096109 Change-Id: I3a4b8f30994ad00de79bdec18482e959f31a1c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248757Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#781438}
-
Xinghui Lu authored
To make sure the cache does not take too much memory, we'd like to know how many real time URL verdicts are stored in cache manager. Also fix a bug on stored_verdict_count_real_time_url_check_ calculation. Add a unit test to capture the bug. Metrics added in this CL: SafeBrowsing.RT.CacheManager.RealTimeVerdictCount Bug: 1096627 Change-Id: I6ae425e7ca7c9cfa1cd3460954d1b0cd3a06a25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253217Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781437}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592917001-f92b525a65d0a85552634ba3f6ed8ed822d9ee38.profdata to chrome-win64-master-1592924274-08d5db635b74d1eb292c1b13837063587fddd457.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5e3a09bea74901788c8421bb2f8bbb02291eb48a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260915Reviewed-by:
-
Chris Sharp authored
TBR=kevers@chromium.org Bug: 1098371 Change-Id: Icecf1008037f27ddf37deccf6f0943a0a3d4c587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260855Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#781435}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/62f76f09dd6f..d724122c7d1e 2020-06-23 fmayer@google.com Test custom allocator. 2020-06-23 fmayer@google.com Do not use NoDestructor. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:141241849 Tbr: perfetto-bugs@google.com Change-Id: I85c59f151c78148f8f3c224f999789f474c8efb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260913Reviewed-by:
-
Natalie Chouinard authored
Replace all usages of NativeLibraryTestRule with NativeLibraryTestUtils and remove NativeLibraryTestRule. This change can land after https://crrev.com/i/3123153 has landed and rolled. Bug: 1096666 Change-Id: I20fbf4e8f4ce40f823ab3cabb196ed7123f1ef95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252941Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#781433}
-
Kyle Horimoto authored
Previously, we would always show settings search results for "Connect", "Disconnect", "Pair", and "Unpair", even if there were no available devices to perform those functions. Now, we only show those search results if they are applicable. In addition, this makes the search results seem much less noisy when searching for "Bluetooth". Fixed: 1094364 Change-Id: I88f22b3f11667a3aae66da469d4accf3526246e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255021Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#781432}
-
Christian Biesinger authored
As discussed in https://github.com/w3c/csswg-drafts/issues/5032 R=ikilpatrick@chromium.org Bug: 1093094, 1045668 Change-Id: Ic73428aef3a6cf426064e4b3824cfc5649e7c0c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241645 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#781431}
-
Chris Sharp authored
This reverts commit 8c0f99be. Reason for revert: CreativeOriginAdsPageLoadMetricsObserverBrowserTest.CreativeOriginStatusNoCreativeDesignated is flaky See crbug.com/1098373 Original change's description: > Ad metrics: Add heuristic to estimate proportion of ad frames throttled. > > Our CreativeOriginStatus metric is recorded as unknown for approximately > 70% of ads. We want to see how much of this indeterminacy is due to > frame throttling, so we add another histogram that splits by whether > there is any unthrottled frame in the ad frame tree. > > The CreativeOriginStatus metric relies on FCP, which for cross-origin > frames can be very large. This is partially due to the flow where: a > frames starts outside the viewport and is throttled; frame is later > scrolled into the viewport, becomes unthrottled; frame receives FCP. > > Because paint-timings are relative to navigation start for the frame, > the values are skewed. This change propagates some additional info, a > best-effort timestamp of when a frame is first not throttled, up to the > browser process to address this. > > Continuation of > https://chromium-review.googlesource.com/c/chromium/src/+/2088037 > which had inexplicable trybot failures. This is the same code ported > into a fresh CL. > > Tests: > > third_party/blink/renderer/core:unit_tests > out/Default/blink_unittests > --gtest_filter=*PaintEligibility* > > chrome/test:unit_tests > --gtest_filter=*CreativeOrigin*Throttling > > chrome/test:browser_tests > --gtest_filter=*CreativeOrigin* > > Bug: 1049125 > Change-Id: I8c9ddd41870ce9797ff0f01de853f7576efd4606 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161606 > Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> > Reviewed-by: John Delaney <johnidel@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781029} TBR=kinuko@chromium.org,wangxianzhu@chromium.org,csharrison@chromium.org,npm@chromium.org,johnidel@chromium.org,cammie@chromium.org Change-Id: Ibff1ffc677a8f87d45d9245c41d937a3505ac342 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1049125,1098373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260430Reviewed-by:
-
Gang Wu authored
This reverts commit 3ed31ecf. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester/32796 Bug:1098417 Original change's description: > Switch RenderTests to use SkiaGold > > Switches all uses of RenderTestRule to use the SkiaGoldBuilder method > of constructing it, which results in all Android RenderTests being > backed by Skia Gold. > > Bug: 1057851 > Change-Id: I63d40faef7863dddb5edaa93aef8559eb4d3696d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248742 > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780931} TBR=boliu@chromium.org,twellington@chromium.org,wychen@chromium.org,peconn@chromium.org,bsheedy@chromium.org,tiborg@chromium.org Change-Id: I58bd6a0289cb496c62ae4b5556374ffcbfa333ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1057851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261178Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781429}
-
Martin Kreichgauer authored
This adds to new events to the WebAuthentication.CableV1DiscoveryEvent UMA histogram. kStartScanningFailed (12) indicates that BluetoothAdapter::StartDiscoverySession() was called but failed. kScanningStoppedUnexpectedly (13) indicates that after StartDiscoverySession() succeeded, the BluetoothAdapter notified the FidoCableDiscovery that the discovery session stopped due to some error. Both of those scenarios currently cannot be recovered from without the user manually retrying the entire request. Change-Id: Idfd4b9c2f45cb2eb9549caccdeea6c0463e77a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258468Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#781428}
-
Christopher Cameron authored
Introduce a viz::DisplayResourceProvider::ScopedOverlayLockGL structure, which mirrors the ScopedReadLockGL, except it specifies a mode of GL_SHARED_IMAGE_ACCESS_MODE_OVERLAY_CHROMIUM instead of the usual GL_SHARED_IMAGE_ACCESS_MODE_READ_CHROMIUM. This is ignored (and treated the same as READ) by all implementations, but the next patch will use OVERLAY in a way that would break if READ were specified. Bug: 1092155 Change-Id: I4e23d6514b67b1f9960a08d206cde0765928ae2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255880Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#781427}
-
Alexandre Courbot authored
frkoenig@ is one of the main owners of the Chrome OS/V4L2 parts. Add him to the OWNERS file. BUG=None TEST=None Change-Id: I53a3e3cf5816f7ae7ca529fcdf7de153d5a0e2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260095 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#781426}
-
Swapnil authored
ExtensionInstallEventLogManager class ties together collection, storage and upload of extension logs. This is used for event based reporting for policy based extensions. Bug: 1092838 Change-Id: Icad7e1dd6bd3994ea983452db1597a0eb655c576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247027 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#781425}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: I9486e42b29ffd00cf8d1ec0f214f5bcb9a273fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254324 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#781424}
-
Torne (Richard Coles) authored
In the browser process, store the current process name (i.e. the app's process name) in a crash key, so we can see which app process the crashes originate from in apps with multiple processes. In renderer processes this isn't relevant since the process name is always our own sandboxed process. Change-Id: I4e0ecb20c064cb06c8905938646c8927aa36b9e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252942 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#781423}
-
Brian Sheedy authored
Removes usage of //third_party/pymock from //tools in favor of the version provided by vpython. This is so that //third_party/pymock can eventually be removed. Bug: 1094489 Change-Id: I0d4b6484c9c44b93fb76613a3e194c3da811550d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255136Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781422}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 32 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-12-20. TBR=chromium-metrics-reviews@google.com Change-Id: Idd7bda836d27f35b773cd0b7f6cdafbb0891513a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261053Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/47124be594aa..e6867ba7c785 2020-06-23 jonross@chromium.org Peak Gpu Memory Ablation Telemetry If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:908462 Tbr: nuskos@google.com Change-Id: Ia8639c3485fc00177cf06b4ddd22efaff69a9292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260916Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/60aab5ad138e..ead457578785 2020-06-23 aerotwist@chromium.org [Performance] Retime markers against nav start records 2020-06-23 sigurds@chromium.org [issues] Add Heavy Ads issue 2020-06-23 kimanh@chromium.org Enable e2e test for wasm debugging after bugfix If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1091116,chromium:1095617,chromium:974550 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0966fd01b03af4010ffb6f277486fb27540951f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260833Reviewed-by:
-
Maggie Chen authored
1. Vulkan and DX12 info was automatically collected when the browser starts. Now we only collect and record DX12 info for UMA. 2. Dx12VulkanVersionInfo structure is removed. Vulkan and DX12 data and functions are now separated. 3. We still detect Vulkan version for about:gpu. 4. DX12 and Vulkan info is still tested in the info collection test of the gpu integration tests. Bug: 850881,863086 Change-Id: Idaabed2d572fa1dd0387cb04781a457843eb8416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252818Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#781418}
-
Mike West authored
We think that COOP and COEP are important isolation primitives that might give us the ability to expose more interesting APIs to developers without putting user data at risk. This CL adds a brief description and some links to the post-Spectre threat model doc to make that clear. Change-Id: I8657cbe158c46acf426b99c1b79643646604dd46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260655Reviewed-by:
Andrew Whalley <awhalley@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#781417}
-
Brandon Jones authored
This particular feature is moving more slowly than the rest of the lighting features, so we'll want to be able to toggle it separately. Bug: 1070819 Change-Id: I94af3008e347023d342296f0a96380139855b33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252841Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#781416}
-
sczs authored
In order to properly handle the life cycle of the DiscoverFeedVC the following changes are made: - Makes the DiscoverVC a ChildVC of the ContentSuggestionsVC and removes it on dealloc. - ContentSuggestionsCoordinator now owns the DiscoverFeedVC. - Adds isDiscoverItem method in ContentSuggestionsCollectionUpdater. Without these changes the DiscoverFeedVC is not properly dealloc-ed and might lead to some crashes. Bug: 1085419 Change-Id: If4b7c1e2ada6876c036527ac5eefdae020339327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258367 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#781415}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592913526-aa0369974c74051e60d9fc3c83a0a362a402bc87.profdata to chrome-win32-master-1592917001-0fc7f1d9ca8aa2b3be882f696f21c14836e980c4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I7f69d087650e174cbf91649764982f5e622bb435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260912Reviewed-by:
-
