GitLab

There is logic in the ClientSession/ClientContext which attempts
to drop a connection on the IO thread. Unfortunately, in doing so,
it called a thread-unsafe member getter within the call to PostTask.

This CL moves the getter into a helper method which runs entirely
on the IO thread.

R=nyquist@chromium.org,wez@chromium.org
CC=steimel@chromium.org
BUG=647814

Review-Url: https://codereview.chromium.org/2344893009
Cr-Commit-Position: refs/heads/master@{#419491}

Now that Attr never has childen, a Text node can't have an Attr parent,
and so the condition would always return true.

BUG=305105
R=tkent@chromium.org

Review-Url: https://codereview.chromium.org/2342163004
Cr-Commit-Position: refs/heads/master@{#419490}

Per https://codereview.chromium.org/2352693002/#msg11

BUG=None

Review-Url: https://codereview.chromium.org/2350173002
Cr-Commit-Position: refs/heads/master@{#419489}

controls.

In the future it might be desirable to remove some disabled color IDs
(like LabelDisabledColor) in favor of just applying this alpha at
callsites.

BUG=none

Review-Url: https://codereview.chromium.org/2346893002
Cr-Commit-Position: refs/heads/master@{#419488}

The GAIA ID is only necessary on Drive and should only be set there.
As the Mirror cookie doesn't have the granularity to only set it on Drive,
it is set on https://google.com instead.

BUG=647260

Review-Url: https://codereview.chromium.org/2343073002
Cr-Commit-Position: refs/heads/master@{#419487}

Use TYPE_DEFAULT message-loop for browser-tests, since that's what
mojo_runner uses by default. We would normally use TYPE_DEFAULT
message-loops for chrome --mash too, but keep using TYPE_UI for now,
since mojo:ui needs that, and it is not known whether mojo:ui will be
run at the type of the message-loop creation.

Also, remove references to MessagePumpMojo since that has been removed.

BUG=none
TBR=jam@ for base/threading/

Review-Url: https://codereview.chromium.org/2351603002
Cr-Commit-Position: refs/heads/master@{#419486}

https://chromium.googlesource.com/chromium/src/+/f7e6a1c1a

BUG=641338
TBR=rob.buis@samsung.com

Review URL: https://codereview.chromium.org/2348383002 .

Cr-Commit-Position: refs/heads/master@{#419485}

This CL implements ImageCapture's takePhoto() method by enqueueing a
callback every time the method is called. Check the queue when a new
frame is captured in DoCapture(), and execute callbacks with a blob
argument.

Add a new method GetPhotoBlob() to construct blob. If the source image
is originally in JPEG format, it's copied to blob directly. Otherwise
convert the source image to RGB format and encode it to PNG.

R=mcasas@chromium.org
BUG=646430
TEST=All tests in VideoCaptureDeviceTests passed.

Review-Url: https://codereview.chromium.org/2344123002
Cr-Commit-Position: refs/heads/master@{#419484}

This includes:
-switching NetErrorTabHelper to use the new WebContentsObserver navigation callbacks that work with PlzNavigate
-fixing NavigationHandle::IsErrorPage to return true for reloads of error pages

This fixes
DnsProbeBrowserTest.CorrectionsDisabled
DnsProbeBrowserTest.CorrectionsLoadStopped
DnsProbeBrowserTest.CorrectionsLoadStoppedSlowProbe
DnsProbeBrowserTest.Incognito
DnsProbeBrowserTest.NoInternetProbeResultWithBrokenCorrections
DnsProbeBrowserTest.NoInternetProbeResultWithSlowBrokenCorrections
DnsProbeBrowserTest.NxdomainProbeResultWithWorkingCorrections
DnsProbeBrowserTest.NxdomainProbeResultWithWorkingSlowCorrections
DnsProbeBrowserTest.ProbesDisabled
DnsProbeBrowserTest.SyncFailureWithBrokenCorrections
ErrorPageNavigationCorrectionsFailTest.FetchCorrectionsFails

BUG=504347,647859
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
R=clamy@chromium.org, juliatuttle@chromium.org

Review URL: https://codereview.chromium.org/2345913002 .

Cr-Commit-Position: refs/heads/master@{#419483}

These are flaky tests detected by chromium-try-flakes.appspot.com
Most of these have not flaked enough to trigger a bug yet, but they did
end up triggering an additional bog run, which is still bad.

BUG=619055
TBR=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2352713002
Cr-Commit-Position: refs/heads/master@{#419482}

In mustash we need to have some D-Bus clients in the ash window manager
process and some in the browser process. In traditional ash we need everything
in the browser process. Allow per-process initialization of subsets of clients.

* Split ownership of clients into DBusClientsBrowser, DBusClientsAsh and
DBusClientsCommon
* Make DBusThreadManager::Initialize() take a process enum. This isn't great,
but see code review comments
* Remove unnecessary setters from DBusThreadManagerSetter
* Use ash/DEPS to restrict which clients can be used in //ash
* Only initialize ash clients in ash_unittests
* When running in mustash, limit which clients are initialized in the ash
and browser processes

This is a transitional step toward cleaner multi-process initialization of
clients as discussed in go/chromeos-dbus-clients option (G)

BUG=644414,647367
TEST=chromeos_unittests, ash_unittests

Review-Url: https://codereview.chromium.org/2343993003
Cr-Commit-Position: refs/heads/master@{#419481}

https://pdfium.googlesource.com/pdfium.git/+log/ea3c3be83dae..c48089977dc4

$ git log ea3c3be83..c48089977 --date=short --no-merges --format='%ad %ae %s'
2016-09-19 dsinclair Revert of Pdfium: Fix fonts leaking on ClosePage. (patchset #10 id:180001 of https://codereview.chromium.org/2158023002/ )

BUG=79367,48791

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2350153002
Cr-Commit-Position: refs/heads/master@{#419480}

Revert of Force U.S. English keyboard layout for TextfieldTest.KeysWithModifiersTest (patchset #11 id:200001 of https://codereview.chromium.org/2197113002/ )

Reason for revert:
Tests are failing on Mac ASAN builder. See details here:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20(1)

First failed build:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/21876

Original issue's description:
> Force U.S. English keyboard layout for TextfieldTest.KeysWithModifiersTest
>
> BUG=633136
>
> Committed: https://crrev.com/19cb1e03c46a4df0c0fd54171369152bcb19c237
> Cr-Commit-Position: refs/heads/master@{#419454}

TBR=pkasting@chromium.org,chongz@chromium.org,sadrul@chromium.org,frankf@chromium.org,wez@chromium.org,samuong@chromium.org,tmoniuszko@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633136

Review-Url: https://codereview.chromium.org/2349253002
Cr-Commit-Position: refs/heads/master@{#419479}

This updates the Flag expectations for PlzNavigate, adding a test that
started failing, and removing several tests that no longer fail/exist.

BUG=576261

Review-Url: https://codereview.chromium.org/2348903002
Cr-Commit-Position: refs/heads/master@{#419478}

This fixes the following browser test for PlzNavigate:
  InProcessBrowserTest.ExternalConnectionFail

BUG=638596

Review-Url: https://codereview.chromium.org/2349893002
Cr-Commit-Position: refs/heads/master@{#419477}

BUG=639401

While fetching the original request, ScriptLoader sets a member flag.
On receiving notifyFinished for the original request, HTMLScriptRunner
creates a new ScriptLoader instance using the original Element with
another flag set to true. It then calls ScriptLoader::prepareScript which
further calls fetchScript. prepareScript sets the defer flag as LazyLoad and
fetchScript sets the intervention info and header in the resource request.
The intervention info is used to set the priority in ResourceFetcher::requestResource.

This CL also adds a link in the dev tools console warning.

Also added internals.getResourcePriority() for
the layout test to test that the new request goes out with priority very low.

The code was tested using netlog to verify the second request is sent and has
the correct priority (net::IDLE).
One of the example sites created by jkarlin@ is:
http://www.karlin.me/test/docwrite/

Review-Url: https://codereview.chromium.org/2260303002
Cr-Commit-Position: refs/heads/master@{#419476}

Using update-w3c-deps in Chromium 6c4ad338.

BUG=646837
R=rbyers@chromium.org

Review-Url: https://codereview.chromium.org/2341333002
Cr-Commit-Position: refs/heads/master@{#419475}

Using hard-coded coordinates for mouse input events resolves the problem
of GetViewBounds returning CSS pixels, which are inconsistent across
different device scale factors.

BUG=647202

Review-Url: https://codereview.chromium.org/2354563002
Cr-Commit-Position: refs/heads/master@{#419474}

If a user selects text in a readonly textfield, all editing operations
will silently fail. This change adds a new callback, Textfield::OnKeypressUnhandled,
which serves to provide feedback in this case. Currently feedback is only
implemented for Mac in the form of a system error beep.

BUG=647523

Review-Url: https://codereview.chromium.org/2342343003
Cr-Commit-Position: refs/heads/master@{#419473}

This test has been flaky for a couple of weeks now. Disabling on
Windows platform until that can be corrected.

TBR=qiangchen@chromium.org
BUG=644614

Review-Url: https://codereview.chromium.org/2346253003
Cr-Commit-Position: refs/heads/master@{#419472}

Many developers have added utility functions to check if the many Mojo
instances are ready and with the correct version, which seems redundant.
This change adds a function to do that (and log failures).

BUG=647853
TEST=cheets_SettingsBridge

Review-Url: https://codereview.chromium.org/2347293002
Cr-Commit-Position: refs/heads/master@{#419471}

https://chromium.googlesource.com/skia.git/+log/950fc6c6360d..122fac306189

$ git log 950fc6c63..122fac306 --date=short --no-merges --format='%ad %ae %s'
2016-09-19 mtklein GN: remove old Android recipe code.
2016-09-19 reed add 'g' to fatbits
2016-09-19 mtklein Delete unused coverage recipe code.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=borenet@google.com

Review-Url: https://codereview.chromium.org/2348343002
Cr-Commit-Position: refs/heads/master@{#419470}

TBR=falken@chromium.org
BUG=648247

Review-Url: https://codereview.chromium.org/2353513002
Cr-Commit-Position: refs/heads/master@{#419469}

When setting tFoot or using createTFoot the new
element should be inserted at the end.

This patch also changes behavior so we throw a
HierarchyRequestError [1] when setting tFoot with
a new element not of type tfoot.

Behavior matches Safari, Firefox and Edge.

[1] https://html.spec.whatwg.org/#dom-table-tfoot

BUG=641338

Review-Url: https://codereview.chromium.org/2338013007
Cr-Commit-Position: refs/heads/master@{#419468}

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2331053003
Cr-Commit-Position: refs/heads/master@{#419467}

https://pdfium.googlesource.com/pdfium.git/+log/a0ff010a380c..ea3c3be83dae

$ git log a0ff010a3..ea3c3be83 --date=short --no-merges --format='%ad %ae %s'
2016-09-19 npm Remove duplicated charset definitions, and move them to fx_font.h
2016-09-19 stackexploit Fix compare between signed and unsigned values in CPDF_ImageRenderer::StartDIBSource.

BUG=645036

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2349213002
Cr-Commit-Position: refs/heads/master@{#419466}

Setting the title frame to be 14px high clips descenders from the text.
If TabController leaves the title frame at its default size, the text
draws properly and is vertically centered in the tab.

BUG=645755

Review-Url: https://codereview.chromium.org/2346513006
Cr-Commit-Position: refs/heads/master@{#419465}

Delete obsolete references to spellcheck files and a switch.

The files listed in chrome/common/owners have been moved to
components/spellcheck/common and are covered by an owners
file there.

The spellcheck switch in ChromeSwitches.java is not used
anywhere (in fact the flag has been removed in
crrev.com/2284583002).

BUG=629609

Review-Url: https://codereview.chromium.org/2341653004
Cr-Commit-Position: refs/heads/master@{#419464}

Revert of Add tests for trace wrappers (patchset #15 id:280001 of https://codereview.chromium.org/2301213003/ )

Reason for revert:
Sorry for the revert; this patch has (I believe) caused the heap-snapshot-with-detached-dom-tree.html to start failing.

The very first failure in that test was in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/17518 -- immediately after this CL was committed.

Here is the flakiness dashboard result for that test:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fheap-profiler%2Fheap-snapshot-with-detached-dom-tree.html&testType=webkit_tests

The test is failing occasionally with output like this:

    Test that all nodes from the detached DOM tree will get into one group in the heap snapshot. Bug 107819.

     Took heap snapshot
    Parsed snapshot
    SUCCESS: found (Detached DOM trees)
    SUCCESS: found Detached DOM tree / 3 entries
    FAIL: unexpected DIV count: 1

Reverting this CL since it appears to be primarily about the tests.

Original issue's description:
> Add tests for trace wrappers
>
> This cl adds very basic tests for general trace wrappers features. And enables TraceWrappables runtime enabled feature for tests!
>
> LOG=no
> BUG=468240
>
> Committed: https://crrev.com/f7d5d042289c5fbe918348830917b888ec587272
> Cr-Commit-Position: refs/heads/master@{#419298}

TBR=haraken@chromium.org,mlippautz@chromium.org,hlopko@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=468240

Review-Url: https://codereview.chromium.org/2350733002
Cr-Commit-Position: refs/heads/master@{#419463}

Removed annotation from:
* ContentViewStatics
* WebContentsObserverProxy

and stopped hooking up their JNI methods for renderer process.

Moved FileDescriptorInfo.java from browser/ to common/ since
it is actually required in the renderer.

BUG=643489

Review-Url: https://codereview.chromium.org/2316183002
Cr-Commit-Position: refs/heads/master@{#419462}

This patch enables CSS hyphens property on stable.

Following values are valid at this point:
  Android/Mac: manual | none | auto
  Other platforms: manual | none

BUG=605840

Review-Url: https://codereview.chromium.org/2342553003
Cr-Commit-Position: refs/heads/master@{#419461}

This unbreaks the V8 Chromium trybot
v8_linux_chromium_gn_rel, broken by missing target mappings
in https://codereview.chromium.org/2352473002

BUG=555273,648153

Review-Url: https://codereview.chromium.org/2350703002
Cr-Commit-Position: refs/heads/master@{#419460}

BUG=fdoray isn't an OWNER of startup_metric_utils :-O

Review-Url: https://codereview.chromium.org/2352693002
Cr-Commit-Position: refs/heads/master@{#419459}

Notable changes:
* ios/web/webui/crw_web_ui_page_builder.mm has a block that had a
   __block reference to itself. Before ARC __block means "do not retain
   when being captured in a block", but with ARC it is captured. So I
   added an additional variable of __weak __block type instead.

* One WeakNSObject in mojo_facade.h could not be removed because it is
  included from non-ARC code. WeakNSObject is functional in ARC but is
  not preferred. Filed crbug.com/639326 to track future removal of
  this.

BUG=639327
TEST=None

Review-Url: https://codereview.chromium.org/2340343002
Cr-Commit-Position: refs/heads/master@{#419458}

BUG=560525

Committed: https://crrev.com/3558706c1b2a630557929b61fefc74e28975f3a6
Review-Url: https://codereview.chromium.org/2322413003
Cr-Original-Commit-Position: refs/heads/master@{#419369}
Cr-Commit-Position: refs/heads/master@{#419457}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/7de487d..314e336

$ git log 7de487d..314e336 --date=short --no-merges --format=%ad %ae %s
2016-09-19 hbos@webrtc.org RTCTestStats moved into webrtc/stats/test (rtc_stats_test_utils)
2016-09-19 sakal@webrtc.org Enable auto-focus on Camera2.
2016-09-19 danilchap@webrtc.org Deprecate RtpSender::SendPadData with provided timestamps.
2016-09-19 sakal@webrtc.org Events refactor in Android session based capturing.
2016-09-19 sakal@webrtc.org Enable stabilization on Camera2.

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2352673002
Cr-Commit-Position: refs/heads/master@{#419456}

https://chromium.googlesource.com/skia.git/+log/bbfe92bc1dd2..950fc6c6360d

$ git log bbfe92bc1..950fc6c63 --date=short --no-merges --format='%ad %ae %s'
2016-09-19 brianosman Add F16 to the list of allowed formats in GaussianBlur
2016-09-19 fmalita [SVGDom] Only apply opacity when needed
2016-09-19 cblume Remove release asserts.

BUG=643845

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=borenet@google.com

Review-Url: https://codereview.chromium.org/2351713002
Cr-Commit-Position: refs/heads/master@{#419455}

BUG=633136

Review-Url: https://codereview.chromium.org/2197113002
Cr-Commit-Position: refs/heads/master@{#419454}

Revert of [sensors] Ambient light sensor bindings implementation (patchset #5 id:80001 of https://codereview.chromium.org/2332323002/ )

Reason for revert:
Sorry for the revert -- two new tests are failing immediately on several Blink bots:
sensor/mock-sensor.html
sensor/ambient-light-sensor.html

See
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=sensor%2Fambient-light-sensor.html%2C%20sensor%2Fmock-sensor.html

First failed build on MacOS 10.10:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/23859

Original issue's description:
> [sensors] Ambient light sensor bindings implementation
>
> This patch implements AmbientLightSensor [1] blink bindings and adds
> LayoutTest helpers for testing sensors that are based on Generic Sensor API.
>
> Following layout tests added to test new functionality:
> IDL tests.
>  - third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensor.html
>  - third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensorReading.html
> AmbientLightSensor tests.
>  - third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html
>
> Intent to Implement:
> https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/TkfdVqYAYiE/xLGN2b1-AAAJ
>
> [1] ED specification for Ambient Light Sensor http://w3c.github.io/ambient-light/
>
> BUG=606766
>
> Committed: https://crrev.com/c457d06894e8f01b24ae83750203fb5d8819c560
> Cr-Commit-Position: refs/heads/master@{#419438}

TBR=jochen@chromium.org,haraken@chromium.org,mikhail.pozdnyakov@intel.com,rijubrata.bhaumik@intel.com,timvolodine@chromium.org,alexander.shalamov@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=606766

Review-Url: https://codereview.chromium.org/2348333002
Cr-Commit-Position: refs/heads/master@{#419453}

https://pdfium.googlesource.com/pdfium.git/+log/e9988dd65e74..a0ff010a380c

$ git log e9988dd65..a0ff010a3 --date=short --no-merges --format='%ad %ae %s'
2016-09-19 stackexploit Avoid nullptr access in sycc422_to_rgb and sycc420_to_rgb

BUG=648127

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2351703002
Cr-Commit-Position: refs/heads/master@{#419452}