GitLab

Windows: Fix a corner case where we still think Adobe Reader is up to date after it has been uninstalled.

BUG=370746
TEST=Manual, see https://code.google.com/p/chromium/issues/detail?id=370746#c43

Review URL: https://codereview.chromium.org/419163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285553 0039d316-1c4b-4281-b951-d872f2087c98

We'll need this for the new and improved WaitMany.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/419613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285552 0039d316-1c4b-4281-b951-d872f2087c98

The NSSCertDatabase singleton for Linux is now maintained by nss_context_linux.cc .

BUG=329735

Review URL: https://codereview.chromium.org/405973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285551 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
Test=None, internal cleanup.

Review URL: https://codereview.chromium.org/411253009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285550 0039d316-1c4b-4281-b951-d872f2087c98

One more clean up before getting 397391 done.

HasGDocFileExtension is a very thin wrapper of the latter
function, and what all the callers need is the former interface.
This CL merges those two functions into one to make it more
easily searchable where in our code is relying on the extensions.

BUG=397391

Review URL: https://codereview.chromium.org/416223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285549 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/408323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285548 0039d316-1c4b-4281-b951-d872f2087c98

Clean up code a bit in MockPeerConnectionImpl. This addresses an issue in non-clang builds on ubuntu 12.04 using gcc 4.6.4 which has been in there for a while now:

The error is as follows:

../../content/renderer/media/mock_peer_connection_impl.cc: In member function
'virtual bool content::MockPeerConnectionImpl::GetStats(webrtc::StatsObserver*,
webrtc::MediaStreamTrackInterface*,
webrtc::PeerConnectionInterface::StatsOutputLevel)':
../../content/renderer/media/mock_peer_connection_impl.cc:280:3: error: in C++98
'value' must be initialized by constructor, not by '{...}'
../../content/renderer/media/mock_peer_connection_impl.cc:293:5: error: in C++98
'value2' must be initialized by constructor, not by '{...}'

R=xians@chromium.org

Review URL: https://codereview.chromium.org/415403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285547 0039d316-1c4b-4281-b951-d872f2087c98

To make it easier to refer to a specific property in the documentation.

Review URL: https://codereview.chromium.org/421443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285546 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396466

Review URL: https://codereview.chromium.org/411253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285545 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/410753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285544 0039d316-1c4b-4281-b951-d872f2087c98

* drive::util::GetHostedDocumentMimeType is useless, the mime type
is directly obtained from ResourceEntry, especially after we've
moved to Drive API (see Bug 308836 for subtlety).
* kWapiRootDirectoryResourceId is just not used anywhere.

BUG=397391

Review URL: https://codereview.chromium.org/414203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285543 0039d316-1c4b-4281-b951-d872f2087c98

This patch ensures that we only create tiling data iterators when
we visit the corresponding region.

Relevant perf data from a macbook:

Before:
tiling_raster_tile_iterator_construct:
0_0_100x100= 5828515 runs/s
50_0_100x100= 5530272 runs/s
100_0_100x100= 2730390 runs/s
150_0_100x100= 3735413.25 runs/s

tiling_raster_tile_iterator_construct_and_iterate:
32_100x100= 576050 runs/s
32_500x500= 601867.5625 runs/s
64_100x100= 353348.21875 runs/s
64_500x500= 362777.46875 runs/s

After:
tiling_raster_tile_iterator_construct:
0_0_100x100= 7913765 runs/s (+36%)
50_0_100x100= 7875735 runs/s (+42%)
100_0_100x100= 3382876.5 runs/s (+23%)
150_0_100x100= 5191805 runs/s (+39%)

tiling_raster_tile_iterator_construct_and_iterate:
32_100x100= 599836.6875 runs/s (+4%)
32_500x500= 629638.75 runs/s (+5%)
64_100x100= 357503.9375 runs/s (+<1%)
64_500x500= 372805.71875 runs/s (+3%)

R=reveman

Review URL: https://codereview.chromium.org/411183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285542 0039d316-1c4b-4281-b951-d872f2087c98

Originally, ExtensionUninstallDialog took a Browser argument (which
determined which browser window it should be modal to), and a special
case was added so the dialog would be modal to the app list if the
Browser argument was NULL. Updated this constructor to take the parent
NativeWindow directly instead of a Browser, so the dialog can be modal
to any parent window. For example, this allows it to be parent to the
App Info dialog, and be a proper standalone dialog in
ExtensionStorageMonitor. Further refactors can be made as a result of
this CL since some of the callsites could be getting a Browser just to
be able to launch the dialog, whereas that is not needed anymore if the
intention is to launch it as a non-modal dialog.

Updated uninstall dialogs launched from the following callsites:
- The management Chrome API
- The extensions context menu
- The 'app disabled' message for when it has requested new permissions
- The chrome://extensions page
- The context menu of apps in the app list
- The 'remove' button in the App Info dialog
- The context menu on the New Tab page

BUG=388746,362308

Review URL: https://codereview.chromium.org/382133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285541 0039d316-1c4b-4281-b951-d872f2087c98

Same what https://chromiumcodereview.appspot.com/11830002 did for ui_resources.

BUG=396209

Review URL: https://codereview.chromium.org/417493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285540 0039d316-1c4b-4281-b951-d872f2087c98

Ephemeral apps should not trigger Chrome background mode and the
"New background app added" notification bubble should not be
displayed when they are launched as they do not have background
activity after they are closed.

BUG=339001
TEST=unit_tests

Review URL: https://codereview.chromium.org/383113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285539 0039d316-1c4b-4281-b951-d872f2087c98

Add support for seccomp bpf sandboxing on MIPS architecture.
Enable testing of seccomp bpf sandbox.

Support for seccomp bpf for MIPS was added in Linux kernel version 3.15.

This patchset was reviewed in https://chromiumcodereview.appspot.com/260793003/ and re-created
to workaround a commit-queue issue.

BUG=369594
TEST=sandbox_linux_unittests

Review URL: https://codereview.chromium.org/409403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285538 0039d316-1c4b-4281-b951-d872f2087c98

In search result, the entries have same names and it causes unstability of the
sort. The CL let the compare function to see URL when the names are same.

The CL also moves the sort functions from the UI class to the model class.

BUG=397386
TEST=manually

Review URL: https://codereview.chromium.org/419173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285537 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392981
TEST=manually

Review URL: https://codereview.chromium.org/419063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285536 0039d316-1c4b-4281-b951-d872f2087c98

To show the focus ring in the correct size, the CL enlarges the size of range
inputs in Gallery. Instead, the CL adds pseudo element to draw the range track
(a thin horizontal bar).

BUG=397062
TEST=manually

Review URL: https://codereview.chromium.org/419153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285535 0039d316-1c4b-4281-b951-d872f2087c98

Leverage OnFocus event to let component IME extension know about the current screen type (e.g. login, lock, etc.) so that on-screen keyboard won't popup new window/page at login/lock screens.

BUG=395621
TEST=None

Review URL: https://codereview.chromium.org/418273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285534 0039d316-1c4b-4281-b951-d872f2087c98

- store the properties into DistilledPageInfo
- add test using OpenGraphProtocol and Schema.Org markup.

BUG=396124
TBR=nyquist

Review URL: https://codereview.chromium.org/411253008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285533 0039d316-1c4b-4281-b951-d872f2087c98

This refactor extracts common functionality to simplify adding the equivalent OpenSSL implementation:

 * Extracts the conversion of public exponent from a big integer to an unsigned integer
 * Restricts key sizes to multiples of 8, between 256 and 16K. This is the more restrictive range supported by NSS.

BUG=389317

Review URL: https://codereview.chromium.org/401233004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285532 0039d316-1c4b-4281-b951-d872f2087c98

Add a /update resource which accepts a new software package (assuming
the hash is correct) and performs an in-place upgrade. To avoid leaving
the device in an unusable state the old version remains running until
the new version starts to accept HTTP connections. At this point the
Tornado I/O loop is running correctly and even if USB functionality
is broken the device should accept another software update to fix it.

BUG=396682
R=rockot@chromium.org,rpaquay@chromium.org,kalman@chromium.org

Review URL: https://codereview.chromium.org/412243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285531 0039d316-1c4b-4281-b951-d872f2087c98

'WebURLRequest::TargetType' has been dropped in Blink in favor of
'RequestContext' and 'FrameType', matching the Fetch specification's
changes, and allowing both more granularity in various Blink-side checks
and more clarity around the thing that caused a request, and the frame
that the request affects.

This CL should have zero practical effect, as it's simply hoisting the
translation work that 'WebURLRequest::setTargetType' is already doing
up into the content layer to bring us one step closer to removing the
concept entirely.

BUG=390497

Review URL: https://codereview.chromium.org/392333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285530 0039d316-1c4b-4281-b951-d872f2087c98

If chrome::VersionInfo::GetVersionStringModifier() returns an empty
string (which is the case for the Stable channel and any unofficial
builds), don't append a space.

R=rtenneti@chromium.org,thestig@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/420613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285529 0039d316-1c4b-4281-b951-d872f2087c98

Fixed the crash when adding a chromium sink to remote audio track or adding a track to peerconnection more than once.

NOTRY=true

BUG=396447
TEST=open peerConnection demo, http://googlechrome.github.io/webrtc/samples/web/content/peerconnection/
2. start a call
3. Open JS console and input below codes:
# adding a chromium sink to remote audio track:
var v = new webkitMediaStream();
v.addTrack(pc2.getRemoteStreams()[0].getAudioTracks()[0]);
var a = document.createElement('audio');
a.src = URL.createObjectURL(v);

# add a track to peer connection more than once:
var v = new webkitMediaStream();
v.addTrack(pc2.getRemoteStreams()[0].getAudioTracks()[0]);
pc1.addStream(v);

Review URL: https://codereview.chromium.org/411903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285528 0039d316-1c4b-4281-b951-d872f2087c98

There are a 8 basic test cases of varying types including text only html files, some html files with forms, an image, and a color-gradient.
BUG=388517

Review URL: https://codereview.chromium.org/416433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285527 0039d316-1c4b-4281-b951-d872f2087c98

Removes an erroneous DCHECK added in this patch: https://codereview.chromium.org/385013002/

This DCHECK is erroneous, because the Install() function in DefaultComponentInstaller is actually called on a different task runner than the member task runner.

It's called from ComponentUnpacker::Install. ComponentUnpacker has a different task runner with a different sequence token, so it's erroneous to DCHECK it against the member task runner of DefaultComponentInstaller.

BUG=397264

Review URL: https://codereview.chromium.org/419103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285526 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds support to truncate files to a desired length via FileWriter's
truncate() method in JS.

Note, that truncating via NaCl IO is not supported yet.

TEST=unit_tests, browser_tests: *FileSystemProvider*Truncate*
BUG=391362

Review URL: https://codereview.chromium.org/417983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285525 0039d316-1c4b-4281-b951-d872f2087c98

We added a new blink_resources.gyp file to Blink repo in order to get
rid of blink_chromium_resources action from webkit_resources.gyp and
make the migration easier in
https://src.chromium.org/viewvc/blink?revision=178275&view=revision

This updates the Chromium side to reference the new generated path.

BUG=338338
TEST=None
R=jamesr@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/398243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285524 0039d316-1c4b-4281-b951-d872f2087c98

This CL only moves account picker related resources that are used on Chrome OS (login UI) and Chrome Win/Mac/Linux (user_manager UI).

The rest of Chrome OS out-of-box/login WebUI resources will be moved later as well.

BUG=387608,370175
R=dzhioev@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/402403005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285523 0039d316-1c4b-4281-b951-d872f2087c98

These now pass thanks to Tim's shutdown fixes.

BUG=396295

Review URL: https://codereview.chromium.org/421473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285522 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327256

Review URL: https://codereview.chromium.org/411283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285521 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285520 0039d316-1c4b-4281-b951-d872f2087c98

> NaCl: Update revision in DEPS, r13506 -> r13526
> 
> This pulls in the following Native Client changes:
> 
> r13507: (noelallen) Reapply patch which was reverted due to conflict.
> r13508: (dschuff) PNaCl Driver: do not generate temp file names beyond Windows'
> MAX_PATH limit
> r13509: (jvoung) Add a flag to pnacl-finalize that allows users to keep
> function names.
> r13510: (dschuff) Disable flaky sandboxed translator tests on mac
> r13511: (dschuff) Update revision for PNaCl r13466->r13509
> r13512: (ncbray) Fix untrusted.gypi and build_nexe.py
> r13513: (noelallen) Cleanup bionic build script.
> r13514: (dyen) Added initial pass of nacl_irt_code_data_alloc.
> r13515: (sbc) Use custom exception class for errors in package_version.
> r13516: (hidehiko) Non-SFI mode: SCONS_NONSFI_TC clean up.
> r13517: (hidehiko) Non-SFI Mode: Refactoring. Provide non-SFI version of
> nacl_irt_query_core.
> r13518: (binji) Revert "Non-SFI mode: SCONS_NONSFI_TC clean up."
> r13519: (bradnelson) Make the trybots fail early if 'git cl try' is mistakenly
> used.
> r13520: (bradnelson) Make build_nexe.py rebuild when script itself has changed.
> r13521: (noelallen) Updates GN dep, and cleans up some toolchain prep
> definitions to make it easier to debug what's going on.
> r13523: (teravest) Add embedder interface for fatal log messages.
> r13524: (bradnelson) Passing --config-name to build_nexe.py for all arches.
> r13525: (teravest) Create a sel_ldr_launcher_base target.
> r13526: (teravest) Revert "Add embedder interface for fatal log messages."
> 
> R=ncbray@chromium.org
> BUG=none
> TEST=browser_tests and nacl_integration
> CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build
> 
> CC: native-client-reviews@googlegroups.com, binji@chromium.org, bradnelson@google.com, dschuff@chromium.org, dyen@chromium.org, hidehiko@chromium.org, jvoung@google.com, ncbray@chromium.org, noelallen@google.com, sbc@chromium.org, teravest@chromium.org
> 
> Review URL: https://codereview.chromium.org/418213002

TBR=bradnelson@google.com

Review URL: https://codereview.chromium.org/420603005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285519 0039d316-1c4b-4281-b951-d872f2087c98

Extensions can now use the <extensionoptions> page to embed another extension's options page with basic iframe-like behavior and features.

In this CL:
 - Create a new guest view (ExtensionOptionsGuest) for safely embedding extension options
 - Modify existing guest view-related classes to support the new view
 - Add API tests to verify that the guest view can be created and that it has access to privileged APIs. 

BUG=386838
TEST=browser_tests

Review URL: https://codereview.chromium.org/378783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285518 0039d316-1c4b-4281-b951-d872f2087c98

We shouldn't crash when the response headers map is null.

BUG=394173

Review URL: https://codereview.chromium.org/392113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285517 0039d316-1c4b-4281-b951-d872f2087c98

This CL allows apps to customize their appearance in the per-app window list
in the Ash shelf by changing their favicon. Each app window will use the 
favicon if it exists, falling back to the current behavior of a downscaled
app icon if it doesn't.

BUG=390907

Review URL: https://codereview.chromium.org/411543009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285516 0039d316-1c4b-4281-b951-d872f2087c98

Exclude USE_AURA specific code with preprocessor blocks.
Related to https://codereview.chromium.org/413303003/
(both are needed for a clean build on ToT@285384)

BUG=395507
TEST=NONE
R=sky@chromium.org

Review URL: https://codereview.chromium.org/418223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285515 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a per-view flex property to BoxLayout. The flex property functions
similarly to the CSS flexbox concept of flex, using the child view's preferred
size as the flex basis and then adding or removing space within each flexed
so that all views fit within the parent.

This CL also removes MAIN_AXIS_ALIGNMENT_FILL as it is superceded by
SetDefaultFlex().

BUG=386475

Review URL: https://codereview.chromium.org/360213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285514 0039d316-1c4b-4281-b951-d872f2087c98