- 01 Nov, 2017 40 commits
-
-
Tatsuhisa Yamaguchi authored
Bug: 761154 Test: gtest_filter=FileManagerJsTest.FileTasks:GenericTask/FileManagerBrowserTest.* Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I43b04bac3a5d5683d3a8c5afba71f19ce77c8231 Reviewed-on: https://chromium-review.googlesource.com/725959Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#513069}
-
Trent Apted authored
BookmarkBarInstructionsView::CalculatePreferredSize() was growing 25->30 pixels under SecondaryUiMd because Labels pick up a default minimum line height under Harmony. BookmarkBarInstructionsView should be using style::CONTEXT_BUTTON so that its text is consistent with the LabelButtons that normally appear in the bookmarks toolbar. That TextContext doesn't set line heights, so the height now stays the same. Bug: 713030 Change-Id: I5386755a8f1e77d91d95a9f03b86ce22d5f31c61 Reviewed-on: https://chromium-review.googlesource.com/746062 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#513068}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/47b67c426b1d..5d790d53ea6e $ git log 47b67c426..5d790d53e --date=short --no-merges --format='%ad %ae %s' 2017-11-01 hinoka Revert "Reland "bot_update recipe: Upload source manifest"" Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I14deb97c769ab25fa7363f5da9393dd4d21ae9a3 Reviewed-on: https://chromium-review.googlesource.com/748315Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513067}
-
Yuke Liao authored
This CL fixes the accessibility id of the share menu button. Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I77885235b8185a4e8058fcc026f2bec6e511ef91 Reviewed-on: https://chromium-review.googlesource.com/747804Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#513066}
-
Patti authored
Make all page info combobox widths be the same as the longest currently displayed item, provided it doesn't exceed a max threshold. Screenshot - https://drive.google.com/file/d/0BzEa5HU1aAqBc1U4SjdhZnVONzA/view?usp=sharing Bug: 535074, 778088 Change-Id: I235e51e9b7d8c77eff43c5690c62e4008a411fef Reviewed-on: https://chromium-review.googlesource.com/730243Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#513065}
-
Wez authored
Bug: 780317 Change-Id: I472b726726629139b57b73d7c010d9aa9744052b Reviewed-on: https://chromium-review.googlesource.com/748202Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#513064}
-
Yuki Awano authored
Bug: none Test: none Change-Id: I5045a725992f985050c230947d65c87eba9f7ee2 Reviewed-on: https://chromium-review.googlesource.com/745084Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#513063}
-
Klaus Weidner authored
Add a gfx::BufferUsage parameter to the various creation methods in gpu_memory_buffer_impl_shared_memory for consistency and to facilitate sharing tests with implementations that use it. It appears that all call sites already have a "usage" parameter in scope, so it just needed to get passed through. (Split from http://crrev.com/c/680100 for AHardwareBuffer-based GpuMemoryBuffer) BUG=761432 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I33ab6255b4b0675fa5fb30b71ddbd10015bdae34 Reviewed-on: https://chromium-review.googlesource.com/747601Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#513062}
-
Wez authored
Bug: 772031 Change-Id: I77eb7d669be38a1163260c3487e61c9541cdca8d Reviewed-on: https://chromium-review.googlesource.com/748265Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#513061}
-
chrome-release-bot authored
TBR=anantha@chromium.org Change-Id: I83c579841ff5690a6bf6f9d14b97ed34b4159bd6 Reviewed-on: https://chromium-review.googlesource.com/748581Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#513060}
-
Brian White authored
This has been running only with sparse histograms for some time now and has been helpful in finding metrics that overflow. Now extend this to check the remaining bulk of histograms. While the original CL looked for many different reasons of acquiring a negative sample count, it's now known that there is only a single reason and so that is the only reason checked for here. Bug: 682680 Change-Id: I96785436468fdbe34f4221caf7a79da299edeca2 Reviewed-on: https://chromium-review.googlesource.com/741004Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#513059}
-
Christopher Lam authored
This CL adds a custom menu model for hosted app which has only the items that should be shown for a hosted app. It also adds 3 new commands which are currently disabled and will be implemented in a future CL. Bug: 762401 Change-Id: I7e53eb3d11042f267567e3773784c8594d7c7bee TBR: erg@chromium.org Reviewed-on: https://chromium-review.googlesource.com/721226 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
-
Junliang Yan authored
Bug: Change-Id: I96b5c9643c73a6ae37c40af1558f1520eb5201e4 Reviewed-on: https://chromium-review.googlesource.com/747513Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#513057}
-
Pawel Osciak authored
This is a reland of de566f6b Relanding with relevant *_EXPORTs added to fix the component build. Original change's description: > Add support for protected gpu memory buffers and a secure mode to ArcVDA. > > A protected gpu memory buffer is a buffer that can be referred to > by a GpuMemoryBufferHandle, which does not provide access to the buffer's > contents. Such handle can be shared with and received from clients that > should not have access to the buffer's contents. When such handle is > passed to the ProtectedGpuMemoryBufferManager service by its privileged > client, it can be translated into another GpuMemoryBufferHandle, which > allows access to the buffer. > > Also, implement a ProtectedMemoryManager to provide an allocation and > lookup service for such buffers for gbm. > > Finally, add secure mode API to the ArcVideoAccelerator stack and integrate > it with the above, to provide a secure codec mode implementation. > > TEST=E2E video playback tests > BUG=b:27174405,b:62575861,b:27204780 > > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I80259db35463f7ed0cc3acc28bf767e55e46c8b8 > Reviewed-on: https://chromium-review.googlesource.com/689818 > Reviewed-by: Kuang-che Wu <kcwu@chromium.org> > Reviewed-by: Owen Lin <owenlin@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: David Reveman <reveman@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Commit-Queue: Pawel Osciak <posciak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#512797} Bug: b:27174405, b:62575861, b:27204780 Change-Id: I147aee03c72ea0d04def1f17ba88ea3a5abd50f6 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=kcwu@chromium.org,owenlin@chromium.org,hidehiko@chromium.org,sky@chromium.org,rjkroege@chromium.org,reveman@chromium.org,dcheng@chromium.org,jorgelo@chromium.org Change-Id: I147aee03c72ea0d04def1f17ba88ea3a5abd50f6 Reviewed-on: https://chromium-review.googlesource.com/748041Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#513056}
-
Jonathan Metzman authored
TBR=meade@chromium.org Bug: 771641 Change-Id: Ibeebf55dfb82c48d32b85a5b97209b1567641b10 Reviewed-on: https://chromium-review.googlesource.com/744311 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#513055}
-
Darren Shen authored
CSSStyleValue.parseAll is similar to CSSStyleValue.parse in that it converts a string value into a CSSStyleValue. The main difference is how it handles list-valued properties. Spec: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssstylevalue-parseall To reduce duplication, we move the common logic between parse and parseAll into a helper function. We also change the tests for parseAll because they wrongly expected that parseAll return a CSSStyleValue instead of a sequence of CSSStyleValues. Bug: 775802 Change-Id: I4b6b05d3a164e34709839ca2e059ec3fbf18a993 Reviewed-on: https://chromium-review.googlesource.com/742822 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#513054}
-
Sam McNally authored
Migrate the remaining interfaces accessed via WorkerThread::GetInterfaceProvider() to use ExecutionContext::GetInterfaceProvider(): - PaymentManager - PermissionService - WebSocket Bug: 734210 Change-Id: Ib33c8783bbb490bd4bda5dd31da2a72ab218d03b Reviewed-on: https://chromium-review.googlesource.com/743102 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#513053}
-
MinChen authored
Changes: 1. Allowing the snapped window that next to the origin of the work area can be moved outside of the bounds of work area. 2. Delete RestackWindows in SplitViewController, since left and right snapped window will not overlap now. Bug: 775236 Change-Id: Ib1d12443f8b9965544014590b8eff37ed8b3f665 Reviewed-on: https://chromium-review.googlesource.com/741489 Commit-Queue: min c <minch@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#513052}
-
Makoto Shimazu authored
crrev.com/c/742354 broke DisplayItemTest.DebugStringsExist in blink_platform_unittests. It seems caused by just forgetting to add a case to DisplayItem.cpp, so this patch is to fix it. TBR=wangxianzhu@chromium.org, trchen@chromium.org NOTRY=true Bug: n/a Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4faf738cb3fabb91253283396fa46733bf287100 Reviewed-on: https://chromium-review.googlesource.com/748481 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#513051}
-
Nate Fischer authored
No change in logic. This adds @Override annotations to fix compile warnings in WebView's glue layer. Bug: 779716 Test: ninja system_webview_google_apk (rebuild glue, look for compile warnings) Change-Id: I73096eaec795a9956993ed34f7d1508c0d19e01f Reviewed-on: https://chromium-review.googlesource.com/744962Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#513050}
-
Kenneth Russell authored
Copy WebGL 1.0 Linux P400 expectations to WebGL 2.0; they weren't being run on that configuration previously. BUG=712469 NOTRY=true TBR=jmadill@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iec9def1894e30ef95f1743b64483cf61798c5d2e Reviewed-on: https://chromium-review.googlesource.com/748319 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This patch converts editing/pasteboard/copy-null-characters.html with assert_selection to promote the use of w3c testharness and improve code health. Bug: 679977, 775701 Change-Id: Ib89e9f246b7c7ef559b0d67ac2a4937405524145 Reviewed-on: https://chromium-review.googlesource.com/746341 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#513048}
-
spqchan authored
There's a bug where the thumb in the Cocoa overlay scrollbar becomes more narrow than the track width. This bug is caused by BaseScrollBarThumb::SetLength() which sets the thumb's size according to its preferred size. Since the CocoaScrollBarThumb::CalculatePreferredSize() returns the thumb's minimum's size, SetLength() would set the thumb's size to be too small. This CL fixes this issue by returning the thumb's current thickness instead of the minimum size in CocoaScrollBarThumb::CalculatePreferredSize(). Additionally, this CL changes the logic so that the thumb and track bounds and size won't be insetted. Instead, the thumb's painting will be inset in the OnPaint() function. The kExpandedScrollbarThumbInset value is also removed. Bug:682466 Change-Id: I59411650df8acfb4e628efbb1a9f0646c2ce385b Reviewed-on: https://chromium-review.googlesource.com/741039 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
-
Abhishek Arya authored
R=dpranke@chromium.org,hans@chromium.org Bug: 780048 Change-Id: I124805ca7fc97ed1d04ab8af213a376540425b3f Reviewed-on: https://chromium-review.googlesource.com/745810Reviewed-by:
-
Philip Rogers authored
When painting composited overflow, kPaintLayerPaintingOverflowContents is set to paint all content. When painting a nested, transformed scroller, we need to ensure this flag is unset so the contents are clipped. Because root layer scrolling (RLS) paints the root layer as a regular overflow scroller, this bug affected more tests with RLS. With this patch, 5 more tests pass with root layer scrolling. Bug: 779885 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I311cfa9e3244192b24ec3dd566aa2c65e9dba851 Reviewed-on: https://chromium-review.googlesource.com/748081 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#513045}
-
Adam Langley authored
This is the result of running tools/metrics/histograms/update_policies.py in a clean branch. Both of these changes appear to be correct based on the names in components/policy/resources/policy_templates.json. This allows future users of update_policies.py to get a clean diff. Change-Id: I28245240d594e1c82481663aa17a9ff099a1864f Bug: None Reviewed-on: https://chromium-review.googlesource.com/747691Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#513044}
-
Miguel Casas-Sanchez authored
This CL moves the file v4l2_stub_header.fragment to //media/gpu/v4l2/ folder. This file is used in conjunction with the signature files in the said folder, to produce an include file with the functions used for v4l2 video acceleration. Right now having the fragment in //media/gpu is unnecessary. TEST= ** No new code added, if it compiles, we're good ** (Note that this code is compiled in the bot chromeos_amd64-generic_chromium_compile_only_ng which is part of the CQ). This CL is kind-of a continuation of crrev.com/c/744462. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I11ea24e3feb27f53d06e3dcacccc2fdb0f0ac6fa Reviewed-on: https://chromium-review.googlesource.com/747532Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#513043}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/4dbdc677affd..a44b013a328d $ git log 4dbdc677a..a44b013a3 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I0319a822d0c0a4d0fbfb2e64ef0bb7788d325244 Reviewed-on: https://chromium-review.googlesource.com/748262Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513042}
-
Thomas Guilbert authored
The devices added in this CL are accountable for 80% of the crashes in the attached bug. There is no good stack trace to investigate the crash further, but all crashes seem to happen at MediaCodecBridgeImpl destruction time. Using the fallback path on those devices on JellyBean should mitigate further crashes. Bug: 693216 Change-Id: I58f5a1522105a87d48470452f28634dc9bf806c7 Reviewed-on: https://chromium-review.googlesource.com/748205Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#513041}
-
Eugene Ostroukhov authored
Bug: 738065 Change-Id: Ia706f3a5edd451de462ab8c6a26abc394d493e9e Reviewed-on: https://chromium-review.googlesource.com/731405 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#513040}
-
Makoto Shimazu authored
This reverts commit fd502dfe. Reason for revert: This patch seems causing interactive_ui_tests failures on Linux Chromium MSan/LSan Tests bots. https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/3892 Original change's description: > Make PendingWallpaper pass weak pointers with a default delay > > After applying a default delay to PendingWallpaper, some tests > failed (crbug.com/779504) or have memory leak [1]. > > These tests indirectly called SetUserWallpaper, but they do not > care/know about this, so they do not actively wait until wallpaper > loading is done, but start the destruction directly. > > This used to be okay when SetUserWallpaper had zero delay. > > But when it has the default delay, the timer is still running when > the destruction starts, and the timer holds a reference to the shared > pointer of PendingWallpaper, which results in memory leak. > > What's worse, if the WallpaperManager already destructs itself, > PendingWallpaper::ProcessRequest does not know it, and it crashes. > > After changing the shared pointer to a weak pointer, WallpaperManager > will be able to completely manage the lifetime of PendingWallpaper. > > [1] https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/24405 > > Below are the description of the original CL: > > 1) All the PendingWallpaper requests are now subject to a delay > calculated from average loading time. However, in most cases the delay > is still zero, and this change only affects corner cases that multiple > requests coming together, which may result in wallpaper being stuck. > > 2) Add the account_id update in PendingWallpaper. Did not modify > the functionality of PendingWallpaper, except for some renaming. > > TBR=oshima@chromium.org > > Bug: 779504, 778451 > Change-Id: Iae943f88bbe046849c3afab75f35a253934fe75b > Reviewed-on: https://chromium-review.googlesource.com/745022 > Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#512883} TBR=oshima@chromium.org,alemate@chromium.org,wzang@chromium.org Change-Id: I62ae0d91bc1cbe953de45a77402f38754de858cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 779504, 778451 Reviewed-on: https://chromium-review.googlesource.com/748381Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/32a6cc20..1facfc82 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I67d1e6588f934ae8682f6c630505780469987bf4 Reviewed-on: https://chromium-review.googlesource.com/747512Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#513038}
-
Chris Bentzel authored
These are pretty trivial, but possibly worth keeping. Change-Id: I89866f829699ac597d44cd87e94f948211539174 Reviewed-on: https://chromium-review.googlesource.com/746365Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Chris Bentzel <cbentzel@chromium.org> Cr-Commit-Position: refs/heads/master@{#513037}
-
Max Moroz authored
R=vitalybuka@chromium.org Bug: 676024 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2c1d8f28ffcce5e657e383ab70ad1dbb4ec9668e Reviewed-on: https://chromium-review.googlesource.com/736669 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#513036}
-
Bailey Forrest authored
The main changes are in chromecast/chromecast.gni The rest of the files were modified with these commands: - Change source_set -> cast_source_set git ls-files "chromecast/*.gn" | xargs sed -i 's/source_set(/cast_source_set(/g' - Include chromecast.gni for any GN files missing it git ls-files "chromecast/*.gn" | xargs grep -L '//chromecast/chromecast.gni' | xargs grep -l 'source_set' | xargs -L1 ~/src/scratch/add_line_after_first_comment.py 'import(' '"//chromecast/chromecast.gni")' add_line_after_first_comment.py can be found under chromecast/internal/tools BUG=b/68723969 TEST=Build and run Change-Id: I38a06ac4d8a45ebc7963b58e5a2db81fde84e635 Reviewed-on: https://chromium-review.googlesource.com/747894Reviewed-by:Stephen Lanham <slan@chromium.org> Commit-Queue: Bailey Forrest <bcf@chromium.org> Cr-Commit-Position: refs/heads/master@{#513035}
-
Dirk Pranke authored
We're not actually going to use that particular config. R=jbudorick@chromium.org BUG=732531 Change-Id: I6ab1cda23fdb621cccd19418263a57e955d032f8 Reviewed-on: https://chromium-review.googlesource.com/744594 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Some of the partner customization logic is extracted to AppHooks, so that it can be overriden in downstream. Bug: 778805 Change-Id: I6dcd4b0a14ed76f7a9c447452ce313f59ca98a65 Reviewed-on: https://chromium-review.googlesource.com/741086Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#513033}
-
Matt Reynolds authored
GamepadHapticActuator receives haptics commands and forwards them to GamepadDispatcher, which dispatches them to the device service. It also manages the state of promises which have been returned to the user as the result of haptics commands. Haptics commands include playEffect, which plays a vibration effect on the target gamepad, and reset, which stops vibration and resets any vibration-related state on the gamepad. Both commands return a promise that is resolved with a result code once the command is completed. BUG=749295 Change-Id: I457c4b0e024c88adcaecdf6695959e06acb20a8e Reviewed-on: https://chromium-review.googlesource.com/747050 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#513032}
-
Matt Reynolds authored
Add MeasureAs attributes for geolocation methods so usage of the feature can be tracked through UseCounter. BUG=780267 Change-Id: I8994be04aa750971204f515d66f5834ce38ab8c8 Reviewed-on: https://chromium-review.googlesource.com/747862Reviewed-by:
Vincent Scheib <scheib@chromium.org> Reviewed-by:
-
Reilly Grant authored
This patch devirtualizes calls to interface methods made through a mojo::InterfacePtr<T> and mojo::AssociatedInterfacePtr<T> by making get() and the -> and . operators return the proxy type directly and marking the interface methods on the proxy as final. The motivation of this change is performance and binary size. The non- virtual call sites are slightly smaller but not enough to effect the complete binary. Performance should be net-positive but as yet has not been accurately measured. Bug: None Change-Id: I463bc32c1989853606d118f57ded5c9dd9f34e2f Reviewed-on: https://chromium-review.googlesource.com/747884 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#513030}
-
