GitLab

This adds support in WebView for blocking Malicious Unwanted Software
(MUwS, UwS) AKA "Harmful software" via Safe Browsing.

In this CL, we do the following:

 * Add new strings for the quiet MUwS interstitial (which is only used
   by WebView). These strings live in assets/stored-locales/ in the APK.
 * Whitelist the quiet MUwS strings (from the previous bullet point) as
   well as the previously chrome-only loud MUwS strings. These strings
   move from assets/locales/ (compressed, chrome-only resources) to
   assets/stored-locales/ (uncompressed, chrome+webview resources) in
   the APK.
 * Change WebView's declared list of threats to include MUwS
 * Change testSafeBrowsingDoesNotBlockUnwantedSoftwarePages, since this
   assertion is no longer valid. Change this to ensure we *do* block
   MUwS pages
 * Add a new test to ensure we can show quiet interstitials for MUwS
 * Change SafeBrowsingQuietErrorUI to respond to MUwS, and refactor it
   to be more similar to the LoudErrorUI.

This change causes the following APK size changes (measurements taken
with is_official_build = true), after unzipping the APKs with `unzip -lv
$APK | grep 'pak'`.

Monochrome:
 * assets/locales/en-US.pak: 20068 -> 19926 (-142) (improvement)
 * assets/stored-locales/en-US.pak: 7773 -> 8472 (+669)
SystemWebViewGoogle:
 * assets/stored-locales/en-US.pak: 7773 -> 8472 (+669)

A later follow-up will add this page to chrome://interstitials.

Bug: 729268
Bug: 729271
Bug: 729272
Test: run_webview_instrumentation_test_apk -f SafeBrowsingTest#*
Test: Manual - load big and small interstitials, verify it looks correct
Change-Id: I79e81f48d8b2ceb1ddcad7fab2d3bed3fcb479ae
Reviewed-on: https://chromium-review.googlesource.com/1182945
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585268}

Bug: chromedriver:2553
Change-Id: I4c8d50c819f128ced652bc397bb294de3984ed2e
Reviewed-on: https://chromium-review.googlesource.com/1185783Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Cole Winstanley <cwinstanley@google.com>
Cr-Commit-Position: refs/heads/master@{#585267}

https://skia.googlesource.com/skia.git/+log/4a0ba280b94c..92b161fab40f


git log 4a0ba280b94c..92b161fab40f --date=short --no-merges --format='%ad %ae %s'
2018-08-22 enne@chromium.org Add emulate_abs_int_function workaround
2018-08-22 scroggo@google.com Switch SkCodec to use skcms
2018-08-22 brianosman@google.com Remove unused sRGB mip-map support
2018-08-22 kjlubick@google.com [PathKit] Add asm.js build and test jobs
2018-08-22 benjaminwagner@google.com [infra] Remove NexusPlayer Vulkan jobs.
2018-08-22 mtklein@google.com streamline interface to GrColorSpaceXform::Make()
2018-08-22 brianosman@google.com Make SkColor4f <-> SkColor skip sRGB conversion
2018-08-22 enne@chromium.org Add unfold_short_circuit_as_ternary workaround


Created with:
  gclient setdep -r src/third_party/skia@92b161fab40f

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium: 642227,chromium:829614,chromium: 307751,chromium:829614
TBR=fmalita@chromium.org

Change-Id: I6ed6e1fe370f351b38d74f862a6a79ee5eb9bf20
Reviewed-on: https://chromium-review.googlesource.com/1185501Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585266}

GTK2 code was historically kept around to keep the electron build working.  But
as of Nov 26, 2017, electron now uses GTK3 [1], so it should now be safe to
remove all of the old GTK2-only code.

[1] https://github.com/electron/electron/issues/2927#issuecomment-347092515

BUG=876558
R=sky

Change-Id: I78402053ae508ccd8fc7ac73697a861bb1ebacf6
Reviewed-on: https://chromium-review.googlesource.com/1183858
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585265}

Also fix similar problem for VP9 (in a code path we seldom hit)

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I86dc30003f71d5a1b32db7986f95c1c9001667a1
Reviewed-on: https://chromium-review.googlesource.com/1184246Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585264}

Change-Id: Ide9ed87b0976edbdfc9d14cbed10e073391d4613
Reviewed-on: https://chromium-review.googlesource.com/1185421Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585263}

We made a change to the ignored calculation in crrev.com/c/990537 that
ended up making it so that <body tabindex=-1> would no longer be ignored,
but this leads to weird side effects.

Note that in our accessibility tree now, the root "web area" element is
not the same as the HTML BODY element, which is usually ignored. Firefox
seems to treat the BODY as the root of the tree, in comparison. It'd be
interesting to try to fix that, but that'd be a huge change.

Bug: 862100
Change-Id: Ibfa54570bd20205d76cb66f50211431a32704bb2
Reviewed-on: https://chromium-review.googlesource.com/1179075Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585262}

Change-Id: Ibd09d463d445c23698253c9e206cc37107b3bdec
Reviewed-on: https://chromium-review.googlesource.com/1185212Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585261}

Bug: 875729
Change-Id: I3a80290e059cd9b21f660572700427d92ef9f84b
Reviewed-on: https://chromium-review.googlesource.com/1181929Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585260}

https://pdfium.googlesource.com/pdfium.git/+log/03fdf3a2b5ee..7e7e0b8379c4


git log 03fdf3a2b5ee..7e7e0b8379c4 --date=short --no-merges --format='%ad %ae %s'
2018-08-22 hnakashima@chromium.org Change in/out params in CBC_PDF417Writer::Encode to only out.
2018-08-22 tsepez@chromium.org Use UnownedPtr<> in IJS_Runtime.
2018-08-22 tsepez@chromium.org Use UnownedPtr<> in JBig2_TrdProc, part 2.
2018-08-22 tsepez@chromium.org Use UnownedPtr<> in CPDFSDK_FileWriteAdapter.
2018-08-22 hnakashima@chromium.org Remove unused setters in CBC_BarcodeMatrix and CBC_BarcodeRow.


Created with:
  gclient setdep -r src/third_party/pdfium@7e7e0b8379c4

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: If6a91d8909bcf65b2411a800e46f33aa0d5ed43c
Reviewed-on: https://chromium-review.googlesource.com/1185601Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585259}

This is very similar to http://crbug.com/868220

TBR=dcheng@chromium.org

Bug: 875856
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ifa6e29c60d593f16d154cae551ccef6c12540c4c
Reviewed-on: https://chromium-review.googlesource.com/1184391
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585258}

Bug: 819675, 734095
Change-Id: I9c9ff697d45118c220992b87ccbffe40ffa0bef5
Reviewed-on: https://chromium-review.googlesource.com/1185187Reviewed-by: Xi Cheng <chengx@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585257}

This is to support mojo sockets. With mojo sockets, we always try to read from
mojo data pipes (without caller explictly telling us to read), and we need a way
to cancel pending reads without having buffered data in socket subclasses.

Bug: 875855
Change-Id: I6570c5320c1ae84b6ef1eddd9ed8ba71e1c8a46c
Reviewed-on: https://chromium-review.googlesource.com/1185209Reviewed-by: Bence Béky <bnc@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585256}

Heap reporting suggests that we are wasting memory for them, too.

Bug: 845639
Change-Id: Ib24a6c6e879a96c95689631bcbec222126ffac83
Reviewed-on: https://chromium-review.googlesource.com/1181470
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585255}

This class is intended for use by the owner of the WindowService to
handle embeddings initiated by clients via ScheduleEmbedForExistingClient().
It roughly mirrors that of views::RemoteViewHost. I put this file in ws2 (but
in it's own directly) to reinfoce that it's optional and only for use with
the owner of ws2.

BUG=876513
TEST=covered by test

Change-Id: Ibc837fcb4619eefcfe90ca3c782446c581aef4cd
Reviewed-on: https://chromium-review.googlesource.com/1185362
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585254}

No change to production logic.

This switches every use of BaseJUnit4ClassRunner to AwJUnit4ClassRunner
under android_webview/javatests/. This also adds
@SkipCommandLineParameterization for each change, because the
BaseJUnit4ClassRunner did not run tests in both single & multiprocess
mode, only in single process mode (so we keep the same behavior).

This also adds a presubmit to prevent regressions.

Proposed on: http://shortn/_OS7nGlyaOn
Test: manually test presubmit prevents me from adding a test suite with
      BaseJUnit4ClassRunner
Test: run_webview_instrumentation_test_apk (everything passes, and the
      same number of tests are run as before this CL)

Change-Id: I36c0e549b1987cd1241407d989a2135f4d932a53
Reviewed-on: https://chromium-review.googlesource.com/1184234Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585253}

This pipes the call to GetProperty from ProtoDatabase through to
leveldb_proto LevelDB and finally onto the underlying Level DB, so we
can retrieve the value for tests and metrics.

Bug: 870813
Change-Id: I23f89685017eeae77e19c37847d6399cc8d6085f
Reviewed-on: https://chromium-review.googlesource.com/1169878
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585252}

Bug: 860654, 734095
Change-Id: I4a705377166d9579f27206f92371c02445f2d6bf
Reviewed-on: https://chromium-review.googlesource.com/1185081Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585251}

It's currently using base::WriteInto from string_util.h which it gets
transitively from components/leveldb_proto/proto_database_impl.h.

Change-Id: Ic795ad30ef79b9abf34ab028da202d92123ca249
Reviewed-on: https://chromium-review.googlesource.com/1185365Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585250}

Bug: 876149
Test: Multiselect several tabs in the middle of the strip.  There should be no separator on either end of the selection region.  On Win 7, dragging this set of tabs slightly to one side should show no separator on the end of the stationary tab by the newly-opened gap.
Change-Id: I68ebde9909c14683e50e9995ad9938e2cda6a1b3
Reviewed-on: https://chromium-review.googlesource.com/1185379Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585249}

Did not flake locally.

Bug: 659077
Change-Id: I8770032fb0944b32950987f5674583cf4b4241aa
Reviewed-on: https://chromium-review.googlesource.com/1180513Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585248}

This reverts commit 155b67d6.

Reason for revert: Test fix in latest EG.

Original change's description:
> [ios] Disables failing iOS12 tests while EG team investigates.
> 
> It seems with Xcode 10 items behind the keyboard are appearing as visible.
> This is likely an EG bug.
> 
> Bug: 854847
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I905d4e7809afe6d5d35e240b8e6c815f70cd41df
> Reviewed-on: https://chromium-review.googlesource.com/1109307
> Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Sergio Collazos <sczs@chromium.org>
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569242}

TBR=rohitrao@chromium.org,justincohen@chromium.org,sczs@chromium.org,gambard@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 854847
Change-Id: I5c1253288d99291fbd5e1677a6a0fb57c3142ffe
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1185801Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585247}

Bug: 112903714
Test: cast_bluetooth_unittests.
Change-Id: Iff20eeb9f2bb2c4b3aec4428eecc3a84980ed190
Reviewed-on: https://chromium-review.googlesource.com/1185525
Commit-Queue: Tiansong Cui <tiansong@google.com>
Reviewed-by: Bailey Forrest <bcf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585246}

Split existing tests for custom backgrounds out from general
SimpleJavascriptTests. These tests were never being run anways,
as they didn't start with 'test'.

Update local_ntp_browsertest.html with changes from local_ntp.html.

Bug: 857256
Change-Id: I251abfdc8aec75d896118d4ce0b251831b2bff43
Reviewed-on: https://chromium-review.googlesource.com/1184143
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585245}

These are more or less promisified versions of the existing FileEntry
and DirectoryEntry interfaces.

Tbr: jbroman@chromium.org
Bug: 872465
Change-Id: Idccd40c4ef3e94bbf12be2d5a1bb6e44019929ab
Reviewed-on: https://chromium-review.googlesource.com/1176555
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585244}

This change uses 'git cl format --full' for gles2_implementation.cc
to facilitate code review in this file. Otherwise, it's hard to
review when we have changes in this file.

Bug: 859249
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I74f04fa47ba4216d656cf96762354ac59057ee5f
Reviewed-on: https://chromium-review.googlesource.com/1184392
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585243}

Reland "MacViews: exit early when trying to drag without a drag image instead of crashing on Mojave"

This reverts commit a9ede579.

Reason for revert: ASAN should be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1185219

Original change's description:
> Revert "MacViews: exit early when trying to drag without a drag image instead of crashing on Mojave"
> 
> This reverts commit 24c96bd0.
> 
> Reason for revert: Mac ASan 64 Tests failing views_unittests, test
> case DragDropClientMacTest.ReleaseCapture,
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20ASan%2064%20Tests%20%281%29/43120
> 
> Original change's description:
> > MacViews: exit early when trying to drag without a drag image instead of crashing on Mojave
> > 
> > This is a temporary patch to merge back to 69 while we figure out the root cause.
> > 
> > Bug: 876201
> > Change-Id: Id87ac81f16b1cd3102c8605691421e8bc53dc401
> > Reviewed-on: https://chromium-review.googlesource.com/1183991
> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> > Commit-Queue: Leonard Grey <lgrey@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#585001}
> 
> TBR=ellyjones@chromium.org,lgrey@chromium.org
> 
> Change-Id: I80ec51eded1f8ba886eebc0c369ba23b96635c90
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 876201
> Reviewed-on: https://chromium-review.googlesource.com/1185142
> Reviewed-by: Sky Malice <skym@chromium.org>
> Commit-Queue: Sky Malice <skym@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585091}

TBR=ellyjones@chromium.org,skym@chromium.org,lgrey@chromium.org

Change-Id: I5f06f3f13b68acc40cfd2e9b91bf5a4692f5f3a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 876201
Reviewed-on: https://chromium-review.googlesource.com/1185802Reviewed-by: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585242}

These are histograms that have not been viewed in the last 6 months, but still
report data on the Stable channel. Set these histograms to stop being recorded
for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug)
reminding owners about the approaching histogram expiry – initially 30 days
prior to expiry, and also with follow-up alerts. The metrics dashboards will
also display a warning for anyone viewing a soon-to-expire histogram.

Owners and/or users of these histograms: Please comment on this CL if you think
that any affected histogram should not have an expiry date set! This should be
uncommon.

Otherwise, there are a few options going forward:
  * If the histogram is no longer needed, please send a follow-up CL to delete
    the recording code and to mark the histogram as <obsolete>. (You can also
    remove the expiry date in the same CL.)
  * If you want to set a different expiry date, please send a follow-up CL to do
    so.
  * If neither of the above apply, then keep an eye out for Monorail bugs as the
    histogram expiry date approaches.
For more info on how unused histograms are identified, see
https://goto.google.com/uma-unused-histograms-cleanup

Bug: 850539
Change-Id: Ib8f8c0b136f5851e4bd628030bf4b01395bf7e3a
Reviewed-on: https://chromium-review.googlesource.com/1111559Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585241}

Position the ripple container relative to the element instead of the
viewport. This will allow the ripple effect to transition with the
element instead of floating in place.

https://screencast.googleplex.com/cast/NDg3NjY2Njc1Mjk5MTIzMnxlNzNlODU3My1jOQ

Bug: 864823
Change-Id: I4352ff9792d16aaa59f610634d71bb46362141b0
Reviewed-on: https://chromium-review.googlesource.com/1184035
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585240}

Currently, the blink v8 initialization code uses a stack address-taken
variable to read the stack position. This fails with SafeStack because
it reads an address on the unsafe stack. Make it match the code in v8 to
read the stack position safely with either ASAN or SafeStack [1] by
using a compiler intrinsic.

[1] https://crrev.com/c/1162669

Bug: 864705
Change-Id: Ib972540eb0264d9f737eb8bc40c601b8b2cf1ab0
Reviewed-on: https://chromium-review.googlesource.com/1179265Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585239}

Having the content dependency creates various problems for builds and
unit tests.

Bug: internal b/111732331
Bug: internal b/112417856
Bug: internal b/112328895
Test: cast_test_lists for Android
Change-Id: I17ef19c77a8062225e9124d6eef58189dcfc504d
Reviewed-on: https://chromium-review.googlesource.com/1180426Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585238}

This method uses the NavigationController API to query the committed
navigational state on a Frame.

Bug: 852145
Change-Id: I49f9122753c393ef33d67905353b5ba1afad157a
Reviewed-on: https://chromium-review.googlesource.com/1182507Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585237}

Refactor the MaybeAllowImagePlaceholder() and MaybeAllowLazyLoadingImage()
functions to checks and enable the placeholder request bit separately.

This will help with lazyloading of CSS background images.

This is reland of below CL which had some formatting issues in local_frame.cc
https://chromium-review.googlesource.com/c/chromium/src/+/1178637

Bug: 846170
Change-Id: I9cf76d6e938a798d91b42d265964ad0c981054a1
Reviewed-on: https://chromium-review.googlesource.com/1180597
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585236}

Bug: 862425
Change-Id: I317be9b1cd25e921c04712fe0e04cdd0d77bd27b
Reviewed-on: https://chromium-review.googlesource.com/1185377Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585235}

When we start processing a gesture event, the
OnHasTouchEventHandler(false) IPC message may not yet
be received which means the |scrolling_touch_action_|
has no value and that results a crash.

This CL fixes the problem by call ResetTouchAction()
in TouchActionFilter's constructor. At that moment, the
|has_touch_event_handler_| is default to false which
will set both |allowed_touch_action_| and
|scrolling_touch_action_| to Auto.

Bug: 850238, 851644
Change-Id: I36f3edf2b9292347f184458aa059904af1a2f597
Reviewed-on: https://chromium-review.googlesource.com/1180592
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585234}

These are histograms that have not been viewed in the last 6 months, but still
report data on the Stable channel. Set these histograms to stop being recorded
for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug)
reminding owners about the approaching histogram expiry – initially 30 days
prior to expiry, and also with follow-up alerts. The metrics dashboards will
also display a warning for anyone viewing a soon-to-expire histogram.

Owners and/or users of these histograms: Please comment on this CL if you think
that any affected histogram should not have an expiry date set! This should be
uncommon.

Otherwise, there are a few options going forward:
  * If the histogram is no longer needed, please send a follow-up CL to delete
    the recording code and to mark the histogram as <obsolete>. (You can also
    remove the expiry date in the same CL.)
  * If you want to set a different expiry date, please send a follow-up CL to do
    so.
  * If neither of the above apply, then keep an eye out for Monorail bugs as the
    histogram expiry date approaches.
For more info on how unused histograms are identified, see
https://goto.google.com/uma-unused-histograms-cleanup

Bug: 850539
Change-Id: Ic888995f3a49848ecfe96c2aea55c1d2d365924c
Reviewed-on: https://chromium-review.googlesource.com/1126328Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585233}

Bug: 857266
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I58c2cb9e7b2ddf90dc9609945e418b27047f1e34
Reviewed-on: https://chromium-review.googlesource.com/1184043
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585232}

Bug: 875936
Change-Id: I27b4e463c128d3dc36fe8e72b47d18db99699410
Reviewed-on: https://chromium-review.googlesource.com/1181778Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585231}

Bug: 876044
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I3c37686f609acdcc479edb18c764e981c32c873c
Reviewed-on: https://chromium-review.googlesource.com/1184147Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585230}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I890952c728f084d643ac05a83b2eba4817fad699
Reviewed-on: https://chromium-review.googlesource.com/1185640
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585229}