- 22 Aug, 2018 40 commits
-
-
Brandon Wylie authored
Bug: 876811 Change-Id: Iaf8508f2cf9bd5b7243ba85572f783b86787dc98 Reviewed-on: https://chromium-review.googlesource.com/1185735 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#585288}
-
Wei Li authored
Since we use this class for both MSKP and PDF data processing, rename its name to MetafileSkia. Similarly, rename the util files and test files accordingly. TBR=jam@chromium.org,dcheng@chromium.org Change-Id: I295a106e1f48cb0110c5d8eb8539d1080e689c05 Reviewed-on: https://chromium-review.googlesource.com/1184157Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#585287}
-
Pavol Marko authored
The goal is to make policy-set trust anchors available as early as possible, instead of waiting for the user's private slot to be initialized. The following changes were made to achieve this: - UserNetworkConfigurationUpdater makes server and CA certificates available to observers as soon as ONC policy comes in. - UserNetworkConfigurationUpdater does not pass server and CA certificates to CertificateImporter for permanent import anymore. Only Client certificates are permanently imported from user policy. - PolicyCertService (which observes for user-policy-set cert changes) makes all user-policy-set server and authority certificates available to NSS as temp certificates through TempCertsCacheNSS. Planned follow-up work: The policy-set certs are not displayed in the Certificates settings view. A follow-up CL (CL:916681) will add support for that. browser_tests --gtest_filter=*PolicyProvided* Bug: 787602 Test: unit_tests --gtest_filter=*NetworkConfigurationUpdater* && Change-Id: I71aa8f1f91849b0b0ad24eb81ce3d1863fe7959c Reviewed-on: https://chromium-review.googlesource.com/873810 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#585286}
-
Yue Li authored
Bug: b/112564431 Test: Manual Test Change-Id: I6750c3d4c8727948165bf821b417cb47d5db0427 Reviewed-on: https://chromium-review.googlesource.com/1185862Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#585285}
-
Jian Li authored
Bug: 852577 Change-Id: Ibad70134b5f43877a39ef48e4a6fc99546d7ca3d Reviewed-on: https://chromium-review.googlesource.com/1182288 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#585284}
-
Konstantin Ganenko authored
Do not process pending request if initialize call is come with not inited dictionaries. R=groby@chromium.org Bug: 850424 Change-Id: I0dd7213f9865b2c5949fd6367c524edfd09febf1 Reviewed-on: https://chromium-review.googlesource.com/1085449 Commit-Queue: Rachel Blum <groby@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Cr-Commit-Position: refs/heads/master@{#585283}
-
Darren Shen authored
Launch was approved. Bug: 752657 Change-Id: I01ac04040b8b928c27512d203667dda234588153 Reviewed-on: https://chromium-review.googlesource.com/1184659Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#585282}
-
Łukasz Anforowicz authored
This reverts commit bc4a7725. Reason for revert: Speculating that this may cause flaky test crashes: https://crbug.com/876903 Original change's description: > CORB shouldn't make an exception for plugins, unless Flash actually runs > > Overview > ======== > > Flash has its own CORS-like mechanism (crossdomain.xml-based) and > therefore CORB (Cross-Origin Read Blocking) cannot be enforced for > requests initiated by Flash. > > This CL avoids making an exception for plugins, unless the given > renderer process is actually hosting a Flash plugin (and is therefore > capable of proxying network requests on behalf of Flash). This > means that the exception won't take place unless the user has > approved running Flash (via click-to-play / content settings / > enterprise policy - see the bug for more details). > > > Details > ======= > > This CL introduces a global set that stores process IDs of renderers > that host Flash. This set lives either in the NetworkService process or > (if NetworkService feature is disabled) in the IO thread of the browser > process. In both cases the global set is implemented and exposed by new > static methods of network::CrossOriginReadBlocking class. > > The CL populates the global set from > PluginServiceImpl::FindOrStartPpapiPluginProcess after all the security > checks have been done and the plugin process is ready to be used or > launched. > > The CL consults the global set before deciding to make a CORB exception > for a plugin request. This is done from network::URLLoader (used if > NetworkService feature is enabled) and from > CrossSiteDocumentResourceHandler (used otherwise). > > The CL removes items from the global set when RenderProcessHostImpl is > destroyed. > > > Bug: 874515 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I50484807c921a4daea08be8a00c67a3cf9c82cf0 > Reviewed-on: https://chromium-review.googlesource.com/1178885 > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585124} TBR=nasko@chromium.org,jam@chromium.org,lukasza@chromium.org Change-Id: I683e189587a2edfe8fbf516b757a6590c6441c9c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874515 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1185941Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#585281}
-
Jeremy Klein authored
I chatted with Shiba and Sebastian about this after looking at screenshots of Android Messages inline reply. It seems like 600 is the right match with the MD2 spec. R=stevenjb@chromium.org Bug: None Change-Id: I2e66180eb752049abf19452fd02cbe103cb516a4 Reviewed-on: https://chromium-review.googlesource.com/1185843Reviewed-by:
-
Angad Sidhu authored
Cleaned up android video capture factory methods to have consistent usage of camera API version. Change-Id: I835ea6debd5fe5fcc758207355c7936f0dccd84c Reviewed-on: https://chromium-review.googlesource.com/1185534 Commit-Queue: Angad Sidhu <angadsidhu@google.com> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#585279}
-
Xiyuan Xia authored
In single process mash, gaia dialog widget goes through the following stack: WindowServiceDelegateImpl::SetModalType -> wm::GetDefaultParent -> GetSystemModalContainer It does not have a |transient_parent| and hence assumed to be a user window and put into SystemModalContainer instead of LockSystemModalContainer. Since the dialog widget is created with a proper container parent, the CL fixes the issue by re-using existing container parent in GetSystemModalContainer. Bug: 876329 Change-Id: Iaf38273e852738b7d258a82f76dae9952051a08d Reviewed-on: https://chromium-review.googlesource.com/1185406 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Yuwei Huang authored
CL 1174982 only fixes layout issues when the screen has two cutouts that cancels each other when calculating the center of the safe area. We still have layout issues in single cutout scenario. This CL fixes these bugs: * Fix the calculation of the safe area center. It should be (width + inset.left - inset.right) / 2 instead of width / 2 + inset.left - inset.right. Same thing for y coordinate calculation. * The letterbox padding doesn't need to account for the safe insets since GetViewportScreenCenter() and GetViewportBounds() already account for that. Undoing the letterbox changes. * The SystemUIRect already takes cutouts into consideration. Since we no longer include safe insets in the letterbox padding, this CL makes DesktopCanvas ignore safe insets during calculation when the SystemUIRect is provided so that we don't double-apply the adjustment. Scenarios manually tested: {no cutout, 1 cutout, 2 symmetrical cutouts on top and bottom} x {portrait mode, landscape mode} x {touch input mode, trackpad input mode} x {desktop < screen (letterboxes showing), desktop >= screen (no letterbox)} x {keyboard showing, keyboard not showing} Bug: 831670 Change-Id: I0ad192b2a199c8c1d4d7740b52d4b074c3626640 Reviewed-on: https://chromium-review.googlesource.com/1185631Reviewed-by:Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#585277}
-
Dave Tapuska authored
Approved Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/HSfL38bAexE/n9QuIIILDwAJ BUG=861735 Change-Id: I3784f1a6b9c4f117563d273d5710cbe2784ac5ac Reviewed-on: https://chromium-review.googlesource.com/1185725Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#585276}
-
Tom Anderson authored
R=thestig BUG=876586 Change-Id: I97c9609bd49f034027f3eb18ae7f57fef14c2267 Reviewed-on: https://chromium-review.googlesource.com/1096401 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Lei Zhang authored
- Simplify ctors. - Rewrite GetCurrentPrintPreviewStatus() as ShouldCancelRequest(). Change-Id: Ie4cbb4dc7a56c1310ec4768687e800f7f40fe61a Reviewed-on: https://chromium-review.googlesource.com/1184507Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585274}
-
Yue Li authored
Bug: b/112310573 Test: Manual Test Change-Id: Ib6ca27acd261437043ebce55c57124458f21425e Reviewed-on: https://chromium-review.googlesource.com/1185367 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
-
Francois Doray authored
Relanding a CL that was reverted because of a variable that was unused in non-DCHECK builds and caused a compile failure. Original CL: Reviewed-on: https://chromium-review.googlesource.com/1171482 This CL adds a feature to use THREAD_MODE_BACKGROUND_BEGIN instead of THREAD_PRIORITY_LOWEST for ThreadPriority::BACKGROUND threads. This lowers the disk and network I/O priority of the thread in addition to the CPU scheduling priority. MSDN recommends using this setting for threads that perform background work. https://docs.microsoft.com/en-us/windows/desktop/api/processthreadsapi/nf-processthreadsapi-setthreadpriority TBR=gab@chromium.org Bug: 872820 Change-Id: I212fb77bb035088595b4944ce145a74d333c38eb Reviewed-on: https://chromium-review.googlesource.com/1185529 Commit-Queue: François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#585272}
-
Philip Jägenstedt authored
This will avoid full manifest rebuilds for Chromium developers when the manifest version changes. Bug: 876717 Change-Id: I6d552ad03936fb07cf559d0f072508e5ea2184a4 Reviewed-on: https://chromium-review.googlesource.com/1185009 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#585271}
-
Carlos IL authored
Couldn't reproduce the flakiness in those tests, so re-enabling with committed interstitials, will revert this CL if the flakiness returns. Also: This tests seem to be flaky in general, even without committed interstitials, e.g., crbug.com/874959 Bug: 863272 Change-Id: I64b5291513041e4dd9da9fa6125785fe4727a6c7 Reviewed-on: https://chromium-review.googlesource.com/1178928 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#585270}
-
Scott Violet authored
This converts ash to using ServerRemoteViewHost now that it hosts the WindowService. This also makes WindowServiceOwner create the WindowService immediately. BUG=876513 TEST=covered by tests Change-Id: I7aba636c9e87db4ab08e1ccab97acecacdfc59f9 Reviewed-on: https://chromium-review.googlesource.com/1185796Reviewed-by:
-
Nate Fischer authored
This adds support in WebView for blocking Malicious Unwanted Software (MUwS, UwS) AKA "Harmful software" via Safe Browsing. In this CL, we do the following: * Add new strings for the quiet MUwS interstitial (which is only used by WebView). These strings live in assets/stored-locales/ in the APK. * Whitelist the quiet MUwS strings (from the previous bullet point) as well as the previously chrome-only loud MUwS strings. These strings move from assets/locales/ (compressed, chrome-only resources) to assets/stored-locales/ (uncompressed, chrome+webview resources) in the APK. * Change WebView's declared list of threats to include MUwS * Change testSafeBrowsingDoesNotBlockUnwantedSoftwarePages, since this assertion is no longer valid. Change this to ensure we *do* block MUwS pages * Add a new test to ensure we can show quiet interstitials for MUwS * Change SafeBrowsingQuietErrorUI to respond to MUwS, and refactor it to be more similar to the LoudErrorUI. This change causes the following APK size changes (measurements taken with is_official_build = true), after unzipping the APKs with `unzip -lv $APK | grep 'pak'`. Monochrome: * assets/locales/en-US.pak: 20068 -> 19926 (-142) (improvement) * assets/stored-locales/en-US.pak: 7773 -> 8472 (+669) SystemWebViewGoogle: * assets/stored-locales/en-US.pak: 7773 -> 8472 (+669) A later follow-up will add this page to chrome://interstitials. Bug: 729268 Bug: 729271 Bug: 729272 Test: run_webview_instrumentation_test_apk -f SafeBrowsingTest#* Test: Manual - load big and small interstitials, verify it looks correct Change-Id: I79e81f48d8b2ceb1ddcad7fab2d3bed3fcb479ae Reviewed-on: https://chromium-review.googlesource.com/1182945 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#585268}
-
Cole Winstanley authored
Bug: chromedriver:2553 Change-Id: I4c8d50c819f128ced652bc397bb294de3984ed2e Reviewed-on: https://chromium-review.googlesource.com/1185783Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Cole Winstanley <cwinstanley@google.com> Cr-Commit-Position: refs/heads/master@{#585267}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4a0ba280b94c..92b161fab40f git log 4a0ba280b94c..92b161fab40f --date=short --no-merges --format='%ad %ae %s' 2018-08-22 enne@chromium.org Add emulate_abs_int_function workaround 2018-08-22 scroggo@google.com Switch SkCodec to use skcms 2018-08-22 brianosman@google.com Remove unused sRGB mip-map support 2018-08-22 kjlubick@google.com [PathKit] Add asm.js build and test jobs 2018-08-22 benjaminwagner@google.com [infra] Remove NexusPlayer Vulkan jobs. 2018-08-22 mtklein@google.com streamline interface to GrColorSpaceXform::Make() 2018-08-22 brianosman@google.com Make SkColor4f <-> SkColor skip sRGB conversion 2018-08-22 enne@chromium.org Add unfold_short_circuit_as_ternary workaround Created with: gclient setdep -r src/third_party/skia@92b161fab40f The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium: 642227,chromium:829614,chromium: 307751,chromium:829614 TBR=fmalita@chromium.org Change-Id: I6ed6e1fe370f351b38d74f862a6a79ee5eb9bf20 Reviewed-on: https://chromium-review.googlesource.com/1185501Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585266}
-
Tom Anderson authored
GTK2 code was historically kept around to keep the electron build working. But as of Nov 26, 2017, electron now uses GTK3 [1], so it should now be safe to remove all of the old GTK2-only code. [1] https://github.com/electron/electron/issues/2927#issuecomment-347092515 BUG=876558 R=sky Change-Id: I78402053ae508ccd8fc7ac73697a861bb1ebacf6 Reviewed-on: https://chromium-review.googlesource.com/1183858 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Fredrik Hubinette authored
Also fix similar problem for VP9 (in a code path we seldom hit) Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I86dc30003f71d5a1b32db7986f95c1c9001667a1 Reviewed-on: https://chromium-review.googlesource.com/1184246Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#585264}
-
Matt Mueller authored
Change-Id: Ide9ed87b0976edbdfc9d14cbed10e073391d4613 Reviewed-on: https://chromium-review.googlesource.com/1185421Reviewed-by:
-
Dominic Mazzoni authored
We made a change to the ignored calculation in crrev.com/c/990537 that ended up making it so that <body tabindex=-1> would no longer be ignored, but this leads to weird side effects. Note that in our accessibility tree now, the root "web area" element is not the same as the HTML BODY element, which is usually ignored. Firefox seems to treat the BODY as the root of the tree, in comparison. It'd be interesting to try to fix that, but that'd be a huge change. Bug: 862100 Change-Id: Ibfa54570bd20205d76cb66f50211431a32704bb2 Reviewed-on: https://chromium-review.googlesource.com/1179075Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#585262}
-
Mike Frysinger authored
Change-Id: Ibd09d463d445c23698253c9e206cc37107b3bdec Reviewed-on: https://chromium-review.googlesource.com/1185212Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 875729 Change-Id: I3a80290e059cd9b21f660572700427d92ef9f84b Reviewed-on: https://chromium-review.googlesource.com/1181929Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#585260}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/03fdf3a2b5ee..7e7e0b8379c4 git log 03fdf3a2b5ee..7e7e0b8379c4 --date=short --no-merges --format='%ad %ae %s' 2018-08-22 hnakashima@chromium.org Change in/out params in CBC_PDF417Writer::Encode to only out. 2018-08-22 tsepez@chromium.org Use UnownedPtr<> in IJS_Runtime. 2018-08-22 tsepez@chromium.org Use UnownedPtr<> in JBig2_TrdProc, part 2. 2018-08-22 tsepez@chromium.org Use UnownedPtr<> in CPDFSDK_FileWriteAdapter. 2018-08-22 hnakashima@chromium.org Remove unused setters in CBC_BarcodeMatrix and CBC_BarcodeRow. Created with: gclient setdep -r src/third_party/pdfium@7e7e0b8379c4 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If6a91d8909bcf65b2411a800e46f33aa0d5ed43c Reviewed-on: https://chromium-review.googlesource.com/1185601Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585259}
-
Clark DuVall authored
This is very similar to http://crbug.com/868220 TBR=dcheng@chromium.org Bug: 875856 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ifa6e29c60d593f16d154cae551ccef6c12540c4c Reviewed-on: https://chromium-review.googlesource.com/1184391 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#585258}
-
Peter Beverloo authored
Bug: 819675, 734095 Change-Id: I9c9ff697d45118c220992b87ccbffe40ffa0bef5 Reviewed-on: https://chromium-review.googlesource.com/1185187Reviewed-by:
Xi Cheng <chengx@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#585257}
-
Helen Li authored
This is to support mojo sockets. With mojo sockets, we always try to read from mojo data pipes (without caller explictly telling us to read), and we need a way to cancel pending reads without having buffered data in socket subclasses. Bug: 875855 Change-Id: I6570c5320c1ae84b6ef1eddd9ed8ba71e1c8a46c Reviewed-on: https://chromium-review.googlesource.com/1185209Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#585256}
-
Maks Orlovich authored
Heap reporting suggests that we are wasting memory for them, too. Bug: 845639 Change-Id: Ib24a6c6e879a96c95689631bcbec222126ffac83 Reviewed-on: https://chromium-review.googlesource.com/1181470 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#585255}
-
Scott Violet authored
This class is intended for use by the owner of the WindowService to handle embeddings initiated by clients via ScheduleEmbedForExistingClient(). It roughly mirrors that of views::RemoteViewHost. I put this file in ws2 (but in it's own directly) to reinfoce that it's optional and only for use with the owner of ws2. BUG=876513 TEST=covered by test Change-Id: Ibc837fcb4619eefcfe90ca3c782446c581aef4cd Reviewed-on: https://chromium-review.googlesource.com/1185362 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to production logic. This switches every use of BaseJUnit4ClassRunner to AwJUnit4ClassRunner under android_webview/javatests/. This also adds @SkipCommandLineParameterization for each change, because the BaseJUnit4ClassRunner did not run tests in both single & multiprocess mode, only in single process mode (so we keep the same behavior). This also adds a presubmit to prevent regressions. Proposed on: http://shortn/_OS7nGlyaOn Test: manually test presubmit prevents me from adding a test suite with BaseJUnit4ClassRunner Test: run_webview_instrumentation_test_apk (everything passes, and the same number of tests are run as before this CL) Change-Id: I36c0e549b1987cd1241407d989a2135f4d932a53 Reviewed-on: https://chromium-review.googlesource.com/1184234Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#585253}
-
Troy Hildebrandt authored
This pipes the call to GetProperty from ProtoDatabase through to leveldb_proto LevelDB and finally onto the underlying Level DB, so we can retrieve the value for tests and metrics. Bug: 870813 Change-Id: I23f89685017eeae77e19c37847d6399cc8d6085f Reviewed-on: https://chromium-review.googlesource.com/1169878 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#585252}
-
Finnur Thorarinsson authored
Bug: 860654, 734095 Change-Id: I4a705377166d9579f27206f92371c02445f2d6bf Reviewed-on: https://chromium-review.googlesource.com/1185081Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#585251}
-
Troy Hildebrandt authored
It's currently using base::WriteInto from string_util.h which it gets transitively from components/leveldb_proto/proto_database_impl.h. Change-Id: Ic795ad30ef79b9abf34ab028da202d92123ca249 Reviewed-on: https://chromium-review.googlesource.com/1185365Reviewed-by:
-
Peter Kasting authored
Bug: 876149 Test: Multiselect several tabs in the middle of the strip. There should be no separator on either end of the selection region. On Win 7, dragging this set of tabs slightly to one side should show no separator on the end of the stationary tab by the newly-opened gap. Change-Id: I68ebde9909c14683e50e9995ad9938e2cda6a1b3 Reviewed-on: https://chromium-review.googlesource.com/1185379Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#585249}
-
