- 14 May, 2020 40 commits
-
-
Samuel Huang authored
Bundle wrapper test scripts calls such as /out/Debug/bin/monochrome_public_bundle install /out/Debug/bin/trichrome_chrome_google_bundle run use the '-m' flag to include DFMs. In particular, the switch for the DevUI DFM is '-m dev_ui' (and '-f dev_ui' for fake install). However, most developers who use these test scripts don't care about this detail. This CL makes the DevUI DFM installed by default when these build scripts are used, to simplify development. The master list |default_modules_for_testing| is in chrome_bundle_tmpl.gni, and currently on has "dev_ui". To make it still possible to test install flows of DevUI DFM, this CL also adds the new flag '--no-module' to exclude non-base DFMs that are installed by default (currently only {dev_ui}). Fake installs, e.g., '-f dev_ui', also excludes the default install. Bug: 1081812, 987040 Change-Id: Icf87515382cc6d0b3d52fc3fa1914c7a4830b6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197339Reviewed-by:Egor Pasko <pasko@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#768784}
-
Dana Fried authored
This reverts commit 1f434e5c. Reason for revert: Uninitialized variable in phishing_classifier_delegate.h|cc causes many MSan tests to fail. See attached bug and associated builders. Bug: 1082797 Original change's description: > Add UMA metrics to Phishing Delegate. > > The metrics are to help better understanding > what is going on in the phishing delegate, such > as when the phishing detection call is blocked > by page capture or if it's destructed before > the call is finished. > > Bug: 1068621 > Change-Id: I1f7d55fc89f448acbec6afa7e3869de5591503a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181566 > Commit-Queue: Bettina Dea <bdea@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768675} TBR=isherman@chromium.org,bdea@chromium.org,drubery@chromium.org Change-Id: I9d9dcef0f6cd56142940c38b431745e5aee81022 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1068621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202120Reviewed-by:
Dana Fried <dfried@google.com> Commit-Queue: Dana Fried <dfried@google.com> Cr-Commit-Position: refs/heads/master@{#768783}
-
Andrew Grieve authored
This reverts commit 0b505061. Reason for revert: Trybots are failing with: ../../chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelFilterProvider.java:20: error: could not resolve EmptyTabModelSelectorObserver e.g.: https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-arm64-rel/555380 Original change's description: > Replace EmptyTabModelSelectorObserver with default methods. > > Bug: 1082248 > Change-Id: I51b883c8fbefcf391750110b3477ea84c78f7a5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199890 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768767} TBR=dtrainor@chromium.org,hnakashima@chromium.org Change-Id: I220287bc7077ab590c6e9d4272784ef3a958bf6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202118Reviewed-by:
-
Ken Buchanan authored
The Web Authentication feature policy which allows pages to delegate the ability to perform public-key navigator.credentials.get operations is enabled by default. Bug: 993007 Change-Id: I8d9330a8fbc8c9881e0b046db4c06b36de28c866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199702Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Rick Byers <rbyers@chromium.org> Auto-Submit: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#768781}
-
Yutaka Hirano authored
Initial empty documents have a special navigation path, which leads to missing reports for cross-origin embedder policy violations. Fix the issue by creating a CrossOriginEmbedderPolicyReporter in the special navigation path. Bug: 1052764 Change-Id: I5825eb2946dc00f9e042b55e602fd786dc2d1adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097800 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#768780}
-
Chris Sharp authored
This new policy allows admins to control what domains AutoOpenFileTypes applies to. BasedOnExtension was removed from a lot of function names since extension isn't the only factor when determining if a file is auto-opened. Bug: 92846 Change-Id: I20cbc254c841a03be3032566ebc2ecd6e91e913c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196245Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#768779}
-
Rayan Kanso authored
Confirmed this is now working by forcing an update via chrome://webapks Bug: 1074351 Change-Id: Ic5b6ccaa725fbf24566473f4ff56c179aa6650d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201818Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#768778}
-
Sahel Sharify authored
This refactoring is needed for addressing review comments on https://chromium-review.googlesource.com/c/chromium/src/+/2168009/8 Change-Id: I49d3a4a8f0d0f5c7640dcb01f66ce3ba4f145951 Bug: 1026667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199889Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#768777}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/493b76784ef1..c7172a2a6808 git log 493b76784ef1..c7172a2a6808 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 pfaffe@chromium.org Disable the flaky Animations Panel test Created with: gclient setdep -r src/third_party/devtools-frontend/src@c7172a2a6808 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1082735 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iac0f1f728448de30b22dc9505abbc8c71f6b2774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201739Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768776}
-
Balazs Engedy authored
This patch adds a flavor of the quiet notification permission UI to be shown on sites known to trick or force users to accept the notification permission. Bug: 1081233 Change-Id: I4ed49fc1b260c261824efe7741f155ed2f7d643a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199150Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#768775}
-
Dave Tapuska authored
In crrev.com/cc788dde there was a code path that the latency info wasn't getting copied. This fixes that issue. Fortunately this code path is not used yet, but it was failing tests when this code gets activated. BUG=1073560 Change-Id: I46cfc0b5c367e8ca1c309e042dc3c7ccc32481b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199868Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#768774}
-
Yuki Shiino authored
Adds missing ArgumentValue method to NVT<union types>. Bug: 839389 Change-Id: I6a8c980eaba4df5ffe4901db6e25abfa6023a174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201797Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#768773}
-
Min Qin authored
Getting application locale may need to read disk, and that causes NTP to crash This CL fixes the issue by using the acceptLanguages instead, and also fixes the TileManager logic to support AcceptLanguages Bug: 1082649 Change-Id: I5212baf40d6f7cd0344d2dd0267eaafaf31156cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200667Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768772}
-
Yuki Shiino authored
Adds missing default values to BidirectionalStream, and registers the generated files. Bug: 839389 Change-Id: I714556867f05ff8907c9cba0722aebd22e28e785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200779Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#768771}
-
Raymond Toy authored
Add Arm NEON support for main loop of WaveShaperCurveValues. This is the Arm version of the x86 SIMD version of the loop. Running the web-audio benchmark on a pixel2 gives these results (with 50 runs of 20 sec each): Without CL (scalar): TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Baseline 1834 1834 1896 1991 2249 2615 2075.42 202.6 WaveShaper-1x 672 672 729 826 984 1254 872.47 170.62 WaveShaper-2x 11198 11198 11428 11808 12083 12731 11793.08 406.35 WaveShaper-4x 17866 17866 18371 18696 19586 21831 19075.35 1017.58 With CL (vector): TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Baseline 1786 1786 1885 2074 2286 2551 2091.17 217.88 WaveShaper-1x 508 508 536 582 768 1129 650.01 148.17 WaveShaper-2x 10819 10819 11109 11244 11697 11019 11430.37 485.8 WaveShaper-4x 17359 17359 17709 18384 19014 20219 18376.45 750.02 Time relative to scalar WaveShaper-1x 0.756 WaveShaper-2x 0.966 WaveShaper-4x 0.972 So the 1x case is about 25% faster, and the difference is statisically significant at the 1% level. Only 3-4% improvement with oversampling, but these are also statistically significant. Bug: 1013118 Change-Id: I63a2b93b0a3eb68de18635fa8cce9b225b829e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194786Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#768770}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f80ec7eedf59..fc43dd4cbbcb git log f80ec7eedf59..fc43dd4cbbcb --date=short --first-parent --format='%ad %ae %s' 2020-05-14 dberris@chromium.org Dashboard: Log the number of rows created 2020-05-14 dberris@chromium.org auto-triage: Auto-close issues with recovered regressions 2020-05-14 abennetts@google.com pinpoint-ux: Improve readability of “Found n differences” message. Created with: gclient setdep -r src/third_party/catapult@fc43dd4cbbcb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1069331,chromium:1081607 Tbr: nuskos@google.com Change-Id: I2857f4c3738ca17170f7fc079201082888bcca55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200742Reviewed-by:
-
Manas Verma authored
If the port of an origin is the default port for its scheme, then it should be trimmed. Fixed: 1082499 Change-Id: I40631dd6f6fd0525f92e623f0e207bf9f60ccba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199869 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#768768}
-
Henrique Nakashima authored
Bug: 1082248 Change-Id: I51b883c8fbefcf391750110b3477ea84c78f7a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199890Reviewed-by:
-
Erik Staab authored
TBR=blundell@chromium.org Bug: 1081407 Change-Id: I8726a5c75a151a8bf638461821f381de9ee5a5bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201406Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#768766}
-
Matthias Körber authored
Currently, autofill::FillCreditCardNumberField() fills the complete rest of the credit card number from an offset calculated from the previous field's |max_length| attribute. The logic relies on the automatic truncation of the value. If the |max_length| value is changed in by JS in the meantime, autofill would fill the whole rest of the number and not only the intended portion. With this change, the value is already truncated by autofill. Change-Id: I7eef43d8abd83081e903bbdb0b12dc78846c9b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190214 Auto-Submit: Matthias Körber <koerber@google.com> Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#768765}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/effa3ad93640..e9ada4599375 git log effa3ad93640..e9ada4599375 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 treehugger-gerrit@google.com Merge "Support ion_stat" 2020-05-14 primiano@google.com Merge "Use exec(curl) for downloading artifacts" Created with: gclient setdep -r src/third_party/perfetto@e9ada4599375 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I47005aed4283ee32f0e7a56e03eec1cda0c7c471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201736Reviewed-by:
-
Clemens Arbesser authored
Previously, implicit login selection was only enabled if the list of available choices had degenerated to a single item. Now, it is also enabled if a default option is set and there are no password manager logins available. This CL also fixes a number of issues where the action would be allowed to prematurely terminate because the check for OnlyLoginRequested was erroneous and did not account for some of the more recent section like date/time and additional prepended/appended input sections. Bug: b/155971226 Change-Id: Ic7df9e8381265207debe6c1f17229285ade2112f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199115Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#768763}
-
Mathias Carlen authored
We forgot to reenable these tests. They pass locally and were already passing when we last looked into this. The reason for the flakes is usually the underlying testing infra that has a hick-up. The last instance being a "Power off" widget obscuring the button we needed to click. Bug: 1057806 Change-Id: Idbbd63afca3d8df0da20b228f863498677d40024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201556Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#768762}
-
Alan Cutter authored
GURL::GetOrigin() doesn't handle blob:* URLs. Use Origin class instead. Also update web app window UI to use full URL if we are unable to parse the origin out of it instead of showing nothing. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=446212&signed_aid=n--6M0MuMy7reB9rCSzlBQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=446381&signed_aid=32H8pSYcBHXM7jZ9LMdxEg==&inline=1 Bug: 1080934 Change-Id: Ifd107797a9e6c40ec6dbbd4891e991db5725484a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198697 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#768761}
-
Hesen Zhang authored
Bug: 1073550 Change-Id: I2a9d0d10839007a1a170a44014a3f9dbbe1f1904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198719 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#768760}
-
Amr Aboelkher authored
This reverts commit 7f416325. Reason for revert: the ios-simulator-cronet builder is failing because of that change Original change's description: > [ios] Update application extension rpath > > As application extension may share private frameworks with the app > they are bundled in, the rpath needs to look both in the extension > private frameworks and the app private frameworks. > > Bug: none > Change-Id: I5686d20d8e3f131929ec14caa932bda18bf7d517 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201096 > Reviewed-by: David Jean <djean@chromium.org> > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768745} TBR=sdefresne@chromium.org,javierrobles@chromium.org,djean@chromium.org Change-Id: Ie83c0aca04c83581ef9bd0bcbff992d9449cc0d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201601Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#768759}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a0a4480f1261..f8cb70a343a7 git log a0a4480f1261..f8cb70a343a7 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9330db6b..8ffd7240 (768590:768712) Created with: gclient setdep -r src/third_party/webrtc@f8cb70a343a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I124e85739c153b10e21d3f545bff82f85fdeb9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201738Reviewed-by:
-
Anton Paymyshev authored
Button callbacks should clear |controller_| pointer as |controller_| deletes itself after calling Accept(), Cancel() or Close(). Otherwise SettingsResetPromptDialog dtor crashes trying to Close() already freed |controller_|. Bug was recently introduced with https://crrev.com/c/2028171. Change-Id: I9c9bc91f15bc639d4ebbb279091171fb07173825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199056Reviewed-by:
-
Elly Fong-Jones authored
TOOLKIT_VIEWS is always defined when building //cbui/views, so these are dead code. Bug: None Change-Id: Id22b091c647c754c52077efbfa0a91da61aa9043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199317Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#768756}
-
Luke Zielinski authored
TBR=robertma Bug: 1082739 Change-Id: If1ec42f8176fe4a187e4dc0ffb3f7e6bbcbfc16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201403Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#768755}
-
Travis Skare authored
Previously, the last-used QR code was used. Change-Id: I00d35ba688af4290eda0c606803d0a5103ee30a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169067 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#768754}
-
Peter Wen authored
This check duplicates our presubmit unused imports check. Most IDEs also already allow optimize imports on save action. This allows intermediate builds to contain unused imports and leaves enforcing no unused imports to presubmit checks. Bug: None Change-Id: Ib959ae52ccd93b4f71a29dfe6f605923503a2fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199600 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 1082276 Change-Id: I38408bdf2fde98ae3599b5f10b6001f9fdffb1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199995 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#768752}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cac6d369. With Chromium commits locally applied on WPT: 59c99fcd "Clipboard API Tests: Automate Web Platform Tests" 7a588d8c "[client hints] Match update behavior to the spec." 46619c73 "[client hints] Enforce the top-frame requirement." 3c2baf64 "[Client-Hints] Fix cross-origin redirect leak" c15bc63c "[EventTiming] Test more event types" 6640d9f9 "[EventTiming] Wrap lines better in event-timing-test-utils" 200214d5 "[client-hints] Ensure by-default&legacy hints behave with XO redirects" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ie2afa59ac11d17f54aa001ac2a448123d647923f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201456Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768751}
-
Michael Thiessen authored
Bug: 1081861 Change-Id: Ife8c169371fafdfb5b4b45de8a4f71e28d600310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197150 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Matt Menke authored
Also make IsolationInfo mandatory for requests using a profile's main NetworkContext. In the future this will be extended to other APIs that take NIKs (WebSockets, DNS lookups, etc). Bug: 1082280 Change-Id: I630f501cfaf57ea01af8af05c37c9bd79bda20ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180542 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#768749}
-
Lukasz Anforowicz authored
In template specializations template parameters (e.g. |T| or |T2| in MyTemplate in tests/template-specializations-original.cc) get substituted with an actual class (e.g. |SomeClass| or |int|). In an *implicit* specialization, these substitutions are "overlaid" / "overimposed" on top of the template definition and this can lead to generating conflicting replacements - for example the same |t_ptr_field| definition can get replaced with: 1. T* t_ptr_field -> CheckedPtr<T> t_ptr_field // expected 2. T* t_ptr_field -> CheckedPtr<SomeClass> t_ptr_field // undesired After this CL, the FieldDecls in an implicit template specialization (i.e. example2 above) are ignored. This avoids generating a conflicting replacement. Bug: 1069567 Change-Id: I8d2487fdece703421ceb08be67bf6f817e44c03d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156068 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#768748}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff46862e0fb2..f348b224a38d Created with: gclient setdep -r src-internal@f348b224a38d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC amraboelkher@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: amraboelkher@google.com Change-Id: I03a50026df7306a420ff7f48aff3b088972c0815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201298Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Allen Bauer authored
Bug: 1044687 Change-Id: I71c5a1e0d01be2c8581327cbc3094c464dea8b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200087Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#768746}
-
Sylvain Defresne authored
As application extension may share private frameworks with the app they are bundled in, the rpath needs to look both in the extension private frameworks and the app private frameworks. Bug: none Change-Id: I5686d20d8e3f131929ec14caa932bda18bf7d517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201096Reviewed-by:
David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#768745}
-
