- 01 Apr, 2019 40 commits
-
-
Michael Ludwig authored
It is supposed to use params.visible_rect instead of quad->visible_rect to get the correct relative relationship between the original rectangle and the texture coordinates. If params.visible_rect isn't used, when a scissor test was explicitly applied, ScaleRectProportional would not calculate the proper visible texture coordinates (basically it would think the visible rectangle hadn't been clipped from the original). Bug: 948225 Change-Id: I426443484f5f0b8391e23fe38e29328807e5a2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546785 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#646515}
-
Harley Li authored
Bug: 946386 Change-Id: I19951d9824e989947e474786ede85d97515e9b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546728Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#646514}
-
Karen Qian authored
Blink bot for concurrent marking. Bug: 945858 Change-Id: Ib88047bc251bcd70c977f6db82e3d076f085f54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535050 Commit-Queue: Karen Qian <karenqian@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#646513}
-
Min Chen authored
Related cl: https://chromium-review.googlesource.com/c/chromium/src/+/1490503 We set the enter animation type in the constructor of TabletModeWindowState. This is not correct since the constructor will be called in many cases, e.g, open a new window in tablet mode. Not only when entering tablet mode. This change going to set the enter animation type only when entering tablet mode to avoid incorrect window update bounds animation in tablet mode. Bug: 916331 Change-Id: I5a7b91bc0d5969038eaa412a7234ad0bae8b2120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546784Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#646512}
-
Alex Newcomer authored
1. Move search_util.h/cc to app_list_metrics.h/cc in ash/public. 2. Record assistant results (which are launched from the ash side) in the controller launch flow. Bug: 946768 Change-Id: If9d42b0f0e25e6ec44c40f27a9e989dcdb9f711f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541945 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#646511}
-
Jacob Dufault authored
- Rework how JSCallsContainer stores pending calls; store the actual values directly instead of storing a closure - Rework BaseWebUIHandler::CallJS so it is a single template function with no overloads - BaseWebUIHandler::CallJS can now optionally now record the outgoing JS call - BaseWebUIHandler::Add(Raw)Callback can now optionally record the incoming JS call The recording can be used by a test to validate what was actually sent to JS as an alternative to creating a *View class that is then mocked. Deferred JS execution is now built on-top of the recording capabilities instead of being an isolated/independent feature. TBR=michaelpg@chromium.org Bug: 928555 Change-Id: Ie3e7d9dff3cd9224810124960b9ba481aef9f0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534710 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#646510}
-
Mike Wittman authored
This reverts commit a92a56cb. Reason for revert: Causes flaky test failures on module lookups. Original change's description: > [Sampling profiler] Move context frame recording outside the native unwinders > > Allows the native unwinders to be used to unwind from arbitrary frames, > not just from the context frame. This is required to support restarting > native frame unwinding after v8 unwinding. > > Bug: 909957 > Change-Id: I8c87d26c981f98bd842aa8467fcc23faffdec7b0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540285 > Commit-Queue: Mike Wittman <wittman@chromium.org> > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#646333} TBR=wittman@chromium.org,lgrey@chromium.org Change-Id: I34491f940d3390d6c5ec0dadfe83532a8a05e564 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 909957, 948302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548362Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#646509}
-
Min Qin authored
Currently InProgressDownloadManager is created for each DownloadManager. And BrowserContext's file path is used to store history downloads. However, for webview, there is no need to store history information. So just use an empty dir should work. BUG=946183,947921 Change-Id: Ifb06065a909fc36d3ca749fd96820e36984eca9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548141 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#646508}
-
Eugene But authored
This gives embedder a chance to handle unsupported URL scheme by launching a native app or doing something else. Bug: 948243, 945814, 899827 Change-Id: I7e5d786f52cd46ee74569ac9f310f681de700f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548374Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#646507}
-
Bret Sepulveda authored
This patch erases lines from the log file that Breakpad uses to record crashes that fall within the history clear range. This file is used on Linux, Android, and Chrome OS, and may be present even when the data in the file does not show up in chrome://crashes. Bug: 825994 Change-Id: I41f73ec9698398923fe67ed14c703375a9f046f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460065Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#646506}
-
Tyler Ouyang authored
CL https://crrev.com/c/822612 intended to support additional_readme_paths.json. However, when Chrome is not built from src, this feature is broken because it's relying on paths relative to src. Thus dozens of entries specified by third_party/android_deps/additional_readme_paths.json and third_party/angle/additional_readme_paths.json are not added to chrome://credits page. This change simply added root to the relative path to ensure existence check will not fail due to relative paths. Bug: 946181 Change-Id: I7979f92a1b542bdccac54f7dfb7bdec3d267ee55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545199Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Tyler Ouyang <tylero@microsoft.com> Cr-Commit-Position: refs/heads/master@{#646505}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/02df81c0a28f..5677ecd6cbab git log 02df81c0a28f..5677ecd6cbab --date=short --no-merges --format='%ad %ae %s' 2019-04-01 roopeshr@google.com chromeos_config: add mistral-paladin to master-paladin Created with: gclient setdep -r src/third_party/chromite@5677ecd6cbab The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: If85db19eb8afc6ef309b18944ffcd6e118230eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548100Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646504}
-
Johannes Henkel authored
This reverts commit 03844362. Reason for revert: heap-snapshot-with-multiple-retainers.js no longer flaky. See https://chromium-review.googlesource.com/c/chromium/src/+/1546939 TBR=pfeldman Change-Id: Ie6917ebadb843c3c0b025a8113345cc9c8994011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548048Reviewed-by:
Johannes Henkel <johannes@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#646503}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/14487c34f7d9..20b0c33913e4 git log 14487c34f7d9..20b0c33913e4 --date=short --no-merges --format='%ad %ae %s' 2019-04-01 natlee@microsoft.com Buffer DestroyImpl check for buffer resource to avoid double free Created with: gclient setdep -r src/third_party/dawn@20b0c33913e4 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:947323 TBR=cwallez@chromium.org Change-Id: I0b03f3512f3fd9b34925030ee4361f080ea554d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548098Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646502}
-
Brian White authored
Bug: 948136 Change-Id: I23efb918e6467cae511fc53b0c8058f34ee6862c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546879 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#646501}
-
Bret Sepulveda authored
BrowserNonClientFrameView::UpdateClientArea has no default behavior and is never overriden. It is only ever called from BrowserNonClientFrameViewAsh::OnTabsMaxXChanged, which is the only override of TabStripObserver::OnTabsMaxXChanged. This patch deletes those methods. Change-Id: Ifa943298d6a925b2f4c0cb0120164324fbacd42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545493 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#646500}
-
Rahul Arakeri authored
The flag kCompositorThreadedScrollbarScrolling needs to be made accessible to LayerTreeHostImpl. This CL moves the flag to ui_base_features.h and plumbs it through to LTHI via LayerTreeSettings CL 1512536 will use it once it is checked in. Bug: 947365 Change-Id: Iadd24676aa8c3713fbe961d5403d853108f24230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545175Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#646499}
-
Stephen Chenney authored
The current Blink Rendering Core UKM process of averaging over 30s intervals, and tracking a worst case has 2 major disadvantages: * Apart from the worst case, we have only a single value to characterize the system behavior within the 30s interval. We cannot distinguish between many very fast frames and a few very slow ones, versus all frames being of medium duration. * We cannot analyse how frame times are broken down among phases. The existing data includes records with a phase using more than 100% of the main frame time, which is certainly an artifact of averaging values. This patch switches to a sampling method, whereby we emit a record at a random time such that we achieve a set rate, initially the same 1 event per 30s we have been using. As a result, we drop the worst case metrics (halving our data output). There is no change of behavior for UMA. Bug: 869996 Change-Id: I5df163414f88da1c53d917c0dcd39ebd87eab56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524997Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#646498}
-
dpapad authored
Bug: 948237 Change-Id: I9138ee2e8e49cdb2ea5a19cd78ccde5e631d9b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548234 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#646497}
-
Garrett Beaty authored
OS X 10.14.5 is a beta release and should be used for and only for builders intended to test beta OS X. Bug: 947561 Change-Id: Ie35828cb712d395ef0e4f3c9e0db5da64ca99360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548240 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#646496}
-
Becky Zhou authored
Bug: 934498 Change-Id: I67d031386146680fafb87cfab5fa8800531b5abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546860 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#646495}
-
kylechar authored
1. Add logic to handle failure to bind context providers to current thread. For kTransient errors it will retry context creation. For kFatal errors it will just crash. This matches the current behaviour in GpuProcessTransportFactory for fatal errors as there is no software compositing fallback on Chrome OS. 2. Create a single shared main thread context provider rather than one per LayerTreeFrameSink. Each context provider allocates a significant amount of shared memory for the command buffer. This matches what we do in VizProcessTransportFactory. 3. Pass in a GpuChannelEstablishFactory* rather than Gpu*. We are now only using the GpuChannelEstablishFactory methods. 4. Change the context stream priority to high. This matches the existing browser compositor stream priority although it's a change for non-browser mus clients. This seems fine because the only other client is the keyboard shortcut viewer but in the future stream priority may need to be adjustable per client. Bug: 908608 Change-Id: Ib310e3649e1af325f53f8610533997ea35d4fff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534287 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#646494}
-
David Benjamin authored
The base::CommandLine was overly broad. The flakiness analysis of https://chromium-review.googlesource.com/c/chromium/src/+/1539787 reported that DumpAccessibilityTreeTest.AccessibilityObject and QuicAllowedPolicyIsNotSet.NoQuicRegulations were flaky. The latter has a 1.8% confidence and is on a non-TSan builder, so it's probably a false positive. DumpAccessibilityTreeTest.AccessibilityObject is real and is tracked in crbug/946481. Refine the suppression to just cover that. (If other command-line races come up, I think it's preferable to add new suppressions and file new bugs rather than revive the overbroad base::CommandLine suppression. The overbroad one has let new bugs through, like the accessibility test.) Bug: 946481, 334140 Change-Id: If09cb2fa2629751367e3fd822e3ba5159d529492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548138 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#646493}
-
Yuwei Huang authored
The current FtlSignalingPlayground is basically for testing the FTL service APIs, and isn't much related to the signaling process. The flow for testing the actual signaling process (which uses the jingle session manager) seems to be very different to just playing with the FTL APIs, so we will likely need a different playground binary for that. For now lets rename the binary to FtlServicesPlayground, and I'll send another CL to refactor CLI common logic. Bug: 947337 Change-Id: I86661738bcc78982df596b5909968b7122bff6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547758Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#646492}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b5462db2. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 6f2e9bd4 "webrtc wpt: add test for ice disconnection" be4bce5d "[WPT] Merge subresource scripts into common/security-features" d1ac10ff "Revert "webrtc wpt: add test for ice disconnection"" e46d3296 "Revise tests for datachannel ID handling" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I81b566a38fde7c3fffbf472f81109bd797a85621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547940Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646491}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d7d8b4c6d219..5be29a31559d Created with: gclient setdep -r src-internal@5be29a31559d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: I58f7fcd5325f578d22e3c4c01a478dd87d5e7934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548096Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646490}
-
Matthew Wang authored
We plan to add a new portal result (Redirect Found) in CL:1532970. Modify the NetworkPortalResult histogram to accommodate this. Bug: 903645 Change-Id: I488508ed6f618d69baa0f59a8b7f28d52c8c8fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542660Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#646489}
-
Min Chen authored
Bug: 916331 Change-Id: I794be5f9c5aa25ca0dfb84f3209061ea992e6875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548130Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#646488}
-
Andrew Grieve authored
It says in the JavaDoc for the method to never downcast, but looks like some places were still doing it. This change removes all such downcasts and also removes some useless plumbing of the application context as parameters. To ensure this doesn't happen again, getApplicationContext() now always returns a ContextWrapper when DCHECKS are enabled. Bug: 846456 Change-Id: If9db976511ee1c7da99d71d455b7baa6b7fdec5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545503 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#646487}
-
Ben Kelly authored
As a first step towards supporting different cache_storage backends, this CL splits the CacheStorage and CacheStorageCache objects into separate base interface and concrete implementation classes. The interface classes maintain the existing names. The new implementation classes are called LegacyCacheStorage and LegacyCacheStorageCache. To make this CL easier to review the code remains in the currently existing files. A follow-up CL will move the implementation code into separate files. Doing the move as a separate CL makes it easier to see what is changing vs what is moving. In addition, future CLs will split the CacheStorageManager and create a factory method for choosing implementations. Bug: 940449 Change-Id: Ie42b02138e2c41555de3e3ac35870c287f025525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542177 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#646486}
-
Miguel Casas authored
This CL adds parsing of the mastering metadata (hdr) to AVStreamToVideoDecoderConfig() function, and its stringification to VideoDecoderConfig::AsHumanReadableString(). It also adds unit testing for this new functionality. Bug: 945850 Change-Id: I8974311f255c80198442a774d633f05523779e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546513Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#646485}
-
Roberto Carrillo authored
R=liaoyuke,sajjadm Bug: 934059 Change-Id: I1496d6c7e699929911561134b15e828a431c4dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546622Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#646484}
-
Xiaoqian Dai authored
Bug: 943349 Change-Id: I527f92e6aae7dbb553d98cc128018db2f136ad4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547945Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#646483}
-
Peng Huang authored
The crash is because the XWindow is destroyed before destroying the vulkan surface. Fix the problem by blocking the viz thread until the SkiaOutputSurfaceImplOnGpu is destroyed. Bug: 934254 Change-Id: Ib39d08407daeb7fe7a3efdca8478b6fe8ca24f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547753 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#646482}
-
Wojciech Dzierżanowski authored
The following errors: ERR_PROXY_CERTIFICATE_INVALID, ERR_PROXY_AUTH_UNSUPPORTED, ERR_PROXY_CONNECTION_FAILED indicate failure to connect to the proxy (there's also the QUIC-specific ERR_NO_SUPPORTED_PROXIES). Before this CL, when a URLRequest completed with one of these errors, |URLRequest::proxy_server_| was not set. While there's some inherent ambiguity as to which proxy server is set in this case (ProxyInfo can store multiple proxies), we already report the net::Error we got for the last proxy we tried, even though previous proxies might have failed with a different error. BUG=940428 Change-Id: I900d7be7ea4761cc81bd08d21ca1abfbe8e824ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541164Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#646481}
-
Pedro Amaral authored
This reverts commit 1dc524aa. Reason for revert: Causing compile failure on android-jumbo-rel. See https://bugs.chromium.org/p/chromium/issues/detail?id=946562 Original change's description: > Introduce UserLevelMemoryPressureSignalGenerator > > UserLevelMemoryPressureSignalGenerator's purpose is to generate extra memory pressure signals when the OS signals are not sufficient. > When the memory usage is over a certain threshold, a critical memory pressure signal will be sent. > Feature is disable by default and enabled through finch. > > Bug: 920922 > Change-Id: I6c6a8b1890a7964902655198f842d8c0e7e74259 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505738 > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Takashi Sakamoto <tasak@google.com> > Cr-Commit-Position: refs/heads/master@{#646224} TBR=mpearson@chromium.org,tasak@google.com,haraken@chromium.org,keishi@chromium.org Change-Id: Ie9c6544ac7669158bfaa4f2fbcb9ec77bbc8ef05 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 920922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548320Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#646480}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2f58334622caf19bd8a90db65d93cbd1d6bbf025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548095Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646479}
-
Sergey Ulanov authored
This reverts commit f7bfe7d0. Reason for revert: vulkan_function_pointers.h must be generated Original change's description: > Add gpu::SemaphoreHandle and use it in VulkanImplmentation > > Previously VulkanImplementation defined functions for semaphore > import/export from/to file descriptors. This approach doesn't work on > platforms that don't support FDs for semaphores, specifically on > Fuchsia and Windows. > > This CL: > 1. Adds cross-platform gpu::SemaphoreHandle that allows to > represent semaphore handle on any platforms. > 2. Replaces ImportSemaphoreFdKHR() with ImportSemaphoreHandle(). > 3. Replaces GetSemaphoreFdKHR() with GetSemaphoreHandle() > > This allows to remove dependency on ScopedFD in > gpu::ExternalVkImageFactory, which will make it easier to reuse that > class on Fuchsia and Windows. > > Bug: 934526 > Change-Id: I16b1a9f3a606683b76a73c4e68a33b3294f25a90 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540724 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Bo <boliu@chromium.org> > Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Michael Spang <spang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#646424} TBR=spang@chromium.org,boliu@chromium.org,sergeyu@chromium.org,piman@chromium.org Change-Id: Ie273be284b587c2c5a2259da3b6a04e902f87e1b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548147Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#646478}
-
Tibor Goldschwendt authored
This reverts commit 7d13b860. Reason for revert: Cannot be merged back and will cause merge conflicts for other tab management CLs. Original change's description: > [modules] Auto-determine if resouces go into base or feature module > > + Move tab management resources into its DFM. > > Bug: 944115 > Change-Id: If14cdcfeb6bca94b9f1b040049c0f659831b193b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534777 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#646437} TBR=wnwen@chromium.org,yusufo@chromium.org,agrieve@chromium.org,tiborg@chromium.org Change-Id: I4f15497d2a87c44b8b5833886f1726ea18e64ac3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547762Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#646477}
-
Mohamed Amir Yosef authored
protos are movable now, so let's simplify the code making use of this fact. Bug: 947044 Change-Id: I1296f3747e22dc461c6ac5013a627dff68e8b76f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547832 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#646476}
-