GitLab

Cr-Commit-Position: refs/heads/master@{#402704}

It was possible for two touch moves that had acks to get coalesced together
and the main thread would only process one and deliver the ack for it. This
caused a situation where the hung renderer timer was getting fired because
there was an outstanding ack in the count. And this timer forced the
omnibox to not go away.

A large portion of this change (plumbing the ack_state will go away when
I land my multi-thread main_thread_event_queue design); but since this
needs to be merged back to M52 this is safest.

BUG=616991

Review-Url: https://codereview.chromium.org/2094323002
Cr-Commit-Position: refs/heads/master@{#402703}

BUG=591179

Review-Url: https://codereview.chromium.org/2097413003
Cr-Commit-Position: refs/heads/master@{#402702}

* Make the names of all the icons used in downloads consistent with the go/icons page again.

* Get rid of a duped drawable.

* Suppress an invalid lint warning.

BUG=623262,623264

Review-Url: https://codereview.chromium.org/2104123003
Cr-Commit-Position: refs/heads/master@{#402701}

Mark virtual/gpu-rasterization/fast/images/color-profile-background-clip-text.html as failing on win10

BUG=624233
TBR=shans@chromium.org

Review-Url: https://codereview.chromium.org/2103953004
Cr-Commit-Position: refs/heads/master@{#402700}

BUG=601909

Review-Url: https://codereview.chromium.org/1851143002
Cr-Commit-Position: refs/heads/master@{#402699}

BUG=622219

Review-Url: https://codereview.chromium.org/2107953003
Cr-Commit-Position: refs/heads/master@{#402698}

Before shipping Shadow DOM v1, we have to remove this feature because Node.rootNode
is guarded by ShadowDOMV1 flag.

See also https://bugs.chromium.org/p/chromium/issues/detail?id=608006.
Ship of Node.rootNode was reverted there.

BUG=531990

Review-Url: https://codereview.chromium.org/2106683002
Cr-Commit-Position: refs/heads/master@{#402697}

Revert of Remove style spans to follow the styles of the block element (patchset #2 id:20001 of https://codereview.chromium.org/2102913002/ )

Reason for revert:
Assignment within conditional on line 836 of ReplaceSelectionCommand.cpp is breaking Win8 build:

https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/builds/133

Original issue's description:
> Remove style spans to follow the styles of the block element
>
> This CL removes style spans to follow the styles of the block
> element(li, pre, td, and h1~6) when the text of the pasted
> or merged element becomes a part of the block element.
>
> BUG=226941
> TEST=third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block-element.html
>
> Committed: https://crrev.com/5220699381aae450f22d1ea3805141deb139f8f3
> Cr-Commit-Position: refs/heads/master@{#402659}

TBR=yosin@chromium.org,joone.hur@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=226941

Review-Url: https://codereview.chromium.org/2109973002
Cr-Commit-Position: refs/heads/master@{#402696}

Review-Url: https://codereview.chromium.org/2102883004
Cr-Commit-Position: refs/heads/master@{#402695}

In order to save memory and upload time, images which are
going to be drawn at less than their native resolution may
be uploaded at a smaller scale. This change adds additional
caching and upload logic to allow this.
See https://goo.gl/0zCd9Z for a complete description.

BUG=623688
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.blink:mac_blink_rel;tryserver.blink:win_blink_rel

Committed: https://crrev.com/bc8acf2632042e5e93982088d5b7dcb7f1c0d168
Review-Url: https://codereview.chromium.org/2042133002
Cr-Original-Commit-Position: refs/heads/master@{#402377}
Cr-Commit-Position: refs/heads/master@{#402694}

Adds support for window state type changed events.

BUG=b/29817350

Review-Url: https://codereview.chromium.org/2110553002
Cr-Commit-Position: refs/heads/master@{#402693}

BUG=NONE
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2103383003
Cr-Commit-Position: refs/heads/master@{#402692}

MemoryPressureListener::MemoryPressureLevel enum has changed to 0, 1, 2.
Let's align WebMemoryPressureLevel with it

BUG=

Review-Url: https://codereview.chromium.org/2086833005
Cr-Commit-Position: refs/heads/master@{#402691}

https://chromium.googlesource.com/chromium/src/+/80a042718

BUG=623688
TBR=ericrk@chromium.org

Review URL: https://codereview.chromium.org/2106803003 .

Cr-Commit-Position: refs/heads/master@{#402690}

The same isInline function is defined in EditingUtilities.cpp and
IndentOutdentCommand.cpp. This CL adds isInline declaration in
EditingUtilities.h so that it can remove the same function from
IndentOutdentCommand.cpp.

In addition, it uses Node::computedStyle() rather than layout object
to reduce dependency of layout tree.

BUG=none

Review-Url: https://codereview.chromium.org/2105653004
Cr-Commit-Position: refs/heads/master@{#402689}

Fix google_play_services_default_java including legacy_http_javalib as a dep rather than a classpath-only jar

Also fixes proguard() GN template not rebasing paths when it should be.

BUG=624003

Review-Url: https://codereview.chromium.org/2103193002
Cr-Commit-Position: refs/heads/master@{#402688}

BUG=620614

Review-Url: https://codereview.chromium.org/2091873002
Cr-Commit-Position: refs/heads/master@{#402687}

* Remove enable_alternative_service_for_insecure_origins;
* change alternative service unittests from http to https;
* change kDefaultUrl from http to https;
* s/kDefaultURL/kDefaultUrl/ (to match the one in QuicStreamFactoryTest);
* adapt a number of tests, explicitly use old URL in others;
* remove SpdyTestUtil::default_url();
* remove moot SpdyAlternativeServiceThroughProxy;
* remove SpdyNetworkTransactionTest::GetDefaultUrl() and port_;
* add SpdyNetworkTransactionTest members to make tests more concise.

Besides an improvement in code health, this CL will make it easier to write
unittests for https://crbug.com/615413.

BUG=621621, 624073

Review-Url: https://codereview.chromium.org/2109803002
Cr-Commit-Position: refs/heads/master@{#402686}

BUG=none

Review-Url: https://codereview.chromium.org/2102003004
Cr-Commit-Position: refs/heads/master@{#402685}

We can store the AtomicStringTable in a unique_ptr in the WTFThreadData
directly and then use the constructor and destructor to handle adding
and removing the strings. We can then return a reference too since
all WTFThreadData instances have an AtomicStringTable.

Future patches will move most of the AtomicString.cpp logic into the
AtomicStringTable class making the code easier to understand.

Review-Url: https://codereview.chromium.org/2103373002
Cr-Commit-Position: refs/heads/master@{#402684}

The FileSelectHelper class is using RenderViewHost notifications to
ensure it cleans up itself. However, as I moved it to use
RenderFrameHost for file selection (but not directory enumeration yet),
it opened it up to use-after-free conditions as it was not monitoring
for those objects going away.

This CL fixes that and adds a test to ensure it gets properly cleaned up
when an iframe that requested the file chooser is removed.

BUG=621076

Review-Url: https://codereview.chromium.org/2102883002
Cr-Commit-Position: refs/heads/master@{#402683}

R=dpapad@chromium.org
BUG=619715
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2108863004
Cr-Commit-Position: refs/heads/master@{#402682}

This was mystifyingly introduced by:
https://codereview.chromium.org/2014433002

It turns out that previously, this relied on calls to setStatusBarColor
based on theme color notifications when nothing changed.  This was
triggering a root level relayout, which hid this issue.

For now, force a root level relayout when attaching the recent
tabs page to the window.

BUG=623515

Review-Url: https://codereview.chromium.org/2109943002
Cr-Commit-Position: refs/heads/master@{#402681}

Create an async interface LoaderDelegate to delegate from c/b/loader to
the rest of content. This allows decoupling of loader so that it can
eventually be moved to a separate service.

Start by using it to remove the dependency on RenderViewHostImpl.

R=jam
BUG=622050

Review-Url: https://codereview.chromium.org/2098923002
Cr-Commit-Position: refs/heads/master@{#402680}

https://chromium.googlesource.com/chromium/src/+/188d4f93b

BUG=596060
TBR=skobes@chromium.org

Review URL: https://codereview.chromium.org/2109963002 .

Cr-Commit-Position: refs/heads/master@{#402679}

This change increases the timeout in
WebappActivityTestBase.waitUntilIdle and re-enables one test
that was failing on M testers due to a too short timeout.

BUG=614338

Review-Url: https://codereview.chromium.org/2108913002
Cr-Commit-Position: refs/heads/master@{#402678}

Removed the toggle between Presentation Mode and Fullscreen.
Renamed UpdateFullscreenWithToolbar to UpdateUIForTabFullscreen.
Fixed the fullscreen toolbar logic in BWC so that the toolbar state is
correct when we exit tab fullscreen.

BUG=579259

Review-Url: https://codereview.chromium.org/2089323002
Cr-Commit-Position: refs/heads/master@{#402677}

When getting screensize for powerwash reset, making sure the currentScreen is 'reset', not 'account-picker'.

BUG=615088
TEST=Multiple tests on M52, the corrupted powerwash proposal UI doesn't happen any more.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2109763003
Cr-Commit-Position: refs/heads/master@{#402676}

These might be useful to track as well.

BUG=none

Review-Url: https://codereview.chromium.org/2100703002
Cr-Commit-Position: refs/heads/master@{#402675}

For Cast builds, only cast desktop and cast audio-only products should use_alsa=true
by default.

BUG= internal b/29770818
TEST= Build several Cast platforms

Review-Url: https://codereview.chromium.org/2109753002
Cr-Commit-Position: refs/heads/master@{#402674}

Current generator's functions are not virtual and doesn't allow the subclass to have polymorphism for the mocks in the test. This CL makes those functions virtual and overridable.

BUG=617238

Review-Url: https://codereview.chromium.org/2105103002
Cr-Commit-Position: refs/heads/master@{#402673}

This CL does two things.
1. Introduce CancelAwareAnimatorListener to Chrome. For vanilla
AnimationListener in Android, onAnimationCancel() and onAnimationEnd()
will both be called if Animator is canclled. This is a confusing
behavior and it caused problems in various places.
2. Change the way security icon animation works in custom tab, making
it able to refresh its theme when the color of the toolbar changes.

Credit of this CL goes to tedchoc@.

BUG=604520
R=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2104053005
Cr-Commit-Position: refs/heads/master@{#402672}

BUG=623763
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2102453003
Cr-Commit-Position: refs/heads/master@{#402671}

Prior to this change it was possible for the AcceleratorRegistrarImpl
to outlive the WindowManager and then attempt to use it. This patch
ensures any AcceleratorRegistrarImpl are destroyed when the
WindowManager loses its connection.

BUG=none
TEST=none
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2105653003
Cr-Commit-Position: refs/heads/master@{#402670}

Change QuicBufferedPacketStore to store QuicReceivedPackets instead of QuicEncrypterPackets, since that is what the Dispatcher uses. Also to take a const clock. Add a method for checking if packets are buffered for a connection ID.

Also clang-format these files since they appear to be incorrectly
styled.

Merge internal change: 125777729
https://codereview.chromium.org/2099313003

Stop using next_packet_sequence_number_length in QuicPacketCreator.  No functional change.  Protected by FLAGS_quic_simple_packet_number_length.

Merge internal change: 125727775
https://codereview.chromium.org2101623003

Add QuicConnectionCloseDelegateInterface. No functional change expected. Not protected.

Merge internal change: 125703498
https://codereview.chromium.org/2099403002

Replace QUIC's PathMtuAckListener with a non-AckListener approach. Protected by FLAGS_quic_no_mtu_discovery_ack_listener.

Merge internal change: 125678921
https://codereview.chromium.org/2100763003

Change users of NextPacketNumberLength to GetPacketNumberLength in QuicPacketCreatorTest when GetPacketNumberLength is equivalent or better.

Merge internal change: 125674835
https://codereview.chromium.org/2104503003

Remove two tests from QuicConnectionTest because they were duplicates of those in QuicPacketCreatorTest.

Merge internal change: 125640116
http://crrev.com/2102713002

Deprecate FLAGS_quic_detect_memory_corrpution.

Merge internal change: 125572214
https://codereview.chromium.org/2107473002

Deprecate FLAGS_quic_disallow_multi_packet_chlo.

Merge internal change: 125572148
https://codereview.chromium.org/2102733002

Add extra logging when QuicFramer's AppendStopWaiting fails to serialize.

Merge internal change: 125563155
https://codereview.chromium.org/2102723002

Add functionality to explicitly set SNI in the QUIC test client

The QUIC test client currently sets SNI based on the request URL which
triggers the client to connect.  This is problematic for tests which
want to set the SNI to something else (in this
case: SSL compartments tests).  This change makes it possible for such
tests to explicitly override this setting.

Merge internal change: 125561343
https://codereview.chromium.org/2101003002

Deleting blank lines from argument list of HandshakeWithFakeClient

Merge internal change: 125459408
https://codereview.chromium.org/2099123003

Let QUIC respect HTTP2 Settings frame. Currently, only SETTINGS_HEADER_TABLE_SIZE is supported. Protected by FLAGS_quic_respect_http2_settings_frame, default true.

Merge internal change: 125448073
https://codereview.chromium.org/2102703002]

Make QuicSpdyStream::ParseHeaderStatusCode() inparam const.

No functional change.

* Use SpdyHeaderBlock::find() instead of operator[] so that |header| is
  not
  modified.
* Make |header| const (and pass by reference instead of pointer).
* Eliminate SpdyHeaderBlock copy in
  QuicSimpleServerStream::SendResponse().

Merge internal change: 125445090
https://codereview.chromium.org/2100213002

Add a new kMIDS (Max Incoming Dynamic Streams) config option, to eventually replace kMSPC.

Adds QUIC_VERSION_35 which allows endpoints to independently set max
open streams. Protected by FLAGS_quic_enable_version_35

Merge internal change: 125773608
https://codereview.chromium.org/2101353003

Flip recent QUIC flags.
https://codereview.chromium.org/2107943002/

Review-Url: https://codereview.chromium.org/2104633002
Cr-Commit-Position: refs/heads/master@{#402669}

This patch updates the code to prevent auto deducing to a raw pointer.

R=sky, danakj, dcheng
BUG=554600

Review-Url: https://codereview.chromium.org/2110643002
Cr-Commit-Position: refs/heads/master@{#402668}

The pending demuxer read state is overwritten in too many cases to
be reliable, instead always use the flag instead of trying to have
it both ways.

The main issue this fixes is where there are parallel decodes and a
demuxer read outstanding, one decode completes with an error, and
the new decoder is initialized before the demuxer read completes.

Previously this would stomp the pending read state and we'd try to
issue a new demuxer read when the decoder initialization completed,
blowing up the demuxer in the process.

BUG=597605
TEST=new unittest

Review-Url: https://codereview.chromium.org/2110463003
Cr-Commit-Position: refs/heads/master@{#402667}

BUG=31519

Review-Url: https://codereview.chromium.org/2107893004
Cr-Commit-Position: refs/heads/master@{#402666}

This adds a 'required' entry to the exe:content_browser manifest
for content::mojom::ProcessControl in exe:content_gpu, allowing
the browser to connect to the ProcessControl interface in the GPU
process.

Also fixes a bug in InterfaceRegistry which was causing useful
log errors to be omitted when capability filters would block
interface connection and registration.

BUG=624112
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2102353002
Cr-Commit-Position: refs/heads/master@{#402665}