- 05 Aug, 2020 40 commits
-
-
Kevin Marshall authored
Consolidates the forked OnLoadScriptInjectors into one single shared implementation. The shared implementation is a necessary prerequisite step for developing platform-agnostic bindings browsertests. * Deletes Fuchsia and Cast specific OnLoadScriptInjectors. * Moves most browser process logic into a new class "OnLoadScriptInjectorHost", to further harmonize the platforms. * Migrate Mojo interface from ScopedSharedBufferHandle to ReadOnlySharedMemoryRegion. Merge-With: eureka-internal/432742 Bug: 1113289 Bug: 1060846 Bug: 1103058 Test: cast_shell_browsertests and web_engine_browsertests both pass. Change-Id: If9fd2c54de08d9bc225771b01cdb32152a95fde8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286193 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795103}
-
Kai Ninomiya authored
This flakes enough times in a row that RetryOnFailure is not enough. Could be because the flake rate is high, or because some system state causes it to fail consistently across a few retries. No-Try: true TBR: kbr@chromium.org Bug: 1112101, angleproject:4922 Change-Id: I1e5612644349ac28e782ef25ede61a2eac255631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338857Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#795102}
-
Joao Victor Almeida authored
Mousewheel (and touchscreen) hardware implementation of the scroll behavior can differ from different manufacturers. Some implement large scroll interactions as a series of small scrolls in a short interval of time. In these scenarios, clamping by a minimal scroll delta creates a very fast and jumpy scroll experience (as those small deltas are clamped by 16px). This was a first motivation to remove the lower-bound of percent-based deltas for mousewheels. But since the lower-bound is perceivable only in extreme cases (scrollers smaller than 100px), for simplicity, we remove the lower-bound for all use cases. In this CL, the minimum of 16px is removed from ScrollUtils::ResolveScrollPercentageToPixels. Bug: 1107662 Change-Id: If0572db744f83829884072f50e63d2ad03c2a545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336510 Commit-Queue: João Victor Almeida de Aguiar <joalmei@microsoft.com> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795101}
-
Peter Kasting authored
This also fixes some bugs: * Non-normal modes still used the file name + status label heights for the preferred label height, instead of an appropriate other 2-line label. * There was no padding between labels and dropdown button. * Various RTL positions and widths could be computed wrong. Bug: none Change-Id: Ie330c5daf4ed553a382db4bd8ca4d759972599d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333370Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#795100}
-
Yuke Liao authored
This CL runs linux-lacros-compile-rel on CQ by default, required resources have been provisioned in: https://chrome-internal-review.googlesource.com/c/infradata/config/+/3197325 Bug: 1110382 Change-Id: Ic0914361ff7d74270aeeed3ad1a034b9b11a254c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335503 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#795099}
-
Etienne Bergeron authored
This CL is explicitly defining the closure called to ensure the NO_SANITIZE attributes is applied to the right function. see: https://bugs.chromium.org/p/chromium/issues/detail?id=1110792#c9 It seems there are code that detect CFI issues even if the attribute is specified. bug: 1110792, 1091259 Change-Id: I2261b138f84d7e05ffe9873d768e162d09b7fc85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336871Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#795098}
-
Lambros Lambrou authored
The host currently supports a control message to request ICE restart, which re-negotiates SDP offer/answer exchange. This CL adds a new control message to only do the SDP exchange without restarting ICE, since that is not necessary to reconfigure SDP parameters (for example, to switch to a different codec). Bug: 706220 Change-Id: I35f21d3eb701f91c56b05f7b97cd2d2d8540c2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336870 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#795097}
-
Andrey Kosyakov authored
DOMSnapshot.captureSnapshot should be used instead. Change-Id: I32b9539e06b4f2d20bee6c34b7ba64a289c84ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335483Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#795096}
-
Brian Sheedy authored
Fixes the earlier Gold issues by rolling the version of goldctl we use and re-enables Gold functionality in affected tests. Bug: 1112946 Change-Id: Ie9680d8f43883abe4392de55366ff37dfc3bf1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337398Reviewed-by:
-
Milica Selakovic authored
Bug: 1110942a Change-Id: If829d88ecc353ba86d20f1197f94365313f5e778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332608 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#795094}
-
Chris Harrelson authored
This one fixes fullscreen/compositor-touch-hit-rects-fullscreen-video-controls.html. It also modifies the test to actually verify that the video is composited. Bug: 1112884,1108972 Change-Id: Ia4357a540a3b8ac530331810824591af2210a5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337544 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795093}
-
Devlin authored
This reverts commit 9b84489c. Reason for revert: breaks windows compile Looks like we missed a callsite here: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/google/google_update_policy_fetcher_win.cc;l=37;drc=0103fe2cf95d7e8fc1a46633d30f56131228906c [46403/48688] CXX obj/chrome/browser/browser/google_update_policy_fetcher_win.obj FAILED: ../../chrome/browser/google/google_update_policy_fetcher_win.cc /Foobj/chrome/browser/browser/google_update_policy_fetcher_win.obj /Fd"obj/chrome/browser/browser_cc.pdb" ../../chrome/browser/google/google_update_policy_fetcher_win.cc(37,13): error: no matching member function for call to 'Set' policies->Set(policy_name, policy::POLICY_LEVEL_MANDATORY, ~~~~~~~~~~^~~ ../..\components/policy/core/common/policy_map.h(146,8): note: candidate function not viable: no known conversion from 'typename remove_reference<unique_ptr<Value, default_delete<Value>> &>::type' (aka 'std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value>>') to 'base::Optional<base::Value>' for 5th argument void Set(const std::string& policy, ^ ../..\components/policy/core/common/policy_map.h(153,8): note: candidate function not viable: requires 2 arguments, but 6 were provided void Set(const std::string& policy, Entry entry); ^ 1 error generated. Original change's description: > Remove the old version of PolicyMap::Set > > 1. Removed the old version of PolicyMap::Set, > which passes value as unique_ptr. > 2. Changed all the remaining refs use the new > version which passes value parameter as base::Value > instead of unique_ptr. > > Bug: 1092469 > Change-Id: Ie45bb05b603cedcad8119a65134c4f5f008964dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332191 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795078} TBR=avi@chromium.org,eugenebut@chromium.org,emaxx@chromium.org,ayaelattar@chromium.org Change-Id: I03456080e9878bcc82eda2eddfe6474b8b13fed2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1092469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339389Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795092}
-
Stephen Martinis authored
We're looking at testing non-default field trial configurations on our bots to cover cases which happen in production which might not have existing test coverage. Bug: 1014727 Change-Id: Ib25bd35468010026acfc481f95bc7724083bd0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238779 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#795091}
-
Devlin Cronin authored
Flaky on Mac. TBR=rogerta@chromium.org Bug: 1112111 Change-Id: Id90a9c6333874bb18ec1300537b8df583b21e132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339499 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Liquan (Max) Gu authored
Change: * Since PRImpl#onlySingleAppCanProvideAllRequiredInformation() is UI logic, it's being moved to PaymentUIsManager. * Replace the "requestXXX" calls in the method. Bug: 1102522 Change-Id: I6eabb53ca43e353b1a64d49fc305b13253287b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332370 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#795089}
-
Josip Sokcevic authored
Bug: 1098562 Change-Id: I10e83b99a480d2d96b911e26b09e8db5d34a082e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333301 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#795088}
-
Sreeja Kamishetty authored
This CL disables failing test "RenderFrameHostManagerTest.BeginNavigationIgnoredWhenInPendingDeletion" with BackForwardCache and adds a new test "RenderFrameHostManagerTestWithBackForwardCache.BeginNavigationIgnoredWhenInBackForwardCache" to consider the case when BackForwardCache is enabled. Bug: 1102630 Change-Id: I9999e443f96302f01c09c0a4def37cab7a536930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310310Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#795087}
-
Liquan (Max) Gu authored
Change: * Move PRImpl's onSectionAddOption, onSectionEditOption, getSectionInformation, onFocusChanged into PaymentUIsManager because they are UI logic. * PaymentUIsManager takes over PRImpl's FocusChangedObserver interface. Bug: 1102522 Change-Id: Icb529f088a5b9d167b9f47da852056cbd6028c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336854 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Yuke Liao authored
This CL fixes linux-lacros-compile-re mb config so that it's under tryserver.chromium.chromiumos. TBR=svenzheng@chromium.org Bug: 1110382 Change-Id: Ic701a63e48715b5981d08984f60647f33cd1962c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337837Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#795085}
-
Devlin Cronin authored
The UIStatus::kEnabledWithNoFeatures variant of the SafetyTipPageInfoBubbleViewBrowserTest test suite has been flaking. Disable this specific variant, to avoid disabling the coverage for the other variants. TBR=jdeblasio@chromium.org Bug: 1113105 Change-Id: If6e499367e63ed152fa15befd7bf66bf5c0a98e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339817Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
-
Adam Ettenberger authored
If a single platform requires the behavior of RUN-UNTIL-EVENTS, but the test is run for multiple platforms, then RUN-UNTIL-EVENTS would need to be defined for an event per-platform. This change applies the same concept as filters for WIN-ALLOW/DENY so we can enable this behavior per-platform for event dump tests. e.g. WIN-RUN-UNTIL-EVENTS Bug: none Change-Id: I0b4eda70c64dea685ed4df8014465297c66a925c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320417 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#795083}
-
Mike Wittman authored
All enum values are expected to be handled in the switch. Bug: 1105170, 1101023 Change-Id: Ia979d79e630375350ca6b260edbc3663cbc99ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339378 Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#795082}
-
Siyu An authored
gcl: http://google3/googledata/googleclient/chrome/finch/gcl_studies/AutofillEnableCardNicknameManagementAndUpstream.gcl Bug:1082013 Change-Id: Ia956f6ca10d361c6ede8364d6c6862b6978e7c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335405Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#795081}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c1e871e8a532..08a9885983f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rogerta@google.com,ayaelattar@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rogerta@google.com,ayaelattar@google.com Change-Id: I7a98f9c910e0cfecaad8ac50039d0e4c39a005ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339635Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795080}
-
Li Lin authored
When supervised user is the owner of the device, the Parent Access Code (PAC) is required for performing: - Add user - Re-authentication The check is currently done in Gaia flow. This CL is to migrate the check to the client using the Parent Access Code widget that is currently used in couple other places. Bug: 921142 Test: unit tests Change-Id: I3588da7779904b7af7145e533af83673eeb8742b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333544 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795079}
-
Aya ElAttar authored
1. Removed the old version of PolicyMap::Set, which passes value as unique_ptr. 2. Changed all the remaining refs use the new version which passes value parameter as base::Value instead of unique_ptr. Bug: 1092469 Change-Id: Ie45bb05b603cedcad8119a65134c4f5f008964dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332191Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#795078}
-
Liquan (Max) Gu authored
Change: Since PRImpl#editCard() is UI logic, we are moving it into PaymentUisManager. Bug: 1102522 Change-Id: Ib0694ea2f5ab2256c4a65ff558aba25bc05fe25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335801 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Stephen Roe authored
This allows adding a linux arm64 ubuntu 16.04 server to the chrome.tests pool. Without the cpu dimension, android and android_arm64 resource size tests would be run on the linux arm64 server and would fail. Bug: 1111100 Change-Id: I5ae6e20e6a0de67854aecf02d619fcd269a11c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337678Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#795076}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/93bb4f5a94f3..f123f22cb971 2020-08-05 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-04 engeg@google.com chromeos_config: caroline-kernelnext to crit 2020-08-04 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-04 kevinruvalcaba@google.com Adding root calculation to DepVisualizer class 2020-08-04 mikenichols@chromium.org chromeos_config: disable rootfs verification for Loonix boards 2020-08-04 dburger@chromium.org Add code_coverage processing for BuildTargetUnitTest endpoint. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ie4f27536c9e844f6e59f7b39bcb3d09f8c18d43d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339634Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795075}
-
Aya ElAttar authored
Changed ScopedClipboardWriter references to set the source of the clipboard data if possible. Bug: 1103193 Change-Id: Ic25363aa1be825681fd4b4136384c4af12972623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320670 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#795074}
-
edchin authored
This CL allows dragging a tab to the edge of the screen to create a new window with the tab. Bug: 1087850 Change-Id: I366d8acaa949a693341fd7159a643c738bddd386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251055 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#795073}
-
Danila Kuzmin authored
Bug: 1106367 Change-Id: Idcb023a623bd230eeba79618162ee47d6c0c5181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303717Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#795072}
-
Mustafa Emre Acer authored
This CL enables SafeBrowsingDelayedWarnings feature in tests by default. It also disables the feature on a few tests on Android. The reason for this is that the feature has good test coverage on desktop, and writing new tests for Android will be a significant time investment. Bug: 1077426 Change-Id: Ia5b04dc74893d513a13a72bc92ad1f1537b6691e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327550Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#795071}
-
Nate Fischer authored
This puts the flag UI's warning text into the ListView so it can scroll off screen as the user scrolls down the list of flags. This adds some complexity because the ListView now supports two different types of layouts. This swaps the order of the warning text and the "reset all" button. This is in order to pin the "reset all" button to the top of the Fragment. Fixed: 1059881 Test: Manual - verify the warning text scrolls as expected Change-Id: Id7afd2b256051d6d7bf5cee18c73592021444194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330042 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#795070}
-
Devlin authored
This reverts commit 4702a75d. Reason for revert: Suspected for causing MSAN failure https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20123? Sample failure: ==7998==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5562f862015e in find_if<std::__1::__wrap_iter<base::internal::UncheckedObserverAdapter *>, (lambda at ../../base/observer_list.h:284:22)> ./../../buildtools/third_party/libc++/trunk/include/algorithm:932:5 #1 0x5562f862015e in base::ObserverList<arc::ArcSessionManagerObserver, false, true, base::internal::UncheckedObserverAdapter>::RemoveObserver(arc::ArcSessionManagerObserver const*) ./../../base/observer_list.h:283:9 #2 0x5562f9398e52 in ScopedObserver<arc::ArcSessionManager, arc::ArcSessionManagerObserver, &(arc::ArcSessionManager::AddObserver(arc::ArcSessionManagerObserver*)), &(arc::ArcSessionManager::RemoveObserver(arc::ArcSessionManagerObserver*))>::RemoveAll() ./../../base/scoped_observer.h:67:7 #3 0x5562f9396de0 in ScopedObserver<arc::ArcSessionManager, arc::ArcSessionManagerObserver, &(arc::ArcSessionManager::AddObserver(arc::ArcSessionManagerObserver*)), &(arc::ArcSessionManager::RemoveObserver(arc::ArcSessionManagerObserver*))>::~ScopedObserver() ./../../base/scoped_observer.h:48:5 #4 0x5562f9396d2a in policy::LockToSingleUserManager::~LockToSingleUserManager() ./../../chrome/browser/chromeos/policy/lock_to_single_user_manager.cc:79:1 #5 0x5562efbc5122 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 #6 0x5562efbc5122 in std::__1::unique_ptr<policy::LockToSingleUserManager, std::__1::default_delete<policy::LockToSingleUserManager> >::reset(policy::LockToSingleUserManager*) ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 #7 0x5562efbc46de in policy::LockToSingleUserManagerTest::TearDown() ./../../chrome/browser/chromeos/policy/lock_to_single_user_manager_unittest.cc:75:34 #8 0x5562f0ae795a in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2866:11 #9 0x5562f0ae9cac in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3020:28 Original change's description: > ARCVM SharePath() to use correct seneschal port > > During the processing of ARCVM SharePath() request, it was retrieving > the seneschal port via some Crostini functions. This was incorrect and > would trigger a Crostini restart. This change will properly fix this > by retrieving the correct seneschal port from ArcSessionManagerVmObserver. > > BUG=b:147618164 > TEST=tast run <DUT> arc.Drivefs.vm > > Change-Id: I4f20ffb3101a17b51044e71c7d164bde78ec634d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320908 > Commit-Queue: Cherie Cheung <cherieccy@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794973} TBR=hashimoto@chromium.org,yusukes@chromium.org,vasilii@chromium.org,hidehiko@chromium.org,treib@chromium.org,joelhockey@chromium.org,cherieccy@chromium.org Change-Id: I4e35fd26a70f3f74588fb77f1c9e2a210bb19371 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:147618164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339579Reviewed-by:
-
Bella Bah authored
This generator uses grouping.xml and annotations.tsv to generate a Google Docs sheet for sys-admin clients. Refer to the README for additional guidance. Bug: 1107860 Change-Id: Ia9350fdc049e0e4b0ac2830968d9e60309bc3c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283487 Commit-Queue: Mohamadou Bella Bah <bellabah@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#795068}
-
John Delaney authored
Reland of https://crrev.com/c/2314843 Change was reverte due to browser test flakes on Linux Asan bots on https://crrev.com/c/2326796 The browsertest flakes seem to have been the result of a race condition caused by logging UseCounters while navigating the main frame cross origin. In these cases, browser-side PLM code received the feature usage updates after the main frame had already begun navigating, causing us to ignore the update. This is unexpected, and is summarized on https://crbug.com/1111524 This change fixes the issue by using an impression tag that targets a new window, so that we can guarantee the feature is received prior to flushing metrics for the page with the impression. TBR=japhet@chromium.org Bug: 1109079 Change-Id: Ie80a9156fb9e90d9891b02e0bdc44dc6cd0fe266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330300Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#795067}
-
Daniel McArdle authored
net_backoff_entry_serializer_fuzzer found an input that contains a very large failure_count. BackoffEntrySerializer::DeserializeFromValue loops |failure_count| times to initialize the BackoffEntry. In the worst case, we could wind up looping MAX_INT times. This CL modifies BackoffEntrySerializer::DeserializeFromValue to cap the failure_count to a maximum value. Bug: 1112132 Change-Id: Ifb7b6bf02161348b6f237b23b016f9fb0fee7fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336853 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#795066}
-
Daniel Clark authored
Through either a mistake of my own or an issue with the tool, after running rebaseline-cl for https://chromium-review.googlesource.com/c/chromium/src/+/2337099 I ended up with an image baseline for mac-retina that matches the expectation prior to that change. So, the test on that platform is still failing. This test didn't previously require a separate mac-retina baseline, so I'll just delete it to fix the issue. Bug: 1112111 Change-Id: I461cc2839451b9d0385d4732aca39f4ca8b80f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339377Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#795065}
-
Peter Kotwicz authored
https://chromium-review.googlesource.com/c/chromium/src/+/2284205 added usage of ObservableSupplierImpl in CompositorViewHolder. This causes threading issues with the off-UI-thread UI inflation done by WebAPKs. This CL temporarily disables the WebAPK off-UI-thread inflation as a simple fix which can be merged back to M85 BUG=1102650 Change-Id: Id6141567e026eae095ea47ea04d803c48b2eadb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336282Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
-
