GitLab

Bug: 790536, 790521
Change-Id: Ib2761ce671a42ab6a3b2a6cdfad94d8725a6c139
Reviewed-on: https://chromium-review.googlesource.com/956495Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541961}

The histograms were added in https://crrev.googlesource.com/c/782642
but the histograms.xml and enums.xml didn't match the actual histogram
and enum names. This CL fixes that.

Bug: 682933
Change-Id: Id0447f7e16032dae16d45781de07bacbd96a2ad6
Reviewed-on: https://chromium-review.googlesource.com/956343Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541960}

Change-Id: I32ab5f24831f7a18e5e3401503b242692f42c48b
Reviewed-on: https://chromium-review.googlesource.com/956541Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Devin Mullins <twifkak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541959}

This CL allows users to use the Feedback keyboard shortcut to launch the
Feedback UI and send Feedback. This also fixes an issue with the current
implementation of login feedback, where if we try to send feedback after
we have launched the app before and restarted Chrome, the UI would not
launch.

This is because on the first run, the background host is always created
just to get the types of events the app can handle. Once this is done,
we save this information in the extension registry and only load the
app once the event is actually dispatched. Since the existing code
was instead waiting for the host to load, it would never send the
event and wait forever.

Instead we're not checking if the extension has been added to the
registry. If it has, we can safely dispatch the event. If not, we instead
wait for the extension to load and then send feedback.

I've tested that this works now both for the first run and subsequent runs
of the app. The existing browser test should still be applicable since the
CL just changed the entry point for login feedback; did not add any
additional functionality.

R=rdevlin.cronin@chromium.org, xiyuan@chromium.org

Bug: 809715
Change-Id: Ib26cb879b15334c010bfed539bc83384c09d2a01
Reviewed-on: https://chromium-review.googlesource.com/953372
Commit-Queue: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541958}

This CL uses ImageView instances to show the icon and answer image
instead of drawing them in OnPaint. The OnPaint has been removed from
OmniboxResultView.

Bug: None
Change-Id: Ic9b1f98d5f81a4dd8b23a39b5174996270314086
Reviewed-on: https://chromium-review.googlesource.com/952669
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541957}

Change-Id: Id7dafc9572f34b3daa2122a11efd2b7e82bd2c91
Reviewed-on: https://chromium-review.googlesource.com/956544Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541956}

Bug: 706389
Change-Id: Ida63780d8010deca305697c93cff34bfa3245443
Reviewed-on: https://chromium-review.googlesource.com/956483Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541955}

When BaseAudioContext is being tear down, AudioWorkletGlobalScope might
be already gone at that point. When BAC accesses AWGS, we must check its
existence.

Currently, the only access point of |global_scope| in BAC is
UpdateWorkletGlobalScopeOnRenderingThread().

Bug: 819845
Test: The attached repro case does not crash after 20 min run.
Change-Id: I485668708406639b8b77ae348c57c31782db5438
Reviewed-on: https://chromium-review.googlesource.com/954228Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541954}

This reverts commit 613ba331.

Reason for revert: Causing build failures:
https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2Fmac_chromium_rel_ng%2F668246%2F%2B%2Frecipes%2Fsteps%2Fanalyze%2F0%2Fstdout

/b/c/b/mac/src/buildtools/mac/gn gen //out/Release --check
  -> returned 1
ERROR at //chrome/test/BUILD.gn:4405:7: Can't load input file.
      "//extensions/features",
      ^----------------------

Original change's description:
> Extensions: Fix memory leak in ExtensionApiFrameIdMap.
> 
> Currently in ExtensionApiFrameIdMap::UpdateTabAndWindowId and
> ExtensionApiFrameIdMap::LookupFrameDataOnUI we don't check whether a
> RenderFrameHost is alive, before storing it's frame data. It's possible that
> such a RenderFrameHost never becomes alive, and hence we don't get any
> OnRenderFrameDeleted notification for it. Since ExtensionApiFrameIdMap is a
> singleton, this causes a memory leak. To fix, ensure that only live
> RenderFrameHosts are tracked.
> 
> Also ensure in InProcessBrowserTest::TearDown that ExtensionApiFrameIdMap is not
> leaking memory for any browser test.
> 
> BUG=817205
> 
> Change-Id: I78bf06cee7e10465f9eb5973ee8e59f525a74d93
> Reviewed-on: https://chromium-review.googlesource.com/951975
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541950}

TBR=sky@chromium.org,rdevlin.cronin@chromium.org,karandeepb@chromium.org

Change-Id: Ib200225c2824c865feda8707f081485d3f53d912
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 817205
Reviewed-on: https://chromium-review.googlesource.com/956610Reviewed-by: Ryan Landay <rlanday@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541953}

Bug: 813716
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I44ca92b701d1fc1140bdbfb577fb9cb0a5680219
Reviewed-on: https://chromium-review.googlesource.com/953972
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541952}

These need a different service account than some of the other trybots
for some of the tests they check out and run.

Bug: 815092
Change-Id: Ieb4eb45971c5b057642722eb615f586e8e212d6b
Reviewed-on: https://chromium-review.googlesource.com/955681Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541951}

Currently in ExtensionApiFrameIdMap::UpdateTabAndWindowId and
ExtensionApiFrameIdMap::LookupFrameDataOnUI we don't check whether a
RenderFrameHost is alive, before storing it's frame data. It's possible that
such a RenderFrameHost never becomes alive, and hence we don't get any
OnRenderFrameDeleted notification for it. Since ExtensionApiFrameIdMap is a
singleton, this causes a memory leak. To fix, ensure that only live
RenderFrameHosts are tracked.

Also ensure in InProcessBrowserTest::TearDown that ExtensionApiFrameIdMap is not
leaking memory for any browser test.

BUG=817205

Change-Id: I78bf06cee7e10465f9eb5973ee8e59f525a74d93
Reviewed-on: https://chromium-review.googlesource.com/951975Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541950}

Refactors the watcher APIs a bit to support some exensibility. Also
renames them in the process because "trap" seems like a better analogy.

Some remnants of the watcher concept are left intact to keep the CL size
small.

TBR=dcheng@chromium.org

Bug: 819046
Change-Id: Ie469f715c32080824d99b3a4f85834c030cbd181
Reviewed-on: https://chromium-review.googlesource.com/952081Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541949}

DownloadManager::InputStream is backed by either a ByteStreamReader or a
DataStreamHandle. The former is implemented in content/. And it is used
by the legacy download code. For network service, the latter is used.
To move download code to components/, this CL makes them 2 separate
child class of a common download::InputStream.
And that makes code more simple to read as there used to be a lot of
if-else statement to check which one is used in the InputStream.

Bug: 803135
Change-Id: Icab5369583b186bf253aec84f1d59769162300c9
Reviewed-on: https://chromium-review.googlesource.com/952023
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Joy Ming <jming@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541948}

Adds a test to ensure that quickly scrolling on the Daydream
controller's touchpad in the VR Browser results in a fling scroll.

Also refactors some related test code to reduce duplication between test
cases.

Bug: 762213
Change-Id: I6a041a6051c9bfc0648c90b04a8a44b06261ae9d
Reviewed-on: https://chromium-review.googlesource.com/874615
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541947}

Most developers use this harness when running the tests locally, and
they should all have depot_tools' vpython on their PATH. This will
help ensure that they get the hermetic Python that the bots use.

This won't have any effect on the bots since they invoke vpython
earlier, and run more wrapper scripts before getting to this one.

TBR=iannucci@chromium.org, ynovikov@chromium.org

Bug: 716241
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I820ae66b0232387328c75f937c241050f8776c59
Reviewed-on: https://chromium-review.googlesource.com/956553Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541946}

Re-recorded the page set on Linux with:
  ./tools/perf/record_wpr --browser=system tough_webgl_cases_page_set

Uploaded the result with:
  depot_tools/upload_to_google_storage.py --bucket chromium-telemetry \
    tools/perf/page_sets/data/tough_webgl_cases_006.wprgo

Bug: 807388
Change-Id: Ie497ef20c5bb0e15fa829e2016e3793ec9ece9f3
Reviewed-on: https://chromium-review.googlesource.com/936324
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#541945}

Generalizes the ability to specify specific revisions for other
repositories when using the VR bisect script. Previously, this was only
available as an option for specifying a clank revision, but can now be
used if some other repository is causing compile errors in the
regression range.

Change-Id: Ieb5045b21989541102a1f57bcf17e0b0e18f710c
Reviewed-on: https://chromium-review.googlesource.com/956562
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541944}

This occured when a user used seach+s to start speech while speech
was already in progress. The change makes sure that chrome.tts.stop
is called before the 'isSpeaking' callback is fired, to make sure
that it doesn't get called late.

This may cause a few cancel events to not be logged if the tts engine
responds very quickly, but based on some manual testing it appears
that events should be fine because the tts engine has some latency.

I'm not sure how to write tests for this because it requires a lot
of timing and a real TTS engine. Open to suggestions. Works well based
on local testing, repeatedly using search+s and search+mouse to
to cancel and restart speech.

Bug: 819926
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9b59caa4d69be1c0a8ae14af6c850113ff140360
Reviewed-on: https://chromium-review.googlesource.com/956226Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541943}

Change-Id: I707c135fe9d7e7c18fb881f617c432a24584959e
Reviewed-on: https://chromium-review.googlesource.com/956084
Commit-Queue: Alan Lau <alanlau@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541942}

A new RECOMMENDS field was added to the templates for debian packaging
in https://crrev.com/c/924193, but the substitution wasn't added to the
template processor for AppShell's installer.

This is a band-aid; code like this should be moved into a common place,
like a component that creates installers given product-specific
arguments.

This regression wasn't detected because the CQ doesn't build the
AppShell installer. With the Chrome installer added to Linux CQ bots
(issue 758654), we should consider building the AppShell installer too.

Bug: 729667,820270
Change-Id: I265a3823b8523e15ff295d7f5e46c4b4b9d84f8d
Reviewed-on: https://chromium-review.googlesource.com/956603Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541941}

Bug: 792865
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I403b8d512bb6d7c8d0e4c6947a8704544ef0f27a
Reviewed-on: https://chromium-review.googlesource.com/956312Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541940}

Don't use the odd yellow-ish highlight rect around the whole BrowserActionsContainer. Instead, highlight each button as needed.

TBR=oshima@chromium.org

Bug: 817180
Change-Id: I9005dd611534b69127dbbcfec666ffb2a81da27d
Reviewed-on: https://chromium-review.googlesource.com/952087
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541939}

This fixes a minor mismatch between the field trial testing config docs
and the list of supported platform strings that are tested for in
testing/variations/PRESUBMIT.py (docs say 'windows', presubmit requires
'win').

Bug: None
Change-Id: Id1bbd0a501043c1c818a13f15618e3a440dd79b8
Reviewed-on: https://chromium-review.googlesource.com/956490Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541938}

deqp/functional/gles3/shaderoperator/common_functions.html
on Mac Intel.

BUG=820225
TBR=kbr@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If8790e13fc6e1563d58aa7e03dadffdb6e23fa80
Reviewed-on: https://chromium-review.googlesource.com/956320
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541937}

Updates the feed to 6dd696995de00102e0fd9e3433e8ace87247b6d4.

Updates the third_paty/feed/BUILD.gn accordingly.

Feed has no DEX impact and total binary size impact is 1,080 bytes.

It took about 25 minutes to prepare the update patch following
instructions. Building for binary size comparison took another
25 minutes, but that work was non-interactive.

Change-Id: If800b13d2058c74e6a1f0a5724f21d732fddd592
Reviewed-on: https://chromium-review.googlesource.com/955886Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541936}

Includes support for both Cardboard (gaze cursor) and Daydream (3DoF)
input modes. In 3DoF mode the WebXR pointer and controller align with
the VR Shell versions.

Bug: 812287
Change-Id: I8dcfe7cdadc9f2c0216208e643c9f11211498e25
Reviewed-on: https://chromium-review.googlesource.com/956524Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541935}

Change-Id: I827cb57345850d703431dc80c1236968737f6a43
Reviewed-on: https://chromium-review.googlesource.com/948542Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541934}

This CL:
1) Prevents the Log messages in WebApkUpdateManager from getting stripped
  in release by converting the logs from Log.v to Log.i
  The Log messages are useful for determining:
  - Whether the updated web page satisfies the PWA checklist
  - Whether an update is requested

2) Adds to chrome://webapks
   WebappDataStorage#KEY_LAST_REQUESTED_SHELL_APK_VERSION
   WebappDataStorage#KEY_RELAX_UPDATES
   These two SharedPreferences are useful for determining how long to
   wait to launch the WebAPK in order to run the update check. In the
   case of "relaxed updates", the update check is done every 30 days.

BUG=815282
R=dominickn@,calamity@
TBR=yfriedman@
    (for CollectionUtil.java change reviewed in another CL)

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I87c77ca76884515f967a9bd9d331eb5c2af7bbfe
Reviewed-on: https://chromium-review.googlesource.com/936582
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541933}

This reverts commit ba3357d7.

Reason for revert: another change landed with this in flight, causing
compile error.

Original change's description:
> Rename omnibox_theme's OmniboxState -> OmniboxPartState
> 
> This avoid a conflict with class OmniboxState in an anonymous enum of
> omnibox_view_views
> 
> Bug: 801583
> Change-Id: Ifbf5ebd3f421e7ead9bd18e62d2c9786db3ae08b
> Reviewed-on: https://chromium-review.googlesource.com/954527
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Commit-Queue: Trent Apted <tapted@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541930}

TBR=pkasting@chromium.org,tapted@chromium.org

Change-Id: I1c301b8e84dbee66179bacbddc52bc44376d1456
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 801583
Reviewed-on: https://chromium-review.googlesource.com/956363Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541932}

This happens when ng cacheing is enabled.

Following tests crash with Cache flag without the fix:
compositing/geometry/composited-in-columns.html
external/wpt/css/css-multicol/multicol-break-000.xht
external/wpt/css/css-multicol/multicol-break-001.xht
fast/block/float/floats-do-not-overhang-from-block-formatting-context.html
fast/block/positioning/offsetLeft-offsetTop-multicolumn.html
fast/css/getComputedStyle/getComputedStyle-zoom-and-background-size.html
fast/css-intrinsic-dimensions/multicol.html
fast/forms/number/number-spinbutton-in-multi-column.html
fast/forms/select/listbox-in-multi-column.html
fast/multicol/auto-height-forced-break-complex-margin-collapsing.html
fast/multicol/balance-break-inside-avoid.html
fast/multicol/balance-floats.html
fast/multicol/balance-short-trailing-empty-block.html
fast/multicol/balance-trailing-border-after-break.html
fast/multicol/balance-trailing-border.html
fast/multicol/balance-unbreakable.html
fast/multicol/break-after-always-bottom-margin.html
fast/multicol/break-before-first-line-in-first-child.html
fast/multicol/break-properties.html
fast/multicol/client-rects-rtl.html
fast/multicol/client-rects.html
fast/multicol/composited-layer.html
fast/multicol/cssom-view.html
fast/multicol/first-line-in-block-below-next-column-top.html
fast/multicol/first-line-in-block-with-padding-exact-fit.html
fast/multicol/first-line-in-block-with-padding.html
fast/multicol/first-line-in-float-below-next-column-top.html
fast/multicol/first-line-in-float-with-margin.html
fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html
fast/multicol/fixedpos-in-transform-at-column-boundary.html
fast/multicol/flipped-blocks-hit-test.html
fast/multicol/float-beside-bfc.html
fast/multicol/float-moved-by-child-line-and-unbreakable.html
fast/multicol/float-with-margin-moved-by-child-block-and-unbreakable.html
fast/multicol/float-with-margin-moved-by-child-block.html
fast/multicol/float-with-margin-moved-by-child-line-and-unbreakable.html
fast/multicol/float-with-margin-moved-by-child-line.html
fast/multicol/float-with-margin-moved-unbreakable.html
fast/multicol/forced-break-before-complex-margin-collapsing.html
fast/multicol/forced-break-in-nested-columns.html
fast/multicol/hit-test-above-or-below.html
fast/multicol/hit-test-end-of-column-with-line-height.html
fast/multicol/hit-test-end-of-column.html
fast/multicol/hit-test-float.html
fast/multicol/hit-test-translate-z.html
fast/multicol/image-inside-nested-blocks-with-border.html
fast/multicol/inline-getclientrects.html
fast/multicol/inner-multicol-moved-into-continuation.html
fast/multicol/insane-column-count-and-padding-nested-crash.html
fast/multicol/margin-bottom-and-break-after.html
fast/multicol/min-height-greater-than-content.html
fast/multicol/min-height-greater-than-height.html
fast/multicol/min-height-less-than-content.html
fast/multicol/min-height-less-than-height.html
fast/multicol/min-height-much-greater-than-content.html
fast/multicol/nested-balancing-with-line-at-exact-top.html
fast/multicol/nested-balancing-with-lines-and-space-left-in-previous-row.html
fast/multicol/nested-inner-auto-height-outer-extra-space.html
fast/multicol/nested-one-line-in-inner.html
fast/multicol/nested-short-first-row-extra-tall-line.html
fast/multicol/nested-short-first-row-unsplittable-block.html
fast/multicol/nested-uneven-inner-column-height.html
fast/multicol/nested-with-forced-breaks-in-eariler-rows.html
fast/multicol/orphaned-line-at-exact-top-of-column.html
fast/multicol/orphans-relayout.html
fast/multicol/relayout-and-push-float.html
fast/multicol/shadow-breaking.html
fast/multicol/three-inner-rows.html
fast/multicol/unforced-break-after-complex-margin-collapsing.html
fast/multicol/widows-and-orphans.html
fast/multicol/widows.html
fast/multicol/widows2.html
fast/multicol/dynamic/bottom-aligned-abspos-change-column-height.html
fast/multicol/newmulticol/balance-images.html
fast/multicol/newmulticol/balance-maxheight1.html
fast/multicol/newmulticol/balance-maxheight2.html
fast/multicol/newmulticol/balance1.html
fast/multicol/newmulticol/balance10.html
fast/multicol/newmulticol/balance2.html
fast/multicol/newmulticol/balance3.html
fast/multicol/newmulticol/balance4.html
fast/multicol/newmulticol/balance5.html
fast/multicol/newmulticol/balance6.html
fast/multicol/newmulticol/balance7.html
fast/multicol/newmulticol/balance8.html
fast/multicol/newmulticol/balance9.html
fast/multicol/newmulticol/orphans-and-widows-balance.html
fast/multicol/span/autofill-after-spanner.html
fast/multicol/vertical-lr/break-properties.html
fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html
fast/multicol/vertical-lr/balancing/balance-trailing-border-after-break.html
fast/multicol/vertical-lr/balancing/balance-trailing-border.html
fast/multicol/vertical-lr/balancing/balance-unbreakable.html
fast/multicol/vertical-rl/break-properties.html
fast/multicol/vertical-rl/balancing/balance-short-trailing-empty-block.html
fast/multicol/vertical-rl/balancing/balance-trailing-border-after-break.html
fast/multicol/vertical-rl/balancing/balance-trailing-border.html
fast/multicol/vertical-rl/balancing/balance-unbreakable.html
fast/pagination/multicol.html
fragmentation/abspos-after-forced-break.html
fragmentation/avoid-break-inside-first-child-nested.html
fragmentation/avoid-break-inside-first-child.html
fragmentation/block-with-float-and-1-orphaned-line.html
fragmentation/break-after-last-child.html
fragmentation/break-before-empty-child-block.html
fragmentation/break-before-first-child.html
fragmentation/break-in-caption-before-tbody.html
fragmentation/break-in-first-table-row-only.html
fragmentation/break-in-first-table-section.html
fragmentation/break-in-second-table-section.html
fragmentation/break-in-tbody-after-caption.html
fragmentation/break-inside-avoid-with-forced-break.html
fragmentation/cell-taller-than-col-straddles-columns.html
fragmentation/class-c-break-after-clearance.html
fragmentation/collapsing-class-a-breakpoints.html
fragmentation/float-after-forced-break.html
fragmentation/image-block-as-first-child.html
fragmentation/multi-line-cells.html
fragmentation/repeating-thead-exceeds-page-size.html
fragmentation/repeating-thead-no-room-for-content-row-on-first-page.html
fragmentation/single-cell-too-large-for-page.html
fragmentation/single-cells-multiple-tables-no-repeating-thead.html
fragmentation/single-line-cells-in-multiple-table-sections.html
fragmentation/single-line-cells.html
fragmentation/table-in-subpixel-fragmentainer.html
fragmentation/table-overlapping-rowspan.html
fragmentation/table-row-dimensions-break-freely.html
fragmentation/table-row-dimensions-with-thead.html
fragmentation/table-row-dimensions.html
fragmentation/tbody-before-thead.html
paint/invalidation/overflow/paged-with-overflowing-block-rl.html
paint/pagination/pagination-change-clip-crash.html
printing/multicol.html
printing/pageProperty-with-multicol.html

Bug: 819372
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I5df07ebf451527a640d7a5f4125d10a3e7441bc8
Reviewed-on: https://chromium-review.googlesource.com/952262
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541931}

This avoid a conflict with class OmniboxState in an anonymous enum of
omnibox_view_views

Bug: 801583
Change-Id: Ifbf5ebd3f421e7ead9bd18e62d2c9786db3ae08b
Reviewed-on: https://chromium-review.googlesource.com/954527Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541930}

Added aria-labels as one of the possible things to be used as a label
for form control elements because they may contain useful information
for username detection.

Bug: 783185
Change-Id: I59a7f025c616f38d533c9c9a7327ec8ec9021c4c
Reviewed-on: https://chromium-review.googlesource.com/951765Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541929}

Also rearrange other Android GPU.FYI bots hierarchy.

BUG=808610

Change-Id: I8f959215b35e5759a759a5c96c0252cdd70c4d0a
Reviewed-on: https://chromium-review.googlesource.com/955951Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541928}

The clip for iframes was missing when the iframe did not have its
own composited layer. Fix the overly aggressive "NeedsClip"
code to not return false for all LayoutEmbeddedContent in most
paint modes.

R=chrishtr@chromium.org
BUG=814177

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iae77a367839f8dfccda817a31ab1cc988ecd0436
Reviewed-on: https://chromium-review.googlesource.com/956031Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541927}

Fixes the ContentFaviconDriverTest browser tests with the network
service by switching to using a URLLoaderInterceptor instead of the
URLRequestDispatcherHost.

Bug: 787614
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ifc04f6b8c85461f4974a8f6dd11b27e1beeef188
Reviewed-on: https://chromium-review.googlesource.com/955892Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541926}

Bug: 804560
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8a7f1779aff808edddc525110c8900cbd9fd8b8a
Reviewed-on: https://chromium-review.googlesource.com/955345Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541925}

Modified the voice overlay to be a dialog element, and expanded the keydown event handler to handle keydown events on buttons/links as click events.

As a side effect, switching to a dialog element also fixes the fade in animation for the voice overlay.

Bug: 706908
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9dd79e21aa2b1f6c429e7f6d6957b18db2aa03a9
Reviewed-on: https://chromium-review.googlesource.com/945146
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541924}

Note from the comments in cc::Layer that the bounds of root cc::Layers
are specified in pixels, in contrast with those of non-root cc::Layers,
which are specified in DIPs.

Add a compositor_viewport_pixel_size() accessor to RenderWidget to
access this from the sub-class (naming is due the pending renaming of
physical_backing_size to compositor_viewport_pixel_size).

Bug: 814690
Change-Id: Ia8033961e04f18c374123b4f9f8da96be131edc7
Reviewed-on: https://chromium-review.googlesource.com/954359Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541923}

linux_dmabuf_v1 has been updated, clients have been updated to
use "create_immed" that is available starting from v2, but we forgot
to bump up the version we pass to wl_registry_bind.

This patch updates the wayland test client code.

Bug: None
Test: wayland_rects_client --use-drm=rockchip on kevin now works.
Change-Id: I83b16f48e797a275208df7f3d7cccfed8f0a5e40
Reviewed-on: https://chromium-review.googlesource.com/956563Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541922}