- 23 Jul, 2019 40 commits
-
-
Yi Gu authored
The test is flaky on Win. See https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyZgsSBUZsYWtlIltjaHJvbWl1bUBibGlua193ZWJfdGVzdHNfZXhwYXJjaGl2ZUBodHRwL3Rlc3RzL2RldnRvb2xzL2VsZW1lbnRzL2VkaXQvZWRpdC1kb20tYWN0aW9ucy0xLmpzDA TBR=luoe@chromium.org NOTRY=true Bug: 985811 Change-Id: Ie224b703dc1b6c45765ff52f54e793aa46d9af87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714327Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#679827}
-
Gayane Petrosyan authored
Bug: 960982 Change-Id: I308196d1210ab9d3e45ea79c68a754cf1789660b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713276 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#679826}
-
Jeremy Chinsen authored
Currently draw_utils::GetPageInsetsForTwoUpView() checks that the |page_index| is greater than or equal to 0. Since |page_index| is size_t, it can never be less than 0. Change-Id: Ied708bec3f5bbfa8861b97e10ba584b66fbb59fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714207Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Cr-Commit-Position: refs/heads/master@{#679825}
-
Xing Liu authored
This CL adds a time randomizer for notification scheduler background task. Bug: 963283 Change-Id: I79f255733b01f6257fb39e603270345c2f08d706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708014 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#679824}
-
Hiroki Nakagawa authored
Bug: 986019 Change-Id: Ie0033961c6e4b00eec638006a580a86c81f695dc Notry: true Tbr: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714193Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#679823}
-
Yuly Novikov authored
Reflecting the upgrade from Android P to Q. TBR=kbr Bug: angleproject:3340 Change-Id: I49b35fe898f4b5b0a877d02a267b7684d337d62a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714287Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#679822}
-
Julian Watson authored
This change refactors the export import notification, such that all string handling is internal, and such that there is a more defined API for setting the many status variants. This change facilitates two incoming changes: one that adds the status CANCELLING and CANCELLED to the notification, and another that adds another variant on the failed status to do with concurrent operations. BUG=chromium:978318 Change-Id: Icc101378ce2f6650f1dc646d06af868684bd56b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702346 Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#679821}
-
Patrick Monette authored
Bug: 943303 Change-Id: I7bcc5b787851409dc488811446cbbdca51963f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712947Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#679820}
-
Lei Zhang authored
https://crrev.com/675319 added more std::unique_ptr usage, but did not always #include <memory>. As a result, the CL only builds due to luck. When one sets use_custom_cxx=false, they no longer build, as seen in this thread: https://groups.google.com/a/chromium.org/d/topic/chromium-packagers/UyJsVJ5QqWo/discussion Change-Id: Ib9812b3210dac60176128b22c3881f7f33d785f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713037Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#679819}
-
Meilin Wang authored
This change fixes the incorrect clickable zone of |zippy-additional| on the assistant third party oobe page. In this way, a modal dialog only shows up when user clicks the link (the <a> element). Clicks on any other parts besides <a> in |zippy-additional| will have no effect on the page. Bug: none. Test: manually. Change-Id: Id5f2f136afcb2fdc677f79cae597c0909d44f141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713945 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#679818}
-
Josh Nohle authored
Change the Sync() input from RequestContext to ClientMetadata and ClientAppMetadata. The RequestContext will be built internally from these components. The ClientAppMetadata is also needed to build the local device's BetterTogetherDeviceMetadata. We also update comments and add a "private" access specifier. Bug: 951969 Change-Id: Ib58128ba706aa8ba3d6a027f987e6cc221a7987d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711144 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#679817}
-
Miyoung Shin authored
This is a reland of cc61e814. The origin CL has twice reverted behavior. The first one caused by the build broken of Linux chromium.fuzz and the breakage had been fixed at 1b39b8b1 with updating including the path. And the second one caused by failing autofill tests in chrome_public_test_apk but autofill tests had still failed even after reverted the CL and it wasn't related to that failures. So there is nothing change from the origin CL at this time. Original change's description: > Reland "Rename traits and mojo directory in //components/autofill/" > > This is a reland of 1b39b8b1 > > Original change's description: > > Rename traits and mojo directory in //components/autofill/ > > > > This CL renames interfaces to mojom and *_struct_traits.* > > to *_mojom_traits.* in //components/autofill/. > > > > *_struct_traits.* => *_mojom_traits.* > > components/autofill/content/common/ => components/autofill/content/common/mojom > > > > Bug: 806965 > > Change-Id: Ie24626259372bacf83399c48f2c1fadbef66aabc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703477 > > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#678167} > > Bug: 806965 > Change-Id: I0f6e5a33d7963d5384066a88367744eb385fe742 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705914 > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678567} Cq-Include-Trybots: luci.chromium.try:android_mojo Bug: 806965 Change-Id: I7d57a878954c58a1938d07674f81ae846dad314a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709316 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/32b89794cac6..4fbd1e670284 Created with: gclient setdep -r src-internal@4fbd1e670284 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tinazwang@google.com,horo@google.com,yigu@google.com Change-Id: I50d9e23e22e924ecb2aac89066a22babb66ce616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712611Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679815}
-
Kristi Park authored
CustomizedFeature.CUSTOMIZED_FEATURE_SHORTCUT was logged each time the tiles were reloaded, which could happen multiple times per page load (e.g. after editing a shortcut, when the list of Most Visited sites was updated, etc). This is potentially causing inflation in the number of customized NTPs. Log CustomizedFeature.CUSTOMIZED_FEATURE_SHORTCUT when the NTP metrics are emitted on page load, instead of through LogEvent. Bug: 985130 Change-Id: I7ca22b8c11b1d5f3464299c375a2c0f4e6173a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707570 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
-
Will Harris authored
This is a reland of 7d5fe940 Original change's description: > Reland "Sandbox: Add support for CIG pre-launch." > > This is a reland of 9e89ae37 > > Original change's description: > > Sandbox: Add support for CIG pre-launch. > > > > This CL allows MITIGATION_FORCE_MS_SIGNED_BINS to be > > enabled pre-launch for targets even with dependent DLLs > > It achieves this by adding a sandbox intercept for > > NtCreateSection and permitting sections backing modules > > that match a whitelist to be created in the broker > > and mapped into the target for the load to succeed. > > > > BUG=750886 > > > > Change-Id: Iac22e206f77f99d9c2253e906780f1bcf5e8e3e6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660097 > > Commit-Queue: Will Harris <wfh@chromium.org> > > Reviewed-by: James Forshaw <forshaw@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#676665} > > Bug: 750886 > Change-Id: I0de3189df0e5435fb33717fcaa3f82768d4504f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699271 > Reviewed-by: James Forshaw <forshaw@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#677510} Bug: 750886 Change-Id: Ib77c5590e58c395d8cedef12be46896919c457ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709798Reviewed-by:
James Forshaw <forshaw@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#679813}
-
Caitlin Fischer authored
This happens with and without the AutofillUseImprovedLabelDisambiguation feature enabled--but in different situations. See the bug for specific examples. Bug: 984957 Change-Id: I75e297f384f7883db0409d40af7995acc92cacdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706579Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#679812}
-
Stephen Martinis authored
Bug: 863028 Change-Id: Ie44f7eb962a76b3eb0fa58de4b6b32d2a11c3685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713709 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#679811}
-
Thanh Nguyen authored
Add codes in ash that notify chrome about the list of items being shown to users if any items got clicked. The data processing and logging parts in chrome will be implemented later. Bug: 972817 Change-Id: I4a311a4f00838a2966ee813e9606dc1b5eb24ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677807 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#679810}
-
Jordy Greenblatt authored
In my fix [1] for our bug to change the OS Settings 'downloads' section to a naming pattern based around the term 'files' to match UX specs [2], I didn't add a separate route for files for OS-Settings. This CL adds that section in. I manually ensured that clicking 'Files' item in os-settings-menu scrolls to the 'Files' section [3]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1696180 [2] http://crbug.com/978648 [3] http://screen/9QpZtnw8TS0 Bug: 986466 Change-Id: I7d255a41015b307c674bf231878dffa72066ca5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713909Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#679809}
-
Kristi Park authored
Log when the user changes their shortcut settings (i.e. type and visibility) as a CustomizeShortcutAction. Also log the current user shortcut settings on page load for Google NTPs. This will be emitted once per page. Bug: 953822 Change-Id: Iba8ae4e7a0773967bb388535dd6650423b2a56ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704034 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
-
dpapad authored
Bug: 965770 Change-Id: I393be10bdb7b9621ab723d15aa04aed5d5993729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713255 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#679807}
-
Aaron Leventhal authored
This reverts commit e5ab7cc7. Reason for revert: The DeleteClientSubtree() changes can lead to crash. Original change's description: > Make AXTreeSerializer safer > > The tree serializer should not crash even if the given tree has invalid > nodes. These changes don't alter behavior but removed possibilities for > accessing dangling pointers. > > Bug: 981311 > Change-Id: I8f2e55771c12a03955f7632335bea347b6a5af30 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707949 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678670} TBR=zork@chromium.org,nektar@chromium.org,aleventhal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 981311 Change-Id: I1d00c05fb0af2ec48d645e475cfcceb9421bd5d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713813 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#679806}
-
Xi Han authored
The bug was introduced in: https://crrev.com/c/1702862. The startup mode should be obtained in handlePostNativeStartup(), rather than in the deferred task. This CL fixes the issue and we continue to use Servicification.Startup3 since it is only in canary for few days. Bug: 984559 Change-Id: I8c630d8ef267955e2b71aaae1199170980b1daf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710002 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#679805}
-
Katie D authored
TBR=anastasi@google.com Change-Id: I181013d765b32146033348186008e02e03f3da74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714209Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#679804}
-
Tina Wang authored
The test became flaky recently. See bug for details. TBR=guidou@chromium.org Bug: 986470 Change-Id: Ibab83e4393ba8e305340b21d01e2716dd4afb07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713366 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#679803}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/da50ef4e8d15..2fb54ea4618d git log da50ef4e8d15..2fb54ea4618d --date=short --no-merges --format='%ad %ae %s' 2019-07-22 simonhatch@chromium.org Dashboard - Add jinja2 dependency to api Created with: gclient setdep -r src/third_party/catapult@2fb54ea4618d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:985917 TBR=zhanliang@google.com Change-Id: Iaed86948c49fd1b3ada7da1a811007abc3fe136f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713572Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679802}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/05c925d2e7f0..cde26f18fbf1 git log 05c925d2e7f0..cde26f18fbf1 --date=short --no-merges --format='%ad %ae %s' 2019-07-22 rsavitski@google.com Merge "Fix incorrect parameter in README." Created with: gclient setdep -r src/third_party/perfetto@cde26f18fbf1 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I0975a80ba2f84730522fe848275192542b9bbf77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713573Reviewed-by:
-
Jordan Bayles authored
As part of our work to get Open Screen working in Chromium, this patch adds a simple task runner implementation for integrating Open Screen in Chromium. It wraps base::SequencedTaskRunner as simply as possible. Change-Id: I794f0c3c221804fefb80ba84922a1fc9e1b40496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708998 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#679800}
-
Jack Lynch authored
This change adds more descriptive aria-labels for the add/refresh buttons. Screenshot: https://gyazo.com/6e5092a5b059c9fecb38141a0f9823a5 Bug: 963183 Change-Id: I31b81f1204393b7061c69bfd0a34c16dc564ac07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646644 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#679799}
-
Jimmy Gong authored
- Alphabetically sort PrinterEntries, which applies to both Saved printers and nearby printers. - Updates browser tests. Bug: 965721 Test: end to end manual, browsertest Change-Id: I6ee45d6d91ae51dca0cc4ef5479bbf9490f82fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706880 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#679798}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/496d1cd2da51..79b937fc949d git log 496d1cd2da51..79b937fc949d --date=short --no-merges --format='%ad %ae %s' 2019-07-22 mikenichols@chromium.org Reland "cros tryjob: Add --infra-testing and remove --staging option" 2019-07-22 saklein@chromium.org Build API: Add automatic chroot file extraction mechanism. 2019-07-22 eashanbhatt@google.com cros_test_unittest: Add Start VM Unittest 2019-07-22 evanhernandez@chromium.org test: Pass chroot path to moblab_vm. 2019-07-22 evanhernandez@chromium.org moblab_vm: Accept optional chroot parameter. 2019-07-22 evanhernandez@chromium.org vm: Chroot path is a flag. Created with: gclient setdep -r src/third_party/chromite@79b937fc949d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I013a3ab17de3dbf8ea65aade7f3ff63906067374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713040Reviewed-by:
-
Yi Gu authored
The test started to fail a DCHECK added in crrev.com/c/1696443. See bug for details. TBR=amehfooz@chromium.org Bug: 986571 Change-Id: I158c1677ca85effb61f3a427ec8cc796ce492786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711892Reviewed-by:
-
Kevin Babbitt authored
Currently, in the renderer, accessibility actions go to a WebAXObject, but plugins such as PDF do not generate WebAXObjects. This CL introduces an AXActionTarget abstraction that allows allow actions to be dispatched without knowing the underlying node type. Bug: 769940 Change-Id: I056d3d2ef325258c2dff5a328fe9958f25cbd77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693772 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#679795}
-
Brian Sheedy authored
Adds an example of how to run the GPU pixel tests locally to the GPU Skia Gold documentation. TBR=ynovikov@chromium.org Bug: 985418 Change-Id: I7610d8e7e37bfa4c40e5c25fa85eb9beb394fec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714186Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Stephane Zermatten authored
This reverts commit ab14c6bc. Reason for revert: I propose reverting this change as it breaks Autofill Assistant. This causes an assertion in setSheetState to fail if onSizeChanged is called while in SCROLLING state. A simple workaround that skips setSheetState from ensureContentIsWrapped in SCROLLING mode might be more dangerous than reverting. Original change's description: > Android: BottomSheet animation from hidden to peek > > BottomSheet animation from hidden to peek state was not working > due to multiple calls to set the sheet state cancelling the > previous one that enables animation. This CL adds a few more > checks to make the subsequent calls no-op if we're already in the > requested state or in the middle of animation toward the state. > > Bug: 937946 > > Change-Id: I48f3e2ca20746bc1f976ce58de774276cb227998 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701131 > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678568} TBR=mdjones@chromium.org,jinsukkim@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 937946 Change-Id: I942684d2cbfeb97a503a1c8a5eac367a90862cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710655 Auto-Submit: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#679793}
-
Brian Sheedy authored
Removes the failure expectation for Pixel_CanvasLowLatency2D in Android Webviews, as it was conflicting with the skip expectation for the same test in Webview. TBR=kbr@chromium.org Change-Id: Ib13a753d19cf1bb8cd55d20a2293588fd9b5ec34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713307Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#679792}
-
rajendrant authored
Add adds param for lazyload experiment, enable-lazy-load-images-metadata-fetch is likely to be false when launching TBR=holte@chromium.org Change-Id: Iaaa9977a8834f0e6c9cee02adbba90cd37d01aca Bug: 950645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707176 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#679791}
-
Yi Gu authored
Mark virtual/disable-blink-gen-property-trees/animations/web-animations/animation-state-changes-positive-playback-rate.html as flaky The disable BGPT path was not spiked until July 22 pm. TBR=flackr@chromium.org Bug: 986019 Change-Id: I9a25c3bcbaafb4bb1ad3c776f421baa6cb0d7635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713811Reviewed-by:
-
Andrew Luo authored
Bug: 924194 Change-Id: I200b9147c95f68dd1f9356fa6959ebfab716e2bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668709 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#679789}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/77950aa0a8d2..b7dad440407e git log 77950aa0a8d2..b7dad440407e --date=short --no-merges --format='%ad %ae %s' 2019-07-22 reed@google.com Reland "hide drawlooper from paint" 2019-07-22 ethannicholas@google.com fixed SkSL handling of constant arrays 2019-07-22 mtklein@google.com move hoist analysis back into Builder 2019-07-22 fmalita@chromium.org [skottie-wasm-perf] Don't redraw unchanged frames 2019-07-22 fmalita@chromium.org [canvaskit] Return damage rect from ManagedAnimation::seek() Created with: gclient setdep -r src/third_party/skia@b7dad440407e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Change-Id: Ia2ce0d7bdb734aa9df944c5716aa7707bc36996b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713585Reviewed-by:
-
