GitLab

SigninInteractionController uses an AlertCoordinator to display
potential sign-in errors, which requires the view controler to use to
present the alert dialog.
To ensure SigninInteractionController can always display correctly
errors, the AlertCoordinator must be given the top most visible view
controller (some errors are displayed before the sign-in screen is
shown, and some are displayed on top of the sign-in screen).

BUG=679809

Review-Url: https://codereview.chromium.org/2626003004
Cr-Commit-Position: refs/heads/master@{#443230}

Added benchmarks: v8.todomvc-turbo, v8.infinite_scroll-turbo_tbmv2, v8.browsing_mobile_turbo, v8.browsing_desktop_turbo

R=mvstanton@chromium.org,hpayer@chromium.org
BUG=v8:5827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2623113003
Cr-Commit-Position: refs/heads/master@{#443229}

When add main thread scrolling reason kHandlingScrolFromMainThread, there is no need to update the subframes as they are not scrollable when the reason is set to main frame.
BUG=675677

Review-Url: https://codereview.chromium.org/2620453003
Cr-Commit-Position: refs/heads/master@{#443228}

Previously, we disabled the hackernews telemetry test as we tried to set the
default value of touch-events flag to enabled. Now we've changed the strategy
and reset the default value to auto. And recently, we also passed the test with
the flag set to be enabled. So the hackernews telemetry test no longer needs to
be disabled.

BUG=665007

Review-Url: https://codereview.chromium.org/2627163003
Cr-Commit-Position: refs/heads/master@{#443227}

BUG=602666

Review-Url: https://codereview.chromium.org/2621453002
Cr-Commit-Position: refs/heads/master@{#443226}

https://skia.googlesource.com/skia.git/+log/e7a364d43584..621ea115e0b1

$ git log e7a364d43..621ea115e --date=short --no-merges --format='%ad %ae %s'
2017-01-12 mtklein only copy NDK binaries when using NDK in our standalone builds

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2631483003
Cr-Commit-Position: refs/heads/master@{#443225}

Before this CL, URLFetcher could only be instantiated from a
single-threaded task. The response was dispatched on the origin thread.

With this CL, URLFetcher can also be instantiated from a sequenced
task. The response is dispatched on the origin sequence.

Since SequencedTaskRunnerHandle behaves the same way as
ThreadTaskRunnerHandle when used from a single-threaded task, this
CL does not affect the behavior of existing URLFetcher call sites
(they are necessarily in single-threaded tasks because
base::ThreadTaskRunnerHandle::Get() crashes when called from
a non-single-threaded task).

BUG=675631

Review-Url: https://codereview.chromium.org/2599873002
Cr-Commit-Position: refs/heads/master@{#443224}

This will avoid the system from inappropriately coalescing them with
other kinds of notifications shown by Chrome.

BUG=674927

Review-Url: https://codereview.chromium.org/2627963003
Cr-Commit-Position: refs/heads/master@{#443223}

Some internal tests require special entitlements (e.g. for keychain
access). This was inadvertently dropped during the upstreaming.

BUG=679042

Review-Url: https://codereview.chromium.org/2632473002
Cr-Commit-Position: refs/heads/master@{#443222}

BUG=676382
TEST=none

Review-Url: https://codereview.chromium.org/2625123003
Cr-Commit-Position: refs/heads/master@{#443221}

BUG=678850
TEST=conformance/more/functions/vertexAttribPointerBadArgs.html,
     conformance/attribs/gl-vertexattribpointer.html,
     conformance2/attribs/gl-vertexattribipointer.html.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2610393003
Cr-Commit-Position: refs/heads/master@{#443220}

Now, TestingPlatformSupport registers itself as the current Platform
instance, but it is inside the constructor.

On the other hand, a child class TestingPlatformSupportWithMockScheduler
expects the parent class reigsters it for children.

But, to register a Platform instance, virtual methods should be ready
to call. Rephrasing it, we can not register a Platform instance
correctly inside a super-class's constructor.

This patch provides ScopedTestingPlatformSupport class template that
manages TestingPlatformSupport instance and Platform instance
installation.

Without this patch, Platform::current()->mainThread() returns a
wrong WebThread, and it makes new tests that I will add fail.

BUG=n/a
TEST=platform_blink_unittests, webkit_unit_tests

Review-Url: https://codereview.chromium.org/2588403002
Cr-Commit-Position: refs/heads/master@{#443219}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6377613b1a29..0e201cdd06ed

$ git log 6377613b1..0e201cdd0 --date=short --no-merges --format='%ad %ae %s'
2017-01-12 hjd Hopefully this will make it easier for people coming to the memory infra UI for the first time to understand what is happening.

BUG=663353

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2622363004
Cr-Commit-Position: refs/heads/master@{#443218}

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: SKIP_ON_SHUTDOWN (default)
  Tasks posted with this mode that have not started executing at
  shutdown will never run. However, any task that has already begun
  executing when shutdown is invoked will be allowed to continue and
  will block shutdown until completion.

  Note: Previously, the task was posted to the blocking pool with
  BLOCK_SHUTDOWN (default in SequencedWorkerPool).

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=667892

Review-Url: https://codereview.chromium.org/2628673003
Cr-Commit-Position: refs/heads/master@{#443217}

The lifetime of ExecutionContext and DOMWindow is a bit different.
In common case, they get detached at the same timing but in a case where
a frame navigates from an initial empty document to another same-origin document,
the ExecutionContext gets detached but the DOMWindow is reused.
Due to the (subtle) difference, we need DOMWindowClient in addition to ContextClient.

ContextClient is a client for objects that want to observe ExecutionContext.
DOMWindowClient is a client for objects that want to observe DOMWindow.

This CL uses DOMWindowClient for Navigator.

BUG=610176

Review-Url: https://codereview.chromium.org/2629493004
Cr-Commit-Position: refs/heads/master@{#443216}

BUG=679369

Review-Url: https://codereview.chromium.org/2619963004
Cr-Commit-Position: refs/heads/master@{#443215}

As a quick fix, I'll revert the change of file_manager_private.js in
https://codereview.chromium.org/2580303002/.

BUG=none
TBR=nya@chromium.org
TEST=run third_party/closure_compiler/run_compiler

Review-Url: https://codereview.chromium.org/2625233004
Cr-Commit-Position: refs/heads/master@{#443214}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d71b47153f16..6377613b1a29

$ git log d71b47153..6377613b1 --date=short --no-merges --format='%ad %ae %s'
2017-01-12 hjd [tracing] Use ES6 object literal notation when exporting symbols

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2631513003
Cr-Commit-Position: refs/heads/master@{#443213}

Instead, I modified V8 to just cope with this behavior

BUG=chromium:679345
R=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2625643002
Cr-Commit-Position: refs/heads/master@{#443212}

Title should be "Switch Sync Account" when switching, and "Sign in to
Chrome/Chromium" when signing in.

BUG=660418

Review-Url: https://codereview.chromium.org/2629443002
Cr-Commit-Position: refs/heads/master@{#443211}

Adds HeapCompaction as a FeatureList flag so it can be enabled from a Finch experiment.

BUG=678923

Review-Url: https://codereview.chromium.org/2624693002
Cr-Commit-Position: refs/heads/master@{#443210}

BUG=chromium:663353

Review-Url: https://codereview.chromium.org/2488933002
Cr-Commit-Position: refs/heads/master@{#443209}

Currently, the ConnectionEventTracker keeps a buffer in memory of events
which still need to be sent to GCM. If there is a shutdown, those events
are discarded without reaching GCM. This CL adds a metric to track the
event count at shutdown to give an estimate of how many events are being
lost and whether a persistence layer needs to be added.

BUG=662983

Review-Url: https://codereview.chromium.org/2594373002
Cr-Commit-Position: refs/heads/master@{#443208}

This patch gets rid of |CaretBase::m_caretLocalRect| to reduce number of states
in |CaretBase| to simplify class hiarachity for improving code health.

After this patch, |CaretBase| represents |DisplayItemClient| for caret.
Following patch will rename |CaretBase| to |DisplayCaretItemClient| and
|DragCaretController|, which should rename to |DragCaret| is derived from
|DisplayCaretItemClient| and makes |DisplayCaretItemClient| had no public
member except for destructor.

This patch is a preparation of [1]

[1] http://crrev.com/1958093002 On-demand visible selection canonicalizataion

BUG=680384
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2623053006
Cr-Commit-Position: refs/heads/master@{#443207}

mostForward/BackwardCaretPosition should be, but are currently not,
called with clean layout.

This patch ensures that they are called with clean layout at
several places in editing/commands

BUG=679991

Review-Url: https://codereview.chromium.org/2628693003
Cr-Commit-Position: refs/heads/master@{#443206}

New media view volumes are added to chromeos::VolumeManager so that they are
available to Files.app. UI patches are coming later, so at this point it looks like
unusable unknown volumes appear in Files.app. To hide them from users for now,
the feature is guarded with base::FeatureList. Once UI is ready I will make them
enabled by default.

BUG=chromium:671511
TEST=New (unusable) volumes are shown with --enable-features=ArcMediaView
TEST=Media views work with local pending UI patches

Review-Url: https://codereview.chromium.org/2580303002
Cr-Commit-Position: refs/heads/master@{#443205}

This patch fixes setting of css-wide keywords on registered custom
properties, which was broken by crrev.com/2607403002.

BUG=679627

Review-Url: https://codereview.chromium.org/2624213004
Cr-Commit-Position: refs/heads/master@{#443204}

Remove virtual/mojo-loading/http/tests/navigation/image-load-in-unload-handler.html from TestExpectations

The test looks no longer flaky.

BUG=674048

Review-Url: https://codereview.chromium.org/2624993002
Cr-Commit-Position: refs/heads/master@{#443203}

Clearing the whole font-cache without considering css-connected fonts
could be cheaper. This is a speculative fix for issue 677415.

BUG=677415

Review-Url: https://codereview.chromium.org/2622673003
Cr-Commit-Position: refs/heads/master@{#443202}

WritableStreamFinishClose would fail if the writer had been
detached. Add checks to stop this happening.

This updates the implementation to match Streams Standard version

https://github.com/whatwg/streams/commit/347667724b8a4b83fcc379b730603cf4cd0d6e91

which is current as of 12 Jan 2017.

Also update the tests to the same commit.

BUG=658144

Review-Url: https://codereview.chromium.org/2625873008
Cr-Commit-Position: refs/heads/master@{#443201}

The check as it is now was spamming too many unrelated changes.
Also make output of the check more precise by showing the line
number affected.

BUG=none

Review-Url: https://codereview.chromium.org/2622083006
Cr-Commit-Position: refs/heads/master@{#443200}

Changes the Reading List icon for the empty state with the new offline icon.

BUG=680152

Review-Url: https://codereview.chromium.org/2622003007
Cr-Commit-Position: refs/heads/master@{#443199}

As it is possible to specify multiple value for target_os in
.gclient, update the script build/mac_toolchain.py to download
the file for the hermetic build on all those OSes. Change the
path where the hermetic files are downloaded to use different
path for each OS.

BUG=680069

Review-Url: https://codereview.chromium.org/2626063002
Cr-Commit-Position: refs/heads/master@{#443198}

Fix compilation for removed files.

BUG=

Review-Url: https://codereview.chromium.org/2622263003
Cr-Commit-Position: refs/heads/master@{#443197}

Restore manual formatting in the kSimplePolicyMap array initializer and
add clang-format off and clang-format on sentinels to prevent accidental
reformatting in the future.

BUG=none

Review-Url: https://codereview.chromium.org/2628653003
Cr-Commit-Position: refs/heads/master@{#443196}

We will collect per allocator memory usage metrics for the renderer at DidFinishLoad and Shutdown.

GetRendererMemoryMetrics generalizes the memory info collection that was used in RecordPurgeAndSuspendMetrics for use with my new metrics.

GetRendererMemoryMetrics is in RenderThreadImpl because it accesses discardable_shared_memory_manager_.

BUG=

Review-Url: https://codereview.chromium.org/2566043004
Cr-Commit-Position: refs/heads/master@{#443195}

The API on action_runner to run JavaScript now supports safe and simple
interpolation of values into code templates. This CL fixes and cleans
up many of the callers which weren't using robust methods for quoting
such values.

BUG=catapult:#3028

Review-Url: https://codereview.chromium.org/2618333006
Cr-Commit-Position: refs/heads/master@{#443194}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/a048ce1..076b7ae

$ git log a048ce1..076b7ae --date=short --no-merges --format=%ad %ae %s
2017-01-12 sakal@webrtc.org Remove some Android lint suppressions.
2017-01-11 skvlad@webrtc.org Move MetricsObserverInterface out of peerconnectioninterface.h
2017-01-11 glaznev@google.com Initial implementation of Android audio recording error handling.
2017-01-11 deadbeef@webrtc.org Reland of: Adding error output param to SetConfiguration, using new RTCError type.
2017-01-11 michaelt@webrtc.org Add overhead to audio bwe min, max.
2017-01-11 henrika@webrtc.org Removes FATAL() from MicrophoneVolumeIsAvailable() on Android.
2017-01-11 sakal@webrtc.org Update Android instrumentation tests to use JUnit4.
2017-01-11 sakal@webrtc.org Update AppRTCMobile tests to use JUnit4.
2017-01-11 nisse@webrtc.org Replace ASSERT(false) by RTC_NOTREACHED().
2017-01-11 sprang@webrtc.org Remove backwards compatibilty path for OpenH264 v1.4
2017-01-11 sprang@webrtc.org Rename incoming_framerate_ to capture_framerate_ in screenshare_layers.
2017-01-11 hbos@webrtc.org RTCMediaStreamTrackStats.ssrcIds removed.
2017-01-11 magjed@webrtc.org Revert of Android: Add field trial for Intel HW Vp8 encoder (patchset #1 id:1 of https://codereview.webrtc.org/2614373004/ )
2017-01-11 philipel@webrtc.org Don't detect a new frame if a previous packet is used in a previous frame.
2017-01-11 magjed@webrtc.org Android: Add field trial for Intel HW Vp8 encoder
2017-01-10 nisse@webrtc.org Make OverheadObserver::OnOverheadChanged count RTP headers only
2017-01-10 magjed@webrtc.org Android: Wrap webrtc::field_trial::FindFullName in Java
2017-01-10 nisse@webrtc.org Move VideoFrame and related declarations to webrtc/api/video.
2017-01-10 brandtr@webrtc.org Reduce FlexFEC logging severity in two places.
2017-01-10 philipel@webrtc.org EndToEndTest.ReceivesAndRetransmitsNack now handles reordering.
2017-01-10 brandtr@webrtc.org Reorder assignments in WebRtcVideoChannel2::ConfigureReceiverRtp to match definition in VideoReceiveStream::Config.
2017-01-10 sakal@webrtc.org Add a check for CameraCapturer being initialized before calling startCapture.
2017-01-10 johan@webrtc.org Reland of Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.
2017-01-10 nisse@webrtc.org Drop unneeded includes of base/stream.h.
2017-01-10 magjed@webrtc.org Final removal of webrtc/api/android
2017-01-10 ivoc@webrtc.org Fix for left shift of potentially negative value.
2017-01-10 kthelgason@webrtc.org Update bitrate adjustment with true buffer used size.
2017-01-10 kthelgason@webrtc.org Disable some filesystem tests that don't make sense on iOS.
2017-01-10 kwiberg@webrtc.org Add advice about Optional function arguments
2017-01-10 sprang@webrtc.org Revert of Fix BitrateProber to match the requested bitrate more precisely (patchset #4 id:60001 of https://codereview.webrtc.org/2613543003/ )
2017-01-10 kwiberg@webrtc.org Move FilePlayer and FileRecorder to Voice Engine
2017-01-09 deadbeef@webrtc.org Merge RTCConfiguration with RTCMediaConstraints in Java/Obj-C wrappers.
2017-01-09 deadbeef@webrtc.org Reland of: Separating SCTP code from BaseChannel/MediaChannel.
2017-01-09 sergeyu@chromium.org Fix BitrateProber to match the requested bitrate more precisely
2017-01-09 noahric@chromium.org Ensure internal_source is false for internal encoders.
2017-01-09 hnsl@webrtc.org Add disabled certificate check support to IceServer PeerConnection API.
2017-01-09 ivoc@webrtc.org Fix for left-shift of potentially negative values in NetEq.
2017-01-09 nisse@webrtc.org Delete final remnants of the buzz namespace.
2017-01-09 palmkvist@webrtc.org Lower bad call logging severity
2017-01-09 magjed@webrtc.org AVFoundationVideoCapturer: Fix apply_rotation() logic
2017-01-09 brandtr@webrtc.org Temporarily remove SSRC DCHECK in RTPSender::SendToNetwork.
2017-01-09 magjed@webrtc.org Make magjed@ owner of webrtc/sdk/objc
2017-01-09 stefan@webrtc.org Clean up ramp-up tests and make sure they all pass.
2017-01-09 mbonadei@webrtc.org Reland of Fixing package-boundary violation with srjar_deps (patchset #1 id:1 of https://codereview.webrtc.org/2617533005/ )
2017-01-09 kthelgason@webrtc.org Remove duplicate implementations of string conversion methods.
2017-01-09 kthelgason@webrtc.org Reland of Delete unused code from systeminfo. (patchset #1 id:1 of https://codereview.webrtc.org/2584563004/ )

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2626163003
Cr-Commit-Position: refs/heads/master@{#443193}

R=jochen@chromium.org
BUG=chromium:575167

Review-Url: https://codereview.chromium.org/2627923002
Cr-Commit-Position: refs/heads/master@{#443192}

Only supports ARM for now.

BUG=620034

Review-Url: https://codereview.chromium.org/2622133004
Cr-Commit-Position: refs/heads/master@{#443191}