- 22 Aug, 2019 40 commits
-
-
Maksim Sisov authored
The content_unittests have been running by the linux-ozone-rel bot for a couple of weeks since 06 of August without any failures. Thus, remove the experiment percentage. R=sky@chromium.org Bug: 700309 Change-Id: Ib9c7e4f29c8bebc808b23bfb8c10358816e7d793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764139Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#689512}
-
Mei Liang authored
This CL updates tab strip when dragging the current tab out of group if the tab strip is visible. Aka when static tab is shown. Change-Id: I10f0f332a3915105e4281d78762aa265d9d6493b Bug: 991251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747248Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#689511}
-
Vasilii Sukhanov authored
This change adds a simple fuzzer for CipherEncrypt() used in the Leak Detection feature. Bug: 986298 Change-Id: I4878b1bf04a0edc4341c7c2997e443207120d6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763756 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#689510}
-
Brian Sheedy authored
Changes the VR browser tests that click on suggestions to ensure navigation works to click on the bottom suggestion instead of the middle one. This is because either the top or middle suggestion can be the "search on the web" suggestion depending on if the OmniboxGroupSuggestionsBySearchVsUrl feature is enabled or not. Bug: 995943 Change-Id: Ic1ee49f8ef95a6b13c65117065bc08c882bbb615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764756 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#689509}
-
Bo Liu authored
Values from manual testing. Bug: 996227 Change-Id: I854f1690f039842c21d97e9324c581156cfa7939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761358Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689508}
-
Lowell Manners authored
With this CL, we now call BackForwardCache::RestoreDocument at the end of the navigation just before committing, instead of at the start of the navigation. This shrinks the window of time where an eviction can occur after the document has been removed from the cache, but before it has been committed. Before this patch, if an eviction arrived after the navigation started, the behavior was undefined. With this patch, that case is now handled by canceling the navigation. In a follow-up CL, it will be handled by restarting the same session history navigation. This CL also has the (pleasant) side effect of fixing an issue where throttling wasn't handled correctly in the case of a BackForwardCache restore, (test added in this CL). Change-Id: I65a1600cef04f2e10f0d28a5df750b26c85e917a Bug: 976697,995316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760220Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#689507}
-
Mike Wasserman authored
Update the strings in accordance with the latest UX specs. Remove bold emphasis in omnibox usage bubbles (keep it for prompts). Update screenshots and sha1 files. Consolidate IDS_NATIVE_FILE_SYSTEM_WRITE_PERMISSION_*_TITLE Remove now unused |NativeFileSystemPermissionView::is_directory_|. See updated screenshots in the associated bugs. Bug: 995897, 996336 Change-Id: I0063b80e2a0fa4fe1442b90029011016d2d808b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764267Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#689506}
-
Sigurdur Asgeirsson authored
Bug: 969764 Change-Id: I78592474edd3ee7c69700940baa148349b4c9830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764967Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689505}
-
Bill Budge authored
- Changes cached metadata callback signatures to take mojo_base::BigBuffer instead of base::span or raw [ptr, len] parameters. - Transfers metadata buffers with as few copies as possible. - Refactors blink::CachedMetadata to be able to have a BigBuffer as the backing store, in addition to a Vector. This allows us to avoid the final copy when creating CachedMetadata. BUG: chromium:992991 Change-Id: I567c51028dfe754fa9403614f466ca202e156570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759008 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#689504}
-
Vasiliy Telezhnikov authored
This CL adds CookieChangeObserver to wait before cookies get propagated to main thread where test checks them. Bug: 993840 Change-Id: I1e05c3af1f319f73c611cea4e804a80cab7d3e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754463 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#689503}
-
Joe Mason authored
Also fixes a bug where the --scan-locations flag couldn't add back ProgramFiles or CLSID once they were removed from the list. R=proberge Bug: 996730 Change-Id: I3661b2c46b3ab1ee9c4f69351fc263fbbf2ad712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764964Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#689502}
-
Rafał Godlewski authored
Bug: 986317 Change-Id: Icedc2ec0507dc7f266661fd5fb25584237adb24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763681 Auto-Submit: Rafał Godlewski <rgod@google.com> Reviewed-by:
-
Stefan Zager authored
This patch made calls to RenderThrottlingStatusChanged more frequent: https://chromium-review.googlesource.com/c/chromium/src/+/1758224 As a result, that method would sometimes get called even before LocalDOMWindow::InstallNewDocument, which would cause the following calls to crash (because they query the document): frame_scheduler->SetCrossOrigin(frame_->IsCrossOriginSubframe()); frame_scheduler->TraceUrlChange(frame_->GetDocument()->Url().GetString()); It was always hacky to update these items of scheduler state from RenderThrottlingStatusChanged. This patch adds the method VisibilityForThrottlingChanged, which propagates just the frame visibility state to the scheduler. The calls to SetCrossOrigin and TraceUrlChange now happen only when those things actually change. BUG=995724,995648 R=alexclarke@chromium.org Change-Id: I8a46391c6a371cf4b8b5eca31558d05c7cedae67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762443Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#689500}
-
Jinfeng Ma authored
Some HTML elements may have a resizer which can be restyled by using CSS pseudo element: -webkit-resizer, for example: 1. <textarea>; 2. <div> with overflow: hidden and resize: both; The resizer of these elements can be displayed independently of the scrollbar. So the custom resizer's construction, style updating, layout and paint offset translation should be considered even if the scrollbar doesn't exist. Bug: 863748 Change-Id: Ie097284fcf8f896c4a394548d0b553475d5f26b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757262 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689499}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e9bc22c848cc..fa6228187eab Created with: gclient setdep -r src-internal@fa6228187eab The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ib1bd05942751df169fa4901e4e4de8d9aeea41b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764865Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689498}
-
rajendrant authored
Lazyload of iframes and images is disabled when the current navigation is a reload navigation. This is controlled by a finch param to be able to turn off or on when needed. Bug: 991038 Change-Id: I43c107258e36f7d210044bee952ce7eb090aa8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743130Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#689497}
-
Nina Satragno authored
This patch adds the `removeCredential` command to the WebAuthn DevTools Domain. This allows removing a single credential identified by ID. This is one in a series of patches intended to create a Testing API for WebAuthn, for use in Web Platform Tests and by external webauthn tests. For an overview of overall design, please see https://docs.google.com/document/d/1bp2cMgjm2HSpvL9-WsJoIQMsBi1oKGQY6CvWD-9WmIQ/edit?usp=sharing Bug: 922572 Change-Id: Idc40416a7be04165729ad03f2902716c922e1e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764517 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#689496}
-
Martin Robinson authored
This is useful for tracking changes to the AuraLinux implementation of accessibility. Bug: None Change-Id: I566de1638b5e26bb8d15d4aaf4159cd57ca008ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757929 Auto-Submit: Martin Robinson <mrobinson@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Marc Treib authored
TBR=sunnyps@chromium.org Bug: 995669 Change-Id: Ia5ac16fd242a5e50a6ce6ad99d811000077076d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764147Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#689494}
-
Maks Orlovich authored
OnWriteResponseInfoToEntryComplete --- used in particular from DoCacheToggleUnusedSincePrefetchComplete and DoCacheUpdateStaleWhileRevalidateTimeoutComplete --- can close the entry in case of a cache write error, and the states the follow these --- STATE_CACHE_DISPATCH_VALIDATION and STATE_SETUP_ENTRY_FOR_READ did not handle that. (DoCacheWriteUpdatedResponseComplete and DoCacheWriteResponseComplete also use this method, but states afterwards can deal with null entry_). Bug: 947065 Change-Id: I990cf49b4840a818e9c2cb3143d8d78a8d3c14a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752073 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#689493}
-
Owen Min authored
In ChromeSignedinProfile, using *_gaia_id instead of gaiaid. Bug: 956237 Change-Id: Ia92d7c9073c1ee6caa446dd5f21da1ba06283b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762449Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#689492}
-
Corentin Wallez authored
Also contains the implementation of GPUBindGroupLayoutBinding.textureComponentType that was newly introduced in Dawn. https://dawn.googlesource.com/dawn.git/+log/ae2b9f4720a7..f463a2029142 $ git log ae2b9f472..f463a2029 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 cwallez Add BGLBinding::textureComponentType Created with: roll-dep src/third_party/dawn Change-Id: Ia40de88d6b2dda7a32a265b3fabfb1b0ae9b906e Bug: dawn:128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765471 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#689491}
-
Philip Rogers authored
This is a speculative revert in order to either confirm or eliminate it as a source for a hard to track down persistent performance regression. This reverts r679216 (commit 629180ff). Tbr: bokan@chromium.org Bug: 993476, 785940 Change-Id: I3585b8bc048509343af495cdb2247131e1b05527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763754 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#689490}
-
Olivier Li authored
Bug: 969139 Change-Id: I26fe6a4d739797ca8b5498fd3f7c1d54b0867820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762484 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#689489}
-
Clemens Arbesser authored
This CL adds a new optional section to the payment request: Login details for <domain>. The intent is to let users choose from a list of login options such as 'guest checkout' and 'username@example.com'. Currently, the list may contain custom options (like 'guest checkout') as well as login details stored in the Chrome password manager. The chosen login option is returned to the server. In the case of Chrome PWM logins, the chosen login details are stored in client memory. As a special case, if there is no meaningful choice to make in the login section, the section is not shown and the choice is made implicitly. This CL only adds the required changes to query and store the login details in the client. There will be a separate CL to read the login details from client memory and autofill the username/password fields. Screenshots of the new feature: - Collapsed: https://screenshot.googleplex.com/uUrpn6jatko.png - Expanded: https://screenshot.googleplex.com/RKNxrjLvMcJ.png Bug: b/128833341 Change-Id: I204a471f67a3f8856cead71080dd5184846c2090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713559 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#689488}
-
Nicolas Ouellet-payeur authored
The network annotation auditor is failing on waterfall with an unknown reason on linux-annotator-rel, when using the python script [1]. This CL adds logging to help troubleshoot the issue. [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8904561230202338112/+/steps/test_traffic_annotation_auditor/0/stdout Change-Id: I50ba290eae8c9ad50320c85e3e4c591636b8ff9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761359 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#689487}
-
Alex Ilin authored
This reverts commit 28b4dfc2. Reason for revert: this CL causes failures on Android M bots https://crbug.com/996720 Original change's description: > [Dark] Update style for incognito grid tab switcher > > This CL modifies incognito GTS to use the same color palette as Dark > mode. In addition, this CLs add darker theme support for all tab group > related UIs in incognito, except for TabSelectionEditor. > > Change-Id: Ic1517867cf90ac0550fd1bf15e91cd19c4231eab > Bug: 960891 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745619 > Commit-Queue: Mei Liang <meiliang@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689339} TBR=yusufo@chromium.org,twellington@chromium.org,wychen@chromium.org,meiliang@chromium.org Change-Id: I9be913dc744091b3b7fbd3cf04f019926df89985 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 960891, 996720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765708Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#689486}
-
Christian Biesinger authored
And make ChildUnstretchedLogical{Width,Height} handle the case where an override size is set (by clearing and re-setting). The problem with clearing the override size, but not doing layout, is that we may later do a simplified layout which will then lay out as shrink-to-fit, which is undesired. Bug: 992010 Change-Id: I18d3ae66f62cbdc9cdcf76810dc0eff6be915af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758940 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
David Bokan authored
We missed the RootScroller case when hooking up the IsAffectedByOuterViewportBoundsDelta bit for BlinkGenPropertyTrees. The fix here is simple, just answer true if we're inside of the global root scroller (i.e. scrolling our iframe causes the URL bar to hide). Bug: 995463 Change-Id: I473b1af3a475fb783844c9f1bdde0d3d1b532329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764610Reviewed-by:
-
Kevin Bailey authored
The selected suggestion index can be -1, going off the beginning of the array. We need to guard against that with a check. (Also update a flag description.) Bug: 995935, 996515, 996526, 996571 Change-Id: I425a04734a5c6fa6af9dd25bd24741f7af6a8643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764802Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#689483}
-
Alex Moshchuk authored
This CL extends expiration for the following features based on the current timeline for launching Android site isolation: - enable-site-isolation-for-password-sites - site-isolation-trial-opt-out It also marks the following flags as never-expiring, since they provide useful ways to extend or strengthen existing site isolation modes: - isolate-origins - strict-origin-isolation Change-Id: Id9bfb24ecc9a2dc193926e5d41d239cb096c5e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762576Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#689482}
-
Sasha McIntosh authored
Bug: 988538 Change-Id: I2093b962f71af8223f738e3d275075c3d0bf715a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732747 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#689481}
-
Justin Cohen authored
This reverts commit 774d23c5. Reason for revert: Moved webState timeout to correct test. Original change's description: > Revert "[ios] Disable failing tests for Xcode 11 beta 6." > > This reverts commit 0ba4c00b. > > Reason for revert: webState timeout is in the wrong place, fixing via > revert. > > Original change's description: > > [ios] Disable failing tests for Xcode 11 beta 6. > > > > Increases a webState timeout, disables a request desktop and two > > share button tests. > > > > Bug: 995797, 996541, 990186, 996544 > > Change-Id: I07c8dd52d0bb13c6c805ef35b2c727ec3deb84bb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762331 > > Commit-Queue: Justin Cohen <justincohen@chromium.org> > > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > > Auto-Submit: Justin Cohen <justincohen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#689326} > > TBR=rohitrao@chromium.org,justincohen@chromium.org > > Change-Id: I0fb517a23c012fae88df440adac061901d1c8cdc > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 995797, 996541, 990186, 996544 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765494 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689476} TBR=rohitrao@chromium.org,justincohen@chromium.org Change-Id: I1e0b311ed2533e8311fe86ba2c290b6794c02930 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995797, 996541, 990186, 996544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763237Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689480}
-
Yann Dago authored
This reverts commit 16579581. Reason for revert: Offline discussions happened around the repercussions of this change. Silently changing a browser's behavior might not be as desirable as expected. Reverting this until a consensus is reached or a another solution found. Original change's description: > Policy: Allow setting enterprise defaults for all platforms > > Transfer the responsibility to set default policies into PolicyService. > The decision is made using a EnterpriseUsersDefaultDelegate injected > into the PolicyService. > > The ProfilePolicyConnector acts as EnterpriseUsersDefaultDelegate. > > For Chrome OS, the resulting behavior is not changed - enterprise > user defaults are set if the profile is managed. > > For android and Desktop platforms enterprise user defaults are set if > the profile managed. > > Bug: 980132 > Change-Id: I134125ed0dbe22149eb36459b45268244afc5954 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706575 > Commit-Queue: Yann Dago <ydago@chromium.org> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687241} TBR=mmenke@chromium.org,pmarko@chromium.org,ydago@chromium.org Bug: 980132 Change-Id: I6334e4d6a7eeda7fef87a4ea6d6ecb820a16eb92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764468Reviewed-by:
-
Matt Falkenhagen authored
The thread ServiceWorkerContextCore lives on (the "core thread") will move from the IO thread to the UI thread. This CL makes DevToolsBackgroundServicesContext aware of the core thread instead of assuming the IO thread. Bug: 824858 Change-Id: I1c58de5e2dc6d262fe6d6f5c375956aa54da77c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765096Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#689478}
-
Peter Wen authored
Add myself to OWNERS for //third_party/google_android_play_core. Built locally @264816199 and uploaded to CIPD. Updated ModuleInstaller to use the new SplitCompat API. Add new play core activity to expected manifest file. Bug: 996212 Change-Id: I0aba37897048cc554330eb933b2687d37e9343e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764804 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#689477}
-
Justin Cohen authored
This reverts commit 0ba4c00b. Reason for revert: webState timeout is in the wrong place, fixing via revert. Original change's description: > [ios] Disable failing tests for Xcode 11 beta 6. > > Increases a webState timeout, disables a request desktop and two > share button tests. > > Bug: 995797, 996541, 990186, 996544 > Change-Id: I07c8dd52d0bb13c6c805ef35b2c727ec3deb84bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762331 > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Auto-Submit: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689326} TBR=rohitrao@chromium.org,justincohen@chromium.org Change-Id: I0fb517a23c012fae88df440adac061901d1c8cdc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995797, 996541, 990186, 996544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765494Reviewed-by:
-
Emil A Eklund authored
This is a speculative revert in order to either confirm or eliminate it as a source for a hard to track down persistent performance regression. This reverts r679183 (commit 6b846d36). Bug: 993476 Tbr: pdr@chromium.org Change-Id: I37566d32fb0853590e72299fdc0f281c712bf027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764195 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
kylechar authored
ContextProvider notifies observers on context loss that the context is no longer usable. These observers typically hold a scoped_refptr<ContextProvider> and could drop their reference immediately. This could result in the ContextProvider being destroyed before OnContextLoss() has finished executing and result in a use-after-free error. Ensure this use-after-free isn't possible by acquiring a scoped_refptr before notifying observers. Bug: 994430 Change-Id: I5e0d6c99b0a42bbfc3dfca28af311df2b0f33831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764803Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#689474}
-
Artem Titarenko authored
Bug: webrtc:10899 Change-Id: I022ac114957b596e76172ca5de5b925d6a937c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757941Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Artem Titarenko <artit@chromium.org> Cr-Commit-Position: refs/heads/master@{#689473}
-
