- 02 Feb, 2019 21 commits
-
-
Takuto Ikuta authored
This CL introduce mojom-forward.h and mojom-import-headers.h mojo-forward.h is introduced for forward enum/class/struct declaration with some using aliases. I replaced some mojom.h includes with mojom-foward.h in mojom.h except files using inlined struct. mojom-import-headers.h is used to include all mojom.h of all (indirectly) imported header for mojo's cc files. Bug: 922875 Change-Id: I386528b1059516dc1d52b18a4778a79a2289c063 Reviewed-on: https://chromium-review.googlesource.com/c/1438975 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#628544}
-
bsheedy authored
Makes the WebXR perf tests use the forked samples in third_party instead of the older version pulled in via DEPS. Also makes sure that the "Enter XR" button is present before attempting to click on it since it can now appear after page load is complete. Bug: 923149 Change-Id: I225704688f827e3b8863bf064f6bfa9105c7d0c5 Reviewed-on: https://chromium-review.googlesource.com/c/1450429 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#628543}
-
Collin Baker authored
Previously, if an early return was hit in SendDamagedRects(), the layer's mask's damaged rects would not be sent. This moves the SendDamagedRects() call on the layer mask to above the early returns. Change-Id: Ic1ef2e96085140e57a02867bb680f68b8ee2f9bc Reviewed-on: https://chromium-review.googlesource.com/c/1450707Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#628542}
-
Peter Kasting authored
This is simpler and less error-prone, and will allow moving the app menu observer access point to the app menu button (in a future CL). Bug: none Change-Id: I17eaf8d3374ae3d8bf1b078631f93c8a6c2e88f7 Reviewed-on: https://chromium-review.googlesource.com/c/1447323 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#628541}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d5b02673..2205f634 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I29f2d600ffe8471bd67443f370dd8a82f142ea85 Reviewed-on: https://chromium-review.googlesource.com/c/1450705Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628540}
-
Kevin Strohbehn authored
Bug: 908621, 916724 Change-Id: Ib08120d4f98081d4c5317a481e282c0c06d25e98 Reviewed-on: https://chromium-review.googlesource.com/c/1449045 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#628539}
-
Anne Lim authored
This is a reland (with modifications to accommodate recent changes) of https://chromium-review.googlesource.com/c/chromium/src/+/1316666 The V2 of StrikeDatabase is now used. Bug: 884817 Change-Id: I13cf973bef9d0f48f218e8e76ad30e365e3617ec Reviewed-on: https://chromium-review.googlesource.com/c/1446665 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#628538}
-
Eugene But authored
GetPendingItem can return null inside webView:didCommitNavigation: This is due to crbug.com/925304, which allows to discard pending items by another navigations prematurely. If pending item is null, it means that Navigation Manager will not commit that item and WebStateObservers can crash because they expect to have at least one committed item. This CL leaves navigation as "uncommitted" if there was no pending item inside webView:didCommitNavigation: Original CL: https://chromium-review.googlesource.com/c/1448683 Bug: 925304 Change-Id: I7852da807d183e87d1fd029d75ed63cde2287d7b Reviewed-on: https://chromium-review.googlesource.com/c/1450300 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#628537}
-
dpapad authored
Replace i18n-values with $i18n{} mechanism. Also remove unnecessary tabs.css dependency. Bug: 677338 Change-Id: I6dbddf8820b10d2c27441d51ab119bcbc7f04ec7 Reviewed-on: https://chromium-review.googlesource.com/c/1450019 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:Joshua Bell <jsbell@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#628536}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/da2bdf0382f7..45c7f2def3e9 git log da2bdf0382f7..45c7f2def3e9 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 bmgordon@chromium.org cros_flash.py: Only require chroot for ssh destination 2019-02-01 cjmcdonald@chromium.org goma_util: Set default goma PLATFORM to 'chromeos' and force update. 2019-02-01 nednguyen@google.com portage_util: Add FindEbuildsForPackages that find ebuilds for many packages 2019-02-01 saklein@chromium.org cros lint: skip generated protobuf files 2019-02-01 lamontjones@chromium.org signing: finish SignImage 2019-02-01 lamontjones@chromium.org kernel_cmdline: Allow searching commandline arg list by string (arg). 2019-02-01 evanhernandez@chromium.org cros_branch_unittest: Add functional test skeleton. 2019-02-01 evanhernandez@chromium.org repo_util: Allow passing --repo_branch to `repo init`. 2019-02-01 evanhernandez@chromium.org cros_branch_unittest: Reinforce test data. 2019-02-01 lannm@chromium.org chromeos_config: Increase full builder timeout to 6 hours Created with: gclient setdep -r src/third_party/chromite@45c7f2def3e9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I33aeba9164191720766fdce623e508f63ef79915 Reviewed-on: https://chromium-review.googlesource.com/c/1450733Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628535}
-
John Lee authored
This is to support being able to set a NTP background without requiring a network call to load collections and album photos. Bug: 924176 Change-Id: Ie19043170e144fbf03e4b7f9dbcffcf106a2107b Reviewed-on: https://chromium-review.googlesource.com/c/1449103 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#628534}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4fa143d003ed..b4138ddf946e Created with: gclient setdep -r src-internal@b4138ddf946e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9d6ebfbab716cd27b65753ecea193cea6db993c5 Reviewed-on: https://chromium-review.googlesource.com/c/1450637Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628533}
-
Peter Kasting authored
This is used to plumb information to the menu controller, which sets alerts on items during OpenMenuImpl(). This is overly complex. The functionality is only used by the app menu, and we can tell it to set these alerts on items as they're added. This allows setting the alert state during menu construction rather than when the menu is run. This will make it possible (in a future CL) to simplify how the reopen tab promo code observes the app menu button. Bug: none Change-Id: I45d7edfabcde3ce2b01f7b50d00d7568e9d41cb1 Reviewed-on: https://chromium-review.googlesource.com/c/1447269 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Kristi Park authored
Remove the now defunct configData.isDarkModeEnabled references. Bug: 927955 Change-Id: Iba9c557eba265d1fa5f5eeaeeff5a2382bfbc26e Reviewed-on: https://chromium-review.googlesource.com/c/1450756 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id64560e08be4ec8e4a4f36bdc57e39777afb353d Reviewed-on: https://chromium-review.googlesource.com/c/1450636Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/debaacab10b5..cd610c9a9dbc git log debaacab10b5..cd610c9a9dbc --date=short --no-merges --format='%ad %ae %s' 2019-02-01 sugoi@google.com CommandPool reset and trim Created with: gclient setdep -r src/third_party/swiftshader@cd610c9a9dbc The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ib6d92b513ff33881aff02e27b1553fae444b9bf4 Reviewed-on: https://chromium-review.googlesource.com/c/1450635Reviewed-by:
-
Joel Einbinder authored
This reverts commit 9a60a25d. Reason for revert: This broke a lot of focus related logic in the Elements panel Bug: 920518 Original change's description: > DevTools: Fix focus when selecting to the left of treeitems > > The mousedown listener in ElementsTreeOutline was moving focus, but > not consuming the event. The event then propagated to the treeoutline > element itself, which stole focus. > > Change-Id: I2de2001175f4029cd94880297c460ff4c90b845a > Reviewed-on: https://chromium-review.googlesource.com/c/1387688 > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Commit-Queue: Joel Einbinder <einbinder@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618423} TBR=pfeldman@chromium.org,einbinder@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I1407655b9a6ca03a2f110f87b7b9d2f98795ef53 Reviewed-on: https://chromium-review.googlesource.com/c/1450512Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#628528}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. TBR=battre@chromium.org R=battre@chromium.org Bug: 925652 Change-Id: Ibe9c02c27b69efa50cba51922b498bed6a411d5e Reviewed-on: https://chromium-review.googlesource.com/c/1438378Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#628527}
-
Stephen Nusko authored
This fixes the roll from the fix inside prefetto code for crbug/839074. This allows us to remove the code referenced there since perfetto now correctly uses the task runner as required. Bug: crbug/839074 Change-Id: I44c3f9413e6b49a933db140ff1a00d5dc9c1e009 Reviewed-on: https://chromium-review.googlesource.com/c/1449675Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#628526}
-
Sidney San Martín authored
Bug: 871870 Change-Id: Ia5d7ac9082566bf201ac059987651beb03ce6108 Reviewed-on: https://chromium-review.googlesource.com/c/1450421 Auto-Submit: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#628525}
-
Wez authored
Update the functions we register as FIDL error handlers to use : - ZX_LOG(FATAL, status) where we never expect to lose connectivity, e.g. for connections to system services such as the Netstack. We typically follow these with an indication of what disconnected, e.g: ZX_LOG(FATAL, status) << " Netstack disconnected."; - ZX_LOG_IF(FATAL, status != ZX_ERR_PEER_CLOSED, status) where we are providing service to a single peer that may disconnect from us at any time, where other status values are unexpected. - ZX_LOG(ERROR, status) where we never expect to lose connectivity, but are serving multiple peers, so must not simply crash the process. - ZX_LOG_IF(ERROR, status != ZX_ERR_PEER_CLOSED, status) where we are providing service to multiple peers that we expect may disconnect, to verify that they do so gracefully. We also update FIDL error handlers in some test suites: - EXPECT_EQ(status, ZX_ERR_PEER_CLOSED) where the test actively expects that the FIDL channel will be disconnected gracefully. - ZX_LOG(ERROR, status) where the test does not expect FIDL errors. Bug: 927400 Change-Id: I10fef90778e58f2aedadb806f857da00aace96aa Reviewed-on: https://chromium-review.googlesource.com/c/1448796 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#628524}
-
- 01 Feb, 2019 19 commits
-
-
David Bienvenu authored
Bug: 668718 Change-Id: I27f8fee576dafdcc9b30e25be4c148d310d75605 Reviewed-on: https://chromium-review.googlesource.com/c/1444705Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#628523}
-
Wez authored
Remove a couple of directory-level OWNERS files in favour of top-level //ui/OWNERS rules for all *fuchsia* and *scenic* files &* directories. Change-Id: Ie2b20f5c272cff9e75859b62a03fc4a13c889a19 Reviewed-on: https://chromium-review.googlesource.com/c/1450702 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#628522}
-
Victor Costan authored
test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/extensions/api/enterprise_platform_keys. Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=drcrash@chromium.org Bug: 925652 Change-Id: I30ea9d065fa7f7e8c3ad4ffb44ab06105cda2ccd Reviewed-on: https://chromium-review.googlesource.com/c/1438380Reviewed-by:
Yves Arrouye <drcrash@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#628521}
-
Victor Costan authored
test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/extensions/api/enterprise_platform_keys_private. Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=drcrash@chromium.org Bug: 925652 Change-Id: I526eef912697ba8dad512de35f88cf841950c068 Reviewed-on: https://chromium-review.googlesource.com/c/1438370Reviewed-by:
-
Tom Anderson authored
BUG=None R=thakis CC=rsesek Change-Id: Ia94b81592164307aa55a910953909b0b25a82b37 Reviewed-on: https://chromium-review.googlesource.com/c/1444136 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
There is no use of SigninFoo class in local_card_migration_browsertest.cc. So they are unnecessary now. This CL removes the includes. Bug: 927244 Change-Id: If20a6806a63123165a865e83c3cf86188b71f2bd Reviewed-on: https://chromium-review.googlesource.com/c/1448010Reviewed-by:
-
Wez authored
Remove the out-of-date comment regarding Watchers outliving the associated MessagePumpLibevent, and add a Debug mode check for StopWatchingFileDescriptor failing during Watcher teardown, since that usually indicates a coding error somewhere. Also fixes incorrect descriptor/watcher teardown ordering in the AddressTrackerLinux and ServiceProcessState for POSIX. Bug: 741188 Change-Id: I3732c61bfb81df89f0011ad8bfff93d7a08c6fc5 Reviewed-on: https://chromium-review.googlesource.com/c/575108 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Nick Diego Yamane authored
As of [1] XkbKeyboardLayoutEngine has been hardcoded to always set num lock mask. That's a ChromeOS-specific requirement, so this patch guard those code under OS_CHROMEOS build flag. This has been causing an issue in ozone/wayland builds, for example, when using keyboards Neo layout (e.g: de-neo). This patch fixes it. [1] https://crrev.com/834373002 R=rjkroege@chromium.org Bug: 921947 Change-Id: I0eadae3169ff9a8442714cd7f41c75b1c623447b Reviewed-on: https://chromium-review.googlesource.com/c/1450338Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#628516}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8cd8f2f71e22..da2bdf0382f7 git log 8cd8f2f71e22..da2bdf0382f7 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@da2bdf0382f7 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie412d4b53fbb12d46bd2ba8a01374caad51488a2 Reviewed-on: https://chromium-review.googlesource.com/c/1450731Reviewed-by:
-
Takuto Ikuta authored
This is preparation CL to use forward declaration only header in mojo's generated code. If we include forward declaration only header in mojo's generated code, we need to include mojo header files in some places where definition is necessary. master CL is in https://chromium-review.googlesource.com/c/chromium/src/+/1438975 This CL was uploaded by git cl split. R=hidehiko@chromium.org CC: rockot@google.com Bug: 922875 Change-Id: I19d473f728ed83b62c9111f62a4fbb94b7077d77 Reviewed-on: https://chromium-review.googlesource.com/c/1446973Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#628514}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/6c1b376e1d502eff365028fe054115f1b46d19b5..1a51a5b4a6bdf7ee11b443f21f08dc2ba2de9815 Bug: none Change-Id: I41e423f917c36d7bc4d5a8eac1f1f17ba56592a4 Reviewed-on: https://chromium-review.googlesource.com/c/1446837Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#628513}
-
Marijn Kruisselbrink authored
We never pass a null ChromeAppCacheService to AppCacheDispatcherHost so don't bother trying to support that. Bug: None Change-Id: Ic8afd00a9ae405c31ca3bcdee8e87ba0beb4a9bd Reviewed-on: https://chromium-review.googlesource.com/c/1450532 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Eugene But authored
The flag was calculated inside registerLoadRequestForURL: based on heuristics. These calculations were often wrong, but they were later fixed up by registerLoadRequestForURL: callers. This CL passes 'is renderer initiated' flag inside registerLoadRequestForURL: call so NavigationContext is always created with correct value. Callers almost always know the value of the flag with the exception of certain NativeContent navigation where value of the flag is not important. This CL does not have tests, because existing tests cover all known cases. Bug: None Change-Id: I0d85b8d91b066a2a8b2788a9618e58fd96fc82e9 Reviewed-on: https://chromium-review.googlesource.com/c/1446797 Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#628511}
-
Hector Carmona authored
This is necessary to have an enterprise check for Navi onboarding. Bug: 924274 Change-Id: I3168b6fd7ecf6707f7987e5453595913926c19cf Reviewed-on: https://chromium-review.googlesource.com/c/1428599 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Auto-Submit: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#628510}
-
bsheedy authored
Adds in retries to the VR fling scrolling test to help combat flakiness on older/slower devices. The previous version of the test was stable on newer devices such as the Pixel 2, but was flaking on the Pixel XLs used by the bots due to scroll jank. Bug: 923093 Change-Id: I218b09c4ae827149541eda0c735a8121b16dd970 Reviewed-on: https://chromium-review.googlesource.com/c/1448530Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#628509}
-
Martin Kreichgauer authored
Cryptotoken used to tolerate challenges and key handles encoded in either regular base64 or base64url, despite the spec only allowing base64url. With the WebAuthenticationProxyCryptotoken feature enabled, this is no longer the case: WebAuthn takes challenges and key handles as raw byte inputs, and re-encodes them to base64url prior to signing. Until now, if cryptotoken failed to base64url-decode a challenge for keyHandle before sending it to WebAuthn, it would send an empty byte sequence instead. Hence, if a non-compliant passed a challenge encoded in regular base64, it would subsequently receive a response, but the challenge field in the response would be empty and signature would be over the empty challenge. This change makes the failure to decode more explicit. If a challenge (or keyHandle) fails to decode, cryptotoken will not forward the request. Rather it will return a BAD_REQUEST error with a descriptive error message. Bug: 925738 Change-Id: I7e1d0bfca55765ccdfaf7b9762c8b79352fb2856 Reviewed-on: https://chromium-review.googlesource.com/c/1450400 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#628508}
-
Khushal authored
The test was disabled because it was flaky on TSAN bots. Unfortunately the logs from these flakes are not available anymore because the test was disabled a while ago. And the failure could not be reproduced locally. Reland the test to verify if the failure on the bots still exists. R=enne@chromium.org Bug: 851231 Change-Id: I5ae4d37f10a3173f1d3b452ab50f229f01dd748f Reviewed-on: https://chromium-review.googlesource.com/c/1450692 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#628507}
-
kylechar authored
InProcessCommandBuffer wasn't checking if exist_on_context_loss GPU workaround was set on context loss. Implement a similar check to the existing one in GpuChannelManager. To reduce code duplication push more of the logic around exiting on context loss up into GpuServiceImpl. Both InProcessCommandBuffer and GpuChannelManager can use the same logic this way through GpuChannelManagerDelegate (which should be renamed). A related change for OOP-D display compositor context creation is to not try to create a context if we are already exiting the process. This matches the logic in GpuChannel. We have to check on the viz compositor thread before starting context creation and also on the GPU thread when starting GPU thread initialization. Bug: 924148 Change-Id: I6eeb016c063063ef26ccdcaa7ad9d2ae3badcdc7 Reviewed-on: https://chromium-review.googlesource.com/c/1448518 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#628506}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e13cf694d42b..33cc9c60892a git log e13cf694d42b..33cc9c60892a --date=short --no-merges --format='%ad %ae %s' 2019-02-01 tsepez@chromium.org Add --jitless to recommended v8 flags. Created with: gclient setdep -r src/third_party/pdfium@33cc9c60892a The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5a61dba1c3c5f37b3d46c8c6a43e5b48a87e438b Reviewed-on: https://chromium-review.googlesource.com/c/1450633Reviewed-by:
-
