GitLab

This reverts commit 3984e14d.

Reason for revert: CrostiniManagerRestartTest.RestartMultipleThenUninstall crashing on https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg

first failure https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/18909

crash log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878996586056266096/+/steps/unit_tests/0/logs/Deterministic_failure:_CrostiniManagerRestartTest.RestartMultipleThenUninstall__status_CRASH_/0

Original change's description:
> Refactor crostini use CrostiniId rather than vm_name, container_name
> 
> Refactor only change.
> 
> Change places where vm_name and container_name are being used in a
> function to use ContainerId, and particularly ContainerId::GetDefault.
> 
> TBR=haraken@chromium.org
> 
> Bug: 846190
> Change-Id: Iaa545c750aa979cceff74c87e89ef4bd21867f4f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220106
> Commit-Queue: Joel Hockey <joelhockey@chromium.org>
> Commit-Queue: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Julian Watson <juwa@google.com>
> Auto-Submit: Joel Hockey <joelhockey@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#773035}

TBR=haraken@chromium.org,joelhockey@chromium.org,juwa@google.com

Change-Id: I8bc3d9e68df869fc19c04381d4d013fe6ef4f7b3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 846190
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218313Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773085}

TBR=benmason@chromium.org

Change-Id: Id65b80afd9334e1e6f60dbed6701eae8f75436f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222133
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773084}

This abstraction has no uses, so fold its single function into its
single user.

Rename the argument to make it clear that it is a tear-off type. Also
call Target() only once on the tear-off item (since it has side-
effects).

Change-Id: Ife6a14cbfe85f2ebe17dab9d6d29b0ffba933ed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218172Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#773083}

This reverts commit c9b650e1.

Reason for revert: https://crbug.com/1087751

Original change's description:
> Reland "Roll ICU to 67.1"
> 
> This reverts commit d90baa9e.
> 
> Reason for revert: reland ICU67.1 after #if 0 the problematic new code
> 
> Fix in 630b884f84d
> 
> Original change's description:
> > Revert "Roll ICU to 67.1 f2223961"
> >
> > This reverts commit db2cb995.
> >
> > Reason for revert: caused 30ms startup performance regression on Windows
> >
> > Original change's description:
> > > Roll ICU to 67.1 f2223961
> > >
> > > ICU 67.1 release notes: http://site.icu-project.org/download/67
> > > ICU 66.1 release notes: http://site.icu-project.org/download/66
> > > CLDR 37: release notes: http://blog.unicode.org/2020/04/unicode-locale-data-v37-released_23.html
> > >
> > > 1. Update to 67-1
> > >    Diary https://docs.google.com/document/d/1ZDtSPa3ZkzBIJmqrDVmGmyrTihjx8Me4fKQoQcBj02E/edit#
> > >
> > > Size changes:
> > >   65-1 .   67-1
> > >  7786368  7778704 android/icudtl.dat
> > >  6412768  6400752 android_small/icudtl.dat
> > >  1418320  1430976 android_small/icudtl_extra.dat
> > >  5060880  5048912 cast/icudtl.dat
> > > 10481632 10470736 chromeos/icudtl.dat
> > > 10506736 10498032 common/icudtb.dat
> > > 10506736 10498032 common/icudtl.dat
> > >   900576 . 898416 flutter/icudtl.dat
> > >  6375984  6363968 ios/icudtl.dat
> > >
> > >
> > > Bug: 1064326, 827538
> > > Change-Id: I169e1f99514b36cafd54a6bc8a9914ccf222d008
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155530
> > > Reviewed-by: Koji Ishii <kojii@chromium.org>
> > > Commit-Queue: Frank Tang <ftang@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#764138}
> >
> > TBR=machenbach@chromium.org,kojii@chromium.org,jshin@chromium.org,ftang@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: 1064326, 827538, 1080367
> > Change-Id: I98ebe6e01631b10ecc1955ac9d3bc53be11e23c6
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209232
> > Commit-Queue: Mike Wittman <wittman@chromium.org>
> > Reviewed-by: Mike Wittman <wittman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#771137}
> 
> TBR=wittman@chromium.org,machenbach@chromium.org,kojii@chromium.org,jshin@chromium.org,ftang@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1064326, 827538, 1080367
> Change-Id: I6d255bac08a68d6716ac51d84765acc010c6a10d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220363
> Reviewed-by: Mike Wittman <wittman@chromium.org>
> Commit-Queue: Frank Tang <ftang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#773036}

TBR=wittman@chromium.org,machenbach@chromium.org,kojii@chromium.org,jshin@chromium.org,ftang@chromium.org

Change-Id: I62514ad0a6c270f8099e4a473e31f93d3ee7619a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1064326, 827538, 1080367, 1087751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217839Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773082}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09841a6eaf28..d95366028fd0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC shimazu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: shimazu@google.com
Change-Id: Iccd1e2374cc9a64ca2d1e465f20d1fd7426213e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220902Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#773081}

This patch changes "5729680.html" to utilize |selection_test()| and renames to
"delete_range_before_space.html" for ease of maintenance and help to
implementing EditingNG.

Bug: 707656, 679977
Change-Id: Ifb10e35390c66f6d82c207a35d90d0324fa8d3fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220109
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773080}

This CL adds |-internal-space-around| keyword to |text-align| CSS
property. It is used for the default value of ruby annotation boxes
and ruby base boxes.

We assumed |start|, the initial value of text-align, in ComputedStyle
had a special effect for ruby annotation and ruby base, and we made a
variant of kJustify internally.  The code was complicated, and
introducing |-internal-space-around| simplifies the code.

This CL has a small behavior change:
 - If text-align:start is specified to <rt>, we ignored it before this
   CL and applied the 'space-around' behavior.
   After this CL, we apply text-align:start behavior in that case.

* LayoutRubyRun.cc
  ComputedStyle for LayoutRubyBase was sometimes overwritten by
  LayoutObject::PropagateStyleToAnonymousChildren(), and the TextAlign
  value was reset to kStart. Uses UpdateAnonymousChildStyle() to keep
  the expected TextAlign value.

* insert-paragraph-into-table-expected.txt
  |style="text-align: -internal-space-around;"|, which is unable to
  parse, appears.  This will be fixed when we implement ruby-align CSS
  property.

Bug: 1069817
Change-Id: Iecc1e999d11b58dd4d950f3579310546f5db7585
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217673
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773079}

Bug: 459423
Change-Id: I33d21c8e23f1544f8ad68a9f58db57a5a3ce1874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216634
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773078}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7d311f594622..93a9381c76d8

2020-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: Ic9a59ccca2dc48c57d1ca540da8c1707028fee92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222131Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#773077}

Make ALT+V a toggle (instead of only switch on) for the system info on the login screen

Bug: 1081689
Change-Id: I7edb4bcfa39f60585937f2a1a4507f7f3abbb15e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210461Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Yunke Zhou <yunkez@google.com>
Cr-Commit-Position: refs/heads/master@{#773076}

This CL removes PutPageIntoBackForwardCache and RestoreFromBackForward
Cache IPCs and use mojo instead.

Now the page state is managed by PageLifecycleStateManager, which is
responsible for sending updates to renderer via mojo messages.

Bug:1057506

Change-Id: I2e1fafe79c758f8d6d56eabd9ee13f288f370bf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192540
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773075}

The download home UI uses offline item collection code stack. This CL
introduces a new struct in both native and Java. The DownloadSchedule
struct will be converted to this when plumbing to the UI.

Bug: 1078454
Change-Id: Ib636f5df4a81c4fd12c6cca7df5e064b895e45a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218483
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773074}

This UMA is still usuful for monitoring the health condition of worker
threads.

Bug: 1084061
Change-Id: I3ac54843dfbe67fe965b3e15a4da5ab126cb19f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217725
Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773073}

Roll Chrome Win64 PGO profile from chrome-win64-master-1590710362-c13fe441c8f420f4cd2f4cff6b98279f2ecbf633.profdata to chrome-win64-master-1590724612-5db2101d2a61d33e1335d92c89441aeea9c7ea20.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I7e8163649d33b1bd40d224cbf7f3be4d8d5d59fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222128Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#773072}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/468f8fff..14aed087

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I53c98a50d732ec99460cd186ff27e87f0d690698
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218392Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#773071}

We have no plans to work on this TODO.

Bug: 616721
Change-Id: Ifb7a5803f9494936c50c164d655e754db87a6dc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222063
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773070}

This reverts commit 54b1dc4f.

This is a *temporary* revert to investigate some unexplained metrics
changes, see linked bug.

Bug: 1075587
Change-Id: I4c4a3c0b1ac5e0f6a39dc15f5fd8aafc87ffec35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218171Reviewed-by: Rushan Suleymanov <rushans@google.com>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773069}

This CL refactors WebAppInstallFinalizer database write code to not
plumb through bool is_new_install. Instead the database write callsites
encode what they want to happen afterwards as part of the CommitCallback.

This is a refactor only CL in preparation for:
https://chromium-review.googlesource.com/c/chromium/src/+/2216143

Bug: 1084405
Change-Id: Ib71740878d9e339fd8cc6ee73b6bd6fa1b782272
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217835
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773068}

Roll Chrome Mac PGO profile from chrome-mac-master-1590710362-35a7ecd8a402bd31319e2be75ae7373248116b8a.profdata to chrome-mac-master-1590724612-c1421d9824c914ff15feb610fd2b028bed82b9e1.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: Idc6406933af55e570acd4d0c9e9246ddc6aaa060
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222124Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#773067}

https://chromium.googlesource.com/catapult.git/+log/3c272f416f07..dd9feece3750

2020-05-29 dberris@chromium.org operations: Fixup style config

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC rmhasan@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: rmhasan@google.com
Change-Id: Ibd749a0eee5958ef247cbffbcdb6db0d08f752da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222127Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#773066}

Bug: 953308
Change-Id: I13b337fe205e897e0350a007d690a24ce582787f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220409Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Commit-Queue: Omid Tourzan <oto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773065}

Closing the keyboard before attempting to click the button should
finally fix those flaky tests.

Bug: 1087042
Bug: 1084324
Change-Id: Iae013984e3b844eb665aac7f363f2111f139e378
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218834
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Reviewed-by: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#773064}

Change-Id: Ie6eeeffc8c29e30388a7958dbbbfb9477dfd96f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222181
Auto-Submit: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773063}

This fixup addresses a regression in blink_perf.parser tiny-innerHTML
by avoiding the creation of some expensive objects when parsing
DocumentFragments.

Bug: 1087199, 901056
Change-Id: Ie9cc5e50c138a66e2c7c1beaad26a8a653614506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218846
Commit-Queue: Richard Townsend <richard.townsend@arm.com>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773062}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e4c9e6c19cc8..7d311f594622

2020-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: I6a6d030e68533fb1e59cdf9664191eee828e593c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222122Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#773061}

This CL adds 'boolean or DoubleConstraint' support for pan, tilt, and
zoom constraints in getUserMedia. Spec says that `pan: true` is just
syntactic sugar for `pan: {}` and `pan: false` the same as pan being
undefined/not provided.

Spec: https://github.com/w3c/mediacapture-image/issues/225
Change-Id: I0f5788ff91bceda14bc9cdad0852e1195755a3f4
Bug: 934063
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210237Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#773060}

The ListMarker class contains common logic for LayoutNGOutsideListMarker
and LayoutNGInsideListMarker. But it's not a superclass, since multiple
inheritance would be slow. Instead, the layout marker classes have a
ListMarker member. But the ListMarker methods need to reference back
their LayoutObject owner, this could have been done with a pointer, but
it would take more memory. Instead, the ListMarker methods accept a
LayoutObject& parameter, which is supposed to be the marker that owns
that ListMarker instance.

The problem was that there was no check that the LayoutObject argument
was actually the owner of that ListMarker, or even that it was a marker.
So if by mistake some caller passes another LayoutObject, something will
go wrong but it may go unnoticed, or the cause of the misbehavior may
not be obvious.

This patch adds some DCHECKs to address this.

Bug: 457718
Change-Id: I6cd34fceaf763f8d8ce8032c288a8066eaf90a54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218311Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773059}

The coefficients were completely wrong. I verified the correct
values suggested in the bug against ITU-T H.273.

This also resolves two comments in the test file remarking that
YCOCG and SMPTEST428_1 were "weird" due to negative values...
which was due to both matrices being wrong.

76fb0d6f fixed YCOCG, but didn't
resolve the test comments.

R=ccameron

Fixed: 1087073
Change-Id: If1d9bfe1810de81ddee1cabdf410c1f41e4602ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218859
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773058}

CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/voJICdrAJXQHr-PwOYa17rQCqEsW2U1T1672WgefrioC

Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202005280800_RC00.html

Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
Change-Id: I82c384b360abf1ce8119c3b46913c20ee9a36163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217838Reviewed-by: Rachel Carpenter <carpenterr@chromium.org>
Commit-Queue: Rachel Carpenter <carpenterr@chromium.org>
Commit-Queue: Callistus Tan <callistus@google.com>
Cr-Commit-Position: refs/heads/master@{#773057}

The web-packaging team is going to implement a new feature:
Subresource loading with Web Bundles.

Create a runtime flag to put the feature behind for now.

Bug: 1082020
Change-Id: I953262ddfe2d3937ed1e1a37c35cb0281255de75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214793Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773056}

TBR=droger@chromium.org

Bug: 1087189
Change-Id: I2e9b96dad3be4ffd541546e5df6332a0ed5f8500
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217979Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773055}

This CL adds usage documentation for the new
video_encode_accelerator_perf_tests, providing in-depth information on
how to run the encoder performance tests.

TEST=gitiles

BUG=953114

Change-Id: I82c445e2923d57dea16b0febddd0e03b67330da3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060366Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773054}

The feature will allow ARC apps to handle a key event before it's sent
to IME and potentially consumed by it.
Please refer to go/arc-key-event-dispatch for the details.

Bug: b:148193316
Test: component_unittests
Test: manual - enable the feature and confirms a key event is sent to an app
Change-Id: I81da94d92400e91ff1e4c2fca23bc22da9ed2569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214850
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773053}

This change captures a few cases where SYSTEM_ERROR could be returned
without a more detailed error being printed for debugging purposes.

Bug: 1070798
Change-Id: I9450d1f89b87483f5e7442736752d4b199f62161
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220743
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773052}

https://pdfium.googlesource.com/pdfium.git/+log/4ae21d7942e1..f32ae562fe52

2020-05-29 tsepez@chromium.org Merge INT_MAX % -1 patch to pdfium
2020-05-29 hikakar@microsoft.com Fix enter/space key press events on Combobox
2020-05-29 hikakar@microsoft.com Handle Enter/Space key events for read-only check box and radio button.
2020-05-29 nigi@chromium.org Add a helper function for creating text rendering options.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1086092
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: Ied1e8acf92a220986c7a51e498eb1d8fbc9fe536
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222120Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#773051}

Change-Id: I3a9ea9e2f98e0162acf1a85daa3309791221860f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215022
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773050}

Bug: 993029
Change-Id: I87e33b72d6a340c48e4a9780c21de4c8693e42f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175552Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773049}

Verify that the QuicTransport constructor rejects incorrect URLs.

Also verify that attempting to connect to port 0 fails.

BUG=1011392

Change-Id: I57d209569633c351dd408cdced1d7e44f92f1065
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217680Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773048}

Implemented a UI change behind the flag:
UI with flag disabled: https://screenshot.googleplex.com/osdAbRsrOdw
UI with flag enabled: https://screenshot.googleplex.com/k9waaRkjG4x

Test: tested with Chrome on Linux
Bug: 1086786
Change-Id: Id3b35306289715e8761e874a6b0fcdfed12205ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216139Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Jing Wang <jiwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773047}

https://chromium.googlesource.com/catapult.git/+log/8c643ad793bf..3c272f416f07

2020-05-29 dberris@chromium.org operations: Set a yapf config in the Dashboard

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC rmhasan@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: rmhasan@google.com
Change-Id: I741fa290e499465df68c8110785a6afa763c27c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220898Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#773046}