GitLab

Ctrl+Break on Windows was busted. The algorithm
in |NextWordPositionInternal| never considered
punctuation as a word break character.
According to the Unicode spec for word break boundaries,
punctuation should be considered as word breaking characters.
Added this additional condition in both previous
and next word movement.
Also changed many spellchecking tests to match this behavior.
Insert a space after the misspelled word so it is spellchecked properly.
This is done to trigger spellchecking as the punctuation after the
misspelled word doesn't trigger spellchecking until the user has pressed
space bar or changed the selection.
This is how it should be done in real sites anyways so inserting the
space after misspelled word to trigger spellcheck  makes sense.

Test: third_party\blink\renderer\core\editing\visible_units_word_test.cc

Bug: 122304, 1004414

Change-Id: I88694d3cd2e275f06e3939e7e42181de0bd1b9c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880602
Commit-Queue: Anupam Snigdha <snianu@microsoft.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710243}

Removes the assumption that InstallableManager currently has: that it will
continue to exist after calling the callback. This makes sense if considering
the callback as a return-like statement for the async GetData call.

In prep for refactoring in http://crrev.com/c/1873817

Bug: 1007860
Change-Id: I18f751b32c88a9d3cc9d6c3f3a083fd3952ebe9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884409
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710242}

This CL converts old Mojo types to new Mojo types
in CdmFoo classes except for CdmService::LoadCdm.

  - Convert FooRequest to mojo::PendingReceiver.
  - Convert FooPtr to mojo::PendingRemote or mojo::Remote.
  - Convert the second parameter to mojo::PendingRemote in
    service_manager::GetInterface

Bug: 955171
Change-Id: I9ff169c17829f5ce69ede8c6b3ab991350491047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883347
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710241}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b5aaf6416b08..c3dc1efee35a


Created with:
  gclient setdep -r src-internal@c3dc1efee35a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: Ifbb2a5660bb4fd7c816d1c00d54b243b13f317bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885954Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710240}

This patch gets rid of unused function |GetForInlineContainer()| in
|NGPaintFragment| for improving code health.

Note: The CL[1] gets rid of the last caller of this.

[1] http://crrev.com/c/1877505 Utilize NGInlineCursor
ComputeNGLocal{Caret,Selection}Rect()

Change-Id: I0f191f711a4d55b5a67e92068a7cb4522dcb19f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881001
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710239}

Bug: 1003238
Change-Id: Icc3227b44ba58fcab17bd8eab959f0346a8a906d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886133Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710238}

This changes the test to use the useful utility functions.

Bug: 1017861
Change-Id: Idc399d439b803d52ca44ede417890e0a8a4ae550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880245
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Auto-Submit: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710237}

Since HaTS library uses async google iframeIO call to post the survey
answer through a form to the server. The form's target is an iframe in
the same doc. If we close the window too quick, the request might not go
through yet. So, in this CL, we wait until the iframe is loaded, which
means the form is already posted, to close the window.

BUG=1018063

Change-Id: Ifcc3120addecf540a6a45430bba3ea545d65d078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880694
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710236}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I8b9cf37169817ab5d7624c06a379e72750aaef65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886110Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710235}

These tests should be moved to wpt as they test shared web platform
features of AOM.

aria reflection spec:https://wicg.github.io/aom/spec/aria-reflection.html

Bug: 746523
Change-Id: I8efff9039bcbc869c6a7e597c1e70326aaaa4be0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884396Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710234}

TBR=govind@chromium.org

Change-Id: If1093b2414446d604468617b161299812faf2fde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885276Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710233}

When you click on a focusable element with the mouse, the element gets
focused in addition to receiving click events.

In contrast, this wasn't always happening when using accessibility APIs to
click on an element. Note that on many platforms, assistive technology
was already triggering a focus action, when the user has enabled automatic
focus. In those cases, this change will have no effect. If the user turns off
automatic focusing in their AT, this change will have the effect of focusing
an element before clicking on it.

This bug was reported on Android. Prior to Android O, TalkBack used to
send a click event when the user double-tapped. Now, TalkBack sends
ACTION_CLICK, which results in clicking elements without first focusing them.

Bug: 791285, 901511
Change-Id: I0ae7664c4e80bd806e008fb86740fbae547ef582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864416Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710232}

Based on UMA data we increase the threshold to 512kb.

Bug: 1018050
Change-Id: Ic4ca9b3d8a959610c5e187d0eefdc0ee02fe785a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885853Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710231}

* Replace map<View*, ... with map<Link*, ... since that more accurately
  captures the intent.  Add a type alias as well.
* Slight modifications to variable names and comments in advance of functional
  patch, to minimize its diff.

Bug: 1015717
Change-Id: If153e69129c2d66a9d12825bdaddfb7e9a1787f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884359
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710230}

TBR=dmazzoni@chromium.org

Change-Id: I7308081ae5c108f8865d1af360ffe21bdf6b538c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885970Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710229}

During FIDO enrollment for Payments Autofill, setting attestation conveyance to
`direct` in the CreationOptions.

Bug: 949269
Change-Id: I56bcb9b9e9acfa6b9c1abe8644a5bf053082b3a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885507Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#710228}

This change adds a field trial testing config for the Touch To Fill
feature on Android.

Bug: 957532
Change-Id: I633e978f4eb4c7c25a5a0c1ee9cf5e0812cc287f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879266Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710227}

VideoFrameValidator validates frames by comparing with expected md5sum. The
validation is appropriate for deterministic image/video processing like video
decoding and format conversion among YUVs. There are various non-deterministic
image/video processing like frame scaling. So that VideoFrameValidator can
verify resulted frames in such cases, this enables VideoFrameValidator to
validate by comparing each byte of a given buffer with one of an expected
buffer.

Bug: 917951
Test: image_processor_test on atlas (pass) and eve (fail due to b/141724493)
Change-Id: I19dac5df329d9c838edc184dedf2582cd72beead
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866114
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710226}

Following bot results are included.
67 69 70 75 76 78 79 80

318 lines were removed and 173 lines were deflaked by consecutive
results since 70.

TBR=yosin@chromium.org
NOTRY=true

Bug: 982194
Change-Id: I1cf456381f40cae295ff966cd36df87dcd01c45a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883448Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710225}

Remove the shlib APIs. Create a threadsafe helper class for
commonly-used methods.

Merge-With: eureka-internal/327818
Merge-With: eureka-internal/328657
Bug: internal b/138938216
Change-Id: Iab6635043af2dd85057ceafc18cb2f64269651c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877601
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710224}

In Blink, the title attribute usually results in the accessibility node getting
a name or description with the title text. In addition, it always populates the
tooltip attribute.

Recently, the tooltip attribute was added to Output.hint_, but no suppression
was made when it is the same as either name or description. Make that so in this
change.

TBR=dcheng@chromium.org

Change-Id: I67d21f0206ce3cb17b691915db0b4dc5d127ff51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872741Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710223}

This is to be built on the Goma RBE Prod backend:
https://chromium-review.googlesource.com/c/chromium/tools/build/+/1886131

Bug: 947436
Change-Id: I5a40c2b2113bf17e8d01b56e33e62dbfbbacdf0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886074
Auto-Submit: Simon Que <sque@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710222}

https://chromium.googlesource.com/catapult.git/+log/090f35f08a00..a8fe19e0c492

git log 090f35f08a00..a8fe19e0c492 --date=short --no-merges --format='%ad %ae %s'
2019-10-29 perezju@chromium.org [pinpoint] Replace "tir_label" with "grouping_label"

Created with:
  gclient setdep -r src/third_party/catapult@a8fe19e0c492

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC simonhatch@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=simonhatch@google.com

Bug: chromium:974237
Change-Id: I4d5152ba3cff47119dac71a8e094cdcf9c2ee3de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885952Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710221}

This class will be used by smbfs to establish a Mojo channel to Chrome.

BUG=939235

Change-Id: Idc0bc822e4839325ba32f204a06cd5fe4a92e012
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833017
Commit-Queue: Anand Mistry <amistry@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710220}

DriveFS files are not opened via externalfile: URLs, so drive no longer
needs to be tested by externalfile URL unittests.

Bug: 1003238
Change-Id: I661df3f6a70abcee9e3d3ea96301eeb9e30541fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883429
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Reviewed-by: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710219}

This code is disabled by default behind kDesktopPWAsWithoutExtensions and
kDesktopPWAsUSS base features.

A browser end-to-end tests will be added later in a follow up CL.
An MVP implementation of the bridge+sync needed first.

Bug: 860583
Change-Id: I461e24fefcbb5d2a0bf819d63a480635e91c732c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858025
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710218}

The resources files were being renamed to no longer have an xml suffix.
In addition, we were including android support library resources, which
should be provided by the client.

Change-Id: I1d651c6db696defd5760c9c39dd6c7a9a57509ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885178Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710217}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1f76613520ff..b5aaf6416b08


Created with:
  gclient setdep -r src-internal@b5aaf6416b08

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Ia3cc2fe3d3203aad38975a9cf06f2785fc546343
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884632Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710216}

This reverts commit 5cd504f9.

Reason for revert: Failed NTPHomeTestCase tests. crbug.com/1019070

Bug: 1019070
Original change's description:
> [iOS] Convert NTPHome test to EG2
>
> OmniboxWidth and OmniboxWidthBetween are moved to the egtest.mm file
> directly to avoid having a more complicated interface.
> Suggestions() uses are replaced by -addNumberOfSuggestions:
> additionalSuggestionsURL:.
>
> Bug: 987646
> Change-Id: I58535b52919fbd1d907c8a72c611e2fbb7f63f67
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871888
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709521}

TBR=eugenebut@chromium.org,stkhapugin@chromium.org,gambard@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 987646
Change-Id: If3418f1cc097867fa1ef011d5036f171c3cc3fa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885971Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710215}

This is a precursor to adding a new scoped_refptr(std::nullptr_t)
constructor. The implicit conversion from NULL to scoped_refptr<T>
causes a compilation error with the new constructor. Replace NULL with
nullptr in any files where this is a problem.

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 1018887
Change-Id: Ifd7c2f17a6be0dcc075020d090f62af299d46708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885012
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710214}

https://chromium.googlesource.com/angle/angle.git/+log/6f23b4b7038e..e78527989c4c

git log 6f23b4b7038e..e78527989c4c --date=short --no-merges --format='%ad %ae %s'
2019-10-29 jmadill@chromium.org Vulkan: Clean up redundant vk:: prefixes.
2019-10-29 jmadill@chromium.org Vulkan: Move readPixels logic to ImageHelper.

Created with:
  gclient setdep -r src/third_party/angle@e78527989c4c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: None
Change-Id: I12cfa5fd4c73df18c7e3218db6a9beb9ebcdc3ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885730Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710213}

This CL converts URLLoader from //content to new Mojo types
using PendingReceiver and Receiver.
It also updates CreateLoaderAndStart from url_loader.mojom
and implementations for it.

Bug: 955171
Change-Id: I3c3b12774e22c1aa239b22e1a86d7018e2259f9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880987
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#710212}

Using wpt-import in Chromium 3b57a5e8.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
nzolghadr@chromium.org, mustaq@chromium.org:
  external/wpt/pointerevents
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I048adc3ebb19a8c357119a766f5a0a0de7432c26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884771Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710211}

Now group previous multiple virtual test suites with the same
prefix and args together.

For example, previous configuration
  {
    "prefix": "composite-after-paint",
    "base": "compositing",
    "args": ["--enable-blink-features=CompositeAfterPaint"]
  }
  {
    "prefix": "composite-after-paint",
    "base": "paint",
    "args": ["--enable-blink-features=CompositeAfterPaint"]
  }
now becomes
  {
    "prefix": "composite-after-paint",
    "bases": ["compositing",
              "paint"],
    "args": ["--enable-blink-features=CompositeAfterPaint"]
  }

This shortens VirtualTestSuites by nearly half, avoids accidental
inconsistent args (We should create different virtual test suite
for different args), and allow "pure physical" virtual test suite
which is an alternative of physical test suite.

A "pure physical" virtual test suite has empty "bases", and the
"virtual/<prefix>" test path contains real tests only.

Normal vitual test suites can still contain real tests.

Bug: 1014162
Change-Id: I8d24be0e62b44ec8987aef65cb6f9ff0423b2d2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873504
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710210}

BUG=976952, 958020

Change-Id: Ied9361ae735c702b3989eb18ab36bf579917bf45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877651Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710209}

I forgot to normalize the app IDs feeding into the Roselle model at
inference time, leading to some (not all) apps erroneously never being
ranked by the model.

Bug: 1019068
Change-Id: I0288c3cf591b92f9f0a9c356630b2212d29d16a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885852
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710208}

Bug: 1015141
Test: policy_test_cases.json
Change-Id: I0865bc5cf631b142388ed52a3e35f492d6edd468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865769
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710207}

We follow https://html.spec.whatwg.org/C/#dom-tabindex by this CL.
The old behavior of default tabIndex was something like "Returns 0
if the element is focusable, -1 otherwise". But it didn't match to
the HTML standard, and was not interoperable.

Since this CL, some elements return -1 if "tabindex" attribute is
missing or invalid regardless of their focusability.

Implementation:
Node::tabIndex() is not a virtual function any longer. We have only
Element::tabIndex(), and it calls virtual DefaultTabIndex() if
"tabindex" attribute is missing or invalid.

DefaultTabIndex() for elements listed in the specification returns 0.
Otherwise, it returns -1.
 - HTMLAnchorElement affects <a> and <area>
 - HTMLFormControlElementWithState affects <input>, <select>, and
   <textarea>.
 - HTMLFrameElementBase affects <frame> and <iframe>

Blink can't use Element::tabIndex() for the purpose of focusability
check any longer.  This CL updates existing tabIndex() callsites to
avoid behavior changes.

Change-Id: Ib1728d6be98ccf589fc0e3e153d07eb973532e25
Bug: 982350
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883350Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710206}

This does the move by removing the blacklist checks for commit-time
previews from the navigation start portion and will be checked for
real at ShouldCommitPreview

Bug: 1018799
Change-Id: I04248c87176376586c7ff07b8ff7c5bcea68c265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885637Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710205}

This fixes a bug where modules can miss an ABI and fail the bundle
packaging step. This is due to two factors:

1. crrev.com/c/1876975 added an allotment step to each bundle that
   determined in which module native libs are packaged into. If a module
   only depends on libs that are also depended on by other modules this
   module will package no libs even though libs are specified when
   instantiating the module target.

2. Bundletool requires that all modules support the same set of ABIs.
   To make modules appear to support the WebView ABI for Monochrome and
   Trichrome we add placeholder libs for the WebView ABI. We do this in
   the chrome_feature_module template if we specify real libs for the
   browser ABI.

Given 1. and 2. it can happen that a module is only left with the
placeholder lib and appear single ABI, failing packaging. This CL fixes
that by telling the packaging step that the module should be multi ABI
and the packaging step will add a placeholder lib if necessary. This
makes placeholder logic in chrome_feature_module obsolete and therefore
it is removed.

This new multi ABI logic can likely be reused for other APKs that use
lib placeholders simply to make the APK multi ABI.

Bug: 870055
Change-Id: I25cf4edd56bf253cff2aef54d1857cbe9167cae3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881814
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710204}