GitLab

From using AtomicString (for 'mask', 'marker-*', 'fill' and 'stroke') or
the string representation of SVGResources ('filter' and 'clip-path'),
convert to using SVGResources.
Add an implementation of SVGResourceClient (SVGElementResourceClient)
and register it with the existing resources. Invalidation code is moved
here. This makes the invalidation code slightly more homogeneous between
the various code-paths.

The new SVGResourceClient implementation is stored in SVGElementRareData
as needed.
The various computed style representations are converted to use the new
StyleSVGResource, which is a ref-counted wrapper around an SVGResource
and its underlying string representation (which is needed for
serialization.) Style building is changed to produce this new wrapper
(rather than an AtomicString.) A helper for serialization is added to
ComputedStyleUtils.
The kHasPendingResources flag is removed since it no longer used, and
the hook in Element is removed.
All LayoutSVGResource* subclasses are changed to take SVGResourceClients
instead of LayoutObjects, and the |clients_| set is removed in favor of
the set in SVGResource.
A bunch of helpers are added for updating (adding/removing) the client
registrations. The various LayoutSVG subclasses are updated to call
these helpers.

Changes on reland: LocalSVGResources are now tracked using WeakMember, and
the associated IdTargetObservers are cleaned up when weak references are
cleared.

Bug: 769774
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie0b42471aea5ea5afb5d239662b4ba195281f764
Reviewed-on: https://chromium-review.googlesource.com/1057330
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559479}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ed1bb34fc59e..23a358764dd8

$ git log ed1bb34fc..23a358764 --date=short --no-merges --format='%ad %ae %s'
2018-05-17 ehmaldonado gclient: Fix for extra custom_deps.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:839925


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I293439d96cfef1bb45b25e3e989f591efce049fb
Reviewed-on: https://chromium-review.googlesource.com/1063557Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559478}

Change-Id: I755687754c62b2da8d20e48d5607f568c5bf47b1
Reviewed-on: https://chromium-review.googlesource.com/1033326
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559477}

Mark the class as non-copyable/moveable to prevent against
slicing and make the destructor public to allow destruction
via pointer to base class (i.e. std::unique_ptr<Observer>).

Bug: none
Change-Id: I713262134cb61fdd37a4c11b20ef154aeed2f00f
Reviewed-on: https://chromium-review.googlesource.com/1063770Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559476}

TBR=brucedawson

Bug: none
Change-Id: Ief0ae90da4d04abfb66e7ebca89849ed9003570f
Reviewed-on: https://chromium-review.googlesource.com/1063836Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559475}

All/AutofillInteractiveIsolationTest.SimpleCrossSiteFill/1 is flaky.
I wasn't able to find a good culprit, so let me disable this so
that owners can figure out.

TBR=estade@chromium.org

Bug: 843935
Change-Id: I3e135fdd51b3b31cfb0fe4af4a031d62984377da
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/1063418Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559474}

This reports the total size of source code size for all external scripts
in a V8 isolate. As with other V8 code stats, this doesn't distinguish
between live and dead objects and doesn't scan the young generation.

Bug: 837659
Change-Id: I746729f3c167cbad847599b4b128fa517a116c7e
Reviewed-on: https://chromium-review.googlesource.com/1032936Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559473}

This CL adds the audio related switches which are used by the audio
service to the whitelisted switches for utility processes. This is
needed when running the audio service out of process.

Also moves all the ifdefed switches to the bottom.

Bug: 843103
Change-Id: I2172d02b28f5011a915c89d9509dd15ccb166950
Reviewed-on: https://chromium-review.googlesource.com/1059624
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559472}

This reverts commit 5a7f3c44.

Reason for revert: this breaks v8's VC++ goma builds, reverting until
goma is updated to support this compiler

Original change's description:
> Switch to VS 2017 15.7.1 with 10.0.17134.0 SDK
> 
> This change switches the VS 2017 package to use VS 2017 Update 7.1 while
> using the 10.0.17134.12 SDK. The new SDK is needed to support new HDR
> features, and to stop forcing external developers to install an old
> ([Spring] Creators Update) SDK. This change will also bring in a new
> linker and other build tools, but the version of clang-cl will be
> unchanged.
> 
> Packaging was done on a Windows Server 2016 VM, cleanly created for this
> purpose.
> 
> Compiler was packaged up by downloading VS 2017 Update 7.1, from
> https://www.visualstudio.com/vs/, and then passing these parameters to
> the installer:
> 
>     --add Microsoft.VisualStudio.Workload.NativeDesktop
>     --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
>     --passive
> 
> Then Add or Remove Programs was used to modify the 10.0.17134.0 SDK to add
> the Debuggers package.
> 
> Then the packaging script was run like this:
> 
>   python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.17134.0
> 
> Bug: 773476
> Change-Id: Ic819f3ae79d7e869227bf33fbb8d202e2f57039b
> Reviewed-on: https://chromium-review.googlesource.com/1054027
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#559033}

TBR=thakis@chromium.org,dpranke@chromium.org,hubbe@chromium.org,brucedawson@chromium.org

Change-Id: Ib8e84084a9717dafa6616f132b4824d93cbf39bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 773476
Reviewed-on: https://chromium-review.googlesource.com/1063810Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559471}

This reverts https://chromium-review.googlesource.com/1042290 since
cc::Surfaces for video are now allowed to work with software
compositing.

Bug: 806249, 807840
Change-Id: Ie02c69d527b8e13235d744d3c2e98ea5b073f61d
Reviewed-on: https://chromium-review.googlesource.com/1062745Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#559470}

This reverts commit 58e3dc5d.

Reason for revert: The failed CrOS test doesn't seem affected
by the newly introduced Android code. 

Original change's description:
> Revert "Render Tabs into Bottom sheet"
> 
> This reverts commit a4ae2e1f.
> 
> Reason for revert:
> All/AutofillInteractiveIsolationTest.SimpleCrossSiteFill/1 started
> to fail on ChromeOS likely after this change.
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/8133
> https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5701
> 
> Original change's description:
> > Render Tabs into Bottom sheet
> > 
> > This CL shapes the role of a KeyboardAccessoryData.Tab element:
> > It is an element that provides a specific benefit to the Manual UI by...
> > ... providing data that is used by the bar to render a tab (upcoming)
> > ... providing the content for a separate tab in the bottom sheet.
> > 
> > This means, that the bottom sheet provides space for tabs and manages the
> > general visibility and active states of tabs.
> > The exact content of a tab doesn't matter to the AccessorySheetComponent.
> > That way, it should become fairly straight forward to implement a new tab
> > that is rendered into bottom sheet and accessory.
> > 
> > The first concrete instance of a bottom sheet will follow soon: a
> > bottom sheet that contains password related actions and data.
> > (It's important to not mix this specific data into the AccessorySheet
> > component as other upcoming sheets are already planned, like one for
> > payments and one for address data.)
> > 
> > Bug: 811747
> > Change-Id: Id8bd8c389496246166d26a6c298056a142c36566
> > Reviewed-on: https://chromium-review.googlesource.com/1047285
> > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#559180}
> 
> TBR=bauerb@chromium.org,fhorschig@chromium.org
> 
> Change-Id: I879e4e89c674d47562c662b5c2bbac3487546062
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 811747
> Reviewed-on: https://chromium-review.googlesource.com/1063732
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#559463}

TBR=kinuko@chromium.org,bauerb@chromium.org,fhorschig@chromium.org

Change-Id: I17ef937cfed19aa4b3fe9b10220b77ac349ffb31
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 811747
Reviewed-on: https://chromium-review.googlesource.com/1063790Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559469}

https://skia.googlesource.com/skia.git/+log/15f1761d9e8f..bd74e6a02ae0

$ git log 15f1761d9..bd74e6a02 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: I3de11e8ce5e351b67eb545308d1f04348dbeaf40
Reviewed-on: https://chromium-review.googlesource.com/1063562Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559468}

Currently ephemeral users are not stored into local state at all. It
works bad in case Chrome crashes (or restarts) inside the session. E.g.
Chrome could not find for which user session should be restored.
This change puts data for ephemeral users into local state and wipes on
logout.

BUG=chromium:843163
TEST=TBD

Change-Id: Ice425c63ca74a0d4862e5f05ff869de185da5e6e
Reviewed-on: https://chromium-review.googlesource.com/1059785
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559467}

This tests tells the audio manager to fail creating an audio stream,
but accessing the audio manager directly isn't possible when running
out of process. Thus, a command line switch is introduced.

I ran the test 100 times for each combination of
(in content streams, in process audio service streams, out of process
audio service streams) and (tsan, release) to ensure it's not flaky in
any way, but note that running it out of process requires updating the
flag whitelist in content::UtilityProcessHost (next CL, since we'll need
a few flags).

Bug: 835742, 843103
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8a6a659523f39a1c66c3a9ed9d37de9eedbc8265
Reviewed-on: https://chromium-review.googlesource.com/1059594Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559466}

Bug: 843412
Change-Id: Ib6d25a9eaca5a7a6153bb1be2ddf48e3bb4538a9
Reviewed-on: https://chromium-review.googlesource.com/1063430Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559465}

See go/closure-compile-gn for details.

This CL converts ntp4 and offline_pages to GN Closure compilation. It
also deletes the webstore_widget GYP file which is no longer used.

A local closure compile can be run by setting closure_compile = true in
args.gn, and then running ninja -C out/Default webui_closure_compile.
A more localized compile may look like:
ninja -C out/Default chrome/browser/resources/ntp4:closure_compile

TBR=fukino@chromium.org

Bug: 632206
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id6f4c248eaf19a63084e1734bc987b5f8a7c11fc
Reviewed-on: https://chromium-review.googlesource.com/1049209Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559464}

This reverts commit a4ae2e1f.

Reason for revert:
All/AutofillInteractiveIsolationTest.SimpleCrossSiteFill/1 started
to fail on ChromeOS likely after this change.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/8133
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5701

Original change's description:
> Render Tabs into Bottom sheet
> 
> This CL shapes the role of a KeyboardAccessoryData.Tab element:
> It is an element that provides a specific benefit to the Manual UI by...
> ... providing data that is used by the bar to render a tab (upcoming)
> ... providing the content for a separate tab in the bottom sheet.
> 
> This means, that the bottom sheet provides space for tabs and manages the
> general visibility and active states of tabs.
> The exact content of a tab doesn't matter to the AccessorySheetComponent.
> That way, it should become fairly straight forward to implement a new tab
> that is rendered into bottom sheet and accessory.
> 
> The first concrete instance of a bottom sheet will follow soon: a
> bottom sheet that contains password related actions and data.
> (It's important to not mix this specific data into the AccessorySheet
> component as other upcoming sheets are already planned, like one for
> payments and one for address data.)
> 
> Bug: 811747
> Change-Id: Id8bd8c389496246166d26a6c298056a142c36566
> Reviewed-on: https://chromium-review.googlesource.com/1047285
> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#559180}

TBR=bauerb@chromium.org,fhorschig@chromium.org

Change-Id: I879e4e89c674d47562c662b5c2bbac3487546062
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 811747
Reviewed-on: https://chromium-review.googlesource.com/1063732Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559463}

TBR=treib@chromium.org

Bug: 843921
Change-Id: I49f76869bbc7cd0e8abd5ac889ddec5e0ac1282d
No-Tree-Checks: True
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/1063526
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559462}

Add UMA stats:
- Duration of “service has incoming connections” intervals: Time between first incoming connection and last disconnected connection.
- Duration of “service has no incoming connections” intervals: Time between last disconnect and when quit_closure_ is called OR quit_closure_ is canceled.
- Service uptime (time between startup and shutdown)

Design doc: https://www.google.com/url?q=https://docs.google.com/document/d/1s_Fd1WRDdpb5n6C2MSJjeC3fis6hULZwfKMeDd4K5tI/edit%23heading%3Dh.2ap5hw4bex5a&sa=D&source=hangouts&ust=1526373977505000&usg=AFQjCNHfaxd8BHSQOi_HmB1cVe-bjilw5w

Bug: 842675
Change-Id: I429e34560ddcd52c814473bff6d6c1cdcc13e418
Reviewed-on: https://chromium-review.googlesource.com/1057628
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559461}

After https://chromium-review.googlesource.com/c/chromium/src/+/1059613,
they should pass.

Bug: 842698
Change-Id: I758bd2ac47ed3c934591ed7083aa32a2cfc0256f
Reviewed-on: https://chromium-review.googlesource.com/1059614
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559460}

String tail merging leads to smaller binaries, but they don't compress
as well, leading to increased mini_installer size.

This reduces mini_installer.exe size by 130 KB and increases chrome.dll
and chrome_child.dll by 72 KB and 154 KB, respectively for 32-bit (64-bit
is in the same ballpark).

(This depends on Clang/LLD being rolled past r332149.)

Bug: 838449
Change-Id: I1653e8d522371edb263f742f55ca1aa27ed5dd62
Reviewed-on: https://chromium-review.googlesource.com/1061733
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559459}

This migrates the test runner in content_shell to use
base::OnceCallback instead of legacy base::Callback.

Change-Id: I6b31e23d09002b8399978d1ea3572b880714fc72
Reviewed-on: https://chromium-review.googlesource.com/1061033Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559458}

Change quick view embedding pdfium with option view=FitH instead of Fit.

"FitH" fits to width which makes the PDF visualization to be fluid when
resizing the window (feature requested on crbug.com/809314) also it
doesn't cause pdfium to flick due to resizing the width and height as
happens with option "Fit".

See bug for a screen cast of PDF visualization with FitH.

Bug: 837591
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I242c92eea948ecc3378a02d404d2772ca4779e34
Reviewed-on: https://chromium-review.googlesource.com/1063518Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559457}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/966fe62677b1..8dba45a1c69f

$ git log 966fe6267..8dba45a1c --date=short --no-merges --format='%ad %ae %s'
2018-05-16 chrome-bot Update config settings by config-updater.

Created with:
  roll-dep src/third_party/chromite


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: If8aaca7e68504f96bfedce42b966aa6624499c9a
Reviewed-on: https://chromium-review.googlesource.com/1063556Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559456}

This is a part of effort to eliminate kUnthrottled task type usages.

Note that the task runner was originally kUnspecedTimer (=
kInternalDefault) and changed to kUnthrottled at https://chromium-review.googlesource.com/c/chromium/src/+/664094

We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading
and replace them with appropriate kInternal* task types.

Task type guideline: https://bit.ly/2vMAsQ4

Bug: 836410
Change-Id: I9bd31b6f1100de6bbd5b0b69487b7f85d341ae2e
Reviewed-on: https://chromium-review.googlesource.com/1056902
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559455}

These tests share a file/directory, or manage a hosted file/directory,
on Drive only. Add "Drive" to their test names to make that clear.

No change in behavior, no new tests.

Bug: 843030
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id9c21021156b24eeceb01351d88cb22310584873
Reviewed-on: https://chromium-review.googlesource.com/1063513Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559454}

Add consent_specifics proto as a preparation for separation of consents
into a separate model type from user events. The proto is based on
UserEventSpecifics::UserConsent. The proto has to land before the actual
split itself, so that the server is aware of the new datatype.

Bug: 840357
Change-Id: I2d3ab6575990d081315a93725fb5cee655af63b9
Reviewed-on: https://chromium-review.googlesource.com/1055567Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559453}

This patch moves virtual function implementation of Renderer-
WebSchedulerImpl to MainThreadSchedulerImpl, and remove Renderer-
WebSchedulerImpl. MainThreadSchedulerImpl now inherits from both
WebMainThreadScheduler and ThreadScheduler, just like NonMainThread-
Scheduler.

WebMainThreadScheduler and ThreadScheduler have a substantial number of
overlapping functions. They are implemented in MainThreadSchedulerImpl
at the same time, as those functions are compatible with each other's.
A future cleanup is planned to reduce the overlaps for a cleaner code
structure.

Bug: 826203
Change-Id: Ic32a1175b07a9f9e86123f4a70329b269758a841
Reviewed-on: https://chromium-review.googlesource.com/1058990
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559452}

Change-Id: I40da6b31558c158b27db52a5aa24e9fa26747e35
Reviewed-on: https://chromium-review.googlesource.com/1062268
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559451}

https://skia.googlesource.com/skia.git/+log/ed4921b9d473..15f1761d9e8f

$ git log ed4921b9d..15f1761d9 --date=short --no-merges --format='%ad %ae %s'
2018-05-17 angle-skia-autoroll Roll third_party/externals/angle2/ f299a378f..0e1c158ed (2 commits)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: I7366fdc87377283707c45a6bd0141a71f88556b8
Reviewed-on: https://chromium-review.googlesource.com/1063559Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559450}

It was only used in some tests, none of which actually cared about the
controller states, only about the set of registered types.

Bug: 839834
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia4f69ad3abfeeefc8bad9fc9124dfbd195e6725b
Reviewed-on: https://chromium-review.googlesource.com/1061471Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559449}

This is a follow-up CL for https://crrev.com/c1061274.

Add a test case, and update the comment to explain why we need to make sure assignment
is recalculated before iterating assigned_nodes.

TBR=kochi,rakina

Bug: 776656,843069
Change-Id: I3707f6fd93b6f1709b34773a63f8ca91be67e824
Reviewed-on: https://chromium-review.googlesource.com/1062990Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559448}

Somehow service workers are timing out and I don't see what could have
changed. We are timing out in "Allocate Process" before a Start mesage
is sent to the renderer, which suggests some thread on the brower
process is hung somewhere. Try to get more info by generating a crash
report which will also let us see if any unusual command line flags
or features are enabled.

Bug: 843456
Change-Id: Ia4f8d8506e02ef0f0166530172ef033c300a1494
Reviewed-on: https://chromium-review.googlesource.com/1063571Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559447}

This cl adds an initial display fetching support for Ozone/Wayland:
  - First, DesktopScreenOzone adds itself as an observer to a
    NativeDisplayDelegate, which has its own implementation based on
    a platform.
  - Then, DesktopScreenOzone initializes NativeDisplayDelegate and,
    in case of WaylandNativeDisplayDelegate, WaylandNativeDisplayDelegate
    sets itself as an observer to a PrimaryOutput.
  - Once PrimaryOutput creates current display's snapshot and current mode
    , (WaylandNativeDisplayDelegate::)OnOutputReadyForUse is called,
    WaylandNativeDisplayDelegate notifies its observers (DesktopScreenOzone
    in this case) through OnConfigurationChanged method.
  - Then, DesktopScreenOzone calls NativeDisplayDelegate::GetDisplays,
    which returns a vector of display snapshots through a callback, and
    DesktopScreenOzone::OnHostDisplaysReady creates a display::Display
    with parameters it gets from display::DisplaySnapshot.

Preliminary support for mode changes has also been added. If we take a
normal run-time browser flow, WaylandOutput::OutputHandleMode can be
called on every display change (it can be a resolution change, a refresh rate
change and etc). Once |current_mode_| is updated, OnOutputReadyForUse is
again called and DesktopScreenOzone fetches the newest list of displays,
which is then used to create a display::Display with the ids provided.
As a result, ProcessDisplayChanged is called and stored display::Display
updated by checking its id.

Note: it's impossible to run Wayland without --in-process-gpu flag
as long as support for gpu process communication with wayland
connection is not in place yet, but it's under development and
going to be pushed soon.

To try this, compile with the following gn args
use_ozone = true
ozone_platform_wayland = true

TEST=./out/Debug/chrome --ozone-platform=wayland --in-process-gpu

Bug: 578890
Change-Id: Ia0f61f1af24eeb46433d22cf31f69396325e4c78
Reviewed-on: https://chromium-review.googlesource.com/1051829Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#559446}

TBR=haraken

Bug: None
Change-Id: Icaa75e99a1804390f12fead5e5ece9c46e68a718
Reviewed-on: https://chromium-review.googlesource.com/1063519Reviewed-by: Gyuyoung Kim <gyuyoung.kim@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559445}

-As EG synchronization is disabled, manually waits until payment screen
 shows.
-Clears profiles before starting each test, so that each test starts with
 a clean state.

Bug:833562

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4e21537e91e57a7f38ff3715f4999ad73481eb56
Reviewed-on: https://chromium-review.googlesource.com/1059654Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559444}

BUG=762641
TBR=alemate@chromium.org

Change-Id: I89bc10d563c0a33c5b804a15ba06581f813aac58
Reviewed-on: https://chromium-review.googlesource.com/1063651Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559443}

This is a reland of 55d941b0
This CL has no diiferences from it. http://crrev.com/559440 should
fixed a build issue on non-goma Windows.

Original change's description:
> Reland "Remove unnecessary include_dirs settings from BUILD.gn in Blink"
>
> This is a reland of 7f4f1890
> This CL has no differences from it.  http://crrev.com/559003 should
> fix a build issue.
>
> Original change's description:
> > Remove unnecessary include_dirs settings from BUILD.gn in Blink
> >
> > Now we have no Blink-relative #includes.
> >
> > Bug: 836071
> > Change-Id: I33bbab6340def20dcd07a72fcc5d1a4d08254a1b
> > Reviewed-on: https://chromium-review.googlesource.com/1058876
> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> > Commit-Queue: Kent Tamura <tkent@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#558629}
>
> TBR=peria@chromium.org
>
> Bug: 836071
> Change-Id: I452a61199a31b6a6a617e2985331ab6a034c6c7c
> Reviewed-on: https://chromium-review.googlesource.com/1059636
> Reviewed-by: Kent Tamura <tkent@chromium.org>
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Commit-Queue: Kent Tamura <tkent@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#559018}

TBR=peria@chromium.org

Bug: 836071
Change-Id: Iade8aebc34d13ac08b257e2c7451071064b8474b
Reviewed-on: https://chromium-review.googlesource.com/1063411Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559442}

Fix check in 'Manage with Drive' action, and add test to ensure it
doesn't regress again. Also added getLastVisitedUrl() in util.js to get
the URL opened by the Manage in Drive button.

Bug: 831480
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I382a662607103d60a5c9a7c58643eff0f9f62106
Reviewed-on: https://chromium-review.googlesource.com/1058884
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559441}

Change it from root_build_dir to "//".
/FI flag argument produces #include virtually, and there is no
reason to use a path relative to root_build_dir, which is
//out/$config typically. We should use a path relative to the
repository root as usual.

This is a preparation to remove "." from include_dirs defined in
the BUILD.gn.

Bug: 836071
Change-Id: I19351b752957e85f9f1aee9fc981e0a8d0f31ff8
Reviewed-on: https://chromium-review.googlesource.com/1063510Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559440}