GitLab

The imprecise logging caused confusion in the interpretaion of at
least one user report.

Change-Id: I50a80ef6e322072ae9143f11e6e86b314d1fb263
Reviewed-on: https://chromium-review.googlesource.com/c/1349771Reviewed-by: Cheng-Yu Lee <cylee@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611237}

Bug: 872904
Change-Id: Ia376f6beb1072d46189954decf7696cb980b4639
Reviewed-on: https://chromium-review.googlesource.com/c/1340364Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611236}

R=cmasso@chromium.org

Change-Id: Ida42b8e93e569176ddfdaeeb961d3dd50b4e6fd0
Reviewed-on: https://chromium-review.googlesource.com/c/1352435Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611235}

Avoids having additional high-frequency post tasking for no-op tasks in
the background.

To keep track of when to stop animating without an AnimationEnded
callback, we keep track of the last-drawn animation state. This also has
the side effect of allowing us to avoid repainting the loading-progress
bar if would paint the same pixels we drew last time. This should avoid
a lot of repaints for slow-loading sites.

This also ends up fixing backwards-jumping indicators. Probably because
the logic for clamping the loading-progress timer got easier.

Bug: chromium:907044, chromium:905020, chromium:905452
Change-Id: Ic83748bad83115ef2283c881a89ed65e3d3938ab
Reviewed-on: https://chromium-review.googlesource.com/c/1346831Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611234}

Bug: 902349
Change-Id: Ibd685911d52ae19c62b06caf47688abad081d243
Reviewed-on: https://chromium-review.googlesource.com/c/1333760
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611233}

Change-Id: Icfd4b43ed64252e0530ee033fc06f12186bcc2b6
Reviewed-on: https://chromium-review.googlesource.com/c/1347059Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611232}

Previously "CorruptPolicyExtensionDetected" was reported every time
when policy extension was corrupted even if it's already scheduled
to be reinstalled. So it might've lead to multiple
"CorruptPolicyExtensionDetected" events per one
"CorruptPolicyExtensionResolved" event.
Now when new entry is added to |expected_policy_reinstalls_| map,
one metric is reported, when removed - another, so it's more 1:1.

Change-Id: I2cb4ad2ae043f4ad01d061c8eb63614a24db0a4a
Reviewed-on: https://chromium-review.googlesource.com/c/1335604
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611231}

Start using disk cache directory for default headless profile.

Bug: 882431
Change-Id: I1790a58fa2da6cb0fd114897d082e289d7a01bc5
Reviewed-on: https://chromium-review.googlesource.com/c/1350881Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611230}

This CL removes macro usage from /ios/chrome/browser/reading_list.

This CL was uploaded by git cl split.

R=olivierrobin@chromium.org

Bug: 589840
Change-Id: Ia0b05a38e3daa883a1ebb3d2255df84d9f30eb45
Reviewed-on: https://chromium-review.googlesource.com/c/1351953Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611229}

The current 1024-bit keys do not work with openssl 1.1.1

BUG=907677

Change-Id: I9abce240d09fc0baf6ea567d71f37c48787b3ceb
Reviewed-on: https://chromium-review.googlesource.com/c/1347201Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611228}

Move the ripple animation handler to a new animations file, and move
common helper functions into a new utils file.

This enables us to add ripple animations to the edit custom link dialog
buttons.

Bug: 874201
Change-Id: I5e3d72bf3fa282faf0068122f1a660e8ad72bab3
Reviewed-on: https://chromium-review.googlesource.com/c/1347776
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611227}

BUG=908458

Change-Id: I14d61f5fd122c77e0e46d170d7930fc52205937d
Reviewed-on: https://chromium-review.googlesource.com/c/1351329Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: yuli <yuli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611226}

Change-Id: I1e43c4b3b66fe1f90ab110dbf7299dce9813288e
Reviewed-on: https://chromium-review.googlesource.com/c/1349870
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611225}

If language is changed, this change should be performed before rest
of OOBE configuration is applied (e.g. input method value can be only
relevant for new language, so setting it before language change is
resolved would not be possible)

Bug: 854101
Change-Id: Ib7e7db058470683d649bfb775c65276141e226fc
Reviewed-on: https://chromium-review.googlesource.com/c/1350892
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611224}

As discussed in the review for CL1326151, there is no need to do
this explicitly on dealloc() since the std::unique_ptr for this
object will be destroyed as part of the deallocation. Thus, we're
removing the call to .reset() to prevent further confusion.

Bug: 903262
Change-Id: Iec51c701501de948d32ce557ca37a7850db7b107
Reviewed-on: https://chromium-review.googlesource.com/c/1337611Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#611223}

+ Change buttons to ButtonCompat
+ Change button bar to DualControlLayout so that it is more consistent
  with other button bars
+ Adjust padding to match the current spec

Bug: 856244
Change-Id: I8bd1d211a27fa47769286cf565a627da65657f57
Reviewed-on: https://chromium-review.googlesource.com/c/1351790Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611222}

Disabling this feature is no longer a valid working state as it breaks
the autofill keyboard accessory.

Bug: None
Change-Id: Ic5bb57e420567c690aff36245cb47b2c508a15e0
Reviewed-on: https://chromium-review.googlesource.com/c/1305239
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611221}

- Turns on UAv2 by default,
- copies test expectations from the virtual to main
  test suite, and
- changes few test expectations.

Intent to Ship discussion: https://groups.google.com/a/chromium.org/d/msg/blink-dev/nkTDR8AUlwM/xsPcojA5BAAJ

Bug: 904991
Change-Id: I213b5a723ffe08b859170ae8dfb539eee84ffaf3
Reviewed-on: https://chromium-review.googlesource.com/c/796938Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611220}

Bug: 890531
Change-Id: Iacf0199ed5b41dce8557d8f9daaf79ad8fa29c27
Reviewed-on: https://chromium-review.googlesource.com/c/1351578Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611219}

This CL removes macro usage from /ios/chrome/browser/metrics.

This CL was uploaded by git cl split.

R=olivierrobin@chromium.org

Bug: 589840
Change-Id: I47b0535e525d6ad8c442f0ac2953324d979c1cd2
Reviewed-on: https://chromium-review.googlesource.com/c/1351075Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611218}

There was a recent issue where this was happening due to cache bugs.
This is something that should never happen, so it would be nice to have
it be more noisy when it fails.

Bug: 906510
Change-Id: Ie4e8aaf415c491d4ba192d1b57c115cec7d81ca9
Reviewed-on: https://chromium-review.googlesource.com/c/1351386Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611217}

https://dawn.googlesource.com/dawn.git/+log/0da9494a4fe9..0bd32409b7b7


git log 0da9494a4fe9..0bd32409b7b7 --date=short --no-merges --format='%ad %ae %s'
2018-11-27 cwallez@chromium.org Run mac-dawn-rel on the CQ


Created with:
  gclient setdep -r src/third_party/dawn@0bd32409b7b7

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:901830
TBR=cwallez@chromium.org

Change-Id: I97cee36d91fb5a9fc35f414af92e9066b6ab9e0f
Reviewed-on: https://chromium-review.googlesource.com/c/1352238Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611216}

Prevented ChromeOS-specific funcionality in seat.cc
from compiling for other platforms. To be used for EXO on cast shell.

Added shell_surface_util, containing utility functions previously
included in shell_surface_base, needed for exo on cast.

TBR=yusukes@chromium.org

Bug: 896710
Test: Run exo_unittests and unit_tests on ChromeOS build.
Change-Id: I3d66b09a6e236e731913ecc77cd0fdbe7937e74a
Reviewed-on: https://chromium-review.googlesource.com/c/1327562
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611215}

Ran `tools/clang/scripts/upload_revision.py 346388 5`.

Bug: 870331
Change-Id: Id09c926a34194487757e641283f63fb63a614436
Reviewed-on: https://chromium-review.googlesource.com/c/1351029
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611214}

When default Email is available (defined as email used to start
Autofill Assistant) it is used to change the order of Profiles inside
Payment Request.

The Profiles containing this email will be displayed on top,
making them a default choice.

Bug: 806868
Change-Id: Iae54abcf009a563a120a6afa09ef02187a82abd8
Reviewed-on: https://chromium-review.googlesource.com/c/1350955
Commit-Queue: Lukasz Suder <lsuder@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611213}

This reverts commit 912050e1.

Reason for revert: Fuchsia SDK believed to be the cause of these failures; speculatively reverting to re-enable the tests to evaluate.

Original change's description:
> Disable all tests in FrameImplTest.
>
> Almost all have been reported as flaky. Disable all to avoid having
> reports coming in from whichever subtest was not reported yet. Caused a
> lot of red jobs on the Fuchsia x64 bot.
>
> TBR=wez@chromium.org
>
> Bug: 907804
> Change-Id: I2fb4da79bf1e4251e14900ef4cabb890b7b3380d
> Reviewed-on: https://chromium-review.googlesource.com/c/1349315
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Commit-Queue: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610580}

TBR=wez@chromium.org,futhark@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 907804, 907859, 907717
Change-Id: I72103faff6457a93136925afdab9d7f003061369
Reviewed-on: https://chromium-review.googlesource.com/c/1351100
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611212}

This CL removes macro usage from /ios/chrome/browser/download.

This CL was uploaded by git cl split.

R=sdefresne@chromium.org

Bug: 589840
Change-Id: I60b22d3a7b65e614f6109a5d2a79baabe986724f
Reviewed-on: https://chromium-review.googlesource.com/c/1351076Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611211}

Now that r8.jar is checked in, this makes more sense.

Bug: 872904
Change-Id: I629c830ec070452688e4eb08dbd02b4190232134
Reviewed-on: https://chromium-review.googlesource.com/c/1349753Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611210}

message

Bug: 866686
Change-Id: I15d6c4fdb7bd9f609a0573f765393544b56f605b
Reviewed-on: https://chromium-review.googlesource.com/c/1347574
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611209}

This flag is user-facing, should not have an expiration date.
See [1] for an example.

[1] https://developers.google.com/web/tools/chrome-devtools/ui#experiments

Change-Id: I287a7707d3f896515ea65481e376df5ad16251fb
Reviewed-on: https://chromium-review.googlesource.com/c/1351603Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611208}

This is a reland of a7291ad3

Original change's description:
> Move audio service to new service APIs
>
> Migrates audio service and related test code away from using deprecated
> service APIs (ServiceContext, ServiceTest, etc) in favor of better ones.
>
> Bug: 891780,906239
> Change-Id: Iba655baf597fabd85fc0151d89cd32cb4b92578f
> Reviewed-on: https://chromium-review.googlesource.com/c/1345548
> Commit-Queue: Ken Rockot <rockot@google.com>
> Reviewed-by: Olga Sharonova <olka@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610373}

TBR=kinuko@chromium.org
TBR=olka@chromium.org

Bug: 891780, 906239
Change-Id: I300692ee9b4e6b26a9957944b38ddf8f468b165a
Reviewed-on: https://chromium-review.googlesource.com/c/1348629
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#611207}

This CL adds a float value scroll_update_delta_ for GSU deltaY and
a time component for last coalesced event to latency_info.
And also adds implementation for Event.Latency.Scroll.AverageLag
metrics, which measures an average distance represents the lag
between finger movement and page scroll.

detail of the metric see the design doc:
https://docs.google.com/document/d/154jddNiKtxELBvrjLz9v6A7sA1J3iwQQzySHgtY12Oo/edit?pli=1#heading=h.zf3l6o8vecuv

Change-Id: I64adef4ebf107185ad4fd1eeec276ea527e1c5ef
Reviewed-on: https://chromium-review.googlesource.com/c/1239260
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611206}

The test PasswordManagerTest.ReportMissingFormManager executes a
number of test-cases, and for each test-case, two runs, one with the
old FormData parser, one with the new one.

Each test-case can leave the PasswordManager in a state not expected
by the next case, so it is good to reset the PasswordManager at the
beginning of each run.

This happens as part of setting the flags for the new parser
automatically, but does not happen when the old parser is used. Thus,
the tests failed if for each test-case the old parser was run first.

This CL fixes that by ensuring that the PasswordManager is reset
before each run.

Bug: 907794

Change-Id: Id3ec0acf34d1a9d7b3530edd3eec0d6351fa4e1d
Reviewed-on: https://chromium-review.googlesource.com/c/1350899
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611205}

Bug: 907180
Change-Id: Iad8aafe80e76d7f7ebfafacbccfdda48e1c4bbf5
Reviewed-on: https://chromium-review.googlesource.com/c/1344902
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611204}

Enqueue navigation events and send once a dynamic module is loaded
even if there is no active CCT session.

Bug: 902298
Bug: 902294
Change-Id: I3ab131b9ab78d4acf48f9959b5232fb6370a9019
Reviewed-on: https://chromium-review.googlesource.com/c/1349694
Commit-Queue: Anna Malova <amalova@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611203}

This converts the V1 unit test, checking pasteboard access in sandboxed
processes, to the V2 sandbox.

Bug: 902597
Change-Id: Id11e2c597a55f9e66f45d1edf6b7c7bcb8396f57
Reviewed-on: https://chromium-review.googlesource.com/c/1327545
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611202}

Update BaseSetOperators::insert() (and the related method
APIpermissionSet::insert()) accept a unique_ptr as a parameter rather
than a raw pointer. This makes it significantly more clear that
ownership is taken as a result of the method call.

Update all call sites appropriately.

Bug: 907661
Change-Id: I08568711a01d7a371343dc9137aefedf86d43c7a
Reviewed-on: https://chromium-review.googlesource.com/c/1347621
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611201}

Change-Id: Ic9bbedc769612b720ea6667a3736a29bc8b0c7c7
Reviewed-on: https://chromium-review.googlesource.com/c/1345412Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611200}

Bug: 842548
Change-Id: I42a81f539d57ec244f2583bbc8bda9126b11256e
Reviewed-on: https://chromium-review.googlesource.com/c/1351197
Commit-Queue: Shu Chen <shuchen@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611199}

This CL removes macro usage from /ios/chrome/browser/passwords.

This CL was uploaded by git cl split.

R=vabr@chromium.org

Bug: 589840
Change-Id: I4269a5dcd85ae4e00d275c30fd40b622cc03a1ba
Reviewed-on: https://chromium-review.googlesource.com/c/1351951Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611198}