- 06 Jun, 2018 40 commits
-
-
Sylvain Defresne authored
With https://crrev.com/c/1070158, base::Bind() supports block so convert uses of base::BindBlockArc() to instead use base::BindOnce() or base::BindRepeating(). Bug: 701275 Change-Id: I0a10526bd47c8c52b2cfc980bdc9d43e4883c18e Reviewed-on: https://chromium-review.googlesource.com/1087061Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564869}
-
Jonathan Backer authored
Removes some #ifdefs from gpu_info_collector.cc to try to collect info from a GL context during GPU process initialization. If this change sticks, we can unroll some of the OSX specific changes that were made to avoid this early code path (e.g. in components/viz/service/gl/gpu_service_impl.cc) Bug: 847543 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id52dcddfb3980f3b3aee52021ebe6c9981ad150e Reviewed-on: https://chromium-review.googlesource.com/1087582Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#564868}
-
Michael Lippautz authored
- Add unit tests. - Move more UMA histograms into common bottleneck. Bug: chromium:840789 Change-Id: Ia51a60cb424fe29eb5f4590f58f5454daf16b6bb Reviewed-on: https://chromium-review.googlesource.com/1082133 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#564867}
-
Alexandr Ilin authored
This CL changes the signature of content::PreresolveUrl() so that the method returns a net::HostResolver::Request object to a caller instead of holding it inside of the callback state. It is done to guarantee that there won't be hanging requests after a caller is shut down. There are only two callers of this method: chrome_browser_net::Predictor and predictors::PreconnectManager. They become responsible for keeping Request objects alive. Bug: 845648 Change-Id: Ie057cde65288341b14813d4df4d7d90a02f588b6 Reviewed-on: https://chromium-review.googlesource.com/1080818 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#564866}
-
Hajime Hoshi authored
To decouple the relationships between EventQueue(Impl) and ExecutionContext, make each user have their own EventQueueImpl object. For ContentSecurityPolicy class, I'll make a follow-up CL later. Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# Bug: 846618 Change-Id: I3177bf1e69ef1db61cb8056c2309e93ad5539b94 Reviewed-on: https://chromium-review.googlesource.com/1088534 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Martin Kreichgauer authored
This is a reland of 7acb4716 with a fix. In the original CL, CredentialMetadata::HmacForStorage wrapped HMAC::Init(base::StringPiece) in a DCHECK. In non-debug this resulted in HMAC::Sign getting called on an unintialized HMAC instance. Change-Id: Ibf6e34dc381812254aaed5c20a83eb6a28d43246 Reviewed-on: https://chromium-review.googlesource.com/1087315Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#564864}
-
Peter E Conn authored
Bug: 844043 Change-Id: I8a24df699cf697762cdbcc3ca9259f839c04d212 Reviewed-on: https://chromium-review.googlesource.com/1085053Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#564863}
-
chrome://appsRamin Halavati authored
chrome://apps page is not supported in guest mode, and currently if navigated to, nothing happens which is felt as a bug to the user. This is changed to redirecting to a page saying that apps is not available to guest users. Bug: 607508 Change-Id: I14880f885eb19279429736a5b3777516435c444d Reviewed-on: https://chromium-review.googlesource.com/1087960Reviewed-by:
-
Pavol Marko authored
If the device is in factory ping embargo period, or the factory ping embargo end date is invalid (too far in the future), attempt to synchronize the system clock with the network before continuing, re-checking if the device is still in the factory ping embargo period after the clock has been synchronized. The system clock sync has a timeout of 15 seconds, if no sync could be reached by then, assume that no Initial Enrollment should be done. Also add an UMA histogram to track if Initial Enrollment was required, and if not, why not. Bug: 839353 Test: browser_tests --gtest_filter=WizardControllerDeviceState* Change-Id: I9094dd19f141e8a4dbdb8dcdcd16ef90d1ec2af5 Reviewed-on: https://chromium-review.googlesource.com/1076233Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#564861}
-
Colin Blundell authored
APIs are now in place that allow ProfileSyncServiceStartupTest to use identity_test_utils.h, which is preferable as that has a direct conversion path to the long-term IdentityTestEnvironment test infrastructure. Bug: 796544 Change-Id: I2850f950353849a50638195bd2c4276089b011a3 Reviewed-on: https://chromium-review.googlesource.com/1085463 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
This is a pure refactoring. Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# Bug: 846618 Change-Id: Ied94509c9d5af1a937142addebbc414da9c0e95f Reviewed-on: https://chromium-review.googlesource.com/1088449Reviewed-by:
-
Hitoshi Yoshida authored
With works around terminate GC, we no longer need to run additional GCs at thread termination. This CL removes such test only behavior and cleans up code of paths to it. Bug: 590802 Change-Id: Icf17118744c785a5a6d0f3e8e6101da1cf9ad3bc Reviewed-on: https://chromium-review.googlesource.com/1088536Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#564858}
-
Sergio Villar Senin authored
The current Grid data structure is mostly generic but it still depends on a grid representation based on Vectors of Vectors. In order to allow future memory efficient representations we should remove that dependency. This CL moves all the vector dependent code to a new class named VectorGrid. Apart from that, GridIterator was moved to Grid and also refectored as we would need to provide different implementations of the iterator depending on the data structure used for grids. Last but not least, in order to limit the amount of changes in the clients of these two interfaces, a couple of factory methods were added to create both Grid and GridIterator objects. These Create() methods are the ones instantiating the specific Grid (and GridIterator) representations. R=jfernandez@igalia.com, rego@igalia.com Change-Id: I59d9f8df93c3c65390a0f22aaf8064359f9248f4 Reviewed-on: https://chromium-review.googlesource.com/1075331 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#564857}
-
Colin Blundell authored
As a convenience step in the porting of the IdentityProvider interface and implementation away from OAuth2TokenService, this CL eliminates FakeIdentityProvider. This change reduces the number of IdentityProvider implementations to two and will avoid duplication of code between FakeIdentityProvider and DeviceIdentityProvider when IdentityProvider and ProfileIdentityProvider are later ported away from knowledge of/dependence on OAuth2TokenService. The change is straightforward: The remaining tests that use FakeIdentityProvider don't use any of its custom hooks for testing. All that was necessary was to let ProfileIdentityProvider have a test constructor that allows for its SigninManager instance to be null. This avoids the need for these tests to construct a FakeSigninManager(Base) instance, which is a pain to do. Once ProfileIdentityProvider is converted to take in IdentityManager, this test constructor can go away, as it is a breeze to construct IdentityManager in a testing context via IdentityTestEnvironment. Bug: 809452 Change-Id: I2f699d6776542626800e59bda731579338076077 Reviewed-on: https://chromium-review.googlesource.com/1087054Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#564856}
-
Colin Blundell authored
This CL removes the callthrough from SyncAuthManager::OnPrimaryAccountSet() to SyncAuthManager::OnRefreshTokenAvailable(). The former currently calls through to the latter when a refresh token is available. However, that call will be a no-op. OnRefreshTokenAvailable() does two things: 1. If the primary account is updated with an invalid refresh token, it takes action to stop sync. 2. If the primary account is updated with a valid refresh token, it checks if there is a need to fetch a new access token and fetches one if so. Neither of these are relevant when SyncAuthManager::OnPrimaryAccountSet() is invoked: - The flow resulting in 1 is started only in the context of there already being a primary account. - For 2, there will by design never be "a need to fetch a new access token" at the time of SyncAuthManager::OnPrimaryAccountSet(): at the time that the primary account is set we don't know whether Sync actually wants to start, e.g., the user might have explicitly disabled it. The initial access token fetch occurs as follows: The SyncEngine tries to connect to the server, but has no access token, so it ends up calling OnConnectionStatusChange(syncer::CONNECTION_AUTH_ERROR) which in turn causes SyncAuthManager to request a new access token. The sum of this reasoning is that SyncAuthManager::OnPrimaryAccountSet's callthrough to SyncAuthManager::OnRefreshTokenAvailable() is a no-op and can be removed. The concrete motivation for this CL is to facilitate porting this class to observe IdentityManager for token-related events. Bug: 825190 Change-Id: I77964296957facf22c60b2a62775c034af9e47a0 Reviewed-on: https://chromium-review.googlesource.com/1087964 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Shanmuga Pandi M authored
This patch removes the extra form data added, if "value" attribute present with non-empty value for <input type='image'> Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hp1_-1tgvDs Bug: 753746 Change-Id: I6a4987a7fb5751b75ff2472f594063876ec076a1 Reviewed-on: https://chromium-review.googlesource.com/1086953 Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#564854}
-
Jose Dapena Paz authored
Fix build error in GCC due to an ambiguous auto resolution. An initializer list is not compatible with an std::vector in a ? : sequence, so it will fail to resolve the subsequent auto statement: ../../components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc -o obj/components/subresource_filter/content/browser/browser/subresource_filter_safe_browsing_activation_throttle.o ../../components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc: In member function ‘void subresource_filter::SubresourceFilterSafeBrowsingActivationThrottle::NotifyResult()’: ../../components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc:141:26: error: operands to ?: have different types ‘std::vector<subresource_filter::SubresourceFilterSafeBrowsingClient::CheckResult>’ and ‘const std::initializer_list<const subresource_filter::SubresourceFilterSafeBrowsingClient::CheckResult>’ consider_redirects ? check_results_ : last_result_array; ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc:145:37: error: unable to deduce ‘auto&&’ from ‘check_results_to_consider’ for (const auto& current_result : check_results_to_consider) { ^~~~~~~~~~~~~~~~~~~~~~~~~ The solution is explicitely setting the type instead of using auto, so the resolution is not ambiguous. Bug: 819294 Change-Id: Ieae11f751569ffe15a5db49833153478eed4cbcb Reviewed-on: https://chromium-review.googlesource.com/1087958 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by: -
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=muyuanli@google.com Change-Id: Icbe3ca6756388b0d46f128ba773ce1c5bc80ab3e Reviewed-on: https://chromium-review.googlesource.com/1087945Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#564852}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/79725d3..c27967f git log 79725d3..c27967f --date=short --no-merges --format='%ad %ae %s' 2018-06-06 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 d197803..0211346 (1 commits) Created with: gclient setdep -r src/third_party/skia@c27967f The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: Ic97180fb1d5ab61e4ce5fa7b422fee5acd1ee041 Reviewed-on: https://chromium-review.googlesource.com/1088588Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564851}
-
Alexander Potapenko authored
TBR=dtapuska@chromium.org Bug: 838769 Change-Id: I3b772a840d382805799cc32d2555ac363bbe4d75 Reviewed-on: https://chromium-review.googlesource.com/1088613Reviewed-by:
Alexander Potapenko <glider@chromium.org> Commit-Queue: Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#564850}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 44914628. With Chromium commits locally applied on WPT: e8832df8 "webrtc wpt: remove test_state_change_event" bf5d61ae "Make fetch-event.https.html faster." be2342db "Worker: Add referrer tests for ES Modules on dedicated workers" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19109 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=foolip No-Export: true Change-Id: Ibd63af6f77103af05b39165387b5a5edcbf088a3 Reviewed-on: https://chromium-review.googlesource.com/1088486 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#564849}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6be71e7..522947b git log 6be71e7..522947b --date=short --no-merges --format='%ad %ae %s' 2018-06-06 vapier@chromium.org cros lint: support linting json files 2018-06-06 vapier@chromium.org lint: start enforcing utf-8 encodings on files 2018-06-06 xixuan@chromium.org Skylab testing: Enable nyan_blaze-paladin retry. Created with: gclient setdep -r src/third_party/chromite@522947b The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:845314 TBR=chrome-os-gardeners@chromium.org Change-Id: I628f5e0e46e0b6ac6377eb0fa151f9f2ad619c89 Reviewed-on: https://chromium-review.googlesource.com/1088587Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564848}
-
Sasha Morrissey authored
Replace DCHECK(!callback.is_null()) with DCHECK(callback) in FakeDriveService Bug: 841659 Change-Id: I88620b26e321a202ef4c73f5aed5cc7d352b9d7a Reviewed-on: https://chromium-review.googlesource.com/1088456 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#564847}
-
Alexandr Ilin authored
NetBenchmarking provides a method to clear network predictor cache. The predictor is migrating to a different service, so this method should clear a different DB. This CL also removes unsafe storing a Profile* on the IO thread. The NetBenchmarking stores weak pointers to predictors instead. Bug: 838949, 623967 Change-Id: Ie73d57555237aea4ebb7be1a324151e5ea190b68 Reviewed-on: https://chromium-review.googlesource.com/1085450 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Initial change done in crrev.com/c/1085458 OmahaService takes a repeating callback as parameter. Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic2e1729b80ca13fca4650384f958f2b4aa83f58c Reviewed-on: https://chromium-review.googlesource.com/1088610 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564845}
-
Colin Blundell authored
IdentityProvider currently provides two observer APIs: 1. IdentityProvider::Observer, which forwards login/logout events 2. An "active account refresh token observer" API, which is a filtered version of OAuth2TokenService::Observer that forwards its events on only for the active account This CL merges the second into the first, thus eliminating clients' having to be OAuth2TokenService::Observers in order to observe active account refresh token events via IdentityProvider. This CL is a step on the path to eliminating visibility of OAuth2TokenService in the IdentityProvider interface and allowing for an IdentityManager-backed implementation of IdentityProvider. Bug: 809452 Change-Id: I002a3b2bd112a12ffcfa576089012461d8e06d11 Reviewed-on: https://chromium-review.googlesource.com/1085447Reviewed-by:
-
Morten Stenshorne authored
Makes them all pass in LayoutNG. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I37756ede232ef3b8fa7c34fa10acf549bbfc0599 Reviewed-on: https://chromium-review.googlesource.com/1087461 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#564843}
-
Alexander Potapenko authored
This reverts commit eb29c355. Reason for revert: broke CrOS MSan bots: crbug.com/850020 BUG=850020 Original change's description: > [VK] Change KeyboardController::GetInstance to never return null. > > Currently, KeyboardController::GetInstance returns null if the keyboard > is disabled. This patch changes it so that |GetInstance| always returns > a valid KeyboardController. > > However, existing code determines whether the keyboard is enabled by > checking whether KeyboardController is null or not. With this patch, > KeyboardController will never be null. So we have to replace the null > checks with calls to KeyboardController::enabled(). In some cases, > calls to KeyboardController::enabled() can be omitted, but we leave > that to a future patch for easier review. > > Bug: 731537 > Change-Id: Ica487e69bae0a589d79c726f131611f0bf934672 > Reviewed-on: https://chromium-review.googlesource.com/1032230 > Commit-Queue: Darren Shen <shend@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564779} TBR=jamescook@chromium.org,yusukes@chromium.org,sky@chromium.org,yhanada@chromium.org,shend@chromium.org Change-Id: I6bf00360e30529ae5f3a1ac4d8a70efbb169e958 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 731537 Reviewed-on: https://chromium-review.googlesource.com/1088567Reviewed-by:
-
Gyuyoung Kim authored
FMP signal has sometimes been used for dismissing a splash screen in some downstream Web Application platforms. But, FMP signal couldn't occasionally be generated or happened a little bit late, then it could cause that the splash screen dismissed a little bit late in the Web Application platforms. This CL is to export FirstMeaningfulPaintCandidate() in order to be used when FirstMeaningfulPaint() doesn't work or generates a signal a little bit late. Bug: 848639 Test: Covered by FirstMeaningfulPaintDetectorTest.FirstMeaningfulPaintCandidate Change-Id: I492d98ef4998e772d293f81b9991a066cb346233 Reviewed-on: https://chromium-review.googlesource.com/1080499Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#564841}
-
Yoichi Osato authored
This patch rebases editing/selection/paint-hyphen.html image expectation. On NG, we don't paint block end hyphen. That's reasonable because no following word after that. Plus, this follows Edge and Firefox. Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I976691f32be99283b526b1daf2dbfbe893fbfd4f Reviewed-on: https://chromium-review.googlesource.com/1088465Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#564840}
-
Yoshifumi Inoue authored
This patch changes |EndOfWordPosition()| to utilize |TextSegments| class to make |EndOfWordPosition()| to work with LayoutNG. This patch also changes |GranularityAdjuster| to handle end of word position in flat tree mapped before start of word position in DOM tree. This patch changes following test expectations: * third_party/WebKit/LayoutTests/fast/text/international/cjk-segmentation.html |TextSegments| provides more context characters to ICU word breaker. * VisibleSelectionTest.expandUsingGranularity * ParameterizedVisibleUnitsWordTest.EndOfWordShadowDOM Due by |PositionInFlatTree| to |Position| conversion. Bug: 778507, 810579 Change-Id: Ie888f8b76e00386bc728a5c647aecf8f33ef7b6e Reviewed-on: https://chromium-review.googlesource.com/1086811Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#564839}
-
Marcin Wiacek authored
Change-Id: Id1e7002a475c43e23abb78f0292709385eaa0356 Reviewed-on: https://chromium-review.googlesource.com/1087907Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#564838}
-
Rayan Kanso authored
The WebApp Manifest spec defines the ImageResource dictionary to represent icon. https://w3c.github.io/manifest/#dom-imageresource This CL changes references to ManifestIcon in blink and mojo to ManifestImageResource. TBR=ortuno@chromium.org Bug: 817445 Change-Id: I75783f8fe1f86edb672a97f6d762f713584b88c9 Reviewed-on: https://chromium-review.googlesource.com/1080794 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#564837}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ff6ae37..6be71e7 git log ff6ae37..6be71e7 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 dgarrett@google.com scheduler_stages: Use --buildbot for all slaves. Created with: gclient setdep -r src/third_party/chromite@6be71e7 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:834076 TBR=chrome-os-gardeners@chromium.org Change-Id: I6ab2ebd812e38b388e484d957c1ee595882872f2 Reviewed-on: https://chromium-review.googlesource.com/1088195Reviewed-by:
-
Kunihiko Sakamoto authored
This patch (temporarily) disables Signed Exchange when Network Service feature is enabled, since cert and CT verification we currently use (via URLRequestContext) is not wired up in the Network Service code path. If Network Service feature is enabled, WebPackageLoader will fail with ERR_INVALID_SIGNED_EXCHANGE and warning message will be shown on devtools. WebPackageRequestHandlerBrowserTest tests this behavior. Layout tests with network service are disabled for now. Bug: 849935 Change-Id: Ic72f9af4d68f55d8557ea0c631020ed871408a70 Reviewed-on: https://chromium-review.googlesource.com/1088270Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#564835}
-
Vaclav Brozek authored
This CL replaces a redundant type mention with 'auto' in form_parser.cc makes the use of trailing ',' consistent and removes unnecessary {} from form_parser_unittest.cc. Bug: 845426 Change-Id: I292af1e436d9b7e98880b3392f0232d88a81e84b Reviewed-on: https://chromium-review.googlesource.com/1087267Reviewed-by:Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#564834}
-
Sylvain Defresne authored
With https://crrev.com/c/1070158, base::Bind() supports block so convert uses of base::BindBlockArc() to instead use base::BindOnce() or base::BindRepeating(). Bug: 701275 Change-Id: Ib251d93328858adfee6ccaddafebaa91124a8a24 Reviewed-on: https://chromium-review.googlesource.com/1087060Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564833}
-
François Beaufort authored
Picture-in-Picture Origin Trial has been cancelled due to multiple risk factors incl. surface layer memory regressions which require investigating, as well as PiP related issues (crashes, resizing, etc.). Bug: 806249 Change-Id: I35d06042e949b6e931e16799ca7abb6f0ff36bfa Reviewed-on: https://chromium-review.googlesource.com/1084451Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#564832}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I0cb4d772c1b45afa092121d0414de239254fa95d Reviewed-on: https://chromium-review.googlesource.com/1088322Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564831}
-
Arthur Sonzogni authored
Bug: 816646 Change-Id: I76f84ba670a69a7e599d43b3dcd0eddde43578fa Reviewed-on: https://chromium-review.googlesource.com/1082397Reviewed-by:
-
