- 15 Nov, 2020 17 commits
-
-
Victor Costan authored
The feature has been on-by-default for quite some time. Bug: 1080597 Change-Id: Iecc4f9d69ff465a29c3e9dccf839165e56121b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535875 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#827625}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605331818-354f114f606d230c1e738fe6417f2e0ad93b6521.profdata to chrome-linux-master-1605354041-d11b800f5d03c7441770fbdbf2620c29609745f4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8b3f3743a4a3ba78298d905b9c5b286271e12545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538802Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827624}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: If8ae6120f88e06d8d9a693106886377160f2f40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538562Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827623}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c82766bd799c..43478ee6935f 2020-11-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic7e523fd8cacc636ec099c5db33e2f2fbd59ff3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538740Reviewed-by:
-
Sorin Jianu authored
Bug: 1147094 Change-Id: I46e84ea854d6719a56885227bf19d4d39d337449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495332 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#827621}
-
Wez authored
Implement the |CreateContextParams.data_quota_bytes| option, to allow a soft-quota to be applied to persisted browsing data. If specified the quota is treated as the "total disk space" of the /data volume, and used to report total & free disk space amounts in SysInfo. Since the platform does not provide native quota, nor free-bytes metrics from filesystems, this is implemented by calling ComputeDirectorySize() to approximate the "used disk space". Bug: 851734, 1071393, 1148334 Bug: b/154204041 Change-Id: Iab982202490080ed9942a7a1b16c62aee5c24cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537698 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827620}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011140600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/rTSxyOBRhg8Kuak4SK_kmsuxt14L_08GfLdW4Vm5OFMC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I22cf872aa2f350857e15d60e769b9b200bd13462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538803Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827619}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0958085d644d..a7106a5f7735 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ia237f7b1dc079d283fdeabc792dc83bca3c2e1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538738Reviewed-by:
-
Liquan (Max) Gu authored
Changes: * Simplified onCompleteHandled::run to be onCompleteHandled * Removed CPRService.mRequestShipping * Limited the access modifiers - MinimalUiCoordinator#showCompleteAndClose - PUiService#onPaymentRequestUiClosed, #onBottomSheetShown - WebPaymentIntentHelperTypeConverter - remove PRService#resetWaitingForUpdatedDetails, setUserGestureShow, setCurrentPaymentRequestShowing, getHasNonAutofillApp - corrected @link PaymentResponseRequesterDelegate - inlined PRService#onError Change-Id: Id1af3182bb887fde6142967638adbf99022cd891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536984 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827617}
-
Nick Harper authored
Change-Id: I55a95dd1e4242a55c182b10b9013d03cb0a179ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528300 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#827616}
-
Wan-Teh Chang authored
Peter Kasting suggested the new name have_parsed_current_data_ in https://crrev.com/c/2530221. Change-Id: I8f96f40fc09206f74ffb2ce4815b3a10230ba7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538959Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#827615}
-
Jimmy Gong authored
Bug: 1106937 Change-Id: I1764a32135c7eaf1f92353f5c6b55488a5659d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538592 Auto-Submit: Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#827614}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I0ac945f701f61aa35127e3323fc5bd4427fcc670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538894Reviewed-by:
-
Theresa Wellington authored
Add PER_CLASS batching to AppMenuTest.java Bug: 1148968 Change-Id: I4669dee278afc6b253a5bad8f74ad4724dce5f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538423 Commit-Queue: Gang Wu <gangwu@chromium.org> Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827612}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/464aaeb55864..aabde6c88f91 2020-11-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 8ca4561b25dd to e5e961722054 (18 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: I68dbb890b904018cbb52a51f2c0337ea24903b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538934Reviewed-by:
-
Kartik Hegde authored
Network diagnostic routines will use the single-use UdpProber to send data to a particular destination. The primary use case is to send a STUN packet (as defined in RFC 5389) to a STUN server owned by Google and validate that a response is received. BUG=b/172994051 TEST=unit_tests --gtest_filter=UdpProberWithFakeNetworkContextTest.* Change-Id: I0abfb70c04a93bef60d690a64f9d99189267b3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516257 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#827610}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: Ib2dedb995c2a10f9f0656097586c5fdd1acf9b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537062Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827609}
-
- 14 Nov, 2020 23 commits
-
-
Hirokazu Honda authored
Bug: 1000988 Test: video_decode_accelerator_tests Change-Id: Iaad87433aafb98b814e2c716af29728c3bfd604a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440333 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Sreerenj Balachandran <sreerenj.balachandran@intel.com> Cr-Commit-Position: refs/heads/master@{#827608}
-
Hirokazu Honda authored
Bug: 1000988 Test: video_decode_accelerator_tests Change-Id: I4793b44a4fb27ccc91f18a6b79225a455c4f1c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440232 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
Bug: 1000988 Test: video_decode_accelerator_tests Change-Id: Ia637a0873e139a80740912574fc7a1c3d20837c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440231 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
Bug: 1000988 Test: video_decode_accelerator_tests Change-Id: I71cb3591028d58ffe802af4404923daac2ef1ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440230 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
Bug: 1000988 Test: video_decode_accelerator_tests Change-Id: I98b6b19c611c27338227693d6af7a963b28cd70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440332 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605311889-01c8544d12c27e9bf1aec153e89a1523ade38101.profdata to chrome-win64-master-1605322732-f3f9a6c28d3c2189d459e96b0d723f5210a3cdc8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5e5ad73e6a8e84169690974f834ab37aef95f7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538735Reviewed-by:
-
Hirokazu Honda authored
Bug: 1000988 Test: video_decode_accelerator_tests Change-Id: Id8e7c1ee82b20f8978cbe64533dc4b9b970dad58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442213 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
Bug: 1000988 Test: video_decode_accelerator_tests Change-Id: I395de75f8ff56a9e6f151f155b30378f90986e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440728 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
Bug: 1000988 Test: video_decode_accelerator_tests Change-Id: Ie960f84fec7233ef70368153ce2412335efc1be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440380 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
Bug: 1000988 Test: video_decode_accelerator_tests Change-Id: I83123233222398f62b622fcb596f49b1e114f4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442212 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
Bug: 1000988 Test: video_decode_accelerator_tests Change-Id: Iac1ff7be472bf851cf2e0222634e45be716708c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440727 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
Bug: 1000988 Test: video_decode_accelerator_tests Change-Id: I63c824468b53114a8be081a28d2297de7af67417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440726 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
This CL implements an AV1 decoder using VA-API. Bug: 1029212 Test: video_decode_accelerator_tests Change-Id: I3ac9e5602ba4ec8ed16e889e0780d948838c973e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921588 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Fabian Henneke authored
This reverts commit 444aad95. Reason for revert: Tests in Canary confirm that the CL does not achieve the intended improvement of Autofill reliability. Original change's description: > Cancel augmented Autofill session when URL bar loses focus > > Since Android Q, views that are labeled with importantForAutofill=no > can still trigger the augmented Autofill service. If this happens, no > ordinary Autofill requests will be triggered anymore for as long as the > Autofill session remains active. This prevents the user-configured > Autofill service from running on web contents if the user's first > interaction is with the URL bar. > > This issue is resolved by canceling the current Autofill session when > the URL bar loses focus. > > R=dmazzoni@chromium.org, michaelbai@chromium.org > > Bug: 1103555 > Change-Id: If06c15f4c397107c284c4de757f58c3aeb939cf0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302636 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808524} TBR=dmazzoni@chromium.org,michaelbai@chromium.org,yusufo@chromium.org,agrieve@chromium.org,fabian.henneke@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1103555 Change-Id: If9fd24b8153256ec8a08d7dd724141e7e338887b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430861 Commit-Queue: Fabian Henneke <fabian.henneke@gmail.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#827595}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I842a6d24c11ab20108d9cf73a7c60ceebbdd6f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538319Reviewed-by:
-
Hirokazu Honda authored
This CL adds an implementation of AcceleratedVideoDecoder for AV1, AV1Decoder and a few necessary classes for it. They use libgav1 parser and structures. Since libgav1 is built in ChromeOS, AV1Decoder is built for ChromeOS x86 targets only. Bug: 1029212, 1000988 Test: video_decode_accelerator_tests test-25fps.av1.ivf --use_vd Test: av1_decoder_unittest Change-Id: Id9d0be18484006005803ae409e45c2028d44c315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397997 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1c8311278ae8..a15da341200e 2020-11-14 tsepez@chromium.org Split up CFXJSE_FormCalcContext::ApplyToExpansion() 2020-11-14 tsepez@chromium.org Consolidate some common logic in cfxjse_formcalccontext.cpp. 2020-11-13 dhoss@chromium.org Purge every C-style cast of int32_t 2020-11-13 tsepez@chromium.org Add one-pager examples for PDFium initialization. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I7e1ca0f85a39f74b05e3f0baf85e8380460bbf7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538736Reviewed-by:
-
Bartek Nowierski authored
Direct-map would always align up to allocation granularity (<=64kB), but wouldn't properly account for this in the following scenarios: 1) Allocated address space would almost come in a committed state and PartitionDirectMap doesn't uncommit what isn't needed. 2) ReallocDirectMappedInPlace compares slot_size against aligned up map_size to decide whether savings from downsizing justify relocating the allocation. The above problems aren't really an issue with 64kB alignment, but GigaCage on 64-bit changes the game by upping the alignment to 2MB. Now the above issues could become more prominent. This CL fixes these. Change-Id: I9e15d17dcfbe907ca5df8e00a7f77851cdc31e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534370 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#827591}
-
Hiroki Nakagawa authored
This is a preparation for removing webkit-prefixed prerendering events (see https://crbug.com/839030). mojom::PrerepderProcessorClient is used for dispatching the events and will be removed along with the events, so it won't be available for monitoring the connection. After this CL, mojom::PrerenderProcessor is used for monitoring the connection instead of mojom::PrerenderProcessorClient so that follow-up CLs can remove it. The renderer-side endpoints of mojom::PrerenderProcessor and mojom::PrerenderProcessorClient have the same lifetime, so the timing of disconnection is not changed before/after this CL. Another notable point in this CL is to change the ownership of PrerenderProcessorImpl in the browser process. Before this CL, PrerenderProcessorImpl is owned by mojo::MakeSelfOwnedReceiver. After this CL, the processor destroys itself on the disconnect handler. This change is necessary for monitoring the disconnection because mojo::MakeSelfOwnedReceiver doesn't provide any hook point to register the discconnect handler. Bug: 839030 Change-Id: I36a094466690d352e1c149792a345ebdaf8a32d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522725Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#827590}
-
Sunggook Chue authored
This reverts https://chromium-review.googlesource.com/c/chromium/src/+/2459309 Reason for revert: Test, All/SystemWebAppManagerUpgradeBrowserTest.Upgrade/WebApps, failed often. It was indeed test bug that it mistakenly called install operation without waiting uninstall operation. so it ends up with early signal, which try to launch non-existent web app. The original CL exposed this error due to increased uninstall time. The testing bug was fixed now https://chromium-review.googlesource.com/c/chromium/src/+/2503374. note. there is no additional change except merge conflict fix in the chrome_features.*, app_launcher_handlers.cc. Original change's description: > PWA on Desktop Windows: Implement uninstallation via OS settings. > When user uninstall a PWA from Windows Settings or Control, it also > uninstall PWA from browser registrar. > The detailed design spec: > https://docs.google.com/document/d/1XjFYnHXCJt08UsbWrQKw5vLW3_vQumOPrB7A9bpHq_s/edit?usp=sharing > Bug: 957043 > Change-Id: I927213c847033ddf5767679f3d7081d2c6760343 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316848 > Commit-Queue: Sunggook Chue <sunggch@microsoft.com> > Reviewed-by: Phillis Tang <phillis@chromium.org> > Reviewed-by: Ben Wells <benwells@chromium.org> > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814546} Change-Id: I35d7b55b0a70d50c8e326007841977973027dc8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508400 Commit-Queue: Sunggook Chue <sunggch@microsoft.com> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#827589}
-
Fabian Henneke authored
Marks the UrlBar as having Autofill type NONE, which disables both standard and augmented Autofill from triggering when the user interacts with the URl bar. Android Q introduced the concept of a system-level augmented Autofill service that replies to fill requests if the user-level standard Autofill service is unable to, e.g., when the request is triggered on a view labeled with importantForAutofill="no". Once an Autofill session is captured by the augmented Autofill service, the standard Autofill service is no longer invoked until the session ends or the user initiates a manual Autofill request. As Chrome's URL bar is marked not important for Autofill to prevent third-party Autofill services from showing fill UI on it, interactions with it frequently trigger augmented Autofill, which results in the user-configured Autofill service no longer being called on web forms. Moreover, since views representing web form fields are not native Android views, they also lack the context menu action with which the user could perform a manual Autofill request and escape the augmented Autofill capture. With an Autofill type of AUTOFILL_TYPE_NONE, the URL bar no longer triggers any Autofill actions, which prevents this scenario. A side effect is that the manual Autofill action on the URL bar is no longer available. However, as real-world Autofill services were found to offer no fill suggestions when invoked manually on current versions of Chrome, this is only a theoretical concern. Bug: 1103555 Change-Id: Ib4089a33db4c674175ccb5ce381dbd703428237c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522078Reviewed-by:
-
Jacobo Aragunde Pérez authored
The use of up and down to manage focus inside bubbles is managed by FocusManager::ProcessArrowKeyTraversal since https://crrev.com/c/2503988 Bug: None Change-Id: I3a0e0afac38b07080fcbf65231e123b6ef0fa6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537671Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#827587}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I2dea1c9f9ac3d7d5f1fbbcb5490e19c67a7bf900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538584Reviewed-by:
-
