- 31 Oct, 2019 40 commits
-
-
Yang Guo authored
Bug: 1011259 Change-Id: I97cb5b2956e2f847a534356ab66bc5b02cac27e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881552 Auto-Submit: Yang Guo <yangguo@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#711166}
-
Miyoung Shin authored
This CL converts TextSuggestionHost mojom interface client in blink to use BrowserInterfaceBroker. Since TextSuggestionHostAndroid life cycle is managed by RenderWidgetHostConnector, this CL gets its object from RenderWidgetHostViewAndroid to register its binder. Bug: 936482 Change-Id: Iccce03e58d9b79ccc8a5f8c011b8ca58e9ed41ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885866 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#711165}
-
Alexey Baskakov authored
This is a reland of 5a0adcbe Let's exclude Win platform for now. This is a useful finding which requires investigation. Original change's description: > WebApp: Check pixel at the center of the generated icon. > > We generate an icon placeholder using a letter with some solid > background color. > > Let the test check if letter_color is actually presented in the icon. > > This is a follow up test enhancement for the previous CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1888234 > > Bug: 1019102 > Change-Id: I10e196926dff78032dcd8f00e93e24715d1be913 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891816 > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711143} Bug: 1019102 Change-Id: I2d01c2a9f5eb94107a4dfc4fea041bdb18871fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892651 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#711164}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/809ec77893be..9c82eb913f44 git log 809ec77893be..9c82eb913f44 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 bb35bb4e5379..841b01678c49 (4 commits) Created with: gclient setdep -r src/third_party/skia@9c82eb913f44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:None Change-Id: I7d074be24a8e09a7cb5a826d3e65e60575efb3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892554Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711163}
-
Yoshifumi Inoue authored
This patch introduces workaround to check invalid selection for avoiding crash in |ComputeRangeForSerialization()| called by |FrameSelection::SelectedText()|. When selection is none, both selection base and extent should be null. However, we have invalid selection, one of base and extent is null, by some reasons. Background: Bug: 1019152 Change-Id: I38717ede505eebb9c59229d5d2e14d75b50f24a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891819 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711162}
-
Adam Rice authored
Log new histograms Blink.Compression.CompressionStream.Format and Blink.Compression.DecompressionStream.Format indicating the format that was passed to the constructor. Also consolidate format enums into a new one named "CompressionStream" and add a common LookupCompressionFormat() function to convert a string to an enum value. Also put back some copyright headers that had gone missing. Bug: 999091 Change-Id: If77623f7bee7fc78f0996dc10d1bac68c01bb77a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886532 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#711161}
-
Fergal Daly authored
R=rakina@chromium.org Change-Id: I0382e7ac771a43a1fb67a02cb8150118bc2ebf49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892632Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#711160}
-
Yura Yaroshevich authored
Bug: None Change-Id: I1d1483197acf0f3d61c8e747dd860e77d373bdda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888931Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/master@{#711159}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/56981910bb85..0a260d789fe9 git log 56981910bb85..0a260d789fe9 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 rharrison@google.com Refactor file reading code into common utility method (#852) Created with: gclient setdep -r src/third_party/shaderc/src@0a260d789fe9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I78cc3f347958c59ce7e66166f375d53efe00bd01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892011Reviewed-by:
-
Marina Sakai authored
This CL removes macro-generated functions for private properties of CustomElement and replaces them with the new GetSymbol function, which uses an instance of V8PrivateProperty::SymbolKey as a key. Bug: 715418 Change-Id: I0b1a28d2c28a89c6d2b163f1ff2c04c017dc311c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885867Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Marina Sakai <marinasakai@google.com> Cr-Commit-Position: refs/heads/master@{#711157}
-
Joel Hockey authored
Created a new class CrostiniStartupStatus which shows a progress bar and spinner, and adds color and emojis. Full status is shown when the terminal starts and the container is not running. Otherwise no status is shown if the container is already running. TBR=benwells@chromium.org Bug: 1016680 Change-Id: I726d9d721937f74a40bba646339a3e9fd97e5a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888239 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#711156}
-
Mikhail Atuchin authored
If SW was restarted and the same process could be used. Update UIThreadWorkerResponseCallbackWrapper to not store worker_thread_id in it and instead use the correct worker_thread_id per callback returned via CreateCallback. Change-Id: I5caead02f2d45fbac967b9e5d42e0e1ef5d970fc Bug: 1019677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879258 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Auto-Submit: Mikhail Atuchin <atuchin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#711155}
-
Findit authored
This reverts commit 5a0adcbe. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 711143 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzVhMGFkY2JlOGYxZGE2OTlmMDBhMDljODYzMjJhNTU4MDAyZjBhMDYM Sample Failed Build: https://ci.chromium.org/b/8898108792770719008 Sample Failed Step: unit_tests Original change's description: > WebApp: Check pixel at the center of the generated icon. > > We generate an icon placeholder using a letter with some solid > background color. > > Let the test check if letter_color is actually presented in the icon. > > This is a follow up test enhancement for the previous CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1888234 > > Bug: 1019102 > Change-Id: I10e196926dff78032dcd8f00e93e24715d1be913 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891816 > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711143} Change-Id: I7e555cad166437e3d004e77526dad06656d2a2b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892127 Cr-Commit-Position: refs/heads/master@{#711154}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/549325c87e9d..809ec77893be git log 549325c87e9d..809ec77893be --date=short --no-merges --format='%ad %ae %s' 2019-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e1cda3916cee..fda994c63075 (2 commits) Created with: gclient setdep -r src/third_party/skia@809ec77893be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:None Change-Id: I5357d10cd9312d49d4fb1b0455e0f7f817d75b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892066Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |LayoutInline::LinesVisualOverflowBoundingBox| to utilize |NGInlineCursor| instead of |NGPaintFragment| for prepration of migrating to |NFragmentItem|. This patch also gets rid of |InlineFragmentsIncludingCulledFor()| in |NGPaintFragment| because it is called only from |LinesVisualOverflowBoundingBox()|. Bug: 982194 Change-Id: Ic6a1fe3b63c810b09d93edd19786b19a6133979c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888623 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Greg Thompson authored
The ScopedTempDir must outlive anything that holds file(s) open within it; otherwise, it is unable to delete itself. BUG=546640 R=sky@chromium.org Change-Id: I38e4e947e48e1d2b6ac8d72c6bdd59264a2e8885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890435Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#711151}
-
Anand K. Mistry authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/8014da0ebf8c..fc6c45f78316 $ git log 8014da0eb..fc6c45f78 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 amistry system_api: Add D-Bus constants for smbfs IPC bootstrap service 2019-10-24 bgeffon system_api: debugd: add missing SwapSetParameter constant 2019-09-30 louiscollard system_api: Add WebAuthn DBus Interface Protos Created with: roll-dep src/third_party/cros_system_api Bug: 939235 Change-Id: I7a47cee9903d15ac2abeb70883a77a0ea063c55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890398 Auto-Submit: Anand Mistry <amistry@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#711150}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6276f9ca394..26f97a5e96ce Created with: gclient setdep -r src-internal@26f97a5e96ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0523245ef94791e5dd94f6879bb71282794431b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892064Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711149}
-
Hirokazu Honda authored
At V4L2VEA::Destroy(), encoder thread process all the pending tasks. If PumpBitstreamBuffers() is in the pending tasks, Enqueue() is posted and processed after DestroyTask(). That leads |input_queue_| and |output_queue_| are nullptr and causes SIGSEGV. This fixes the issue by posting tasks to encoder_thread_.task_runner() with WeakPtr of this. This makes V4L2VEA not execute any tasks posted to the task runner after DestroyTask() because the WeakPtr is invalidated in DestroyTask(). Bug: 1019437 Test: VEA unittest on guado with dcheck_always_on=true Change-Id: Ie2e43d1dd9c74114cbd0d2b51e260213b60136e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890462 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711148}
-
Alice Boxhall authored
TBR=dtapuska@chromium.org Bug: 1020036 Change-Id: I5add7fa7b57e7ace63e84599ca3b120a71a933a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890463Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711147}
-
Tsuyoshi Horo authored
This class will be used to read partial body data of a web bundle response from server. Bug: 1018640 Change-Id: Ib945b9152527be2dfd2fc43dc1e6ef8fcc09b12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886271Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711146}
-
Gauthier Ambard authored
This CL create the EG2 target for Showcase and also convert the Content Suggestions TestCase. Change-Id: Iee84c298746b1a8da8d455b5214ea61eb5e0ea6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873750 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#711145}
-
Alice Boxhall authored
TBR=sky@chromium.org Bug: 928924 Change-Id: I71b6615a8855bbb76b0807ecd5abb6153441b9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892233Reviewed-by:
-
Alexey Baskakov authored
We generate an icon placeholder using a letter with some solid background color. Let the test check if letter_color is actually presented in the icon. This is a follow up test enhancement for the previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1888234 Bug: 1019102 Change-Id: I10e196926dff78032dcd8f00e93e24715d1be913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891816 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/672707f76e2d..64a3bb93dcea git log 672707f76e2d..64a3bb93dcea --date=short --no-merges --format='%ad %ae %s' 2019-10-31 enga@chromium.org Add DrawCallPerf tests Created with: gclient setdep -r src/third_party/dawn@64a3bb93dcea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I583c7b103c871bd9be5f2a82cbacdc3e5f6d8ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892063Reviewed-by:
-
Eric Willigers authored
If the web app manifest specifies 'standalone' or 'fullscreen', we do not show minimal-ui Back and Reload buttons. We only show the buttons when a web app is being opened in a standalone window, and the manifest requested 'browser' or 'minimal-ui', or failed to specify a display mode. https://w3c.github.io/manifest/#display-modes Not yet implemented: support for the extensions-based implementation of bookmark apps - crbug.com/1014346 Bug: 1007151 Change-Id: I68be5280d2d5cfb1ad1565c9408635a694aad2c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883271 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#711141}
-
Austin Tankiang authored
Also remove WriteOnCacheFile as it is no longer being used. Bug: 1003238 Change-Id: I8cf85264b08b7ed969c2bf88f40b36702810404c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890396 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#711140}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/69a6c2e64544..7677c2ab05a0 git log 69a6c2e64544..7677c2ab05a0 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@7677c2ab05a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I39f57619e6134148b2242ec405d70d4f295cf4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892431Reviewed-by:
-
Michael Spang authored
Updating displays in TestScreen loses the pixel size, which causes later calls to SetDisplayRotation to revert updates of the display size made by TestScreen::OnWindowBoundsChanged. Bug: 1019015 Change-Id: I47d77665102c9500609cfd203740e320ef841af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889295 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#711138}
-
nancy authored
kAppServiceInstanceRegistry is used to checked whether AppService Instance Registry feature is used. The default value is set as disable. When AppService Instance Registry feature is done,the flag will be marked as enable. BUG=1011235 Change-Id: If1fadd8cf1079c59141980c282b8506919252a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890511 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#711137}
-
Manas Verma authored
Changing "fido_eligible_credit_card_id" to "fido_eligible_card_id" to match server field names. Bug: 949269 Change-Id: I932fd907cd18dd5377e1e0b278cec0b936a6c25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891769Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#711136}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/54eda5713da0..6524ae660745 git log 54eda5713da0..6524ae660745 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 tsepez@chromium.org Prevent duplicate string creation in CFWL_ComboBox::AddString() 2019-10-30 tsepez@chromium.org Remove c_str() calls from CXFA_Node::InsertItem() Created with: gclient setdep -r src/third_party/pdfium@6524ae660745 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Idc4e822f8c6b0a99586859d2b84dcbc786dd7275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892391Reviewed-by:
-
Austin Tankiang authored
This code is unreachable now that the legacy drive client is disabled. Bug: 1003238 Change-Id: I08bf70752e98df90a3c78eb8d506337a460fc86a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885859Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
ActivilyLoggerTest creates some GC objects like DOMWrapperWorld which may be related to the global environment. Without running a GC after the test, these objects are kept alive and thus some statistics can show wrong values in the next test. e.g. DOMWrapperWorld::NonMainWorldsExistInMainThread() Bug: 1018970 Change-Id: Ib692c6593b121f187b6d70fa05a109135701b864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890373Reviewed-by:
-
Adam Rice authored
This reverts commit 3bce0223. Reason for revert: This is no longer needed in ToT because it has already been merged and released for M77. Original change's description: > Disable WebSocket connection throttling in the network service > > Permit any number of connect requests to be pending in the network > service. > > Note that per-server WebSocket connection serialisation is still > applied, so this doesn't permit denial-of-service attacks against > servers. > > BUG=1006243 > > Change-Id: I31a10ec3384f32aa34ff0380f22738271bee0160 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829629 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701043} TBR=ricea@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1006243 Change-Id: I195e463ab05461c8246be372378671c9b53a1c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880999Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#711132}
-
Tim Song authored
This CL also adds unit tests for the collapse/expand behaviour for the message center. TEST=manual + new unit tests BUG=1019405 Change-Id: I1189549e41e6f11f2d513c4d041de6e5ac108caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888187 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#711131}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6d4996c3785c..f6276f9ca394 Created with: gclient setdep -r src-internal@f6276f9ca394 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Idac35285153659e16b45c6ed9058cb19c9287a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892352Reviewed-by:
-
Doug Turner authored
Bug: None Change-Id: Ibd6eee35a6d06083464ff9e76af779bf1871499c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874720Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#711129}
-
John Abd-El-Malek authored
This is more aligned with Android style guide. Change-Id: I503748a796e2e5934e92d6ec9c6963907debabbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890824 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711128}
-
Xianzhu Wang authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1873504, we can put tests directly under a virtual directory, no longer needing the extra level of directory. TBR=wangxianzhu@chromium.org Bug: 1014162 Change-Id: I6aad51c4c508a50d274d35acdf9112cc9d809330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892094Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711127}
-
