- 17 Nov, 2020 40 commits
-
-
Jasmine Chen authored
Generates the token for CameraHalServer for it to be used for RegisterServerWithToken. Bug: b/170075468 Test: Build, deploy simplechrome, and verify the server token is generated. Change-Id: If3feaa7c06aa67bfbd478d4d0b5aedf22847ff0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534552 Commit-Queue: Jasmine Chen <lnishan@google.com> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#828211}
-
Alex Turner authored
These two page-level metrics are still useful for tracking ads behavior in Chrome. Bug: 1138426 Change-Id: Ia279c184383197084af2a0b05ea2069795f3485d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542546Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#828210}
-
Robbie Gibson authored
These coordinators were just being set to nil, without stopping. They should be stopped first. Change-Id: If1a1ffb632176c77b9d5d69655f0e9a4f2a3874c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544464Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#828209}
-
Alfonso Castaño authored
This CL introduces a new probe and a new command to set a breakpoint on a particular Trusted Type violation. Design doc: https://docs.google.com/document/d/1rlRtq_Ai0leS9sqlRvoOL5RNc1BR6Q1yAVvLLJFasMA/ Bug: chromium:1142804 Change-Id: I605525db9cba063d6ba583011bbbfbdf02d6b6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517519 Commit-Queue: Alfonso Castaño <alcastano@google.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#828208}
-
Liviu Tinta authored
There is a potential compat issue with making click/contextmenu pointer events. The coordinates (clientX/clientY, screenX/screenY, pageX/pageY, offsetX/offsetY) will be returned as fractional numbers. This is a mitigation plan for the unlikely case of breakage from fractional coordinates. We believe this is unlikely because we have been running a Finch experiment with ClickPointerEvent flag enabled in Canary+Dev for 2 months and there were no related bug reports. Our mitigation plan would allow us to keep click/contextmenu as pointerevents but make sure to return integer instead of fractional coordinates. Bug: 989958 Change-Id: I190010ab65f1e01b58480973660b4823f51a24fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510931 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#828207}
-
ckitagawa authored
Fix a crash that can happen if the compositor client is disconnected or stopped while fetching the proto. Bug: 1148899 Change-Id: Ib8536364e14be1bfdfcfe451bf497cf18be5735a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538113 Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#828206}
-
Swapnil authored
This is a reland of f9ad6770 In the previous commit, the flag was overriden only for Windows. But the flag is set to true in case of MacOS too. Original change's description: > Fix ExtensionPolicyTest.ExtensionRecommendedInstallationMode browsertest > > We check the list of enabled and disabled extensions in > ExtensionPolicyTest.ExtensionRecommendedInstallationMode browsertest. > In Windows, the extension is disabled by default as the user is > prompted before enabling the extension. On other platforms, the > extension is enabled by default. This CL overrides the prompting > flag to false. > > Bug: 1006342 > Change-Id: I1d783a8fc381b50e84e5ba85b5c9f37e58b7a986 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537641 > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> > Cr-Commit-Position: refs/heads/master@{#828093} Bug: 1006342 Change-Id: If01e0d818a2b0a1e0f8704852aee5ac478c301ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544292Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#828205}
-
Ganggui Tang authored
This reverts commit 536b412d. Reason for revert: the test is failing on Linux Chromium OS ASan LSan Tests, crbug.com/1149939 Original change's description: > desks: Speculative fix for crash. > > The previous attempt [1] added checks for whether the starting or ending > screenshot was taken. In the case of the starting screenshot missing, it > would signal the animation to remove some RootWindowDeskSwitchAnimators, > leading to a vector out of bounds. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2506356 > > Bug: 1148607 > Test: added regression test > Change-Id: I7f14df877cb93619a0ca8a85f5d0ad434dda3ad2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536934 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828034} TBR=afakhry@chromium.org,sammiequon@chromium.org Change-Id: I27cc6811a5edd38a56eb82f20752638351e2b2df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544443Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#828204}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c4b2f38f2396..f0f126063145 2020-11-17 tvanderlippe@chromium.org Use TypeScript-authored files in har_importer/ 2020-11-17 tvanderlippe@chromium.org Typecheck layer_viewer/LayerTreeOutline.js with TypeScript 2020-11-17 tvanderlippe@chromium.org Use TypeScript-authored files in webauthn/ 2020-11-17 tvanderlippe@chromium.org Use TypeScript-authored files in settings/ 2020-11-17 tvanderlippe@chromium.org Use TypeScript-authored files in heap_snapshot_worker/ 2020-11-17 tvanderlippe@chromium.org Use TypeScript-authored files in screencast/ 2020-11-17 tvanderlippe@chromium.org Use TypeScript-authored files in console/ 2020-11-17 aerotwist@chromium.org [unit test] Add ZoomManager to environment vars 2020-11-17 tvanderlippe@chromium.org Use TypeScript-authored files in snippets/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1148296 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icf57ad4340eb00e2c711b2b9ba786771b4bc95c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544245Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828203}
-
Rohit Agarwal authored
This CL: a) Restricts Incognito CCT to non-3P apps. b) Modifies the existing tests in order for them to launch the Incognito CCT with this change. c) Adds a new IncongitoCustomTabActivityTestRule that adds module overrides to help with the mocking 1P apps. Bug: 1139293 Change-Id: Ie230858361c915470b4d5ff6042b4d6e1784fe8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536455 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#828202}
-
Xida Chen authored
This CL extends the cc::PaintWorkletInput::PropertyKey to support the native property types. This is needed in order to support composite background color animation, which is described here: https://docs.google.com/document/d/1usCnwWs8HsH5FU_185q6MsrZehFmpl5QgbbB4pvHIjI/edit This CL doesn't change any behavior, because right now only native property uses the PaintWorkletInput. Bug: 1139008 Change-Id: I4e2a7417a982c39106dd28ce43fe7452151e8511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528937Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#828201}
-
Anastasiia N authored
Add kAccountManagementFlowsV2 flag for redesign of account management flows and Account Manager page in Settings. Bug: 1144113 Change-Id: I1a5ee10afc5e51ba426d4330c571e84e44effad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526401 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#828200}
-
Liquan (Max) Gu authored
Before the CL, mSpec, mJourneyLogger were destroyed in CPRService. After the CL, they are destroyed in PRService. This change shares the destructions of the two variables with the WebLayer payment request service. Bug: 1025619 Change-Id: I572f8b5f0cc54963e3f3cd86fa2148ebea9c2541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540746 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828199}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/find_in_page Bug: 1113033 Change-Id: Ia31af39407628ab5c568efcfbe92d9f1297bca50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543544 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#828198}
-
Yifan Luo authored
Bug: 1116418 Change-Id: I9b031a46008557c42121943b0680da5eef8652b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502338Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#828197}
-
Harry Cutts authored
Otherwise one might only find out when OsSettingsManagerTest.Initialization fails during the submit process. Change-Id: I86f2135f3aca46fdad6cab4be7337de211af625d Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542732Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#828196}
-
Sebastien Lalancette authored
Runs only on iOS 13+, and will: - Select a word on a test page, - Tap on "Link to Text", - Tap on the "Copy" activity, - Assert that the expected URL was added to the pasteboard. Test is skipped on iOS 12 due to the activity view not being accessible by EarlGrey. Test is disabled on iPads due to: Bug: 1149603 Change-Id: Ia1011f538e6d2b6aed00a12cccd19df40da13472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530389 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#828195}
-
Roman Aleksandrov authored
Bug: 1144159 Change-Id: I02c5ba9fa2d67755025f364807e4c0e03bba312f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537839 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#828194}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605592392-dc172d915909da26cabde4fc0f34ef46d817ea1e.profdata to chrome-linux-master-1605612997-0b538d267d59602889f3873bf24b3a402bd4dd04.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iba237a12cb4ca4bd2cf26f10b20dc53a40c0a955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544246Reviewed-by:
-
Andrew Shulaev authored
Bug: b/171790119 Change-Id: I00249eab13ecee8163c52f90a91bcaeaa8899a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507651Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Andrew Shulaev <ddrone@google.com> Cr-Commit-Position: refs/heads/master@{#828192}
-
Jan Wilken Dörrie authored
This change unexpires the PasswordImport flag. Bug: None Change-Id: Ie93933f7e12b02f5fc7f9850ae48b433595c3cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542790 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#828191}
-
zhiyuancai authored
This CL records whether users turn on the feature "track prices on tabs" and updates the checkbox on the tab switcher menu. Bug: 1146636 Change-Id: I7dbdddb287a30b47298425eda79778433caa2316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524961Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Cr-Commit-Position: refs/heads/master@{#828190}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=sky@chromium.org Bug: 1145565 Change-Id: I917d2102c2a9d3276355bf395db2a88749effdfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532662 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828189}
-
Karandeep Bhatia authored
Extend expiry of the following histograms: - Extensions.DeclarativeNetRequest.ReadDynamicRulesJSONStatus - Extensions.DeclarativeNetRequest.UpdateDynamicRulesStatus - Extensions.DeclarativeNetRequest.RulesetReindexSuccessful BUG=1149533, 1149532 Change-Id: Id8bb35c0ece810b5c8cadd9f57eb14559cdbebc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541669Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#828188}
-
Liquan (Max) Gu authored
Changes: * De-dups the not-show error handling for disconnectForStrictShow and disconnectIfNoPaymentMethodsSupported by onShowFailed(). Behaviour changes: * When the strict-show conditions fail, adds this behaviour: logs "NotShownReason.OTHER". Bug: 1148902 Change-Id: I30dacb87f9e785466edd76a2de9ceb9b6ed9be9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540574 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#828187}
-
James Vecore authored
Contains only cl/342372120 since the last uprev. This addresses a possible keep alive time-out when doing larger file transfers due to the crypto context mutex being held for longer than necessary. Bug: 1146293 Change-Id: If6e51f936faf10756c122b7d9676ddc606ab7e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543196 Auto-Submit: James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#828186}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py 6ef07111a402a87fda096b6b8d7327e4aa89d4d6`. Bug: 1149189,1148761 Change-Id: I6bde4a1d5f055296d4f52619f7bec9ddb191cb79 Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538318 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#828185}
-
Felipe Andrade authored
Remove duplicate import("//tools/polymer/polymer.gni") from some BUILD.gn files in settings UI. This is a clean up work done while creating a new settings section called Kerberos. See associated bug for additional information. Bug: 983041 Change-Id: Idbf0f78253d4f0410ea9600dff98ae9ac0bc9760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536648 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#828184}
-
Karandeep Bhatia authored
This is a reland of 34bf7349 Original change's description: > DNR: Add initial implementation for [get/update]SessionRules. > > The session rules are not indexed and evaluated yet. This will be done > in a follow-up. > > Skipping presubmit since this seems to be hitting crbug.com/956368. > > BUG=1043200 > Doc=https://docs.google.com/document/d/1_I6jHA_jCa0UbR2QVUZsBApt_GqEuMz7qnpQdt1LEv0/edit?usp=sharing (Internal only) > > No-Presubmit: True > Change-Id: Id15783af14ff1f4a88900680d29d71d07794b4e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495511 > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827418} Bug: 1043200 No-Presubmit: True Change-Id: I9174b278594236d5b90cf0d7f434efce538a1cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540208 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828183}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ic5e99247361e57a90ea048463797bde1b0744101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542756Reviewed-by:
-
Boris Sazonov authored
Adds ToMojoAccountKey/FromMojoAccountKey helpers to components/account_manager_core/account_manager_util.h. These methods will be used by subsequent CLs to implement observers in AccountManagerFacade. Bug: 1117472 Change-Id: I625afacc31dc2d3bd4ceb56dde70a99ed1d15e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542903Reviewed-by:
-
Omar Morsi authored
This CL inlines the definitions of the constructors of the NSS operation states to make it more readable and shorter. Bug: 1131873 Change-Id: I0ff8b270fe4f1e2b653d3066e9b5dd7ebccad4b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541724Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#828180}
-
Roman Sorokin authored
This CL eliminates NOTIFICATION_KIOSK_AUTOLAUNCH_WARNING_VISIBLE and NOTIFICATION_KIOSK_AUTOLAUNCH_WARNING_COMPLETED notifications. These were used for the tests only. Replaced it with javascript waiter. Bug: none Change-Id: Iea1f187d43fc708c2c23e02e4ebfe37d8a38b329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544138Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828179}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4f96bf19941b..2f5d646c928e 2020-11-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 089f5a3e to d8a32653 (384 revisions) 2020-11-17 syoussefi@chromium.org Vulkan: Make ImageViewHelper a Resource 2020-11-17 amy.liu@arm.com Fix flip info of colorBlit with pre-rotation. 2020-11-17 cclao@google.com Vulkan: Remove rotation related data from driver uniform If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I91adb3a4dce11175fcef45540021847ea112844c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542856 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Guido Trotter authored
Since we have an observer for the "hidden" attribute, that is going to be called anyway, inline the show() function into it, instead of having it called explicitly. One place in oobe_welcome.js already calls show() only if it exists. Change the other call to follow the same pattern, and remove the show() function altogether from that module. Signed-off-by:
Guido Trotter <ultrotter@chromium.org> Change-Id: I96ff9feb8d339ddf3aca2cf672e69eff78a15c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537688Reviewed-by:
-
Yu-Hsuan Hsu authored
Check whether there is a keyboard mic. If yes, adding keyboard mic effect on lacros-chrome. BUG=b:173113548 Change-Id: I5241c11031cd5f681380f091dac23fbc82b3d75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536661 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#828176}
-
Tal Pressman authored
This CL introduces separate legacy IPC channels per AgentSchedulingGroup in "MBI mode". This channel is then used to associate channel-associated interfaces with, and to send legacy IPC messages. In addition it does the following: 1. Remove MaybeAssociatedRemote/Receiver, as the ASG's mojo interfaces are now always channel-associated. 2. ASG and ASGH implement IPC::Listener to handle legacy IPC message on the new channel. 3. Rename SetUpMojo/ResetMojo to SetUpIPC/ResetIPC. 4. `should_associate_` flag is replaced with an enum to make its meaning clearer. Bug: 1111231 Change-Id: I1d850aae48b4a900ab0aef24ac8a58b00cbcb218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535954 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#828175}
-
Jit Yao Yap authored
Change-Id: I995dae02a8823ce904f201501063e6a0526dab6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543922 Auto-Submit: Jit Yao Yap <jityao@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#828174}
-
Fredrik Söderqvist authored
ElementStyleResources holds a reference to the Element of the StyleResolverState that also owns the former object, so don't go across the stream for water and use |ElementStyleResources::element_| to get a reference to a proper TreeScope in GetSVGResourceFromValue(). Also make said field a reference to clearly indicate that it will be non-null. Drop StyleResolverState::GetTreeScope() since it now only has a single user. Change-Id: Ic2c994b546069001e6dd716a0d175825ceaeb96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544183Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#828173}
-
Jan Scheffler authored
CL: https://crrev.com/c/2505657 Bug: chromium:1144127 Change-Id: I438126be535524c073fb9bcba32309ff5c81ac3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539197Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#828172}
-
