- 20 Mar, 2018 40 commits
-
-
Peter E Conn authored
Digital Asset Link verification consists of two parts, verifying the link from the app to the website and verifying the link from the website to the app. The first part is done client side and a developer can easily satisfy this by putting a line in their app's manifest. The second part is done server side and thus a developer cannot create a link between their app and a locally running web server for development. This CL adds a command line Chrome flag that disables the server-side check allowing developers to use trusted web activity on locally hosted websites. Change-Id: I47a00ec45e5016ef398e876c1b35be680b2284f8 Reviewed-on: https://chromium-review.googlesource.com/883467 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544351}
-
Boris Sazonov authored
This CL extracts ConsentTextTracker from AccountSigninView and implements consent recording in SigninFragmentBase by using ConsentTextTracker. Bug: 814728 Change-Id: I7c699e63bea7a2c61244e72956d4774d46d79556 Reviewed-on: https://chromium-review.googlesource.com/964841Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#544350}
-
Elad Alon authored
This is a purely cosmetic change, bring the order of the private methods in line with the public ones. (The order of the public methods was changed by a previous CL that made some of the methods virtual.) Bug: 775415 Change-Id: I978cc34bc1ac6ffa579608030de3ac1343f7eb92 Reviewed-on: https://chromium-review.googlesource.com/966905Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#544349}
-
Vaclav Brozek authored
chrome/android/java/src/PRESUBMIT.py currently contains one test: checking for bad use of Notification.Builder. This CL improves that test in two ways: * It makes it ignore the forbidden pattern in comments. * It adds a test for the presubmit check. Bug: 821981 Change-Id: I5e2e362ed2168e479b446eccdca11e76a95e9e85 Reviewed-on: https://chromium-review.googlesource.com/966626 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544348}
-
https://webrtc.googlesource.com/src.git/+log/d2c8332e2b03..9047dac7576d $ git log d2c8332e2..9047dac75 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None,chromium:None,chromium:822799,chromium:680172,chromium:None,chromium:755660,chromium:None,chromium:None,chromium:None,chromium:755660 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia063873eca78ba81cec927cf4374423586bb338f Reviewed-on: https://chromium-review.googlesource.com/970723 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544347}
-
Oleh Prypin authored
Add remoting/webapp to prevent possible compile failures that were not detected previously (see https://chromium-review.googlesource.com/969604) And re-add 'all' on Linux and Windows dbg -- the slowdown is OK because these can run in parallel with testers which use release builds Bug: chromium:820041 Change-Id: Ic1c7d5e47748c216bbe43c54c2fa526a16b5dc39 Reviewed-on: https://chromium-review.googlesource.com/970545Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544346}
-
Avi Drissman authored
BUG=730593 Change-Id: I99aba6a46ed01fe3ec3579ee1f6180670f2e6778 Reviewed-on: https://chromium-review.googlesource.com/969109Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#544345}
-
David Bokan authored
This crash was occurring because a local frame is made the effective rootScroller. Then, it is navigated to a cross origin domain and it swaps in a remote frame. The code to handle this for rootScroller would mark the document as needing layout - after which we'll notice the rootScroller is no longer valid and replace it. However, before that happens we might get a resize IPC which executes code in RootScrollerController that assumes an iframe rootScroller is local. The fix here is to just immediately recompute the effective rootScroller when the iframe's FrameView is changed. We also need to notify the RootScrollerController of updates to an iframe's FrameView in more cases. Previously, we would early-out if the iframe wasn't the effective root scroller. This would fail in some situations. e.g. The iframe loses its FrameView which causes us to recalculate and remove it as the effective root scroller. The iframe then gets a new FrameView so we should recalculate again. This CL makes it so we early out only if the iframe isn't the rootScroller or implicit rootScroller. Bug: 805298 Change-Id: Ibf5c46c9fea6016bfa376116dc1f18723fe2c2d1 Reviewed-on: https://chromium-review.googlesource.com/957791Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#544344}
-
David Roger authored
Bug: 714018 TBR: avi Change-Id: I7bdf746f928f0feb6cf08d63a12b506063256430 Reviewed-on: https://chromium-review.googlesource.com/931129Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#544343}
-
Justin Cohen authored
Updates the spacing within each content suggestion cell and the style of the collection view container. Bug: 805638 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3ef8ae27f5f275c48cb9c6ed6c2b9c6ea65e0505 Reviewed-on: https://chromium-review.googlesource.com/962979 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#544342}
-
Gauthier Ambard authored
This CL adds a coordinator for the popup menu. This coordinator is in charge of handling all "showPopupX" events. This coordinator is aimed to replace all the other coordinator currently handling those event, like the toolsMenuCoordinator or the TabHistoryCoordinator and their associated protocols. Bug: 804770, 804771 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib206abed3c22bf64b023b9cd55a7fe11a7372ccd Reviewed-on: https://chromium-review.googlesource.com/962454 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#544341}
-
Gabriel Charette authored
Re-uses existing helpers to make these truly empty impls in non-dcheck builds. Most importantly, this allows instrumenting these calls with extra tracing information when debugging without having to rebuild the world (thread_restrictions.h is implicitly included virtually everywhere). (and yes they should be outright removed in favor of the new ones but that's orthogonal to this CL) R=fdoray@chromium.org Bug: gab doesn't like to rebuild the world when debugging Change-Id: I6f7f39a26164c4375fd9b48233236a528b0fa2b5 Reviewed-on: https://chromium-review.googlesource.com/969446 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#544340}
-
Ashley Enstad authored
Bug: 757933 Change-Id: Iaa6e4d2e254dccef2f6e4a81909b3eefa7f7fd46 Reviewed-on: https://chromium-review.googlesource.com/969954 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#544339}
-
Gauthier Ambard authored
This CL creates the first files used to present the popup menu. The presenter is used to display a view inside a popup, with a scrim on the rest of the screen, preventing interactions. It also creates a flag to enable it, as we don't want to use the general phase 1 flag while the tools menu is not working. For now this presenter is not used anywhere. Bug: 804770 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3015e8aeb063dd948f8bf1cdb8d15667093345ae Reviewed-on: https://chromium-review.googlesource.com/962444Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#544338}
-
Mostyn Bramley-Moore authored
Followup to https://chromium-review.googlesource.com/c/chromium/src/+/970242 Bug: 814305 Change-Id: I3e034eb8c1bc093cc6117641c625059f0e208f70 Reviewed-on: https://chromium-review.googlesource.com/970471Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#544337}
-
Finnur Thorarinsson authored
Convert ... const CallBack& callback ... to ... CallBack callback Bug: 734095 Change-Id: I96125e214b5337c78763ba304e8a7135cd42b635 Reviewed-on: https://chromium-review.googlesource.com/964327 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#544336}
-
Adam Rice authored
Prior to this change, response body methods such as response.body.arrayBuffer() would reject with a TypeError if the fetch was aborted. This change makes them correctly reject with an AbortError instead. This implements stage #3 of the "Body Cancellation" section of the design doc: https://docs.google.com/document/d/1OuoCG2uiijbAwbCw9jaS7tHEO0LBO_4gMNio1ox0qlY/edit#heading=h.fvc7d7q07oio Bug: 817687 Change-Id: Ifde322d9c22485a8ba9d14fd4ffca65c4fb4745a Reviewed-on: https://chromium-review.googlesource.com/954765 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#544335}
-
Rayan Kanso authored
The flag ensures that the broadcast receiver for notification taps gets foreground priority upon receiving the broadcast intent. Bug: 868654 Change-Id: Ie45d039a3f0fb74fd40d467828ba2d7bf3e993ee Reviewed-on: https://chromium-review.googlesource.com/968872Reviewed-by:
Anita Woodruff <awdf@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#544334}
-
Alexander Potapenko authored
This reverts commit 380375bf. Reason for revert: MSan reports on buildbots and Clusterfuzz, see https://bugs.chromium.org/p/chromium/issues/detail?id=823654 Original change's description: > Adding a |root_background_color| to RenderFrameMetadata > > Added |root_background_color| to RenderFrameMetadata. Since > |root_background_color| does not change with every frame,it's added > to low frequency fields. > > One use case is added together with this change: > RenderWidgetHostViewAura::SubmitCompositorFrame is used to sniff the > |root_background_color| from the CompositorFrame, after this change, > RWHVA listens to RenderFrameMetadataProvider and updates the background > color when the RenderFrameMetadata changes. > > Bug: 716911 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: I6857d0096fe3662b53410e2a7dc8a1682c0544c5 > Reviewed-on: https://chromium-review.googlesource.com/952303 > Commit-Queue: Yi Xu <yiyix@chromium.org> > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544172} TBR=fsamuel@chromium.org,tsepez@chromium.org,yiyix@chromium.org Change-Id: I5d079dbd1ddc84e4c938a253aa105e68c5b279d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 716911 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/970405Reviewed-by:
Alexander Potapenko <glider@chromium.org> Commit-Queue: Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#544333}
-
David Roger authored
Tracks the changes in token states for all accounts. Tokens can have three states: Regular (retrieved from Gaia), Invalid (created by Chrome and known to be invalid) or None (no token). Recorded when a token is loaded or changed. Bug: 821863 Change-Id: I4e73978a746315ff81d9bc395b3186f178fe2cca Reviewed-on: https://chromium-review.googlesource.com/964525Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#544332}
-
Olivier Robin authored
Some web sites (like apple.com or llbean.com) build forms after the page loading. This prevent using the server side type resolution. Add a tracker to update the autofill forms regularly. Bug: 798675 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ieaaf502a7bff38756d90bd96e94c058977dcab7b Reviewed-on: https://chromium-review.googlesource.com/943321 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#544331}
-
Koji Ishii authored
This patch rebaselines text-only failures that have matched images, from the following bot result on ToT. https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_layout_tests_layout_ng/4285 Additional rebaselines were found by adjusting the normalization logic: * Text dumps can contain arbitrary strings before the dump. Before this patch, the text must start with "layer at". * Ignore trailing spaces of text runs. * Ignore position of LayoutBR TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I58d22a7af545e15d88b89cf770104feb6ab93d8c Reviewed-on: https://chromium-review.googlesource.com/970621 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#544330}
-
Magnus Jedvert authored
TBR=tommi Bug: None Change-Id: I58f12bcc2deb794f921ad3dd94d527fabe8e7681 Reviewed-on: https://chromium-review.googlesource.com/970462Reviewed-by:
Magnus Jedvert <magjed@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Magnus Jedvert <magjed@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#544329}
-
Mounir Lamouri authored
Fixes a crash when onPlay and onPause were called without a MediaNotificationInfo object available. This should not happen but clients seems to regularly crash because of it. Possibly Android runs the callbacks at moments we are not expecting. Bug: 817051 Change-Id: Ieb06f93a06025386300ee3c7513f530b63c3215d Reviewed-on: https://chromium-review.googlesource.com/955694 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#544328}
-
Ulan Degenbaev authored
The _markDetachedDOMTreeNodes in the worker sets the detachedDOMTreeNode flag if the node is native and its name starts with "Detached " prefix. This patch also ensures that '.highlight' and '.detached-dom-tree-node' CSS styles are not set both at the same time. Bug: 811925 Change-Id: Iee4ee0647abb19a36c1be2f078b4c2915d67cba5 Reviewed-on: https://chromium-review.googlesource.com/964761 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#544327}
-
Hans Wennborg authored
This reverts commit 33f64ee2. After the latest Clang roll, lld will not warn about missing symbols from the order file, so enable the use of order files again. Originally reviewed at https://chromium-review.googlesource.com/955726 TBR=thakis@chromium.org,rnk@chromium.org Bug: 792131, 728324 Change-Id: I6662f40b9b36063eec172728027b82d96a2cd487 Reviewed-on: https://chromium-review.googlesource.com/970421Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#544326}
-
Zhuoyu Qian authored
Since ApplyBlockElementCommand::DoApply() has checked |visible_start| is not null before, and |new_selection|'s base is |visible_start|, so |new_selection| can not be an empty selection and the null check of |new_selection| is redundant, we can remove it. Bug: 689392 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ic278963f06b05b65a2d1a08532b9a2a78ef530d3 Reviewed-on: https://chromium-review.googlesource.com/967631Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544325}
-
Jochen Eisinger authored
Now that downloads initially look like navigations, we have to allow some navigations from extension views such as popups BUG=821219,823639 R=clamy@chromium.org,rdevlin.cronin@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I2276a5649120a17974bf576791f74e3eac3d4e3a Reviewed-on: https://chromium-review.googlesource.com/960003 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544324}
-
Marc Treib authored
It occasionally crashes, see bug. Bug: 434438 Change-Id: I16efb79247855c77e9e41d5eb0c64b6bd8144af6 Reviewed-on: https://chromium-review.googlesource.com/970245Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#544323}
-
Zhuoyu Qian authored
This CL introduces "EditorCommand.h", move class Editor::Command from Editor.h to EditorCommand.h and rename it to EditorCommand. This make |Editor| class simpler for improving code health. Bug: 672405 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I572094e32b4a7c19b62fcaf810165f9aab44db08 Reviewed-on: https://chromium-review.googlesource.com/958623Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544322}
-
Kunihiko Sakamoto authored
Tests for signed exchange verification were written in WebPackageRequestHandlerBrowserTest, since SignedExchangeHandler was not unit-testable at the time. Now SignedExchangeHandler has unit test, so this patch moves these test cases to SignedExchangeHandlerTest. Bug: 803774 Change-Id: Ie5333cbf5d1984de56a3a7f7d5a3f350fd92b283 Reviewed-on: https://chromium-review.googlesource.com/970186Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#544321}
-
Dominik Röttsches authored
Reland after revert in https://chromium-review.googlesource.com/c/chromium/src/+/969185 as the previous CL left files behind in the src directory and did not add the src directory to .gitignore. Remove src/ from Chromium repo and retrieve HarfBuzz sources from the mirror at [1]. Cherry picks can be done by HarfBuzz OWNERS by pushing new branches to refs/heads/chromium/ of [1]. This was tested and confirmed working in:: https://chromium-review.googlesource.com/c/chromium/src/+/937502 [1] https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/ Bug: 814305 Tbr: eae, behdad, bungeman Change-Id: Ia4232a3231bb6388aaf31a0739626d778c5b6d68 Reviewed-on: https://chromium-review.googlesource.com/970242Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#544320}
-
Eero Häkkinen authored
This CL doubles the performance on an Intel Broadwell CPU. Bug: 778262 Change-Id: Ie60d64a0e862148a8a74e1fb162be2ec147e6cc6 Reviewed-on: https://chromium-review.googlesource.com/924144 Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#544319}
-
Vaclav Brozek authored
Right now, changes to //PRESUBMIT.py trigger running //PRESUBMIT_test.py during presubmit checks. However, this does not happen for PRESUBMITs in subdirectories, of which there is a number with associated PRESUBMIT_test. This CL allows running the associated PRESUBMIT_test. Bug: 821981 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I057f4d736992795dde7dd0d329ed3773d22553dc Reviewed-on: https://chromium-review.googlesource.com/966906 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#544318}
-
Dominick Ng authored
This addresses a bug where sites using the beforeinstallpromptevent to implement an install button could have users trigger a do-nothing install prompt if the user first used the menu item "Add to Shelf" to install, and then pressed the beforeinstallprompt-connected button. Resetting the event binding when the OnInstall() method is triggered means that when an install is started, all outstanding beforeinstallpromptevents are voided, fixing the bug. BUG=823602 Change-Id: Ib2c747c74f7083a7663580ed37da7a319d9a9c60 Reviewed-on: https://chromium-review.googlesource.com/970050Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#544317}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d811a187..8ac76771 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic170d29a8bf695b602ad75f21510c86e3cfa4ea1 Reviewed-on: https://chromium-review.googlesource.com/969996Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#544316}
-
Max Morin authored
Only documentation, hence no-try. No-Try: true Bug: 803102 Change-Id: I5acc5eaf492a79dadd609e6272d73ab100196163 Reviewed-on: https://chromium-review.googlesource.com/966285Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544315}
-
Antoine Labour authored
The semantics of EnsureWorkVisible are that it is expected to validate any OrderingBarrier or Flush that was called prior to it. This is necessary so that GenSyncTokenCHROMIUM correctly generates validated sync tokens. Bug: 797137 Change-Id: I2b012328b79ea038eb02f82c19d5faf239aa43b2 Reviewed-on: https://chromium-review.googlesource.com/970164Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544314}
-
Tetsui Ohkubo authored
According to UnifiedSystemTray spec, the tray has blurry background. It is appropriate to use app_list::IsBackgroundBlurEnabled, becuase app_list is moving from ui/app_list to ash/app_list (go/move-applist), and also it returns true only on high-end devices which have small performance impact when the blur is enabled. Screenshot: http://screen/wUryXYd800Y Design doc: go/cros-qs-restyling TEST=out/Release/chrome --enable-features=EnableBackgroundBlur,SystenTrayUnified BUG=811641 Change-Id: I270751b734110023261bdb698af33b31fb1af87f Reviewed-on: https://chromium-review.googlesource.com/970055Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#544313}
-
Yuta Kitamura authored
Currently, WebFrameScheduler is created through ChromeClient, but actually we don't have to talk to ChromeClient -- we can directly get PageScheduler from Page, and then call PageScheduler:: CreateFrameScheduler(). Bug: 822201 Change-Id: Ib4c85a41a18f2e2deb8f2a8a96aa527c6f5b4cbe Reviewed-on: https://chromium-review.googlesource.com/964072Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#544312}
-