GitLab

testharness.js is used for http tests but the changes made to the report
file were not done to the one in the http/resources/ directory.

BUG=268711

Review URL: https://codereview.chromium.org/302093010

git-svn-id: svn://svn.chromium.org/blink/trunk@175288 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently, if you select some text in text editor and then do a right-click
inside selection, the just-summoned context menu won't have a copy/paste/cut
items, as well as other native items natural for text area context menu.

This happens due to the way CodeMirror handles contextmenu event. It
focuses a small text area during the contextmenu bubbling phase, so the
upcoming ContextMenu gets populated with appropriate items. Unfortunately,
codemirror does all this textarea mess *after* firing its own "contextmenu"
event, and as we create menu in the listener, it doesn't have correct active
element.

This patch goes back to listening contextmenu event on element, which due to
bubbling nature happens after textarea was focused.

R=vsevik

Review URL: https://codereview.chromium.org/306023015

git-svn-id: svn://svn.chromium.org/blink/trunk@175286 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a mostly mechanical change that makes use of the SMILInterval
type added in https://codereview.chromium.org/298043005.

Review URL: https://codereview.chromium.org/312503003

git-svn-id: svn://svn.chromium.org/blink/trunk@175285 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- add trace event for RenderImage::paintIntoRect;
- fix name of decode & resize image events for tracing vs. old timeline;
- add processing of decode/resize/paint/imageref events to TimelineTraceEventBindings;
- generalize handling of additional event properties when building details, so that
    we avoid extra switches over event type by extracting properties relevant for
    details into TraceEvent properties;
- temporary workaround for crash on record stop in tests by cloning an AtomicString
    (see crbug.com/375242 for more details).

BUG=361045,375242

Review URL: https://codereview.chromium.org/308123008

git-svn-id: svn://svn.chromium.org/blink/trunk@175284 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ThreadableLoaderOptions shouldn't derive from ResourceLoaderOptions.
ResourceLoaderOptions members are basically just passed through to
FetchRequest while items added by ThreadableLoaderOptions definition
are configuring how CORS, etc. are handled in ThreadableLoader.
Inheritance looks making things less readable to me.

Also, I'd like to make DocumentThreadbleLoader more readable by making
constant variables held by const members.

Items in ThreadableLoaderOptions that determines ThreadableLoader's
behavior could be held by DocumentThreadableLoader as a const member.
Items defined in ResourceLoaderOptions can be altered inside
DocumentThreadableLoader, but can still be held as a const member by
having members to hold overridden items.

BUG=377541

Review URL: https://codereview.chromium.org/301243015

git-svn-id: svn://svn.chromium.org/blink/trunk@175283 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move NoEventDispatchAssertion class to its own file instead of having it in
ContainerNode.h.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/301173006

git-svn-id: svn://svn.chromium.org/blink/trunk@175282 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Design doc: https://docs.google.com/a/chromium.org/document/d/1LTk9uVMGi4kurzcF5ellsAJReTF31fFJMHrQwSVtBjc/

BUG=368358

Review URL: https://codereview.chromium.org/299883004

git-svn-id: svn://svn.chromium.org/blink/trunk@175281 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Having the @param annotation for only a part of function's params is both
confusing (makes people think the function is properly annotated) and
error-prone (missing a @param can result in subtle coding errors).

R=sergeyv
NOTRY=true

Review URL: https://codereview.chromium.org/301383002

git-svn-id: svn://svn.chromium.org/blink/trunk@175280 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=369451

Review URL: https://codereview.chromium.org/302973003

git-svn-id: svn://svn.chromium.org/blink/trunk@175279 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch also fixes some ?Event -> !Event cases.

R=vsevik@chromium.org, lushnikov, vsevik

Review URL: https://codereview.chromium.org/301163005

git-svn-id: svn://svn.chromium.org/blink/trunk@175278 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If we find a direct pointer to the backing store of the deque (this will
normally be an iterator) we have to trace the backing without knowing how
much of it is in use (that information is in the Deque itself, not the
backing store).  This means we have to ensure that unused areas of the
backing store are zeroed out.
R=ager@chromium.org, mikhail.pozdnyakov@untel.com
BUG=

Review URL: https://codereview.chromium.org/308323002

git-svn-id: svn://svn.chromium.org/blink/trunk@175277 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#request-objects

Multi-sided patch: 
1/3: blink-side, THIS PATCH
2/3: chromium-side, https://codereview.chromium.org/305893003/
3/3: blink-side, cleanup Not Yet.

BUG=377373

Review URL: https://codereview.chromium.org/304053003

git-svn-id: svn://svn.chromium.org/blink/trunk@175276 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Bumped into these methods while investigating background layers. They were
not in use.

Review URL: https://codereview.chromium.org/310623002

git-svn-id: svn://svn.chromium.org/blink/trunk@175275 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Finalization of ScreenOrientationController now needed, adjust GC class.

R=haraken@chromium.org,ager@chromium.org
BUG=162827
NOTRY=true

Review URL: https://codereview.chromium.org/305363003

git-svn-id: svn://svn.chromium.org/blink/trunk@175274 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previous implementation used display:none to hide columns.
This caused UI glitches, tremble on resize and performance issues.

In new implementation hidden columns are not rendered at all.

BUG=372246

Review URL: https://codereview.chromium.org/297893003

git-svn-id: svn://svn.chromium.org/blink/trunk@175273 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some tests trigger CONSOLE output of various kind (LOG, ERROR,
etc.) for legitimate reasons so we shouldn't break those tests.

Furthermore, we are a little too pedantic with regards to whitespaces
around testharness output. Given how we get that output (ie. using
element.innerText), we should be less restrictive.

BUG=379442

Review URL: https://codereview.chromium.org/308223002

git-svn-id: svn://svn.chromium.org/blink/trunk@175272 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We can reduce overloads and also remove using.

BUG=none

Review URL: https://codereview.chromium.org/309533008

git-svn-id: svn://svn.chromium.org/blink/trunk@175271 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch provides the fix for NeedsManualRebaseline lines
in TestExpectations added in following revision
https://src.chromium.org/viewvc/blink?revision=174761&view=revision

Review URL: https://codereview.chromium.org/306473008

git-svn-id: svn://svn.chromium.org/blink/trunk@175270 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If the new navigation will be canceled by a Browser-side throttle we
don't want to cancel the currently loading document.

BUG=308257, 378716

Review URL: https://codereview.chromium.org/181493007

git-svn-id: svn://svn.chromium.org/blink/trunk@175269 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add required parens.

R=
BUG=378167
NOTRY=true

Review URL: https://codereview.chromium.org/311563006

git-svn-id: svn://svn.chromium.org/blink/trunk@175268 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Preliminary CL for splitting global constructor computation between core
and modules.
Straightforward, but needed for pipeline.

Computation of global constructors (as partial interface definitions) depends
on global *objects* (interface definitions with [Global] or [PartialGlobal]).

We want to split global *constructors* between core and modules (as separate
partial interface .idl files), but we first need to compute global *objects*.
Thus we split this computation into 2 steps.

Also a bit of cleanup.

Followup CLs:
* Split global constructors computation between core and modules
* Split global objects computation between core and modules
...at which point the bindings build will be 100% split!

R=haraken
BUG=358074

Review URL: https://codereview.chromium.org/309793002

git-svn-id: svn://svn.chromium.org/blink/trunk@175267 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=jochen

Review URL: https://codereview.chromium.org/304353015

git-svn-id: svn://svn.chromium.org/blink/trunk@175266 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The functionlity is already supported by presentation record.

BUG=None
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/306123009

git-svn-id: svn://svn.chromium.org/blink/trunk@175265 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Stop firing 'orientationchange' events to pages that are not visible as per the
specification:
https://w3c.github.io/screen-orientation/#handling-screen-orientation-changes

This avoids having background pages handle 'orientationchange' events and
wasting battery.

As indicated in the specification, screen.orientation keeps returning the old
orientation if the orientation changes while the page is not visible.

R=mounir@chromium.org, jochen@chromium.org
BUG=162827
TEST=screen_orientation/page-visibility.html

Review URL: https://codereview.chromium.org/280283002

git-svn-id: svn://svn.chromium.org/blink/trunk@175264 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All its usages have been inlined.

BUG=361045
R=alph@chromium.org

Review URL: https://codereview.chromium.org/305133004

git-svn-id: svn://svn.chromium.org/blink/trunk@175263 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=alph, yurys

Review URL: https://codereview.chromium.org/308643003

git-svn-id: svn://svn.chromium.org/blink/trunk@175262 bbb929c8-8fbe-4397-9dbb-9b2b20218538

background-repeat serialization did not handle initial keyword values in
background-repeat value lists.
Initial values in value lists are introduced by setting the background
shorthand to multiple background values while omitting background-repeat
properties.
Example: background: url(#1), url(#2), url(#3);
The background-repeat gets stored internally as "initial, initial, initial".

This patch updates StylePropertySerializer::backgroundRepeatPropertyValue()
to handle this case correctly.

BUG=378167

Review URL: https://codereview.chromium.org/303993003

git-svn-id: svn://svn.chromium.org/blink/trunk@175261 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For DocumentInit, the context document is no longer mediated
as a WeakPtr, but as a Member. It is sufficient that the
Document holds onto this reference weakly.

R=haraken@chromium.org, tkent@chromium.org
BUG=357163

Review URL: https://codereview.chromium.org/304323010

git-svn-id: svn://svn.chromium.org/blink/trunk@175260 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a regression caused by r174937.
After r174937, ExecutionContexts created for IDBRequestTest and IDBTransactionTest
outlive the tests (because the lifetime of the ExecutionContexts is bound to a ScriptState
associated with the tests). This is wrong, and we should clear the ExecutionContexts
when shutting down the tests.

BUG=379616

Review URL: https://codereview.chromium.org/307933011

git-svn-id: svn://svn.chromium.org/blink/trunk@175259 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes |IndentOutdentCommand::outdentParagraph()| not to call
|CompositeEditCommand::movePargrap()| with null |VisiblePositon|.

This situation can be happened in attached test case, where
|visibleStartOfParagraph| and |visibleEndOfPargraph| are second TABLE element.
Both |startOfParagraph()| and |endOfParagraph()| return null |VisiblePositon|
for them.

BUG=379058
TEST=editing/execCommand/outdent-collapse-table-crash-2.html

Review URL: https://codereview.chromium.org/305143002

git-svn-id: svn://svn.chromium.org/blink/trunk@175258 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TEST=fast/events/drag-leak-document.html (run_webkit_tests with --enable-leak-detection)
BUG=364392

Review URL: https://codereview.chromium.org/302133002

git-svn-id: svn://svn.chromium.org/blink/trunk@175257 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently an XMLHttpRequest that fails without response is shown as "Other"
resource type. This CL fixes the behavior.

BUG=294676

Review URL: https://codereview.chromium.org/302093003

git-svn-id: svn://svn.chromium.org/blink/trunk@175256 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=369401
TEST=All tests should pass, because of just refactoring.

Review URL: https://codereview.chromium.org/304083003

git-svn-id: svn://svn.chromium.org/blink/trunk@175255 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=eseidel@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/307933012

git-svn-id: svn://svn.chromium.org/blink/trunk@175254 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=369451

Review URL: https://codereview.chromium.org/301113002

git-svn-id: svn://svn.chromium.org/blink/trunk@175253 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175243

BUG=373389
TBR=ksakamoto@chromium.org

Review URL: https://codereview.chromium.org/308983002

git-svn-id: svn://svn.chromium.org/blink/trunk@175252 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes |IndentOutdentCommand::outdentParagraph()| to check whether
|enclosingBlockNode| is null or not, before passing it to
|CompositeEditCommand::splitTreeToNode()| which assumes it isn't null.

This situation can be happened in attach test case, where
|enclosingBlockNode| is calculated from |visibleStartOfParagraph|, which is
second TABLE element, by |enclosingBlock()|.

BUG=378758
TEST=editing/execCommand/outdent-collapse-table-crash.html

Review URL: https://codereview.chromium.org/308023003

git-svn-id: svn://svn.chromium.org/blink/trunk@175251 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The TestExpectations objects we were creating in a loop would consume memory
and never return it. I'm not sure why the memory wasn't getting freed, but reparsing
TestExpectations over and over again is really slow and by far the longest pole
in rebaseline performance. So, fix both issues by not doing this.

Instead, grab all the test_configurations that we want to remove up front and then
remove them all in one go from TestExpectations. This makes the work and memory
cost be O(number of ports) instead of O(number of tests * number of ports).

Also, fix a bug where we would not remove lines for passing tests that were being
rebaselined. I had previously fixed this incorrectly in auto-rebaseline. Instead, fix
it correctly in AbstractParallelRebaselineCommand so that the rebaseline-expectations,
rebaseline-json and rebaseline commands also get the fix.

BUG=379484

Review URL: https://codereview.chromium.org/302003009

git-svn-id: svn://svn.chromium.org/blink/trunk@175250 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=379616
TBR=oilpan-reviews@chromium.org

Review URL: https://codereview.chromium.org/308963003

git-svn-id: svn://svn.chromium.org/blink/trunk@175249 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL changes generated bindings so that both toV8(RawPtr<X>) and toV8(X*) are generated. Otherwise, if someone uses RawPtr<X> instead of X* in the code base, it can be bound to unexpected toV8() and a wrong wrapper can be returned to V8. For more details, see my comment in the patch set 3.

BUG=340522

Review URL: https://codereview.chromium.org/257503003

git-svn-id: svn://svn.chromium.org/blink/trunk@175248 bbb929c8-8fbe-4397-9dbb-9b2b20218538