GitLab

When a click on a password is performed, the opened fragment loads the
data about the saved password by its ID through PasswordManagerHandlerProvider.

Bug: 377410
Change-Id: If3612580645c71701bc574ac723b35a397fb6726
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709321
Commit-Queue: Ivana Zuzic <izuzic@google.com>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681219}

This reverts commit a2103b51.

Reason for revert: Only Fido Cl before failures in
FidoGetAssertionHandlerTest.* started: 
https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/55166

Log: 
[ RUN      ] FidoGetAssertionHandlerTest.SuccessWithOnlyInternalTransportAllowed
=================================================================
==86183==ERROR: AddressSanitizer: requested allocation size 0xbebebe00bebebe00 (0xbebebe00bebece00 after adjustments for alignment, red zones etc.) exceeds maximum supported size of 0x10000000000 (thread T0)
    #0 0x113961c0d in __sanitizer_mz_malloc ??:0:0
    #1 0x7fff63b001bc in malloc_zone_malloc ??:0:0
    #2 0x7fff3ba12b7b in __CFStringDecodeByteStream3 ??:0:0
    #3 0x7fff3b9ee8a5 in __CFStringCreateImmutableFunnel3 ??:0:0
    #4 0x7fff3b9fc50c in CFStringCreateWithBytes ??:0:0
    #5 0x10a49f7ee in base::SysUTF8ToNSString(base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >) ??:0:0
    #6 0x10ab34881 in device::fido::mac::FindCredentialsImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::set<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > >, std::__1::allocator<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > const&, LAContext*) ??:0:0
    #7 0x10ab34496 in device::fido::mac::FindCredentialsInKeychain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::set<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > >, std::__1::allocator<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > const&, LAContext*) ??:0:0
    #8 0x10ab1988a in device::fido::mac::TouchIdAuthenticator::HasCredentialForGetAssertionRequest(device::CtapGetAssertionRequest const&) ??:0:0
    #9 0x10aa6c35b in device::GetAssertionRequestHandler::AuthenticatorAdded(device::FidoDiscoveryBase*, device::FidoAuthenticator*) ??:0:0
    #10 0x10aa57795 in device::FidoDeviceDiscovery::AddDevice(std::__1::unique_ptr<device::FidoDevice, std::__1::default_delete<device::FidoDevice> >) ??:0:0
    #11 0x103f5dd56 in device::FidoGetAssertionHandlerTest_SuccessWithOnlyInternalTransportAllowed_Test::TestBody() ??:0:0
    #12 0x10438ec30 in testing::Test::Run() ??:0:0
    #13 0x10439139a in testing::TestInfo::Run() ??:0:0
    #14 0x104392a26 in testing::TestSuite::Run() ??:0:0
    #15 0x1043c0236 in testing::internal::UnitTestImpl::RunAllTests() ??:0:0
    #16 0x1043bee1c in testing::UnitTest::Run() ??:0:0
    #17 0x10a6fc90a in base::TestSuite::Run() ??:0:0
    #18 0x10a738fa1 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ??:0:0
    #19 0x10a738b48 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ??:0:0
    #20 0x1040af3cc in main ??:0:0
    #21 0x7fff63957014 in start ??:0:0

==86183==HINT: if you don't care about these errors you may set allocator_may_return_null=1
SUMMARY: AddressSanitizer: allocation-size-too-big (/b/s/w/ir/out/Release/libclang_rt.asan_osx_dynamic.dylib:x86_64+0x43c0d)
==86183==ABORTING

Original change's description:
> [webauthn] Refactor Platform Discovery
> 
> This change moves the platform discovery logic from AuthenticatorCommon
> into TouchIdDiscovery, which is injected directly into
> FidoRequestHandlerBase. This streamlines the device discovery process
> for platform authenticators and allows testing them through the virtual
> authenticator environment.
> 
> Additionally, this change uncovered a bug on BLE device tests: they
> were relying on FidoRequestHandlerBase::notify_observer_callback
> never being called because SetPlatformAuthenticator wasn't called.
> 
> Bug: 981399
> Change-Id: Ic0b508c701447fb6228fd2fb8a44b4132370f330
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699947
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Auto-Submit: Nina Satragno <nsatragno@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Martin Kreichgauer <martinkr@google.com>
> Cr-Commit-Position: refs/heads/master@{#680857}

TBR=avi@chromium.org,nsatragno@chromium.org,martinkr@google.com

Change-Id: If6a20f444449936aa0fe24f7e0bd1536f9cc3989
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 981399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720237Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681218}

This reverts commit c5667854.

Reason for revert: Most likely candidate to have started the failing
TextFragmentAnchorBrowserTest.EnabledOnUserNavigation/0 tests.

Bug: 987895

Original change's description:
> Kitkat build test
> 
> Disable input for some browser and content Android tests.
> 
> 
> Disable input until we present something to the user
> 
> When a document loads, there is a significant period between when
> the frame is created and when the user sees content. During this time,
> the document is not processing lifecycle updates but Javascript is
> scheduled and the RenderWidget exists to handle input.
> 
> A major concern is that users might click on some place where there is
> something reactive laid-out and available for hit testing and processing
> (an ad, a link, start a video) before they have actually seen anything to
> click on. Think of something like a last ditch attempt to click on
> something on the page you're navigating away from only to hit something
> on the page you're navigating to.
> 
> It seems safer to avoid this rather than have unexpected and potentially
> very nasty behavior. In theory this situation was possible before with
> deferred lifecycle updates though it apparently never warranted concern.
> But we're preparing to enable the flag that defers the first compositor
> commit until we have some content ready to raster (or a timeout), in
> which case document lifecycles are running and there is content there
> to hit-test against and send events to, but the user hasn't seen it yet
> (for half a second at most, right now).
> 
> This patch adds a flag to suppress all input from the time when
> RenderWidget navigates to a frame to the time we are notified of the
> first compositor commit and paint, which is the best estimate we have
> for the user seeing something.
> 
> This patch may affect the FirstInputDelay (FID) web platform metric.
> FID may improve because dropped input won't be measured at all, and
> the delay for the first event we actually process will be smaller because
> it will come when the system is less stressed. i.e. after initial layout
> and paint. Regardless, the impact on FID will be monitored when this
> patch lands.
> 
> Tests disable this feature, with an open bug crbug.com/987626 to fix
> the tests and enable the feature.
> 
> Bug: 958424
> 
> Change-Id: I9d288b6861f88e7101d9957d1a21b6bebb38bca8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590415
> Commit-Queue: Stephen Chenney <schenney@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#681157}

TBR=avi@chromium.org,dcheng@chromium.org,bokan@chromium.org,torne@chromium.org,schenney@chromium.org

Change-Id: If18cd4c9ae4b9d21e578e2ce46f9f9aa20f8650a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 958424
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719487Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681217}

Also remove treib (who hasn't worked on this in years) and pam (who
also hasn't worked on this in years, and who isn't even working on
chromium anymore).

Bug: none
Change-Id: Icb33f4f47d8863bfbfce0720cc348d64924f1bbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715499
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681216}

Bug: 927324
Change-Id: I710f718f18410cc69391f1456b0ba7f02ea9e66d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710652
Commit-Queue: Fergus Dall <sidereal@google.com>
Reviewed-by: Nic Hollingum <hollingum@google.com>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681215}

Default-installed external web apps is a 1st class subsystem in WebAppProvider.

WebAppProvider should not be a proxy between ExternalWebAppManager and
PendingAppManager: they should be connected directly.

This CL just wraps the function into a class and moves the code.
No behavior changes.

Bug: 877898
Change-Id: I95871207d9548c65a915d7b9ebe2590fa2f9d089
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715515
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681214}

This reverts commit de2996a4.

Reason for revert: Causing issues with blink unit tests.

Original change's description:
> LazyLoad: Mark automatic lazyloading as experimental
> 
> This CL marks "loading" attribute support as experimental, so that WPT
> tests run with this attribute supported.
> 
> Bug: 937986
> Change-Id: I797a6e467e784c1740bdd77750f7b6a3460ca58b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700651
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: rajendrant <rajendrant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#680556}

TBR=kinuko@chromium.org,rajendrant@chromium.org,yoavweiss@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 937986
Change-Id: Id341a39814c93140deb95447368081549a011788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719863
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681213}

This CL refactors DesktopScreenX11 to re-use ui::XDisplayManager so that
ozone and non-ozone |display::Screen| implementations share the same
core code that interacts with Xlib/XRandR.

Bug: 891175
Test: views_unittests (DesktopScreenX11Test.*)
Change-Id: I67a622f2573de2b073b6b6ab403bb068e0ec7581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715901Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#681212}

Before this CL, a GN wrapper "blink_python_runner" assumed its invoker
to have inputs, outputs, and deps.

This CL makes it more flexible, i.e. to assume invoker's sources, data,
and data_deps.
This change resolves the confusing situation, for example, having |data| in
an invoker does not affect on any actions.


Bug: 839389
Change-Id: Ieecb8d07adc7f020df7de869fd15789d76c81621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718065
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Auto-Submit: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681211}

Currently we ignore these, but properly interfacing with chrome's
drag&drop implementation will require distinguishing between pointer
and touch events from the event serial. This CL adds a mechanism to do
this.

Bug: 927324
Change-Id: If829533c4b5b28b3b2b4eb5826dfe687df0de792
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709497
Commit-Queue: Fergus Dall <sidereal@google.com>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681210}

Bug: 927324
Change-Id: I5e1f99913d548ae342a9d8895d0240e8bdae09ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683514Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Nic Hollingum <hollingum@google.com>
Commit-Queue: Fergus Dall <sidereal@google.com>
Cr-Commit-Position: refs/heads/master@{#681209}

* OnFileChanged now calls to GetVolumeMountOnUIThread and then
  check if the path exists in CheckIfVolumeMountRemoved.
* Removed no_file_watchers_for_testing since all tests
  now run with watchers
* Changed the name of mount_event_seneschal_callback_ to simpler
  seneschal_callback_ since it is used more than just for
  mount events.
* Added 2 new tests to verify FilePathWatchers trigger
  when a path is deleted.
* Tests insert a test VolumeManager KeyedService which is
  required by GetVolumeMountOnUIThread.

Change-Id: Ib0c71fb860d22ee6d8b1e4d4169143e6656c13e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720113Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681208}

BUG=chromium:978318

Cq-Depend: chromium:1697997,chromium:1714191
Change-Id: I553dbd4c8b36d7487bde32c11f5361ac603fafa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701663
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Julian Watson <juwa@google.com>
Cr-Commit-Position: refs/heads/master@{#681207}

AutofillPopupControllerImplMac's |UpdateDataListValues| and |Show| call the super class' (AutofillPopupControllerImpl) methods which may hide the popup and therefore destroys |this|. So, |AutofillPopupControllerImpl| calls should be at the end.

Bug: 972741
Change-Id: I94cd0a4326c0321bfd231649f4f373f0385b18a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705913Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681206}

This CL waits the concurrent tasks to finish and then checking if it
pass the assertion. Otherwise, it might cause segmentation fault after
the assertion is triggered.

Bug: None
Test: ./jpeg_encode_accelerator_unittest
Change-Id: I0484bb1cea7968ea85565015c29365ab10424b66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716107Reviewed-by: Sheng-hao Tsao <shenghao@chromium.org>
Commit-Queue: Wei Lee <wtlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681205}

Bug: 987737
Change-Id: Id3133ef51446cddd071d1e4ca9a6e3be2c5c9470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718999Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681204}

Each builder has less than 1 machine hour usage in p99.
http://shortn/_Xldrj7izfc

Bug: 954450
Change-Id: Ibab82bac67991d5908ce78fcf6567ca1b2ebcd8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717879
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681203}

MessageLoopForUI will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you believe your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=hashimoto@chromium.org

Change-Id: Iaa588e8a5730c969415a1f4e294c3de5fc48059c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715201
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681202}

14 out of 24 usages of ExtensionTabUtil::GetTabById didn't require
|browser|, |tab_strip| and |tab_index| and specified nullptr for
them. Provide a simpler version without these params and update
callers to use the simplified version.


Bug: None
Test: No visible changes expected, internal only cleanup.
Change-Id: I3cbdeee148c335b49c058b9498be097f43043c8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717458Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681201}

This reverts commit 23dc294d.

Reason for revert: This change makes the highlight of the intent pick icon stays after closing the bubble.

Original change's description:
> Align intent picker bubble to the Omnibox.
> 
> Currently the intent picker bubble is aligned to the intent picker icon,
> this CL aligns the intent picker bubble to the Omnibox.
> 
> BUG=986145
> 
> Change-Id: I4940e000b7d9738b4fb886b79efe2edc7b1a18ac
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715349
> Commit-Queue: Maggie Cai <mxcai@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#681162}

TBR=sky@chromium.org,mxcai@chromium.org

Change-Id: I8b69f98708e82a321b5c14ce6a94c6937ab4dcc5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 986145
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719812Reviewed-by: Maggie Cai <mxcai@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681200}

Bots are added by
https://chrome-internal-review.googlesource.com/c/infradata/config/+/1523847

Bug: 987520
Change-Id: I7a5854035f6cf629b95411b90d8c53abc7ef1dca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718472Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681199}

(We'll start deleting the code soon too)

Bug: 985682
Change-Id: I7a53b0849820bfe18b93d0aabaaedc83bc062527
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715775
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681198}

The crash happens in DCHECK of FileSystemDispatcher::RemoveOperationPtr.
Because RemoveOperationPtr is called multiple times when a mojo connection
error happens. The first call removes a connection object in
|cancellable_operations_|. Then, the crash occurs in the second call due to
DCHECK because the connection object was already removed by the first call.
RemoveOperationPtr doesn't consider the multiple calls through the connection
error. So, this CL removes DCHECK in RemoveOperationPtr. Instead, it returns
when the given operation isn't found in the hashmap.

Bug: 986072
Change-Id: I0781b4225c15c883cf39348f53ab4b0a3b49c0ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716239
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681197}

This adds a D-Bus method called IsVmManagementCliAllowed to
ChromeFeaturesService. This method checks if the corresponding
VmManagementCliAllowed policy allows VM management CLI tools.

The method only considers restrictions if the
CrostiniAdvancedAccessControls feature flag is enabled. It will be used
in Crosh to limit access to vmc and vsh (potentially other commands
as well).

dbus-send --system --type=method_call --print-reply \
  --dest=org.chromium.ChromeFeaturesService \
  /org/chromium/ChromeFeaturesService \
  "org.chromium.ChromeFeaturesServiceInterface.IsVmManagementCliAllowed" \
  "string:${CROS_USER_ID_HASH}"

Test: compile, deploy to device, invoke:
Bug: 983996
Change-Id: I05d77ba27af6317e639d13bd4ae7f115d08f6c76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715295Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Alex Oldemeier <aoldemeier@chromium.org>
Commit-Queue: Ilya Bizyaev <ilyabiz@google.com>
Cr-Commit-Position: refs/heads/master@{#681196}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: I91a67dc6025a113701d7d9c225e9e9bbc75add12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700859Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681195}

https://chromium.googlesource.com/catapult.git/+log/1c7dba2cadad..572296c6382d


git log 1c7dba2cadad..572296c6382d --date=short --no-merges --format='%ad %ae %s'
2019-07-26 bsheedy@chromium.org [typ] Make typ Python 3 compatible


Created with:
  gclient setdep -r src/third_party/catapult@572296c6382d

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=oysteine@google.com

Bug: chromium:979879
Change-Id: I3925bd8b54f70079169c5e36700139a8db0de0af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719996Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681194}

Instead of setting WaylandConnection to the manager,
use observers pattern, and make interested parties subscribe
to changes.

Bug: 987239
Change-Id: I92252966e24417ed44227062b28e5096ca863517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715293
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#681193}

Changes GenericPendingReceiver's typemap to set nullable_is_same_type
and implements the necessary traits to support that.

This allows mojom interfaces using a non-nullable GenericPendingReceiver
argument to safely assume the GPR contains a valid pipe and interface
name, as this will be validated by bindings during deserialization.

Bug: None
Change-Id: I4368ef4f4927439c0793e894f015ce946f499eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717646
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681192}

WaylandConnection still has been overloaded with different tasks.

Thus, to make code cleaner, extract window management methods into
a separate class called WaylandWindowManager, which is responsible
for managing windows.

Bug: 987239
Change-Id: Ic74291842e24e919dae7335ebb7c89b08a81a61c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715193
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#681191}

Remove unused intermediate methods in NQE (network quality estimator).
This CL does not introduce any functionality changes.

Change-Id: I3d345443f48a7775e42c2d88b218ecc8d726671d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498721
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681190}

3.19.0 -> 5.16.0

This CL removes/adds many dependent packges.

New packages:
@babel/highlight 7.0.0, https://www.npmjs.com/package/@babel/highlight, MIT
astral-regex 1.0.0, https://www.npmjs.com/package/astral-regex, MIT
chardet 0.7.0, https://www.npmjs.com/package/chardet, MIT
cross-spawn 6.0.5, https://www.npmjs.com/package/cross-spawn, MIT
emoji-regex 7.0.3, https://www.npmjs.com/package/emoji-regex, MIT
external-editor 3.0.3, https://www.npmjs.com/package/external-editor, MIT
fast-deep-equal 2.0.1, https://www.npmjs.com/package/fast-deep-equal, MIT
fast-json-stable-stringify 2.0.0, https://www.npmjs.com/package/fast-json-stable-stringify, MIT
flatted 2.0.0, https://www.npmjs.com/package/flatted, ISC
functional-red-black-tree 1.0.1, https://www.npmjs.com/package/functional-red-black-tree, MIT
iconv-lite 0.4.24, https://www.npmjs.com/package/iconv-lite, MIT
import-fresh 3.0.0, https://www.npmjs.com/package/import-fresh, MIT
is-promise 2.1.0, https://www.npmjs.com/package/is-promise, MIT
isexe 2.0.0, https://www.npmjs.com/package/isexe, ISC
json-schema-traverse 0.4.1, https://www.npmjs.com/package/json-schema-traverse, MIT
json-stable-stringify-without-jsonify 1.0.1, https://www.npmjs.com/package/json-stable-stringify-without-jsonify, MIT
mimic-fn 1.2.0, https://www.npmjs.com/package/mimic-fn, MIT
nice-try 1.0.5, https://www.npmjs.com/package/nice-try, MIT
os-tmpdir 1.0.2, https://www.npmjs.com/package/os-tmpdir, MIT
parent-module 1.0.1, https://www.npmjs.com/package/parent-module, MIT
path-key 2.0.1, https://www.npmjs.com/package/path-key, MIT
punycode 2.1.1, https://www.npmjs.com/package/punycode, MIT
regexpp 2.0.1, https://www.npmjs.com/package/regexpp, MIT
rxjs 6.5.2, https://www.npmjs.com/package/rxjs, Apache-2.0
safer-buffer 2.1.2, https://www.npmjs.com/package/safer-buffer, MIT
semver 5.7.0, https://www.npmjs.com/package/semver, ISC
shebang-command 1.2.0, https://www.npmjs.com/package/shebang-command, MIT
shebang-regex 1.0.0, https://www.npmjs.com/package/shebang-regex, MIT
signal-exit 3.0.2, https://www.npmjs.com/package/signal-exit, ISC
tmp 0.0.33, https://www.npmjs.com/package/tmp, MIT
tslib 1.10.0, https://www.npmjs.com/package/tslib, Apache-2.0
uri-js 4.2.2, https://www.npmjs.com/package/uri-js, BSD-2-Clause
which 1.3.1, https://www.npmjs.com/package/which, ISC

Chrome binary will include none of them.

Bug: 977046
Change-Id: Ic9b03e913ca3544f0630d5d842eff163459f2b66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668495Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681189}

Its currently in wallpaper view even though it only does overview
functions, and we will be adding much to it shortly.

Test: none
Bug: 981174
Change-Id: Ib32ebfad1fa137450aa790b1cb018e82778e26c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714288
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681188}

UKM shows that 0.0025621 % of reports have a weird quirk where dropped
frames exceed decoded frames by 1. I've been unable to determine the
cause of the off-by-one, but we don't want to simply throw out the data
because this is a very strong signal the machine can't keep up. Instead,
this CL just caps all frame counts to the total number of decoded frames.

Additionally, 0.385807851 % of records in the DB appear to be corrupted.
This causes our proto's double fields to contain crazy high values,
triggering exceptions (crashes) in floating point math. This CL will
discard any DB data that is obviously corrupt. This is tied to the
above fix because we can now consider dropped > decoded to reliably be
DB corruption.

Bug: 796885,982009
Change-Id: Id7d0adb509d7e20b3b61453e7407c8efff9feb86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717403Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Auto-Submit: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681187}

CA Overlay Validator has simple logic and could be easily merged into
a subclass of overlay processor.

R=rjkroege

Bug: 963597
Change-Id: Ia6334b82a8826740098ad279b74cd044ff4d8d42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664973
Commit-Queue: weiliangc <weiliangc@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681186}

This CL removes blink::NFCError by creating a util function
NFCErrorTypeToDOMException() to do what blink::NFCError::Take() does
instead, because blink::NFCError::Take() is not really needed given the
fact that we do not use CallbackPromiseAdapter anywhere across nfc code.

BUG=520391
TBR=dcheng
for the trivial change in nfc_type_converters.cc

Change-Id: I67b1d6f6bb47b456b92a0a7ccca26f21c21a0004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717867Reviewed-by: Leon Han <leon.han@intel.com>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#681185}

https://chromium.googlesource.com/angle/angle.git/+log/08b97da894b2..c327370e72d3


git log 08b97da894b2..c327370e72d3 --date=short --no-merges --format='%ad %ae %s'
2019-07-25 jmadill@chromium.org Vulkan: Pass VkExtent3D to TextureHelper::init.
2019-07-25 syoussefi@chromium.org Vulkan: Fix image copy flipping
2019-07-25 syoussefi@chromium.org Fix read framebuffer binding sync before copy image


Created with:
  gclient setdep -r src/third_party/angle@c327370e72d3

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=jmadill@chromium.org,jmadill@google.com

Bug: None
Change-Id: Ic310ec4e755daaceaa9d3c2b653d010697a56a50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719430Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681184}

Mojo JS Lite Bindings were recently renamed to align with the new C++
names. This CL changes usage of the old names with the new ones. See
bug for more details.

Bug: 968369
Change-Id: I17f82ce239503282f6dacf8ce828ba7ab1b3b70b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714464Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681183}

The log is only for testing the flag that was just added for updating
hover, it is merged by mistake, now remove it.

TBR=bokan@chromium.org

Bug: 877132
Change-Id: I6a5ac31e7c7274dcd246f97d90487d8fbd945b45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719575Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681182}

This patch removes an unused function.

Bug: 985201
Change-Id: I6fe7f88596ebf8fc719f714c425079c66203e43b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719346
Auto-Submit: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681181}

Only attempt to fetch hints if the network is available.

Note: The Optimization Guide does not support iOS but is in components
due to supporting Previews. A future refactor of Previews may allow for
 moving Optimization Guide to the browser layer. An assertion was added
to the BUILD.gn file to make the iOS decision more clear.

Bug: 986817
Change-Id: Iafa4101b42147530e0b38f2d6a4eb36a7ddac37c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715505Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681180}