- 16 Apr, 2020 40 commits
-
-
Clark DuVall authored
This was in c/b/content_settings but seems to make more sense in browsing_data since all the types it holds are in browsing data. This moves CreateCookiesTreeModel() to collected_cookies_views.cc since that's the only place it's used. Bug: 1070825 Change-Id: Ib41e130fc77d492d691538d23cc4ef3e6cf4b696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151328Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#759649}
-
Sigurdur Asgeirsson authored
Bug: 1071090 Change-Id: I9e3fc5f6d78050ee819c827abae4ca76cc291f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150059 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#759648}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6e711c377517..d28d4891fbd9 git log 6e711c377517..d28d4891fbd9 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@d28d4891fbd9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id95c185d88f35d73b3e742427c597d8778c3974d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152441Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759647}
-
David Roger authored
These histograms are still useful in particular because we are going to migrate desktop platforms to multilogin, and these histograms will be used to check the success of the migration. We may consider keeping the histograms even after the migration is complete, but we'll see at this time. If we want to keep them indefinitely we should maybe consider renaming them however, because they are specific to multilogin, and it's not really captured in their name. Fixed: 1059815 Change-Id: Iff2860a961945e01abd965a51be9d90a1e121185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151457 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759646}
-
Virender Singh authored
Body element should be the default focused element when a PDF is opened. For both embed and non-embed scenarios body element is the default focus item. Bug: 1041417 Change-Id: I538c434239575a0ff8c6a3ee7368c7c5fe7047f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141997Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Virender Singh <virens@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759645}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2430d665d3f2..45e5510c53da git log 2430d665d3f2..45e5510c53da --date=short --first-parent --format='%ad %ae %s' 2020-04-16 bclayton@google.com Fix chrome autorollers 2020-04-16 bclayton@google.com Reimplement LRUCache, fold away LRUSnapshotCache, add tests. Created with: gclient setdep -r src/third_party/swiftshader@45e5510c53da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ib4e514952c82e33d90061783d7d05a40a1b6dc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152437Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/938b4532b48f..7a9c9d66f12c git log 938b4532b48f..7a9c9d66f12c --date=short --first-parent --format='%ad %ae %s' 2020-04-16 prashant.n@samsung.com Make SkM44 public. 2020-04-16 reed@google.com separate m44 tests Created with: gclient setdep -r src/third_party/skia@7a9c9d66f12c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I51828c78fc6711723fa09457fb673220d544138a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152440Reviewed-by:
-
Antonio Gomes authored
BUG=767015, 1063749 R=rego@igalia.com Change-Id: Ifc75702730ea9528c431a0245bda488cde370bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151385 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#759642}
-
Ross McIlroy authored
BUG=v8:9684 Change-Id: If46fb6e37100f90fb7cc25dcad1824a2f135d8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151506Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#759641}
-
sauski authored
This CL aligns the description in the new cookie controls of what may happen when third party cookies are disabled to that already present on the incognito NTP. Bug: 1069687 Change-Id: I75578604cd55d2613b6c73686a92fb5c1835947b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145883Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#759640}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5f3889a6dff8..d113c17a489e git log 5f3889a6dff8..d113c17a489e --date=short --first-parent --format='%ad %ae %s' 2020-04-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 1be434141625..0d4857ea576a (1 commits) 2020-04-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 81e08df29531..2430d665d3f2 (4 commits) 2020-04-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 3f7e3cbf33a7..3682237cb326 (1 commits) Created with: gclient setdep -r src/third_party/angle@d113c17a489e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I9d84e0768f63a4dff23846903b92dccd1d671fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152435Reviewed-by:
-
Gyuyoung Kim authored
This CL migrates flex-sizing-columns-min-max-width.html from fast/css-grid-layout to external/wpt/css/css-grid/grid-definition with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to flex-sizing-columns-min-max-width-001.html to be align with existing tests. Bug: 1063749 Change-Id: Ia88b67bd6ace8b2901990da9da26e5643a2ceaf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152127 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d67b97dfbac8..bb63adbd88be git log d67b97dfbac8..bb63adbd88be --date=short --first-parent --format='%ad %ae %s' 2020-04-16 lalitm@google.com Merge "Revert "tp: ensure that sde_tracing_mark_write tgid is always set to be kthreadd"" Created with: gclient setdep -r src/third_party/perfetto@bb63adbd88be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I780d50834fbba4c9e04c2b96ccc1a1f21f1f95fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152439Reviewed-by:
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/fast/css-grid-layout/ into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749, 767015 Change-Id: Id9bff09a76842aa9d96d566cce5c6731d9b6d530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148746 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8ec11b831293..3d687a1e3e31 git log 8ec11b831293..3d687a1e3e31 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 magjed@webrtc.org Add null checks in stacktrace.cc Created with: gclient setdep -r src/third_party/webrtc@3d687a1e3e31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7860844146a93ee25d4903e532d9d00185fba4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152438Reviewed-by:
-
Jérôme Lebel authored
Adding IOSTrustedVaultClient using ChromeTrustedVaultService class. Replacing FileBasedTrustedVaultClient for IOSTrustedVaultClient in IOSChromeSyncClient. Related: - crrev.com/c/2116079 ChromeTrustedVaultService - crrev.com/i/2774364 ChromeTrustedVaultServiceImpl => crrev.com/c/2118054 IOSTrustedVaultClient Bug: 1019685 Change-Id: I3c9640a52da4132fbad7d5cb19d94a8e05c81c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118054 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#759634}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/157451f9900a..6e711c377517 git log 157451f9900a..6e711c377517 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 janscheffler@chromium.org Show cookies for unreachable frames Created with: gclient setdep -r src/third_party/devtools-frontend/src@6e711c377517 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1047348,chromium:1057948,chromium:1066415 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I097de539321a4d69fd82e6210f17a2dba5cf6acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152436Reviewed-by:
-
Keishi Hattori authored
BackgroundFetchRegistration does lazy initialization, but that isn't really necessary because the initialization is done right after. Change-Id: I3b762beaed14a01d729f413d2c6ccf438affc514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143882Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759632}
-
Hitoshi Yoshida authored
This CL updates IDL files and/or related C++ code to be consistent with spec, as far as the changes do not change actual behaviors. What this CL does are - Add default values on some dictionary members - Check if a dictionary member is missing before accessing it. - Check if a dictionary member value is null, if its type is nullable. After this CL, they would work as expected also with the new IDL compiler which is under development. Bug: 839389 Change-Id: Ic7740092fe28bc4a76c0e5f5e268c6d112612cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120079 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#759631}
-
Marc Treib authored
The PasswordAccountStorageUserState covers the sign-in state and account storage opt-in state of the current user. It will be used for metrics (but is not used yet in this CL). Bug: 1063852 Change-Id: I85a0e5f310e6b766f8fcc7986c1170cdb9580bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149358 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#759630}
-
Mugdha Lakhani authored
Offline Pages isn't a feature WebLayer intends to support for now. Move offline pages related logic from PageInfoController to ChromePageInfoControllerDelegate so that the former can be componentized. Bug: 1052375 Change-Id: I59fc6208a5ce3528c6d0e59da3733679d63ea894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144029 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#759629}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d7247aad..652f83ad Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ied7ee82706db8e335a65c44ef73c03f7c70e3ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151550Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759628}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a6fbe4e685f0..938b4532b48f git log a6fbe4e685f0..938b4532b48f --date=short --first-parent --format='%ad %ae %s' 2020-04-16 reed@google.com Revert "transition matrix44 to opt-in only" Created with: gclient setdep -r src/third_party/skia@938b4532b48f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Id49df72286dc274f9cbeffe6cc4fbc9439775f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152432Reviewed-by:
-
Rainhard Findling authored
* Deprecate the |ENABLED| SB state in safety check and use |ENABLED_STANDARD| and |ENABLED_ENHANCED| states instead. * This CL updates the JS side of safety check. The C++ side is updated in crrev.com/c/2141983. Bug: 1015841 Change-Id: I24388fec9060eebe43dbfb7f537dd88080560fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148735Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#759626}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 82c12e80. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 788a3bf1 "[css-grid] Migrate grid-auto-repeat-intrinsic.html to WPT" f9b790bb "[css-grid] Fix percentage track sizing functions in size containment" 9c8b766c "[css-grid] Migrate grid-auto-fit-rows.html test to WPT" 9373f79e "[css-grid] Migrate grid-baseline.html to WPT" b792b260 "[css-grid] Migrate grid-baseline-margins-1.html to WPT" 44402a06 "[css-grid] Migrate grid-baseline-margins-2.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I97b5ef280eff559728efe1418eb5c95402f1925f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151968Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759625}
-
Abhijeet Kandalkar authored
Migrate this test out of t_p/blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. This test verifies that repeat(auto-fill, ) syntax works as expected inside grid layout. Bug: 1063749 Change-Id: I2b2f2d02ecdb250a42b38ac4b5773c546ce9e637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147487 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#759624}
-
Andrey Zaytsev authored
This state is present on non-Google branded browsers, where it is not possible to check for updates directly. In this case Safety check simply prints out the current version. Bug: 1015841 Change-Id: I23e54330366fb722f36a7b6732970c0627a9a705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144038Reviewed-by:
-
Daniel Cheng authored
- roll.py has been updated to apply local patches *before* attempting to configure libxml. This allows issues at Makefile generation to also be locally patched if needed. - roll.py now uses input redirection for applying patches, so missing patch files are now a fatal error. Missing files would previously be ignored, since only the exit code of the final command in a sequence of piped commands is considered for success/failure. - libxml2-2.9.4-security-CVE-2017-7376-nanohttp-out-of-bounds-write.patch is no longer needed. This has been fixed an alternate way upstream, though it is somewhat unclear why parsing a port number larger than 65535 is desirable. - revert-non-recursive-xml-parsing.patch: recursive to non-recursive conversion of XML parser is causing test failures. - add-missing-ifdef-in-xml-reader.patch: add a preprocessor check around error handling for a feature that is disabled in Chrome. Change-Id: Iee172f9142146224b70cc35d3b97ced6786c1b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142719Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#759622}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/51591a540007..d67b97dfbac8 git log 51591a540007..d67b97dfbac8 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 taylori@google.com perfetto-ui: Fix time slider Created with: gclient setdep -r src/third_party/perfetto@d67b97dfbac8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:153765614 Tbr: perfetto-bugs@google.com Change-Id: Ic1372c1ab13aa3730b36e5eddc5a719e5e50f7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152428Reviewed-by:
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/fast/css-grid-layout/ into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749, 767015 Change-Id: Ib7d476bc45aa3d2364c6d723d6b085f25632651f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144021 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Oleh Lamzin authored
Remove logic that checks whether MAC address source property on USB Ethernet adapter must be updated. This logic is complicated and doesn't work very well. For example, 0. policy value for MAC address source is "designated_dock_mac" 1. device is not link up and has MAC address source property equals to "designated_dock_mac" 2. we send request to change MAC address source to "usb_adapter_mac" 3. device is link up, but MAC address source property hadn't been updated, so we update path to primary USB Ethernet adapter 4. device MAC address source property was updated to "usb_adapter_mac", but we see that primary USB Ethernet adapter didn't change and policy value is still the same. Here we have to verify that primary Ethernet adapter still has correct property. After applying this CL, each time there will be property value verification. Side effect of this CL is that we may send the same request to shill few times. In practice, it's only 2 requests. BUG=b:152425041 TEST=manual end-to-end TEST=existing unit tests Change-Id: I773aeff67d0aae9a2bb5e7172e3677dbd8a18141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150598 Commit-Queue: Oleh Lamzin <lamzin@google.com> Auto-Submit: Oleh Lamzin <lamzin@google.com> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#759619}
-
Anders Hartvoll Ruud authored
This is the "Keyframe Animation Inconsistency" described in the initial StyleCascade design doc [1] (see Appendix). This was fixed at some point during the StyleCascade work, probably when interpolations started using the same StyleCascade instance as the main declarations. The test only asserts equality between the standard and custom property cases, while ignoring absolute values, as browser disagree wildly on what that value should be at the moment [2]. [1] https://docs.google.com/document/d/1HrmPmcQBTUMouqQQG3Kww43I5aFW9-Q9tr-DEKZk09I [2] https://github.com/w3c/csswg-drafts/issues/3751 Change-Id: I1447aea439fe60cce1d280b0310a0983e71155b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150432Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#759618}
-
Andrey Zaytsev authored
Bug: 1015841, 1068587 Change-Id: I84a2b48fb179a5d8959864cf4429a18130ca2d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141983Reviewed-by:
-
Michael van Ouwerkerk authored
This is particularly important for persistent notifications in their current form, because having multiples on screen is not helpful. Change-Id: I52a92095124c60de14ad8032dd5b53dbd724145e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144076Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#759616}
-
Harald Alvestrand authored
This change makes sure the SetLocalDescription completes before we call SetRemoteDescription. If we don't wait, we will sometimes see a change to have-remote-offer rather than the expected change to first have-local-offer, then stable (and then have-remote-offer, but the test doesn't wait for that). Bug: chromium:1071329 Change-Id: I7eaa06a71edff92e76448ac2ef1fdfecee795ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152446 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#759615}
-
Hidehiko Abe authored
This is preparation to support LaCrOS Chrome. BUG=chromium:1043804 TEST=Ran tryjob. Change-Id: I6036f44cedab76560d6d1c0031aa030870707a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084774Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#759614}
-
Victor Hugo Vianna Silva authored
No behavior is changed. The interface methods are altered to return an optional ModelError instead of the older SyncError. To achieve this, some helper methods in the implementations must be changed in that same way, which is a natural step in the final goal of eliminating the SyncError class. Change-Id: I7211eb1613aabb8bce9273765c943a3ec1fd958c Bug: 1057577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093482 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Harald Alvestrand authored
This avoids some MSAN error messages. Bug: chromium:787254 Change-Id: If01797d8bd1a57ea44a151ad3bdd74e3cb4aecc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152365 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
-
Rushan Suleymanov authored
The following histograms were removed after M80 because they are only relevant for the deprecated and deleted bookmarks sync directory implementation: - Sync.BookmarksModelSyncStateAtNewDuplication - Sync.BookmarksDuplicationsAtAssociation Code has been removed in http://crrev.com/c/1863808 Bug: 1053166 Change-Id: Iabdbe8ffd467c395756eeb43e080fb3e1a8f6bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148322 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/159f3561ccfa..5491b2a8263c git log 159f3561ccfa..5491b2a8263c --date=short --first-parent --format='%ad %ae %s' 2020-04-16 fancl@chromium.org Cleanup old versions when push-on-green Created with: gclient setdep -r src/third_party/catapult@5491b2a8263c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: I253821c5f342406f9843dfa3f306949bb34e3d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152426Reviewed-by:
-
