- 09 Jan, 2020 40 commits
-
-
Jared Saul authored
Change-Id: I60c326d0e44376a13ff1ebceaaf53e3de415bdc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991499 Auto-Submit: Jared Saul <jsaul@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#729602}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bd26a09fd13c..52175631d301 git log bd26a09fd13c..52175631d301 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 rmhasan@google.com Revert "[Typ] Allow typ expectations parser to escape the '*' character" Created with: gclient setdep -r src/third_party/catapult@52175631d301 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036130,chromium:1038130 Tbr: oysteine@google.com Change-Id: Iaa236420306a8726e0a25b9aca2f0ad3d8264a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992736Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729601}
-
jonross authored
It is not desired to have --fuzzy-diff be the default for blink_web_tests on Linux. This had originally been done as a part of SkiaRenderer's development. This change: - removes --fuzzy-diff as the default. - updates the Linux port to disable SkiaRenderer - changes non_skia_renderer_swiftshader_blink_web_tests to be skia_renderer_swiftshader_blink_web_tests with SkiaRenderer reenabled and fuzzy-diff re-added for just this configuration. - Updates TestExpectations for current failures. The update to TestExpectations is temporary, it will allow us to land the non-fuzzy tests. We will be triaging the failures, and landing rebaselines as needed separately. Or filing more specific bugs for the failures. non_skia_renderer_swiftshader_blink_web_tests was used to keep an eye on regressions for the non-SkiaRenderer case while SkiaRenderer rolled out. We will return it to that once we can re-enable SkiaRenderer by default for blink_web_tests. We will be following this up by triaging all failures that occur with SkiaRenderer on and fuzzy-diff off. Then rebaselining/addressing bugs as needed. TEST= blink_web_tests skia_renderer_swiftshader_blink_web_tests Bug: 1039401 Change-Id: Ia4f88e41e6288947135eb6f19a0290f1a0d090a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989866 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#729600}
-
Sergey Ulanov authored
Cleared flag was not set when importing GpuMemoryBuffer to a SharedImageBacking. As result SharedImageRepresentationSkia::BeginScopedReadAccess() was returning nullptr when trying to render video frames on Fuchsia, as result video content wasn't rendered properly. Fixed ExternalVkImageBacking::CreateFromGMB() to call SetCleared(), since imported GMBs are supposed to have the content initialised when they are imported. Bug: 1040250 Change-Id: I324e902418956e631e4da6ad7f723992b2074f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992595 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729599}
-
yilkal authored
This cl does the following: 1. Adds PrefChangeRegistrar to AppTimeController to enable it to be notified when user policy has changed. 2. Enables prefs::kPerAppTimeLimitsWhitelistPolicy policy to be used in WebtimeLimitEnforcer. Bug: 1015661 Change-Id: Ifd5e0ddc3df9f564ffb018244e652c8b88586865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946936 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#729598}
-
Brandon Jones authored
Test was producing a minor image diff, has been triaged. Bug: 1040202 Change-Id: Iae6dd08ea4b97d7f4975971b8abbb948d97867d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992564Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#729597}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/99c274baf503..c431d59626e1 git log 99c274baf503..c431d59626e1 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 jmadill@chromium.org Add Serial to all GL resources. Created with: gclient setdep -r src/third_party/angle@c431d59626e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Ib329ead2b78c6f15d93ae16939165eb60049a1ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991837Reviewed-by:
-
Brandon Wylie authored
I verified this is no longer flaking with 500 local runs, I'll continue to monitor in the coming days. TBR=tedchoc@chromium.org Bug: 1020381 Change-Id: I170649506ae0d958ee5e7921b4e11c5d90a548da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992364Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#729595}
-
Weilun Shi authored
Support class type in json_to_struct and use C++ class base::Optional<bool> for is_low_end_device instead of OptionalBool. Bug: 987717 Change-Id: Ica6b475af788bbe9842c8630ef96e2ad6ad7f80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973491Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#729594}
-
Antonio Gomes authored
... now that it resides out of the Blink API layer. BUG=704136 R=haraken@chromium.org Change-Id: Ibfc613dea5f304c9c29cd96a2465e71cfbe7a7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991404 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#729593}
-
Dan Beam authored
R=rbpotter@chromium.org Bug: none Change-Id: I7b149467709f5bb8d80bbc1c933da97675c8799e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992593Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#729592}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8a7067d88174..77c89ff847b6 git log 8a7067d88174..77c89ff847b6 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 bclayton@google.com Build: Verify that we're compiling with C++14. 2020-01-08 bclayton@google.com Build: Move from using C++11 to C++14. 2020-01-08 bclayton@google.com Kokoro: Update from GCC 4.8 to GCC 7. Created with: gclient setdep -r src/third_party/swiftshader@77c89ff847b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I44c6a9a3bf6e334124c9fb7716b746c23eef1288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992720Reviewed-by:
-
Ahmed Mehfooz authored
This change ensures that the tray remains expanded or collapsed when opened after being previously expanded or collapsed by the user. Change-Id: I66f5547e36f7f245f75eabfa74fb63e021bbe20f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992168 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#729590}
-
Arthur Wang authored
Bug: 1021309 R=harringtond@chromium.org Change-Id: I785b5adb86041f554e13966377e35532aead0d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992681 Commit-Queue: Arthur Wang <wuwang@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#729589}
-
yilkal authored
This cl adds kPerAppTimeLimitWhitelist child user policy. The policy specifies the always allowed URLs and applications that will not get blocked. The whitelist policy overrides settings configured by PerAppTimeLimit. Support for whitelisting URLs, for example, is required because there are certain crucial access requests to URLs that should not be blocked even though the PerAppTimeLimit policy's set time limit on chrome has been reached. Examples of these URLs are chrome://*, file://* and support.google.com. Bug: 1022093 Change-Id: Ic625ca5e301bd742925bc88af06395a05b39337c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929086 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
-
rbpotter authored
Bug: 967861 Change-Id: I9fca173ca4b364066ed669ba5fc888114e96d640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992683Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#729587}
-
Nicolas Zea authored
zea@ is leaving Chrome, removing from OWNERS files Change-Id: I4df1ad4b3545cca91489ab7f26f1c0edf0b99bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986245 Commit-Queue: Nicolas Zea <zea@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729586}
-
Oksana Zhuravlova authored
This change adds traces under BrowserMainLoop::CreateThreads:PreMainMessageLoopRun(). Bug: 1019793 Change-Id: I89577b30b797af78e19cf6afc0079a264fc1df97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986906Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#729585}
-
Antonio Gomes authored
... down to renderer/platform/mediastream, and also rename it to webaudio_destination_consumer.h. BUG=919392, 704136 R=haraken@chromium.org Change-Id: I1592af19495c729ab7911036c1a6858e610822f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991403Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I08583b374f6ac6fc688730cba2ab91ee4688cf3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992724Reviewed-by:
-
Fabrice de Gans-Riberi authored
This reverts commit 71a290c2. Reason for revert: Suspected cause of failures in WizardController* tests on chromeos: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/1413 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/16312 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/33460 Original change's description: > Reland "Squash top level error code returned from host resolver." > > This is a reland of 834f2092 > > Original change's description: > > Squash top level error code returned from host resolver. > > > > If the host resolution process fails, the top level error code should > > now be only ERR_NAME_NOT_RESOLVED. A more specific error code (e.g. > > ERR_CONNECTION_REFUSED if a secure mode DoH server was offline) may be > > found in ResolveErrorInfo. > > > > Bug: 1016325 > > Change-Id: I9f5f857fffd71be6485d05280239cd0b649d7a8f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974678 > > Commit-Queue: Katharine Daly <dalyk@google.com> > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Eric Orth <ericorth@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#728725} > > Bug: 1016325, 1039639 > Change-Id: Ifcf5d1c8d3e5558e81b9efc784d234d034ee9a52 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990249 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Katharine Daly <dalyk@google.com> > Cr-Commit-Position: refs/heads/master@{#729518} TBR=jam@chromium.org,mmenke@chromium.org,ericorth@chromium.org,dalyk@google.com Change-Id: If09e8178659f5d47503ccee5cb8919d099b2330a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016325, 1039639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992812Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#729582}
-
Matt Reynolds authored
A single physical device may expose multiple HID interfaces. Each interface is represented by a HidDeviceInfo object. To allow HidDeviceInfo objects to be grouped by physical device, a |physical_device_id| member is added that will be used to identify the physical device. This CL adds the new member and updates callsites to provide a value for the physical device ID when constructing a HidDeviceInfo. The platform logic to construct the ID will be added in a followup CL. BUG=1011499 Change-Id: I0f821de0693d625a5279f057b9986dc71923ccda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987113 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729581}
-
Sam Fortiner authored
We plan to start experimenting with preferring compositing over LCDText in the next couple weeks (tracked via https://crbug.com/984346). This histogram will help provide insight into the impact on text quality and needs extended to cover the experimentation timeframe. Bug: 1036860 Change-Id: I8612404f727604b0f94211c1bbfa5233c2d9acf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990259Reviewed-by:
-
Alex Cooper authored
vr_pixeltests were failing on Windows 7, so they were disabled for all windows platforms, though the evidence is that they were fine on other platforms. Given that VR is not supported on Win7, only disable these tests on that platform. Fixed: 1035767 Change-Id: Ic97593f9b324c30111ec1465ae3da41de7aa2c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985126Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#729579}
-
Gang Wu authored
https://cs.chromium.org/chromium/src/skia/ext/image_operations.cc?g=0&l=408 The first parameter should be the source of image, not the destination. Bug: 1039791 Change-Id: Ib0fc4cc2b3a15143b4ceb3de7ca558e0d279e3ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990206 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#729578}
-
Kent Tamura authored
If a radio button is connected or owned by a form, radio button groups are managed by RadioButtonGroupScope in order to complete various operations for a group in O(1). Otherwise, we did not assume a radio button belonged to any groups. It didn't conform to the HTML standard, and was not interoperable with Firefox. After this CL, such radio buttons are grouped without RadioButtonGroupScope's help. We iterate over the tree including the target radio buttons to find a checked button in the group or |required| attribute in the group. Bug: 883723 Change-Id: I56185559592dff6b0254655aeb499ed6ac29df64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988087 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Ross Zwisler authored
We will need this flag until we have completed the uprev of SKL-Y and SKL-U Chrome OS systems to their new kernels. It's unclear exactly when this will be done, but my best guess right now is around M87. Also, remove Jon from the flag contacts as he's moved on to other adventures. BUG=b:144308685 Change-Id: I7675b7542b8f73a82f958bb50dfc9bd64a91486a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991723Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Ross Zwisler <zwisler@google.com> Auto-Submit: Ross Zwisler <zwisler@google.com> Cr-Commit-Position: refs/heads/master@{#729576}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I8082fccac2a20d00e916f9e6d2abeb88de8e1ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991983Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#729575}
-
Gyuyoung Kim authored
This CL replaces .mojom.h includes with .mojom-forward.h in device/gamepad to reduce the pre-processed size of header files and shorter build time. Additionally, this CL modifies device/fido as well. - device/gamepad - device/fido This CL has no behavior changes. Bug: 1001360 Change-Id: If8a759c7551699c41d594ef4831d2f099bec02a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989710Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#729574}
-
Karan Bhatia authored
It's not used anymore. BUG=None Change-Id: I62d5b22b61ed08e7a6be8fac730506137b5b5b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992502 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#729573}
-
Ian Kilpatrick authored
Previously we'd store intermediate calculations of margins directly on a FlexItem's box. This instead stores the intermediate margin calculations on the FlexItem directly. This is primarily just a refactor / cleanup. (The existing code was fine, not causing any bugs/issues), but was somewhat confusing from a LayoutNG p.o.v. as transient calculations shouldn't be stored directly on the LayoutBox. Change-Id: Ia37b3837ecbbfbd3f61c19571536fc8484d85d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977196 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#729572}
-
Simon Que authored
This CL migrates the trunk/branch builders: CI: - GPU Win x64 Builder - Win x64 Builder Try: - win10_chromium_x64_rel_ng Schedule of migration: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413 Change-Id: I0a688a919a1199a583200ce8d4928777c03b7370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965739Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#729571}
-
Johannes Henkel authored
Upstream PR: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1990896 New Rev: dee0c0c65cc2df6284e75ae9fca083dc604c9fca TBR=caseq Change-Id: I66f6146ec38c1abfeeb04822cb7d1c7f64b580ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992202 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#729570}
-
Michael Spang authored
Chromecast cross compiled builds are always stripped before being deployed to the target, so local symbolizion doesn't work there. Enable print_unsymbolized_stack_traces in this config to ensure traces are in a consistent format, which should be post-processed with asan_symbolize.py. Bug: 1040148 Change-Id: Ib133644336beba363faf0efe7792d8bee62531c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991727Reviewed-by:
-
Natalie Chouinard authored
Extract the following preferences to Settings build target, along with owned resources: - ButtonPreference.java - ChromeBaseCheckBoxPreference.java - ChromeSwitchPreference.java - TextMessagePreference.java Bug: 1035928 Change-Id: I1aa8e616bbb1b98bc4217ef2669d5388dab40cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991732 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#729568}
-
Kurt Horimoto authored
This is the only infobars::InfoBar subclasses used on iOS. Bug: 1030357 Change-Id: I70bc1336792bd861921dcafbec20ffa7ed1a6142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990077 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#729567}
-
Chong Gu authored
When remote debugging port set to 0, allow web_engine_shell to find available port to use. Allow web_engine_shell to log the remote debugging port (if turned on). Bug: 1014642 Change-Id: I7e7b98f10eb8ea0aa17c1a4761bbb50bf9d32dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984626 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#729566}
-
Yuichiro Hanada authored
We changed the flag according to whether an app is launched by a key event or not, however it leads to undesirable results because of the unpredictability of which element will be focused on startup. This CL stops sending an intent to exit touch mode when launching an ARC++ app by a key event. Bug: b:146477273 Test: Launch app by enter key and checks the mode is not changed. Change-Id: Id57099803572cb3e800553c4cbb1022cc215a1f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977876Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#729565}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a47e1e9794a7..bd26a09fd13c git log a47e1e9794a7..bd26a09fd13c --date=short --first-parent --format='%ad %ae %s' 2020-01-08 mattm@chromium.org netlog_viewer: remove obsolete code to handle 0 source IDs Created with: gclient setdep -r src/third_party/catapult@bd26a09fd13c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: oysteine@google.com Change-Id: I831b8996493d19690d1baa949ada7bcd1b96e623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991796Reviewed-by:
-
Mia Glaese authored
Adapt metrics collection to OverviewModeStates. Before: State change metrics are collected at visibility change, even if state does not change. After: Metrics are only collected if state changes. Bug: 1025296 Change-Id: I1e6ab1282a7a154d5542d24f27b6b97a942ba32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980477 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#729563}
-
