- 30 Nov, 2020 40 commits
-
-
Garrett Beaty authored
A generator is added that outputs some numbers representing our goma usage. The values have no concrete meaning, but approximate the load applied to goma for the project and the relative load for different builders (with some numbers being very rough approximations). Changes that modify the generated file require a footer in the CL description in order to submit. Bug: 1145230 Change-Id: I6d58deee27e9bc6d220f87311a6266c220f03e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556210 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#831871}
-
Anastasiia N authored
InlineLoginDialogChromeOS::ShowDeprecated will be removed when all calls to the dialog will be migrated to call AccountManagerFacade instead. Bug: 1140469 Change-Id: Ide858dffd4253ab9088a33dc1a4303522428f367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550681 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#831870}
-
Fredrik Söderqvist authored
Change-Id: I845087099ddd7aabd43624e34a43aa4b782b864f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561628 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#831869}
-
Jesse Doherty authored
Mobile.SystemNotification.Content.Click::Downloads - Files is used as part of a high level guiding metric. We're trying to consolidate these metrics as user actions to improve query speeds and enable new analysis. Bug: b/161525144 Change-Id: I9c1522cd9399bccb35dbfd47450b9f5b1257108f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533696Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#831868}
-
kylechar authored
Run clang-tidy with analyzers enabled for Chromium and apply the automated fixes to Chrome graphics code. Also fix linter errors that were failing presubmit on upload in the same files. Bug: none Change-Id: I41a020c7eae44f40a08b2018cf8e49c3be9c710c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563920Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#831867}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d8bb0bb7c735..2fe7335d34bc 2020-11-30 jiawei.shao@intel.com Skip two MultisampledRenderingTest tests on D3D12 with debug layer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: Icd06e27a41390a3c58a49ca36d87a078500f9ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564895Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831866}
-
Yi Gu authored
Major changes: 1. Adds a new policy-controlled feature "otp-credentials" to allow the iframe to get credentials from its parent frame. 2. Supports parsing SMSes with format "@top.com #code @iframe.com" 3. Passes along a list of origins in the system instead of a single origin previously. More details on the context: https://github.com/WICG/web-otp/issues/50 Bug: 1136506 Change-Id: Ic458e51c33b721a80204abb490776b436086bff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497992 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#831865}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 374b0e9f. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ieb808731569c7b07778a606365cf3b5158942069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564814Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831864}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I3491e8450ba4a0720073862afb1ca117524166f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550263 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831863}
-
Scott Violet authored
These tests trigger the 'open in chrome' menu item, which may trigger the disambiguation dialog. This adds code to ensure that doesn't happen. BUG=1148855 TEST=test only changes Change-Id: I15e268d0d0d7c8b308e853fab4193e27485ee2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548363Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#831862}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3d061021c920..5968da649c17 2020-11-30 jmadill@chromium.org code gen: Be more robust to dirty hashes. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I7aaa35b29c7b7274010fd0dba31e6a6485e6de6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565391Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831861}
-
Roman Aleksandrov authored
Add oobe-adaptive-dialog which could be either a proxy object for old layout or implementation of a new layout. Change the screen container styling depends on which type of a layout is shown. Propagate horizontal / vertical mode from C++ to html label since @media orientation doesn't work inside oobe. Bug: 1151292 Change-Id: Ib39b38f159a41b09a30eef25895a28fef4114bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543940 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831860}
-
Tim Dresser authored
Bug: None Change-Id: I859eafd2cd1ff683e6c8aba4257271faa9f34d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547960Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#831859}
-
Chris Sharp authored
Bug: 1018157 Change-Id: Id7f047bf87b1bca596f2c1ed4b693df8bf327178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551486 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831858}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/633335551f5d..03097b03496d 2020-11-30 tvanderlippe@chromium.org Fix running layout tests 2020-11-30 alexrudenko@chromium.org [DarkMode] turn off legacy patching for accessibilityNode.css 2020-11-30 tvanderlippe@chromium.org Remove HTMLElement title prototype override 2020-11-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152736 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia9ac804435e29e5f679d5bf72f06e7569366f35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564897Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831857}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I7b32ee35d356eb9ea33e6648a86c076ff4b5ecb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551485 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831856}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011300600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/DFP6775_ioCBTjnpyJoXzr5w-Xv6mSoZDrurJfFGpu4C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/168064736 Tbr: media-app@grotations.appspotmail.com Change-Id: I4f9a1e2f81b86263c98895c2e2233034e79a90fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564528Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831855}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c2f6edd90e95..41e380345098 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rogerta@google.com,rsorokin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rogerta@google.com,rsorokin@google.com Change-Id: Ic3d5932c8c8002da2312215fb155ce28c325b1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564525Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831854}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/77b68e8599f0..ca92424e21e5 2020-11-30 robertphillips@google.com Remove SkBaseDevice::flush (take 2) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I6e867dd24fc92530f712d6a7aacbbd4a3d7bb63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564527Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831853}
-
Bartek Nowierski authored
Empty slot spans are typically registered for lazy decommitting, to avoid perf regression when going back and forth between decommitted<->active states. However, we haven't observed a perf difference for single-slot slot spans, in which case better to decommit them as soon as they become free. Change-Id: I09e09055dd2b54b17a54ed35f518d72e9a16e310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549024 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#831852}
-
Jaeyong Bae authored
This patch does skip empty span when finding the first-letter text. Also, this adds the following tests. external/wpt/css/css-pseudo/first-letter-skip-empty-span.html external/wpt/css/css-pseudo/first-letter-skip-empty-span-nested.html Bug: 911093 Change-Id: Iee9c6f531771826ea8f8446cd73e2015dfc2fb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560522Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#831851}
-
Ewann authored
This CL updates the padding between the icon and the text and also the padding between detail text and the AccessoryType. The position of the switch button is also modified in order to be correctly aligned with AccessoryType of the other items. Bug: 922511 Change-Id: I8b738a82d0b523c59344f145938be09f9022bc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560637Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#831850}
-
Mattias Nissler authored
This reverts commit 960e7e40. Reason for revert: Stray startup_up_flags.flags reference in policy_templates.json breaks things. Original change's description: > Introduce feature flags Chrome OS device setting. > > This new device setting will supersede the existing "startup flags" > setting. The latter was storing chrome://flags feature flags as raw > command line switches, which turned out to be problematic since Chrome > can't easily map the switches back to feature flags to validate them. > Subsequent changes will add support for the new way of doing things as > well as migration logic in session_manager and Chrome. > > BUG=chromium:1073940 > TEST=None > > Change-Id: I54204286db5262e6ccc76b844db5863e69c1d8c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290730 > Commit-Queue: Mattias Nissler <mnissler@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831789} TBR=xiyuan@chromium.org,mnissler@chromium.org,pmarko@chromium.org Change-Id: I1af63c3cca1eddc0663e1770c51edaab599ab59d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1073940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563673Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#831849}
-
Chris Hamilton authored
Currently this data is associated with frames, but it is also measured for workers. This moves the tracking class to be associated with "ExecutionContexts", which encapsulates either a frame or a worker. This also adds a little bit of syntactic sugar to the ExecutionContext machinery to make it easier to use. BUG=1085129 TBR=jkarlin@chromium.org Change-Id: Ib769c1044ff76af25fa97c804a193ccfbff89eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551154Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#831848}
-
Rune Lillesveen authored
Checking whether a ActiveStyleSheetVector has media queries more naturally belongs there, but also makes it accessible for an upcoming user css split out from StyleEngine. Also renamed the method to better explain what it does. Bug: 336876 Change-Id: I48a58f16867392345d3960304263ea2b90403bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563493Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#831847}
-
Aaron Leventhal authored
This CL progresses towards removal of ShouldUseLayoutBuilderTraversal(), simplifying AddChildren() and removing conditions that lead to lack of symmetry in child-parent relationships. Note that pseudo elements can have multiple children, including text and images. Example in test: list-marker-styles.html. Bug: None Change-Id: I204d567f4673e449ec21a91d923b0bf215b133e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563862 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#831846}
-
Alice Wang authored
This CL adds GoogleActivityController to signin.ui target. The old class will be removed after migrating the callers of the class in //clank. Bug: 1153038 Change-Id: Ia10b1d95be9b26808fe2021d4c539b5fb7b0f3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562139Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#831845}
-
Victor Hugo Vianna Silva authored
Bug: 1105795 Change-Id: Idd7efc38c149769b837fced9743731f5eb0802a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565129 Auto-Submit: Victor Vianna <victorvianna@google.com> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#831844}
-
Mugdha Lakhani authored
Example failure: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester/b8863983830613553808 The test accesses the disk with a blocking call when destroying the incognito profile. Allow blocking calls from the test to fix failure on M. Bug: 1147754 Change-Id: I7f5f00421193a7065626ba2438a77420ff8ffb6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563665Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#831843}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ie3d8881c5035acc6c17400c039fa58f17972d9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564813Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831842}
-
David Roger authored
The label was (probably) broken because of some syntax error. Rather than fixing the aria-label, this CL uses aria-labelledby instead, because the label already exists at the top of the card element. Fixed: 1151901 Change-Id: I4dc0540bf776f7fb4c271075d047ae243b71f8bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565242 Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#831841}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ic91046cc2a69892008df51d1911b7ce2095b3cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564891Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831840}
-
David Roger authored
When the user accepts the bubble, it is no longer closed immediately. Instead the buttons are disabled and a spinner is shown. Screenshot: https://drive.google.com/file/d/1yTJ2jac0rq-ly6bEZ0mxhrp5hQ3fd1Ai Bug: 1076880 Change-Id: Iff64b798ce7f11fec2c753d0642e989823a349dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563480Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#831839}
-
chrome://settingsAntonio Gomes authored
CL ifdef's out Lacros from using having this menu item. By doing this, Lacros pairs itself up with ash/chrome Web browser. Also, even enabled, the menu item is ineffective, since it makes use of a GTK+ functionality, only available for Desktop Linux builds. BUG=1153355 R=thomasanderson@chromium.org Change-Id: I184f65b5efb23c926b7f3a63127a24855b8de067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563919Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#831838}
-
Alice Wang authored
This CL moves UnifiedConsentServiceBridge to signin.services target for signin backend modularization. Bug: 1153046 Change-Id: I4f5c6e0848ad2c3daffdfa634217679cdf38f16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561384Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#831837}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/732b1bcf..ac4c4dc0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I58cd21acfe0803fdfd5651cf7b3b44b588de407b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564969Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831836}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606715277-7cd8080ef7943d789d7f3f75a67090679d493829.profdata to chrome-mac-master-1606737208-e8262bf3e6eb680125b6c552d8461f977d1e98a6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I06b48a5e77b3c525acfd7883ad1bc6e35318daa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564894Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831835}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606715277-5a5c0b93116eb4ed5bae16849c10b7071f9da60f.profdata to chrome-linux-master-1606737208-c1622dbc8154d000833156e031e2fb92fdbe0368.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I65465d08109fb5af1eb9404337222294b0f636bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564971Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831834}
-
Maksim Sisov authored
Fixes a crash when FindDisplayNearestPoint cannot find a suitable display (if num of displays <= 1) and returns nullptr, which is then returned to ScreenOzone by value, which is illegal and results in a crash. Bug: 1135518 Change-Id: Icb1e788bcc0fbda13bc84023999b1b39eebfd1cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565119 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Maksim Sisov (GMT+2) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#831833}
-
Anton Bikineev authored
qurantine. Bug: 11297512 Change-Id: I819d323831993c36575f64f00def30a2e3686577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563766 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#831832}
-