GitLab

BUG=None 
CID=111426

Review URL: https://codereview.chromium.org/303393006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274460 0039d316-1c4b-4281-b951-d872f2087c98

BUG=323265

Review URL: https://codereview.chromium.org/308963006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274459 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None 
CID=115567

Review URL: https://codereview.chromium.org/301243020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274458 0039d316-1c4b-4281-b951-d872f2087c98

Fingers crossed, hopefully all known bugs are fixed.

BUG=356073,371633,369204
TEST=new unittest.

Review URL: https://codereview.chromium.org/278673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274457 0039d316-1c4b-4281-b951-d872f2087c98

R=rsleevi@chromium.org,wtc@chromium.org

Review URL: https://codereview.chromium.org/303133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274456 0039d316-1c4b-4281-b951-d872f2087c98

Ensuring that QUIC's pacing sender can have TimeUntilSend called
multiple times and behave return the same time to send.

Also add more tests to ensure the pacing sender properly makes up for
lost time, but stops doing so after application limited sending.

Merge internal change: 68257669
https://codereview.chromium.org/312573002/


Drop "Interface" from name of QUIC debug interfaces that should not be
abstract.

Drop Interface from some class names.

Merge internal change: 68257565
https://codereview.chromium.org/310693002/


QUIC flow control now based on highest received byte offset rather than
bytes buffered. No longer keep track of how many bytes we have buffered
in the QUIC flow controller - this adds complexity when we can just
track the highest received byte offset. This allows us to detect flow
control violation earlier.

QUIC flow control now based on highest received byte offset rather than
bytes buffered. Protected behind (already ENABLEd)
FLAGS_enable_quic_stream_flow_control_2

Merge internal change: 68200399
https://codereview.chromium.org/305033011/


Changes the pacing sender's alarm granularity from 1 microsecond to 5
milliseconds.

Merge internal change: 68197640
https://codereview.chromium.org/302283004/


Remove unnecessary MaybeSendWindowUpdate from ReliableQuicStream: always
try sending a WINDOW_UPDATE from inside AddBytesConsumed. Whenever
bytes_consumed changes we may want to send a WINDOW_UPDATE, and this CL
prevents future users calling AddBytesConsumed and forgetting
MaybeSendWindowUpdate.

QUIC: remove unnecessary MaybeSendWindowUpdate from ReliableQuicStream

Merge internal change: 68188106
https://codereview.chromium.org/308363002/


Remove the TransmissionType argument from QuicConnection CanWrite and
SentPacketManager TimeUntilSend by generalizing the
QuicSentPackeManager's TLP alarm.

Merge internal change: 68148420
https://codereview.chromium.org/306013009/


Cleanup in QuicConnection to always cancel the send alarm when CanWrite
is consulted and use CanWrite when deciding to send in response to a
packet receipt.

Merge internal change: 68118973
https://codereview.chromium.org/304293009/


Allow QUIC's BBR congestion control to be negotiated in the crypto
handshake.

Adding an implementation of QuicFixedTagVector to QuicConfig to enable
multiple congestion control options per connection.

Merge internal change: 68114869
https://codereview.chromium.org/308273004/


Move test-only method from QuicFramer to quic_test_utils.

Merge internal change: 68110215
https://codereview.chromium.org/305343002/


Replaced options from QuicPacketCreator with members and explicit
getters/setters. A couple of small bugs fixed.

Merge internal change: 68099048
https://codereview.chromium.org/301173007/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/312553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274455 0039d316-1c4b-4281-b951-d872f2087c98

Fix aria warnings for the same controls.


Reset margin input controls error state when error is cleared. Fix aria warnings for the same controls.

BUG=354340

Review URL: https://codereview.chromium.org/308943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274454 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/301243019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274453 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369848

Review URL: https://codereview.chromium.org/294043017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274452 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380082
TBR=kaznacheev
R=kaznacheev
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/314643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274451 0039d316-1c4b-4281-b951-d872f2087c98

Multi-sided patch: 
1/3: blink-side, https://codereview.chromium.org/304053003/
2/3: chromium-side, THIS PATCH
3/3: blink-side, cleanup Not Yet.

BUG=377373

Review URL: https://codereview.chromium.org/305893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274450 0039d316-1c4b-4281-b951-d872f2087c98

I made it talk directly to the view_manager. We'll likely want a
variant that talks to the client_lib too.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/313483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274449 0039d316-1c4b-4281-b951-d872f2087c98

Nodes weren't being properly deleted when ViewManagerConnection was
deleted.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/309793007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274448 0039d316-1c4b-4281-b951-d872f2087c98

It doesn't work there for some reason.

BUG=

Review URL: https://codereview.chromium.org/314463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274447 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274446 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175309:175314&mode=html
TBR=mvanouwerkerk@chromium.org,jchaffraix@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/309063009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274445 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362880
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/309103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274444 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357693

Review URL: https://codereview.chromium.org/308433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274443 0039d316-1c4b-4281-b951-d872f2087c98

BUG=273710

Review URL: https://codereview.chromium.org/305243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274442 0039d316-1c4b-4281-b951-d872f2087c98

Once complete, this layout will have common parts factored out so that it can be shared across other similar interstitials. (E.g., malware.) But that day is not today.

For now, this is behind a Finch flag with the old interstitial running as default. The two will trade places when this version (v2) is launched.

BUG=331453
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/294343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274440 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274439 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/b3281585bb6ee3ad8385bf4ba46513af609fa11b..1940df968da44ef95ddb332270aa23481552ca65
TBR=jvanverth@google.com
BUG=

Review URL: https://codereview.chromium.org/306893011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274438 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379667

Review URL: https://codereview.chromium.org/306073007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274437 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds displaying live log from the request manager of the selected
file system.

TEST=Tested manually with a testing extension.
BUG=376095

Review URL: https://codereview.chromium.org/301873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274436 0039d316-1c4b-4281-b951-d872f2087c98

It's a no-op in Windows-only code.

Review URL: https://codereview.chromium.org/299363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274435 0039d316-1c4b-4281-b951-d872f2087c98

Plumb a new VideoFrame format (YV24) through the stack and add a conversion using libyuv to the software path.

BUG=104711

Review URL: https://codereview.chromium.org/289373011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274434 0039d316-1c4b-4281-b951-d872f2087c98

Enables reflection blocking for several groups of integration tests.
These tests have been ready for this change for a while, but we never
got around to setting the flag until now.

BUG=97780

Review URL: https://codereview.chromium.org/293993019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274433 0039d316-1c4b-4281-b951-d872f2087c98

Sometimes, changes to JSON/IDL files make them invalid. It's easier to check these at presubmit time than discovering they can't be parsed at runtime.

This just moves the check from chrome/common/extensions/api to top-level.
This presubmit check excludes files in test/data directories.

BUG=366395

Review URL: https://codereview.chromium.org/239283008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274432 0039d316-1c4b-4281-b951-d872f2087c98

This CL is the first CL introducing java bindings. It only generates constants.

This is a reland of https://codereview.chromium.org/291903003 with a custom
DEPS file to fix bot issue.

TBR=viettrungluu@chromium.org,rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/312643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274431 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274430 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
This CL seems to cause Linux Chromium OS ASan LSan bots failure.
The failure logs are:
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%282%29/builds/1458
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29&number=1639
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/1639


Original issue's description:
> Animate window control changes in TouchView
> 
> Add animation for the hiding and showing of the resize button. Add an animation
> for sliding the minimize button into the position of the resize button. Delay
> changing the size of FrameCaptionButtonContainerView to account for conflicting
> layout changes caused by the transition to TouchView.
> 
> TEST=FrameCaptionButtonContainerViewTest
> TEST=CustomFrameViewAshTest
> TES=BrowserNonClientFrameViewAshTest
> BUG=363717
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274371

TBR=flackr@chromium.org,jamescook@chromium.org,oshima@chromium.org,jonross@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=363717

Review URL: https://codereview.chromium.org/309973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274426 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380044
TBR=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/315523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274425 0039d316-1c4b-4281-b951-d872f2087c98

  "compositor: Tick the UI animations from cc, instead of from timer callbacks."
  "asan: Fix asan leak from r274404."

These CLs seem to break ash_unittests on win8 aura bot:
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win8%20Aura&number=19390

BUG=371071
TBR=sadrul@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/311783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274423 0039d316-1c4b-4281-b951-d872f2087c98

launcher inits the view manager, running the "window manager" app @ root.
window manager embeds another app.

** not tested by main chrome integration testing **

R=sky@chromium.org
TEST=mojo_shell --origin=http://127.0.0.1:4444 --disable-cache mojo:mojo_demo_launcher
http://crbug.com/365012

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274322

Review URL: https://codereview.chromium.org/303163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274422 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Reduce plugin_metrics_provider_ usage in MetricsService (https://codereview.chromium.org/308433004/)

Reason for revert:
This CL seems to cause bot failure on CI:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2745

Original issue's description:
> Reduce plugin_metrics_provider_ usage in MetricsService
> 
> This CL eliminates MetricsService's call to
> PluginMetricsProvider::RecordPluginChanges (replaced by a new API on
> MetricsProvider). It additionally adds a
> MetricsServicesManager::OnPluginLoadingError() API and has the plugin observer
> call that API rather than calling MetricsService directly. This change will
> enable easily moving MetricsService::LogPluginLoadingError() to
> ChromeMetricsServiceClient once the latter is the class that keeps a weak
> pointer to the plugin metrics provider.
> 
> BUG=375776
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274403

TBR=asvitkine@chromium.org,isherman@chromium.org,jochen@chromium.org,blundell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=375776

Review URL: https://codereview.chromium.org/314583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274418 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274411 0039d316-1c4b-4281-b951-d872f2087c98

Make sure the initiated animations are terminated correctly before teardown.

BUG=none
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/307323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274409 0039d316-1c4b-4281-b951-d872f2087c98

Two cases don't have breaks and fall through incorrectly. The first
may be responsible for issue http://crbug.com/370919.

BUG=370919

Review URL: https://codereview.chromium.org/307293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274408 0039d316-1c4b-4281-b951-d872f2087c98

All licensing issues were fixed in pdfium/checklicenses last week.

BUG=374943
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/307933013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274407 0039d316-1c4b-4281-b951-d872f2087c98

The commented bug seems to be resolved, and I don't see any reason to suspect
that this would still timeout.

BUG=

Review URL: https://codereview.chromium.org/304353018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274406 0039d316-1c4b-4281-b951-d872f2087c98