- 21 Nov, 2017 40 commits
-
-
Danyao Wang authored
Bug: 786551 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I621a26b36fd3777345dd2b77890dc4aee596105b Reviewed-on: https://chromium-review.googlesource.com/777770 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#518398}
-
Nate Fischer authored
No change to logic. This uses getDeclaredConstructor() when creating the SafeBrowsingApiHandler, since this provides more information in case an exception is thrown. This resolves an errorprone compile warning. Test: ninja system_webview_apk (fewer compile warnings) Change-Id: Icdaf2aadf6fbd16fb298b140f3918b51a5fd2d43 Reviewed-on: https://chromium-review.googlesource.com/780761Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#518397}
-
Christopher Cameron authored
This is no longer read by GLRenderer -- it's just plumbed to nowhere. Bug: 759215 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I0667217d643c3e527947106ff1de48e04d935f0f Reviewed-on: https://chromium-review.googlesource.com/780147 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#518396}
-
Nate Fischer authored
No change to logic. This uses getDeclaredConstructor to instantiate an instance for the TestRunner. This propagates exceptions from the constructor, which means we can log more error cases. This resolves an errorprone compile warning (ClassNewInstance) Test: ninja system_webview_apk (fewer warning messages) Change-Id: I110b444ca93557d0ec138c2a05d8fda81904dfc8 Reviewed-on: https://chromium-review.googlesource.com/780808 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#518395}
-
Steven Bennetts authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ef632e4a473b..575c52b3e1f9 $ git log ef632e4a4..575c52b3e --date=short --no-merges --format='%ad %ae %s' 2017-11-17 stevenjb cros_chrome_sdk: Add --gn-gen and make --nogn-gen the default 2017-11-17 akeshet patch: factor out cherry-pick operation from Apply 2017-11-20 dgarrett Revert "cbuildbot_launch: Always wipe firmware/factory branches." 2017-11-20 dgarrett cbuildbot: Tighten requirements for production configs. 2017-10-30 hungte lib: Support 'pixz' compressor. 2017-11-15 dgarrett generic_stages_unittest: Fix lint error. 2017-11-17 akeshet patch: rename PatchNotMergeable -> PatchNotSubmittable 2017-11-20 akeshet patch: add _IsAncestorOf method 2017-11-17 akeshet patch: add _GetParents method 2017-11-20 dgarrett Revert "config_lib: Remove OverrideConfigForTrybot." 2017-11-20 phobbs cidb: Correct filename of migration 00063 2017-11-17 jclinton cbuildbot: Drop the reef-uni builder 2017-11-17 nxia validation_pool: check git log diff between local HEAD and remote_ref 2017-11-16 bmgordon cros_sdk: Run fstrim to keep chroot.img sparse 2017-11-13 ghines Add capri builds 2017-11-14 pberny meowth: add builder configuration. 2017-11-16 dgarrett cbuildbot_launch: Always wipe firmware/factory branches. 2017-11-15 dgarrett config_lib: Fix misspelled display_label. 2017-11-16 phobbs cidb: Allow CLAction build_id to be NULL 2017-11-16 phobbs cidb: Add "exonerated" claction 2017-11-17 nxia SlaveBuilderStatus should fetch builders based on exclude_experimental 2017-11-17 chrome-bot Update config settings by config-updater. 2017-11-01 armax x30evb & lassen: unify the configurations for lassen and x30evb. 2017-11-03 dgarrett config_lib: Remove OverrideConfigForTrybot. 2017-11-15 dgarrett scheduler_stages: Add buildbucket tags for GE. 2017-11-16 phobbs annotator: Fix finalize field.value usage. 2017-11-16 phobbs annotator: Fix _MaybeSaveFinalizeMessage 2017-11-17 shuqianz Revert "auto_updater: Apply cold reboot for AU" 2017-11-09 phobbs cq_stats: "Annotations finalized" checkbox 2017-10-30 phobbs annotator: Add buildMessageTable model 2017-11-16 stevenjb chrome_chromeos_lkgm: Use 'git -c user.email cl upload' 2017-11-13 cywang auto_updater: Apply cold reboot for AU 2017-11-15 dgarrett cros tryjob: Fix submission of unknown build configs. 2017-11-15 dgarrett cros_tryjob: Add go link to -tryjob error messages. 2017-11-16 phobbs Revert "gob_util: Support Appengine Gerrit credentials." 2017-11-14 dgarrett branch-util: Fix branch-util-tryjob for testing. 2017-11-15 shapiroc Fix issue with model specific au fanout 2017-11-07 aelder deploy_chrome: Add --private_key option 2017-11-09 phobbs locking: Fix errno.EDEADLK reference. 2017-11-15 cmtice Revert "generic_stages: temporarily ignore all target prebuilts." 2017-11-15 chrome-bot Update config settings by config-updater. 2017-11-15 hiroh TestSimpleChromeWorkflowStage: Pass --nogn-gen to cros chrome-sdk 2017-11-09 phobbs gob_util: Support Appengine Gerrit credentials. 2017-11-08 achuith [cros_vm]: Use virtio instead of cirrus. 2017-11-14 cmtice generic_stages: temporarily ignore all target prebuilts. 2017-11-13 shapiroc Configure coral for chrome/android pfq and paladin 2017-09-13 vapier cros tryjob: restore metavar 2017-11-14 stevenjb TestSimpleChromeWorkflowStage: Pass --nogngen to cros chrome-sdk 2017-11-14 chrome-bot Update config settings by config-updater. 2017-11-13 xixuan cros-update: use curl instead of wget to check devserver health. 2017-11-13 chrome-bot Update config settings by config-updater. 2017-09-29 stevenjb cros_chrome_sdk: Automatically generate args.gn files 2017-11-11 manojgupta Revert "generic_stages: temporarily ignore all target prebuilts." 2016-07-20 sjg commands: Use cros_config_host instead of fdtget 2017-11-08 dgarrett cbuildbot: Enforce tryjob safe configs. 2017-11-01 dgarrett cros tryjob: Enforce tryjob safe configs. 2017-11-07 manojgupta generic_stages: temporarily ignore all target prebuilts. 2017-11-09 akeshet summarize_build_stats: link to new cq-weekly dashboard 2017-11-09 akeshet summarize_build_stats: drop the "Top reasons" table 2017-11-09 akeshet summarize_build_stats: add a category picker to the top X lists 2017-11-10 chrome-bot Update config settings by config-updater. 2017-11-09 dgarrett chromeos_config: Remove tryjob config overrides. 2017-11-01 dgarrett cros tryjob: Update --list for production vs tryjob. 2017-11-07 vapier image_test: move security_CroshModules autotest here 2017-11-08 derat chromite: Make TastVMTestStage unforgiving. 2017-11-06 nxia Get current builders_array from metadata. 2017-11-09 stevenjb chrome_chromeos_lkgm: Add --email to 'git cl upload' 2017-11-08 derat chromite: Run ARC Tast VM tests on betty-release. 2017-11-08 ayatane Fix typo 2017-11-06 ayatane Exclude provision suite from subsystems 2017-08-21 smbarber chromeos_config: Add tatl-full builder on external waterfall 2017-11-08 lhchavez Remove support for aosp_bertha* Android targets 2017-11-08 stevenjb chrome_chromeos_lkgm: Remove any existing chrome checkout 2017-11-08 chrome-bot Update config settings by config-updater. 2017-09-28 nxia chromite changes for Cros_CL_Status_Viewer 2017-11-06 phobbs cidb: Changes for cl_exonerator 2017-11-07 dgarrett chromeos_config: Update generated files together. 2017-11-07 achuith [cros_vm]: Better error messages for qemu. 2017-11-03 pprabhu cidb_integration_test: Wait longer for mysqld to initialize. 2017-11-08 chrome-bot Update config settings by config-updater. 2017-10-20 dgarrett chromeos_config: Create mirrored tryjob build configs. 2017-11-07 stevenjb cros_chromeos_lkgm: Add UploadNewLKGM stage (take 4) 2017-11-06 akeshet pre-cq: mark failed-to-apply changes as pre-cq-failed so they don't loop 2017-10-27 davidriley Reland "cbuildbot: Emit partition files for provisioning purposes." 2017-11-06 derat chromite: Ensure TastVMTest runs after VMTest failure. 2017-11-06 pprabhu cq_stats: deploy the correct cidb credentials. 2017-11-06 pprabhu Update cidb settings for gen2 SQL instances. 2017-11-06 pprabhu Hack fake_modules some more to allow chromite import. 2017-10-31 dgarrett cros_uprevchrome: Tweak tempdir creation. 2017-11-06 dgarrett cros_tryjob: Add --chrome_version passthrough option. 2017-11-03 llozano chromite: cleanup board lists for llvm-toolchain configs. Created with: roll-dep src/third_party/chromite Bug: 762650 Change-Id: I50225211a2c997aa63a9a818b68a564dfd4ad119 Reviewed-on: https://chromium-review.googlesource.com/782820 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#518394}
-
Andrey Kosyakov authored
Change-Id: I561218917c5491c4326eec34897d15af124add70 Reviewed-on: https://chromium-review.googlesource.com/780762Reviewed-by:
Will Chen <chenwilliam@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#518393}
-
Fredrik Söderquist authored
This moves the stroke approximation code from LayoutSVGPath::HitTestStrokeBoundingBox to a helper in LayoutSVGShape, and then makes use of it in LayoutSVGShape::CalculateStrokeBoundingBox() (which is the generic "stroke bounds" computation for shapes) as well. This makes stroke bounding box computation O(1) (assuming a fill bbox exists), avoiding the generation of a stroke path, which can be expensive for the more "complex" parametrizations (primarily dashes.) The downside is of course lower fidelity, and the approximation will always be both larger than the fill bbox and larger than the "exact" stroke bbox. Also fix an issue where a miter-limit < 1 would incorrectly shrink the resulting bounding box in some cases. Bug: 435097 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id0228bc78bb7d8db223be082106f3c3d2bcb038a Reviewed-on: https://chromium-review.googlesource.com/774746 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#518392}
-
Adrian Elder authored
Since this private api function is only intended for use by a Chrome App running on Linux and ChromeOS, there's no need to support other platforms. Bug: 775961 Change-Id: I14ccfea7de7cdd9f1e6bbe4cd4115f8804fe4b89 Reviewed-on: https://chromium-review.googlesource.com/780299 Commit-Queue: Adrian Elder <aelder@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#518391}
-
Matt Menke authored
This, or something like it, will eventually need to replace TYPE_FILE (Which just contains a path) in order to sandbox the network service process. Bug: 777879 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8c67e828288443cbfc15aa774c1b97aa2f22ef29 Reviewed-on: https://chromium-review.googlesource.com/773238 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#518390}
-
sahel authored
This cl marks GSB and GSE events that are generated from wheel events with timer based phaseBegan and phaseEnded as synthetic. This change is necessary to avoid rubber banding effect while scrolling by a Mac mouse or any other device that don't provide wheel phase info. Bug: 776962 Test: RenderWidgetHostViewMacWithWheelScrollLatchingEnabledTest.TimerBasedPhaseInfo Change-Id: I51b318fd2790d39939d41dad2539c788bd6430eb Reviewed-on: https://chromium-review.googlesource.com/779659Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#518389}
-
Gabriel Charette authored
Round 3 of https: //chromium-review.googlesource.com/c/chromium/src/+/638550 Round 2 was: https://chromium-review.googlesource.com/667938 TBR=fdoray@chromium.org Bug: Missing includes prevents header cleanup in https://chromium-review.googlesource.com/c/chromium/src/+/638550 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I99f2d37cf342f2ed38d167b9dcc3c57173b2f9a2 Reviewed-on: https://chromium-review.googlesource.com/782663 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#518388}
-
Dominic Mazzoni authored
AccessibleNode needs an owner document. If it's constructed without an element, we get the document from the JavaScript context. That part is fine. But if we construct it from an Element, we were caching its Document - but elements can be reparented to a different document, leading to a crash if the Element is reparented and then its original document is deleted. The solution is to not cache the Document if the AccessibleNode is associated with an Element. Just get it from the Element. Bug: 785802 Change-Id: I8d67f9117a5d9a9c9efbd978ac4d1965e4c0eb2a Reviewed-on: https://chromium-review.googlesource.com/775616Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#518387}
-
Stefan Zager authored
The previous platform/win expected.png file was not a printing layout. Bug: 618082 Change-Id: I73c5d69a4f5d45086d974178f2d21151f5bb10d5 Reviewed-on: https://chromium-review.googlesource.com/781980Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#518386}
-
Adrian Elder authored
Before this change, webrtcLoggingPrivate.startAudioDebugRecordings was only available if switches::kEnableAudioDebugRecordingsFromExtension was present. This change adds new API permissions that permit creating audio debug recordings without that flag. These permissions are only granted to whitelisted apps installed on internal Hotrods. Bug: 777906 Change-Id: I42d583f1a58d86c351cc41e2cd261bff4b96be9f Reviewed-on: https://chromium-review.googlesource.com/766708Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Greg Levin <glevin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Adrian Elder <aelder@chromium.org> Cr-Commit-Position: refs/heads/master@{#518385}
-
Andrew Grieve authored
Bug: 776351 Change-Id: Iecb2d207d5c6383898f1d58e2f0fb2b61f09dbc0 Reviewed-on: https://chromium-review.googlesource.com/782463Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#518384}
-
Chris Kuiper authored
This fixes the issue that is_ducking_ remains set even after the focus was abandoned. This can cause the volume to be set to ducking levels when requesting a new focus. Bug: [internal] b/69384033 Test: verified bug is not happening anymore Change-Id: I64751e91abe440ecd6f80ffca68c87862536b8b6 Reviewed-on: https://chromium-review.googlesource.com/782539Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Chris Kuiper <ckuiper@chromium.org> Cr-Commit-Position: refs/heads/master@{#518383}
-
Mathieu Perreault authored
NormalizeAddress{Sync/Async} will now use the profile's region (or fallback to the app_locale's region) when normalizing. Bug: 767931 Test: existing` Tbr: mahmadi Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2bda562786e2fd6b6f50ffaf27c6fa7942eeafb7 Reviewed-on: https://chromium-review.googlesource.com/782039 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#518382}
-
Robert Sesek authored
Bug: 598854 Change-Id: Ie92935f4919e57cae338c33750458c0509a93627 Reviewed-on: https://chromium-review.googlesource.com/782040 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#518381}
-
Natalie Silvanovich authored
Bug: Change-Id: I272123ce602510eef102fbe58516c5dd37c23af0 Reviewed-on: https://chromium-review.googlesource.com/780680 Commit-Queue: Natalie Silvanovich <natashenka@google.com> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#518380}
-
dpapad authored
Also fixing remaining ESLint violations automatically with --fix flag. Bug: 720034 Change-Id: I3fe1b0fbe7b559316a26c1526abacbde0486f418 Reviewed-on: https://chromium-review.googlesource.com/775597 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#518379}
-
Sidney San Martín authored
Bug: 773944 Change-Id: Ic1ed323b5facb6479bdbeaf319260269426400a8 Reviewed-on: https://chromium-review.googlesource.com/783250Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#518378}
-
Owen Min authored
With this new flow parameter value, sign in dialog will not contains chrome sync related information in the embedded sign-in page. Bug: 784582 Change-Id: I2b315d381750bc1ad3932d5a8bf3edcab8a64285 Reviewed-on: https://chromium-review.googlesource.com/775693 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#518377}
-
Miguel Casas authored
This CL moves gpu_jpeg_decode_accelerator_factory_provider.* from //media/gpu/ipc/service/ to //media/gpu/ and renames them (and the class inside) to GpuJpegDecodeAcceleratorFactory, updating call sites. No new code is intended. TBR=rjkroege@chromium.org for components/viz/...gpu_service_impl.cc since it's pure renaming. Bug: 787176 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia85d58a9906752f49a5362c7cb85605986e44445 Reviewed-on: https://chromium-review.googlesource.com/781583 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#518376}
-
Koji Ishii authored
This patch fixes NGBoxFragmentPainter::PaintText to check cached drawing before it creates DrawingRecorder. This is currently the top crasher when NGPaintFragments is enabled, and this patch fixes ~7000 crashes. Bug: 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3cac0517e06b52b394ab0838db441cbb0a971296 Reviewed-on: https://chromium-review.googlesource.com/773791 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#518375}
-
Eric Lawrence authored
On ChromeOS, any prior observation of a policy-installed cert is an indicator of a MITM being present (the enterprise). Previously, the SECURE_WITH_POLICY_INSTALLED_CERT security level was returned even if the page contained mixed content or used a SHA-1 certificate. Instead, such problems should impact the security level instead of being ignored. Bug: 756639 Change-Id: I4e87fc6039eb76ff8b5b87612c5d0dc004ddd867 Reviewed-on: https://chromium-review.googlesource.com/779743Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#518374}
-
Vlad Tsyrklevich authored
This is a reland of e77256b1 now that crrev.com/00fb4b7e landed fixing the lock-up issue we previously saw. Original change's description: > [cfi-icall] Use ProtectedMemory for localtime ptrs > > Control Flow Integrity [1] indirect call (cfi-icall) checking can not > verify that dynamically resolved function pointers call their intended > function. Instead we place the LibcFunctions pointers in > ProtectedMemory, a wrapper for keeping variables in read-only memory > except for when they are initialized. After setting the pointers in > protected memory we can use the UnsanitizedCfiCall wrapper to disable > cfi-icall checking when calling them since we know they can not be > tampered with. > > [1] https://www.chromium.org/developers/testing/control-flow-integrity > > Bug: 771365 > Change-Id: Ib74faff066e1107293b67d11f2a1a054bbff08b5 > Reviewed-on: https://chromium-review.googlesource.com/769853 > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517152} Bug: 771365 Change-Id: Iaba5de8e37332878cd0b85c9dbdafc08e2d9a6ba Reviewed-on: https://chromium-review.googlesource.com/782739Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#518373}
-
Bugs Nash authored
This is to prevent upcoming larger style builder functions from making the headers difficult to read This patch - Added a comment to section off style builder functions in the property class header files for readability - Moved style builder functions to end of class so that that section does not merge with another optional section - Changed the condition to print style builder functions from should_declare to should_implement so that the comment does not appear for classes that have not yet had the style builder methods moved into them. The should_declare member is kept as it will be required in future for declaration only cases. Diff of generated files: https://gist.github.com/BugsNash/49febc392af82920fea3e59e6c7d3224/revisions Bug: 751354 Change-Id: Ic664b6fcad97d70bf24d46428561fff2dd6107a0 Reviewed-on: https://chromium-review.googlesource.com/780160 Commit-Queue: Bugs Nash <bugsnash@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#518372}
-
Peter Lee authored
This reverts commit 2d1368a2. Reason for revert: This will break on iOS 11.2 beta Original change's description: > Calls decisionHandler asynchronously, part 2 > > Only one of two calls to decisionHandler was converted to async in > http://crrev/c/773570. This changes the other call. > > Bug: 774736 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Ie72c6efc42e5921eae8983d01f4be29fd3934d98 > Reviewed-on: https://chromium-review.googlesource.com/777400 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Peter Lee <pkl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517730} TBR=eugenebut@chromium.org,pkl@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 774736 Change-Id: I589fdeee11059b25edc1f755c0411f8ff9d7e87f Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/782744Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#518371}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/120c19b6a193..135c6601bd9d $ git log 120c19b6a..135c6601b --date=short --no-merges --format='%ad %ae %s' 2017-11-21 thestig Add {Byte/Wide}String::Trim(). 2017-11-21 thestig Clean up CJS_PublicMethods. 2017-11-21 dsinclair Make CXFA_CaptionData methods const 2017-11-21 dsinclair Make CXFA_CalculateData methods const 2017-11-21 dsinclair Remove unused CXFA_BoxData methods 2017-11-21 dsinclair Cleanup CXFA_BindItemsData methods 2017-11-21 dsinclair Cleanup CXFA_EventData methods 2017-11-21 dsinclair Rename CXFA_DataData::TryMeasure 2017-11-21 dsinclair Remove unused CXFA_DataData::SetMeasure 2017-11-21 dsinclair Convert CXFA_WidgetData methods to Optional 2017-11-21 dsinclair Rename the CXFA_WidgetData size methods from Get to Try 2017-11-21 dsinclair Make CXFA_MarginData::Try* methods return Optional 2017-11-21 dsinclair Add CXFA_MarginData::Get*Inset helpers Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I67288b0345817e8fcf2bff7169fcac484bf02f0f Reviewed-on: https://chromium-review.googlesource.com/782620 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#518370}
-
Michael Thiessen authored
Moves the concept of disabling magic window poses into VRDeviceBase. Bug: 777868 Change-Id: I5ab317faf5ad04abb47558e041446cfc1a484da0 Reviewed-on: https://chromium-review.googlesource.com/776165 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#518369}
-
Christopher Cameron authored
Ensure ca_context_id be initialized to 0 (otherwise the browser will attempt to use it). TBR=zmo Bug: 785599 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idcc8b0e6922c9842ecc7462fe93788aa942793db Reviewed-on: https://chromium-review.googlesource.com/779306Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#518368}
-
Min Qin authored
This logic is present in ResourceDispatcherHostImpl::ContinuePendingBeginRequest(). However, it is missing in URLLoader when constructing the URLRequest. The bug causes the wrong cookie to be presented if server redirection happens. DownloadContentTest.DownloadAttributeSameSiteCookie should provide test coverage for this CL. BUG=787046 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I708ecba1c386d101ae21e968351732a15fb6f31f Reviewed-on: https://chromium-review.googlesource.com/779065Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#518367}
-
Yixin Wang authored
Allow HttpNetworkSession::Params::quic_max(_idle)_time_before_crypto_handshake to be set by Cronet experiments Bug: 780964 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib405bcdd6ae986f0eb2f6e1be9f360a61dbf1e3c Reviewed-on: https://chromium-review.googlesource.com/778043 Commit-Queue: Yixin Wang <wangyix@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#518366}
-
Yuwei Huang authored
These code are no longer used and can be removed. Bug: 786616 Change-Id: I81782e7935026d36c9d3207da4db11c80057e3bf Reviewed-on: https://chromium-review.googlesource.com/780585Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#518365}
-
Julia Tuttle authored
Bug: Change-Id: I2412fd464a2efc2a5fe1900818804b636cc43d59 Reviewed-on: https://chromium-review.googlesource.com/779251Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#518364}
-
Yuwei Huang authored
The percentage of seeing a GLES2-only device is low but it's still safer to handle that, given that doing so requires only a few more lines. Bug: 787224 Change-Id: I63650f3ce4c2afe93492b81e30d7075d7007ebdc Reviewed-on: https://chromium-review.googlesource.com/780801Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#518363}
-
Andrey Kosyakov authored
Bug: 787173 Change-Id: Ia5d9aec2b96b5cfbfb25ff71d3a436a3575c16fd Reviewed-on: https://chromium-review.googlesource.com/782141Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#518362}
-
Min Qin authored
BUG=778255 TBR=dtrainor@chromium.org Change-Id: I599eec2a7123584d4943171e15da326ec730325d Reviewed-on: https://chromium-review.googlesource.com/783275Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#518361}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c11c947e..fdf73522 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib5a7e4de403a8a58e82b5fcce537e0fa4056991c Reviewed-on: https://chromium-review.googlesource.com/782459Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#518360}
-
danakj authored
TextureMailboxDeleter has nothing to do with the now-defunct TextureMailbox, it just deletes textures. So name it so. While doing so we uncovered a use of base::ThreadTaskRunnerHandle::Get() in GLRenderer, which may not be the same task runner given to the compositor to run its tasks on, so change things to plumb in the task runner to GLRenderer. Then creators of GLRenderer do not need to make a TextureDeleter anymore, so have GLRenderer do that itself. While sorting this out, clean up the GLRendererCopier tests to not subclass GLRendererPixelTest, and make and destroy a GLRenderer. Instead subclass PixelTest and make only the things it needs. R=ccameron@chromium.org TBR=boliu Bug: 769423 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I15a93b3f858fd52272341e19edf8e5ed989721dd Reviewed-on: https://chromium-review.googlesource.com/782403 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#518359}
-