GitLab

Command line flags override checks for hardware support so they
shouldn't be counted in UMA. However, we should log the hardware
support, and initialize globals even if overlays are disabled via
command line flags. Also guard against globals not being initialized.

R=zmo
BUG=837378

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Idfcab896a7e1671ebe0446e657f093a4cd1f5169
Reviewed-on: https://chromium-review.googlesource.com/1034021
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558477}

Some assert_throws statements did not include expected exceptions, which
broke their respective tests following a testharness.js update. Add
expected exceptions for all assert_throws statements. The only
functional change was to fast/serviceworker/serviceworker-interface.html
as per the spec ServiceWorker extends EventTarget and not Worker.

Bug: 754365
Change-Id: I733605d721085788d43e179ca6f9a7c7b25da995
Reviewed-on: https://chromium-review.googlesource.com/1056253Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558476}

Change-Id: Ia496ac5f5311871ebb234f8d725d3d902ae3f597
Reviewed-on: https://chromium-review.googlesource.com/1058045Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558475}

https://pdfium.googlesource.com/pdfium.git/+log/77c223be193b..a7ff4dc7c27c

$ git log 77c223be1..a7ff4dc7c --date=short --no-merges --format='%ad %ae %s'
2018-05-14 dsinclair Cleanup CPDF_Form parsing code

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:813349


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ic2e83914ab3a7df850858f8af5570c0bbeb67ec7
Reviewed-on: https://chromium-review.googlesource.com/1058139
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558474}

An earlier patch (commit e931d2ae)
changed code in MapToVisualRectInAncestorSpace to omit fixed-position
scroll in cases where the containing block was the LayoutView and
a counter-scroll would have been applied in the LayoutView anyway.
This fixed a bug in which a clip was applied in-between in the
wrong space.

The CL introduced a bug, however, in the case when the LayoutView
was the desired ancestor passed to MapToVisualRectInAncestorSpace.
In this case we should apply the counter scroll in LayoutView, because
the results of MapToVisualRectInAncestorSpace are in the unscrolled
space of the LayoutView.

Note that
LayoutBox::MapToVisualRectInAncestorSpace already has code to
skip fixed-position scroll and clip if container == ancestor,
independent of the above commit.

Bug:841194

Change-Id: Ia05894dd94bdb3b0503cbb155728b0ef074b0227
Reviewed-on: https://chromium-review.googlesource.com/1058039Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558473}

When comparing 2 URLs for equality in StrippedURLsAreEqual() - one a
suggestion and one an open tab - we were passing the user input to
only one of the reductions - the suggestion, since the suggestion was
based on it, and because the open tab was assumed to be already
cleaned up.

Instead, the input causes rules to be applied to the suggestion URL
which must also be applied to the open tab URL, so that, if equal,
they compare equal.

This CL changes the comparison to pass the input to both reductions so
that we're comparing apples to apples.

Bug: 842170
Change-Id: Ib88d7306b25ceaf9b1441366e66199620e107492
Reviewed-on: https://chromium-review.googlesource.com/1055670
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558472}

Bug: None
Change-Id: I9afbbafbe4dc0d2667c441b548598d366d478cf6
Reviewed-on: https://chromium-review.googlesource.com/1057473Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558471}

Bug: 790531
Change-Id: I8b044703ec950c7090e9d13a7adb132bece1384d
Reviewed-on: https://chromium-review.googlesource.com/1058186Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558470}

As per crbug.com/788021 Comments 1,6:
- Width = 448px
- Remove X (Close) button from upper right

Bug: 788021
Test: Log out from a public session (not sure if this is sufficient),
observe logout confirmation dialog, bask in Harmony.

Change-Id: I965c3237f222a4acae809946e0cbb003f40f2b45
Reviewed-on: https://chromium-review.googlesource.com/1021992Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Greg Levin <glevin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558469}

Bug: 841722
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If3e5e0c3866bee7660dfbab37b309f3c63978cdf
Reviewed-on: https://chromium-review.googlesource.com/1058029Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558468}

This doesn't include those in 'if' statements.

Bug: 703768
TBR: already agreed in blink-dev; too many files.
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I499b91695e177d2a498d96cf20537ee146e22d06
Reviewed-on: https://chromium-review.googlesource.com/1057947Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558467}

Just like it is already done for HTTP/2 pushed streams, and it is
already done in QuicClientPuthPromiseIndex::Try() for QUIC pushed
streams, use GetPromisedUrlFromHeaders() instead of
GetUrlFromHeaderBlock() in QuicChromiumClientSession::HandlePromised().

Bug: 810845
Change-Id: I60a656f6e2d382bf7a1b5e288de4fb42e2a2d4db
Reviewed-on: https://chromium-review.googlesource.com/1057414
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558466}

https://chromium.googlesource.com/catapult.git/+log/195c52dc7098..a67f1510e710

$ git log 195c52dc7..a67f1510e --date=short --no-merges --format='%ad %ae %s'
2018-05-14 perezju [soundwave] Fetch bug data in parallel
2018-05-14 perezju [Telemetry] Define --browser android-webview-google
2018-05-14 simonhatch Dashboard - Strip dead code from testselection.html
2018-05-14 nednguyen Add script to update Telemetry binary
2018-05-10 perezju [soundwave] Create bugs table if needed
2018-05-11 simonhatch Dashboard - Remove internal_only field from Row

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:841757


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ia81ddecb305d9801c475b922f3d392884f208df6
Reviewed-on: https://chromium-review.googlesource.com/1057903Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558465}

Focused item background color should be changed to
google-grey-200(#e8eaed).

Bug: 842380
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9a16e764764fa1c908c5aeb0f523b5c9e88ea295
Reviewed-on: https://chromium-review.googlesource.com/1057648
Commit-Queue: Hwanseung Lee <hwanseung@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558464}

Bug: 842790
Change-Id: Ibb0ad4d30ba9c52f8e0b1627fd314fe738a413cd
Reviewed-on: https://chromium-review.googlesource.com/1058010Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558463}

This CL adds a SoftwareOutputDevice implementation for Windows software
compositing to a layered window. The layered window API is required to
support transparency when DWM is disabled. Calling UpdateLayeredWindow()
is also blocked by the GPU sandbox.

To work around this SoftwareOutputDeviceWinProxy in the GPU process
draws into a shared memory buffer and sends an IPC to the browser
process. LayeredWindowUpdaterImpl receives the IPC and calls
UpdateLayeredWindow().

Having the browser process draw into an HWND with pixels produced in the
GPU process shouldn't be a security issue. The GPU process can already
draw into the HWND via other APIs. Drawing is clipped to the HWND size.

It's not ideal having to send an IPC from the GPU to browser process for
each draw. However, layered windows are the only way for an HWND to
guarantee it supports transparency on Windows 7. Having a child window
in the GPU process is not possible as layered windows are incompatible
with child windows for Windows 7.

HWNDs with transparent backgrounds are used infrequently and don't
update quickly so this should hopefully be performant enough. This code
is also only used for Windows 7.

Bug: 826633
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I3b2d749b75aed7789b19b3e8dfd7d0371ef6fe73
Reviewed-on: https://chromium-review.googlesource.com/1042283
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558462}

Bug: 830810
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I49e61c4ddbdc248dbd354bdf9538da3d986a8a83
Reviewed-on: https://chromium-review.googlesource.com/1054486
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558461}

Bug: 790531,731983
Change-Id: Id859a3540cdbe9798ec22af680878da71212740d
Reviewed-on: https://chromium-review.googlesource.com/1058180
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558460}

The actual test binary is actually baked into the VM image. The gn
target here just builds chrome and a wrapper script around the test
runner.

Bug: 832374
Change-Id: I062c80966abb6a234511ba125cdfb5c86367d9ad
Reviewed-on: https://chromium-review.googlesource.com/1057961
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558459}

The validation layer requires a call to
vkGetPhysicalDeviceSurfaceSupportKHR() even if support was already
verified via vkGetPhysicalDeviceXlibPresentationSupportKHR().

Bug: 840470
Test: Run vulkan_tests on linux with nvidia GPU

Change-Id: I4005e8ef9584a8d413a39882c374c7bc5ab5416b
Reviewed-on: https://chromium-review.googlesource.com/1053989
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558458}

This CL refactor TemplateUrl code related to locale includes:
1. Change all SpecialLocaleHandler to LocaleTemplateUrlLoader to be more
clear.
2. Remove getSearchEngineType from LocaleManager. TemplateUrlService
should be able to get the type directly.

Bug: 835504
Change-Id: I16b6667371673faa749ed96ab06efb16e18556fe
Reviewed-on: https://chromium-review.googlesource.com/1043486
Commit-Queue: Lei Tian <ltian@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558457}

Suggestions containing an action url should launch the url in the
browser. Otherwise we continue to use the suggestion text to submit
a simple query.

See bug for before/after demo.

Bug: b:79597028
Change-Id: I73b02c22e3fbdcef70f20a35100116ebd77261e9
Reviewed-on: https://chromium-review.googlesource.com/1056226Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#558456}

Ensures that test bots cover OfflinePagesSharing flag scenarios.

This was reverted because of a flaky unit test.
The test has been disabled, and a new bug has been filed to investigate.

Bug: 758733
Change-Id: I7043ffe7d520869f79abdc6c80d6bcdbe8029651
Reviewed-on: https://chromium-review.googlesource.com/1043349Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#557636}
Reviewed-on: https://chromium-review.googlesource.com/1056221Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558455}

  - Copies the text-to-speech (TTS) extension API from Chrome to Chromecast.
  - The long range plan is to refactor and move to a common implementation in /components and /extensions/components. However many changes in chrome's TTS implementation will be required before we can get there.
  - So in the interim this CL merely copies and makes the modifications necessary to get a stub implementation of the TTS API working in cast.
  - This copy includes only a TTS stub implementation, without any actual working text-to-speech functionality.

Note that the first patchset is the copy operations only, while the subsequent patchsets include the additional files and  modifications to make them compile and work in cast.

Bug: internal b/79409897
Test: unit and manual tests
Change-Id: I857642efb15607b122d9b13852e01bedfbe45366
Reviewed-on: https://chromium-review.googlesource.com/1049957
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Reviewed-by: Albert Chaulk <achaulk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558454}

This CL fixes a minor interaction issue where the Fullscreen exit
UI can remain visible when transitioning out of tab initiated
fullscreen into browser fullscreen.  The Exit UI does disappear when
the user releases escape, but we should try to be more proactive and
hide the UI as soon as the transition occurs.  Note: This fix is for
the Aura platforms, I will test on MacOS and make a separate fix
there if needed.

BUG=680809

Change-Id: I0bd375005aef05cacf430d14169f28c43e52c5be
Reviewed-on: https://chromium-review.googlesource.com/1057897Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558453}

This patch removes the tab tilting behavior during overscroll in the
tab switcher. This patch keeps the full-roll easter egg.

Bug: 841424
Change-Id: I0ab57f9012a4fd05c92afe427e8886459f5e0086
Reviewed-on: https://chromium-review.googlesource.com/1056160
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558452}

Otherwise, passing an empty allow_credentials (such as for resident
key devices) returns a NotSupported error. This error is appropriate
for U2F devices but not for CTAP2 support.

Bug: 831712
Change-Id: Ia8126e8cdecc2b9149b72f8e636a08f5d5e71d0b
Reviewed-on: https://chromium-review.googlesource.com/1057960Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558451}

We want to propagate pointer-events: none information to cc to generate
correct hit testing data for viz. The plan is to have blink set the hit
testable bit on cc::Layers. In order to disambiguate the bit in surface
layer that represents the origin of the surface, we want to rename the
variable.

Bug: 841358
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I207815dcfad0f29b222b0a39c350f1e926aedac9
Reviewed-on: https://chromium-review.googlesource.com/1052506Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558450}

All framebuffers refer to the same image because the attachment index is
used instead of the swap chain image index. Use the swap chain image
index instead.

Bug: 840470
Test: ozone_demo on X11
Change-Id: Ie9132719be5ed2391042530a5fce4aba8ecbff15
Reviewed-on: https://chromium-review.googlesource.com/1054499
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558449}

Bug: 725241
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I92403b3a703965fa90cdfe998421463a6a3fec59
Reviewed-on: https://chromium-review.googlesource.com/1054006Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558448}

There was a regression since http://crrev.com/ffe776a where Inspector capability was introduced.

Now devtools frontend expects Inspector domain to be present on any targets and crashes if it's missing.

This commit restores usage of capability, adding it to targets that support it to best of my knowledge.

R=dgozman@chromium.org, lushnikov@chromium.org

Change-Id: I6eab098ef12d5212c65cc65f0d49f619aaf4edd3
Reviewed-on: https://chromium-review.googlesource.com/1042709Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558447}

Bug: 841509
Change-Id: I841f3487c12716d4ab0c88a6a27462729308f31c
Reviewed-on: https://chromium-review.googlesource.com/1057837Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558446}

R=tandrii@chromium.org

Bug: 731967
Change-Id: Ief7e6c0d37225f6cef01f8b5960aa4a7aa6e8f4b
Reviewed-on: https://chromium-review.googlesource.com/1057994Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558445}

Bug: 823365
Change-Id: Ib9d707af46d45b4cd5c0eabacd91102f84ef000f
Reviewed-on: https://chromium-review.googlesource.com/1058035Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558444}

Add a new GPU test target that runs screenshot_sync a second time with
--enable-features=VizDisplayCompositor. This test will verify that GPU
compositing is working for OOP-D. The test only runs on Windows and
Linux bots.

Originally landed in https://crrev.com/c/1028613 but was reverted
because it failed on Windows 7 waterfall bots. There is some bug in the
interaction between the passthrough command decoder, OOP-D and frame
capture. Disable viz_screenshot_sync on Windows 7 FYI bots for now.

Bug: 812385, 825906
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I96ad1b49313bf5bbcdca0f464da4b185ee74722a
Reviewed-on: https://chromium-review.googlesource.com/1047146
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558443}

This Cl replaces ID-based link with p-link for the help button on the
Time zone settings dialog.

Bug: 842839
Change-Id: I1d05f041543489c41230856e8240be464b52df1c
Reviewed-on: https://chromium-review.googlesource.com/1058108Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558442}

Add missing value for required parameter pWaitDstStageMask to
command buffer submission. This fixes a validation error:

[25936:25936:0510/163736.372562:1612536696:ERROR:vulkan_instance.cc(24)] Object: 0x0 | vkQueueSubmit: required parameter pSubmits[0].pWaitDstStageMask specified as NULL. (null)

Bug: 840470
Test: Run vulkan_tests on linux with nvidia GPU

Change-Id: Ib7a70da78808872e60d6461cc2ff6495fc50115c
Reviewed-on: https://chromium-review.googlesource.com/1054497
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558441}

Bug: 800762
Change-Id: Ided3819577c81b78bef59bea60718a42812075be
Reviewed-on: https://chromium-review.googlesource.com/1056356Reviewed-by: Urvang Joshi <urvang@chromium.org>
Commit-Queue: James Zern <jzern@google.com>
Cr-Commit-Position: refs/heads/master@{#558440}

Once a sample is being recorded we close the "fast path" (lock free operation)
of RecordFree function. That was bacause insertion of an element into
unordered_map may cause rehashing, making all concurrent read operations
invalid.

The patch makes it be less strict, by locking the fast path only when there's a
chance for the container do rehashing.

Change-Id: I80553f59400f97ada7a2a6097b201c2da62d3b2e
Reviewed-on: https://chromium-review.googlesource.com/1056404
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558439}

Enabling on trunk in preparation for the 100% Stable rollout. 1% Stable
experiment has concluded with positive metrics consistent with the Beta
experiment.

Bug: 799085, 737787
Change-Id: I656f55dd100ca97973e417c11bbb494f4e3c4fa9
Reviewed-on: https://chromium-review.googlesource.com/1055929Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558438}