GitLab

BUG=None

Review URL: https://codereview.chromium.org/311183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277887 0039d316-1c4b-4281-b951-d872f2087c98

Instead of creating the exact match in HistoryURLProvider::DoAutocomplete(),
pass it in in the HistoryURLProviderParams struct.

This also uses this match as the "can't find DB, fallback" match in Start(); I
don't see any disadvantage to creating that match on the results of running
fixup, instead of creating a pre-fixup match like before.

This also splits out CanPromoteMatchForInlineAutocomplete() from
PromoteMatchForInlineAutocomplete().  I'll be converting
PromoteMatchForInlineAutocomplete() into a different function in the next part
of this change, and this happens to make the calling convention a little more
sane anyway.

Also removes a few comments from the .cc file that are in the .h file already.

BUG=376199
TEST=none
R=mpearson@chromium.org

Review URL: https://codereview.chromium.org/336173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277886 0039d316-1c4b-4281-b951-d872f2087c98

Previously it would return an array buffer of the JSON.

This corresponds with the recent spec update:
https://dvcs.w3.org/hg/webcrypto-api/rev/f61017a76a5d

BUG=373917, 245025
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/334333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277884 0039d316-1c4b-4281-b951-d872f2087c98

When the find bar is hidden, there is still an invisible view (its superview)
in its place that was consuming the right-click event.
Fixed this by hiding the find bar superview instead.
Also make sure that the initial state is set to hidden.

TEST=Invoke find bar then close it, right-click where the find bar was, context
menu should appear.

BUG=381207

Review URL: https://codereview.chromium.org/332283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277883 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385198

Review URL: https://codereview.chromium.org/337393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277882 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/326043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277881 0039d316-1c4b-4281-b951-d872f2087c98

The progress bar was not being read properly by screen readers for the
Mac (VoiceOver).  This gives the screen reader enough information to
do its job.

BUG=370512

Review URL: https://codereview.chromium.org/333643007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277880 0039d316-1c4b-4281-b951-d872f2087c98

This is part 1 of the code to start supporting embedded YT for cast. The main
issue is that YT embedded videos need to be identified via the frame that
contains it. This CL sets the frame URL of each video in the MediaPlayerAndroid
object.

Clank downstream piece to come later. 
Min / Aaron: will send you the doc I have that explains this in more detail.

BUG=358573

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277425

Review URL: https://codereview.chromium.org/302453012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277879 0039d316-1c4b-4281-b951-d872f2087c98

This also converts the TextButtons in the BookmarkBarView to LabelButtons, since they need to have the same base class as MenuButton does. This also standardizes on fade eliding instead of fade eliding sometimes and ellipsis eliding in other cases.

This patch has the effect that everything on the bookmark bar also renders with GTK+ borders in GTK theme mode on Linux.

BUG=155363

Review URL: https://codereview.chromium.org/298813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277878 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373344
TEST=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/299663009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277877 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/331853009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277876 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Linux sandbox: add sandbox_linux_unittests.isolate (https://codereview.chromium.org/340523006/)

Reason for revert:
Breaking linux_chromium_clang_dbg 

[7609/24970 | 449.637] SOLINK lib/libmojo_launcher.so
FAILED: cd ../../sandbox; python ../tools/isolate_driver.py check --isolated "../out/Debug/sandbox_linux_unittests.isolated" --isolate "linux/sandbox_linux_unittests.isolate" --path-variable DEPTH .. --path-variable PRODUCT_DIR "../out/Debug " --extra-variable "version_full=37.0.2056.0" --config-variable "OS=linux" --config-variable "chromeos=0" --config-variable "component=shared_library" --config-variable "internal_gles2_conform_tests=0" --config-variable "icu_use_data_file_flag=1" --config-variable "libpeer_target_type=static_library" --config-variable "use_openssl=0" --ignore_broken_items
Traceback (most recent call last):
  File "../tools/isolate_driver.py", line 279, in <module>
    sys.exit(main())
  File "../tools/isolate_driver.py", line 269, in main
    create_wrapper(args, isolate, isolated)
  File "../tools/isolate_driver.py", line 194, in create_wrapper
    assert os.path.basename(isolate) == isolate, isolate
AssertionError: linux/sandbox_linux_unittests.isolate
ninja: build stopped: subcommand failed.


Original issue's description:
> Linux sandbox: add sandbox_linux_unittests.isolate
> 
> BUG=384514
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277867

TBR=nodir@chromium.org,vadimsh@chromium.org,maruel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=384514

Review URL: https://codereview.chromium.org/339183007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277875 0039d316-1c4b-4281-b951-d872f2087c98

The file chrome/test/data/extensions/api_test/gcd_private/api/trun is unneeded.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/342493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277872 0039d316-1c4b-4281-b951-d872f2087c98

Resubmit of https://codereview.chromium.org/332003002

BUG=144491

Review URL: https://codereview.chromium.org/340543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277871 0039d316-1c4b-4281-b951-d872f2087c98

Fixes regression introduced by r276036 that removed the title from
the notification center on ChromeOS.

BUG=350449

Review URL: https://codereview.chromium.org/335413005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277870 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385701
TBR=aboxhall@chromium.org

Review URL: https://codereview.chromium.org/336423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277869 0039d316-1c4b-4281-b951-d872f2087c98

Check the preferences thaht can be controlled by other users.
Also look for the secondary user banner, and controlled-by
indicators in headings.

BUG=359578
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/322293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277868 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384514
NOTRY=true

Review URL: https://codereview.chromium.org/340523006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277867 0039d316-1c4b-4281-b951-d872f2087c98

The picker window is embedded in the parent window and does not have its own native window.

TESTED=verified on Linux, Win and ChromeOS that the picker window is not listed to share with or without a delegate tab, and the chrome window is correctly listed.

BUG=384370

Review URL: https://codereview.chromium.org/338503007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277866 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384010
TEST=new tests added

Review URL: https://codereview.chromium.org/335693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277865 0039d316-1c4b-4281-b951-d872f2087c98

The params is used for ServiceRuntime::StartSelLdr(). ServiceRuntime
already knows if it is for nonsfi or not. So the use_nonsfi_mode in
SelLdrStartParams is just redundant. Remove it.

BUG=333950
TEST=Ran browser_tests --gtest_filter=*NonSfi*:*NonSFI* locally, and trybots.
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32

Review URL: https://codereview.chromium.org/332333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277864 0039d316-1c4b-4281-b951-d872f2087c98

The new method RemoveLoginsSyncedBetween() works exactly like the existing RemoveLoginsCreatedBetween(). 

BUG=362679
TBR=zea@chromium.org

Review URL: https://codereview.chromium.org/335893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277863 0039d316-1c4b-4281-b951-d872f2087c98

Called from android logging macro used in mesa.

BUG=358029

Review URL: https://codereview.chromium.org/321353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277862 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/338933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277861 0039d316-1c4b-4281-b951-d872f2087c98

Improve documentation for Reset and Flush.
Use VpxVideoDecoder in implementation code.

BUG=281689

Review URL: https://codereview.chromium.org/336833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277860 0039d316-1c4b-4281-b951-d872f2087c98

This flag will be controlled via enterprise policy to reenable the
deprecated window.showModalDialog API to extend the time window for
porting apps to other APIs.

The flag will eventually be removed as well.

BUG=345831
R=atwilson@chromium.org

Review URL: https://codereview.chromium.org/334173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277858 0039d316-1c4b-4281-b951-d872f2087c98

Metro's avatar button is no-op w/--new-profile-management.
This may have regressed with r270126, but I'm not sure how.

IsNewAvatarMenu returns true in metro (r263677, r263396).
However, GetNewAvatarMenuButton returns NULL in metro.
(the new button isn't implemented for that frame, afaict)
So ShowAvatarBubbleFromAvatarButton currently does nothing.
Instead, anchor to the avatar menu button or app menu.

Remove the unused |anchor_rect| parameter.

BUG=382895
R=noms@chromium.org,sky@chromium.org
TEST=Avatar button works in Windows 8 mode (metro) with .

Review URL: https://codereview.chromium.org/333353004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277857 0039d316-1c4b-4281-b951-d872f2087c98

We currently set a technology to 'enabling' even if it is not available.
We also enable / disable both Cellular and Wimax on the same UI element
since both are never expected to be available.
Simple fix is to ignore technologies that are not available.

BUG=368754

Review URL: https://codereview.chromium.org/336313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277856 0039d316-1c4b-4281-b951-d872f2087c98

Implement iaccessible and isimpledom

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/330413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277855 0039d316-1c4b-4281-b951-d872f2087c98

KeyboardControllerProxy::GetKeyboardWindow() can create the keyboard window if
it's not already created. So during hit-testing, use HasKeyboardWindow() to
first determine if the window exists, before using GetKeyboardWindow().

BUG=380215
R=kevers@chromium.org

Review URL: https://codereview.chromium.org/341573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277854 0039d316-1c4b-4281-b951-d872f2087c98

The rand_util_nacl.cc will be used inside the IRT and outside the IRT.  So we need to use nacl_secure_random() which will work for both.

BUG=nativeclient:3881

Review URL: https://codereview.chromium.org/334353004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277853 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384729
R=gab@chromium.org, mattm@chromium.org

Review URL: https://codereview.chromium.org/332053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277852 0039d316-1c4b-4281-b951-d872f2087c98

It seems that the logic from the downstream file is different from the
CL that upstreamed it. This CL restores the downstream logic.

Consider this case:

 type == TabLaunchType.FROM_LONGPRESS_BACKGROUND: FALSE
 type == TabLaunchType.FROM_RESTORE: TRUE
 mTabModelSelector.isIncognitoSelected(): FALSE
 isNewTabIncognito: TRUE

In the downstream version willOpenInForeground -> TRUE
In the current version willOpenInForeground -> FALSE which
incorrectlys restores the incognito tab even thought it isn't
the current tab model.

BUG=383470

Review URL: https://codereview.chromium.org/338833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277851 0039d316-1c4b-4281-b951-d872f2087c98

We picked the name "source_prereqs" to try to emphasize that these are source
(compile-time) dependencies rather than data or link-time dependencies.
However, now that all actions are implicit hard deps, the use-case of using
this for binary targets is almost nonexistant (I want to eventually put back
actions-as-soft-deps but this requires some additional checking to make sure
people don't mess up, at which time this may becomre more relevant.)

source_prereqs is hard to type and difficult to understand. Inputs is much more
clear, especially since the typical case is an action.

This will fall back to reading "source_prereqs" for back-compat until we change
all users.

Significantly enhance the "gn desc" command. A bunch of action-related fields
were missing.

BUG=374271
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/333243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277850 0039d316-1c4b-4281-b951-d872f2087c98

BUG=382564

Review URL: https://codereview.chromium.org/320323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277849 0039d316-1c4b-4281-b951-d872f2087c98

1. Fix SendTo() result handler for UDP sockets to properly handle errors
   we may get. It wasn't possible in the past because pepper sockets
   were not returning correct error codes. Now they do.
2. Don't try binding to link-local IPv6 addresses because it always
   fails due to crbug.com/384854 .

BUG=382697
R=wez@chromium.org

Review URL: https://codereview.chromium.org/336113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277848 0039d316-1c4b-4281-b951-d872f2087c98

Clearer this way, especially since a deletion may entail a hierarchy
change.

BUG=365012
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/331243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277847 0039d316-1c4b-4281-b951-d872f2087c98

(Per review comment from https://codereview.chromium.org/330933004/.)

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/339923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277846 0039d316-1c4b-4281-b951-d872f2087c98

After the landing https://codereview.chromium.org/317203004,
background_contents_service.cc doesn't need the command line switch
related headers anymore. So we can remove these.

BUG=350898

Review URL: https://codereview.chromium.org/338083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277845 0039d316-1c4b-4281-b951-d872f2087c98

Locally, this reduces the time the suite takes from ~15 seconds to ~5 seconds.

BUG=384314

Review URL: https://codereview.chromium.org/333893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277844 0039d316-1c4b-4281-b951-d872f2087c98