- 30 Oct, 2019 40 commits
-
-
Ahmed Mehfooz authored
Initializing the system tray and message center with chrome vox enabled causes a crash when the tray event filter references the message center bubble before it's constructor is fully executed. This fix ensures this doesn't happen by separating the constructor from the part of the code which shows the bubble. Change-Id: I297bf5212fb82a3372081dc418c25473f22d5cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881689 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#710585}
-
Austin Tankiang authored
With the removal of the legacy drive client, DriveFsTestVolume can be used instead. Bug: 1003238 Change-Id: I57e99412c4a22c6bfa2d831f3506dc48309fa489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885865 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#710584}
-
Timothy Loh authored
Change-Id: Ie57165228901ff1c85907ea7c1e20829b3a04e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884403Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#710583}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9a8fdbed. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Idf4fb87083981a1b900aaf42b42f929309fdef28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888575Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710582}
-
Mitsuru Oshima authored
Bug: 1019485 Change-Id: I016c2529ad046180be57e8904a16fff9ff0b6c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887874Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#710581}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 79 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-04-26. Change-Id: I606fe320a735c8914ca01400ccc3b8bb3abc553b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886631 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#710580}
-
Yusuf Sengul authored
?sz={n} query parameter to specify the Google profile image size doesn't work. It may not be supported anymore. This change fixes it as well as adds logging in a couple of places. Bug: 1019032 Change-Id: I4fe794ac5e8f04b3624de2d021dd2a526e565294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885346Reviewed-by:Tien Mai <tienmai@chromium.org> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#710579}
-
Wei Li authored
The manual layout just put one child view at the start and one in the middle vertically. This CL removes the manual layout by introducing two container views to be placed in equal size vertically. BUG=1005568 Change-Id: Iae552da751d71175d3967deaf788a323221d0a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884999 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#710578}
-
Regan Hsu authored
Currently, the confirm button is not disabled while the password is being checked,serving a confusing experience as users can repeatedly hit the confirm button without a visual ack that the password is being checked. This CL disables the confirm button while the password is being checked. Bug: 999475 Change-Id: I907017dd1f7bfdf4cff318b0621d730b113200bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888150 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#710577}
-
Jesse Schettler authored
Replace PrintMsg_PrintingDone, PrintMsg_PrintPages, and PrintMsg_SetPrintingEnabled IPC messages with new Mojo methods. Update AwPrintManager and HeadlessPrintManager to also use these new methods. Bug: 1008939 Test: Print a webpage and PDF Change-Id: I3a403dd47ffc9c4debe819d26b00eccbd24b1180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876473 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#710576}
-
Avery Musbach authored
The present CL modifies GetGridBoundsInScreenForSplitview so that it uses the correct split view controller when on an external display. SplitViewOverviewSessionInClamshellTestMultiDisplayOnly.Dragging Test: ash_unittests Bug: 1019221 Change-Id: Ibba4867a342d6a4057e7bb724fbd24b0dae85d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887837 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#710575}
-
Daniele Castagna authored
Add 4 UMA stats for both internal and external monitors. These metrics will help answering OEMs/PMs questions like: - How many users connected an external monitor with resolution X? - How many users are using high refresh rates monitors? Additionally these metrics can be used to drive compositor development efforts. For example, some optimizations might be beneficial for displays with a lot of pixels, but add a constant cost that might not be justifiable for lower resolution screens. ConfigureDisplays.{Internal,External}.Modeset.Resolution tracks the resolution of the mode we're setting on the display. ConfigureDisplays.{Internal,External}.Modeset.RefreshRate tracks the refresh rate used for modesetting. The following metrics can be useful to detect how many times users experience slow display modesetting (a few modes fails) or failure in modesetting (the screen will stay black) ConfigureDisplays.{Internal,External}.Modeset.AttemptSucceeded tracks succeeded attempts at modesetting. ConfigureDisplays.{Internal,External}.Modeset.FinalStatus tracks when a monitor has eventually been mode set (there might be more than one attempt before it succeeds). Test: Plug in a monitor and check about://histograms. Change-Id: I047fd816683983e669e01638a75668e6c7732c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860299Reviewed-by:Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#710574}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 80-3931.2-1572259441-benchmark-80.0.3950.1-r1 to 80-3931.2-1572259441-benchmark-80.0.3951.3-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Iaf3be37b0b6553f400dae5f9b0c59e6ea1bb0f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888825Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710573}
-
Hector Carmona authored
Bug: 876601 Change-Id: If0bd85c62c7f25b46df2ca5c5d0905d2bc9d14b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887845Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Auto-Submit: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#710572}
-
Gyuyoung Kim authored
This is a reland of 78abc7fa Fix an unchanged caller of CreateAssistantAudioDecoder() in AudioStreamHandler::StartAudioDecoder(). Original change's description: > Migrate AssistantAudioDecoderFactory to new Mojo types > > This CL applies the new Mojo types to CreateAssistantAudioDecoder > in AssistantAudioDecoderFactory interface. > > - Convert FooRequest to mojo::PendingReceiver. > - Convert FooPtr to mojo::PendingRemote or mojo::Remote. > > Bug: 955171 > Change-Id: I2de4cb0561c69201335817ec6a873258a30d9a00 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871503 > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709059} Bug: 955171 Change-Id: I0fe2281c64c5c15b8d1d6d324f966329bfac1c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880236Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#710571}
-
Gyuyoung Kim authored
This CL applies pending_receiver to AcquireWatchTimeRecorder and AcquireVideoDecodeStatsRecorder in MediaMetricsProvider interface. - Convert FooPtr to mojo::PendingRemote or mojo::Remote. - Convert FooRequest to mojo::PendingReceiver. - Convert MakeStrongBinding to MakeSelfOwnedReceiver. Bug: 955171 Change-Id: Ife29eb0e123324305d316b1ec0b9ec3754488e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885851Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Wenbin Zhang authored
In order to ensure homogeneous fleets, we need to have more specific dimension values when looking for bots. This set of CLs updated some existing dimensions, and added the synthetic_product_name values for dimensions if appropriate. This CL updated the dimensions for linux-perf: - Added synthetic product name 'PowerEdge R230 (Dell Inc.)'; - Updated GPU from '10de:1cb3' to '10de:1cb3-384.90'; - Updated OS from 'Ubuntu' to 'Ubuntu-14.04' Please check the link below for the available bots based on the old/new dimensions: https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=gpu&c=os&c=status&c=synthetic_product_name&d=asc&f=gpu%3A10de%3A1cb3&f=os%3AUbuntu&f=cpu%3Ax86-64&f=pool%3Achrome.tests.perf&s=id Bug: chromium:996830 Change-Id: I0eaaea53448d3044b6f10f9020c8f4c1a27318eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888193Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#710569}
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for mojom::BlobURLStore using SelfOwnedAssociatedReceiverRef instead of StrongAssociatedBindingPtr. Bug: 955171 Change-Id: I5069e33e5397da53cee6138ad070de1d5bc54619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886550Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Jesse Schettler authored
The switch statment found in GetColorModelForMode() is useful for determining whether a ColorMode is color or monochrome. Move it into a new static function for other classes to use. Change-Id: I834e503744c698ca82a2ef841f9b22484c49b414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888737 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
-
Toby Huang authored
According to go/unicros-extensions-dd, we should remove the installed_by_custodian flag, which was originally created to mark remotely force-installed extensions for legacy supervised users. Since legacy supervised users are deprecated, this flag is deprecated as well. Bug: 1014183 Change-Id: Ifcda35765c2ed05e4c5b2025a5778f223cc0c828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861280 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#710566}
-
Sinan Sahin authored
This CL adds a helper Animation class to browser_controls_offset_manager and separates the top and bottom controls by giving them Animation instances. Currently, the top and bottom controls still animate together, but an upcoming CL will make use of the separated animations. Bug: 989148 Change-Id: I8d7062073cfe300a52d9fa643e47982ef618b811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862269 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#710565}
-
Reilly Grant authored
The AmbientLightSensor class has not been shipped and is still behind the "SensorExtraClasses" flag. In feature_policy_features.json5 however this policy was only behind the "Sensor" flag, which was marked stable as part of shipping the motion and orientation subset of the Generic Sensor family of APIs. This change fixes the dependency, effectively unshipping this policy. Change-Id: Idce46684545807cce6134021c357051520e6a713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762690Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#710564}
-
Megan Jablonski authored
Bug: 1017489 Change-Id: I5933118b329b9c21297bed80b529f43563eb933d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881810 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#710563}
-
Gyuyoung Kim authored
The previous CL has missed to apply pending_receiver to Connector::Clone. This CL makes Clone use pending_receiver. - Convert FooRequest to mojo::PendingReceiver Bug: 955171 Change-Id: I506bcf413427c901cbd3ead571c941a9f5f0eb56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886084Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
ServiceWorkerContainerHost::Register() should always take a non-null FetchClientSettingsObject. Bug: 937177 Change-Id: I983f8aa25f5f3e66d64c4947d1f8bae0d10c2edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884400Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710561}
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/eab918f02856..cda1ce2eee02 $ git log eab918f02..cda1ce2ee --date=short --no-merges --format='%ad %ae %s' 2019-10-28 renjietang Remove QuicConnectionPeer::GetVisitor(). Created with: roll-dep src/net/third_party/quiche/src Change-Id: Ifba915730474920589846b0b66f32bf4e77dd0eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888294 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710560}
-
Donn Denman authored
Fixes a drawing problem where the ellipsis on contracting text does not erase when it contracts and the icon is drawn over the older version of the text image. This only happens on one brand of devices. Renames the OverlayPanelRepaddingTextView.java file to OverlayPanelAdjustingTextView.java and the actual adjustment is done in native code now (which is not ideal -- see bug for details). BUG=1012835 Change-Id: I4c1068743a54e7970d12dfa5cce23dd1f1733235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883113Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 80-3940.0-1572255699-benchmark-80.0.3950.1-r1 to 80-3940.0-1572255699-benchmark-80.0.3951.3-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I02bfa6f9b731cac63f6964b9b40a193a69d6b7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889090Reviewed-by:
-
Xiaohan Wang authored
- Add AddBaseFactory() to simplify caller code since in most cases we are adding base factories. - Generalize QueryIsRemotingActiveCB and QueryIsFlingingActiveCB into one ConditionalFactoryCB. - Misc cleanups. Bug: 1018372 Test: Updated tests Change-Id: I508957bd11500f8028b2fd4d0d4431069bf38f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881121 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#710557}
-
dpapad authored
CL produced with ESLint --fix and clang-format. This is in preparation of turning on web-dev style related PRESBUMIT checks for this folder. Bug: 1019312 Change-Id: I6e8400d2125b55a1a22603eb7d81f1889d914b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887840Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#710556}
-
Alex Newcomer authored
A few changes: - Catches some hotseat corner cases causing multiple state changes - adds tests to catch these multi-state changes - Adds the ability to determine that Overview is in the process of being toggled. Before this cl, overview would be in the process of being shown but it was not clear if it was being shown or hidden until it was too late. Bug: 1018346 Change-Id: I6e8dfd0a9b0256134770e207345f4926bfc512ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885173 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#710555}
-
Lukasz Anforowicz authored
This is a follow-up to r694827 which intended to ensure that |request_initiator| is always set to the website (and not, for example, to the content script's origin), but missed fixing this for XHR API. Note that some follow-ups for r694827 (e.g. r700486 and r704100) have already landed in M79 - these follow-ups assume that |request_initiator| is set to the website origin everywhere. This CL fixes this assumption for XHR. We should consider merging this CL to M79 (otherwise CORB and CORS might incorrectly start to block same-origin XHRs). This CL is also a prerequisite for starting to enforce request_initiator_site_lock in a follow-up CL at https://crrev.com/c/1875273 Bug: 1017448 Change-Id: I8512daf9364aaa10d76c81ef9bcc18f072a2337d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876981 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#710554}
-
Jordy Greenblatt authored
The elements were both 'cr-link-row's with the id sync-status removed in [1] and [2] respectively. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1871989 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1869657 Bug: 1015805 Change-Id: I495213225e6d1413a537f750a3d265a5885f52c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885555Reviewed-by:
Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#710553}
-
John Abd-El-Malek authored
Also rename WebLayer's NavigationCommitted to ReadyToCommitNavigation for consistency. Change-Id: Ib7c08067e30987018a3192acfe835d4d00e6e49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872995 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#710552}
-
Anqing Zhao authored
Extract the logic of generating BrowserReport from ReportGenerator class. It can be shared by following classes. * ReportGenerator: which is existing to generate ChromeDesktopReportRequest. * ChromeOsUserReportGenerator: which will be newly added to generate ChromeOsUserReportRequest (for Chrome OS only). Bug: 1010213 Change-Id: I4bd64080319732bd200ae719dd1b9af00d41cdda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876033 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710551}
-
Caleb Rouleau authored
This change reduces the number of stories that we run as part of system_health_smoke_test from 82 to 27. We do this by limiting ourselves to health_check stories, which are recognized as the most important to maintain. (Note also that we aren't running all of the 27 since some of those are currently temporarily disabled.) Bug: 1019383 Change-Id: I271a0e94288177e9387c9f5551ff44d6e072b9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888136Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#710550}
-
Theresa Wellington authored
Previously we relied solely on a check for the item position to determine if "Move up" and "Move down" items should be shown in any given bookmark item menu. This CL updates the check to also makes sure the bookmark is moveable. It looks like we had this check at one point and it got lost in a bad rebase. BUG=1019178 Change-Id: I595ba7646de23f79bd13e85d0bb2bb1e5d17f413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887732 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
Renjie Tang authored
Change-Id: I43d60c450a80288980cf65313a601771a5123128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875648Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
RJ Ascani authored
This CL is the next step in a soft transition for updating the Fuchsia key id type to be a bytes field and rename fuchsia.media.drm/ENCRYPTION_MODE to fuchsia.media/ENCRYPTION_SCHEME. In particular, this step removes the LicenseSession/OnKeysChanged event handler and renames the encryption mode references to scheme. Bug: fxb/38522 fxb/38438 Change-Id: Ibbb06af16cd10ef3e71fbd0ce70e441e412c3947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884282Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: RJ Ascani <rjascani@google.com> Cr-Commit-Position: refs/heads/master@{#710547}
-
John Chen authored
This reverts commit 263061fc. Reason for revert: Causing all builds to fail on mac-builder-perf (https://ci.chromium.org/p/chrome/builders/ci/mac-builder-perf) Original change's description: > Roll clang 373424-64a362e7-1 : n330255-55c223a7-1. > > Since upstream llvm/clang has moved to Github, there are no longer any svn revisions. > Instead, our package versioning scheme now begins with the number of commits since > the initial commit in the repository, prefixed by an "n". > > These "n" numbers are NOT comparable to svn revisions. > > Ran `tools/clang/scripts/upload_revision.py 55c223a7ed522293cf9995d07d348368c345d1f2`. > > Bug: 1011815 > Change-Id: If2b9dce272182ca4f0881424e1d64410b796b4c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879890 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710354} TBR=thakis@chromium.org,hans@chromium.org Change-Id: I203d5f8c9e3880d2bc85bb5efa422a9654736a6f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1011815, 1019517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889211Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#710546}
-
