- 03 Mar, 2020 40 commits
-
-
Vasiliy Telezhnikov authored
After BeginWrite was moved out of critical path SkiaOutputDeviceBufferQueue::Image is often in the middle of write. When resize or reallocation of display happen (e.g rotate screen on Android) we need to call EndWrite on the image before destruction to ensure all necessary semaphores are submitted. Bug: 1056221 Change-Id: Id55c25f43cbb4bf082ad3e3ef6cd1b59e164937d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083835 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#746438}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia29f89b3066ea48480a59b9a56482e44758e6970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085017Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746437}
-
Anders Hartvoll Ruud authored
I forgot to actually set the CSSValue (i.e. cache key), which means the cache was never used. This CL adds a performance test for this which should catch regressions in the future. The test works by specifying a couple of shorthands, each of which has a large number of var() references that needs resolving. Local testing on my machine shows ~170ms with the cache enabled, and over 500ms with the cache disabled. Change-Id: I867679969bb6617219388e0b6f28adc3ae223f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080262Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#746436}
-
Maksim Ivanov authored
This fixes the UX glitch that pressing the "Back" button in the SAML smart card PIN dialog (<security-token-pin> Polymer element) was triggering the "Network Error" screen. The underlying issue is that cancelling the PIN dialog indeed aborts the TLS handshake with an error, but it doesn't make sense to show this error to the user. The proposed fix is to remember whether the PIN dialog was canceled during the current authentication attempt, and suppress the network error in that case. Bug: 1052409 Test: start SAML login via a smart card, proceed to PIN dialog, press "Back", verify that no Network Error screen is shown Change-Id: If54dbd067da763afca7ceec4957bebf0d748da9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069542 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#746435}
-
Rune Lillesveen authored
Sadly, we do SetInlineStyleProperty() for UA shadow DOM during style recalc in some cases. Make sure that we don't schedule any invalidation while in style reacalc as that would leave use with a dirty tree for style invalidations after UpdateStyle(). This fixes a regression introduced in [1] where we unified the invalidation code for the various ways of changing the inline style. [1] https://crrev.com/2faf55836255e6762141712d943c47f3208c8ac4 Bug: 1057210 Change-Id: I0edab4acc03baefe0fb386c15dce78e0f8e041ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082382 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#746434}
-
Reilly Grant authored
This is a follow-up to r689238 which makes sure that the file descriptor watchers are always removed before closing the serial port. The previous fix handled most cases but left open the possibility that a watcher was still registered if there wasn't a pending read or write operation to cancel. Bug: 1057858 Change-Id: I0c760b84cbad2ec4632c9d99e8c5b2550d770ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083922 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#746433}
-
Nina Satragno authored
Move the timeout adjustment from blink to the browser and avoid adjusting it if we detect a discovery factory override is in place. This change makes authenticator browser tests and WPTs 3X faster. Fixed: 976428 Change-Id: Iaea88f356a6d090c14474151b29c04e912c471b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079043 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#746432}
-
Ovidio Henriquez authored
This change fixes the icon for the Payment Handler site setting. This icon was mistakenly set to "settings:bluetooth-scanning" in https://crrev.com/c/2058064. Change-Id: I092f85624d6442edbb1258ee3cc23fc90370d785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082907 Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#746431}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/83762b21dbd2..496a335a8700 git log 83762b21dbd2..496a335a8700 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 jonaso@webrtc.org Add field trials for sending ping on network switches 2020-03-03 srte@webrtc.org Makes Thread::Send execute sent messages after pending posted messages. 2020-03-03 marinaciocea@webrtc.org Transform encoded frame in RTPSenderVideo. Created with: gclient setdep -r src/third_party/webrtc@496a335a8700 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I81f92d715644ef4645972b7eceac2be7ee03f9fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083970Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746430}
-
Ovidio Henriquez authored
This change implements FakeBluetoothDelegate which fakes the behavior of the new Web Bluetooth permissions implemented behied the WebBluetoothNewPermissionsBackend flag. Therefore, the web-bluetooth-new-permissions-backend virtual test suite runs the Web Bluetooth tests with this flag enabled. Design doc: https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM/ Bug: 577953 Change-Id: I5f81b92433009fc34a6a5e5495fdba72500db41e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080813 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#746429}
-
Maksim Moskvitin authored
When signin cookies are cleared, then related data like locally stored trusted vault keys should be cleared. This CL adds RemoveAllStoredKeys() function to TrustedVaultClient interface. The contract is that this function should clear all keys previously stored by StoreKeys(). Since mobile OSs fetches the keys outside the browser and doesn't store anything within the browser data, there is nothing to clean. The implementation relies on IdentityManager::Observer::OnAccountsCookieDeletedByUserAction() call and analogous to autofill::prefs::ClearSyncTransportOptIns() and password_manager_util::ClearAccountStorageSettingsForAllUsers(). Bug: 1019658 Change-Id: I4993bf63cd777e652055b13be29987ef5eee6dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080484 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746428}
-
Josh Nohle authored
Do not assume the local device has an Instance ID in the DeviceSync client if v2 DeviceSync is enabled. The local device will always have an Instance ID with CryptAuth, but there might be a race condition while v1 and v2 DeviceSync are running in parallel; the v1 local device data--which does not contain an Instance ID--might be returned before the v2 local device data. Bug: 951969, 1019206 Change-Id: I46882202d99cde87efc60cdd60628053a96c74f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078749 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#746427}
-
Mohsen Izadi authored
For injected scroll gesture events, we are incorrectly logging EventLatency of the original event leading to the injected event, rather than the injected event itself. Bug: 1054007 Change-Id: I8a95fbdb6b5eb05a5cf6d7797951098d15141809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070372Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746426}
-
Sylvain Defresne authored
As iOS has fully migrated to ARC (automatic reference counting) and there is no traction to migration macOS to ARC, remove the support allowing to use scoped_{nsobject,block} in files build with ARC. The guards are not necessary as scoped_{nsobject,block} won't build with ARC since they contains calls to -release and cast blocks to void*. However, they make it easier to understand that this is not supported, so add them for documentation. Bug: 1051997 Change-Id: I3db04ec645cb1830b92003723631c119e6e4a94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082385 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#746425}
-
Stephen Chenney authored
The goal is to gain a better understanding of the effective zoom seen by users so that we can properly prioritize sub-pixel work (non-integral zoom results in pixel aligned content becoming un-aligned) and triage bugs related to zoom and sub-pixel rendering. Bug: 1040550 Change-Id: Iab1eb8b0cfcf5c1ee2fb75c6653deadc50c7a5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071329 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#746424}
-
behdad authored
Removed the code for the expired metric of MainAndImplFrameTimeDelta2 in compositor_timing_history. Bug: chromium:1037242 Change-Id: Ib5e6537275b4c585a9a4b031801d8ff042f15706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075042 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#746423}
-
Yue Zhang authored
Original change's description: > Currently, when a tab in group is selected or a new tab is created > within group, the tab strip doesn't scroll to the position of the > currently selected tab. This could lead to a state where user needs to > scroll by themselves to find their selected tab in strip. This CL fixes > this issue by making following changes: > * Always scroll the strip to the last position when new tab is added > in group. > * When selected a tab in group (through tab grid dialog etc), try to > scroll to a state where the selected tab is in the middle of the > strip, if possible, > > Bug: 1054079 Change-Id: I8397d2fbd1cdff340fc1ad221abb3a54baa16514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078901 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746422}
-
Haiyang Pan authored
Also enable some tests that work fine after switching to playstore image Bug: 1046059 Change-Id: Iaaf02429d35dc63716d221728c40009cc328a8ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084090Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#746421}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96c2eb6258ae..94b928cd7d3d git log 96c2eb6258ae..94b928cd7d3d --date=short --first-parent --format='%ad %ae %s' 2020-03-03 michaelludwig@google.com Fix GM for preAbandonGpu flag 2020-03-03 michaelludwig@google.com Don't draw as sprite when alpha, CF, or MF are present 2020-03-03 robertphillips@google.com Add onPrePrepareDraws & createProgramInfo methods to GrDrawVerticesOp (take 2) 2020-03-03 reed@google.com switch to virtual with no bones Created with: gclient setdep -r src/third_party/skia@94b928cd7d3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I508531537324896dbc6eb0e7ed643ee37c3ff38b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085011Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746420}
-
Ahmed Fakhry authored
This provider runs only when chrome is started with the flag --task-manager-show-extra-renderers (which is the case from the crash report). The task manager can stop updating; instructing all the providers to clear their data, and suspend all updating. However, RenderProcessHostTaskProvider used to observe RenderProcessHost lifetime events and update the task manager regardless, which causes a crash if the task manager has stopped updating. BUG=1043379 Change-Id: I6fd57125eae09e00ab5aed10f6c6b3336145933b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083955Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#746419}
-
henrika authored
Adds more detailed native logging for the lowest audio layers for both input and output sides (Linux PulseAudio and Windows Core Audio). Focus is on Windows since that is where we have the most users and we see most error reports. Example of new output: https://paste.googleplex.com/6563757645889536 Bug: 1017219 Change-Id: If0f4f157e57f5a387b20fdffe41198f83e2fb9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062428Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#746418}
-
Alison Maher authored
The ForcedColors flag will be expiring from about:flags after the branch for 82. Extending the expiration to branch 85. Bug: 970285 Change-Id: I788ac31e6053c8577b291815973781b8aec79a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083951Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#746417}
-
Paul Lewis authored
This removes the user-metrics-perf.js layout test in preference to the end-to-end test in the DevTools repo, created in this CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2084582 Bug: 1032561, 1046784 Change-Id: Iebe9baf872302579af89cea3542e343c9681a185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084557Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#746416}
-
Greg Thompson authored
- ReportGenerator can now optionally generate a report lacking full profile info. - BrowserReportGenerator and ReportGenerator are now stateless. - ReportScheduler now observes BuildState and generates/updates a minimal report for desktop Chrome when an update is available. If a trigger to generate a report arrives while a report is in-flight, its handling is deferred until the previous completes. BUG=1043624 R=zmin@chromium.org Change-Id: I7864ee467bd681869ba0a57015c718cd811dc4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036072 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746415}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I8d84f37600e97535466d8c5da717fec7fff56b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084673Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#746414}
-
Sammie Quon authored
Shelf animations have operations to animate bounds to and from empty rects, so I had to make some changes to BoundsAnimator. To empty dst rect is fine, modified code that BoundsAnimator uses in ui/gfx to accept calculating transforms to empty dst rect. For empty src rect, the use_transforms option will fallback to using a bounds animation. Test: manual Bug: 1051492 Change-Id: Icbed996a77a31db9d989435b6815294b1067a87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079607Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#746413}
-
Alison Maher authored
Both LinkSystemColors and NewSystemColors have been stable for several months. Removing the flags as a result. http://crrev.com/c/1829645 Bug: 1015968 Change-Id: I8e4926941c634349ff47c0c9dd86ae4d0e7749ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082996Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#746412}
-
Alison Maher authored
The initial value for color has recently been updated from black to CanvasText: http://crrev.com/c/2033144. As a result, forced_colors.css and svg.css no longer need to apply this style after reverting for forced colors mode. This change should have no functional effect. Bug: 970285 Change-Id: I50bcacb1ef355ef26def9fc6768aa1aa654688c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082997Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#746411}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d5af67a8. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" d5af67a8 "Don't compare px rounded font sizes." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: If7f675dfc06f12e0203491fe9bf434e95645f2d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083059Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746410}
-
Eugene But authored
NTP url path may contain trailing slash ("//newtab/"). Bug: 1046231 Change-Id: I3fd313c6489d7a78e471affa86089d6a9bcae8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081239 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#746409}
-
Andrew Grieve authored
The default was changed to 2, but size builds don't need the extra info. Change-Id: I8e28af952d3452334c020f8fe4d975a395dd7d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083346 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#746408}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6566156b03a0..181bb9733f83 git log 6566156b03a0..181bb9733f83 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 vapier@chromium.org luci: allow bytes in payload 2020-03-03 tbegin@google.com packages: improve uprev_ebuild_from_pin unit tests 2020-03-03 vapier@chromium.org scripts: convert random standalone programs to python3 only 2020-03-03 vapier@chromium.org cros_update: allow python2 again 2020-03-03 jrosenth@chromium.org cros_set_lsb_release: change to --unibuild flag 2020-03-03 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-02 vapier@chromium.org service: convert most modules to python3 2020-03-02 tbegin@google.com packages: add manifest to commit for uprev_ebuild_from_pin 2020-03-02 mikenichols@chromium.org chromeos_config: Refactor to build rapid builders from chromeos_boards. 2020-03-02 yueherngl@google.com drallion: add firmware branch builder 2020-03-02 vapier@chromium.org cros cli: convert all subcommands to python3 only 2020-03-02 saklein@chromium.org api/router: Refactor protobuf internals usage. Created with: gclient setdep -r src/third_party/chromite@181bb9733f83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ib48f591036b918ae98c71eb4889606d07f2daa5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083969Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746407}
-
Kuo-Hsin Yang authored
BUG=b:149833548 Change-Id: Ibcaead958fb5b56c5bedf19649be1433644837c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082664 Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#746406}
-
Gang Wu authored
Bug: 977402 Change-Id: I37f6200fbfdb4d613362e7e309ba60ed34a64f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033544Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746405}
-
Rouslan Solomakhin authored
Patch #6: Remove an unnecessary layer of methods for firing the "canmakepayment" event on Android. Bug: 1005076 Change-Id: Ia943f24e2e0931b80e7e31dd347411aab57b5748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080197Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#746404}
-
Tim van der Lippe authored
This has been replaced by an e2etest in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2084583 Als note that this test was erronously passing, even though the functionality under test is broken. R=aerotwist@chromium.org Bug: 1003497 Change-Id: I9cbfc67607c50125ecdca27aef8d8415f0296424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083490 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#746403}
-
Kush Sinha authored
This reverts commit ea6fab21. Reason for revert: AccountReconcilor has a non-predictable end-state. It can end up in failure or success states depending on race conditions. See https://crbug.com/1053905 for details. Original change's description: > Remove OAuth2LoginVerifier > > Remove OAuth2LoginVerifier and make the OAuth2LoginManager observe > AccountReconcilor instead of doing /MergeSession. > > DD: http://doc/1fACI5GQgXvmlmEJj6aPedazXeDZAZPw9jH_E91WGe3w > > Bug: 977137 > Change-Id: Iaa21dd12f0ca6568d920f135bbfdddf3f9def088 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674099 > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Kush Sinha <sinhak@chromium.org> > Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738673} TBR=xiyuan@chromium.org,droger@chromium.org,holte@chromium.org,sinhak@chromium.org,anastasiian@chromium.org Bug: 977137, 1053905 Change-Id: I5f7a92732c367f3fa07bc9ac0a688a5c4e3b4be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081430Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#746402}
-
Zhuoyu Qian authored
This CL update the functions GetOriginsForTypeOnFileTaskRunner and GetOriginsForHostOnFileTaskRunner of FileSystemQuotaUtil to use dedicated Origin type instead of GURL. Change PluginPrivateDataDeletionHelper::CheckOriginsOnFileTaskRunner also. Bug: 598424 Change-Id: Ica53219f4f7acbf457195a7cb964b404bf7af98b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074842Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#746401}
-
Manuel Rego Casasnovas authored
In r745093 we fixed an issue with sticky elements with strict containment. However that introduced a performance regression in the following test: perf_tests/paint/contain-update-layer-tree.html This change applies the fix only for sticky positioned elements so the performance tests comes back to previous numbers. Change-Id: I686e2cfee13a3e44f5f67d05ed7526b6f01d4e5f Bug: 1057255,1057257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083030Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#746400}
-
Maksim Ivanov authored
Change the color of the "smart card" ("chip") icon displayed in Ash Login Screen to use the value recommended by the UX designers: #E8EAED. Implementation-wise, this desired color is denoted as "GoogleGrey200". Bug: 1024254 Test: log in via a smart card and log out, take screenshot, verify that the "smart card" icon displayed under the user pod has colors #E8EAED Change-Id: I15d53810434975b80d1ee5c0fccaba18a1b8c1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085071Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#746399}
-