GitLab

The list is currently not being requested because the backend doesn't
support it yet.

Bug: 966646, 963165
Change-Id: I8533d5da79c8e88a5d15285c3ee3610551d47bc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650510
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670311}

These file manager apps have a shelf presence, but can only be launched
when provided a filename to open. Pinning them creates an item that does
nothing.

Bug: 955396
Test: ChromeLauncherControllerTest.UnpinnableComponentApps
Change-Id: Id157a74606c774c10afef97afe02cbca73026764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661315
Auto-Submit: Trent Apted <tapted@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670310}

Changing the expiration date of Signin.AccountReconcilorState.OnGaiaResponse
histograms to M87.

Bug: 975868
Change-Id: I545ee977dff5648a7af18daeef73b39f1abb4f28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665689
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670309}

Watch dog test functions SetAlternativeTerminateFunctionForTesting() and
SetTimeoutForTesting() are not used. Delete them.

Bug: 949839
Change-Id: I1bd01d02ac4fcac4297789b3aca2c8aa73f77510
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662629Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670308}

https://pdfium.googlesource.com/pdfium.git/+log/f0f9a8f1fd94..84079432edd2


git log f0f9a8f1fd94..84079432edd2 --date=short --no-merges --format='%ad %ae %s'
2019-06-18 thestig@chromium.org Add tests for the PostScript truncate operator.
2019-06-18 thestig@chromium.org Add a pixel test for /Range in PostScript functions.
2019-06-18 thestig@chromium.org Reuse CFX_FontMgr::GetFixedFace().


Created with:
  gclient setdep -r src/third_party/pdfium@84079432edd2

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=pdfium-deps-rolls@chromium.org

Change-Id: I0b6f6026607b0688fb8f01468f3a19056c1dbce6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665968Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#670307}

Bug: 974933,974967,976026
Change-Id: Ief0a20ae0d119cf9361d0d7edfe936a385a8e95d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663320Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670306}

Bug: 973674
Change-Id: I5549cc0a3995e450c04e6c34d379825cea4a873a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665288Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670305}

These are important indirect performance metrics that should be kept
around roughly indefinitely.  This is both to understand how content in
the wild is changing and how changes to the codebase are affecting these
metrics.

Bug: 975186
Change-Id: I98eed0400682ff8155fb42123d6978368f5ad40e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663082Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670304}

Example failure: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/894
Failing bot: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak

TBR=aboxhall@chromium.org

Bug: 976438
Change-Id: Ib95fd2a98df825981f8fd8d87b04db66a802cf48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666291Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670303}

Upcoming CLs will change the heuristics for selecting the low-power
vs. high-performance GPUs on dual-GPU systems, macOS in particular.
The GPU tests in Chromium's hardware fleet expect to run on the
high-power GPU, so maintain this behavior by default.

Bug: 965842
Change-Id: I17707475a4505905ea95a8a57d06a1754fc101fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665910Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670302}

When the context is lost during creation, on some drivers we may have had bogus values
during initialization for the static queries, which means we might have constructed a
ContextState that's inconsistent with other ContextStates for the same real context,
which causes problems when doing virtualized context switches.
So check reset state after initialization and fail if the context is lost.

Bug: 946978
Change-Id: I38fb73d819dfcedf0565e6b4345c3700c49fbb07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659644
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Auto-Submit: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670301}

grpc_core::InlinedVector has a few (reinterpret|static)_casts that look
benign but will trigger CFI bad cast check. I've tried to suppress the
check by adding "-fno-sanitize=cfi-..." when building the gRPC lib
(http://crrev.com/c/1660194), but it doesn't seem to have any effect on
the canary ChromeOS build. As suggested by pcc@, this CL blacklists the
whole inlined_vector.h file for CFI cast check.

For longer term, we will need to fix InlinedVector to prevent it from
casting the element before initializing it. This is tracked in github.

Bug: 972108
Change-Id: Ic90631f9e66d15e1a3c8d073c99bfb69a6400103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665554Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670300}

This patch removes following histograms:
  Hyphenation.Open
  Hyphenation.Open.File

These are added to learn how long it will take to open
hyphenation dictionary. A concern was raised when I
implemented hyphenation on Android as the open operation is
synchronous.

We do not see the data indicating needs to invest in
asynchronous hyphenation at this moment, and the data is
steady that further recording does not seem to be necessary.

Bug: 975142
Change-Id: I1d98eedf47a1afa5940f6e01b3c6fadcca4cbcdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664092Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670299}

Creates and implements a QuarantineFile mojo interface.
The implementation in QuarantineImpl calls existing
quarantine::QuarantineFile(), converts the return value to a mojo type,
And runs the callback.

The service is invoked in BaseFile::AnnotateWithSourceInformation,
where QuarantineFile() is now called.

Since asynchronous quarantine should only be done when
kPreventDownloadsWithSamePath is true, leave the non-service path
in for now.

Bug: 870998
Change-Id: I0f668e18b882893d1a8a736a2afe9912dc320b1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625944Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Alexander Woolf <alewoolf@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#670298}

Bug: 972125
Change-Id: Ieba22ac128dbb4c6e24e1ff417a84c5e4f775605
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660966Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670297}

https://skia.googlesource.com/skia.git/+log/f91aeb259e09..7694b90eb000


git log f91aeb259e09..7694b90eb000 --date=short --no-merges --format='%ad %ae %s'
2019-06-18 bsalomon@google.com Revert "Consolidate quad optimizations into single internal function."
2019-06-18 brianosman@google.com Cast to fix Linux ANGLE builds
2019-06-18 jlavrova@google.com Refactor font resolution out of font iterator;
2019-06-18 robertphillips@google.com Add Ganesh support for RGBA_16161616 and RG_half (take 2)
2019-06-18 mtklein@google.com extract Assembler so it can be tested
2019-06-18 brianosman@google.com Revert "Interpreter: Support striped inputs for less overhead"
2019-06-18 borenet@google.com [infra] Add UpdateGoDeps bot
2019-06-18 brianosman@google.com Connect ANGLE's trace events to Skia's tracing
2019-06-18 michaelludwig@google.com Consolidate quad optimizations into single internal function.
2019-06-18 jvanverth@google.com Minimize renderstate changes and vertex buffer rebinding.
2019-06-18 egdaniel@google.com Reland "Store GrSwizzle on proxies for texturing and swizzling."
2019-06-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-06-18 mtklein@google.com start excising xbyak
2019-06-18 borenet@google.com Remove experimental Go bindings
2019-06-18 benjaminwagner@google.com Add Firestore emulator to gcloud_linux asset.
2019-06-18 rmistry@google.com [skottie-wasm-perf] Add recipe and CPU bot
2019-06-18 bungeman@google.com Remove SK_IGNORE_MAC_BLENDING_MATCH_FIX.
2019-06-18 brianosman@google.com Interpreter: Support striped inputs for less overhead
2019-06-18 brianosman@google.com Revert "Revert "Shuffle SkSL sources around so compiler and bytecode can be used w/o GPU""
2019-06-18 borenet@google.com [infra] Fix Cloud Build


Created with:
  gclient setdep -r src/third_party/skia@7694b90eb000

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bsalomon@google.com

Change-Id: I7e9f1423aa159c1b5eaf85c11dc2bb05c635ba2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665889Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#670296}

1. AutofillPruneSuggestions
2. AutofillUseMobileLableDisambiguation

Bug: 963157, 970351
Change-Id: I5d0870b39d5dd57ade56650a922390b0be7cb21c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660417Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#670295}

Move SetQuietMode to AssistantNotificationController interface.
It's only used by assistant code.

Bug: 958191
Change-Id: I02e2da517e760d0c2e0cff9d2f0cc6c78f34d1e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660644
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670294}

We have occasional compile failure due to backend error.
https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.try/linux-rel?limit=200
Let me switch back to use old goma backend until we fixed the error.

Bug: b/135145905, 976362
Change-Id: I6da5b5a94fdd9dcb2b52cf1a21aa7da9a3f82ca2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665774
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670293}

https://chromium.googlesource.com/angle/angle.git/+log/81b6acfb8685..32d718f3e81e


git log 81b6acfb8685..32d718f3e81e --date=short --no-merges --format='%ad %ae %s'
2019-06-18 jonahr@google.com NVIDIA Shield workaround for IsNVIDIA() detection
2019-06-18 sunnyps@chromium.org Add support for D3D11 texture backed EGLImages
2019-06-18 jonahr@google.com Fix Platform.h integration with ANGLE
2019-06-18 jmadill@chromium.org Remove gl::Context parameter from Observer functions.


Created with:
  gclient setdep -r src/third_party/angle@32d718f3e81e

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:939655
TBR=jonahr@google.com

Change-Id: Ibfc216a8b5ea8c3a0b6ba5b8611c80ce0f7c71dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665709Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#670292}

Also Keyboard.ShortcutViewer.SearchUpdateTimeVisual.

Keyboard shortcut viewer has been in production for many milestones
and its performance is adequate.

Bug: 975901
Change-Id: I63c01eb253e7424ecd5bd85e17752d96c8d29b2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665297Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670291}

With this change, users can change their variation permanent country via
chrome://translate-internal and the country stored will not changed on
chrome updated.

Bug: 793889
Change-Id: Ifdef9c911a83c2435474bdd775d3a018b99ace57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573720
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670290}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/84c5a537..353cbaa9

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6b1212dd1e2bce049599c09045c5a06aaa112541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665204Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#670289}

And also make OverviewController::ToggleOverview() a private function.
All callsites of ToggleOverview() are modified to use StartOverview()
and EndOverview() instead.

Bug: None
Change-Id: Idf11ec78770afab33c4e1298dfee17dbb08b09b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662505Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670288}

md_browser wasn't correctly slugifying escaped characters in header names.
Gitiles shows the literal character (ex. "\_" shows as "_"), but md_browser
previously slugified to "_95_" as an artifact of the python library
encoding escaped chars as "\x02 (ASCII code for escaped char) \x03", where
\x02 & \x03 are "start of text" and "end of text" respectively.

This adds a step to decode decimal codes in-between \x02 & \x03.

Bug: 974025
Test: tools/md_browser/md_browser.py android_build_instructions.md (click "Figuring out target_cpu")
Test: I also tested this by comparing against https://crrev.com/c/1665854
Change-Id: I561be6f0742d11ac5188e5680573ce112b8883fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658676Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670287}

This CL adds TabSelectionEditorLayout that is a SelectableListLayout,
and its visibility is controlled by TabSelectionEditorLayoutBinder, as
well as the click listeners for the toolbar buttons.

Change-Id: Ib3888cdf3eed9fa66c815c5196fbd460476ef224
Bug: 972299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649122Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670286}

Bug: 974660, 976362
Change-Id: Iea8ad0cef870131b1b65df1bfc4b3b35a081baa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665895
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670285}

Bug: 976384
Change-Id: Ibb18e97bd5e799a513922b81698eb5cea98b5bfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665912
Commit-Queue: Jon Mann <jonmann@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670284}

This reverts commit 0d06e98a.

Reason for revert: Causes a crash:

VUID_Undefined(ERROR / SPEC): msgNum: 0 - Instance Extension VK_KHR_xlib_surface is not supported by this layer.  Using this extension may adversely affect validation results and/or produce undefined behavior.
    Objects: 1
        [0] 0, type: 0, name: NULL
Received signal 11 SEGV_MAPERR 000000000040

Original change's description:
> Enable VK_LAYER_LUNARG_standard_validation with VK_KHR_xlib_surface
> 
> Tested it with vulkan-validationlayers-1.0.106
> 
> Bug: 843346
> Change-Id: I180d690421ede3251721452334e59b35c28f0d49
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662534
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Auto-Submit: Peng Huang <penghuang@chromium.org>
> Reviewed-by: Jonathan Backer <backer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#669729}

TBR=penghuang@chromium.org,backer@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 843346
Change-Id: I5a164b461039cdf1805594fcff697a9e99e60714
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665430Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670283}

Bug: 974949
Change-Id: I9fac4c21281102dc4294c111763c917ecef4b340
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665350Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#670282}

FidoDeviceAuthenticator::BioEnrollFingerprint() potentially derefences a
base::nullopt if an authenticator unexpectedly omits a required
templateId in its response. It also users a static variable to
temporarily store the templateId of on ongoing enrollment, which only
works as long as only a single FidoDeviceAuthenticator is ever
instantiated.

Bug: 974046
Change-Id: I6ebba028ba3f214fb2ee47c0dc53b2d91fc79676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663035
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670281}

https://chromium.googlesource.com/catapult.git/+log/baea8814b88e..26377fc5ea90


git log baea8814b88e..26377fc5ea90 --date=short --no-merges --format='%ad %ae %s'
2019-06-18 jbudorick@chromium.org devil: shorten android src link.
2019-06-18 khokhlov@google.com Fix artifact creation on Windows
2019-06-18 bsheedy@chromium.org [Devil] Restore root after system app modification
2019-06-18 perezju@chromium.org [Telemetry] Remove unused bits of PageTestResults


Created with:
  gclient setdep -r src/third_party/catapult@26377fc5ea90

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:976274,chromium:972221,chromium:973837
TBR=eyaich@google.com

Change-Id: I4d56fafc011c5b8835eed9b0aa9231572eaa652c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665291Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#670280}

If a process has already gone away when you call TerminateProcess then
TerminateProcess will fail with error code 5. This seems unintuitive to
me and the resulting error spew when running tests can be misleading.

This change avoids printing the message when GetLastError() is
ERROR_ACCESS_DENIED to avoids the spuriuos debug spew.

This was noticed while investigating crbug.com/861730

Change-Id: I869073bd3c6b0c00ceeee7d7f1139e3091e3a1cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662974
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670279}

AssistantWebView's child view for embedded WebContents was not being
sized during initialization due to a failed initialization condition
check.

Bug: b:135215741
Change-Id: I470daf60466baa3435c431f6256468c0cbc641ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665776Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#670278}

Also rename JankRegion to LayoutShiftRegion.

(There are still many references to "jank", which will be cleaned up in
follow-up patches.)

Bug: 963474
Change-Id: I33683bbd95dfea135f6e30215ddd09959913e8da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644230
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670277}

Bug: 973877
Change-Id: I546ad0782c578607ae8af99524804d07fc35577b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660786
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670276}

This reverts commit 5139af43.

Reason for revert:

Reverting this change in favor of blacklisting CFI cast check in the blacklist
file. See crrev.com/c/1665554

Original change's description:
> [gRPC] Suppress CFI cast checks
>
> ChromeOS builders build Chrome with CFI cast check enabled, so using
> reinterpret_cast on invalid/uninitialized pointer will crash Chrome.
> This is what happened in grpc_core::InlinedVector, which tries to use
> reinterpret_cast before initializing the storage.
>
> While the proper fix should be calling the placement-new operator
> directly on the raw (void*) pointer, the easiest and safest fix for M76
> is just to disable CFI cast checks when building the gRPC library.
>
> I've verified that the crash was reproducible with
> ftl_signaling_strategy if I add `is_cfi=true` (and other required
> arguments) to GN args, and the crash goes away once I've added these
> compiler flag.
>
> Bug: 972108
> Change-Id: Idf874a028af002fafe3a4905d70a3bca71777e42
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660194
> Commit-Queue: Joe Downing <joedow@chromium.org>
> Reviewed-by: Joe Downing <joedow@chromium.org>
> Auto-Submit: Yuwei Huang <yuweih@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#669203}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 972108
Change-Id: I9146543b71ab139e4a91bd9add77229c1db9a5c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665775Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Auto-Submit: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670275}

This patch fixes computing max-content for tabulation
characters when `break-word` is set.

In that case, multiple tabulation characters are broken into
multiple NGInlineItemResult. This patch supports such cases
when computing max-content.

Bug: 972000
Change-Id: I1da0cda6e61f0bc122f9d942a7a2d91d82f83a72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663900Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670274}

Add flow to handle case when card is successfully saved to server.
Details are not implemented yet, and this CL only changes the logic to
save card bubble controller.

Bug: 964127
Change-Id: I678e1a30cec878d6701c984434ccdc1251f91923
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650717Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670273}

The trigger is notified when a popup is blocked. If the frame causing the blocked popup is a google ad frame we send a RIND report.

For more details see: go/extending-chrind-q2-2019-1

Bug: 965587
Change-Id: I8f079bd3b254a3664abd4855d9c9cb393ce2ec4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628173
Commit-Queue: Archana Simha <archanasimha@google.com>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670272}