- 29 Aug, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/460ee9c8dc88..3479e999694c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I630ea03d108485788b45343a012cd6ed43737e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383782Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802935}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I100649cc857aebcc46c202ea72c4bc0293147af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382811Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802934}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/metrics/process_memory_metrics_emitter.cc This CL was uploaded by git cl split. R=chrisha@chromium.org Bug: 1110266 Change-Id: I92ac28914d3263dd50cf5a845f509e1cfade9479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371253Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#802933}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598712808-09df931579252487b94010e4a09d388ad40a3578.profdata to chrome-win32-master-1598716151-c6631225049a2220e70028e087f4c38c43ce234c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic5623379710754e62a0e93e9b23e4c746c1d038c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383629Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802932}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5692b2cbc2f8..460ee9c8dc88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ida32cbf2e00700b00c1f63256adcbb2ba6d1467e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383752Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802931}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I9515efae60d93ede65aa3b8de11f6ee05828e109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382812Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802930}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I35684eca30719b00c226ab5d27d1d909649802b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382831Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802929}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 714f7bad. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I95a837b3becbcc2a4fbd9a990b98dd25d0adac9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382231Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802928}
-
Rouslan Solomakhin authored
Before this patch, calling PaymentRequest.canMakePayment() after its value has been calculated would return "false", ignoring the fact that secure payment confirmation is being requested, for which canMakePayment() should return "true" if an authenticator device is available, even if there are no credentials on file. This patch changes PaymentRequestState::CanMakePayment() to use GetCanMakePaymentValue() after all apps have finished queried. This method takes into account whether secure payment confirmation is being requested and an authenticator is available. After this patch, PaymentRequestState.canMakePayment() always returns "true" for secure payment confirmation when an authenticator is available (if the secure payment confirmation feature is enabled). Bug: 1123148 Change-Id: I4bb4895cbc1c7db1d84a19c9d753d5766769ad84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383693Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802927}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc This CL was uploaded by git cl split. R=chrisha@chromium.org Bug: 1110266 Change-Id: Iddf90171933636e81053e57d94696f57bf8af85b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371254Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#802926}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/776538aab025..f71283c987e8 2020-08-29 jmadill@chromium.org Fix EGLContextCompatibilityTest. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: Ie7816aba67d297ca74d0e11b66453aec2e82e315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383750Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802925}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5d3314c53ce5..8702b8f4444f 2020-08-29 reed@google.com don't return unknown from computing-convexity, as documented If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ia53c6408e8db59c0a9ef725c376e7b9f927e228d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383627Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802924}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.59-1598262024-benchmark-86.0.4240.12-r1 to 86-4183.59-1598262024-benchmark-86.0.4240.13-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ifbb83a8cbae9ec46723d98517bc57d28ae3f945f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383754Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802923}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I6ac65bab7ec72870f4a6a2396b9edefbb46c86e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383691Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#802922}
-
Lijin Shen authored
When "system settings" method is used under P-, the app crashes because the system does not have "change default" settings. This CL skips when the system does not have such settings. Bug: 1122907 Change-Id: I6133e83ee15074cd48bd4db6c098005428cb088b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382895 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#802921}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.74-1598267562-benchmark-86.0.4240.12-r1 to 86-4183.74-1598267562-benchmark-86.0.4240.13-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I64a0379039fd1951a6d2c32fbbb65894aa921180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383751Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802920}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598692662-51dd0188d114bd684377b7bf15f0aec233b129c0.profdata to chrome-win32-master-1598712808-09df931579252487b94010e4a09d388ad40a3578.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6398b1e44c211b57824290b8a8f53b0363b14844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383622Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802919}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b4efc051da9d..776538aab025 2020-08-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 11fcbbf5d7cc to 3b3f93c206dc (13 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: Ifcad5d30adada1bf4f79020fe49d6e6f6c98d3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383621Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802918}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008290800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/R04rsBEeH2QD52I6NpNlr89kXmUPZPdVo_ElSJ4y9_sC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I4fa75085c1f333fca55a25f1c7487a43dfe035e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383620Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802917}
-
Gang Wu authored
This is a reland of a1ee3eea Original change's description: > TabModel type should same as Tab type when switching tab > > We were use getCurrentModel() to switch tab, and this will be a problem > in multi window mode. We should choose the model(incognito or not) same > as the tab which we will switch to. > > Bug: 1121102 > Change-Id: Ie9742fb4a1b38f921c01d7f8ffd47a813b1b5a14 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379093 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Gang Wu <gangwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802295} Bug: 1121102 Change-Id: I5d943085b61f7d8a74bec78c1f9400404ed03de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382211 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#802916}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ica071e09a1fa0caa1c9b4766bba79d6393c9d600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383619Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802915}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ib7b30b7935870db480dbf62a6cc83de03bfc9c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802914}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Nightly/media_app_202008290800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/VabimoNbXIh6u61XiMd1LCTqdNfFPCZq40c1l-IF2fAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I9cc32fa84bfe909fa2b9755e4f920c917e959e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383618Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802913}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb9ebe49ad3b..5692b2cbc2f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I6b1841fc688fd351dbc0df4f20ba849d27aecf7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383617Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802912}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1598613564-d41b98b98dbc5191c7849f32cc1e8367c121c9d0.profdata to chrome-win64-master-1598701830-094fa9b25781b44321eb93f9a4da522936ebbe2a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I89beb40b11b087f7b2a86c237d36b637aed100ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383616Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802911}
-
Aaron Leventhal authored
Bug: None Change-Id: I41c7eed35244427f920f1a38a8b19f4c30dfdad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378530 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#802910}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598689782-79c1a956e58769ff0627fe1929a3fc8c6eba4637.profdata to chrome-win32-master-1598692662-51dd0188d114bd684377b7bf15f0aec233b129c0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I5a53ea8396bf0dbd7071484a0784ad1bf187dde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383613Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802909}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6fd391a016f3..5d3314c53ce5 2020-08-29 mtklein@google.com overhaul blit_row_s32a_opaque() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1088224 Tbr: mtklein@google.com Change-Id: Icc5df01f2d6679dccab7cd3a44b81258db3f4e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383611Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802908}
-
Aaron Leventhal authored
Bug: None Change-Id: I84170deec32ee211fd15a1ee7ac715cd9849bb1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372887 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#802907}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f00f89fca0f4..48b9a3aff08a 2020-08-29 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I816c52062f4a30b304116cf83c60dbeece2b2977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383610Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802906}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598684367-c0af722967a8d21b37257898f8c14103e1ccc303.profdata to chrome-win32-master-1598689782-79c1a956e58769ff0627fe1929a3fc8c6eba4637.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iab18071bbd9b752c35f66dc41e71c4ffb2e0c7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383493Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802905}
-
Owen Min authored
There is no request dialog and request pending dialog for theme request. And the request is confirmed automatically. Enable these dialogs for theme request for better consistency as admin is able to block theme like an extension Bug: 1077349 Change-Id: I96fe2bafc59f97851d089c646294b33098f18492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175740Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802904}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ib8f4ae6bb906363dbbab8ed1157a78b3e6a0e4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383015Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802903}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I3f3dab82cb743c4033bb3c562f9a7767341a7e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382113Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802902}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I3065aa58a68b1f942a87e315906e0f0d2750c2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382318Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802901}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fe6f6198. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I6c7ffbe8c34e191c0d8c8daed270b1d47ead9f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382333Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802900}
-
K. Moon authored
Makes chrome_pdf::UrlLoader abstract, extracting a new PepperUrlLoader implementation from the old UrlLoader. A number of call sites don't need to create a real UrlLoader. These can just use nullptr, as it turns out they never call any methods on the UrlLoader. Bug: 1099022 Change-Id: Ic86fa5a9ccf8f2128f41fb3023c5a07dd682c3bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381064 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#802899}
-
Rakina Zata Amni authored
Previously we wanted to do both cross-site process reuse and same-site process reuse for BFCache, but now we want to enable process-reuse on same-site navigations only for BFCache experiment (at least for the initial experiment). This CL adds a case that handles BFCache process reuse separately from ProactivelySwapBrowsingInstance, to ensure we will only do process-reuse on same-site navigations if BFCache is enabled and ProactivelySwapBrowsingInstance is not explicitly enabled (which is what we will do on the experiment). Also consolidates all three process-reuse cases into a more readable flow. Bug: 1122974 Change-Id: Iec6eb683293b9b384c74da238f3161ab149c0845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381223 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802898}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598658096-a64278c47873df00bb292e7f5bde23944317e855.profdata to chrome-win32-master-1598684367-c0af722967a8d21b37257898f8c14103e1ccc303.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I7b5d5f69edb89aa5f85a1a935a67693acf3c9d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383491Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802897}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4720732dc405..bb9ebe49ad3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I7d71e49a8222923527c5c8c5257de50e13062aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383490Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802896}
-