GitLab

Bug: 832367
Change-Id: Ibf6b3a7291f137e64e47ec382fcf0cfa7230243f
Reviewed-on: https://chromium-review.googlesource.com/1015161Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#551750}

Update ExtensionManagementApiTest to manifest v2 and remove the
allowance for manifest v1 extensions.

Bug: 816679

Change-Id: I0448ee64cbde9ed8431c30090d1f109e6d655fce
Reviewed-on: https://chromium-review.googlesource.com/1014711Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551749}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/84ba9179592f..4e29b62239da

$ git log 84ba91795..4e29b6223 --date=short --no-merges --format='%ad %ae %s'
2018-02-05 yhong cros_sdk: Resolve the tarball URL only if --download is specified.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:795449 of sorts


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Id1c7addda62e3e83c01222aa4d29ac679fffa851
Reviewed-on: https://chromium-review.googlesource.com/1017222Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551748}

Bug: 820422
Change-Id: I9d621e09536828a40b09cb369380ac57f4e6f023
Reviewed-on: https://chromium-review.googlesource.com/1016667Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551747}

CodeCacheAfterExecute feature was added to setup a finch trial
for the new v8 code caching mechanism. Now, the feature is
enabled by default and hence removing this feature.

Bug: 783124
Change-Id: I3e59c9a17b72a4201d8b74dc230988dfc7cbf96d
Reviewed-on: https://chromium-review.googlesource.com/1012115Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551746}

Bug: 831404
Change-Id: I1b0813135c39cfd912e34e229fe98a97d8b89df4
Reviewed-on: https://chromium-review.googlesource.com/1010417Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Daniel Park <danielpark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551745}

This removes non-md resources due MD is forced now.

Test: Manually
Bug: 834002
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic2af89f20efc69f971c6b5d34ffe9759d4818f90
Reviewed-on: https://chromium-review.googlesource.com/1015659Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#551744}

//ios/web_view needs this API for showing a list of cards and updating
and deleting cards.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I429e9f6dd544ea80cb1b443891de6b8f8d777ed0
Reviewed-on: https://chromium-review.googlesource.com/1013300
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551743}

This histogram is logged when Download is complete with
true if Install Drive promo was presented.

Bug=832329

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I82e8cfe84c2cc1b10cd2a522d1dc0a02a7c852b9
Reviewed-on: https://chromium-review.googlesource.com/1011415Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551742}

|is_success| parameter in FidoHidDevice::MessageReceived() can be
represented by nullptr |message| parameter.

Bug: 828088
Change-Id: Ia13439acc98f43af1741308063ac7c2ab1b62af9
Reviewed-on: https://chromium-review.googlesource.com/1014655Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551741}

Before this patch some calls from compositor may not realize the PLSA
disposed. In this patch, we clear the pointer of scrollable area in
paint layer and graphics layer and check it before calls.

Bug: 813520
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia2df7d114abd1a344d24d534055fca051ad965fd
Reviewed-on: https://chromium-review.googlesource.com/1000932
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551740}

R=enne@chromium.org

Bug: 832726
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3e21bd4a54b82fcf7f9f07ae36cdfdb65034fe39
Reviewed-on: https://chromium-review.googlesource.com/1015820Reviewed-by: enne <enne@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551739}

ContentVerifierTest was setting up override but never reseting it
causing other tests that loaded extension to access invalid memory
of stack allocated registry override.

This is regression after crrev.com/c/957645 that causes crash
or timeout in extensions_unittests.

Bug: 809088, 832801
Change-Id: I45d8ee2e4e450e8d5f619e502e7a6e96c8879ef0
Reviewed-on: https://chromium-review.googlesource.com/1013982
Commit-Queue: Marek Haranczyk <mharanczyk@opera.com>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551738}

This change attempts to address some Mac CWInterface crashes.  Although
CWInterface's interfaceWithName was deprecated in 10.10, these crashes
don't appear to be a result of that (especially since there is one other
use of the API in Chromium that isn't experiencing any crashes).  This
change adds a check on the interface name before calling
interfaceWithName to ensure it is only called on Wifi interfaces.

Bug: 827944
Change-Id: I2775bc7c3b26a015c1893b3ba56a13f66f3d5ead
Reviewed-on: https://chromium-review.googlesource.com/1016068Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551737}

This is placed in big letters at the top of the file to have a chance
of being noticed by someone when their editor opens before moving down
to find the entry they want to change.

Change-Id: I204d14138dc508a640ced8c17008c8ae95c1bdb7
Reviewed-on: https://chromium-review.googlesource.com/1015787Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551736}

IdentityManager is the new API that replaces the (semi-)deprecated
SigninManager.

Bug: 825190, 798412
Change-Id: I4bb24b0ebdf0d1d964ce4ad16aa986cc56af2fa4
Reviewed-on: https://chromium-review.googlesource.com/1016760Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551735}

Mostly removing unsued includes. Also deleting the unused
sync_db_util.h/cc.

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idebea0d8ed82c1ddfb4707ed5517ea6e9125576f
Reviewed-on: https://chromium-review.googlesource.com/1014132Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551734}

BUG=722573
R=scottmg@chromium.org

Change-Id: I55d17ae0e4de6ccd5a7a674a52a9948bdafc915b
Reviewed-on: https://chromium-review.googlesource.com/1016283Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551733}

BUG=chromium:794372
R=thakis@chromium.org
NOTRY=True

Change-Id: Iaef5d1b0e4fcb155d90de714187e16496fdfdee1
Reviewed-on: https://chromium-review.googlesource.com/1015847
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551732}

Stop opening a CCT for out-of-scope navigations from WebappActivities.

Bug: 830946, 771418
Change-Id: Ied9c33518488f0bab38366bf2e8b8532c71e3819
Reviewed-on: https://chromium-review.googlesource.com/1003552
Commit-Queue: Ran Ji <ranj@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551731}

Port the GDPR information message for invitations to the new UI.

Also fix a styling issue with buttons (were appearing vertically
stacked).

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9c36d15ed37e82b3e3038d9dd180b420fe8ecc04
Reviewed-on: https://chromium-review.googlesource.com/1012516Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551730}

This change will keep this manager's lifetime in line with its partners,
SyncedPrintersManager & CupsPrintJobManager. Also keeps only one intance
around per profile, becoming the source of truth for users' current view
of available configured printers

Dependent CL with API changes

BUG=chromium:829492
TEST=manually confirmed correct shutdown behavior

Change-Id: Ief45ebbf6610fef0d5b4c294a8c6cc923899ddb3
Reviewed-on: https://chromium-review.googlesource.com/998531Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551729}

It's failing on the tree.  It most likely broke due to
https://chromium-review.googlesource.com/1012455.  Will revert the
CL if there are any other failures.

TBR=jam@chromium.org
NOTREECHECKS=true
NOTRY=TRUE

Bug: 832600
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I35da207aa89350bafcc36395a62e436cbbb6e5a4
Reviewed-on: https://chromium-review.googlesource.com/1016707
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551728}

This replaces the usage of private web API in the test.

Bug=622485

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I848dad4fddf60bc7a5e83f5008b151f143b1f7a7
Reviewed-on: https://chromium-review.googlesource.com/1014417
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551727}

Bug: 807742
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4b51cdc093f914ca05801b301e55be124d52c3a1
Reviewed-on: https://chromium-review.googlesource.com/1015649Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551726}

This reverts commit 94fac28e.

Reason for revert: Broke compile: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5265

Original change's description:
> app_launcher: Fix OEM folder is not created in new user flow.
> 
> This fixes the issue when OEM folder is created empty after new user
> flow and OEM items are placed to non-named folder. This also fixes
> various crashes when trying to manipulate these items.
> 
> Bug: 828209
> Test: Manually
> Change-Id: Ib07f0ab1d301d1e38a6ad91fca10396e9f58ccf7
> Reviewed-on: https://chromium-review.googlesource.com/1016024
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Yury Khmel <khmel@google.com>
> Cr-Commit-Position: refs/heads/master@{#551716}

TBR=xiyuan@chromium.org,khmel@google.com

Change-Id: Iaa41f7f11f9992b9d5037b4ae5dd2289aa99b4cb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 828209
Reviewed-on: https://chromium-review.googlesource.com/1017261Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551725}

Build targets for traffic annotation auditor's tests are expanded to
cover all required generated files.
The test result is corrected.

Bug: 690323
Change-Id: Iefb2e61fda12e34aa85879da73f1f174baa56c38
TBR: dpranke@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1016901Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551724}

Bug: chromium:819629
Change-Id: Ia004db9e52cb147a1948de604d840387dff3379f
Reviewed-on: https://chromium-review.googlesource.com/1017200Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551723}

Adds the option to apply a stashed change before syncing when using the
VR bisect script. This is mostly to allow an automated bisect (as
opposed to using --manual-mode) when there is a bad DEPS entry in
the revision range that requires a patch to be applied before syncing.

Change-Id: Ibc8b16bbb44a03e9c2a56f8011b0b1d57d6bbd88
Reviewed-on: https://chromium-review.googlesource.com/1016100
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551722}

This reverts commit ad6f7598.

Reason for revert: Reverting the revert because I don't think that the original CL is the culprit for net_unittests failures on Mac as these failures already appeared before the CL landed:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/31390

Original change's description:
> Revert "Add cookie security metrics"
> 
> This reverts commit 23e0b326.
> 
> Reason for revert: Suspected cause of net_unittests failures on Mac-10.10
> 
> Original change's description:
> > Add cookie security metrics
> > 
> > Log the degree of protection against cookie theft, split by 1st/3rd
> > party.
> > 
> > Includes a bit of TransportSecurityState refactoring (no functional
> > change) to provide easy access to HSTS lifetime.
> > 
> > Bug: 749059
> > Change-Id: Ib9ab7cff6a7fb4c65e84d7085e70ef13d5c00ba9
> > Reviewed-on: https://chromium-review.googlesource.com/978142
> > Reviewed-by: Nick Harper <nharper@chromium.org>
> > Reviewed-by: Ilya Sherman <isherman@chromium.org>
> > Reviewed-by: Mike West <mkwst@chromium.org>
> > Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#551644}
> 
> TBR=isherman@chromium.org,tnagel@chromium.org,nharper@chromium.org,mkwst@chromium.org
> 
> Change-Id: I9e7411956eb5d748b547edcf6aec7f40dde88d8d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 749059
> Reviewed-on: https://chromium-review.googlesource.com/1017141
> Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
> Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551698}

TBR=mohsen@chromium.org,isherman@chromium.org,tnagel@chromium.org,nharper@chromium.org,mkwst@chromium.org

Change-Id: Ib3260311c6455b5892619e83352da4780ac466a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 749059
Reviewed-on: https://chromium-review.googlesource.com/1016649Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551721}

Adds a new content type on the DRP resource type provider to accomplish
this.

Bug: 726058
Change-Id: I9a5c3934c293279894a396e8d7e879e8ffe60ec5
Reviewed-on: https://chromium-review.googlesource.com/1015766Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551720}

The previous implementation was finding the form and field of the
select element that was modified for each option added or removed.

Since this can happen several times in a row it was not efficient.

This search now happens after all the add/remove have been debounced.

Bug: 832077
Change-Id: Icf28910459163a4d92eca96e2e4adad65a147cf7
Reviewed-on: https://chromium-review.googlesource.com/1015322
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551719}

This uses the new TextureLayer APIs to register SharedBitmapIds instead
of using ClientSharedBitmapManager, in order to get the registration in
the same IPC channel that the compositor uses for submitting frames
that include the ImageLayerBridge's shared memory bitmaps.

This CL also fixes a bug where bitmap data wasn't properly copied into
shared memory. All rows from the source were copied into the same row of
the destination. This was causing the canvas to appear (almost?) all
black when using software compositing. I've tested the fix with
https://codepen.io/anon/pen/qoeQEE which looks the same using GPU and
software compositing.

Bug: 730660, 831303
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibf778947a68c5948596f5dd516606937a8c5c442
Reviewed-on: https://chromium-review.googlesource.com/1014380Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551718}

BUG=834318

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Ib1023da9cd09a3291725aa539fdfa044356a7e81
Reviewed-on: https://chromium-review.googlesource.com/1016691Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551717}

This fixes the issue when OEM folder is created empty after new user
flow and OEM items are placed to non-named folder. This also fixes
various crashes when trying to manipulate these items.

Bug: 828209
Test: Manually
Change-Id: Ib07f0ab1d301d1e38a6ad91fca10396e9f58ccf7
Reviewed-on: https://chromium-review.googlesource.com/1016024Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#551716}

This was only required because it is not available on Windows XP, which is no
longer supported.

R=forshaw@chromium.org

Bug: 821290
Change-Id: Ie5fba51391b25f7a1a01549f67a054c00aefa50f
Reviewed-on: https://chromium-review.googlesource.com/1012119Reviewed-by: James Forshaw <forshaw@chromium.org>
Commit-Queue: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551715}

The omnibox is a text element that updates according to user input.
User input happens after element layout, and since the text texture
heavily relies on layout, "dirtying" the text texture really means
laying it out again.

Prior to recent cleanup and refactoring, we mistakenly got away with
this - a text element could resize itself after the layout stage and
appear incorrectly.  Post-cleanup, the re-layout can't happen, but a new
bug was introduced where a post-layout phase could dirty a texture, and
the texture update phase would redraw and "clean" the texture without
doing layout.  The broken layout would then persist indefinitely.

To address the problem, elements may mark themselves as requiring
measurement for texture draw.  These elements will not be redrawn unless
their measurement step has happened.

There was a measured() DCHECK mechanism previously, that was taken out
because most textures no longer measure themselves.  This change
reintroduces that check in it's new form.

BUG=834297

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Ib17315a5c053d487edfbf7b858c2e9541924c3a6
Reviewed-on: https://chromium-review.googlesource.com/1016064Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551714}

This CL also slays some dead methods (*Setting*Old) for old behavior.

This CL lands server change 193221621 by diannahu.

BUG=488484

Change-Id: I420b10a15cef120176cce8842616e47154afc43e
Reviewed-on: https://chromium-review.googlesource.com/1016702
Commit-Queue: Dianna Hu <diannahu@chromium.org>
Reviewed-by: Dianna Hu <diannahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551713}

It already has Brotli enabled when using the network service, so this
makes behavior the same whether the network service is enabled or not.
Enabling makes more sense than disabling, since this matches Chrome's
behavior, and it's a web standard.

Bug: 825687
Change-Id: Ifa45aa704df5e3948e27cf2f1b23f8f06764425f
Reviewed-on: https://chromium-review.googlesource.com/1015555
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551712}

This is really what we ought to be doing to avoid ODR violations
caused by linking the prebuilt .a into multiple components, but
I previously couldn't see a way to link the .a into the component
.so with --whole-archive. However, it turns out that it's possible
using ldflags. This is a little hackish but it's probably better than
dealing with ODR violations.

Bug: 749784
Change-Id: I1ae275d57f36bc4a2c816d7f0ee8fdc4c000cf63
Reviewed-on: https://chromium-review.googlesource.com/1016092Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551711}