- 16 Aug, 2018 40 commits
-
-
Finnur Thorarinsson authored
Bug: 860467 Change-Id: If72184b571a5d550e321bf8568523a16c9fb35f0 Reviewed-on: https://chromium-review.googlesource.com/1177603 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#583687}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5314945fa47a..922ba81b497b git log 5314945fa47a..922ba81b497b --date=short --no-merges --format='%ad %ae %s' 2018-08-16 simonhatch@chromium.org Enable LUCI presubmit 2018-08-16 simonhatch@chromium.org Dashboard - Flaky alerts test setting global 2018-08-16 nastasoiuf@google.com Functional prototype for dotPlot and linePlot Created with: gclient setdep -r src/third_party/catapult@922ba81b497b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:825436,chromium:874800,chromium:866423 TBR=sullivan@chromium.org Change-Id: Id94d5cfa2c8e1955d0b39cec9afcb63365f89650 Reviewed-on: https://chromium-review.googlesource.com/1177585Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583686}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874929 Change-Id: Ia0cabec9bdd4bacaf4d8acdb8a69cbd50dc0a446 Reviewed-on: https://chromium-review.googlesource.com/1178103Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583685}
-
Bill Budge authored
- RawResource is used for several non-text resources, as well as document resources. The cached metadata handling has been set up for a document's inline scripts. This makes it difficult to cache metadata properly for other RawResources, such as WebAssembly modules. This change only creates SourceKeyedMetadataHandler for RawResources whose type is kMainResource. - Renames RawResource::CacheHandler to InlineScriptCacheHandler so it doesn't hide the Resource::CacheHandler method, and so we can later add other kinds of metadata handlers. Bug: chromium:719172 Change-Id: I53f361a0df48dc9d73780971e3408dfff08de518 Reviewed-on: https://chromium-review.googlesource.com/1173496Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#583684}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/767fddfcce61..cbd83bbd77d1 git log 767fddfcce61..cbd83bbd77d1 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 mtklein@google.com don't adapt gray colors to 565 Created with: gclient setdep -r src/third_party/skia@cbd83bbd77d1 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I60eb62a1fd42049248d3da549efa211368927357 Reviewed-on: https://chromium-review.googlesource.com/1177584Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583683}
-
Tibor Goldschwendt authored
This is a reland of bc740b07 with a fix to include the loadable modules into the final APK. Original change's description: > [build:android] Add a module for AR in Monochrome > > Add an AR Dynamic Feature Module (DFM) and bundle it into the public > Monochrome bundle. > > + Add loadable modules to the build config so that their paths can be > passed to the module create target. > > + Add option to bundle targets to specify the Android SDK target for > synchronized proguarding. This was necessary because the Monochrome > base module uses a different Android SDK than the AR module, which > made proguard sad. Also pass the Android SDK Jar as a dedicated > classpath Jar to proguard and don't mix it with the other classpath > Jars. > > Bug: 863063 > Change-Id: I024d05dd99136c069e510995657ac7236f6b6e5e > Reviewed-on: https://chromium-review.googlesource.com/1165533 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582765} TBR=tedchoc@chromium.org Bug: 863063, 873986 Change-Id: I4a72667027ab283b43685197c980b46e90553df8 Reviewed-on: https://chromium-review.googlesource.com/1174772 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#583682}
-
Cole Winstanley authored
Added a class to parse out HTTP and WebSocket DevTools entries from ChromeDriver log files. Bug: chromedriver:2501 Change-Id: I0a3173b295b802c119c90c416fe1e77d7e39cdab Reviewed-on: https://chromium-review.googlesource.com/1166036Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Cole Winstanley <cwinstanley@google.com> Cr-Commit-Position: refs/heads/master@{#583681}
-
Elly Fong-Jones authored
These use focus rings even on platforms that normally use the ink drop effect to indicate focus. Bug: 874750 Change-Id: I1a531126b348b8d910998778caa5abd40e87a898 Reviewed-on: https://chromium-review.googlesource.com/1177681 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#583680}
-
Daniel Vogelheim authored
The previous implementation used both a --feature-enabled and a --runtime-feature-enabled switch, initializing the latter based on the former, presumably because it had components in both browser and Blink. That's redundant. The current implementation uses the browser switch. All Blink-resident parts of the code act on whether they receive a policy or not (which would be always false if the browser switch isn't set). Bug: 751996 Change-Id: I81f10cc888fd7c29c6c93e727526863216ca6f02 Reviewed-on: https://chromium-review.googlesource.com/1165351Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#583679}
-
sangwoo.ko authored
Replace old API with new API. This CL is a refactor ans has no intended behavior change. Bug: 842194 Change-Id: I700df0bc23f0b52d123e92ff16013153a359b16f Reviewed-on: https://chromium-review.googlesource.com/1176897Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#583678}
-
about://flagsBecca Hughes authored
Add flag for new unified sound settings UI to about://flags. BUG=865548 Change-Id: Ie3a3139d9af32bacfe6992708841272c47f4179c Reviewed-on: https://chromium-review.googlesource.com/1176648Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#583677}
-
Ramin Halavati authored
Settings Reset Prompt preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I84164f5734290d20c2a50ed93139645b91561296 Reviewed-on: https://chromium-review.googlesource.com/1176808 Commit-Queue: Robert Shield <robertshield@chromium.org> Reviewed-by:
Robert Shield <robertshield@chromium.org> Cr-Commit-Position: refs/heads/master@{#583676}
-
Adam Langley authored
Chrome isn't doing Token Binding any longer. Change-Id: I5c9cdfec22ae1075f3943d4c041544311be9c4ad Reviewed-on: https://chromium-review.googlesource.com/1176786Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#583675}
-
Peter E Conn authored
This will display Trusted Web Activities correctly when they are launched when verification hasn't been completed. It also ensures that Trusted Web Activities show the top bar when they are launched to a non-verified origin. Bug: 871266 Change-Id: Ibd245812647a2f1d6b6a9405f14d12f46f6ae6f9 Reviewed-on: https://chromium-review.googlesource.com/1177611Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#583674}
-
Sadrul Habib Chowdhury authored
The PersistentMemoryAllocator in the gpu (and other) process is created asynchronously. If any uma-histogram is reported before that time, then those Histograms are not stored in the shared memory. This has some implications: . If the process crashes (which is common for the gpu process on android), then these metrics are lost. . If the process stays alive, then the metrics are reported periodically, but because it is buffered, it doesn't match up correctly with the other metrics that are reported in the shared memory. The allocator is created in response to a message from the browser, which includes the handle for the shared memory to use for the allocator. The browser waits until the process has been launched and connected. So this happens much later, compared to other messages which are sent from browser over mojo without waiting for the connection to have been established first. Therefore, change this so that the browser immediately shares the shared-memory segment with the gpu process. mojo takes care of waiting for the process-launch etc. BUG=865179, 778749 Change-Id: Iccd3d4422de3e22ead4bc6510afc5ea207bf6b6e Reviewed-on: https://chromium-review.googlesource.com/1174709Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#583673}
-
Annie Sullivan authored
Bug: 874935 Change-Id: Ic5959bd2f22097f6534248d9c1f15323f8ebe57b TBR: nednguyen@google.com NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1177890Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#583672}
-
rbpotter authored
In Polymerized Print Preview, the event target is always print-preview-app, which does not have an ancestor with a scrollbar even if one exists on the page (e.g. in the settings sections). Examine the event path instead of the target and its ancestors to determine if there is a scrollbar that should receive the arrow key events instead of the plugin. Bug: 872251 Change-Id: I034542d04644e1b47fd1961a9b984a48843b2b40 Reviewed-on: https://chromium-review.googlesource.com/1174995 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583671}
-
W. James MacLean authored
There have been no flakes reported on EmulatedTouchPinchGoesToMainFrame since https://chromium-review.googlesource.com/c/chromium/src/+/1172723 went in, so let's try re-enabling some more tests. Bug: 833380 Change-Id: If406a6f5d7b0a88e84cad84e07d1bba547eb1baa Reviewed-on: https://chromium-review.googlesource.com/1177843Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#583670}
-
Arthur Sonzogni authored
Some builds timed out recently: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Marshmallow%2064%20bit%20Tester Bug: 874840 Change-Id: I31aa161ef63488debb8c3fe38f71c096fe132207 Reviewed-on: https://chromium-review.googlesource.com/1177703 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#583669}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874931 Change-Id: I49375c4593122e9a3a1f8c06ffa3969b6fa1ea1c Reviewed-on: https://chromium-review.googlesource.com/1177904Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583668}
-
Siddhartha authored
Change-Id: I1f9f3f47933ef13a0a69f999e7ddd2b021affa16 Reviewed-on: https://chromium-review.googlesource.com/1177197Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#583667}
-
Gauthier Ambard authored
The FindInPage activity should only be shown when the FindInPage action is doing something. This CL adds a BOOL to know if the page can be searched. It is used to display the activity or not. Bug: 871260 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I35dacc9c1adf1410f1c080af672f9abf2b5ec37f Reviewed-on: https://chromium-review.googlesource.com/1174114Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#583666}
-
Paul Jensen authored
This API was entirely unused so it was allowed to be removed from the API previously in crrev.com/571588. This CL cleans up the ICronetEngineBuilder and api.txt references as they're no longer needed. Removing an API isn't normally allowed, so this required temporary modification of the API update checks to rebuild api.txt. Bug: 857693 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I1bffb016f781aeb5116d8507245630dedacbb14b Reviewed-on: https://chromium-review.googlesource.com/1148019Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583665}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874929 Change-Id: Id81d25adc31cf8c34c0fd5c00b1d1fb7a4390000 Reviewed-on: https://chromium-review.googlesource.com/1177885Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583664}
-
Aldo Culquicondor authored
The RenderLoopFactory is responsible of instantiating the delegates that Ui and RenderLoop require. In this CL, we are still instantiating a VrShellGl object, as the split-up has not been completed yet. Also, we make sure that the variables passed to VrGLThread are freed once the RenderLoop has been built. The testapp starts to be prepared to make use of RenderLoop. We simplify the VrTestContext creation (soon to be the RenderLoop) by initializing it once a GL context was set. Bug=767282 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie0f580f77fb109463dc41093919a7c535976e321 Reviewed-on: https://chromium-review.googlesource.com/1175852Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#583663}
-
Gemene Narcis authored
This CL adds six histograms. Three histograms are for HTTP credentials with HSTS enabled and the other three are for HTTP credentials without HSTS enabled, and they are supposed to count the next cases: 1) Number of HTTP credentials for which no HTTPS credential for the same username exists. 2) Number of HTTP credentials for which an equivalent (i.e. same host, username and password) HTTPS credential exists. 3) Number of HTTP credentials for which a conflicting (i.e. same host and username, but different password) HTTPS credential exists. All six are recorded once for the profile on startup with a delay of 60 seconds. Bug: 871140 Change-Id: I231ad82ab1e5d74520cd4c9be4e3cad62645c3d1 Reviewed-on: https://chromium-review.googlesource.com/1163243Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Narcis Gemene <gemene@google.com> Cr-Commit-Position: refs/heads/master@{#583662}
-
sunxd authored
The original name is confusing given that there might be passive event handlers, but the function only returns true if event listener property is Blocking or BlockingAndPassive. This CL renames the function name for better readability. Bug: 841364 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia6e28347e33fd28d3cc4954b307010fe2861dbfb Reviewed-on: https://chromium-review.googlesource.com/1176108Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#583661}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874915 Change-Id: Id0fae86ef2e130185d92ad28383c74036dcd96f3 Reviewed-on: https://chromium-review.googlesource.com/1177881Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583660}
-
Oskar Sundbom authored
By putting these parameters in a struct, future changes to parameters accepted by audio sinks can be made easier, without changing so many dependencies. This CL also adds an optional 'processing_id' parameter to audio sinks. It will be used to associate input and output streams for audio processing, when it's running in the audio service. At this point, the id doesn't get transferred along IPC. That's part of the next CL. For an outline of the project this CL is part of, see: https://docs.google.com/document/d/1u4POff_ts_1LE3WDLA_wDDFnUswdlsuHL5DsiTE0a3U/edit?usp=sharing It's accessible to everyone @chromium.org. Bug: 851959 Tbr: kinuko@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I59a467d83d1516965bbbf06cd4fc49a3198c6cfb Reviewed-on: https://chromium-review.googlesource.com/1163884 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#583659}
-
Annie Sullivan authored
Bug: 874810 Change-Id: I11ff44a55b4f2b14b8ba0a4ab5bb4e0f54cd8ef8 TBR: nednguyen@google.com NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1177882Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#583658}
-
Fredrik Söderquist authored
Too deep recursions can cause stack overflows. Bug: 874759 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie532e28bceee4e7f1c3ab501b80c0e2f14be083a Reviewed-on: https://chromium-review.googlesource.com/1106378Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#583657}
-
W. James MacLean authored
Instead of using GetOuterWebContents, which only return the immediate parent of this WebContents, use GetOutermostWebContents to check against the root of the web-contents tree, which in this case should be the app-view's web-contents. Bug: 873672, 823021 Change-Id: I421a64be495c575d22501328ec732794abc045f4 Reviewed-on: https://chromium-review.googlesource.com/1176342 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#583656}
-
Xida Chen authored
This is a follow up for https://chromium-review.googlesource.com/c/chromium/src/+/1174696 TBR=dtapuska@chromium.org Bug: 851644 Change-Id: I702bd9afc80a82d0b7db02cb8f06a1765c69aaaf Reviewed-on: https://chromium-review.googlesource.com/1177631 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583655}
-
Balazs Engedy authored
Ensure that FidoRequestHandlerBase only instantiates FidoDiscoveries for transports that are in the intersection of those supported by the client, and those allowed by the relying party; where the allowed transports are: (1) For MakeCredential calls: -- {BLE, caBLE, USB, NFC} if `authenticatorAtttachment` == `cross-platform`, -- {Internal} if `authenticatorAtttachment` == `platform`, -- (all) if `authenticatorAtttachment` == `any`. (2) For GetAssertion calls: -- (all) if `allowedCredentials` is undefined or empty, or if it contains an entry with `transports` undefined or empty, -- the union of `transports` lists in all elements of `allowedCredentials`. FidoRequestHandlerBase::Observer::OnTransportAvailabilityEnumerated is also changed to be consistent with this, i.e., the |available_transports| list in TransportAvailabilityInfo will also be this intersection set. Finally, the CL ensure that this method is always called on the observer, even if enumerating transports is finished before the observer is set. Bug: 866601 Change-Id: I00fbd6684fd52851149bdb0dd39800aafda54630 Reviewed-on: https://chromium-review.googlesource.com/1175118 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#583654}
-
Oskar Sundbom authored
It will be used both by content::MediaStreamAudioProcessor and the upcoming media::AudioProcessor. For an outline of the project this CL is part of, see: https://docs.google.com/document/d/1u4POff_ts_1LE3WDLA_wDDFnUswdlsuHL5DsiTE0a3U/edit?usp=sharing It's accessible to everyone @chromium.org. Bug: 851959 Change-Id: I794558e46ab01fd2f367e1df2fababdefb712c4f Reviewed-on: https://chromium-review.googlesource.com/1170841 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#583653}
-
Andrew Grieve authored
Bug: 872904 Change-Id: Ia4ea4ff2de48680abc94bb0ff7c678a430c0cae4 Reviewed-on: https://chromium-review.googlesource.com/1176969 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#583652}
-
Juan Antonio Navarro Perez authored
Tag a selection of system health stories chosen to have a wide coverage for catching regressions, but run in a limited amount of time. The stories chosen caught more than 80% of system health memory mobile regressions in Q2 2018, and a single repeat of the entire set runs in under 20 minutes. Bug: 865959 Change-Id: I397cda35bb71dadf94bb2343c389d00cb8e80ec3 Reviewed-on: https://chromium-review.googlesource.com/1177396Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#583651}
-
Stephen McGruer authored
This reverts commit 2b5dfbb0. Reason for revert: Strong suspect for performance regression (https://pinpoint-dot-chromeperf.appspot.com/job/14a343e2640000), and disagreements on original CL implementation. Reverting until they can be resolved. Bug: 872123, 869387 Original change's description: > Add full saturate-to-infinity behavior to base::TimeDelta > > Before this CL TimeDelta had saturation behavior for translating > from/to other values, but had clamping behavior for its computation. > That is, invariants like the following did not hold: > > TimeDelta::Max() - TimeDelta::FromSeconds(1) == TimeDelta::Max() > > This CL fully implements saturation behavior, such that TimeDelta::Max() > and TimeDelta::Min() are treated as positive and negative infinity > regardless, with all the expected mathematical consequences. > > The one exception is that adding/subtracting a saturated TimeDelta to a > TimeClass is still undefined. This was left undefined because we are not > yet making a statement on whether TimeClass should be considered to have > clamping or saturating behavior for values outsied of range. > > See the linked bug, or also the discussion at > https://groups.google.com/a/chromium.org/forum/#!topic/platform-architecture-dev/S4umX2sOvrk > > Bug: 869387 > Change-Id: I2b3f98c69e7fc5030a6e210d75409d667b73c5ac > Reviewed-on: https://chromium-review.googlesource.com/1155264 > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579969} TBR=gab@chromium.org,smcgruer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869387 Change-Id: I7251e77bd66dc95c9b1aae16fbfc89acd239f19b Reviewed-on: https://chromium-review.googlesource.com/1175470 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#583650}
-
Leszek Swirski authored
Posted blocking ScriptStreamer tasks can end up in a queue, and have their Resource complete loading before the task even starts. When this happens, these tasks will no longer block on network input, but they will still be posted to the blocking task runner, which does not spin up new threads if the running task is not blocked. When there are a lot of small functions posted for streaming, this results in a slightly paradoxical starvation, where the blocking task runner is processing lots of no-longer-blocking tasks all in one thread, as it has no reason to spin up new threads. To avoid this, if a streaming task isn't started before the resource finishes loading, we can cancel this posted task, and instead post a new non-blocking task to the non-blocking thread pool. This frees up the blocking task runner to process only blocking tasks (and thus allows it to spin up new threads for them). Bug: chromium:865098 Bug: chromium:866868 Change-Id: Iceb282582781109ade233366d1009c3be50db3a5 Reviewed-on: https://chromium-review.googlesource.com/1174380 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#583649}
-
Danyao Wang authored
Current expectations assume a buggy behavior of LegacyNavigationManager, which doesn't create a pending item on reload (crbug.com/676129). The test initiates a navigation to the same page to abort the payment request. This navigation is incorrectly classified as renderer-initiated by LegacyNavigationManager, which causes the abort reason for payment request to be incorrectly logged as EVENT_OTHER_ABORTED. WKBasedNavigationManager fixes this bug, so the test should now check EVENT_USER_ABORTED. Bug: 874628 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I74997df64464f196cfcfb34f21b0252d2f2f6e3e Reviewed-on: https://chromium-review.googlesource.com/1176470 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#583648}
-