- 07 Aug, 2020 40 commits
-
-
James Cook authored
Lacros needs to support two notification pathways: * In-process, for the ash-chrome binary * Out-of-process, for the lacros-chrome binary However, both of these pathways have some shared behavior around handling multiple profiles (for the pre-lacros ash case) and transient notifications. This code lives in NotificationPlatformBridgeChromeOs and we want to reuse it. 1. Introduce MessageCenterClientLacros. This is a stub for now. In a follow-up CL it will send notifications over mojo from lacros to ash. 2. Change NotificationPlatformBridgeChromeOs so it supports different |impl_| helpers for ash and lacros. 3. Refactor ChromeAshMessageCenterClient to inherit from NotificationPlatformBridge. This allows NPBChromeOs to have a generic |impl_| for both helpers, and avoids introducing a new abstract interface class. See go/lacros-notifications for overall plan. Bug: 1113889 Test: existing unit_tests and browser_tests Change-Id: I159f410f3d84cc6e9bde0b3757015691f2289419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343217Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#796096}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/56f14dabfe99..a4cba6578f09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4f1d2194a229e438247b3b41d743f94f5a9de9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343489Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796095}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/56f14dabfe99..a4cba6578f09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5609083d3e87d9831848ca5c5911841401c1675c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343595Reviewed-by:
-
Xianzhu Wang authored
Currently PaintInvalidator iterates all block fragments with one context for each LayoutObject, so we should create ContainingBlockScope only once for the first fragment only. Previously creating multiple ContainingBlockScopes for one multi-block-fragment object broke stacking of the scopes, causing memory corruption. Add check in ~ContainingBlockScope for stacking error in the scopes. This limitation will be removed with LayoutNGFragmentTraversal which traverses block fragments in depth-first order. Bug: 1113710 Change-Id: I07aa3626f1a1d34714459e256880a96897585d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339449Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796093}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I02e35892e8d6b6b0425a273366ef8aa92a7a6a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343529Reviewed-by:
-
Matthew Crabill authored
Change Graphics.Smoothness.FrameSequenceLength.* to only report the length for the effective thread. This change modifies all of the Graphics.Smoothness.FrameSequenceLength.* metrics to only report the length for the effective thread. Bug: 1101497 Change-Id: I5397d8fcdc8bd82b0a142e35dec7803d2c2a5c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319786 Commit-Queue: Matthew Crabill <macrabil@microsoft.com> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#796091}
-
David Black authored
Menu traversal handles up/down arrow keys as expected. But if the user is holding down VKEY_COMMAND while pressing up/down arrows, menu traversal does not occur. In this case, the ui::KeyboardCode received by MenuController is actually VKEY_NEXT and VKEY_PRIOR which were previously unhandled. For an upcoming Chrome OS feature, a menu may be shown while holding down VKEY_COMMAND, and we want to allow the user to continue to hold down VKEY_COMMAND throughout their entire menu iteraction. NOTE: Pressing down and up arrows while holding down VKEY_COMMAND moves ChromeVox focus on Chrome OS. I confirmed that *prior* to this change, ChromeVox did *not* appear to traverse menus but after this change it does. Bug: 1113035 Change-Id: I9df923d0972102542e69fa92c39eda711346b88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338918 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796090}
-
Ahmed Fakhry authored
This CL adds the CaptureModeBarView which is the content view of the CaptureModeBarWidget. It also adds the CaptureModeSession which owns the widget and remains alive as long as capture mode is active. BUG=1112919 TEST=Manually, added new tests in capture_mode_unittests.cc Change-Id: I36b5b5f2cb147c36aa66f5d889c55865345463a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339902 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#796089}
-
Miriam Zimmerman authored
To be technically accurate, we should not describe this option as "anonymous"; it's actually properly described as "de-identified". However, "de-identified" is a bit technical, so change to a more clear string. BUG=chromium:1112012 TEST=Deploy to DUT and verify dialog option is as expected Change-Id: I41abf1ca9ec04bc6518a2c085d86f8c29db83a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340522Reviewed-by:
Greg Levin <glevin@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#796088}
-
phillis authored
Fix the code to use WebApp.Launcher.LaunchResult and WebApp.Launcher.UpdateResult to match the ones in histograms.xml Bug: none Change-Id: Iece91aa20d3614ff2d711d7c765ec0837a63c23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341845 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#796087}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0c0349252934..a4cba6578f09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9736cff2e080973864459305913ab08c496b860c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343590Reviewed-by:
-
Jeffrey Cohen authored
This is a reland of af2e1e93 Original change's description: > [Screenshot] Enable image editor for canary builds. > > Bug: 1024586 > Change-Id: I586d8dc0a05c0aab3776b42c9145d0f6a586c1f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032505 > Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> > Reviewed-by: Kristi Park <kristipark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793791} Bug: 1024586 Change-Id: Iaa640531a8190fc0c1bebcc05990330283327e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342125Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796085}
-
Brian Malcolm authored
This is intended to replace the UserNativePrintersAllowed policy. The old policy will still be used in the absence of the new one for at least a few releases of Chrome. BUG=chromium:1113371 Change-Id: If1098adeab5b9fbce431184cf33b8162c99eb30d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341825 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796084}
-
Regan Hsu authored
* Adds cellular setup button to InternetSubpage. * Adds OsSettingsCellularSetupDialog to InternetPage (the dialog may be opened in a detail page of InternetPage rather than InternetSubPage). * Adds blue icon_add_cellular.svg icon. * Add string resources for a11y for button and title for dialog. * Reorganize the add buttons in the internet subpage to make clear which add button adds which network type (Cellular vs WiFi vs VPN). * Embedding the CellularSetup shared component will be done in a follow up CL. Screenshots: https://screenshot.googleplex.com/K2gfDgS4V28 https://screenshot.googleplex.com/nDTbHT87e4k Bug: 1093185 Change-Id: I75062f3e30d1d75b980524c44e9f568798d74bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333055 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#796083}
-
Matthias Körber authored
This CL adds the types needed for LeipzigV1 and some additional compound types that will be used to implement the structured address component. Change-Id: Ic3191f58089ee26c0aed6b86e11490f575d10d9c Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332701 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#796082}
-
Ben Joyce authored
Combines the report generated from the host (junit) code coverage with the report generated from the test a ran on device. It goes to each method and updates the counters from whichever coverage is higher. It then updates the lines covered in the source file and finally, updates the counters. Please note if an instruction has branch A,B,C, and one report covers only branch A and another only covers Branch B and C, it will choose the report results that cover branch B and C, showing A as uncovered. This is because if one report covered A and B, and another covered B, we can't say "3 branches are covered." Bug: 1107004 Change-Id: I8dfa9feb80df5c9ed6d468226c25155383962519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333065 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#796081}
-
Dirk Pranke authored
This removes jumbo.gni, the imports of jumbo.gni, and any remaining stray references to it in the build files and docs. Bug: 994387 Change-Id: Ic39b7c609e1bd922e05c7e1104f1e5532c188f5a AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337392Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#796080}
-
dpapad authored
Per UX suggestion, experimenting with a different color, google-grey-600 instead of white, which unfortunately is not noticeable at all when the document (usually white bg color), is zoomed in. Bug: 1069370 Change-Id: Ibde70bac01ce70dde3e56a5a6129d549e53baf9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343568 Commit-Queue: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#796079}
-
K. Moon authored
Adds empty implementations of the PDFEngine::Client interface to PdfViewWebPlugin, in preparation for using PdfViewWebPlugin with PDFiumEngine. Bug: 1085334 Change-Id: Iebe1681829a6b02e220bb353c767a9c28cd2a3ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342138Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#796078}
-
Aleks Totic authored
Tables with collapsed borders compute their borders by running an algorithm. To run this algorithm, ComputeBorders needs an NGBlockNode argument. Change-Id: I1d1028bed42a4b16b662bd51c4d46d18e68c57f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341411Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#796077}
-
Abigail Klein authored
Based on UXW feedback, modify the live caption settings subtitle string and add a new download complete string. Also, only show the download error message when there is an error event from the component updater. Previously, we also showed an error message if the download progress was unknown, but it is better to do nothing in that case and wait for more information about the download progress. Bug: 1055150 Change-Id: Ib8343b45b20b8a3b66a4dbbc15361189d015cae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343231Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#796076}
-
Adam Raine authored
Follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/2283289 Adding the compositor failure reasons to the trace allows Lighthouse to report if an animation fails due to unsupported CSS properties, but Lighthouse cannot see which CSS properties are unsupported. These changes collect the unsupported CSS properties and add them to the animation trace event for compositor failure reasons. Bug: 230229 Change-Id: I5d40b1ffd7fd82f8231940b7027ace30ea25df48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320552Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Adam Raine <asraine@google.com> Cr-Commit-Position: refs/heads/master@{#796075}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ce00f903c268..55eebf450c36 2020-08-07 jalyn@microsoft.com Enable new Shortcuts settings page by default If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I48ca2762a9bc9336dce26393736892e81a32e558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343525Reviewed-by:
-
Matthias Körber authored
Change-Id: I185216a1a5cdb7063b9e6d90d99195cc608f97ab Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339350 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
-
Angela Yoeurng authored
Bug: 1046523 Change-Id: Ie25435820d7ebbb67b884638fd4add05a7011c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341840Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#796072}
-
Ben Pastene authored
Bug: 1092973 Change-Id: I4df191266f28297cf8581f1687de87e336713363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339580Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#796071}
-
John Delaney authored
Moves ConversionStorage and it's task runner into a wrapper which can be shared across threads. The new ConversionStorageContext is created by the ConversionManager on the UI thread. To integrate with QuotaManager, ConversionStorage needs to be accessible/owned by the IO thread where QuotaClients are accessed. ConversionStorageContext wraps a ConversionStorage instance which lives on its own task runner. As is, this requires redeclaring all ConversionStorage methods with appropriate callbacks on the ConversionStorageContext. Future improvements to base::SequenceBound may remove this need, but for now this simply moves the existing task runner + storage interface into the storage context This construction allows for data races on tasks that are posted to the storage task runner, which is okay because operations on ConversionStorage does not require any sequencing on operations. Change-Id: Iff0c2c22bb1d02d98f8d8fd80734f235b116918c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239676 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#796070}
-
Bella Bah authored
Was causing Windows trybot traffic_annotation tests to fail because of module naming collision. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8872768115210425728/+/steps/test_traffic_annotation_auditor/0/stdout Change-Id: I5205f8232c633cb9028de667472f4e80f869d973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339941Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Mohamadou Bella Bah <bellabah@chromium.org> Cr-Commit-Position: refs/heads/master@{#796069}
-
Carlos IL authored
Prior to this fix, stale rectangles where showing at the start of a new animation. Bug: 1112848 Change-Id: Ie41eae474a2c2477b436a6b450cda099225f90f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341839 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
-
Brian Manthos authored
No functional changes other than the namespace the function is in and making the function available elsewhere via the header declaration. Change-Id: Ie48dd21e1c8358c53e692fd45f219a16e9cfd9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342311 Commit-Queue: Brian Manthos <brianman@microsoft.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#796067}
-
Alexander Surkov authored
Bug: 1100991 Change-Id: Ie00ccd7659e131a20702b5b8a028cbd1289f1647 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341400 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Justin Cohen authored
An unresolvable URL is now a syntax error in WebKit. Change-Id: I6707b683887db3d7b715eb87b8d223023ee733bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342321 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796065}
-
Chris Sharp authored
As an escape hatch we shouldn't mark this policy as deprecated until removing it. Bug: 1114250 Change-Id: I7261b51fd4d10c584564a13dc7624b2ed4a8f55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339943Reviewed-by:
-
Matthias Körber authored
This CL integrates the merging into the AutofillProfile. It also disables honorifics and fixes most but not all test issues that occur if the structured-name feature is globally enabled. Change-Id: Ibf940a01a28697a6e0be2ea5e61625a6a23bf8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333204 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
-
Alex Gough authored
Removes pre-spawn hook and export from network service and moves code into utility delegate. No functional changes. This code only runs for Windows. Various DEPS and OWNERS are also updated to reflect the move. (The linux sandbox hook is not moved as runs in the utility at start up.) Bug: 1111421,1049894 Change-Id: Ib7c6145509731883a21d790ce1c7ce4da220c8bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339325Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#796062}
-
nuwanda authored
This change should not affect bots unless --experimental-tbmv3-metrics flag is supplied. The metric is defined here: https://source.chromium.org/chromium/chromium/src/+/master:tools/perf/core/tbmv3/metrics/accessibility_metric.proto. Change-Id: I600ce186b8f343f8c12d3d80a7d2f98bd83e3d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339966 Commit-Queue: Julia Semavina <nuwanda@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Deep Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#796061}
-
James Vecore authored
The visibility page is just stubbed in place without the center content. A shared component will be added to implement the visibility selection in a future CL. The link used for "Managed Contacts" is also temporary. Specs, strings, accessibility handled in a follow-up CL. The "Confirm" button will however actually enable Nearby Sharing. Screenshot: https://screenshot.googleplex.com/xOasYwc8hSq Change-Id: I68ab57e10611045270d261deae1dd66f3e3969f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340681 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
-
Dominique Fauteux-Chapleau authored
This reverts commit c2e39ede. Reason for revert: Breaks Mac builder (https://ci.chromium.org/p/chromium/builders/ci/Mac%20Builder/119092) Original change's description: > Do clean up in PlatformFontMac > > Do not try to derive one weight of font from another. > Use the API to directly generate them. > > PlatformFontMacTest.FontWeightAPIConsistency tested that > our understanding of shifting weights up and down was > correct. The code no longer shifts weights up and down > as that is unreliable and version-specific, so there is > no need to test weight shifting and it is removed. > > This also fixes Big Sur issues. > > Bug: 1101426 > Change-Id: I2165c3550ad295b3ee7742f3289874ed2bb89c68 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340262 > Commit-Queue: Avi Drissman <avi@chromium.org> > Auto-Submit: Avi Drissman <avi@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796044} TBR=ellyjones@chromium.org,avi@chromium.org Change-Id: I7a7d792d80eadfab524fc7235c3b9a349a34c970 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343490Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#796059}
-
Thoren Paulson authored
Looks like this was missed in crrev.com/c/2297920 Bug: internal b/162634401 Test: CQ Change-Id: Iafbfb2dbcf24abe1e6e31e6d4b461908382309eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343504 Commit-Queue: Thoren Paulson <thoren@chromium.org> Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org> Auto-Submit: Thoren Paulson <thoren@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#796058}
-
Ali Juma authored
This makes SafeBrowsingService use a persistent cookie store, and clears this cookie store whenever cookies are cleared for "all time". This makes the behavior on iOS consistent with the behavior of Safe Browsing on other platforms. Change-Id: I37fec41b6929386ecf2ce1e29fdbb8e95ac89383 Bug: 1103219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291694 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#796057}
-
