GitLab

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2375583002
Cr-Commit-Position: refs/heads/master@{#421303}

BUG=650782

Review-Url: https://codereview.chromium.org/2369053002
Cr-Commit-Position: refs/heads/master@{#421302}

This removes platform-specific hooks from extension API generation, as these
were only relevant in WebKit.

Review-Url: https://codereview.chromium.org/2374573002
Cr-Commit-Position: refs/heads/master@{#421301}

TouchActionBrowserTest.DefaultAuto is flaky on devices which have a
longer display than other devices. The test could not scroll the
full height of the display, so we increase the scroll height.

BUG=648755

Review-Url: https://codereview.chromium.org/2358673002
Cr-Commit-Position: refs/heads/master@{#421300}

BUG=647764

Review-Url: https://codereview.chromium.org/2372573005
Cr-Commit-Position: refs/heads/master@{#421299}

The code was assuming window was this->window_, which is not
necessarily the case.

BUG=650755
TEST=none
R=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2369413002
Cr-Commit-Position: refs/heads/master@{#421298}

extensions/browser/api/cast_channel/logger.cc includes
"third_party/zlib/zlib.h" and so the target should depend on zlib.

BUG=none

Review-Url: https://codereview.chromium.org/2362383003
Cr-Commit-Position: refs/heads/master@{#421297}

The current implementation of base::SysInfo().OperatingSystemVersion()
for Windows joins the version of the OS with some representation of
the Service Pack. That created a server configuration issue in the past
where a rule had been written assuming a dotted version string for the OS.
Since then, the authors of configuration files have learned to write rules
that consider the possibility that OS versions may not be dotted strings.

Traditionally, Omaha expected the OS version and Service Pack as serparate
entities in the Omaha protocol.

Other platforms but Windows and Linux use dotted version strings currently.
They have no Service Packs.

The Linux does not provide an implementation for
base::SysInfo::OperatingSystemVersionNumbers(). Linux versions could include
relevant information that does not fit the typical dotted string version.

In conclusion, this change is a minor improvement for the Windows OS metadata
and leaves the rest, including Linux, the same as before.

BUG=642476

Review-Url: https://codereview.chromium.org/2365523004
Cr-Commit-Position: refs/heads/master@{#421296}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6888cbc1..f2767998

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2372153003
Cr-Commit-Position: refs/heads/master@{#421295}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/384efea3161c..8410eebd6f4c

$ git log 384efea31..8410eebd6 --date=short --no-merges --format='%ad %ae %s'
2016-09-27 benjhayden CC current sheriff instead of assigning them to perf regression bugs.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2375683002
Cr-Commit-Position: refs/heads/master@{#421294}

Currently ARC++ BT just supported only discoverable timeout
for set_adapter_property to pass the CTS test. This CL
finishes the implementation of that and refactor the current
code to use common callback function.

BUG=646584
TEST=Build/Unit test/CTS

Review-Url: https://codereview.chromium.org/2364443002
Cr-Commit-Position: refs/heads/master@{#421293}

path, is not reliable. Instead, this adds a central check to the sandbox
to see if filesystem access is available (by trying to stat() /proc).

BUG=chromium:630420

Review-Url: https://codereview.chromium.org/2357393003
Cr-Commit-Position: refs/heads/master@{#421292}

Previously, an "unknown duration" signalled by a mvhd duration
field was only understood to be unknown if it were 0, or a
64-bit (version 1 mvhd) special value of all bits set. This change adds
the same special value handling for a 32-bit (version 0 mvhd).

This change corrects detection of unknown mp4 MSE durations in some
cases. Unknown duration is web-app-visible and changes MSE behavior.
Also, it's used as a signal to enable our experimental low-delay
video rendering path.

I used a hex editor create the new test media file from
bear-1280x720-av_frag.mp4: truncated the file to just the initialization
segment (~1.5k, compared to full original file ~750k), and modified
the mvhd duration field values to be all bits set instead of 0.

The new unit test fails (due the the max-uint32 value being interpreted
as a real duration) before the rest of the code changes were included
into this CL.

TEST=MP4StreamParserTest.UnknownDuration_V0_AllBitsSet
BUG=649882
R=xhwang@chromium.org

Review-Url: https://codereview.chromium.org/2368773002
Cr-Commit-Position: refs/heads/master@{#421291}

This CL introduces the basic structure of Shape Detection API, including
four classes:
Detector, FaceDetector, DetectedObject, DetectedFace (dictionaries are
not yet implemented)

and adds simple layout tests in shapedetection-creation.html to verify
corresponding constructors.

R=mcasas@chromium.org
BUG=646083

Review-Url: https://codereview.chromium.org/2360783003
Cr-Commit-Position: refs/heads/master@{#421290}

Merge internal change: 134339524

Review-Url: https://codereview.chromium.org/2368183003
Cr-Commit-Position: refs/heads/master@{#421289}

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2369593002
Cr-Commit-Position: refs/heads/master@{#421288}

Before this CL, blocking of top-level navigations in extension pop-ups
was accomplished by routing them via OpenURL path and blocking (or
rather - silently dropping) CURRENT_TAB navigations via
ExtensionViewHost::OpenURLFromTab.  This was problematic for a few
reasons:

1. This unnecessarily blocked navigations that end-up being treated
   as downloads (i.e. because HTTP response says Content-Disposition:
   attachment).  This was the root cause of the regression raised in
   https://crbug.com/646261

2. There are still some remaining issues in handling of POST requests
   via OpenURL path (e.g. dropping Content-Type header -
   https://crbug.com/648648).

3. In the long-term we want to rely less on process isolation
   accomplished via OpenURL - an exploited renderer process does not
   necessarily have to go through OpenURL path and can instead choose
   to use the regular, renderer-initiated path.

After this CL:

1. ExtensionViewHost::ShouldTransferNavigation is used to block top-level
   navigations in extension pop-ups (and background pages).

2. POST navigations do not go through OpenURL path anymore (i.e. this CL
   effectively reverts the essence of r407586).

   In the long-term we want to make all extension navigations to not go
   through OpenURL path, but this seems too risky to merge back to M54,
   so for now we only do #1 above (i.e. avoid OpenURL only for POST
   requests).

BUG=646261
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2352083003
Cr-Commit-Position: refs/heads/master@{#421287}

libosmesa.so is referenced in blimp/engine/browser_tests/integration_test.cc:68

This is a temporary workaround for crbug.com/650285

Also, add tests-manifest-blacklist.txt as an input to
generate_blimp_engine_env_tests_manifest, so that when the blacklist
changes the test bundle is re-generated.

R=dtrainor@chromium.org
BUG=650285

Review-Url: https://codereview.chromium.org/2366973003
Cr-Commit-Position: refs/heads/master@{#421286}

https://chromium.googlesource.com/skia.git/+log/53c7bbfaaf80..3ba96c8cecd8

$ git log 53c7bbfaa..3ba96c8ce --date=short --no-merges --format='%ad %ae %s'
2016-09-27 mtklein Turn on -Wgnu-anonymous-struct and -Wnested-anonymous-types.
2016-09-27 egdaniel Revert of Add command buffer submits before copy calls in vulkan. (patchset #5 id:80001 of https://codereview.chromium.org/2363773006/ )

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=fmalita@google.com

Review-Url: https://codereview.chromium.org/2369753005
Cr-Commit-Position: refs/heads/master@{#421285}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/14c8f0a44c13e0d91bae2ac4ca74acfd0aa084a8 Remove the download_android_tools step (jsimmons@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2368413004
Cr-Commit-Position: refs/heads/master@{#421284}

When loading a resource, it is possible that it will not have a
bitmap (OOM cases for example). This change checks that the bitmap
exists in the resource before calling native OnResourceReady.

BUG=650361

Review-Url: https://codereview.chromium.org/2368373003
Cr-Commit-Position: refs/heads/master@{#421283}

Direct access to LayoutPart is deprecated and being removed soon. The
replacement is LayoutPartItem, which routes methods through the new
block layout API. (See linked crbug for details.) This means the
ownerLayoutObject() method is also deprecated, to be replaced with
ownerLayoutItem().

There are no functional changes.

BUG=499321
TBR=eae@chromium.org

Review-Url: https://codereview.chromium.org/2374613003
Cr-Commit-Position: refs/heads/master@{#421282}

Add a metric to measure clicks on the "Annotate" button in
screenshot notifications. Also list additional owners for
DownloadNotification.Button_Annotate.

BUG=650497
TEST=manual: chrome://user-actions shows Screenshot_Annotate
     action after clicking button

Review-Url: https://codereview.chromium.org/2376553002
Cr-Commit-Position: refs/heads/master@{#421281}

BUG=649539

Review-Url: https://codereview.chromium.org/2371953002
Cr-Commit-Position: refs/heads/master@{#421280}

Refactoring done in that CL looks like it could introduce potential problems
because now there's a path through the affected method that does not
reset the context.

This CL refactors the affected method to always reset the context while
preserving the refactoring done in 2157793002.

BUG=626770

Review-Url: https://codereview.chromium.org/2300753003
Cr-Commit-Position: refs/heads/master@{#421279}

BUG=649874

Review-Url: https://codereview.chromium.org/2359363004
Cr-Commit-Position: refs/heads/master@{#421278}

https://html.spec.whatwg.org/multipage/semantics.html#hyperlink-auditing
part 4 states that a Ping-From header should only be sent
for same origin requests or if the document containing the
hyperlink is unencrypted.

I think this was regressed accidentally in https://trac.webkit.org/changeset/91306

BUG=637459
TEST=PingLoaderTest.HTTPSToHTTPS

Review-Url: https://codereview.chromium.org/2360753002
Cr-Commit-Position: refs/heads/master@{#421277}

This is mostly a copy of https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/pgo/resources/run_benchmark.py (which will disappear)

I think that it make more sense to keep this script in the Chrome repo, so people can easily do a local PGO build.

BUG=309849

Review-Url: https://codereview.chromium.org/2368353003
Cr-Commit-Position: refs/heads/master@{#421276}

BUG=650239
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2370843002
Cr-Commit-Position: refs/heads/master@{#421275}

Temporary workaround for linked bug. I think it probably makes more
sense for the function to crash anyway, because the caller is not
expecting the call to return (esp. if used in a "security"-type crash.)

R=mark@chromium.org
BUG=634418

Review-Url: https://codereview.chromium.org/2377693002
Cr-Commit-Position: refs/heads/master@{#421274}

Also clean-up for unnecessary context parameters.

BUG=649729

Review-Url: https://codereview.chromium.org/2374523002
Cr-Commit-Position: refs/heads/master@{#421273}

Make the assert functions take array instead of dictionary as expected argument.
Also, fix wrong indentation in test codes.

BUG=None

Review-Url: https://codereview.chromium.org/2370623003
Cr-Commit-Position: refs/heads/master@{#421272}

Only a problem with use-zoom-for-dsf on, but that is now default on Windows and
ChromeOS.

BUG=644421

Review-Url: https://codereview.chromium.org/2370523002
Cr-Commit-Position: refs/heads/master@{#421271}

Some YouTube 4K videos have frames larger than 2 megabytes, e.g. video
tdWV2xEyOfE has frame larger than 2MB at 385.886 sec. So increase mojo
video buffer capacity to 3MB.

BUG=internal b/31724921

Review-Url: https://codereview.chromium.org/2371763003
Cr-Commit-Position: refs/heads/master@{#421270}

BUG=635649,540022
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2367213002
Cr-Commit-Position: refs/heads/master@{#421269}

Reland of cc: Remove frame queuing from the scheduler. (patchset #1 id:1 of https://codereview.chromium.org/2336493002/ )

Reason for revert:
Reland after fixing screenshot grabber test and perf issues.

Original issue's description:
> Revert of cc: Remove frame queuing from the scheduler. (patchset #3 id:40001 of https://codereview.chromium.org/2323063004/ )
>
> Reason for revert:
> Broke ChromeScreenshotGrabberTest.TakeScreenshot on  Linux ChromiumOS Tests (dbg)(1): https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/18015.
>
> Original issue's description:
> > cc: Remove frame queuing from the scheduler.
> >
> > CC scheduler has a frame queuing mechanism called "retro frames". This
> > has been responsible for a lot of complexity and hard to fix bugs. The
> > original intent for adding retro frames was to allow the scheduler to
> > handle multiple frames in flight but that goal doesn't seem feasible or
> > even desirable any more. This CL removes the retro frames queue and
> > instead makes the Scheduler end the previous frame when it receives a
> > BeginFrame message.
> >
> > One surprising behavior was that SyntheticBFS MISSED frames would be
> > queued as retro frames and this would convert the synchronous begin
> > frame call (inside Scheduler::ProcessScheduledActions) to an
> > asynchronous retro frame PostTask. To work around this the Scheduler
> > keeps track of a single CancelableClosure that's used for MISSED frames.
> >
> > The above behavior was also causing the BeginFramesNotFromClient tests
> > to work even though there was an extra MISSED frame in the queue. This
> > is more elegantly solved in another way by using frame number to advance
> > the task runner instead of just running pending tasks.
> >
> > Lastly SchedulerStateMachine is modified so that it's possible to end
> > the previous frame and still have the same behavior as before in the
> > commit to active tree (browser compositor) mode.
> >
> > R=brianderson@chromium.org,enne@chromium.org,danakj@chromium.org
> > BUG=602485, 644992
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
> >
> > Committed: https://crrev.com/559280b26cc5672f5f054e8ac35281e804c14d78
> > Cr-Commit-Position: refs/heads/master@{#417764}
>
> TBR=enne@chromium.org,brianderson@chromium.org,danakj@chromium.org,sunnyps@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=602485, 644992
>
> Committed: https://crrev.com/95beb47e50065959ee2f5b43cf431431e32e14cd
> Cr-Commit-Position: refs/heads/master@{#417895}

TBR=enne@chromium.org,brianderson@chromium.org,danakj@chromium.org,sammc@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=602485, 644992
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2339633003
Cr-Commit-Position: refs/heads/master@{#421268}

This bug only appears for the certain bubbles because it is only
visually apparent when the margins are set to zero. I'm not sure
why we're setting this extra background. It's probably my fault.

BUG=649355

Review-Url: https://codereview.chromium.org/2363403003
Cr-Commit-Position: refs/heads/master@{#421267}

They come out looking a little different than the png assets we were
using, which is intentional. Screenshots at 1x and 2x are sgabriel-
approved.

BUG=649545
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2364163002
Cr-Commit-Position: refs/heads/master@{#421266}

This makes the following changes:

- Tweak ERR_BAD_SSL_CLIENT_AUTH_CERT's text be suitable for both
  invalid and missing client certs. net_error_list.h actually already
  documents it for this case, but the user-visible error does not.

- Since TLS lacks a dedicated alert for missing client certificates,
  servers often send a generic handshake_failure alert. Detect this case
  and map to ERR_BAD_SSL_CLIENT_AUTH_CERT.

- One of the many bad client cert alerts is access_denied.
  Unfortunately, that was badly named so firewalls sometimes send it,
  giving users a confusing error page. Detect this case too and map it
  to ERR_SSL_PROTOCOL_ERROR, the same error we would use for an unexpected
  alert.

Add a bunch of tests for these cases.

Screenshot of the new ERR_BAD_SSL_CLIENT_AUTH_CERT:
https://drive.google.com/file/d/0Bz14lOW5Hke4ZzRPLXZwUUlzOFk/view?usp=sharing

BUG=630883,646567

Review-Url: https://codereview.chromium.org/2350483002
Cr-Commit-Position: refs/heads/master@{#421265}

We lacked these ids in OnNewLiveVersion and there were no updates when they changed.

BUG=648775

Review-Url: https://codereview.chromium.org/2365053002
Cr-Commit-Position: refs/heads/master@{#421264}