- 04 Dec, 2017 40 commits
-
-
Lei Zhang authored
Change-Id: Ib22c9ebe468065a572cf3d5a2ba61cbd3ed85698 Reviewed-on: https://chromium-review.googlesource.com/804752Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#521441}
-
chrome://interventions-internalsThanh Le authored
Design doc: https://docs.google.com/document/d/1i7_1VkjJ2x86BXWocK4ZuEVq_DzdYRslt2ihJ2UdlZk Screenshot: https://drive.google.com/a/chromium.org/file/d/1qGcgcNF3vCjb0cjkkrO_Sox9OEOSQtXo Bug: 788872 Change-Id: Ib09a31a3914aa9b244e9e6117e1cc501a102e82c Reviewed-on: https://chromium-review.googlesource.com/791910 Commit-Queue: Thanh Le <thanhdle@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#521440}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/bee6cacc5435..7ffbcf909d36 $ git log bee6cacc5..7ffbcf909 --date=short --no-merges --format='%ad %ae %s' 2017-12-04 robertphillips Add unit test for SkDeferredDisplayLists (take 2) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: Ie17e899f94aa96c4dc8124fcbcd2fcd7b90b9d36 Reviewed-on: https://chromium-review.googlesource.com/806914Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521439}
-
Erik Luo authored
- Remove redundant Find/Previous buttons - Replace "Replace" checkbox with cool icon - 'Replace all' button is disabled when 'Replace' is also disabled Screnshot: https://imgur.com/a/gp0SZ Bug: 631163 Change-Id: I98f2ca5b8e504d13d85057a80fa5bb9cf60c6118 Reviewed-on: https://chromium-review.googlesource.com/769991 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521438}
-
Rintaro Kuroiwa authored
- With typemap to media/cdm/cdm_proxy.h types. - No methods are added yet. Bug: 785563, 641132 Change-Id: I9012cc81bb52be694d004673881aedad8b8abb09 Reviewed-on: https://chromium-review.googlesource.com/772863 Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521437}
-
David Reveman authored
Camera: Take photo. Video: Capture video. Bug: 787673 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie9f3a72991b6384533b6d5d031ab4e11ecf2e1b2 Reviewed-on: https://chromium-review.googlesource.com/804560Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521436}
-
Réda Housni Alaoui authored
- Full rewrite of the MediaFoundation implementation video part to use IMFCaptureEngine - Implementation of takePhoto, setPhotoOptions and getPhotoCapabilities - takePhoto triggers a still image capture with the highest available resolution without stopping the video stream thanks to IMFCaptureEngine TEST=adapted video_capture_device_unittest.cc and webrtc_image_capture_browsertest.cc; launch Chrome with --force-mediafoundation on Win8+ and capture video using e.g. https://webrtc.github.io/samples/src/content/getusermedia/gum/ R=mcasas@chromium.org Bug: 730068 Change-Id: Ib8e7f475d8120a63dd08c7b215c1eaf2c6f3d800 Reviewed-on: https://chromium-review.googlesource.com/734042 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#521435}
-
Wez authored
Bug: 789712 TBR: gab Change-Id: I16e059c18420a56e875c5564015531177bc213d3 Reviewed-on: https://chromium-review.googlesource.com/806815Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#521434}
-
Reza.Zakerinasab authored
virtual/gpu/fast/canvas/canvas-createImageBitmap-colorClamping.html is consistently passing on Linux and Windows and failing on Mac. Trying to re-enable this disabled test. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual/gpu/fast/canvas/canvas-createImageBitmap-colorClamping.html Bug: 791554 Change-Id: I4e89ec29a19f1d9c3d7b122214dcd39dfd7eb648 Reviewed-on: https://chromium-review.googlesource.com/803903Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#521433}
-
Lei Zhang authored
Change-Id: Ie912416a96a1ad49df0beb01f3e974b0b17f53a1 Reviewed-on: https://chromium-review.googlesource.com/804680Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#521432}
-
Ryan Sleevi authored
Beginning with macOS 10.12, the APIs Chromium uses to enumerate client certificates in the Keychain may miss certificates from some smartcards; notably, ECDSA certificates on Tokend-backed cards. This is because Chromium uses the deprecated macOS APIs for detecting client certificates. However, those legacy APIs are the only way to access some identities on other cards. To resolve this, use both the deprecated and the current API to enumerate client identities, deduplicating along the way. This is largely based on a patch from agaynor@mozilla.com in https://codereview.chromium.org/2910893002/, updated for the current API. Bug: 769699 Change-Id: I706ad121d0e6827ac4830f36aeacbc7d1c959560 Reviewed-on: https://chromium-review.googlesource.com/804118Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521431}
-
Charles 'Buck' Krasic authored
Profiled on android arm64, seems to speed up net::QuicUtils::CopyToBuffer() by about 10%, translating to about 0.1% overall. Merge internal change: 177612619 R=rch@chromium.org Bug: Change-Id: I7b85a4c91538a73af58c3fdbe32637e51693bd4a Reviewed-on: https://chromium-review.googlesource.com/804744Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Buck Krasic <ckrasic@chromium.org> Cr-Commit-Position: refs/heads/master@{#521430}
-
James Wallace-Lee authored
This CL adds a histogram to track how often loadDataWithBaseUrl is called with a historyUrl parameter that is empty, the same as baseUrl, or different from baseUrl. Bug: 779661 Change-Id: Ifba359d6527454cedf4879990c8ce73f7e0225ef Reviewed-on: https://chromium-review.googlesource.com/798354Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#521429}
-
Yi Gu authored
PullDeltaForMain() happens right before the commit and is supposed to return the latest active tree delta. Therefore calling it on a pending tree doesn't make sense and should never happen. Bug: Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I80c4e9727d5600dfe701c948e0ae822a8718f731 Reviewed-on: https://chromium-review.googlesource.com/806475 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521428}
-
Bence Béky authored
Remove more than a dozen test-only accessor methods and more than two dozen FRIEND_TEST_ALL_PREFIXES() macros from SpdySession. Move these accessor methods to SpdyNetworkTransactionTest (three of them), SpdySessionPool (one of them), and SpdySessionTest (many) base classes. Also wrap direct access to private members from test subclasses into accessor methods in test base classes. I was originally writing a SpdySessionPeer class, see earlier patch sets, but since almost every method is called multiple times within SpdySessionTests, and always with |session_| argument, I ended up relaying them through SpdySessionTest protected methods anyway, and it was just simpler in the end to befriend SpdySessionTest and access SpdySession members directly. Change-Id: Iaef2084f4f5a5d81e85c34bdbbbcfd963282d86e Reviewed-on: https://chromium-review.googlesource.com/803937 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#521427}
-
Joel Einbinder authored
We emulate the correct text selection colors for CodeMirror, but we were awlays displaying the active colors even when the window was not focused Bug: none Change-Id: Idaf4983ef758a6e66479244b641b3e0245b13ded Reviewed-on: https://chromium-review.googlesource.com/671533Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#521426}
-
Sean Kau authored
Some print jobs take a very long time to render. Add some buffer to allow rendering to complete. Long term, we hope to reduce the timeout to 20s to detect if a printer is reachable. If a printer is unreachable, this change will result in extending the time a user waits from 20 to 120s. This should only be encountered by users setting up their printer for the first time. Bug: 786182, 791230 Change-Id: I5088654b3f8a68b1178efeef98c5cb66dfe4647c Reviewed-on: https://chromium-review.googlesource.com/804606Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#521425}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/a827770faf5c..0ddd5dc79696 $ git log a827770fa..0ddd5dc79 --date=short --no-merges --format='%ad %ae %s' 2017-12-04 thestig Break out CFX_ImageTransformer color calculations. 2017-12-04 thestig Break out CFX_ImageTransformer mono calculations. 2017-12-04 thestig Add text unit to glyph unit conversion to CPDF_Type3Char. 2017-12-04 dsinclair Cleanup CFXJSE_Engine visibility 2017-12-04 thestig Break out CFX_ImageTransformer alpha calculations. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I54e1022620bd0ae0b899c038bb5455bec07ead5c Reviewed-on: https://chromium-review.googlesource.com/806431 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521424}
-
Victor Costan authored
After the removal of byte-swapping in V8 value serialization, SerializedScriptValue::ToWireBytes() is strictly worse than GetWireData(), as it creates a copy of the serialized value bytes. Removing it makes copying obvious in the callers, so it can be removed where that results in a performance improvement. Bug: Change-Id: I2c299ac4baa89ba3d33210ce64762730390c4952 Reviewed-on: https://chromium-review.googlesource.com/804902Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#521423}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/86de7e898a63..83d27683a83d $ git log 86de7e898..83d27683a --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I95402af01d9171fb8d66451818543c87471f46e2 Reviewed-on: https://chromium-review.googlesource.com/806739Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#521422}
-
Robert Hogan authored
The Blink Rename has made most uses of this-> unnecessary. The relevant variable names no longer clash with the getters. Bug: 789653 Change-Id: I6ce6cb4107354a411da57e674df667658ea5d2fc Reviewed-on: https://chromium-review.googlesource.com/798130Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/heads/master@{#521421}
-
Francois Doray authored
Support deleting a window with tracked occlusion from LayerAnimationObserver::OnLayerAnimationEnded. Previously, if a window with tracked occlusion was deleted from LayerAnimationObserver::OnLayerAnimationEnded, an invalid memory access occurred in WindowOcclusionTracker::CleanupAnimatedWindows (because the window was deleted before being removed from |animated_windows_|). This CL fixes this problem by removing the Window* from |animated_windows_| in WindowOcclusionTracker::OnWindowDestroyed. Bug: 668690 Change-Id: I77749c79d72d7cebc3a77647552605c8abec3abb Reviewed-on: https://chromium-review.googlesource.com/806356 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#521420}
-
Morten Stenshorne authored
In an engine with subpixel support, these tests would render ever so slightly "incorrectly", compared to the ref, which assumed that all values less than 1px be rounded down to 0. Bug: 788337 Change-Id: I5810a9620763fa0065ee480ed953a1426c95cf93 Reviewed-on: https://chromium-review.googlesource.com/806173Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#521419}
-
Erik Luo authored
Relevant V8 CLs have landed in this autoroll: https://chromium-review.googlesource.com/c/chromium/src/+/805157 Bug: 700624, 727514 Change-Id: I73392015ee47bb79499cc7ee8b447673c00387da Reviewed-on: https://chromium-review.googlesource.com/806258Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#521418}
-
Michael Spang authored
The tracing request format currently in use is deprecated and does not support enabling some features such as system tracing. Switch to the new format. This requires us to tokenize the category filter ourselves; this is done using the same algorithm as chrome. This also fixes a regression where the category filter was set to '"*"' (double quotes included) which does not work properly, disabling all events. We should use the empty string, which simply means to apply the defaults. The android backend appears to be prepared to handle this as well (mapping it to "_DEFAULT_CHROME_CATEGORIES"). BUG=786091 Change-Id: Ic60a3db7f4decc5ee046ce50bfc58d3c22211558 Reviewed-on: https://chromium-review.googlesource.com/804857Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521417}
-
Greg Thompson authored
r516772 was the last of many commits that resolved a number of problems that made this test suite flaky on Windows. This CL enables tests that had been disabled over time due to flakes, yet now seem to run okay. BUG=133341,751031,751543,764415,789913 This CL was uploaded by git cl split. R=sky@chromium.org Change-Id: I753c741a9194f489f072cd86d72407a1294150c3 Reviewed-on: https://chromium-review.googlesource.com/784937Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#521416}
-
Greg Thompson authored
r516772 was the last of many commits that resolved a number of problems that made this test suite flaky on Windows. This CL enables tests that had been disabled over time due to flakes, yet now seem to run okay. BUG=69475,129235,147579,419468,764415 This CL was uploaded by git cl split. R=sky@chromium.org Change-Id: I99053d0c38c27a0ad91b426214bff6365c3b4a5e Reviewed-on: https://chromium-review.googlesource.com/784934Reviewed-by:
-
Greg Thompson authored
r516772 was the last of many commits that resolved a number of problems that made this test suite flaky on Windows. This CL enables tests that had been disabled over time due to flakes, yet now seem to run okay. BUG=499858,764415 This CL was uploaded by git cl split. R=sky@chromium.org Change-Id: Ic884babd5f4814fdf173a18fe91c6e71ce828f92 Reviewed-on: https://chromium-review.googlesource.com/785018Reviewed-by:
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/17995a9f1282..ad64abd69aed $ git log 17995a9f1..ad64abd69 --date=short --no-merges --format='%ad %ae %s' 2017-12-04 agable git-cl: Fix 'git cl issue --reverse' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Ieae5e041e0959596cb6b85d3ca289b4d27a7740f Reviewed-on: https://chromium-review.googlesource.com/806432Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521413}
-
Denis Bessonov authored
The reason for change --------------------- The tests of EXTMultisampleCompatibilityTest will crash if CollectBasicGraphicsInfo fails. Crash occurs in the following call graph: TEST_F(EXTMultisampleCompatibilityTest, (any test)) gpu::EXTMultisampleCompatibilityTest::IsApplicable() gpu::GPUTestBotConfig::CurrentConfigMatches("AMD") gpu::GPUTestBotConfig::LoadCurrentConfig(NULL) // Due to CollectBasicGraphicsInfo failure, // function makes no call SetGPUInfo() and returns true. // This will result in empty gpu_vendor_ vector. gpu::CollectBasicGraphicsInfo(&my_gpu_info) // Returns false for any reason gpu::GPUTestBotConfig::Matches(const std::string& = config_data) gpu::GPUTestBotConfig::Matches(const GPUConfig& = config) // BANG! Segfault trying to access gpu_vendor()[0] The example of situation, where CollectBasicGraphicsInfo fails, is a test Mac with no display connected. In this case, the internal call graph of CollectBasicGraphicsInfo will cause the failure: gpu::CollectBasicGraphicsInfo(&my_gpu_info) angle::GetSystemInfo(&system_info) // Will return false after calling GetActiveGPU() angle::{anonimous namespace}::GetActiveGPU(...) // GetEntryProperty() following CGDisplayIOServicePort will // return false. CGDisplayIOServicePort(kCGDirectMainDisplay) // Will return MACH_PORT_NULL if display is not connected. Suggested change ---------------- Check that gpu_vendor_ is empty and bail out early in gpu: :GPUTestBotConfig::Matches(const GPUConfig&) Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id8f325e4155ee928f2988c50240d7517641779f8 Reviewed-on: https://chromium-review.googlesource.com/788851 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#521412}
-
Aleks Totic authored
Bug: 740993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I6deb54167769a639f2d66a01fb1f2ae13e85ba28 Reviewed-on: https://chromium-review.googlesource.com/804955 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#521411}
-
Mohamad Ahmadi authored
This class is to be used in ChromeAutofillClientIOS and PaymentRequest for lazy instantiation of the AddressNormalizerImpl Bug: 788229 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibe57b150e0aeea1777fab5e5a5aebecfd04fdfc3 Reviewed-on: https://chromium-review.googlesource.com/797735 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#521410}
-
Sophie Chang authored
Bug: 783365 Change-Id: Ib19d2453ce4079b2367d8593dd0d1bf1c7fec301 Reviewed-on: https://chromium-review.googlesource.com/762101Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
-
Johann authored
msan builds skip optimizations because of past issues instrumenting the assembly. R=tomfinegan@chromium.org Change-Id: I4ec4195687b54b85e12e21bbb16666ef4dcb8658 Reviewed-on: https://chromium-review.googlesource.com/806634 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521408}
-
Alexis Menard authored
The spec was updated some time ago clarifying how any-hover: none should match (see https://github.com/w3c/csswg-drafts/commit/98f494677a265df504eee67d587329478b8ce6ba). This patch aligns the behavior with the spec clarification by making sure that 'any-hover:none' will only evaluate to true if there are no pointing devices, or if all the pointing devices present lack hover capabilities. The previous implementation was reading the specification literally by returning the union of the capabilities of the input devices connected on the machine. Windows, Linux and Android are now updated in this patch. This technically has a compatibility impact as we're changing behavior but @rbyers and myself did a rapid search of top websites and didn't find anything relevant to the change. BUG=778694 Change-Id: I230a44f29707e660515b4d27a1bc88552aa73032 Reviewed-on: https://chromium-review.googlesource.com/803662 Commit-Queue: Alexis Menard <alexis.menard@intel.com> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
-
Kurt Horimoto authored
This CL converts FullscreenController to a KeyedService vended through FullscreenControllerFactory. Bug: 778016 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2d81964223cff6a16907ebbcbd9a2b357a3ccae0 Reviewed-on: https://chromium-review.googlesource.com/804750Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#521406}
-
Francois Doray authored
Previously, a DCHECK failure occurred if a WindowObserver or a LayoutManager changed a tracked window after Window::AddChild() added it to a root but before WindowOcclusionTracker::OnWindowAddedToRootWindow was notified. With this CL, the DCHECK is replaced with an early return. We rely on WindowOcclusionTracker::OnWindowAddedToRootWindow to mark the new root as dirty shortly after the early return. Bug: 668690 Change-Id: I0030869c01bb2955bcd8c31b7e5212cb404dc794 Reviewed-on: https://chromium-review.googlesource.com/804120 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
Robert Hogan authored
The Blink Rename has made most uses of this-> unnecessary. The relevant variable names no longer clash with the getters. Bug: 789653 Change-Id: I016817495e3192c6bf2d226afb2901df4b4c90c7 Reviewed-on: https://chromium-review.googlesource.com/805255Reviewed-by:
-
Stephen Chenney authored
When layers are squashed they currently lose their border radius clips. Fix that by using ClipRects instead of IntRects in the sqaushed layer clipping code, and gathering the clips appropriately. Based on https://chromium-review.googlesource.com/c/chromium/src/+/772081 by chrishtr@. R=chrishtr@chromium.org Bug: 761298 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I58a4c8bc785a5cea562a7de52ba24ee1600c9cff Reviewed-on: https://chromium-review.googlesource.com/797337 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521403}
-
stkhapugin@chromium.org authored
The DCHECK was added defensively for the developers to make sure that the animation looks fine if one day it's hit. I've checked that the animation looks fine and nothing jumps around, hence removing it. to the tab switcher and rotating the phone, then choosing one of the tabs. The toolbar should be animated correctly. Specifically test iPhone X. Bug: 788742 Test: Enable Tab switcher presents BVC experimental flag. Try going Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib906b4aaa1ac2b2e7eefa3f82931fa59a4dd3ac8 Reviewed-on: https://chromium-review.googlesource.com/806335Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521402}
-
