GitLab

This is just moving code around in preparation for
making HTMLImportController not being a root HTMLImport.

R=morrita
BUG=

Review URL: https://codereview.chromium.org/303643005

git-svn-id: svn://svn.chromium.org/blink/trunk@175002 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=esprehn@chromium.org
BUG=164167

Review URL: https://codereview.chromium.org/307723002

git-svn-id: svn://svn.chromium.org/blink/trunk@174999 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Just giving up on this test, it tried to work around windows oddity
but we clearly still don't understand what windows is doing
so just skipping the test.

Review URL: https://codereview.chromium.org/305613003

git-svn-id: svn://svn.chromium.org/blink/trunk@174998 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Per spec, after an error the |result| should always be |undefined|. Chromium was yielding |null| or an obsolete value instead.

BUG=378411

Review URL: https://codereview.chromium.org/307653004

git-svn-id: svn://svn.chromium.org/blink/trunk@174997 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/303653008

git-svn-id: svn://svn.chromium.org/blink/trunk@174996 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There used to be a similar cache before r168864. The old cache
system did not survive the refactoring, which caused a measurable
performance degradation on several mobile platforms.  This change
reinstates it in a refactored form.

BUG=354565
TEST=jsgamebench telemetry on android

Review URL: https://codereview.chromium.org/297293004

git-svn-id: svn://svn.chromium.org/blink/trunk@174995 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When porting the original srcset parser from WebKit, the code was split from
HTMLParserIdioms into a separate file - HTMLSrcsetParser.
The Apple copyright notice of that code was mistakenly not copied to the new file.
This CL corrects this.

BUG=
TBR=pdr

Review URL: https://codereview.chromium.org/305653007

git-svn-id: svn://svn.chromium.org/blink/trunk@174994 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045

Review URL: https://codereview.chromium.org/305623007

git-svn-id: svn://svn.chromium.org/blink/trunk@174993 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When subpixel font scaling is enabled text runs are positioned at
subpixel boundaries on the x-axis and thus there is no reason to snap
the x value.
We still round the y-axis to ensure consistent line heights.

BUG=164167
R=leviw@chromium.org, mstensho@opera.com

Review URL: https://codereview.chromium.org/300623007

git-svn-id: svn://svn.chromium.org/blink/trunk@174992 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I'd like to drive this number down to zero. Having a list of issues to
drive down is the starting place.

Mostly this just requires exposing a few more bits from builders and
loader. Otherwise, it's just going through the motions of loading
each result for testtype/group combination and seeing which ones
fail.

NOTRY=true

Review URL: https://codereview.chromium.org/293393006

git-svn-id: svn://svn.chromium.org/blink/trunk@174991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In theory, this case should never happen, but clearly there's
a bug somewhere. I don't have time to dig into the bug right now,
so just bandaid over it by returning the empty string. This will
mean the old data is lost, since we basically treat this as an
empty file, but at least we start collecting the new data.

We'll still log the error though, so we can grep the log to find
these cases in the future and fix them.

BUG=377594
NOTRY=true

Review URL: https://codereview.chromium.org/298163003

git-svn-id: svn://svn.chromium.org/blink/trunk@174990 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The under-repaint occurs in non-RAL mode when an object needs both
repaint and non-full layout. https://codereview.chromium.org/265703012/
caused this because it skips the direct repaint() call in the above
case.

BUG=376306
TEST=fast/repaint/change-text-content-and-background-color.html

Review URL: https://codereview.chromium.org/298973011

git-svn-id: svn://svn.chromium.org/blink/trunk@174989 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When click() method is called, previously we change the active status
of the element to true and then back to false. This doesn't change
anything for a button (or other elements that status doesn't change
after click()) but causes a repaint.

Don't change active status when click() method is called. (Elements
that status changes after click() call (e.g. checkboxes) will still
repaint.)

This doesn't change how we handle real mouse down/up/click events.

BUG=369358
TEST=fast/repaint/button-checkbox-click-method-repaint.html
TEST=fast/events/button-mouse-active.html # ensures :active is correct on real mouse down events.

Review URL: https://codereview.chromium.org/291563009

git-svn-id: svn://svn.chromium.org/blink/trunk@174988 bbb929c8-8fbe-4397-9dbb-9b2b20218538

V8 now implements Isolate::RunMicrotasks() in C++, which means its callers
no longer need to enter V8 Context::Scope before calling it. This simplifies
WebCore::Microtask::performCheckpoint, and gets us one step closer to ditching
V8PerIsolateData::ensureDomInJSContext().

This patch also gets rid of most of the microtask-related logic in
ScriptPromiseResolverWithContext, allowing WebCore::Microtask::performCheckpoint
to be the only code in Blink that calls Isolate::RunMicrotasks().
Instead of triggering microtask delivery directly, or via the RunMicrotasksTask,
ScriptPromiseResolverWithContext now utilizes V8RecursionScope to "simulate"
a JavaScript stack (from Blink's point of view). In workers, this will
result in a RunMicrotasks() call when the V8RecursionScope is destructed.

There are still two FIXMEs:
  - The V8RecursionScope discussed above would be unnecessary if there were
    a WebThread::TaskObserver on worker threads to handle microtask-running
    at the end of each task.
  - ensureDomInJSContext() is still needed in order to instantiate the v8::Functions
    that are passed into Isolate::EnqueueMicrotask(). Fixing this will require
    more work on the V8 side to allow passing in a C++ callback directly.

BUG=374772

Review URL: https://codereview.chromium.org/303693005

git-svn-id: svn://svn.chromium.org/blink/trunk@174987 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When creating a new GraphicsContextState the constructor initializes the state
with various default values. In GraphicsContext::realizePaintState we immediately
overwrite these values after creation. This patch adds a copy constructor to
GraphicsContextState to avoid that.

Even though this seems like a clear win, the benefits are not visible when
profiling. Looks like the overhead of the redundant initialization is
not very large. Still seems worth fixing though.

BUG=377687

Review URL: https://codereview.chromium.org/303613002

git-svn-id: svn://svn.chromium.org/blink/trunk@174985 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In the destruction of HTMLCanvasElement, we call
HTMLCanvasElement::existingDrawingContext(), whose behavior was changed
incorrectly in r162330 and was triggering the allocation of an ImageBuffer
during tear-down.  This is not only wasteful, but it can trigger a
garbage collection because the creation of an ImageBuffer will increase
the amount of externallay allocated memory that is declared to V8.
Triggering a GC during the finalization of a garbage collected object
is bad.

BUG=378289

Review URL: https://codereview.chromium.org/303803002

git-svn-id: svn://svn.chromium.org/blink/trunk@174984 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Change the way clip rects are determined for multicol by using enclosing
IntRect instead of pixelSnappedIntRect to ensure that the colum contents
fully fits within the clip rect.

R=leviw@chromium.org, mstensho@opera.com

Review URL: https://codereview.chromium.org/300843010

git-svn-id: svn://svn.chromium.org/blink/trunk@174983 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We don't really need these classes anymore, we can just use methods on
ContainerNode. This gets us one step closer to completely eliminating
ContainerNodeAlgorithms which now only contains one shared method related
to SVGElementInstance and cleanup code that Oilpan will eliminate.

Review URL: https://codereview.chromium.org/305603003

git-svn-id: svn://svn.chromium.org/blink/trunk@174982 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Debug assertions in the GraphicsContext destructor were
dependent on object destruction order, which made them
incompatible with oilpan. The state validation logic
was refactored to make the state validation checks more
useful.

BUG=370793

Review URL: https://codereview.chromium.org/293963009

git-svn-id: svn://svn.chromium.org/blink/trunk@174981 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reduces methods exposed on the throttle class and makes
throttling details hidden to XMLHttpRequest class.

- Use dispatchProgressEvent also for loadstart event
- Remove "throttled" from method names
- Move if-clause to switch how to dispatch a ProgressEvent based on its
  name to XMLHttpRequestProgressEventThrottle::dispatchProgressEvent()
- Remove dispatchThrottledProgressEvent and just call
  m_progressEventThrottle.dispatchProgressEvent for each event
- Make XMLHttpRequestProgressEventThrottle::dispatchEvent() private

BUG=none

Review URL: https://codereview.chromium.org/301643002

git-svn-id: svn://svn.chromium.org/blink/trunk@174979 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Forgot to do this during my last gardening stint :(

BUG=369600
TBR=ojan

Review URL: https://codereview.chromium.org/305623006

git-svn-id: svn://svn.chromium.org/blink/trunk@174978 bbb929c8-8fbe-4397-9dbb-9b2b20218538

From private conversation with annevk - make the properties of the
TextDecoder object inspectable.

BUG=375847

Review URL: https://codereview.chromium.org/292243003

git-svn-id: svn://svn.chromium.org/blink/trunk@174977 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376770

Review URL: https://codereview.chromium.org/304503004

git-svn-id: svn://svn.chromium.org/blink/trunk@174976 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since HTMLImportsController controls the lifetime of HTMLImportChild
instances, there's no need for HTMLImportLoader to be ref-counted.
We can just let it be owned by HTMLImportsController, as well.

R=morrita
BUG=

Review URL: https://codereview.chromium.org/298023007

git-svn-id: svn://svn.chromium.org/blink/trunk@174975 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the first step of three in moving over EventTarget. The next step is to update the IDL of EventTarget to be WillBeGarbageCollected, and then to replace all RefPtr uses. Once all Node RefPtr uses have also been replaced, we can remove the ref-count from Node.

BUG=357163

Review URL: https://codereview.chromium.org/307433003

git-svn-id: svn://svn.chromium.org/blink/trunk@174973 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Prior to this change the webkit_unit_tests target did not enable the plugin for its compilation units.

TBR=eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/301543005

git-svn-id: svn://svn.chromium.org/blink/trunk@174972 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Trivial change.

R=haraken
BUG=358074
BUG=377364

Review URL: https://codereview.chromium.org/298293008

git-svn-id: svn://svn.chromium.org/blink/trunk@174971 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mechanical change, mostly bindings/core/v8, a few bindings/modules/v8.
(This will make sorting custom bindings trivial.)

2 exceptions due to files generated outside of bindings:
V8HTMLElementWrapperFactory.h
V8SVGElementWrapperFactory.h
...which are generated by core_generated.gyp in gen/blink.
FIXMEs added.
(core_generated.gyp also requires qualifying all its paths,
but that's another kettle of fish)

R=haraken
BUG=358074

Review URL: https://codereview.chromium.org/300863004

git-svn-id: svn://svn.chromium.org/blink/trunk@174970 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After https://codereview.chromium.org/289973008/ lands,
there are no remaining call sites. And it's been a no-op
for over a month anyhow.

BUG=354688

Review URL: https://codereview.chromium.org/286263004

git-svn-id: svn://svn.chromium.org/blink/trunk@174969 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now an easy change, this correctly adds qualified paths based on component.

There are still other places to qualify (notably v8/custom), which I'll do
separately, so we can't yet remove the other dirs from core.gyp, but we're
close!

Also some test fixes due to use of invalid interface types, and lotta test updates.

R=haraken
BUG=358074
BUG=377364

Review URL: https://codereview.chromium.org/306543008

git-svn-id: svn://svn.chromium.org/blink/trunk@174968 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/H6lsGFqdy3Y/F2GlWvbl-TsJ

Review URL: https://codereview.chromium.org/303663004

git-svn-id: svn://svn.chromium.org/blink/trunk@174967 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Both of the counters are at 0%:
http://www.chromestatus.com/metrics/feature/timeline/popularity/86
http://www.chromestatus.com/metrics/feature/timeline/popularity/245

In other worlds, there's hardly anyone to see the deprecation message.

BUG=240252

Review URL: https://codereview.chromium.org/303473004

git-svn-id: svn://svn.chromium.org/blink/trunk@174966 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/-OvFrybkW1E/Ucrct3sm6foJ

Review URL: https://codereview.chromium.org/301563002

git-svn-id: svn://svn.chromium.org/blink/trunk@174965 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When finalizing the media element, its media player is also cleared
out. With Oilpan enabled, that media player object must not touch the
media element while destructing its "client", as it is not in a
valid state (its heap object member may have been finalized already.)

Arrange for that to not happen by having the media element enter a
'finalizing' state, which is explicitly checked for when the player
attempts to access the media element during destruction.

This is a shorter-term solution until the media player object itself
is moved to the Oilpan heap; http://crbug.com/378229 for handling that.

R=haraken@chromium.org,ager@chromium.org
BUG=377567
TEST=media/track/track-removal-crash.html
TEST=media/audio-delete-while-slider-thumb-clicked.html
TEST=http/tests/media/media-source/mediasource-closed-on-htmlmediaelement-destruction.html

Review URL: https://codereview.chromium.org/303593002

git-svn-id: svn://svn.chromium.org/blink/trunk@174964 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Method StyleResolver::pseudoCSSRulesForElement is used from both WebPlatform
(via window.getMatchedCSSRules) and inspector in its styles sidebar pane.
Due to security reasons, this method "lies" about css rules applied for
visited and unvisited links so that it is impossible to sniff user history.

This patch makes inspector to adjust method results so that it knows which
rules are actually applied and which are not.

FYI: The previous version of this patch is https://codereview.chromium.org/228673002/
It was reverted due to regression of :host rules, thus this patch adds
a test to verify them.

BUG=356999

Review URL: https://codereview.chromium.org/300693004

git-svn-id: svn://svn.chromium.org/blink/trunk@174963 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Follow up to Blink r174945.

TBR=amikhaylova@google.com, yurys

Review URL: https://codereview.chromium.org/307533006

git-svn-id: svn://svn.chromium.org/blink/trunk@174961 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Ever since border-image-width was implemented in

https://bugs.webkit.org/show_bug.cgi?id=67657

border-widths values haven't been scaled with the zoom level for SVG
elements. Remove the special casing since it doesn't seems to be any
good reason for having it. Firefox doesn't do anything of the sort and
there is no specification support for it.

BUG=377447

Review URL: https://codereview.chromium.org/302643002

git-svn-id: svn://svn.chromium.org/blink/trunk@174960 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=378222
R=alph@chromium.org

Review URL: https://codereview.chromium.org/297143011

git-svn-id: svn://svn.chromium.org/blink/trunk@174959 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=377723

Review URL: https://codereview.chromium.org/302783010

git-svn-id: svn://svn.chromium.org/blink/trunk@174958 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I'm going on leave for 11 weeks, and besides there's a suitable
mailing list for such notifications now.

TBR=rune@opera.com
NOTRY=true

Review URL: https://codereview.chromium.org/305673002

git-svn-id: svn://svn.chromium.org/blink/trunk@174957 bbb929c8-8fbe-4397-9dbb-9b2b20218538