- 04 Dec, 2020 40 commits
-
-
Charlie Hu authored
This CL renames 'feature policy' to 'permissions policy' in console messages. Bug: 1123116 Change-Id: Ia7a526e44ccc1d0eb3109f2fb86b12ad7ba2daec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513824Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#833788}
-
Toni Barzic authored
This is a reland of 2a07cc57 Original change's description: > Shutdown holding space delegates while device is suspended > > Some file systems are unmounted during device suspend (for example drive > FS), which was causing the holding space file system delegate's file > path removal detection to remove them from the holding space on device > suspend. To avoid this issue, holding space keyed service now observes > device suspend status and shuts down holding space delegates when the > device suspends. The delegates are re-initialized when suspend ends, > restoring the model from persistence again. > > BUG=1152924 > > Change-Id: Iffe4586bcb87f47d687ceeff0fc76e60a443c0d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568355 > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: David Black <dmblack@google.com> > Cr-Commit-Position: refs/heads/master@{#833515} Bug: 1152924 Change-Id: I4ef1fa83d684260e4ebf66fe4c01e9627e5c46af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573893Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#833787}
-
Findit authored
This reverts commit 5326cda9. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 833751 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzUzMjZjZGE5NmNhOTdlN2ZiMDdlYTBhMzNkODUyN2RmYmRkZmJiNWYM Sample Failed Build: https://ci.chromium.org/b/8861821025876153104 Sample Failed Step: compile Original change's description: > Patch in Fix For Protobuf Deserialization Bug > > This CL picks up a bugfix integrated into protobuf as part of commit: > http://cl/342360226 > > This fix is responsible for fixing a bug in the serialization code > when trying serialize/deserialize protobuf messages at the end of an > iostream > > Change-Id: I7608174a083b6b63c152c1250d3ccd1fd53914c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535667 > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Commit-Queue: Ryan Keane <rwkeane@google.com> > Cr-Commit-Position: refs/heads/master@{#833751} Change-Id: If9e7cb5da756a985bfc53fe03be0632e3cdbdef1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575436 Cr-Commit-Position: refs/heads/master@{#833786}
-
Ana Salazar authored
In the Holding Space's Screen Capture section, we display screenshots and screen recordings. At the moment, both previews display as still images. In order to differentiate between screenshots and screen recordings, we add a play icon over the screen recordings. Screenshot: https://screenshot.googleplex.com/9YVVkvvyAk7Duds Bug: 1144927 Change-Id: Id1614a867caa73676d24c9ab59289337fea88c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566051 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#833785}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ad70609509a9..6c80aebd0036 2020-12-04 henrik.lundin@webrtc.org Remove kwiberg@webrtc.org from OWNERS files 2020-12-04 hta@webrtc.org Relax check for unknown STUN attribute lengths 2020-12-04 mbonadei@webrtc.org Use RTC_HAS_MSAN to check for MSan builds. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1155459 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I71ccb08b12368aa4c81d113f911ace63db0a12cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574724Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833784}
-
Ryan Heise authored
Bug: chromium:1138593 Change-Id: Ie821d672487612933865610bfba722faf1bc6e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573679Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ryan Heise <heiserya@google.com> Auto-Submit: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#833783}
-
Abigail Klein authored
in SODAInstallerImplChromeOS. This fixes an overlooked nit whereby the SODAInstallerImpl was overriding a non-virtual destructor in its parent class, and the SODAInstallerImplChromeOS was not. Bug: 1055150 Change-Id: If039f7e046201bcc776f493338c0bffcea365a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572942Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#833782}
-
Patrick Noland authored
This change moves the implementation of revertChanges to LocationBarMediator. It also passes the call to selectAll directly to the UrlBarCoordinator, and implements the OnKeyListener interface in LocationBarCoordinator instead of LocationBarLayout. The latter change is because this listener needs to be able to call revertChanges, which LocationBarLayout can no longer do. Bug: 1147581 Change-Id: I5df4ec31997ed072f0d6040b7d96e595471ec741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552758 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#833781}
-
Michael Lippautz authored
Bug: 1056170 Change-Id: I0c3420dfb6d0fd978a25aee28c95b412d91a3bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572844 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#833780}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ab5821d0166f..f31b78e90e1e 2020-12-04 senorblanco@chromium.org Enable all remaining end2end tests on OpenGL ES backend. 2020-12-04 bclayton@google.com Remove legacy tint::transform API codepaths If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I8463b72d5670ffca8e141fd385c26f233b5b7760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574719Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833779}
-
Robert Sesek authored
Bug: 1153883 Change-Id: Ieb2ee69ba93e0469cbe307dfb1f12687a0a1a702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572379 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#833778}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d1cf5db4152d..88efddc6a162 2020-12-04 ulan@chromium.org Implement the unified V8 and CppGC metric computation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1154636 Tbr: wenbinzhang@google.com Change-Id: I08a55a2e486c3898a9f9dacd3ec377f3fc020df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574425 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833777}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4324.9-1606733211-benchmark-89.0.4342.0-r1 to 89-4324.9-1606733211-benchmark-89.0.4343.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I1aa38e3eb726be18675f14cb1f6a3409118a993d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574726Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833776}
-
Andrew Grieve authored
Plus minor tweaks: * --build-build-config -> --build * Fix --inner name mangling not removing __test_apk Bug: None Change-Id: I3cb77e9f12306d80cb1e4e2d3b2466c489f5a155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574656 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#833775}
-
Chris Buquicchio authored
CFMs currently rely on this behavior. It was removed in https://chromium-review.googlesource.com/c/chromium/src/+/2306918. BUG=b:167805373 TEST='Locally checked order of video capture devices on CFM devices.' Change-Id: I2dc348a88b6821e7cac257ecf9710ec1c5247942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573196Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Chris Buquicchio <cbuquicchio@google.com> Commit-Queue: Chris Buquicchio <cbuquicchio@google.com> Cr-Commit-Position: refs/heads/master@{#833774}
-
Andre Le authored
Add MultiDevice.SecureChannel.Nearby.MessageAction Bug: 1106937, 1150634 Change-Id: I91bc2801c9e35b8b041b4d4c39780ed4d9f32e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569117 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#833773}
-
Chris Hamilton authored
Catan team still uses these, and will be monitoring them in some upcoming experiments. Change-Id: Id6cda68e5b47cd36b2249bea8cb04bce3dcc2116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573461Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#833772}
-
Benoit Lize authored
Bug: 998048 Change-Id: Ie18db70f78188e4541aa4d5a0f44da2ce166524e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569664 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#833771}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4324.9-1606737320-benchmark-89.0.4342.0-r1 to 89-4324.9-1606737320-benchmark-89.0.4343.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2d1150fa7ab69793c68be4ef174795c86527d7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574727Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833770}
-
Keren Zhu authored
A comment-friendly doc version is available at http://doc/1jBT-aqlwb4I7_OH6xC4yX5sn8zlZTOXbfYiU4coG0yQ Bug: None Change-Id: I135f0ba144c437af6bd366625e8cc989c246d7a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571803Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#833769}
-
Brandon Wylie authored
Bug: 1123209 Change-Id: Id5d25db3cb60c2bac266ea84a6892475c467fedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573135Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#833768}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ab473c14..61f3e614 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaa861c5fc9f32cc910b0f628cd7439754c7cde8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572910Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833767}
-
Yifan Luo authored
Bug: 1116418 Change-Id: I4753f5f077a861501088ce6797d99402de4558de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574637Reviewed-by:
Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#833766}
-
Dominique Fauteux-Chapleau authored
This should address the concerns raised in crrev.com/c/2391514 without regressing crbug.com/1100902. Bug: 1151724, 1139050, 1100902 Change-Id: I2180278fec307555eb9714aed6f3644520838326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556587Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#833765}
-
Palak Agarwal authored
This is a reland of 5aea6042 New changes: - Visibility client needs to be set for parent widget in ChromeOS platforms which otherwise causes uninitialised memory error. Original change's description: > Implement the confirmation-box for getCurrentBrowsingContextMedia API. > > Rebased on top of https://chromium-review.googlesource.com/c/chromium/src/+/2502628 > > UI without audio capture: https://drive.google.com/file/d/1SA9vuDOkQjnioBfmAaiOjqoXGBUmVw22/view?usp=sharing > UI with audio capture: https://drive.google.com/file/d/1jcncgHsF6L_o3D5Jc3UJ6pkjwQAKtoVl/view?usp=sharing > > This change relates to the UI code that is added to support the new getCurrentBrowsingContextMedia API. > > This is an API for capturing the current tab. > > Design doc: > go/get-current-browsing-context-media > > Intent-to-Prototype: > https://groups.google.com/u/3/a/chromium.org/g/blink-dev/c/NYVbRRBlABI/m/MJEzcyEUCQAJ > > PR against spec: > https://github.com/w3c/mediacapture-screen-share/pull/148 > > > Bug: 1136942 > > Change-Id: I8e72023d944df3d7e996ad3acea7527c34569868 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489991 > Commit-Queue: Palak Agarwal <agpalak@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Elad Alon <eladalon@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831017} Bug: 1136942 merging Reland "Implement the confirmation-box for getCurrentBrowsingContextMedia API." This is a reland of 5aea6042 Original change's description: > Implement the confirmation-box for getCurrentBrowsingContextMedia API. > > Rebased on top of https://chromium-review.googlesource.com/c/chromium/src/+/2502628 > > UI without audio capture: https://drive.google.com/file/d/1SA9vuDOkQjnioBfmAaiOjqoXGBUmVw22/view?usp=sharing > UI with audio capture: https://drive.google.com/file/d/1jcncgHsF6L_o3D5Jc3UJ6pkjwQAKtoVl/view?usp=sharing > > This change relates to the UI code that is added to support the new getCurrentBrowsingContextMedia API. > > This is an API for capturing the current tab. > > Design doc: > go/get-current-browsing-context-media > > Intent-to-Prototype: > https://groups.google.com/u/3/a/chromium.org/g/blink-dev/c/NYVbRRBlABI/m/MJEzcyEUCQAJ > > PR against spec: > https://github.com/w3c/mediacapture-screen-share/pull/148 > > > Bug: 1136942 > > Change-Id: I8e72023d944df3d7e996ad3acea7527c34569868 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489991 > Commit-Queue: Palak Agarwal <agpalak@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Elad Alon <eladalon@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831017} Bug: 1136942 Change-Id: I441da788396f9b74253df7d7bb2573483502688f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561622Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Palak Agarwal <agpalak@chromium.org> Cr-Commit-Position: refs/heads/master@{#833764}
-
Abigail Klein authored
Introduce a Live Caption toggle image button in the volume slider. This UI follows the Android pattern of offering a Live Caption button in the volume controls, enabling easy access to toggle the feature on and off. This CL does a few things: 1. Moves the live_caption icon from chrome/app/vector_icons to components/vector_icons so that it can be shared with chrome and ash, and renames it as live_caption_on. 2. Introduces a new icon, live_caption_off. 3. Introduces a LiveCaptionButton in the UnifiedVolumeView. 4. Since the new LiveCaptionButton shares code with the MoreButton, introduces a new template, UnifiedVolumeViewButton, which contains the shared ink drop and color code. 5. Defines the kLiveCaptionEnabled pref name in ash (synced with the chrome pref). 6. Introduces a new toggle_background to the ToggleImageButton which allows buttons to toggle their background color when the toggled state changes. Screenshots: Live Caption off: https://screenshot.googleplex.com/BRoxxFsssg9f6ix Live Caption on: https://screenshot.googleplex.com/58TfboB96UU273Z Bug: 1055150, 1111002 AX-Relnotes: N/A (feature has not launched yet) Change-Id: Ie8b3736eaee3a2fc4ba841de8d98dd8c95495e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571481Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#833763}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a58c14025a27..fa8d6915cbbf 2020-12-04 jvanverth@google.com Remove Metal Perf bots running on MacOS 10.13. 2020-12-04 johnstiles@google.com Simplify various logic around multi-dimensional arrays. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I36cdd6615adcfff3a3d89c47389579a69ba23ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574426Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833762}
-
Stepan Khapugin authored
Reenables this test. It should now pass. Fixed: 1037651, 1029255 Change-Id: I982814eb592f227562947fdcd25972885739d1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574936 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#833761}
-
Yu Su authored
Change-Id: I4c5fdbd3648e088353db5491084c3247b0f40968 Bug: 1155490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574478Reviewed-by:
Ben Goldberger <benwgold@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Commit-Queue: Yu Su <yusuyoutube@google.com> Cr-Commit-Position: refs/heads/master@{#833760}
-
Vladimir Levin authored
This patch adds a transition directive class to viz. It isn't currently used outside of unittests, but will be referenced in cc and indirectly from Blink in order to construct the right directive for viz to execute. R=kylechar@chromium.org Bug: 1150461 Change-Id: I9cbe63507148405b0a363ee6d957d76b1a18b34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568985 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#833759}
-
rbpotter authored
This largely seems to create a bunch of noise for screenreaders whenever the preview is reloaded, unless another element is explicitly focused. The message is also generally unhelpful, e.g. Chrome Vox reads out the name of the underlying WebContent, iframe, and the names of all the plugin buttons, which seems unlikely to be useful. Bug: 987370 Change-Id: I97b7d25b859e50bd51b82ffa6760571ae8319a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573881Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#833758}
-
Zhaoliang Ma authored
Bug: 1126811 Test: apprtc on atlas Change-Id: I903dac22f3504f2cc142e3fcad1feb93b12ed58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574069Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Zhaoliang Ma <zhaoliang.ma@intel.com> Cr-Commit-Position: refs/heads/master@{#833757}
-
Robert Sesek authored
Bug: 1153883 Change-Id: I54580da3620bc97a5dd5d812ff798fc7aaeedf26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571812Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833756}
-
Norman Rosas authored
//components/w…, and//components/z.., also removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I2ebce402c335ad9d8f54120ba41860832eeef621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570554 Auto-Submit: Norman Rosas <normando@google.com> Commit-Queue: Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Cr-Commit-Position: refs/heads/master@{#833755}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8e12f9222902..b917ab64e84b 2020-12-04 tvanderlippe@chromium.org Update third_party/wasmparser to 4.0.0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I965621fc0a40a702c44e0a7f979f1cf05bdeb8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573526Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833754}
-
Camille Lamy authored
Add a WebFeature use counters tracking embedding of cross-origin subframes without a CSP frame-ancestor header. Bug: 1153118 Change-Id: Idbffecd04bb90ad8278ef945fb31a5d2d1bd20f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562300 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#833753}
-
Yifan Luo authored
Reversed order of fuzzer proto file to make the corpus files more useful. Bug: 1116418 Change-Id: I8f2f789b014ec252a072dfbb037e543f0a39b3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574636 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#833752}
-
Ryan Keane authored
This CL picks up a bugfix integrated into protobuf as part of commit: http://cl/342360226 This fix is responsible for fixing a bug in the serialization code when trying serialize/deserialize protobuf messages at the end of an iostream Change-Id: I7608174a083b6b63c152c1250d3ccd1fd53914c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535667Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Ryan Keane <rwkeane@google.com> Cr-Commit-Position: refs/heads/master@{#833751}
-
Gavin Williams authored
Show the new status icons for local CrOS enterprise destinations in the dropdown and in the destination dialog. http://screen/Ar4TwJzsnGBmQeo http://screen/49UeCL7e9KMmuUy Bug: 1146550 Change-Id: Iaa5c2933db43f32fe054619863b71c7483af62b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572396Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#833750}
-
Josh Nohle authored
At login, and if the user has Nearby Share enabled, record the user's chosen degree of visibility to their contacts, which was selected during onboarding or updated in settings. Note: Any changes made to the visibility setting will not be logged until the next sign-in. Bug: 1105579 Change-Id: I5f78dbdc841b83d09a2e30c6c1b68c813453df3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568535Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#833749}
-