- 21 Oct, 2018 21 commits
-
-
Alan Cutter authored
Subclasses of BrowserNonClientFrameView that contain a HostedAppButtonContainer child view have duplicate logic outside of creation, colors and layout. This CL dedupes the logic involved in having a HostedAppButtonContainer in preparation for adding one to BrowserNonClientFrameViewMac. Bug: 895690 Change-Id: If2e5d58af58cd72ea9d0902d3a15f3375a9e1585 Reviewed-on: https://chromium-review.googlesource.com/c/1288092Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#601427}
-
Ryan Sturm authored
This is a reland of 310c6fa1 This was caused by a CL that landed on Friday morning that was missing a RunUntilIdle (that was added for the rest of the tests in the file). https://chromium-review.googlesource.com/c/chromium/src/+/1289086 added the failing test. The delta for the reland is adding a RunUntilIdle. Original change's description: > Switching Previews triggering from the IO thread to the UI thread > > This CL moves previews triggering from the IO thread > (ChromeResourceDispatcherHostDelegate) to the UI thread > (ChromeContentBrowserClient). The new call sites occur in > NavigationRequest and update the previews_state in > CommonNavigationParams held by the NavigationRequest directly. This > means PreviewsDeciderImpl is being moved to the UI thread. > > Significant changes: > - PreviewsDeciderImpl is now owned by the PreviewsUIService instead of > profile IO data. > - PreviewsUserData is now entirely a UI thread notion. For now, we use > PreviewsUITabHelper to manage its lifetime, but it could move to > NavigationHandle (if NavigationHandle already supported UserData, > that solution would be ideal). > - ChromeNavigationData is update to remove PreviewsUserData and > PreviewsState (the latter has moved into PreviewsUserData and there is a > notion of Allowed PreviewsState and committed PreviewsState) > - Offline Previews committed checks use the OfflinePreviewsTabHelper > instead of PreviewsUserData now that we are on the same thread. > - Cleanup on ResourceRequestInfo to remove PreviewsState setter as well > as cleanup to remove PreviewsState from being passed back out of the > loader code into NavigationRequest. > - There is a TODO to re-evaluate PreviewsState during redirects, which > will *not* be plumbed into the network service, so DataReductionProxy > Previews will not be updated. > > Bug: 842233 > Change-Id: I80a3044a4c84734b877f8ebcbe5a4bb2c2900dbb > Reviewed-on: https://chromium-review.googlesource.com/c/1266196 > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Jian Li <jianli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601298} Bug: 842233,897385 Change-Id: I4ff029a45edf3a1ac84f409fb3326d6767f03fd8 TBR=jochen@chromium.org,clamy@chromium.org,tbansal@chromium.org,mmenke@chromium.org,jianli@chromium.org Change-Id: I4ff029a45edf3a1ac84f409fb3326d6767f03fd8 Reviewed-on: https://chromium-review.googlesource.com/c/1292955Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#601426}
-
Peter Kotwicz authored
This CL changes the WebAPK autoplay logic to canonicalize the scope URL prior to checking whether the document URL is within the WebAPK's scope. The scope passed to the renderer comes from a <meta-data> tag in the WebAPK's Android Manifest. The value of the scope <meta-data> tag comes from the scope URL sent by Chrome to the WebAPK Minting server during WebAPK creation (which is canonicalized). Right now the <meta-data> tag in the Android Manifest is always canonicalized. We should not assume this. Change-Id: I9982420fda7da53ca9a77ed90e9f35de7b00bd28 Reviewed-on: https://chromium-review.googlesource.com/c/1068252 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#601425}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c226492507a..47133fdb992a git log 0c226492507a..47133fdb992a --date=short --no-merges --format='%ad %ae %s' 2018-10-20 jvanverth@google.com ColorType fixes for wacky_yuv_textures. Created with: gclient setdep -r src/third_party/skia@47133fdb992a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: Ia4ed4a9c06331797744bafbc16f8b54c2896db42 Reviewed-on: https://chromium-review.googlesource.com/c/1292801Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601424}
-
Francois Doray authored
The new API supports getting the creation time of any process (not just the current process). This will be used to get a (pid, creation time) pair identifying a renderer process and sending it to the resource coordinator service via Mojo. Ideally, we would send a process handle, but this is not supported by Mojo, and if it was, it would have undesirable security implications. Bug: 885293 Change-Id: Ic3a24c93e5352767eb8e6fb025eeacdbc0d23109 Reviewed-on: https://chromium-review.googlesource.com/c/1273607Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#601423}
-
Antonio Gomes authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. This CL migrates chromedriver and its respective unittests away from URLFetcher. Note that because of the multithreaded nature of the code, the natural approach was to simply call SharedURLLoaderFactory::Clone and pass the "info" mojo handle accross threads, until the operational thread. However, the structure holding this mojo handle is called/passed from (i) an indirect chain of BindRepeating calls, (ii) various threads. Given that network::mojom::URLLoaderFactoryPtrInfo and network::SharedURLLoaderFactoryInfo are both move-only object (which does not comply with BingRepeating) and that raw a network::SharedURLoaderLoader instance must operate on the same thread it was created on, this CL comes up with a local thread-agnostic "wrapper" to mojom::URLLoaderFactory, named WrapperURLLoaderFactory (see chrome/test/chromedriver/server/http_handler.cc). Its instance replaces URLRequestContextGetter instead across threads and BindRepeating chains just fine. This CL is based on the original work of Sergio Villar (svillar@igalia.com) on [1]. TBR=johnchen@chromium.org (John +1'ed the original incarnation of this CL at [1]). [1] https://crrev.com/c/1221256 Bug: 872887 Change-Id: I21386edb04b25438ba3aa40dd5ecc1461342aecf Reviewed-on: https://chromium-review.googlesource.com/c/1289849 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#601422}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I9b8f18ea1cd663e98f956cbe45675794a0e9ff12 Reviewed-on: https://chromium-review.googlesource.com/c/1292970Reviewed-by:
-
Victor Vasiliev authored
Merge internal change: 217957275 R=rch@chromium.org Change-Id: I07eef67fd54b96f37d6ee234c5cfb247a9472c74 Reviewed-on: https://chromium-review.googlesource.com/c/1292443Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#601420}
-
Malay Keshav authored
This patch adds an API to gfx::Canvas to draw skottie directly on the backing canvas. It also removes the bitmap rasterization of each animation frame from the ui thread and offloads it to cc. Bug: 890224 Change-Id: Ibf8d9b682428be26c12caa4cccaae9bd53bb255a Component: gfx, canvas, skia vector animation Reviewed-on: https://chromium-review.googlesource.com/c/1292527 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601419}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b8eec4a4ab53..d4f07760e9ee git log b8eec4a4ab53..d4f07760e9ee --date=short --no-merges --format='%ad %ae %s' 2018-10-20 jmadill@chromium.org GL: Apply dirty bit mask on sync state. Created with: gclient setdep -r src/third_party/angle@d4f07760e9ee The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I0f9ea47bc1738ec75f18d2e8ab6f31fe8defbf7e Reviewed-on: https://chromium-review.googlesource.com/c/1292969Reviewed-by:
-
Wez authored
This test leaks process-global GCPhase state, potentially crashing tests which run later in the same process, e.g several IncrementalMarkingTest suite tests expect GCPhase to be None when they start executing. Bug: 897400, 879806 Change-Id: I8071fded78038b9c77a4cb6d3a5e1b258a4bbd49 Reviewed-on: https://chromium-review.googlesource.com/c/1292895 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#601417}
-
Jongheon Kim authored
This patch is updated duplicate code of tooltip text and accesible name Bug: 890465 Change-Id: I74ba045aab1f5668db0e10c279c8ce99f993238d Reviewed-on: https://chromium-review.googlesource.com/c/1278076 Commit-Queue: Jongheon Kim <sapzape@gmail.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#601416}
-
Mounir Lamouri authored
Fixing the following issues: - take into account AudioContext stopping; - removes 10 seconds limitation. Bug: 897451 Change-Id: I63b22fc20ded193cd032e30722ab35571adba56c Reviewed-on: https://chromium-review.googlesource.com/c/1292378 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#601415}
-
Mike Klein authored
I've replaced two ref tests with image tests. The diffs there are both the same root cause, basically moving from one approximation of a rounding divide by 255 to another, and some low bits move. I could have updated the ref tests with new numbers, but if you look at them, they're basically bitmaps already. And we actually use different div255 approximations per platform, so I think it's a little more "right" to make these image tests. (If we were running ARM layout test bots, we'd see slightly different results than these Intel ones.) Weeeeeellllllll.... that was my plan, but I ran into an issue where Macs would end up with a slightly different expected.txt file, and I don't really know what I'm doing with those, so I've switched it back to a ref test updated with the new colors. :( Change-Id: I20cbfa886f71cb509d5e60e0d7cd40af5bca13ea Reviewed-on: https://chromium-review.googlesource.com/c/1291810 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#601414}
-
Fredrik Söderquist authored
Plumb HitTestLocation into clip-path handling and LayoutSVGShape::*Contains. Change-Id: Ibd4e433e868ac427e637f906ff3d778fd33e1a80 Reviewed-on: https://chromium-review.googlesource.com/c/1291409Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#601413}
-
Ehsan Karamad authored
This CL converts the current "animations" feature policy to "layout-animations" feature policy: the former policy is about blocking non-composited animations whereas the new policy only blocks a handful of CSS animations which are known to (potentially) cause re-layout and are also widely used. The current set of CSS properties considered in the new policy is: {bottom, height, left, right,top, width}. Bug: 874218 Change-Id: I97f08ce6b2b902c7057ea821416a9c145d26f068 Reviewed-on: https://chromium-review.googlesource.com/c/1235055 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#601412}
-
Ehsan Karamad authored
This is a reland of 02cb80e6 The issues seems to have been the test case {'a', 'b', 'b'} where apparently the failed navigation still fires a load event which might arrive sooner than fallback update. The reland modifies the test file to suppress sending 'OBJECT_LOAD' event from the test page. Original change's description: > Implement fallback content for RemoteFrameOwner > > RemoteFrameOwner does not implement the logic for fallback content. This > means if a cross-origin navigation fails with some error, the owner > element (in this context, <object>) in the parent process does not get > notified and will not use its fallback content (instead the frame might > show an error page). > > When the <object> has fallback content, it should always use that over > the frame's error message. To support this matter, this CL implements > fallback methods in RemoteFrameOwner. Essentially, > > * When <object> creates a local frame, the corresponding frame tree > node will be marked as the type that "can" render fallback content. This > will propagte everywhere using FrameReplicationState. > > * When the provisional loading of a frame fails, RemoteFrameOwner will > notify the browser through the current proxy for navigation. The browser > then uses the parent frame to notify the renderer process that the owner > element should render its own fallback content. > > * If the <object> does not specify fallback, the navigation to error > page commits and the error page is shown. > > * When the <object> renders its own content, the remote frame stays > alive. This is a bug but not a new one; It will be fixed in future CLs. > > Bug: 853140 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: Icad3934ccfc1823c0cdecd8e1223e6370ea4b3bb > Reviewed-on: https://chromium-review.googlesource.com/c/1105635 > Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Reviewed-by: Wei Li <weili@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601194} TBR=dcheng@chromium.org,alexmos@chromium.org,weili@chromium.org Bug: 853140 Change-Id: Ib1594aa642ea238f745fd29d191818fddc503afc Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1292899Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#601411}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/91b0f1063bdf..410c469a02ae Created with: gclient setdep -r src-internal@410c469a02ae The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I082bcad16b0770c4256cd13c0415236859dc78f9 Reviewed-on: https://chromium-review.googlesource.com/c/1292799Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601410}
-
Christopher Cameron authored
With MacViews, it is now very rare to actually need a RenderWidgetHostViewMac to have its own compositor. The only circumstances where this happens are - content shell - popup windows (the date/time picker) - tab capture of backgrounded tabs Remove the concept of having a "detached" compositor, and simplify the transitions between states. This change will introduce flashes to paths that rely on the RenderWidgetHostViewMac having its own compositor (which are now vanishingly rare). Change-Id: I0feeec67a42f05de05aa4d72fe9af93f033d9d64 Reviewed-on: https://chromium-review.googlesource.com/c/1292377 Commit-Queue: ccameron <ccameron@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601409}
-
Saman Sami authored
Sometimes EmbedSurface is called right before WasShown when the tab is hidden. When frame evictor is notified of this new surface, it might immediately evict it because it doesn't know the tab will be visible soon. This will result in an evicted surface getting embedded which will show blank. Do two things: - Only call SwappedFrame when the tab is visible so don't have the problem mention above. Generally there is no point in calling SwappedFrame when it's invisible because even though a new id is allocated, there will not be any CompositorFrames submitted to this surface until the tab is shown, so there is no point in notifying the frame evictor. - Notify RHWVAndroid via WasEvicted when the surface is evicted so that it can allocate a new id for the next time it's shown. Bug: 896633,893731 Change-Id: I6fbc339f606d70e65ecc79b0f74bcd44133bd4fc Reviewed-on: https://chromium-review.googlesource.com/c/1289953 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I4859bb33a11bff11c65a9568155e3fb114039193 Reviewed-on: https://chromium-review.googlesource.com/c/1292381Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#601407}
-
- 20 Oct, 2018 19 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/773e141a83e3..0c226492507a git log 773e141a83e3..0c226492507a --date=short --no-merges --format='%ad %ae %s' 2018-10-19 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 bc6f52f36d5f..b8eec4a4ab53 (6 commits) Created with: gclient setdep -r src/third_party/skia@0c226492507a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: Iefdc61468817dea12cdda2a769ee8dedf5e94f3d Reviewed-on: https://chromium-review.googlesource.com/c/1292795Reviewed-by:
-
Peter Kotwicz authored
This CL reverts https://crbug.com/307333 for WebAPKs but not webapps. That CL made webapps reload when a user: - navigated back to a webapp via Android Recents AND - the webapp had been killed (which means that it is likely that a long time elapsed since the webapp was launched has passed) A WebAPK user is using window.history.pushState() to cache that a web page was reached by launching a WebAPK instead of by navigating on the web. The behaviour introduced in https://crbug.com/307333 was preventing the history state from getting restored when the user navigates back to the WebAPK via Android recents and Chrome has been killed. The rationale for reverting the behaviour for WebAPKs but not webapps is that WebAPKs are supposed to be sophisticated apps. Reloading the page takes control away from web developers. BUG=888100 Change-Id: Icb4803b0ee8b3444e0aade2acc2473b8ce1c23b7 Reviewed-on: https://chromium-review.googlesource.com/c/1275290 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#601405}
-
Khushal authored
Since skia's internal caching is keyed on text blobs, its important to reuse the same object. Make sure we cache text blobs in the ServiceTransferCache to get a cache hit in skia. R=enne@chromium.org Bug: 894200 Change-Id: I8808d649ca3520211d034e07e7d4670ffb39094c Reviewed-on: https://chromium-review.googlesource.com/c/1292722 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#601404}
-
Ahmed Fakhry authored
To avoid confusion when there is no internal keyboard connected: - We should not show the option to remap the internal "Search" key since that key doesn't exist. - We should also avoid labeling the options to remap the external meta keys as "External Meta" or "External Command", and just say "Meta" or "Command" as "External" here is redundant. TBR=stevenjb@chromium.org BUG=890522, 890950 TEST=Expanded existing tests. Reviewed-on: https://chromium-review.googlesource.com/c/1253022Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#601403}
-
David Benjamin authored
This got fixed by recent work to be pickier around function pointers. Bug: 719699 Change-Id: I684c0ee1d9866ef5517fe983f6e86ab44fb16689 Reviewed-on: https://chromium-review.googlesource.com/c/1282202Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#601402}
-
Peter Kasting authored
At this point, normal/hybrid should behave identically to refresh, and touchable identically to touchable refresh. Bug: none Change-Id: I616e35e50a95d467c361bc40eacbb738a3368665 TBR: nektar Reviewed-on: https://chromium-review.googlesource.com/c/1287929Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#601401}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=timvolodine@chromium.org Bug: 681136 Change-Id: I98dd1c92df3d38301e0394e44cea06263f54beaf Reviewed-on: https://chromium-review.googlesource.com/c/1288512Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#601400}
-
Wez authored
Crash can locate particular entries in a stack by scanning for start & end markers with unusual values. We add start & end markers around the |str_stack| copy of the LogMessage string, created when we're about to crash the process due to a FATAL level log message. This was originally landed with review: https://chromium-review.googlesource.com/c/1201344 which was reverted because MSan bots (correctly) failed due to the test's scanning of uninitialized stack memory. Since the test can't avoid doing that, we simply disable it under both ASan and MSan. Bug: 802393 Change-Id: Icd87f258aeb9556ab8e68d3e3431e80c01f1d3f0 Reviewed-on: https://chromium-review.googlesource.com/c/1292597Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#601399}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/90b15ebffc98..91b0f1063bdf Created with: gclient setdep -r src-internal@91b0f1063bdf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I19f17d8611f627c323d6a840c897ad57bf21f845 Reviewed-on: https://chromium-review.googlesource.com/c/1292797Reviewed-by:
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286016 This CL was uploaded by git cl split. R=dpranke@chromium.org Bug: 753973 Change-Id: Ie5be77df8c85eff62c9e0bb7bee0e20bbc4c367a Reviewed-on: https://chromium-review.googlesource.com/c/1288172Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#601397}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Ia7a55dae442fdf272becf47532ad20dfd551e349 Reviewed-on: https://chromium-review.googlesource.com/c/1292374Reviewed-by:
-
Roberto Carrillo authored
Since our primary objective is to reduce the cycle time for repo-wide code coverage reports, we'd do better to have compilation and test running on separate builders. R=stgao,liaoyuke,jbudorick Bug: 896446 Change-Id: Ic8b7f6319b208405a310694134da6011b485d8f1 Reviewed-on: https://chromium-review.googlesource.com/c/1289075 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#601395}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0b3c5cb7. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26403 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cvazac@akamai.com, igrigorik@chromium.org: external/wpt/server-timing NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I82ab75f9adc69facefbfb1bd8a8b576c266115b6 Reviewed-on: https://chromium-review.googlesource.com/c/1292399 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#601394}
-
David Tseng authored
Bug: 896910 Change-Id: I7b8b08147943a214900e6b835ce7c45016167b22 Reviewed-on: https://chromium-review.googlesource.com/c/1292151 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#601393}
-
Dongseong Hwang authored
CL:1045256 calculates |uv_rect| of the primary plane in wrong way. It causes drmModeAtomicAddProperty failure. This CL fixes it. BUG=896945 Change-Id: I6e914707cb961e8294e8ddd160b75e48ae5a2b64 Reviewed-on: https://chromium-review.googlesource.com/c/1291590 Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by:
Dongseong Hwang <dongseong.hwang@intel.com> Cr-Commit-Position: refs/heads/master@{#601392}
-
Ahmed Fakhry authored
This reverts commit 4c097c39. Reason for revert: I found a bug in internal keyboard detection. I will reland with fix to be able to merge to M-71. Original change's description: > Hide option to remap internal search when no internal KB is connected > > To avoid confusion when there is no internal keyboard connected: > - We should not show the option to remap the internal "Search" > key since that key doesn't exist. > - We should also avoid labeling the options to remap the external > meta keys as "External Meta" or "External Command", and just say > "Meta" or "Command" as "External" here is redundant. > > BUG=890522, 890950 > TEST=Expanded existing tests. > > Change-Id: If979b80217298a5f6bb18be478aa2c457859a351 > Reviewed-on: https://chromium-review.googlesource.com/c/1253022 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599409} TBR=stevenjb@chromium.org,afakhry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 890522, 890950 Change-Id: I9cd4273a61c51751a20d8bbffbf7fffbb252246c Reviewed-on: https://chromium-review.googlesource.com/c/1292816Reviewed-by:
-
Jun Cai authored
This reverts commit 8e3e6c83. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=896603 Original change's description: > Network Service: Convert port_forwarding_controller.cc to mojo host resolver > > Bug: 874651 > Change-Id: I4762526cc8fc4dbf18512b8ab7fbeeda8434336d > Reviewed-on: https://chromium-review.googlesource.com/1184306 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Jun Cai <juncai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585658} TBR=caseq@chromium.org,mmenke@chromium.org,juncai@chromium.org,ericorth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874651, 896603 Change-Id: Iaeede103359aeb369589620ec10085dcf20311ee Reviewed-on: https://chromium-review.googlesource.com/c/1292824 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/51cc30c12411..648d28ad6257 git log 51cc30c12411..648d28ad6257 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 thaloun@google.com Media engine and channel support for per-channel dscp values, specified by RtpParameter Created with: gclient setdep -r src/third_party/webrtc@648d28ad6257 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I27cdd34c150d2be9e783f26da58977e3e7c0ff53 Reviewed-on: https://chromium-review.googlesource.com/c/1292793Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bd5d55eea5c0..9b771ac49bd2 git log bd5d55eea5c0..9b771ac49bd2 --date=short --no-merges --format='%ad %ae %s' 2018-10-20 derat@chromium.org Revert "chromeos_config: Reenable Tast on VM paladin builders." Created with: gclient setdep -r src/third_party/chromite@9b771ac49bd2 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I29869cd7fe4e250854738c290c9337dc859c67b3 Reviewed-on: https://chromium-review.googlesource.com/c/1292794Reviewed-by:
-
