- 12 Apr, 2018 40 commits
-
-
Istiaque Ahmed authored
Currently calling DictionaryValue::Set(??, bool) and ListValue::Append(bool) would result in calling int variant from the overloaded methods(!). This is confusing and can be a source of bugs. (The current suggested way is to explicitly call SetBoolean and AppendBoolean). There is only once place where this was happening, in extension_printer_handler.cc. Fix that code to use boolean variant, by using SetBoolean() method. This CL will also let us overload the bool variant in future. This CL - Provides an explicit "const char*" param overload. - Declares a bool overload but makes it inaccessible (= delete). This will - Make sure attempting to call DictionaryValue::Set with bool will fail compile (call to deleted member function 'Set'). So accidental introduction of such bugs won't be possible. - The char* variant will make sure we don't attempt to resolve bool to this pointer variant. - Give us the ability to remove GetBoolean/AppendBoolean. Bug: 831839 Change-Id: If61ce8a44799ff8e12957d5206baf74467655894 Test: Expect no behavior change, touches webui/print_preview FYI Reviewed-on: https://chromium-review.googlesource.com/1008870Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550196}
-
Adam Langley authored
The spec suggests aborting an operation when focus[1] is lost, but that's advice for site developers. I can't find anything in the spec about preventing background tabs from triggering operations. The cryptotoken extension refused to start a registration request, or to send a registration response to, anything but the active tab in the focused window. But background tabs could complete an authentication request. This change does something similar: it rejects both authentication and registration requests unless the requesting frame is in a focused window. It also performs that check before returning responses. This is slightly different from the cryptotoken behaviour because cryptotoken could only use what the extensions API exposed. For example, if the omnibox was focused, cryptotoken would complete a registration from the foreground tab but this code will reject it. I think this behaviour is better, and it's certainly far more inline with the content / browser separation. This change has been split from its tests, which will come in a future CL. [1] https://w3c.github.io/webauthn/#abortoperation Bug: 827266 Change-Id: If6e97dd6526e175f40718724eda21e3efd434f7f Reviewed-on: https://chromium-review.googlesource.com/991073 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550195}
-
Lukasz Anforowicz authored
Bug: 831671 Change-Id: Ib0de8b66ebe2963bf25cfde26ab8fef7e1070e56 Reviewed-on: https://chromium-review.googlesource.com/1008172 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#550194}
-
vasilii authored
Bug: 819626 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4ea56f1d4d7d12184b2fdfbdbc9c44330b72b94e Reviewed-on: https://chromium-review.googlesource.com/1007059 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550193}
-
Min Qin authored
For download service, we are going to pass a class that retrieves URLLoaderFactory. This CL defines a common interface for that purpose. And the implementation can support either a blob url or a network url. BUG=803135 Change-Id: I505e025fc54553753180f05b97fbd3c4b654253a Reviewed-on: https://chromium-review.googlesource.com/1007974 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550192}
-
Xi Han authored
This is the precursor step before creating a thread to start the ServiceManager before content_main_runner is running. It is because no thread is expected to be when the zygote process is forked. In this CL, we move the setup to ContentMainRunner::Initialize(). Bug: 740677,729596 Change-Id: I90e95cce8bc32be03c944aaa17f96c79d555e7cb Reviewed-on: https://chromium-review.googlesource.com/999741Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550191}
-
Henrik Boström authored
This adds RuntimeEnabled feature RTCUnifiedPlanByDefault (off by default even in LayoutTests) which overrides the default SDP semantics of RTCPeerConnection, and adds running external/wpt/webrtc/* as a virtual test suite with this flag enabled. The tests can be run as: virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/ The -expected.txt files are identical to the non-virtual versions. The only problem introduced with Unified Plan is that the following test times out: virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/ RTCPeerConnection-setRemoteDescription-tracks.https.html Bug filed: https://crbug.com/828866 And unlike external/wpt/webrtc/ RTCPeerConnection-setLocalDescription-answer.html, virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/ RTCPeerConnection-setLocalDescription-answer.html does not fail against the -expected.txt file. Bug: 828793, 828866 Change-Id: I51d86fc5a0388ae1d8bf5f8497f31795d205d5d2 Reviewed-on: https://chromium-review.googlesource.com/995278 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:Harald Alvestrand <hta@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#550190}
-
Francois Doray authored
This CL previously landed as https://chromium-review.googlesource.com/997892. It was reverted because of an access race in ChromeStorageImpl https://crbug.com/829122. This CL fixes the issue by deleting both callbacks on the origin sequence when they can't run. Before, there was always leak when an internal task posted by PostTaskAndReplyImpl didn't run. With this CL, PostTaskAndReplyImpl notices when its internal callbacks aren't scheduled and schedules deletion of all its internal state (including callbacks that didn't run) on the origin sequence via a DeleteSoon(). Note that a deletion scheduled via DeleteSoon() might not happen if Chrome is shutting down. R=gab@chromium.org Bug: 807013 Change-Id: I17abffd3e7afcc861c8c92dce30c14ce8629b125 Reviewed-on: https://chromium-review.googlesource.com/1006045 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
Corentin Wallez authored
Also fixup some documentation links for GPU optional bots. Also change a PRESUBMIT.py's master name for win_angle_rel_ng. TBR=kbr@chromium.org TBR=sky@chromium.org BUG=chromium:815092 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ifda505e121f67f922f19da466a37b7f6266cea05 Reviewed-on: https://chromium-review.googlesource.com/1008182Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#550188}
-
Devlin Cronin authored
Update profile_signin_confirmation_helper_unittest.cc and sync_extension_helper.cc to generate extensions with manifest_version 2. Bug: 816679 Change-Id: I302693e92b7925f900cd41b7fa3751a4a299a8cf Reviewed-on: https://chromium-review.googlesource.com/1008624Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550187}
-
Asanka Herath authored
The generate-quic-chain.sh scripts expects the latter. Also the line endings are not significant. R=jam@chromium.org, rch@chromium.org Change-Id: I6dc0a14bd2f3b7f7e1438ee6207dfbc53deb4eba Reviewed-on: https://chromium-review.googlesource.com/1007642Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
Thomas Tangl authored
This is a follow-up CL from crrev.com/c/998112, adding the sync-paused icon to the avatar button on Mac. Bug: 825533 Change-Id: Ia07908a362150f784ce91ef7a8dea96d2cea7b59 Reviewed-on: https://chromium-review.googlesource.com/1007135Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#550185}
-
Danyao Wang authored
This removes flicker in Omnibox that briefly exposes the internal URL when restoring session history. Virtual URL must be set on the pending item before calling |loadCurrentURLInWebView| because WebStateObserver::DidStartLoading event fires during this call, which triggers ToolbarModelDelegateIOS to update itself using the virtual URL of the pending item. Bug: 815248 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I260e251d90ad832120b908a61843fe30df261be3 Reviewed-on: https://chromium-review.googlesource.com/1003252 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#550184}
-
Moe Ahmadi authored
- This CL expands on the dynamic form filling logic by tracking the filling context for multiple forms, therefore allowing multiple dynamic forms on the same page to get filled, e.g., billing and shipping address forms on victoriassecret.com _ It also fixes a bug where previously filled fields were not being refilled even if their value was reset during the dynamic form change. - It also rewrites the JS logic in the test html files to eliminate race conditions and improve readability. Change-Id: I44681742820d5285e77a4e9e4a61917ae4bfc41e Reviewed-on: https://chromium-review.googlesource.com/1003381Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550183}
-
David 'Digit' Turner authored
This CL tries to document more internal GN build rules, as a preliminary for future patches that will perform refactoring of some of them. In particular to simplify the impressive java_library_impl() rule. Also perform a little cleanup, since this led to discover a few obsolete things: - Remove the 'manifest_entries' variable since it is never set, and its entries passed as --manifest-entry= arguments to javac.py, which doesn't support it! - Remove forwarding of the optional public_deps variable, in cases where it would never be used by the final rules that receive it (it was never being set by any upstream callers). - Remove un-needed passing of processors_javac which seems obsolete. - Move more variables in the (type == "android_apk") block of java_library_impl() to make it clearer that these are only used for android_apk() targets. BUG=830641 R=agrieve@chromium.org Change-Id: I489c1921d58bc9f649a5bc02cf630c36e607b20a Reviewed-on: https://chromium-review.googlesource.com/1007061 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#550182}
-
Maks Orlovich authored
Once NetLog moves to NetworkService, it'll be desirable to have the output files used for netlogs passed in from browser process, since sandboxing of network service process probably will limit where it can write on disk. base::File (mapped as mojo_base.mojom.File) is the preferred way of transferring files per https://chromium.googlesource.com/chromium/src/+/lkcr/docs/security/mojo.md#Use-structured-types This doesn't address actually passing in the file or configuring a separate in-progress directory for the bounded mode (assuming the network service will have some temp dir it can write to); that would be the next steps. Bug: 767450 Change-Id: I814d2fdf6d95016e32d08902038fc84b391411b8 Reviewed-on: https://chromium-review.googlesource.com/1005425 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550181}
-
Devlin Cronin authored
A bunch of extension unittests generate extension objects at runtime. Update these to generate extensions with manifest_version: 2. Where trivial, update these to use ExtensionBuilder (if they weren't already), which uses manifest v2 by default. Bug: 816679 Bug: 756488 Change-Id: Iec80a5dd288452e70e5dbdd1902180611f6bbcca Reviewed-on: https://chromium-review.googlesource.com/1007501 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550180}
-
Ken Rockot authored
Instances are explicitly stopped during Service Manager shutdown, but then "stopped" again during individual Instance destruction. That results in listeners being notified twice about each instance being stopped if they aren't stopped before Service Manager shutdown. This CL fixes that. Bug: 831386 Change-Id: I210c9ce07cfa386d39bba7aa42244e00519b6f81 Reviewed-on: https://chromium-review.googlesource.com/1008968Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#550179}
-
Robert Ma authored
The tests have unstable failure messages. Add these expectations in advance to unblock wpt-importer. TBR=kereliuk No-Try: True Bug: 832071 Change-Id: I4a1efcd869f3660f4a88d37e9a02bf4bc9f0ee40 Reviewed-on: https://chromium-review.googlesource.com/1010243 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#550178}
-
Christopher Grant authored
BUG= R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2db855f4a560e521537c5016f564aee69edc0073 Reviewed-on: https://chromium-review.googlesource.com/1007632Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#550177}
-
Adam Rice authored
Mark virtual/off-main-thread-websocket/http/tests/websocket/close-code-and-reason.html as flaky. BUG=831320 Change-Id: I388617a9d8269da334bfa3d1de1cdafbb8203efb Reviewed-on: https://chromium-review.googlesource.com/1009782 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#550176}
-
Fady Samuel authored
This reverts commit 3fb6e543. Reason for revert: This is blocking branch cut. We know we hit this case and we've collected some crash logs to sift through now. Original change's description: > Surface synchronization: Add diagnostic CHECK > > Current evidence points to a race in cc that is causing surface invariants > violations (No invariants violations detected in LayerTreeHost but detected > in ClientLayerTreeFrameSink). > > My suspicion is viewport is updated out of sync with LocalSurfaceId and > device scale factor. > > This CL adds a diagnostic CHECK between the pending and active LayerImpls to > attempt to detect the race and produce a better stack trace. The invariant > we want to test here is if active tree has an invalid viewport (viewport has > changed), then the LocalSurfaceId MUST change. > > Bug: 672962 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I975c9dfb9c86c292d7aac052bac01510e6efb1c2 > Reviewed-on: https://chromium-review.googlesource.com/989851 > Reviewed-by: enne <enne@chromium.org> > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547457} TBR=enne@chromium.org,fsamuel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 672962 Change-Id: Id1ad5997e12b7f966df5f7b034bd5a30baa5ae60 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1008642Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#550175}
-
Takumi Fujimoto authored
This feature is getting rolled out on M66. Enable it by default for M67. Bug: 758005 Change-Id: Id96a86f8e7140f61496b8bfcf7ac5c4f3e00b56a Reviewed-on: https://chromium-review.googlesource.com/1003519Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#550174}
-
John Abd-El-Malek authored
Bug: 825242 Change-Id: I9e674841ca4199d53b9b50f12050cb4d085daa10 Reviewed-on: https://chromium-review.googlesource.com/1007010Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#550173}
-
jdoerrie authored
This change implements comparisons of base::spans with different types. This is useful to compare spans that only differ in their cv qualifiers, or whose different types allow comparison (e.g. int and double or std::string and base::StringPiece). Comparisons across types is a recent addition to the std::span proposal and was not part of P0122R6. Bug: 828324 Change-Id: Ia65a027c6b4a141f1a6dad11ba1d7699c7ed6f8c Reviewed-on: https://chromium-review.googlesource.com/1006580Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#550172}
-
Fady Samuel authored
This reverts commit 79edda64. Reason for revert: Reverting before branch point. Original change's description: > Reland "Surface synchronization: Add a diagnostic CHECK in ClientLayerTreeFrameSink" > > This is a reland of 119455cb > > Original change's description: > > Surface synchronization: Add a diagnostic CHECK in ClientLayerTreeFrameSink > > > > There's a race in cc somewhere from commit to draw. I don't know exactly > > how to repro the race yet even though I have a high probably fix. This > > CL is intended to catch the race in the wild and produce a stack trace > > in a crash log. Hopefully from there we can acertain repro steps. > > > > Once repo steps are produced locally (either via user interaction or > > unit test) then this CL will be reverted. > > > > Bug: 672962 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > > Change-Id: I3bce066591e15d5c3aac7d4c8685dce411e284b7 > > Reviewed-on: https://chromium-review.googlesource.com/973987 > > Reviewed-by: Saman Sami <samans@chromium.org> > > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#544834} > > Bug: 672962 > TBR: samans@chromium.org > Change-Id: I880540f3f00c419efb4055007787e86f4722d675 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/981154 > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545994} TBR=fsamuel@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 672962 Change-Id: I02cc346dddda60a02e9233ec6fcb7c9df50e1d8a Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1008610Reviewed-by:
-
Ramya Nagarajan authored
The 'Emoji & Symbols' item is part of the context menu for editable text fields. This adds an emoji icon to be displayed along with the menu item text. https://screenshot.googleplex.com/Css3YDJuuvX For more details, see http://go/chrome-emojisertion. Bug: 827404 Change-Id: I0f0f660803d2c871fcf157b905210a49bd14f140 Reviewed-on: https://chromium-review.googlesource.com/1007896 Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#550170}
-
Lutz Justen authored
Refactored CloudPolicyValidator so that the base class doesn't expect the policy_value() to be a protobuf. This is a preparation for the support of extension policy for Active Directory managed devices, where the policy_value() is a JSON blob. Also removed the static Create methods. There's no reason to have them as one can use the constructor directly. The rest is clang format. BUG=chromium:735100 TEST=Trybots Change-Id: Ic952c2cd00e945910f62d0ad08839282818d1d1e Reviewed-on: https://chromium-review.googlesource.com/1002654Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#550169}
-
Christopher Grant authored
Rects with a local opacity of 0 should not render. In addition, any quad with transparent color should also not render. This change eliminates the overhead of drawing the content reposition frame if it's not visible. BUG=831625 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3245005ab448a6958bc786603568431850cb1bdb Reviewed-on: https://chromium-review.googlesource.com/1007494Reviewed-by:
-
Vasilii Sukhanov authored
Bug: 730625 Change-Id: I443a7c65ef0664eb56d2cdbed090d34f667c2161 Reviewed-on: https://chromium-review.googlesource.com/1006955 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Hwanseung Lee authored
recent versions of the spec do not support 'auto' value. so before retire that value, we should check how many use it. Bug: 831550 Change-Id: I3b551ea759d05cade1e8823f3dc1c68f30b65816 Reviewed-on: https://chromium-review.googlesource.com/1007294 Commit-Queue: Hwanseung Lee <hwanseung@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#550166}
-
Michael Achenbach authored
TBR=hablich@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ia59425425955af5593c37b3c35cdfe101f4ba938 Reviewed-on: https://chromium-review.googlesource.com/1009945 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#550165}
-
Maxim Kolosovskiy authored
fields. Bug: 824793 Change-Id: I44b8fa3da4409c692eec54ecd25f2b306f27d8ba Reviewed-on: https://chromium-review.googlesource.com/1009903 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#550164}
-
Eduardo Cordeiro authored
Cleaning up usage of ChildAccountDetection experiment, replacing it with target OS checks to enforce that the feature is always enabled on ChromeOS and Android, and disabled elsewhere Bug: 795857 Change-Id: I2cd752637bc0cb5549606062c52c3b539d08677d Reviewed-on: https://chromium-review.googlesource.com/1002972Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
-
Miguel Casas authored
This CL removes the use of = {} to clear base::queues, because, for classes, zero initialization simply clears the (non-static) data members, which might leave the objects in an incorrect meta state because ctors are not called: this should not be an issue for std::queue, but it is for base::queue, which is implemented as a base::circular_deque. Nothing is crashing now, but a sibling unlanded sister CL (crrev.com/c/947341) had some issues with a similar idiom, so I'm removing it just in case. [1] http://en.cppreference.com/w/cpp/language/zero_initialization Bug: 717265 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I96af3e6475c0596f3316219bd51732e085f5e098 Reviewed-on: https://chromium-review.googlesource.com/1005917Reviewed-by:Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#550162}
-
Chris Blume authored
The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. Viz's display unittests are one such call site. BUG=759031 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I9b689e7e22971baf9596fcc42ccc7ffb28a4b7af Reviewed-on: https://chromium-review.googlesource.com/1008963 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This change: 1) Adds MenuClosureAnimationMac, which implements the Mac menu closure animation; 2) Adds logic to MenuItemView to force drawing the item in a selected or unselected state as needed, for use in this animation; 3) Adds support to MenuController for disabling handling input events, so that the closure animation can appear to be "synchronous"; 4) Makes MenuController::Accept possibly asynchronous; 5) Updates unit tests to account for (4) Bug: 829347 Change-Id: I8676718e6a5e9704b422ed4cb08e8d10002bf45a Reviewed-on: https://chromium-review.googlesource.com/999803 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Michał Pichliński authored
Without them XCode cannot compile generated projects with ICECC. Bug: 831500 Change-Id: I3b50c730660c4e8a6a06b9fda340e20edb87e40a Reviewed-on: https://chromium-review.googlesource.com/1006577Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Michal Pichlinski <mpichlinski@opera.com> Cr-Commit-Position: refs/heads/master@{#550159}
-
Matt Falkenhagen authored
This CL was speculatively reverted in r549859 to try to fix issue 831255. But the issue already disappeared in the Chrome release prior to the revert. Therefore, this CL didn't cause the issue. Original code review: https://chromium-review.googlesource.com/981845 Bug: 831255, 796819 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id76ea08d7ac158ed1958bcf9561aaf1e2c05c8ae TBR: kinuko Reviewed-on: https://chromium-review.googlesource.com/1009447Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#550158}
-
Jan Wilken Dörrie authored
This change introduces WriteWithoutResponse() on BluetoothRemoteGattCharacteristic. In contrast to the regular WriteRemoteCharacteristic() this method does not wait for a response from the operating system. For now it is only implemented on Mac, where it can result in a speedup of 8x for sending data (see https://crbug.com/808175#c9). Bug: 808175, 831524 Change-Id: If2012ac8e19d17fe218e273d8d0e300a2b06a19a Reviewed-on: https://chromium-review.googlesource.com/1000859 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#550157}
-
