GitLab

Adding a DCHECK() and a null check.

Bug: 883329
Change-Id: I56efb844c7cc6788ac04e9f494608ef18e94cd78
Reviewed-on: https://chromium-review.googlesource.com/1236454Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592817}

The current implementation of DeviceReenroller uses the incorrect
callbacks to signal when an enrollment and device sync are complete.
Specifically, the ForceEnrollmentNow() and ForceSyncNow() callbacks were
used instead of the DeviceSyncClient::Observer callbacks,
OnEnrollmentFinished() and OnNewDevicesSynced().

Here, we use to the correct callbacks along with a more appropriate and
simplified retry mechanism. Namely, the complete re-enrollment
process of enrollment --> device sync --> verification is retried every
5 minutes or until success.

Note: The OnEnrollmentFinished() and OnNewDevicesSynced() callbacks
might be invoked due to enrollments or device syncs external to the
DeviceReenroller class. Regardless of how the functions are called, the
two sets of supported software features (from GCM device info and local
device metadata) are compared. If they disagree, the re-enrollment
process is triggered.

Bug: 870770
Change-Id: If33320386cd8ce5d5639082009291b935ec6e471
Tested: Manual and unit tests
Reviewed-on: https://chromium-review.googlesource.com/1228311
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592816}

In a recent cl, https://chromium-review.googlesource.com/c/chromium/src/+/1171562,
it starts to use singleton to create AcceessibillityRecorder instance.
This causes a problem in crbug.com/883136, that because the dtor will
never be called, windowns event will still be caught and processed during
destuction period, which may randomly crash due to race condition.

This cl is to partially revert the changes to stop listening correctly
at destruction.

Bug: 883136
Change-Id: I1bd8d3e00b23590c222652c15632e33b4e3667e9
Reviewed-on: https://chromium-review.googlesource.com/1234853
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592815}

The embedder has been migrated to Custom Elements V1, so there is no
longer any need for Custom Elements V0 to register elements with
non-standard names.

Bug: 867831
Change-Id: I96a48fcf8560e08c8286081b844be93a3a630159
Reviewed-on: https://chromium-review.googlesource.com/1220036Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592814}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a6fb5c9cdd1b..fd2e62420dba


Created with:
  gclient setdep -r src-internal@fd2e62420dba

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ie7d505fac21293dd4d8d80608cb28e8755dc9607
Reviewed-on: https://chromium-review.googlesource.com/1235843Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592813}

https://chromium.googlesource.com/catapult.git/+log/985f6fe58181..5e97145328bd


git log 985f6fe58181..5e97145328bd --date=short --no-merges --format='%ad %ae %s'
2018-09-20 sadrul@chromium.org trace-viewer: Allow filtering processes.


Created with:
  gclient setdep -r src/third_party/catapult@5e97145328bd

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I53f0902ab938016d3e3c60e6638a3efbd0abf7cf
Reviewed-on: https://chromium-review.googlesource.com/1235842Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592812}

Moves functionality from content/renderer/fileapi to
blink/renderer/modules/filesystem:

- Moves most functionality in content::FileSystemDispatcher and
  content::WebFileSystemImpl into blink::FileSystemDispatcher
- Moves all functionality in content::WebFileWriterBase to
  blink::FileWriterBase
- Moves all functionality in content::WebFileWriterImpl to
  blink::FileWriter and blink::FileWriterSync
- Move web_file_writer_base_test.cc to blink
- Removes WebFileWriter, WebFileWriterClient, WebFileSystemCallbacks,
  WebFileError, WebFileInfo, WebFileSystemEntry
- Makes AsyncFileSystemCallbacks and FileSystemCallbacks use
  base::File::Error directly instead of using blink::FileError.

Bug: 787281
Change-Id: Iff0ca3e9fe20d0586709c5efbce4cd1cc79c1419
Reviewed-on: https://chromium-review.googlesource.com/1195098Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592811}

I've got an email suggesting to add a Monorail component for benchmark
startup.mobile.

I think "Speed>Metrics>SystemHealthRegressions" is the component that
best matches the bug target for startup.mobile. The description for this
component says:
    "Any performance regressions detected in the lab, in production or
     extraneous to automated tool that need a human step .."

Bug: None
Change-Id: Idf857073114886f00c4772a02643d402997ee9e1
Reviewed-on: https://chromium-review.googlesource.com/1233741Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592810}

This path has been disabled since crrev.com/c/1024703, so remove dead
code.

Bug: 882513
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2b6e076bd97b62464c3c1d9508827f7ac4be4561
Reviewed-on: https://chromium-review.googlesource.com/1234238
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592809}

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates URLDownloader and the respective unittests away
from URLFetcher.

BUG=773295

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8abfd9c9d9e66757c555479fe6a153e3dc08b9c5
Reviewed-on: https://chromium-review.googlesource.com/1234635Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#592808}

AssemblePasswordForm inside
components/password_manager/core/browser/form_parsing/form_parser.cc
currently gets a pointer to SignificantFields and checks it for being
null. However, it is never called with the pointer being null.

To clarify the code, this CL changes the AssemblePasswordForm
signature to expect a reference instead.

Bug: 883633
Change-Id: I2a81350836074ca60e925a2a0bd28b5fa0169281
Reviewed-on: https://chromium-review.googlesource.com/1235582Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592807}

Bug: 809610
Change-Id: Ib9403a5a18424fe37a7a85ab9c3b6ff90e59b614
Reviewed-on: https://chromium-review.googlesource.com/1235719Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592806}

Bug: 766206
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ifb5996a5491bde08885517ad56a539d73cf60260
Reviewed-on: https://chromium-review.googlesource.com/1235223
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592805}

This CL modifies SyncAndServicesPreferences to check off and disable
'Activity and interactions' checkbox if history sync is turned off. The
same restriction is already implemented for Autofill and Payments
checkboxes, so this CL just uses the existing pattern.

Bug: 885356
Change-Id: I40913c0c71dd1b8ad399c81b0031e623c7d74e6d
Reviewed-on: https://chromium-review.googlesource.com/1236273Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592804}

Simplify logic and code by getting rid of the secondary priority queue that was tracking the times at which ProcessRipeTasks() was scheduled, and replacing it by a simple boolean flag for each delayed task.

See https://chromium-review.googlesource.com/c/chromium/src/+/1196844/13/base/task/task_scheduler/delayed_task_manager.h#89

Change-Id: I1ea6312183eaf8fc4ce45c5d668e4e5a13506e11
Reviewed-on: https://chromium-review.googlesource.com/1230694
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592803}

Roll src/third_party/SPIRV-Tools/src/ 0cd3e599a..6e2dab2ff (3 commits)

$ git log 0cd3e599a..6e2dab2ff --date=short --no-merges --format='%ad %ae %s'
2018-09-19 chaoc Add support for Nvidia Turing extensions
2018-09-19 stevenperron Add unrolling to the legalization passes (#1903)
2018-09-17 jaebaek Specified clang-format version in README.md

Created with:
  roll-dep src/third_party/SPIRV-Tools/src

Roll src/third_party/spirv-headers/src/ dcf23bdab..d5b2e1255 (2 commits)

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/dcf23bdabacc..d5b2e1255f70

$ git log dcf23bdab..d5b2e1255 --date=short --no-merges --format='%ad %ae %s'
2018-09-19 cepheus Fix D -> d typo in previous commit.
2018-09-19 cepheus Add enumerants for six Nvidia extensions:

Created with:
  roll-dep src/third_party/spirv-headers/src

TBR=dneto@chromium.org

Change-Id: I024cb5917c5b0aaf61110a534ffa7d7b6664ab15
Reviewed-on: https://chromium-review.googlesource.com/1236373Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592802}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/79023740..08b9e376

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I0857369ad18bd563030d6f83d3ede03cd12b6743
Reviewed-on: https://chromium-review.googlesource.com/1235896Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592801}

Make ForwardingAudioStreamFactory hosting the source streams to be
aware that it's being captured by a loopback sinks. Notify loopback sinks
when the source ForwardingAudioStreamFactory (i.e. WebContents whch owns it)
is being destroyed.

Bug: 866440,852880,866442
Change-Id: I4a46952cafd378f87ceb7da4a1c1ce27341babd9
Reviewed-on: https://chromium-review.googlesource.com/1221318
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592800}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/media.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=chcunningham@chromium.org

TBR=chcunningham@chromium.org

Bug: 874080
Change-Id: If0029c7a63eb0cc35a18dbcec7c21cbdaeeaf156
Reviewed-on: https://chromium-review.googlesource.com/1191193
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592799}

These two files are unused after
https://chromium-review.googlesource.com/c/chromium/src/+/1234473

Bug: 832676
Change-Id: I216ee64cda26ba618a8b89bd8dc216aef6f567f5
Reviewed-on: https://chromium-review.googlesource.com/1236176Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592798}

https://chromium.googlesource.com/external/github.com/google/re2.git/+log/4c916c947ab7..bfe29206c269

$ git log 4c916c947..bfe29206c --date=short --no-merges --format='%ad %ae %s'
2018-09-19 junyer Crudely limit the use of . when fuzzing.

Created with:
  roll-dep src/third_party/re2/src

Bug: 884457
Change-Id: Id978d2f46c8c0fdf2017d4c3cba78b75797fd17a
Reviewed-on: https://chromium-review.googlesource.com/1235336Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592797}

Replace the remaining references to BrowserThread::PostTask with the
base::PostTaskWithTraits API.

These locations weren't covered by the global replacement patch as they
were either added recently or ignored by the script.

TBR=lazyboy@chromium.org

Bug: 878356
Change-Id: Id199777ae6bcb30ebb03b767f9cd8c6f981c6ac4
Reviewed-on: https://chromium-review.googlesource.com/1235727
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592796}

This updates the closures and callbacks to use the "Once"
paradigm as per the style guide/presubmission warnings.
All of the instances were switched over to "Once".

Bug: 884057
Change-Id: I93a63e79c6e142051a80eea433f29239a1f3b28d
Reviewed-on: https://chromium-review.googlesource.com/1234217
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592795}

ProfileOAuth2TokenService has a corner case wherein during startup,
it can fire token removal notifications for accounts for which it has
never previously filed a token available notification. IdentityManager
currently swallows such notifications. However, as we streamline
IdentityManager to be just a straight pass-through to its backing
classes (crbug.com/883722), IdentityManager will no longer be able
to detect this case (because it won't be maintaining any cached info
from the token available notifications).

This CL makes the behavioral change of having IdentityManager always
pass on token removal notifications from ProfileOAuth2TokenService.
The behavioral impact is that consumers of
IdentityManager::Observer::OnRefreshTokenRemovedForAccount() will now
see a removal notification in the corner case described above. However,
all such consumers were previously consumers of
ProfileOAuth2TokenService::Observer::OnRefreshTokenRevoked() before
their conversion and hence were previously seeing the removal
notification in this corner case. Thus, the behavioral change does
not seem to have a concrete impact on consumers one way or the other.

Bug: 883722
Change-Id: I131ad8dbe12d73772845fd2eb565cd3477779c36
Reviewed-on: https://chromium-review.googlesource.com/1225878Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592794}

There are a few reports on esoteric android devices where
getApplicationRestrictions may throw SecurityException even though it is
not documented behavior. Just ignore them.

Bug: 886814
Change-Id: Ife0c91f3516ec022912bfb2dc99cfc69ba25f186
Reviewed-on: https://chromium-review.googlesource.com/1235118Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592793}

ModelTypeController assumes that the user must be signed in by the time
a datatype gets started. This however doesn't hold true for local sync,
so we relax the requirement.

Some datatypes have similar requirements in their bridge
implementations, so we disable those datatypes for local sync.

The patch introduces first browser tests for local sync, which would
have caught such a basic issue.

Bug: 887250
Change-Id: I1bca79478958ac64ee5502e4795f8619ee50e85c
Reviewed-on: https://chromium-review.googlesource.com/1235935
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592792}

R=futhark@chromium.org

Bug: 641877
Change-Id: I5f12db2690ec02248cb0533b2f18da2613afea98
Reviewed-on: https://chromium-review.googlesource.com/1235723
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592791}

https://pdfium.googlesource.com/pdfium.git/+log/109aa6d0f673..dd92aa594625


git log 109aa6d0f673..dd92aa594625 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 thestig@chromium.org Fix misc lint errors and other cleanups.


Created with:
  gclient setdep -r src/third_party/pdfium@dd92aa594625

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I810c9319884a00aea8b64b4ef440ea5e3cd87183
Reviewed-on: https://chromium-review.googlesource.com/1235841Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592790}

Remember the last call to SetOutputIsSecure, and apply the information
when the compositor is configured, or if the gpu process crashes.

Bug: 882519
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Id212aaae3b2c164575c1d8e92e93e623bd182d69
Reviewed-on: https://chromium-review.googlesource.com/1225290
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592789}

R=futhark@chromium.org

Bug: 641877
Change-Id: I0b4dc43b29f7e30dbc3eab89f22ffa5505e6a333
Reviewed-on: https://chromium-review.googlesource.com/1235999
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592788}

This Options object will soon need to carry information that
ValueForCustomProperty needs to act upon. Specifically, it
needs to know whether the resolved CSSVariableData should be
stored on the ComputedStyle before returning.

Also, since the Options object is now available here, let
ValueForCustomProperty return nullptr if a variable is disallowed.
This avoids an extra PropertyRegistation lookup at one of the
callsites.

R=futhark@chromium.org

Bug: 641877
Change-Id: I85f51ff23d23ab404f6fc133e2017f70dd5aea03
Reviewed-on: https://chromium-review.googlesource.com/1235721
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592787}

Original CL intention was:
This CL uses ScopedBlockingCall to mark blocking calls in /chromeos/binder.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=satorux@chromium.org

Bug: 874080
Change-Id: Ia8c04385530dbaefee972c8ebffc46c1ec627aa3
Reviewed-on: https://chromium-review.googlesource.com/1191246
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592786}

In this CL, we reuse hashset that control all the assigned slots
in the shadowroot for each node, added previous CL.
Thanks to the hashset we can find the assigned slot for each
node in O(1) order, instead of searching all the slot for each
shadow root when we call slot change event.

We will improve this implementation in another CL.

Result of perftests:
https://pinpoint-dot-chromeperf.appspot.com/job/151f9a47640000

Previous implementation CL: crrev.com/c/1179555

See design doc at
https://docs.google.com/document/d/1n2iDNkI5bF4B5eefxa0SRSyS_RVchvTNSqezvA4PyF4/edit?usp=sharing

Bug: 869308
Change-Id: I96fc4c50d9083eca199c7849db0097e73436983d
Reviewed-on: https://chromium-review.googlesource.com/1201513
Commit-Queue: Kyoko Muto <kymuto@google.com>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592785}

In the near future, it will be necessary for ValueForCustomProperty
to return a CSSVariableData which may not be stored elsewhere. This
is because we need to do a "non-destructive" pre-resolve of registered
custom properties that are used before high priority properties are
applied.

R=futhark@chromium.org

Bug: 641877
Change-Id: Idb1ab4ba7aae77187a4fd86877a0246e56fc82a4
Reviewed-on: https://chromium-review.googlesource.com/1235936Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592784}

Using the appropriate type gets rid of a checked cast and a truncation.

BUG=879657

Change-Id: I30e6aa1f28ebcd6e245a95a8662a212e72986829
Reviewed-on: https://chromium-review.googlesource.com/1234016
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592783}

Bug: 807330
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I988192d63f2189524b86c5ccd40f64fe42aebf40
Reviewed-on: https://chromium-review.googlesource.com/1228515
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592782}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ecfe498c1a1a..a6fb5c9cdd1b


Created with:
  gclient setdep -r src-internal@a6fb5c9cdd1b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ic06aaab2918f506b88ea657707e4b4b3cc8c84f9
Reviewed-on: https://chromium-review.googlesource.com/1235840Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592781}

This change reads the original intent, looks for parameters that are
meant for Autofill Assistant and allow scripts to check these in
preconditions.

Bug: 806868
Change-Id: I8bd6b51cf281d1f21ce2ccf6128b7345290cab0a
Reviewed-on: https://chromium-review.googlesource.com/1225696
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592780}

This CL allows cleaning of blacklisted duplicates for iOS platform.

Bug: 862930
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I44e9fb90181781c261760ac0d933f8917b7d2910
Reviewed-on: https://chromium-review.googlesource.com/1233234Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Narcis Gemene <gemene@google.com>
Cr-Commit-Position: refs/heads/master@{#592779}

This reverts commit f6a8902e.

Reason for revert: relanding with lto for android disabled until
things are sorted out.

Original change's description:
> Revert "Roll clang 340925:342523."
> 
> This reverts commit 34893e97.
> 
> Reason for revert: New failures on Android in computeKnownBits(), looks like an LTO problem. http://crbug.com/887272
> 
> Original change's description:
> > Roll clang 340925:342523.
> > 
> > Ran `tools/clang/scripts/upload_revision.py 342523`.
> > 
> > Bug: 880827
> > Change-Id: I8f747ab4a2de74a0f0b4b5a201d37e111f323077
> > Reviewed-on: https://chromium-review.googlesource.com/1232590
> > Reviewed-by: Reid Kleckner <rnk@chromium.org>
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#592531}
> 
> TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org
> 
> Change-Id: Idee414178ab15058aa080f670585cee81e0f8ac5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 880827
> Reviewed-on: https://chromium-review.googlesource.com/1236003
> Reviewed-by: Egor Pasko <pasko@chromium.org>
> Commit-Queue: Egor Pasko <pasko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592765}

TBR=pasko@chromium.org,thakis@chromium.org,hans@chromium.org,rnk@chromium.org

Change-Id: I26ea97e83cfebcec0670e79683fe0db7f993c1a7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 880827
Reviewed-on: https://chromium-review.googlesource.com/1236174
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592778}