GitLab

In case marking is in progress, first stop concurrent markers and
then cancel compaction.
If marking is not in progress, compaction should not have been
initialized yet, so it suffices to confirm that compaction is disabled.

Bug: 1058777
Change-Id: I8f9c6e2c461a6d933d56a7e39c18cbd09e6a40f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089873
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747364}

This CL prevents media notifications from unfreezing if they are still
waiting on new MediaSessionActions. This prevents an issue where
notifications would change sizes briefly because they had no actions to
show.

Bug: 1055254
Change-Id: I2345188626b332846a7b51c93545a1b40764044e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090291Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747363}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: I6b2c51ab3f3ac138855695a6b21e6e730a5c3466
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089403Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747362}

https://skia.googlesource.com/skia.git/+log/d2f18734aa84..2dbcbe8b12e8

git log d2f18734aa84..2dbcbe8b12e8 --date=short --first-parent --format='%ad %ae %s'
2020-03-05 robertphillips@google.com Loosen up SkSurface_Gpu::onIsCompatible a bit wrt FBO0-ness
2020-03-05 kjlubick@google.com [infra] Update node to 12.16.1
2020-03-05 nifong@google.com Name name changes suggested in API review

Created with:
  gclient setdep -r src/third_party/skia@2dbcbe8b12e8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC herb@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: herb@google.com
Change-Id: I4bcb0be347043b89cbbcec984f87bbf2752f66dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090212Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747361}

This change removes BulkLeakCheckData and kBulkLeakCheckDataKey from the
BulkLeakCheckAdapter. The attached UserData is not required to mark
saved passwords as compromised.

Bug: 1047726
Change-Id: I3a5c60da160a7d7f42146abb1d5b5f0cc84e929e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089892Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747360}

The "Failed to add Windows firewall rules" message shows up when running
tests as non-admin. This error is usually benign but looks like a
failure so it causes confusion when investigating test failures. The
message can be avoided by not trying to add firewall rules when this is
guaranteed to fail (when running as non-admin).

Change-Id: I0980529d3b289f99444d7b2f7ca99440432cefaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088533
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747359}

After NSOOP_chrome_public_test_apk is also switched to playstore image, it is
more clear to see the failed tests that are common to both test_suites,
and android-pie-arm64-rel

Bug: 1046059
Change-Id: I605ad36c71b5c08bf13b34a2050b2a28319976d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085848Reviewed-by: John Budorick <jbudorick@chromium.org>
Auto-Submit: Haiyang Pan <hypan@google.com>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#747358}

When the Windows compatibility mode is turned on, ::GetVersionEx()
returns a simulated OS version instead of the real OS version.  As a
result, InterceptionManager selects a wrong thunk resolver, incorrectly
patches ntdll's functions, and thus the process crashes when one of
those incorrectly-patched functions are executed.

The proposed fix is to use OSInfo::Kernel32Version() which returns
the real OS version even with the compat mode to select a thunk
resolver.

Bug: 1053805

Test: Run 32-bit chrome.exe on 32-bit Windows 10 or 8.1 with the compat
mode setting to Windows 7.  Please note that the crash does not happen
if you run chrome.exe on 64-bit OS.

R=wfh@chromium.org

Change-Id: Id39a11288cc64ff5552de0a6a273231bdeb2eeff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080785Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747357}

Bug: 1058598
Change-Id: I37c233c9fd0aca75be049a2e9ce21498b7ecb7c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088671
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747356}

This change adds a temporary workaround to effectively revert the
following changes. While the long term fix for this bug has landed, it
might be too risky to merge to M81. So this change reverts enabling of
AImageReader on these GPUs, to restore the behaviour prior to M80.

Reverted changes:
https://chromium-review.googlesource.com/c/chromium/src/+/2015553
https://chromium-review.googlesource.com/c/chromium/src/+/1873393

TBR=nyquist@chromium.org
R=dalecurtis@chromium.org

Bug: 1051705
Change-Id: I2f7f0828c8ba4a7279c2f6bb95de449402d88f92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087987
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747355}

The UI now offers the possibility to bypass DLP warnings via buttons in
the dialog. The button interactions are tested via a browser test.

This involves a few refactors:
- DeepScanUploadStatus becomes DeepScanningFinalResult in order to
  clearly represent what to show the user.
- There is now a 4th DeepScanningDialogStatus to represent bypassable
  warnings.
- The callback to allow/deny a paste/upload/drag is delayed in the
  warning case.
- The "Cancel" override in DeepScanningDialogViews is replaced by using
  set_cancel_callback instead since the virtual method approach is
  deprecated.

Bug: 1044290
Change-Id: I477db8ba06dec26dc12ebc17fdfce94d019787d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072584
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747354}

Follow-up CL to crrev.com/c/2083571 to remove confusing
flips_vertically.

Bug: 1051970
Change-Id: Ic260d7b48747d70f41937cba4fec38c8bb943a78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087417Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747353}

https://swiftshader.googlesource.com/SwiftShader.git/+log/a095711c5d77..51b2800bb317

git log a095711c5d77..51b2800bb317 --date=short --first-parent --format='%ad %ae %s'
2020-03-05 capn@google.com Support launching PowerVR samples from Visual Studio using SwiftShader

Created with:
  gclient setdep -r src/third_party/swiftshader@51b2800bb317

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Ie79b6461aa9c2c778cdedb03e51f6d3d7bc8383f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090076Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747352}

Using codecs.open() results in a CR at the end of every product name's string.
E.g.

    static const UsbProduct vendor_0001_products[] = {CRLF
      {0x7778, "Counterfeit flash drive [Kingston]CR
    "},CRLF
    };CRLF

Use io.open() instead, which works as expected on both Python 2 and 3.

Bug: 1058804
Change-Id: I3d77df0a248ccab57e1980a09977cf87720e5714
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089696
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#747351}

(Re-land of https://chromium-review.googlesource.com/c/chromium/src/+/1997306)

This CL creates AllWebStateListObservationRegistrar, which can be used
in any case when an object needs to observe all web state lists for a
given BrowserState.

This is a generalized version of the snapshot cache tab model observer,
which this replaces.

For cases where only regular or OTR browsers' WebStateLists should be
observed, AllWebStateListObservationRegistrar has an optional param that
can be set at creation time.

To avoid circular dependencies, one target in web_state_list/ had to
be split from the main target (hence the scattershot BUILD.gn updates).

Bug: 1050148
Change-Id: I3940e2ddf5829e3f70fbc759c7c57220aaadfaef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087620
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747350}

Previously the Assistant was enabled but failed to start because they
are not linked with Gaia.

Bug: 1056717
Change-Id: I922822ed16bd8c33b88f85061c09859c564f5737
Tests: Manual and new unittest.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088534Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/master@{#747349}

This reverts commit e8d50869. It is not a
complete revert, but only removes the skipping bit in TestExpectations.
The previously failing test (external/wpt/html/webappapis/scripting/
processing-model-2/integration-with-the-javascript-job-queue/promise-job-
entry-different-function-realm) now always passes after a recent V8 roll,
so an -expected.txt is no longer needed.

Reason for revert: CL 2071624 has been relanded in V8 as
92a2f0c703a6dbbffc2dc83a92c26c24f78c9ec2 and rolled into Chromium.

Original change's description:
> Temporarily disable promise entry realm test
>
> This is necessary to land CL 2071624 in V8.
>
> Bug: v8:10200
> Change-Id: I48c7ad881c060ad161417cd78fdbac8aba8a77ad
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082112
> Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Auto-Submit: Timothy Gu <timothygu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745789}

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel

Bug: v8:10200
Change-Id: Id041c97d5d0286e190b508e39a14f36459963835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087697
Commit-Queue: Timothy Gu <timothygu@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747348}

Also reland "Restore End-To-End test on ChromeOS"
initially reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/2074882
reverted on https://chromium-review.googlesource.com/c/chromium/src/+/2074882

Bug: 1058022
Change-Id: I6766dd944a5807a77087fed240e18766af60e880
Fixed: 1054935, 1058081, 1058582, 1057814, 1057777
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087821Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747347}

crrev.com/c/2084725 moved the timeout adjustment logic to the browser
side while keeping the old behaviour to make internal android source
happy. This removes the old behaviour.

Fixed: 976428
Change-Id: I2c6acb06f3efc6c4efbfc917b06a06603b81e7e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090091
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747346}

* Simplify AshTestHelper::SetUp() API use by making InitParams arg
  optional
* Rename AshTest*::CurrentContext() to GetContext() to match Views
  helper class API names
* Minor cleanups to ChromeViewsTestBase
* NULL -> nullptr to silence presubmit

Bug: none
Change-Id: If55b08d31a3d244852d3e7aab73e4270e94cde5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088734Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747345}

BUG: 1046814

Change-Id: I704099fce2d703f964d16be46f8a7c4c0be07e78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954671Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747344}

Change-Id: Ib82dc3a17382d8f20d0ccf0d840ff7f6bc4b606c
Bug: 1052460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088404
Commit-Queue: benjamin joyce <bjoyce@google.com>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747343}

Bug: 1050703
Change-Id: I09b9c20f631a6dda0a424790ac7f55ada0f144d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056947
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747342}

https://android.googlesource.com/platform/external/perfetto.git/+log/7c0409aa3814..f365c53a18b1

git log 7c0409aa3814..f365c53a18b1 --date=short --first-parent --format='%ad %ae %s'
2020-03-05 taylori@google.com Merge "perfetto-ui: Fix counter quantization"

Created with:
  gclient setdep -r src/third_party/perfetto@f365c53a18b1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I9f1496de8f76cf68115b362d70f759719d2ea452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090074Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747341}

Plumbs a Browser into BookmarkHomeViewController and BookmarkInteractionController.

This removes explicit passing of BrowserState, WebStateList and Dispatcher
into these classes.

Unit tests are also updated, including fixing incorrectly named members
in the Bookmarks test superclass.

Bug: 1057116, 1057121
Change-Id: Ifdf674c76dc3d449f49ef22d48a4bdc4c8ffceec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087921
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747340}

This moves the error label a bit down in the SAML smart card PIN dialog,
in conformance to the UI feedback.

As was clarified by the designers, the padding should be 4px to the
upper bound of the text box, not to the upmost pixel of the font.
Conceptually, the error message should look centered between the input
field and the keypad below.

This CL moves the error label by 3 pixels downwards, in accordance to
this corrected understanding of the requirements.

Bug: 1024251
Test: start SAML login via a smart card, proceed to PIN dialog, take a screenshot, verify the distance
Change-Id: I3e2aa96151254595424010e4db33673f5ddd0d31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089757Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747339}

Before Change:
View depends on ChromeActivity, ActivityWindowAndroid,
ContentView.

After Change:
View no longer depends on them.

Change:
Move the dependencies into Coordinator.

Bug: 1058844

Change-Id: Ifb8653855111d4d2fcf7ece0436fa466543f4ca0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089972
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747338}

https://dawn.googlesource.com/dawn.git/+log/2de34c1791f3..56f1678437ba

git log 2de34c1791f3..56f1678437ba --date=short --first-parent --format='%ad %ae %s'
2020-03-05 david.turner.dev@gmail.com Vulkan: Enforce fixed subgroup size for compute shaders.
2020-03-05 david.turner.dev@gmail.com Vulkan: Report and enable subgroup size control device extension.

Created with:
  gclient setdep -r src/third_party/dawn@56f1678437ba

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I9f48a7973e626b96d1088b0b916745f02c70769b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090072Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747337}

Bug: 1058599
Change-Id: I80f0396a7d43ad2e5c2ffcf93165544391c4c801
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089671
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#747336}

It uses solid color layer and full size texture for the border right
now. Since there is texture for the border, just paint the background so
that when we do layer opacity, there is no render pass.

ui.OverviewDragPerf.drag_to_snap 53.5ms -> 52ms
ui.DragWindowFromShelfPerf (WIP) 52ms -> 51ms

So not that much gains, but code is also simpler.

Test: manual
Bug: 1024679
Change-Id: Id5554c25cd69e42e31f97c8426b2ceec78f3fd2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087349
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747335}

Bug: 911427
Change-Id: Ib3ffd449c8772ac7993b861255c5ecc6ebcb55e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087499
Auto-Submit: Rob Schonberger <robsc@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747334}

Sync on style before evaluating a pseudo-element selector other than null.
Remove manual style syncs from pseudo-element animation wpt tests.

Bug: 1057101
Change-Id: I8a1184221f40c7546ac5179615f0d6541e8729e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083715Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: George Steel <gtsteel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747333}

Issue:
In case a new_profile is mergeable with one of the existing_profiles,
AutofillProfileComparator::MergeProfile inadvertently ends up
modifying the existing profile directly as part of the merge by
calling AutofillProfile::SaveAdditionalInfo on them. These modified
profiles are then added to merged_profiles which is the out parameter.
So at this point there is no diff between the merged_profiles and the
existing_profiles that we passed. Later when we compare the two (in
PersonalDataManager::SetProfiles), since there is no diff, we end up
not writing the updates to the DB.

Fix:
We instead pass a const ref to AutofillProfileComparator::MergeProfile
so that we don't end up modifying the original set of profiles and
work on a copy of them. This ensures that we capture the updates in
case of a merge and write it to the web DB.

R=battre@chromium.org

Bug: 1057041
Change-Id: Idcabbd9549dc2f8a3dfec582194fd316818c654d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087297Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Siddharth Sharma <siddhash@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#747332}

https://webrtc.googlesource.com/src.git/+log/3c91b31162b8..b05ca4b6168c

git log 3c91b31162b8..b05ca4b6168c --date=short --first-parent --format='%ad %ae %s'
2020-03-05 orphis@webrtc.org Implement new specification for degradation preference

Created with:
  gclient setdep -r src/third_party/webrtc@b05ca4b6168c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ice79f35e77f79b0225b738a4395ca58f75597e59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090071Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747331}

Credential leak dialog is component in development and it is forked
so experimental code with password change can be introduced without
affecting component. When password change from leaked warning prototype
finished it will be merged with main component.

Bug: 1053522

Change-Id: If105bdd40e46e2a92a2a2f9589b377679299141b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080233
Commit-Queue: Milica Selakovic <selakovic@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747330}

Bug: 1048653

Change-Id: Ia3c19908bb49194c4f4bda98b8316176b29a5e9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090231
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747329}

This TabHelper will observe WebStateObserver and record page sessions
while its WebState is the active WebState (i.e. it is visible on the
screen). When a new page is navigated to, the app backgrounds, or if
the WebState is destroyed, the recording will stop and a UKM will be
logged for the page session duration.A new IOS.PageNavigation UKM will
be logged for every navigation completion.

Bug: 1006357
Change-Id: I9c7184a1cc3d8f9ff1a39f34f3363a388738e82a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068244
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747328}

In unit tests, it turns out that the AtomicFlag may still be stuck to
its previous sequence. Detach it in UnsafeResetForTesting to avoid that.

Change-Id: I34b2e4953424c5aebd6ec55c8b13086617a16098
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089759Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747327}

Non-functional changes:

* Add browser test boilerplate for testing the <security-token-pin>
  Polymer element.
* Add a test that an 8-character PIN fits into the input field
  (which tests the functionality initially added in
  https://crrev.com/c/2069324);
* Add a test that the letter-spacing attribute doesn't fall back to the
  default value (which tests the regression that was fixed in
  https://crrev.com/c/2082378);

Functional changes:
* Reduce the interval between the dots by one pixel, so that 8 dots
  actually fit into the input field (the interval used before this CL
  turned out to be exceeding the input width by 1 pixel).

Bug: 1051859
Change-Id: If93757b19806067e29718e00c64f4ce5549931a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081420Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747326}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4b1eadeb..fbadeeaf

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iec9ca3c5afbacda564fa9f48919b31667be03f1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089399Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747325}